[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308959#comment-14308959 ] Hudson commented on HADOOP-11463: - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #96 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/96/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309020#comment-14309020 ] Hudson commented on HADOOP-11463: - FAILURE: Integrated in Hadoop-Yarn-trunk #830 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/830/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309181#comment-14309181 ] Hudson commented on HADOOP-11463: - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #93 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/93/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309207#comment-14309207 ] Hudson commented on HADOOP-11463: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2028 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2028/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307354#comment-14307354 ] Hudson commented on HADOOP-11463: - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #96 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/96/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307395#comment-14307395 ] Hudson commented on HADOOP-11463: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2046 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2046/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307131#comment-14307131 ] Steve Loughran commented on HADOOP-11463: - s3 test suites against S3 EU all passed +1 Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307138#comment-14307138 ] Hudson commented on HADOOP-11463: - FAILURE: Integrated in Hadoop-trunk-Commit #7019 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7019/]) HADOOP-11463 Replace method-local TransferManager object with S3AFileSystem#transfers. (Ted Yu via stevel) (stevel: rev 4e7ad4f0a88bd36bc91db6b1bd311d7f5c6bebee) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Fix For: 2.7.0 Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291907#comment-14291907 ] Ted Yu commented on HADOOP-11463: - Is there any review comment that I haven't addressed, [~ste...@apache.org] ? Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Components: fs/s3 Affects Versions: 2.7.0 Reporter: Ted Yu Assignee: Ted Yu Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch, hadoop-11463-003.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281506#comment-14281506
]
Hadoop QA commented on HADOOP-11463:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12692927/hadoop-11463-003.patch
against trunk revision 2908fe4.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-tools/hadoop-aws.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5423//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5423//console
This message is automatically generated.
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Components: fs/s3
Affects Versions: 2.7.0
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch,
hadoop-11463-003.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281479#comment-14281479
]
Steve Loughran commented on HADOOP-11463:
-
I had a look at the other {{FileSystem}} classes -afraid you must also call
{{super.close()}} for its cleanup work
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Components: fs/s3
Affects Versions: 2.7.0
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280258#comment-14280258
]
Steve Loughran commented on HADOOP-11463:
-
-1
I want one minor change, which is the {close()}} operation must check for
transfers != null before doing its work. There's some stuff done in the
{{initialize()}} method before the field is assigned, so there's a risk that if
something went wrong there, close() would fail.
Once that's done I'll approve the patch
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280421#comment-14280421
]
Hadoop QA commented on HADOOP-11463:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12692782/hadoop-11463-002.patch
against trunk revision 000ca83.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-tools/hadoop-aws.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5417//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5417//console
This message is automatically generated.
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Components: fs/s3
Affects Versions: 2.7.0
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch, hadoop-11463-002.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278448#comment-14278448 ] Thomas Demoor commented on HADOOP-11463: [~ste...@apache.org] shutDown terminates immediately. In-process transfers are abandoned. For regular uploads, S3 simply discards the object. However, for multi-part uploads, parts that were completely uploaded are stored (and paid for) forever and the multi-part upload is in progress. The purging functionality alleviates this. If fs.s3a.multipart.purge == true, the constructor of S3AFileSystem aborts all in process multi-part uploads older than fs.s3a.multipart.purge.age seconds (this protects active multi-part uploads). [~tedyu] Yeah, that was to be expected. See comment 2 in the description above. Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Reporter: Ted Yu Assignee: Ted Yu Attachments: hadoop-11463-001.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277750#comment-14277750
]
Ted Yu commented on HADOOP-11463:
-
Without the patch, I observed the following exception in test
(fs.s3a.multipart.purge being true):
{code}
testRenameFileAsExistingFile(org.apache.hadoop.fs.s3a.TestS3AFileSystemContract)
Time elapsed: 1.944 sec ERROR!
java.util.concurrent.RejectedExecutionException: Task
java.util.concurrent.FutureTask@14b43b9c rejected from
java.util.concurrent.ThreadPoolExecutor@44b58962[Terminated, pool size = 0,
active threads = 0, queued tasks = 0, completed tasks = 0]
at
java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2048)
at
java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:821)
at
java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1372)
at
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:132)
at
com.amazonaws.services.s3.transfer.internal.UploadMonitor.init(UploadMonitor.java:129)
at
com.amazonaws.services.s3.transfer.TransferManager.upload(TransferManager.java:449)
at
com.amazonaws.services.s3.transfer.TransferManager.upload(TransferManager.java:382)
at
org.apache.hadoop.fs.s3a.S3AOutputStream.close(S3AOutputStream.java:125)
at
org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:72)
at
org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:101)
at
org.apache.hadoop.fs.FileSystemContractBaseTest.createFile(FileSystemContractBaseTest.java:484)
at
org.apache.hadoop.fs.s3a.TestS3AFileSystemContract.testRenameFileAsExistingFile(TestS3AFileSystemContract.java:68)
{code}
The above is fixed by patch.
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277087#comment-14277087 ] Ted Yu commented on HADOOP-11463: - With HADOOP-10714, the upper bound on un-transferred objects is 1000. Meaning, the wait for closing S3AFileSystem would be short. Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Reporter: Ted Yu Assignee: Ted Yu Attachments: hadoop-11463-001.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276902#comment-14276902
]
Steve Loughran commented on HADOOP-11463:
-
Looks good, but one question:
Will the FS shutdown() operation block until transfers have finished? I've hit
problems in HDFS where the client blocks due to connection retries, so the a
client app blocks on a control-C-initiated shutdown —as that is when
{{FileSystem}} tries to shutdown all its instances.
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[ https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270852#comment-14270852 ] Thomas Demoor commented on HADOOP-11463: This addresses my remarks. I have run the tests vs AWS S3 and all passed. LGTM Replace method-local TransferManager object with S3AFileSystem#transfers Key: HADOOP-11463 URL: https://issues.apache.org/jira/browse/HADOOP-11463 Project: Hadoop Common Issue Type: Task Reporter: Ted Yu Assignee: Ted Yu Attachments: hadoop-11463-001.patch This is continuation of HADOOP-11446. The following changes are made according to Thomas Demoor's comments: 1. Replace method-local TransferManager object with S3AFileSystem#transfers 2. Do not shutdown TransferManager after purging existing multipart file - otherwise the current transfer is unable to proceed 3. Shutdown TransferManager instance in the close method of S3AFileSystem -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11463) Replace method-local TransferManager object with S3AFileSystem#transfers
[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266489#comment-14266489
]
Hadoop QA commented on HADOOP-11463:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12690381/hadoop-11463-001.patch
against trunk revision 4cd66f7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-tools/hadoop-aws.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5368//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5368//console
This message is automatically generated.
Replace method-local TransferManager object with S3AFileSystem#transfers
Key: HADOOP-11463
URL: https://issues.apache.org/jira/browse/HADOOP-11463
Project: Hadoop Common
Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Attachments: hadoop-11463-001.patch
This is continuation of HADOOP-11446.
The following changes are made according to Thomas Demoor's comments:
1. Replace method-local TransferManager object with S3AFileSystem#transfers
2. Do not shutdown TransferManager after purging existing multipart file -
otherwise the current transfer is unable to proceed
3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
