[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624765#comment-14624765
]
Steve Loughran commented on HADOOP-11492:
-
Did this get backported to branch-2? As there's now some dependency
declarations on ${curator.version} alongside previous imports of
curator-framework and curator-test version 2.6.0:
[https://github.com/apache/hadoop/blob/branch-2/hadoop-project/pom.xml#L930]
Either it wasn't completely applied, or branch-2 develop had already diverged
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Arun Suresh
Fix For: 2.7.0
Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch,
hadoop-11492-3.patch, hadoop-11492-3.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355204#comment-14355204 ] Steve Loughran commented on HADOOP-11492: - Sean: you want this in the incompatible section? The other option: and it is maybe possible, is see if we can back out of this change for now. YARN-2716 hasn't gone in yet. HADOOP-11612 shows that with this dependency, Hadoop is now internally inconstent w.r.t guava versions. though if we back it out of 2.7; we'll effectively have to do the same for the rest of the 2.x line, until the classloader problem gets fixed... Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355506#comment-14355506 ] Karthik Kambatla commented on HADOOP-11492: --- Thanks for drafting it, [~busbey]. Just marked it an incompatible change and copied your notes to Release Notes. I am not sure how these release notes actually show up in the release notes of the release, but will follow up at 2.7 release time. PS: I can't wait for us to isolate classpaths. Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355479#comment-14355479
]
Sean Busbey commented on HADOOP-11492:
--
I don't think backing out is needed, unless we plan to keep the curator version
fixed to 2.6 for the life of branch-2. None of these issues are things the
Curator project can fix in the 2.y line without further breakage.
I'd love to see it in the incompatible section, preferably with a reference to
the compat guideline that points out downstream doesn't get a guarantee on
dependencies. something like
{quote}
=Apache Curator version change
Hadoop has updated the version of Apache Curator used from 2.6.0 to 2.7.1. This
change should be binary and source compatible for the majority of downstream
users. Notable exceptions:
* Binary incompatible change:
org.apache.curator.utils.PathUtils.validatePath(String) changed return types.
Downstream users of this method will need to recompile.
* Source incompatible change:
org.apache.curator.framework.recipes.shared.SharedCountReader added a method to
its interface definition. Downstream users with custom implementations of this
interface can continue without binary compatibility problems but will need to
modify their source code to recompile.
* Source incompatible change:
org.apache.curator.framework.recipes.shared.SharedValueReader added a method to
its interface definition. Downstream users with custom implementations of this
interface can continue without binary compatibility problems but will need to
modify their source code to recompile.
Downstream users are reminded that while the Hadoop community will attempt to
avoid egregious incompatible dependency changes, there is currently no policy
around when Hadoop's exposed dependencies will change across versions (ref
http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html#Java_Classpath).
{quote}
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Arun Suresh
Fix For: 2.7.0
Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch,
hadoop-11492-3.patch, hadoop-11492-3.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354386#comment-14354386 ] Sean Busbey commented on HADOOP-11492: -- Can we release note this change? Curator ends up in our classpath for downstream folks and [Curator 2.6.0 - 2.7.1 has a binary incompatible change|http://people.apache.org/~busbey/compat_reports/curator/2.6.0_to_2.7.1/compat_report.html] (it's minor and not something they can undo safely) Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307272#comment-14307272 ] Hudson commented on HADOOP-11492: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2027 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2027/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java * hadoop-common-project/hadoop-common/CHANGES.txt Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307303#comment-14307303 ] Hudson commented on HADOOP-11492: - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #92 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/92/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307349#comment-14307349 ] Hudson commented on HADOOP-11492: - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #96 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/96/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307390#comment-14307390 ] Hudson commented on HADOOP-11492: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2046 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2046/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java * hadoop-common-project/hadoop-common/CHANGES.txt Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307022#comment-14307022 ] Hudson commented on HADOOP-11492: - FAILURE: Integrated in Hadoop-Yarn-trunk #829 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/829/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306995#comment-14306995 ] Hudson commented on HADOOP-11492: - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #95 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/95/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304858#comment-14304858 ] Steve Loughran commented on HADOOP-11492: - +1 Little used JAR; jenkins should have found where things break; Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305948#comment-14305948 ] Karthik Kambatla commented on HADOOP-11492: --- Checking this in. Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306084#comment-14306084 ] Hudson commented on HADOOP-11492: - FAILURE: Integrated in Hadoop-trunk-Commit #7007 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7007/]) HADOOP-11492. Bump up curator version to 2.7.1. (Arun Suresh and Karthik Kambatla via kasha) (kasha: rev 55235d28c3641ff5f1c05c53dd7271cafc131926) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java * hadoop-project/pom.xml Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Arun Suresh Fix For: 2.7.0 Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch, hadoop-11492-3.patch, hadoop-11492-3.patch Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304228#comment-14304228
]
Hadoop QA commented on HADOOP-11492:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12696294/hadoop-11492-3.patch
against trunk revision c559df2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5571//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5571//console
This message is automatically generated.
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch,
hadoop-11492-3.patch, hadoop-11492-3.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287498#comment-14287498
]
Hadoop QA commented on HADOOP-11492:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693882/hadoop-11492-2.patch
against trunk revision 786dbdf.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5452//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5452//console
This message is automatically generated.
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288741#comment-14288741
]
Hadoop QA commented on HADOOP-11492:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12694040/hadoop-11492-3.patch
against trunk revision 5f124ef.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1291 javac
compiler warnings (more than the trunk's current 1207 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
23 warning messages.
See
https://builds.apache.org/job/PreCommit-HADOOP-Build/5461//artifact/patchprocess/diffJavadocWarnings.txt
for details.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.ha.TestZKFailoverControllerStress
The following test timeouts occurred in
hadoop-common-project/hadoop-common:
org.apache.haTests
org.apache.haTests
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5461//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5461//artifact/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5461//console
This message is automatically generated.
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch,
hadoop-11492-3.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288466#comment-14288466
]
Arun Suresh commented on HADOOP-11492:
--
Hey [~kasha], Looks like a minor issue in your {{incrSharedConter()}} method
(you should be calling trySetCount on {{sharedCount}} not
{{delTokSeqCounter}}).. also dont think you need to do a
sharedCount.getCount().. since you already have the versionedValue which has
the count.
Also I guess the new Curator library handles paths a bit differently.. guess we
need to modify the following :
{noformat}
private static final String ZK_DTSM_SEQNUM_ROOT = /ZKDTSMSeqNumRoot;
private static final String ZK_DTSM_KEYID_ROOT = /ZKDTSMKeyIdRoot;
private static final String ZK_DTSM_TOKENS_ROOT = /ZKDTSMTokensRoot;
private static final String ZK_DTSM_MASTER_KEY_ROOT = /ZKDTSMMasterKeyRoot;
{noformat}
And in the testcase, the leading path must be removed too :
{noformat}
conf.set(ZKDelegationTokenSecretManager.ZK_DTSM_ZNODE_WORKING_PATH,
testPath);
{noformat}
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283720#comment-14283720
]
Hadoop QA commented on HADOOP-11492:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693278/hadoop-11492-1.patch
against trunk revision c94c0d2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1206 javac
compiler warnings (more than the trunk's current 1204 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5433//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5433//artifact/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5433//console
This message is automatically generated.
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-11492-1.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283649#comment-14283649 ] Steve Loughran commented on HADOOP-11492: - Does it still work happily with the version of guava we ship with? If so, the yarn-registry stuff will be happy Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[ https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283690#comment-14283690 ] Karthik Kambatla commented on HADOOP-11492: --- Discussed with Steve offline. Curator continues to use the same version of guava - 16.0.1. I was able to compile Curator with guava version 11.0.2, so I suppose Curator doesn't use any fancy APIs that are only available in later releases. Bump up curator version to 2.7.1 Key: HADOOP-11492 URL: https://issues.apache.org/jira/browse/HADOOP-11492 Project: Hadoop Common Issue Type: Task Affects Versions: 2.6.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 requires. PS: Filing a common JIRA so folks from other sub-projects also notice this change and shout out if there are any reservations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11492) Bump up curator version to 2.7.1
[
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283749#comment-14283749
]
Steve Loughran commented on HADOOP-11492:
-
There's two extra warnings in javac
{code}
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java:[511,30]
[deprecation] trySetCount(int) in SharedCount has been deprecated
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java:[540,29]
[deprecation] trySetCount(int) in SharedCount has been deprecated
{code}
Assuming the cost of migrating to the successor is low, and we don't care about
working with v curator 2.4.1, then it'd be nice to fix these.
If neither of those conditions is met, +1
Bump up curator version to 2.7.1
Key: HADOOP-11492
URL: https://issues.apache.org/jira/browse/HADOOP-11492
Project: Hadoop Common
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-11492-1.patch
Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716
requires.
PS: Filing a common JIRA so folks from other sub-projects also notice this
change and shout out if there are any reservations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
