[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160729#comment-16160729
]
Hadoop QA commented on HADOOP-11597:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HADOOP-11597 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-11597 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12731686/HADOOP-11597.004.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13236/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Factor OSType out from Shell: change in common
> --
>
> Key: HADOOP-11597
> URL: https://issues.apache.org/jira/browse/HADOOP-11597
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: util
>Affects Versions: 2.7.0
>Reporter: Yongjun Zhang
>Assignee: Yongjun Zhang
> Labels: BB2015-05-TBR
> Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
> HADOOP-11597.003.patch, HADOOP-11597.004.patch
>
>
> This jira is to cover the hadoop-common-project change for HADOOP-11293
> (Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946182#comment-15946182
]
Hadoop QA commented on HADOOP-11597:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color}
| {color:red} HADOOP-11597 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-11597 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12731686/HADOOP-11597.004.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11970/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Factor OSType out from Shell: change in common
> --
>
> Key: HADOOP-11597
> URL: https://issues.apache.org/jira/browse/HADOOP-11597
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: util
>Affects Versions: 2.7.0
>Reporter: Yongjun Zhang
>Assignee: Yongjun Zhang
> Labels: BB2015-05-TBR
> Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
> HADOOP-11597.003.patch, HADOOP-11597.004.patch
>
>
> This jira is to cover the hadoop-common-project change for HADOOP-11293
> (Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[ https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538305#comment-14538305 ] Chris Nauroth commented on HADOOP-11597: [~yzhangal], thanks for the notice. I remain indifferent about this work, as described in this comment: https://issues.apache.org/jira/browse/HADOOP-11293?focusedCommentId=14206640page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14206640 However, please feel free to proceed if the compatibility concerns are addressed and other committers agree. Thanks! Factor OSType out from Shell: change in common -- Key: HADOOP-11597 URL: https://issues.apache.org/jira/browse/HADOOP-11597 Project: Hadoop Common Issue Type: Sub-task Components: util Affects Versions: 2.7.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Labels: BB2015-05-TBR Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch, HADOOP-11597.003.patch, HADOOP-11597.004.patch This jira is to cover the hadoop-common-project change for HADOOP-11293 (Factor OSType out from Shell). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536284#comment-14536284
]
Hadoop QA commented on HADOOP-11597:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 54s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 26 new or modified test files. |
| {color:green}+1{color} | javac | 7m 49s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 59s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 9s | The applied patch generated 6
new checkstyle issues (total was 734, now 626). |
| {color:red}-1{color} | whitespace | 0m 23s | The patch has 6 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 43s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 2s | Tests passed in
hadoop-common. |
| | | 61m 37s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731686/HADOOP-11597.004.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 02a4a22 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6565/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6565/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6565/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6565/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6565/console |
This message was automatically generated.
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Labels: BB2015-05-TBR
Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
HADOOP-11597.003.patch, HADOOP-11597.004.patch
This jira is to cover the hadoop-common-project change for HADOOP-11293
(Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536260#comment-14536260
]
Yongjun Zhang commented on HADOOP-11597:
Hi [~szetszwo],
Thanks for the clarification of your suggestion, I was confused earlier because
I thought you meant to take the OSType out from Shell: It is good to refactor
OSType out from Shell. How about simply moving OSType to a standalone class
instead of adding CurrentOS?
I like your suggestion and thanks for that. I did a new rev to address it. One
problem of having an OSType outside Shell is, when both this OSType and Shell
are imported in a file, this OSType conflicts with the one in Shell (we kept
the one in Shell for backward compatibility). Thus in stead of calling OSType,
I made it OsType, I think you mentioned that you prefer this kind of naming
too.
It's a bit confusing to have OsType and OSType in the code base because they
differ by only the case of a letter, but our eventual goal is to obsolete
OSType in Shell, I guess it's ok. I changed all reference of Shell.WINDOWS in
hadoop-common to OsType.IS_WINDOWS in the patch. The goal is to do the same for
all other components in related jiras.
HI [~cmccabe], [~steve_l] and [~cnauroth],
Thanks for your earlier review. I got Nicholas' help during the bug bash. I'm
uploading patch rev 4 to address his suggestion: I changed {{class CurrentOS}}
to {{enum OsType}} and made it {{@InterfaceStability.Unstable}} instead of
{{@InterfaceStability.Evolving}}. Would you please comment if you have any?
Thank you all.
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Labels: BB2015-05-TBR
Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
HADOOP-11597.003.patch
This jira is to cover the hadoop-common-project change for HADOOP-11293
(Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535714#comment-14535714
]
Hadoop QA commented on HADOOP-11597:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 37s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 26 new or modified test files. |
| {color:green}+1{color} | javac | 7m 30s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 41s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 5s | The applied patch generated
2469 new checkstyle issues (total was 3059, now 3073). |
| {color:red}-1{color} | whitespace | 6m 52s | The patch has 51 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 41s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 47s | Tests passed in
hadoop-common. |
| | | 66m 50s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731548/HADOOP-11597.003.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f523e96 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6554/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6554/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6554/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6554/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6554/console |
This message was automatically generated.
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Labels: BB2015-05-TBR
Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
HADOOP-11597.003.patch
This jira is to cover the hadoop-common-project change for HADOOP-11293
(Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535758#comment-14535758
]
Tsz Wo Nicholas Sze commented on HADOOP-11597:
--
- The OS_TYPE_ prefix can be dropped since they are already inside OSType.
- Let's also change WIN to WINDOWS.
{code}
public enum OSType {
LINUX,
WINDOWS,
SOLARIS,
MAC,
FREEBSD,
OTHER;
{code}
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Labels: BB2015-05-TBR
Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
HADOOP-11597.003.patch
This jira is to cover the hadoop-common-project change for HADOOP-11293
(Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[ https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535665#comment-14535665 ] Tsz Wo Nicholas Sze commented on HADOOP-11597: -- It is good to refactor OSType out from Shell. How about simply moving OSType to a standalone class instead of adding CurrentOS? Factor OSType out from Shell: change in common -- Key: HADOOP-11597 URL: https://issues.apache.org/jira/browse/HADOOP-11597 Project: Hadoop Common Issue Type: Sub-task Components: util Affects Versions: 2.7.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Labels: BB2015-05-TBR Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch, HADOOP-11597.003.patch This jira is to cover the hadoop-common-project change for HADOOP-11293 (Factor OSType out from Shell). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[ https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535694#comment-14535694 ] Yongjun Zhang commented on HADOOP-11597: Thanks [~szetszwo]! We wanted to be totally backward compatible, so application depending on old Shell impelmentation won't fail. Please see earlier discussion in HADOOP-11293. Thanks. Factor OSType out from Shell: change in common -- Key: HADOOP-11597 URL: https://issues.apache.org/jira/browse/HADOOP-11597 Project: Hadoop Common Issue Type: Sub-task Components: util Affects Versions: 2.7.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Labels: BB2015-05-TBR Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch, HADOOP-11597.003.patch This jira is to cover the hadoop-common-project change for HADOOP-11293 (Factor OSType out from Shell). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535727#comment-14535727
]
Tsz Wo Nicholas Sze commented on HADOOP-11597:
--
We wanted to be totally backward compatible, ...
I am talking about the new class. So there is no compatibility issue. BTW,
let's annotate it as Unstable for the moment.
{code}
@InterfaceAudience.Public
@InterfaceStability.Unstable
/** OSType: operating system types to be detected */
public enum OSType {
OS_TYPE_LINUX,
OS_TYPE_WIN,
OS_TYPE_SOLARIS,
OS_TYPE_MAC,
OS_TYPE_FREEBSD,
OS_TYPE_OTHER;
...
}
{code}
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Labels: BB2015-05-TBR
Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch,
HADOOP-11597.003.patch
This jira is to cover the hadoop-common-project change for HADOOP-11293
(Factor OSType out from Shell).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323261#comment-14323261
]
Hadoop QA commented on HADOOP-11597:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12699151/HADOOP-11597.002.patch
against trunk revision 814afa4.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5717//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5717//console
This message is automatically generated.
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HADOOP-11597.001.patch, HADOOP-11597.002.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11597) Factor OSType out from Shell: change in common
[
https://issues.apache.org/jira/browse/HADOOP-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321829#comment-14321829
]
Hadoop QA commented on HADOOP-11597:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698948/HADOOP-11597.001.patch
against trunk revision 3338f6d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5703//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5703//console
This message is automatically generated.
Factor OSType out from Shell: change in common
--
Key: HADOOP-11597
URL: https://issues.apache.org/jira/browse/HADOOP-11597
Project: Hadoop Common
Issue Type: Sub-task
Components: util
Affects Versions: 2.7.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HADOOP-11597.001.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
