[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530462#comment-14530462
 ] 

Hudson commented on HADOOP-11917:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #186 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/186/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* pom.xml
* hadoop-common-project/hadoop-common/CHANGES.txt
* .gitignore
* dev-support/test-patch.sh


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530495#comment-14530495
 ] 

Hudson commented on HADOOP-11917:
-

SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/919/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* .gitignore
* pom.xml
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/test-patch.sh


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530872#comment-14530872
 ] 

Hudson commented on HADOOP-11917:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* dev-support/test-patch.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* .gitignore
* pom.xml


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530899#comment-14530899
 ] 

Hudson commented on HADOOP-11917:
-

SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* dev-support/test-patch.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* pom.xml
* .gitignore


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530724#comment-14530724
 ] 

Hudson commented on HADOOP-11917:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* dev-support/test-patch.sh
* pom.xml
* hadoop-common-project/hadoop-common/CHANGES.txt
* .gitignore


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530745#comment-14530745
 ] 

Hudson commented on HADOOP-11917:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* .gitignore
* pom.xml
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/test-patch.sh


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-05 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528425#comment-14528425
 ] 

Sean Busbey commented on HADOOP-11917:
--

{quote}
-${GIT} clean -xdf
+${GIT} clean -xdf -e patchprocess/
{quote}

If someone passes in the cli arg for PATCH_DIR and it doesn't happen to be 
${BASE_DIR}/patchprocess, then this won't keep them safe. Probably best to 
add a warning to the cli arg that says this should not be within ${BASE_DIR} 
and leave this hold out as an undocumented feature. It's easy enough to set up 
a jenkins workspace where the git repo and the patch dir sit next to each other 
(for example, as done in the [work-in-progress nifi 
job|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-NIFI-Build/])

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-05 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528829#comment-14528829
 ] 

Hadoop QA commented on HADOOP-11917:


(!) A patch to test-patch or smart-apply-patch has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6485/console in case of 
problems.

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-05 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528949#comment-14528949
 ] 

Owen O'Malley commented on HADOOP-11917:


+1

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-05 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529005#comment-14529005
 ] 

Hudson commented on HADOOP-11917:
-

FAILURE: Integrated in Hadoop-trunk-Commit #7738 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/7738/])
HADOOP-11917. test-patch.sh should work with ${BASEDIR}/patchprocess setups 
(aw) (aw: rev d33419ae01c528073f9f00ef1aadf153fed41222)
* dev-support/test-patch.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* pom.xml
* .gitignore


 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Fix For: 2.8.0

 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-05 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528914#comment-14528914
 ] 

Hadoop QA commented on HADOOP-11917:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |  14m 29s | Pre-patch trunk compilation is 
healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as 
test-patch has been patched. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 28s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck |   0m 23s | Shellcheck was not available. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| | |  34m  6s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12730539/HADOOP-11917.01.patch |
| Optional Tests | shellcheck javadoc javac unit |
| git revision | trunk / 9b01f81 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6485/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6485/console |


This message was automatically generated.

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.01.patch, HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-04 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527572#comment-14527572
 ] 

Allen Wittenauer commented on HADOOP-11917:
---

* add patchprocess to the various exclude bits
* make sure git clean doesn't wipe it out
* clean up some whitespace issues in pom.xml while i'm there
* fix PATCH_DIR being a relative path

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527674#comment-14527674
 ] 

Hadoop QA commented on HADOOP-11917:


(!) A patch to test-patch or smart-apply-patch has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6479/console in case of 
problems.

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11917) test-patch.sh should work with ${BASEDIR}/patchprocess setups

2015-05-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527722#comment-14527722
 ] 

Hadoop QA commented on HADOOP-11917:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |  14m 46s | Pre-patch trunk compilation is 
healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as 
test-patch has been patched. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 38s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 43s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck |   0m 23s | Shellcheck was not available. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| | |  34m 44s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12730320/HADOOP-11917.patch |
| Optional Tests | shellcheck javadoc javac unit |
| git revision | trunk / d701acc |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6479/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6479/console |


This message was automatically generated.

 test-patch.sh should work with ${BASEDIR}/patchprocess setups
 -

 Key: HADOOP-11917
 URL: https://issues.apache.org/jira/browse/HADOOP-11917
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11917.patch


 There are a bunch of problems with this kind of setup: configuration and code 
 changes in test-patch.sh required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)