[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013309#comment-16013309 ] Mingliang Liu commented on HADOOP-14274: [~sisan...@microsoft.com] can you add releases notes for this JIRA? That should summarize major changes, and be helpful for others to get the context. Thanks, > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Fix For: 2.9.0, 3.0.0-alpha3 > > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch, > HADOOP-14274.003.patch, TestingForRegressionWithSecureModeSwitchedOff.txt, > TestingWithSecureModeSwitchedOnSuccess.txt > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971236#comment-15971236 ] Hudson commented on HADOOP-14274: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11591/]) HADOOP-14274. Azure: Simplify Ranger-WASB policy model. Contributed by (liuml07: rev 0cab57223e3f54be17a5f27cefdb6d1da1b073e5) * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockWasbAuthorizerImpl.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbAuthorizationOperations.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbRemoteCallHelper.java * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteWasbAuthorizerImpl.java > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Fix For: 2.9.0, 3.0.0-alpha3 > > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch, > HADOOP-14274.003.patch, TestingForRegressionWithSecureModeSwitchedOff.txt, > TestingWithSecureModeSwitchedOnSuccess.txt > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967133#comment-15967133 ] Sivaguru Sankaridurg commented on HADOOP-14274: --- Thanks for reviewing and committing [~liuml07]. > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Fix For: 2.9.0, 3.0.0-alpha3 > > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch, > HADOOP-14274.003.patch, TestingForRegressionWithSecureModeSwitchedOff.txt, > TestingWithSecureModeSwitchedOnSuccess.txt > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966860#comment-15966860 ] Hudson commented on HADOOP-14274: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11584 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11584/]) HADOOP-14274. Azure: Simplify Ranger-WASB policy model. Contributed by (liuml07: rev 0cab57223e3f54be17a5f27cefdb6d1da1b073e5) * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/MockWasbAuthorizerImpl.java * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteWasbAuthorizerImpl.java * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbAuthorizationOperations.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbRemoteCallHelper.java * (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Fix For: 2.9.0, 3.0.0-alpha3 > > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch, > HADOOP-14274.003.patch, TestingForRegressionWithSecureModeSwitchedOff.txt, > TestingWithSecureModeSwitchedOnSuccess.txt > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965671#comment-15965671 ] Hadoop QA commented on HADOOP-14274: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 4s{color} | {color:blue} The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 23s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 31s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 13s{color} | {color:orange} hadoop-tools/hadoop-azure: The patch generated 1 new + 54 unchanged - 1 fixed = 55 total (was 55) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 2m 35s{color} | {color:green} The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 10s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 18s{color} | {color:green} hadoop-azure in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:612578f | | JIRA Issue | HADOOP-14274 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12863003/TestingWithSecureModeSwitchedOnSuccess.txt | | Optional Tests | asflicense unit shellcheck shelldocs compile javac javadoc mvninstall mvnsite findbugs checkstyle xml | | uname | Linux 5c5d8cf1864b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / f48e968 | | Default Java | 1.8.0_121 | | shellcheck | v0.4.6 | | findbugs | v3.0.0 | | checkstyle |
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965659#comment-15965659 ] Sivaguru Sankaridurg commented on HADOOP-14274: --- Hi [~liuml07], I have attached HADOOP-14274.003.patch with a minor fix to one of the tests. I have also attached logs that indicate that there was no regression, and that the new functionality passed all tests. I hope this is what you were looking for. Thanks Siva > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch, > HADOOP-14274.003.patch, TestingForRegressionWithSecureModeSwitchedOff.txt, > TestingWithSecureModeSwitchedOnSuccess.txt > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964792#comment-15964792 ] Mingliang Liu commented on HADOOP-14274: The checkstyle warning is fine to skip in this patch. How about the testing? > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964282#comment-15964282 ] Sivaguru Sankaridurg commented on HADOOP-14274: --- [~liuml07]. I fixed all your code review comments in the latest patch. Please review the changes. I have not broken up NativeAzureFileSystem.java into smaller file. That is the only checkstyle item still pending. I'll fix it in future changes. > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments: HADOOP-14274-001.patch, HADOOP-14274.002.patch > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964260#comment-15964260 ] Hadoop QA commented on HADOOP-14274: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 20s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 11s{color} | {color:orange} hadoop-tools/hadoop-azure: The patch generated 1 new + 42 unchanged - 7 fixed = 43 total (was 49) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 17s{color} | {color:green} hadoop-azure in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 20m 11s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:612578f | | JIRA Issue | HADOOP-14274 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12862834/HADOOP-14274.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 51542d6074b9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / aabf08d | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/testReport/ | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12081/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments:
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959612#comment-15959612 ] Mingliang Liu commented on HADOOP-14274: Overall looks good. # {{performAuthCheck}} should have javadoc for all parameters. # Checkstyle warnings are related. # As we're changing {{performAuthCheck}}, is it possible to use {{WasbAuthorizationOperations accessType}} instead of {{String accessType}} as parameter of [{private void performAuthCheck()}}? This seems cleaner. # {{MockWasbAuthorizerImpl.java:66}}, let's use Map.Entry<> instead of HashMap.Entry<>. We should always use the interface type unless we have good reasons. Plus, this fails in Java 7 as the HashMap.Entry is private. Testing will happen and let's post test report here before commit. > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments: HADOOP-14274-001.patch > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956492#comment-15956492 ] Sivaguru Sankaridurg commented on HADOOP-14274: --- Thanks [~liuml07]. :) > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments: HADOOP-14274-001.patch > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1593#comment-1593 ] Mingliang Liu commented on HADOOP-14274: Thanks for the patch. I really love the improvements in test. I'll review this week if no one else provides review. > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Reporter: Sivaguru Sankaridurg >Assignee: Sivaguru Sankaridurg > Attachments: HADOOP-14274-001.patch > > > This improvement seeks to simplify the WASB-Ranger policy model -- both the > policy specification and policy enforcement. > More specifically, WASB-Ranger checks do not follow the same policy model and > enforcement as Ranger-HDFS. > Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The > handoff requires the Ranger policies follow the same model as HDFS-ACLs. This > is not true with Ranger+WASB. > We seek to simplify the policy specification and enforcement by dropping the > 'x' bit altogether. > This JIRA tracks this improvement, alongwith a few more minor bugfixes that > were found during Ranger-WASB testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14274) Azure: Simplify Ranger-WASB policy model
[ https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955407#comment-15955407 ] Hadoop QA commented on HADOOP-14274: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 32s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 11s{color} | {color:orange} hadoop-tools/hadoop-azure: The patch generated 12 new + 43 unchanged - 6 fixed = 55 total (was 49) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 23s{color} | {color:green} hadoop-azure in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 20s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Issue | HADOOP-14274 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12861887/HADOOP-14274-001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml | | uname | Linux 60fb37cb6b4e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 6eba792 | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/testReport/ | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12022/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Azure: Simplify Ranger-WASB policy model > > > Key: HADOOP-14274 > URL: https://issues.apache.org/jira/browse/HADOOP-14274 > Project: Hadoop Common > Issue Type: