[jira] [Commented] (HADOOP-15023) ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
[
https://issues.apache.org/jira/browse/HADOOP-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254578#comment-16254578
]
Hudson commented on HADOOP-15023:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13241 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/13241/])
HADOOP-15023. ValueQueue should also validate (int) (lowWatermark * (xiao: rev
b1941b200d6b4fa6a7891421c0a1e212cad3d6eb)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java
> ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
> --
>
> Key: HADOOP-15023
> URL: https://issues.apache.org/jira/browse/HADOOP-15023
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Minor
> Fix For: 2.10.0, 3.0.1
>
> Attachments: HADOOP-15023.01.patch
>
>
> ValueQueue has precondition checks for each item independently, but does not
> check {{(int)(lowWatermark * numValues) > 0}}. If the product is low enough,
> casting to int will wrap that to 0, causing problems later when filling /
> getting from the queue.
> [code|https://github.com/apache/hadoop/blob/branch-3.0.0-beta1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java#L224]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15023) ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
[
https://issues.apache.org/jira/browse/HADOOP-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254507#comment-16254507
]
Hadoop QA commented on HADOOP-15023:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m
0s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 12s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 57s{color} | {color:green} patch has no errors when building and testing our
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
16s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}102m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | HADOOP-15023 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897857/HADOOP-15023.01.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux db16a24c5ca4 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / fac72ee |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13693/testReport/ |
| Max. process+thread count | 1345 (vs. ulimit of 5000) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13693/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> ValueQueue should also
[jira] [Commented] (HADOOP-15023) ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
[
https://issues.apache.org/jira/browse/HADOOP-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254461#comment-16254461
]
Lei (Eddy) Xu commented on HADOOP-15023:
+1. LGTM.
Thanks [~xiaochen]
> ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
> --
>
> Key: HADOOP-15023
> URL: https://issues.apache.org/jira/browse/HADOOP-15023
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Minor
> Attachments: HADOOP-15023.01.patch
>
>
> ValueQueue has precondition checks for each item independently, but does not
> check {{(int)(lowWatermark * numValues) > 0}}. If the product is low enough,
> casting to int will wrap that to 0, causing problems later when filling /
> getting from the queue.
> [code|https://github.com/apache/hadoop/blob/branch-3.0.0-beta1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java#L224]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15023) ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
[
https://issues.apache.org/jira/browse/HADOOP-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254391#comment-16254391
]
Bharat Viswanadham commented on HADOOP-15023:
-
+1 (non-binding)
> ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
> --
>
> Key: HADOOP-15023
> URL: https://issues.apache.org/jira/browse/HADOOP-15023
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Minor
> Attachments: HADOOP-15023.01.patch
>
>
> ValueQueue has precondition checks for each item independently, but does not
> check {{(int)(lowWatermark * numValues) > 0}}. If the product is low enough,
> casting to int will wrap that to 0, causing problems later when filling /
> getting from the queue.
> [code|https://github.com/apache/hadoop/blob/branch-3.0.0-beta1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java#L224]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15023) ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
[
https://issues.apache.org/jira/browse/HADOOP-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254338#comment-16254338
]
Rushabh S Shah commented on HADOOP-15023:
-
+1 non-binding.
small and easy to understand patch.
> ValueQueue should also validate (lowWatermark * numValues) > 0 on construction
> --
>
> Key: HADOOP-15023
> URL: https://issues.apache.org/jira/browse/HADOOP-15023
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Minor
> Attachments: HADOOP-15023.01.patch
>
>
> ValueQueue has precondition checks for each item independently, but does not
> check {{(int)(lowWatermark * numValues) > 0}}. If the product is low enough,
> casting to int will wrap that to 0, causing problems later when filling /
> getting from the queue.
> [code|https://github.com/apache/hadoop/blob/branch-3.0.0-beta1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java#L224]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
