[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797579#comment-16797579
]
Hadoop QA commented on HADOOP-15978:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HADOOP-15978 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-15978 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12951909/HADOOP-15978.shade.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16070/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797573#comment-16797573 ] Daryn Sharp commented on HADOOP-15978: -- If all goes well in this/next week's deploy, I'll begin posting the latest patches. Sean is right, the shading was in sufficient. Shading netty with maven is a PITA to put it mildly. I've fixed it. I've also changed some existing ipc nested classes to static so I can split all the netty code and import dependencies out into separate NettyClient/NettyServer classes. > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737799#comment-16737799
]
Sean Busbey commented on HADOOP-15978:
--
Over in Apache HBase we've been relocating Netty 4 since our 2.0 release and
IIRC there was a bunch more work needed to isolate it because of a bundled
{{.so}}. What's different here that let's us skip it?
see for example [hbase-thirdparty relocating the
.so|https://github.com/apache/hbase-thirdparty/blob/rel/2.1.0/hbase-shaded-netty/pom.xml#L97]
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737779#comment-16737779
]
Sean Busbey commented on HADOOP-15978:
--
to be clear, I'm -1 on including relocated classes in the package {{hrpc}}
unless there's some class name length limitation stopping us from using
{{org.apache.hadoop.shaded}}.
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1673#comment-1673
]
Sean Busbey commented on HADOOP-15978:
--
yes, we should only be exposing downstream to classes that are within our java
package space, which means {{org.apache.hadoop}}. Preferably we would always
make clear when we're relocating things and have it be
{{org.apache.hadoop.shaded}}. That's why our own build process checks for
classes in other package spaces and complains.
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737712#comment-16737712 ] Wei-Chiu Chuang commented on HADOOP-15978: -- Thank you Daryn for the clarification. Those were all the questions in my review. bq. Regarding later comment on hbase issues with a shade prefix of "hrpc.", is the imposed requirement to always prefix with o.a.h.? Those checks are defined in this file: https://github.com/apache/hbase/blob/master/hbase-shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh [~busbey] FYI > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737254#comment-16737254
]
Daryn Sharp commented on HADOOP-15978:
--
I'm back from a nice very long vacation and starting to catch up. Thanks
[~jojochuang] for the review comments!
bq. Does it support rolling restart? ...
Most definitely or we'd never be able to deploy.
bq. add ipc.server.netty.enable in core-default.xml
I'd prefer not adding/documenting, yet, but rather regard as "experimental" as
indicated in comments until the later patches. However I will add now if you
feel strongly about it.
bq. shading:
I admit complete ignorance and will defer to your patch, thanks! Regarding
later comment on hbase issues with a shade prefix of "hrpc.", is the imposed
requirement to always prefix with o.a.h.?
bq. Do we always want to use EpollServerSocketChannel for Linux? The similar
netty initialization in HBase asyncfs implementation checks if the os.arch is
amd64.
I'd say yes due to performance. Explicitly checking the arch is brittle when
{{Epoll.isAvailable()}} will support any current or future arch with epoll.
(Netty should have hidden the various arch specific impls with a
{{NativeServerSocketChannel}} interface...)
bq. Does it require netty-transport-native-epoll ...
Yes. I originally had a dep, not sure why I removed it. The native transport
was used during testing so the dep came in somehow... Will look into it.
bq. Once TLS is implemented and enabled, what configuration or additional
preparation will be required? It seems both client and server will require
generating additional certificates.
This will arrive in the later subtasks. Briefly, and we can further discuss on
the other jiras, intention is:
# server-side option if TLS is disabled, optional, or mandatory – using a
facility much like the {{SaslPropertiesResolver}} to support requirements for
mixed environments
# client/server cert location – leverage existing
{{server-\{client,server\}.xml}} resources
# client-side option for optimistic TLS, otherwise switch to TLS if server’s
NEGOTIATE response requests TLS (optional or mandatory)
Are you still reviewing the implementation? Or is addressing the cited issues
(including pre-commit dings) sufficient?
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725351#comment-16725351 ] Wei-Chiu Chuang commented on HADOOP-15978: -- Also note this patch breaks HBase 2.1 and above due to the classpath check added in HBASE-20332. If you change the shaded class path to org.apache.hadoop.shaded or something else, instead of hproc/, it'll be easier to integrate with downstream applications. > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722292#comment-16722292
]
Hadoop QA commented on HADOOP-15978:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HADOOP-15978 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-15978 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12951909/HADOOP-15978.shade.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15657/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722291#comment-16722291 ] Wei-Chiu Chuang commented on HADOOP-15978: -- Hi [~daryn] I spent some time to understand shading. Turns out it was more than updating the script. [^HADOOP-15978.shade.patch] is what's needed to build the patch after enabling shading. Please apply it on top of your first patch. Thanks! > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch, HADOOP-15978.shade.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721883#comment-16721883
]
Wei-Chiu Chuang commented on HADOOP-15978:
--
Thanks for the patch, Daryn!
* Does it support rolling restart? It’s always a pain to do this kind of change
at RPC level.
* some refactor work is greatly appreciated. The Server.java is at more than
4000 lines now.
* add ipc.server.netty.enable in core-default.xml
* shading: patch doesn’t compile due to shading checks. Need to update
ensure-jars-have-correct-contents.sh to add allowed jar class path.
{code}
allowed_expr+="|^hrpc/"
{code}
* netty: hadoop-project/pom.xml already declares a dependency on io.netty-all,
and version is 4.0.52.Final, different than the one used in this patch.
* Do we always want to use EpollServerSocketChannel for Linux? The similar
netty initialization in HBase asyncfs implementation checks if the os.arch is
amd64.
* Does it require netty-transport-native-epoll as described in
https://netty.io/wiki/native-transports.html?
* Once TLS is implemented and enabled, what configuration or additional
preparation will be required? It seems both client and server will require
generating additional certificates.
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720455#comment-16720455 ] Wei-Chiu Chuang commented on HADOOP-15978: -- FYI [~zvenczel] and I are reviewing the patch too. > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718238#comment-16718238 ] Daryn Sharp commented on HADOOP-15978: -- Let me clarify that I was comparing current IPC and Netty performance. I have no TLS benchmarks – yet. > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718202#comment-16718202 ] Daryn Sharp commented on HADOOP-15978: -- Yes, complete compatibility is tantamount. I will not break the protocol. With no TLS, any mix of Netty client/server will work. With TLS, both will need to be Netty (although technically you should be able to use something like NIO ipc + stunnel). A TLS enabled server with mandatory TLS will return a protocol compliant error response that TLS is required. I think an early prototype showed a ~4% degradation using Netty. It re-implemented some of the code paths which aren't in this patch. The Netty architecture is nice but is has more overhead than hadoop's highly optimized ipc. Absorbing that overhead is going to be necessary to quickly get us to a standard TLS implementation. I'm soon going to disappear for probably the rest of the year so it would be great if I can get some general review comments on the approach. > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[ https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711785#comment-16711785 ] Erik Krogen commented on HADOOP-15978: -- Hey Daryn, it's great to see this work being done. Do you have any performance numbers you can share with this Netty implementation vs. the existing RPC implementation? It would be nice to see the comparison without encryption and JavaSSL vs. Netty TLS. > Add Netty support to the RPC server > --- > > Key: HADOOP-15978 > URL: https://issues.apache.org/jira/browse/HADOOP-15978 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, security >Reporter: Daryn Sharp >Assignee: Daryn Sharp >Priority: Major > Attachments: HADOOP-15978.patch > > > Adding Netty will allow later using a native TLS transport layer with much > better performance than that offered by Java's SSLEngine. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710557#comment-16710557
]
Hadoop QA commented on HADOOP-15978:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 13 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 38s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
8s{color} | {color:green} root generated 0 new + 1489 unchanged - 1 fixed =
1489 total (was 1490) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 58s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 32 new + 574 unchanged - 21 fixed = 606 total (was 595) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 12m
52s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
48s{color} | {color:red} hadoop-common-project/hadoop-common generated 1 new +
0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 35s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
39s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 98m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of
org.apache.hadoop.ipc.Server$NioListener.selector; locked 62% of time
Unsynchronized access at Server.java:62% of time Unsynchronized access at
Server.java:[line 1205] |
| Failed junit tests | hadoop.ipc.TestIPC |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HADOOP-15978 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12950740/HADOOP-15978.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle |
| uname | Linux c10d8aa5e55d 4.4.0-134-generic #160~14.04.1-Ubuntu SMP Fri Aug
17 11:07:07 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 228156c |
[jira] [Commented] (HADOOP-15978) Add Netty support to the RPC server
[
https://issues.apache.org/jira/browse/HADOOP-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710430#comment-16710430
]
Daryn Sharp commented on HADOOP-15978:
--
Goal is a minimally invasive patch that allows using Netty or NIO. The Netty
impl can be further optimized but reusing virtually all existing code paths
(for now) has lower risk. Main changes are converting existing classes to
abstract or interfaces to facilitate a Netty and NIO implementation to override
a few methods. Majority of changes involve changing of the signatures. The
{{doRead}} impl was moved into the {{Connection}} class to allow both Netty and
NIO to call it.
> Add Netty support to the RPC server
> ---
>
> Key: HADOOP-15978
> URL: https://issues.apache.org/jira/browse/HADOOP-15978
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>Priority: Major
> Attachments: HADOOP-15978.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
