[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102695#comment-15102695 ] Nick Dimiduk commented on HADOOP-6221: -- Bless you [~ste...@apache.org] > RPC Client operations cannot be interrupted > --- > > Key: HADOOP-6221 > URL: https://issues.apache.org/jira/browse/HADOOP-6221 > Project: Hadoop Common > Issue Type: Bug > Components: ipc >Affects Versions: 0.21.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.7.0 > > Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, > HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, > HADOOP-6221.patch, HADOOP-6221.patch > > > RPC.waitForProxy swallows any attempts to interrupt it while waiting for a > proxy; this makes it hard to shutdown a service that you are starting; you > have to wait for the timeouts. > There are only 4-5 places in the code that use either of the two overloaded > methods, removing the catch and changing the signature should not be too > painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293650#comment-14293650 ] Hudson commented on HADOOP-6221: FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #87 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/87/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293582#comment-14293582 ] Hudson commented on HADOOP-6221: FAILURE: Integrated in Hadoop-Mapreduce-trunk #2037 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2037/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * hadoop-common-project/hadoop-common/CHANGES.txt RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293573#comment-14293573 ] Hudson commented on HADOOP-6221: FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #83 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/83/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293605#comment-14293605 ] Hudson commented on HADOOP-6221: SUCCESS: Integrated in Hadoop-Hdfs-trunk #2018 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2018/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293319#comment-14293319 ] Hudson commented on HADOOP-6221: FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #86 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/86/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/CHANGES.txt RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293331#comment-14293331 ] Hudson commented on HADOOP-6221: FAILURE: Integrated in Hadoop-Yarn-trunk #820 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/820/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[
https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292191#comment-14292191
]
Chris Douglas commented on HADOOP-6221:
---
* At RPC.java:415, won't the following call to {{Thread.sleep()}} check if the
interrupt flag is set? Is the explicit check required?
* According to the
[docs|http://docs.oracle.com/javase/7/docs/api/java/lang/Thread.html#interrupt%28%29],
a thread blocked a a {{Selector}} should set the interrupt flag and return,
rather than throwing {{InterruptedIOException}}, but I'm not sure the rest of
the RPC stack is consistent. HDFS seems to use it this way, so this is arguably
correct.
AFAIK, the only way to forcibly interrupt some IO operations is to close the
channel from outside the thread, but implementing that would be more invasive.
+1 overall
RPC Client operations cannot be interrupted
---
Key: HADOOP-6221
URL: https://issues.apache.org/jira/browse/HADOOP-6221
Project: Hadoop Common
Issue Type: Bug
Components: ipc
Affects Versions: 0.21.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch,
HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch,
HADOOP-6221.patch, HADOOP-6221.patch
RPC.waitForProxy swallows any attempts to interrupt it while waiting for a
proxy; this makes it hard to shutdown a service that you are starting; you
have to wait for the timeouts.
There are only 4-5 places in the code that use either of the two overloaded
methods, removing the catch and changing the signature should not be too
painful, unless anyone is using the method outside the hadoop codebase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292503#comment-14292503 ] Hudson commented on HADOOP-6221: FAILURE: Integrated in Hadoop-trunk-Commit #6935 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6935/]) HADOOP-6221 RPC Client operations cannot be interrupted (stevel) (stevel: rev 1f2b6956c2012a7d6ea7e7ba5116d3ad71c23d7e) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCWaitForProxy.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[
https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291721#comment-14291721
]
Hadoop QA commented on HADOOP-6221:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12694520/HADOOP-6221-008.patch
against trunk revision 7b82c4a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5479//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5479//console
This message is automatically generated.
RPC Client operations cannot be interrupted
---
Key: HADOOP-6221
URL: https://issues.apache.org/jira/browse/HADOOP-6221
Project: Hadoop Common
Issue Type: Bug
Components: ipc
Affects Versions: 0.21.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch,
HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch,
HADOOP-6221.patch, HADOOP-6221.patch
RPC.waitForProxy swallows any attempts to interrupt it while waiting for a
proxy; this makes it hard to shutdown a service that you are starting; you
have to wait for the timeouts.
There are only 4-5 places in the code that use either of the two overloaded
methods, removing the catch and changing the signature should not be too
painful, unless anyone is using the method outside the hadoop codebase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[ https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292612#comment-14292612 ] Chris Douglas commented on HADOOP-6221: --- Still curious about RPC.java:415. Is the check required? RPC Client operations cannot be interrupted --- Key: HADOOP-6221 URL: https://issues.apache.org/jira/browse/HADOOP-6221 Project: Hadoop Common Issue Type: Bug Components: ipc Affects Versions: 0.21.0 Reporter: Steve Loughran Assignee: Steve Loughran Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-6221-007.patch, HADOOP-6221-008.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch RPC.waitForProxy swallows any attempts to interrupt it while waiting for a proxy; this makes it hard to shutdown a service that you are starting; you have to wait for the timeouts. There are only 4-5 places in the code that use either of the two overloaded methods, removing the catch and changing the signature should not be too painful, unless anyone is using the method outside the hadoop codebase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-6221) RPC Client operations cannot be interrupted
[
https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291249#comment-14291249
]
Hadoop QA commented on HADOOP-6221:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12694440/HADOOP-6221-007.patch
against trunk revision 35f6496.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 1206 javac
compiler warnings (more than the trunk's current 1204 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5475//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5475//artifact/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5475//console
This message is automatically generated.
RPC Client operations cannot be interrupted
---
Key: HADOOP-6221
URL: https://issues.apache.org/jira/browse/HADOOP-6221
Project: Hadoop Common
Issue Type: Bug
Components: ipc
Affects Versions: 0.21.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
Attachments: HADOOP-6221-007.patch, HADOOP-6221.patch,
HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch,
HADOOP-6221.patch
RPC.waitForProxy swallows any attempts to interrupt it while waiting for a
proxy; this makes it hard to shutdown a service that you are starting; you
have to wait for the timeouts.
There are only 4-5 places in the code that use either of the two overloaded
methods, removing the catch and changing the signature should not be too
painful, unless anyone is using the method outside the hadoop codebase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
