[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572522#comment-14572522
]
Hadoop QA commented on HADOOP-8320:
---
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12708789/HADOOP-8320.007.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e830207 |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6916/console |
This message was automatically generated.
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch,
HADOOP-8320.003.patch, HADOOP-8320.004.patch, HADOOP-8320.005.patch,
HADOOP-8320.007.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572521#comment-14572521
]
Vinayakumar B commented on HADOOP-8320:
---
[~vijaysbhat], thanks for the update on patch.
Two things need to be corrected.
# AbstractFileSystem doesn't support relative paths, Instead it supports only
fully qualified or paths starting with root '/'. Its okay untill relative path
is corrected already in FileContext before passing to AFS.
# Usage of {{NetUtils.getCanonicalUri(uri, getDefaultPort());}} was
intentionally not done, because there was no need of DNS replacement for the
host, which might be time consuming, instead just needed to replace default
port. Check javadoc in {{FileSystem#canonicalizeUri()}}
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch,
HADOOP-8320.003.patch, HADOOP-8320.004.patch, HADOOP-8320.005.patch,
HADOOP-8320.007.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390752#comment-14390752
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708691/HADOOP-8320.005.patch
against trunk revision 2e79f1c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestFcLocalFsUtil
org.apache.hadoop.fs.TestLocalDirAllocator
org.apache.hadoop.io.file.tfile.TestTFileSeqFileComparison
org.apache.hadoop.fs.shell.TestCopy
org.apache.hadoop.util.TestDiskChecker
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractRename
org.apache.hadoop.fs.TestFileUtil
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractOpen
org.apache.hadoop.security.ssl.TestSSLFactory
org.apache.hadoop.fs.TestFsShellCopy
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
org.apache.hadoop.fs.TestLocalFileSystem
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractDelete
org.apache.hadoop.fs.shell.find.TestIname
org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
org.apache.hadoop.io.file.tfile.TestTFileStreams
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractOpen
org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
org.apache.hadoop.util.TestGenericOptionsParser
org.apache.hadoop.io.TestSetFile
org.apache.hadoop.fs.TestS3_LocalFileContextURI
org.apache.hadoop.crypto.key.TestKeyShell
org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegationTokenSupport
org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegation
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractMkdir
org.apache.hadoop.io.compress.TestCodec
org.apache.hadoop.fs.TestGetFileBlockLocations
org.apache.hadoop.fs.viewfs.TestViewFsLocalFs
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsStreams
org.apache.hadoop.fs.TestChecksumFileSystem
org.apache.hadoop.fs.TestTruncatedInputBug
org.apache.hadoop.security.alias.TestCredShell
org.apache.hadoop.security.alias.TestCredentialProviderFactory
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractCreate
org.apache.hadoop.io.TestMapFile
org.apache.hadoop.fs.TestPath
org.apache.hadoop.fs.viewfs.TestChRootedFs
org.apache.hadoop.security.TestLdapGroupsMapping
org.apache.hadoop.fs.TestFilterFileSystem
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.fs.shell.TestPathData
org.apache.hadoop.fs.TestFileSystemInitialization
org.apache.hadoop.fs.shell.find.TestPrint0
org.apache.hadoop.io.TestArrayFile
org.apache.hadoop.fs.TestLocalFsFCStatistics
org.apache.hadoop.fs.TestLocalFileSystemPermission
org.apache.hadoop.fs.TestListFiles
org.apache.hadoop.fs.shell.find.TestFind
org.apache.hadoop.io.file.tfile.TestTFileByteArrays
org.apache.hadoop.io.file.tfile.TestTFileSplit
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[ https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391776#comment-14391776 ] Vijay Bhat commented on HADOOP-8320: [~atm] all test cases now finally pass for the refactor. There are no new additional test cases since existing ones capture the functionality of the code being refactored. Would appreciate a review when you get a chance. FileSystem#checkPath and AbstractFileSystem#checkPath should share code --- Key: HADOOP-8320 URL: https://issues.apache.org/jira/browse/HADOOP-8320 Project: Hadoop Common Issue Type: Improvement Components: fs Affects Versions: 2.0.0-alpha Reporter: Aaron T. Myers Assignee: Vijay Bhat Priority: Minor Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch, HADOOP-8320.003.patch, HADOOP-8320.004.patch, HADOOP-8320.005.patch, HADOOP-8320.007.patch Per the discussion on HADOOP-8310, these two methods can be refactored to share some code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391709#comment-14391709
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708789/HADOOP-8320.007.patch
against trunk revision c94d594.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6044//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6044//console
This message is automatically generated.
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch,
HADOOP-8320.003.patch, HADOOP-8320.004.patch, HADOOP-8320.005.patch,
HADOOP-8320.007.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370546#comment-14370546
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705776/HADOOP-8320.004.patch
against trunk revision e37ca22.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestAfsCheckPath
org.apache.hadoop.fs.TestFileSystemCanonicalization
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5974//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5974//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5974//console
This message is automatically generated.
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch,
HADOOP-8320.003.patch, HADOOP-8320.004.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368008#comment-14368008
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705432/HADOOP-8320.003.patch
against trunk revision f0dea03.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.shell.TestPathData
org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.TestLocalDirAllocator
org.apache.hadoop.fs.shell.TestCopyPreserveFlag
org.apache.hadoop.fs.TestFsShellCopy
org.apache.hadoop.io.TestSecureIOUtils
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.TestFileSystemCanonicalization
org.apache.hadoop.fs.viewfs.TestChRootedFileSystem
org.apache.hadoop.fs.TestLocalFileSystem
org.apache.hadoop.io.compress.TestCodec
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5966//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5966//console
This message is automatically generated.
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch,
HADOOP-8320.003.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366469#comment-14366469
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705231/HADOOP-8320.002.patch
against trunk revision 968425e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.io.file.tfile.TestTFileByteArrays
org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs
org.apache.hadoop.fs.shell.TestPathData
org.apache.hadoop.fs.TestChecksumFileSystem
org.apache.hadoop.crypto.key.TestKeyProviderFactory
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractDelete
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractSeek
org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.TestPath
org.apache.hadoop.util.TestGenericOptionsParser
org.apache.hadoop.crypto.key.TestKeyShell
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
org.apache.hadoop.fs.TestTrash
org.apache.hadoop.fs.TestS3_LocalFileContextURI
org.apache.hadoop.fs.TestLocalDirAllocator
org.apache.hadoop.security.alias.TestCredShell
org.apache.hadoop.fs.TestFileContextResolveAfs
org.apache.hadoop.io.TestMapFile
org.apache.hadoop.fs.shell.TestCopyPreserveFlag
org.apache.hadoop.fs.TestFsShellCopy
org.apache.hadoop.io.TestBloomMapFile
org.apache.hadoop.io.TestSecureIOUtils
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractOpen
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractMkdir
org.apache.hadoop.fs.shell.TestTextCommand
org.apache.hadoop.fs.viewfs.TestViewFsTrash
org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractMkdir
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractRename
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractDelete
org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs
org.apache.hadoop.fs.TestLocal_S3FileContextURI
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.security.ssl.TestSSLFactory
org.apache.hadoop.io.TestSequenceFile
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
org.apache.hadoop.io.TestSequenceFileSync
org.apache.hadoop.fs.TestLocalFSFileContextCreateMkdir
org.apache.hadoop.fs.TestFcLocalFsUtil
org.apache.hadoop.fs.TestStat
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractSeek
org.apache.hadoop.fs.TestLocalFSFileContextMainOperations
org.apache.hadoop.security.alias.TestCredentialProviderFactory
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractAppend
org.apache.hadoop.fs.viewfs.TestChRootedFs
org.apache.hadoop.fs.TestFileSystemCanonicalization
org.apache.hadoop.fs.TestFsShellReturnCode
org.apache.hadoop.fs.TestLocalFsFCStatistics
org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractLoaded
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358759#comment-14358759
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704050/HADOOP-8320.001.patch
against trunk revision ff83ae7.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5924//console
This message is automatically generated.
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Attachments: HADOOP-8320.001.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358969#comment-14358969
]
Hadoop QA commented on HADOOP-8320:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704185/HADOOP-8320.001.patch
against trunk revision ff83ae7.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5926//console
This message is automatically generated.
FileSystem#checkPath and AbstractFileSystem#checkPath should share code
---
Key: HADOOP-8320
URL: https://issues.apache.org/jira/browse/HADOOP-8320
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.0.0-alpha
Reporter: Aaron T. Myers
Assignee: Vijay Bhat
Priority: Minor
Attachments: HADOOP-8320.001.patch
Per the discussion on HADOOP-8310, these two methods can be refactored to
share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[ https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357808#comment-14357808 ] Vijay Bhat commented on HADOOP-8320: [~atm], [~daryn] I am using the getCanonicalUri from the NetUtils class to canonicalize the uri in the refactored checkPath logic. FileSystem#checkPath and AbstractFileSystem#checkPath should share code --- Key: HADOOP-8320 URL: https://issues.apache.org/jira/browse/HADOOP-8320 Project: Hadoop Common Issue Type: Improvement Components: fs Affects Versions: 2.0.0-alpha Reporter: Aaron T. Myers Assignee: Vijay Bhat Priority: Minor Attachments: HADOOP-8320.001.patch Per the discussion on HADOOP-8310, these two methods can be refactored to share some code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8320) FileSystem#checkPath and AbstractFileSystem#checkPath should share code
[ https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339708#comment-14339708 ] Vijay Bhat commented on HADOOP-8320: [~atm], [~daryn], I can take this. Here's how I plan to refactor the code - move the checkPath logic from the AbstractFileSystem and FileSystem classes to a checkFileSystemPath method in the Path class. The AbstracFileSystem and FileSystem checkPath method will call the common code in checkFileSystemPath (adapter pattern). This is because the two classes aren't derived from any common ancestor. However, I wanted your input of what I should do with the canonicalizeUri method in the FileSystem class. Since the AbstractFileSystem checkPath method should also be performing canonicalization (and it doesn't now), do you think it makes sense to move that to the Path class or is there a more logical location for it? FileSystem#checkPath and AbstractFileSystem#checkPath should share code --- Key: HADOOP-8320 URL: https://issues.apache.org/jira/browse/HADOOP-8320 Project: Hadoop Common Issue Type: Improvement Components: fs Affects Versions: 2.0.0-alpha Reporter: Aaron T. Myers Assignee: Vijay Bhat Priority: Minor Per the discussion on HADOOP-8310, these two methods can be refactored to share some code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
