[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2013-03-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617224#comment-13617224
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Yarn-trunk #169 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/169/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration (Jan van der Lugt via harsh)
Merging into branch-2. Updating CHANGES.txt (Revision 1461727)

 Result = FAILURE
vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1461727
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Assignee: Jan van der Lugt
Priority: Minor
 Fix For: 2.0.5-beta

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2013-03-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617300#comment-13617300
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Hdfs-trunk #1358 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1358/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration (Jan van der Lugt via harsh)
Merging into branch-2. Updating CHANGES.txt (Revision 1461727)

 Result = FAILURE
vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1461727
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Assignee: Jan van der Lugt
Priority: Minor
 Fix For: 2.0.5-beta

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2013-03-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617349#comment-13617349
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Mapreduce-trunk #1386 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1386/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration (Jan van der Lugt via harsh)
Merging into branch-2. Updating CHANGES.txt (Revision 1461727)

 Result = SUCCESS
vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1461727
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Assignee: Jan van der Lugt
Priority: Minor
 Fix For: 2.0.5-beta

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2013-03-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615527#comment-13615527
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-trunk-Commit #3536 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/3536/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration (Jan van der Lugt via harsh)
Merging into branch-2. Updating CHANGES.txt (Revision 1461727)

 Result = SUCCESS
vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1461727
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Assignee: Jan van der Lugt
Priority: Minor
 Fix For: 2.0.5-beta

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Harsh J (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283149#comment-13283149
 ] 

Harsh J commented on HADOOP-8415:
-

I filed HADOOP-8434 for the setter tests coverage. Thanks again.

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283313#comment-13283313
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Hdfs-trunk #1056 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1056/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration. Contributed by Jan van der Lugt. (harsh) 
(Revision 1342501)

 Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1342501
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283400#comment-13283400
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Mapreduce-trunk #1090 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1090/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration. Contributed by Jan van der Lugt. (harsh) 
(Revision 1342501)

 Result = ABORTED
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1342501
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283426#comment-13283426
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Hdfs-trunk-Commit #2361 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2361/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration. Contributed by Jan van der Lugt. (harsh) 
(Revision 1342501)

 Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1342501
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283438#comment-13283438
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Common-trunk-Commit #2288 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2288/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration. Contributed by Jan van der Lugt. (harsh) 
(Revision 1342501)

 Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1342501
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283498#comment-13283498
 ] 

Hudson commented on HADOOP-8415:


Integrated in Hadoop-Mapreduce-trunk-Commit #2307 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2307/])
HADOOP-8415. Add getDouble() and setDouble() in 
org.apache.hadoop.conf.Configuration. Contributed by Jan van der Lugt. (harsh) 
(Revision 1342501)

 Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1342501
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java


 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Jan van der Lugt (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283597#comment-13283597
 ] 

Jan van der Lugt commented on HADOOP-8415:
--

Hurray! I'll file a separate JIRA for the set-functions on monday. Thanks for 
your help, Harsh!

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-25 Thread Harsh J (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283676#comment-13283676
 ] 

Harsh J commented on HADOOP-8415:
-

I've already filed HADOOP-8434 for the setter methods.

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Fix For: 3.0.0

 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283138#comment-13283138
 ] 

Hadoop QA commented on HADOOP-8415:
---

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528779/HADOOP-8415.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 1 new or modified test 
files.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse.  The patch built with eclipse:eclipse.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1034//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1034//console

This message is automatically generated.

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-23 Thread Harsh J (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13281476#comment-13281476
 ] 

Harsh J commented on HADOOP-8415:
-

Hey [~janlugt],

Sorry, should've been more precise. The test is called simply TestConfiguration 
(You'll find many tests for classes via Test[ClassName] in Hadoop, as a general 
pattern). You should see test methods in there for Float methods which you can 
simply ape for Double then.

Regarding the trunk patch, the same may apply but your patch's root ought to be 
the root trunk directory. Here it seems to be hadoop-common as root. This is 
required to be able to run the QA Bot for patch validation across the project 
automatically. Its not a big deal so long as you can ensure your patch applies 
cleanly to trunk, wherever its based. I can rebase it to the right directory 
for you afterwards.

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-23 Thread Harsh J (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13281480#comment-13281480
 ] 

Harsh J commented on HADOOP-8415:
-

P.s. If you can also find some spots within the framework itself where use of 
Double is very relevant (from via Configuration), do let us know! :)

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-23 Thread Jan van der Lugt (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13281911#comment-13281911
 ] 

Jan van der Lugt commented on HADOOP-8415:
--

Hi Harsh,

I modified the patch file per your request, it now includes tests for doubles. 
I believe it is also patched from the root trunk directory. Please let me know 
if this version is fine.

- Jan

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HADOOP-8415) getDouble() and setDouble() in org.apache.hadoop.conf.Configuration

2012-05-21 Thread Jan van der Lugt (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280408#comment-13280408
 ] 

Jan van der Lugt commented on HADOOP-8415:
--

In my case I could fall back to floats as well (that's what I do now), but it 
just feels like when there's support for Integers, Longs, Boolean, Floats, 
Strings, Enums, etc., there should be support for Doubles as well. I don't know 
where I would add test cases. The patch works for trunk as well, as far as I 
understand. Please give me some pointers on how to do these things if they are 
required.

 getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
 ---

 Key: HADOOP-8415
 URL: https://issues.apache.org/jira/browse/HADOOP-8415
 Project: Hadoop Common
  Issue Type: Improvement
  Components: conf
Affects Versions: 1.0.2
Reporter: Jan van der Lugt
Priority: Minor
 Attachments: HADOOP-8415.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 In the org.apache.hadoop.conf.Configuration class, methods exist to set 
 Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
 absent. Are they not there for a reason or should they be added? In the 
 latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira