[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698680#comment-13698680
]
Hadoop QA commented on HADOOP-9416:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590588/hadoop-9416-8.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2724//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2724//console
This message is automatically generated.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch,
hadoop-9416-6.patch, hadoop-9416-7.patch, hadoop-9416-8.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699102#comment-13699102
]
Colin Patrick McCabe commented on HADOOP-9416:
--
bq. I had a similar thought regarding HdfsConstants, but couldn't find an
equivalent class in hadoop-common.
{{org.apache.hadoop.fs.FsConstants}}
bq. I'd rather have this in FSLinkResolver than Path though because it feels
weird to have an internal-use-only symlink method exposed in a public stable
class to end-users.
Who said anything about exposing it to end-users? Make it package-private.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch,
hadoop-9416-6.patch, hadoop-9416-7.patch, hadoop-9416-8.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[ https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699292#comment-13699292 ] Colin Patrick McCabe commented on HADOOP-9416: -- +1. Add new symlink resolution methods to FileSystem and FSLinkResolver --- Key: HADOOP-9416 URL: https://issues.apache.org/jira/browse/HADOOP-9416 Project: Hadoop Common Issue Type: Sub-task Components: fs Affects Versions: 3.0.0 Reporter: Andrew Wang Assignee: Andrew Wang Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch, hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch, hadoop-9416-6.patch, hadoop-9416-7.patch, hadoop-9416-8.patch, hadoop-9416-9.patch Add new methods for symlink resolution to FileSystem, and add resolution support for FileSystem to FSLinkResolver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699302#comment-13699302
]
Hadoop QA commented on HADOOP-9416:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590687/hadoop-9416-9.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2733//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2733//console
This message is automatically generated.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch,
hadoop-9416-6.patch, hadoop-9416-7.patch, hadoop-9416-8.patch,
hadoop-9416-9.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698116#comment-13698116
]
Hadoop QA commented on HADOOP-9416:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590479/hadoop-9416-7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2719//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2719//console
This message is automatically generated.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch,
hadoop-9416-6.patch, hadoop-9416-7.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698504#comment-13698504
]
Colin Patrick McCabe commented on HADOOP-9416:
--
Thanks, this looks better.
MAX_PATH_LINKS should go in HdfsConstants.java or a similar file.
If, as the comment explains, FSLinkResolver is a FileContext-specific class,
I don't think it makes sense to have FileSystemLinkResolver methods call into
it. I think {{qualifySymlinkTarget}} could and should be moved into Path,
since there is nothing FileContext or FileSystem-specific in that method.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch,
hadoop-9416-6.patch, hadoop-9416-7.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697316#comment-13697316
]
Hadoop QA commented on HADOOP-9416:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590319/hadoop-9416-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2715//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2715//console
This message is automatically generated.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697336#comment-13697336
]
Colin Patrick McCabe commented on HADOOP-9416:
--
{code}
+ public T next(final FileSystem fs, final Path p)
+ throws IOException {
+throw new AssertionError(Should not be called without first overriding!);
+ }
{code}
These and related methods should be abstract if they have to be overridden by
subclasses.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9416) Add new symlink resolution methods to FileSystem and FSLinkResolver
[
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697432#comment-13697432
]
Hadoop QA commented on HADOOP-9416:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590354/hadoop-9416-6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2716//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2716//console
This message is automatically generated.
Add new symlink resolution methods to FileSystem and FSLinkResolver
---
Key: HADOOP-9416
URL: https://issues.apache.org/jira/browse/HADOOP-9416
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 3.0.0
Reporter: Andrew Wang
Assignee: Andrew Wang
Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch,
hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch,
hadoop-9416-6.patch
Add new methods for symlink resolution to FileSystem, and add resolution
support for FileSystem to FSLinkResolver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
