[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-09 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-
   Resolution: Fixed
Fix Version/s: 2.7.0
   Status: Resolved  (was: Patch Available)

Local mvn eclipse:eclipse passes just fine with patch. I've pushed the patch to 
trunk and branch-2.

Resolving.

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Fix For: 2.7.0

 Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-09 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-
Component/s: (was: conf)
 io

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: io
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Fix For: 2.7.0

 Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-09 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-
Target Version/s:   (was: 3.0.0, 2.7.0)

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: io
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Fix For: 2.7.0

 Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-08 Thread Ryan P (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan P updated HADOOP-11512:

Attachment: HADOOP-11512.patch

Alright, so hopefully I got it this time. I apologize for all the testing 
mishaps.


 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-08 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-
Attachment: HADOOP-11512.branch-2.patch

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-08 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-
Attachment: HADOOP-11512.patch

Thanks Ryan. I've attached a cleaned up version that removes the extra changes 
to indentation made on some unrelated lines.

+1, will commit after Jenkins runs through this.

I also attached a tested branch-2 variant as the back-port was not 
straight-forward.

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-08 Thread Harsh J (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-
Hadoop Flags: Reviewed
  Status: Patch Available  (was: Open)

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-03 Thread Ryan P (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan P updated HADOOP-11512:

Attachment: HADOOP-11512.patch

[~qwertymaniac], much appreciated. I'll get the hang of this eventually 

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.patch, HADOOP-11512.patch, 
 HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-02-01 Thread Ryan P (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan P updated HADOOP-11512:

Attachment: HADOOP-11512.patch

Bit confused on part 2, forgive my ignorance, but  
testSerializationKeyIsTrimmed() will be run by the two testGetSerializer() and 
testGetDeserializer() methods below. 

At any rate I have added a serialization class padded with whitespace on both 
ends. If any further adjustments are needed please let me know. 

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.patch, HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys

2015-01-29 Thread Ryan P (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan P updated HADOOP-11512:

Attachment: HADOOP-11512.patch

[~qwertymaniac], test may need some work adjustments. 

 Use getTrimmedStrings when reading serialization keys
 -

 Key: HADOOP-11512
 URL: https://issues.apache.org/jira/browse/HADOOP-11512
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: Harsh J
Assignee: Ryan P
Priority: Minor
 Attachments: HADOOP-11512.patch


 In the file 
 {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
 which does not trim the input. This could cause confusing user issues if 
 someone manually overrides the key in the XML files/Configuration object 
 without using the dynamic approach.
 The call should instead use Configuration#getTrimmedStrings(…), so the 
 whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)