[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=784363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784363
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 23/Jun/22 22:22
Start Date: 23/Jun/22 22:22
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#issuecomment-1164971077
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 40m 24s | | trunk passed |
| +1 :green_heart: | compile | 25m 10s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 21m 37s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 31s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 58s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 31s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 4s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 6s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 52s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 6s | | the patch passed |
| +1 :green_heart: | compile | 24m 13s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 24m 13s | | the patch passed |
| +1 :green_heart: | compile | 21m 45s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 21m 45s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 24s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 56s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 22s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 4s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 3s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 37s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 18m 17s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 16s | | The patch does not
generate ASF License warnings. |
| | | 224m 51s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4474/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4474 |
| JIRA Issue | HADOOP-18306 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 472d91b4539c 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 370df9b21f54462fd0da45aa1a5cf2c87bbd0757 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4474/2/testReport/ |
| Max. process+thread count | 1803 (vs. ulimit of 5500) |
| modules | C:
[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783142
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 20/Jun/22 22:31
Start Date: 20/Jun/22 22:31
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#issuecomment-1160856465
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 14s | | trunk passed |
| +1 :green_heart: | compile | 22m 58s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 34s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 47s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 13s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 50s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 16s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 12s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 34s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 8s | | the patch passed |
| +1 :green_heart: | compile | 22m 13s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 22m 13s | | the patch passed |
| +1 :green_heart: | compile | 20m 37s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 20m 37s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 41s | | the patch passed |
| +1 :green_heart: | mvnsite | 2m 10s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 38s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 21s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 9s | | the patch passed |
| +1 :green_heart: | shadedclient | 23m 36s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 18m 29s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 36s | | The patch does not
generate ASF License warnings. |
| | | 214m 32s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4474/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4474 |
| JIRA Issue | HADOOP-18306 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux a88b3d64dc08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 26b3148baaedef06c2e825cf989d01f3cf7bf3ab |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4474/1/testReport/ |
| Max. process+thread count | 3158 (vs. ulimit of 5500) |
| modules | C:
[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783115
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 20/Jun/22 18:41
Start Date: 20/Jun/22 18:41
Worklog Time Spent: 10m
Work Description: smengcl commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901931491
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##
@@ -215,7 +215,13 @@ private Set getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
Yes IMO we don't need the warn.
@swamirishi Just be sure to double check the debug log can actually be
enabled for example by setting
`org.apache.hadoop.security.ShellBasedUnixGroupsMapping=DEBUG` in
`log4j.properties` or JVM `-D` param.
nit: checkstyle missing space after `if`
Issue Time Tracking
---
Worklog Id: (was: 783115)
Time Spent: 50m (was: 40m)
> Warnings should not be shown on cli console when linux user not present on
> client
> -
>
> Key: HADOOP-18306
> URL: https://issues.apache.org/jira/browse/HADOOP-18306
> Project: Hadoop Common
> Issue Type: New Feature
>Reporter: Swaminathan Balachandran
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> {code}
> {noformat}
> 22/04/26 10:51:18 WARN security.ShellBasedUnixGroupsMapping: unable to return
> groups for user om
> PartialGroupNameException The user name 'om' is not found. id: ‘om’: no such
> user
> id: ‘om’: no such user
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.resolvePartialGroupNames(ShellBasedUnixGroupsMapping.java:291)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getUnixGroups(ShellBasedUnixGroupsMapping.java:215)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getGroupsSet(ShellBasedUnixGroupsMapping.java:123)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupSet(Groups.java:413)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:351)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:300)
> at
> com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
> at
> com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
> at
> com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
> at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
> at com.google.common.cache.LocalCache.get(LocalCache.java:3962)
> at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3985)
> at
> com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
> at org.apache.hadoop.security.Groups.getGroupInternal(Groups.java:258)
> at org.apache.hadoop.security.Groups.getGroupsSet(Groups.java:230)
> at
> org.apache.hadoop.security.UserGroupInformation.getGroupsSet(UserGroupInformation.java:1760)
> at
> org.apache.hadoop.security.UserGroupInformation.getPrimaryGroupName(UserGroupInformation.java:1603)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getGroupName(BasicRootedOzoneClientAdapterImpl.java:992)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatusAdapterForVolume(BasicRootedOzoneClientAdapterImpl.java:1016)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatus(BasicRootedOzoneClientAdapterImpl.java:574)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.getFileStatus(BasicRootedOzoneFileSystem.java:858)
> at org.apache.hadoop.fs.Globber.getFileStatus(Globber.java:115)
> at org.apache.hadoop.fs.Globber.doGlob(Globber.java:349)
> at org.apache.hadoop.fs.Globber.glob(Globber.java:202)
> at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:2106)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.globStatus(BasicRootedOzoneFileSystem.java:915)
> at org.apache.hadoop.fs.shell.PathData.expandAsGlob(PathData.java:353)
> at org.apache.hadoop.fs.shell.Command.expandArgument(Command.java:250)
> at
[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783114=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783114
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 20/Jun/22 18:39
Start Date: 20/Jun/22 18:39
Worklog Time Spent: 10m
Work Description: smengcl commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901931491
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##
@@ -215,7 +215,13 @@ private Set getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
Yes IMO we don't need the warn.
@swamirishi Just be sure to double check the debug log can actually be
enabled for example by setting
`org.apache.hadoop.security.ShellBasedUnixGroupsMapping=DEBUG` in
`log4j.properties` or JVM `-D` param.
nit: checkstyle
Issue Time Tracking
---
Worklog Id: (was: 783114)
Time Spent: 40m (was: 0.5h)
> Warnings should not be shown on cli console when linux user not present on
> client
> -
>
> Key: HADOOP-18306
> URL: https://issues.apache.org/jira/browse/HADOOP-18306
> Project: Hadoop Common
> Issue Type: New Feature
>Reporter: Swaminathan Balachandran
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code:java}
> {code}
> {noformat}
> 22/04/26 10:51:18 WARN security.ShellBasedUnixGroupsMapping: unable to return
> groups for user om
> PartialGroupNameException The user name 'om' is not found. id: ‘om’: no such
> user
> id: ‘om’: no such user
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.resolvePartialGroupNames(ShellBasedUnixGroupsMapping.java:291)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getUnixGroups(ShellBasedUnixGroupsMapping.java:215)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getGroupsSet(ShellBasedUnixGroupsMapping.java:123)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupSet(Groups.java:413)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:351)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:300)
> at
> com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
> at
> com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
> at
> com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
> at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
> at com.google.common.cache.LocalCache.get(LocalCache.java:3962)
> at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3985)
> at
> com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
> at org.apache.hadoop.security.Groups.getGroupInternal(Groups.java:258)
> at org.apache.hadoop.security.Groups.getGroupsSet(Groups.java:230)
> at
> org.apache.hadoop.security.UserGroupInformation.getGroupsSet(UserGroupInformation.java:1760)
> at
> org.apache.hadoop.security.UserGroupInformation.getPrimaryGroupName(UserGroupInformation.java:1603)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getGroupName(BasicRootedOzoneClientAdapterImpl.java:992)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatusAdapterForVolume(BasicRootedOzoneClientAdapterImpl.java:1016)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatus(BasicRootedOzoneClientAdapterImpl.java:574)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.getFileStatus(BasicRootedOzoneFileSystem.java:858)
> at org.apache.hadoop.fs.Globber.getFileStatus(Globber.java:115)
> at org.apache.hadoop.fs.Globber.doGlob(Globber.java:349)
> at org.apache.hadoop.fs.Globber.glob(Globber.java:202)
> at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:2106)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.globStatus(BasicRootedOzoneFileSystem.java:915)
> at org.apache.hadoop.fs.shell.PathData.expandAsGlob(PathData.java:353)
> at org.apache.hadoop.fs.shell.Command.expandArgument(Command.java:250)
> at
[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783113=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783113
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 20/Jun/22 18:38
Start Date: 20/Jun/22 18:38
Worklog Time Spent: 10m
Work Description: smengcl commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901931491
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##
@@ -215,7 +215,13 @@ private Set getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
IMO this is fine.
@swamirishi Just be sure to double check the debug log can actually be
enabled for example by setting
`org.apache.hadoop.security.ShellBasedUnixGroupsMapping=DEBUG` in
`log4j.properties` or JVM `-D` param.
nit: checkstyle
Issue Time Tracking
---
Worklog Id: (was: 783113)
Time Spent: 0.5h (was: 20m)
> Warnings should not be shown on cli console when linux user not present on
> client
> -
>
> Key: HADOOP-18306
> URL: https://issues.apache.org/jira/browse/HADOOP-18306
> Project: Hadoop Common
> Issue Type: New Feature
>Reporter: Swaminathan Balachandran
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> {code}
> {noformat}
> 22/04/26 10:51:18 WARN security.ShellBasedUnixGroupsMapping: unable to return
> groups for user om
> PartialGroupNameException The user name 'om' is not found. id: ‘om’: no such
> user
> id: ‘om’: no such user
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.resolvePartialGroupNames(ShellBasedUnixGroupsMapping.java:291)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getUnixGroups(ShellBasedUnixGroupsMapping.java:215)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getGroupsSet(ShellBasedUnixGroupsMapping.java:123)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupSet(Groups.java:413)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:351)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:300)
> at
> com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
> at
> com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
> at
> com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
> at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
> at com.google.common.cache.LocalCache.get(LocalCache.java:3962)
> at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3985)
> at
> com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
> at org.apache.hadoop.security.Groups.getGroupInternal(Groups.java:258)
> at org.apache.hadoop.security.Groups.getGroupsSet(Groups.java:230)
> at
> org.apache.hadoop.security.UserGroupInformation.getGroupsSet(UserGroupInformation.java:1760)
> at
> org.apache.hadoop.security.UserGroupInformation.getPrimaryGroupName(UserGroupInformation.java:1603)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getGroupName(BasicRootedOzoneClientAdapterImpl.java:992)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatusAdapterForVolume(BasicRootedOzoneClientAdapterImpl.java:1016)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatus(BasicRootedOzoneClientAdapterImpl.java:574)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.getFileStatus(BasicRootedOzoneFileSystem.java:858)
> at org.apache.hadoop.fs.Globber.getFileStatus(Globber.java:115)
> at org.apache.hadoop.fs.Globber.doGlob(Globber.java:349)
> at org.apache.hadoop.fs.Globber.glob(Globber.java:202)
> at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:2106)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.globStatus(BasicRootedOzoneFileSystem.java:915)
> at org.apache.hadoop.fs.shell.PathData.expandAsGlob(PathData.java:353)
> at org.apache.hadoop.fs.shell.Command.expandArgument(Command.java:250)
> at org.apache.hadoop.fs.shell.Command.expandArguments(Command.java:233)
> at
[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783111=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783111
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 20/Jun/22 18:17
Start Date: 20/Jun/22 18:17
Worklog Time Spent: 10m
Work Description: umamaheswararao commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901921272
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##
@@ -215,7 +215,13 @@ private Set getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
@smengcl do you think this is fine? or we don't need this in even in Warn?
we were hitting this log message. This current patch voids the full trace in
logs when debug is not enabled.
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##
@@ -215,7 +215,13 @@ private Set getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
can we just extract this into String msg = ""unable to return groups for
user {}" and use this msg to make log line looks clean?
Issue Time Tracking
---
Worklog Id: (was: 783111)
Time Spent: 20m (was: 10m)
> Warnings should not be shown on cli console when linux user not present on
> client
> -
>
> Key: HADOOP-18306
> URL: https://issues.apache.org/jira/browse/HADOOP-18306
> Project: Hadoop Common
> Issue Type: New Feature
>Reporter: Swaminathan Balachandran
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> {code}
> {noformat}
> 22/04/26 10:51:18 WARN security.ShellBasedUnixGroupsMapping: unable to return
> groups for user om
> PartialGroupNameException The user name 'om' is not found. id: ‘om’: no such
> user
> id: ‘om’: no such user
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.resolvePartialGroupNames(ShellBasedUnixGroupsMapping.java:291)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getUnixGroups(ShellBasedUnixGroupsMapping.java:215)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getGroupsSet(ShellBasedUnixGroupsMapping.java:123)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupSet(Groups.java:413)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:351)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:300)
> at
> com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
> at
> com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
> at
> com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
> at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
> at com.google.common.cache.LocalCache.get(LocalCache.java:3962)
> at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3985)
> at
> com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
> at org.apache.hadoop.security.Groups.getGroupInternal(Groups.java:258)
> at org.apache.hadoop.security.Groups.getGroupsSet(Groups.java:230)
> at
> org.apache.hadoop.security.UserGroupInformation.getGroupsSet(UserGroupInformation.java:1760)
> at
> org.apache.hadoop.security.UserGroupInformation.getPrimaryGroupName(UserGroupInformation.java:1603)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getGroupName(BasicRootedOzoneClientAdapterImpl.java:992)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatusAdapterForVolume(BasicRootedOzoneClientAdapterImpl.java:1016)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatus(BasicRootedOzoneClientAdapterImpl.java:574)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.getFileStatus(BasicRootedOzoneFileSystem.java:858)
> at
[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client
[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783101=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783101
]
ASF GitHub Bot logged work on HADOOP-18306:
---
Author: ASF GitHub Bot
Created on: 20/Jun/22 17:45
Start Date: 20/Jun/22 17:45
Worklog Time Spent: 10m
Work Description: swamirishi opened a new pull request, #4474:
URL: https://github.com/apache/hadoop/pull/4474
### Description of PR
[Warnings should not be shown on cli console when linux user not present on
client](https://issues.apache.org/jira/browse/HADOOP-18306)
### How was this patch tested?
Logging Changes
Issue Time Tracking
---
Worklog Id: (was: 783101)
Remaining Estimate: 0h
Time Spent: 10m
> Warnings should not be shown on cli console when linux user not present on
> client
> -
>
> Key: HADOOP-18306
> URL: https://issues.apache.org/jira/browse/HADOOP-18306
> Project: Hadoop Common
> Issue Type: New Feature
>Reporter: Swaminathan Balachandran
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> {code}
> {noformat}
> 22/04/26 10:51:18 WARN security.ShellBasedUnixGroupsMapping: unable to return
> groups for user om
> PartialGroupNameException The user name 'om' is not found. id: ‘om’: no such
> user
> id: ‘om’: no such user
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.resolvePartialGroupNames(ShellBasedUnixGroupsMapping.java:291)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getUnixGroups(ShellBasedUnixGroupsMapping.java:215)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getGroupsSet(ShellBasedUnixGroupsMapping.java:123)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupSet(Groups.java:413)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:351)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:300)
> at
> com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
> at
> com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
> at
> com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
> at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
> at com.google.common.cache.LocalCache.get(LocalCache.java:3962)
> at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3985)
> at
> com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
> at org.apache.hadoop.security.Groups.getGroupInternal(Groups.java:258)
> at org.apache.hadoop.security.Groups.getGroupsSet(Groups.java:230)
> at
> org.apache.hadoop.security.UserGroupInformation.getGroupsSet(UserGroupInformation.java:1760)
> at
> org.apache.hadoop.security.UserGroupInformation.getPrimaryGroupName(UserGroupInformation.java:1603)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getGroupName(BasicRootedOzoneClientAdapterImpl.java:992)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatusAdapterForVolume(BasicRootedOzoneClientAdapterImpl.java:1016)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatus(BasicRootedOzoneClientAdapterImpl.java:574)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.getFileStatus(BasicRootedOzoneFileSystem.java:858)
> at org.apache.hadoop.fs.Globber.getFileStatus(Globber.java:115)
> at org.apache.hadoop.fs.Globber.doGlob(Globber.java:349)
> at org.apache.hadoop.fs.Globber.glob(Globber.java:202)
> at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:2106)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.globStatus(BasicRootedOzoneFileSystem.java:915)
> at org.apache.hadoop.fs.shell.PathData.expandAsGlob(PathData.java:353)
> at org.apache.hadoop.fs.shell.Command.expandArgument(Command.java:250)
> at org.apache.hadoop.fs.shell.Command.expandArguments(Command.java:233)
> at
> org.apache.hadoop.fs.shell.FsCommand.processRawArguments(FsCommand.java:104)
> at org.apache.hadoop.fs.shell.Command.run(Command.java:177)
> at org.apache.hadoop.fs.FsShell.run(FsShell.java:328)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
> at org.apache.hadoop.fs.ozone.OzoneFsShell.main(OzoneFsShell.java:83)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
