date:20070103

Author: rwinston
Date: Wed Jan  3 03:20:00 2007
New Revision: 492106

URL: http://svn.apache.org/viewvc?view=revrev=492106
Log:
Add commons-parent

Modified:
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/pom.xml

Modified: jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/pom.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/pom.xml?view=diffrev=492106r1=492105r2=492106
==
--- jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/pom.xml (original)
+++ jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/pom.xml Wed Jan  3 
03:20:00 2007
@@ -25,6 +25,13 @@
inceptionYear1997/inceptionYear
descriptionJakarta Commons Net/description
 
+   parent
+   groupIdorg.apache.commons/groupId
+   artifactIdcommons-parent/artifactId
+   version1/version
+   /parent
+
+
pluginRepositories
pluginRepository
idsnapshots/id



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492107 - /jakarta/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java

Author: rwinston
Date: Wed Jan  3 03:22:28 2007
New Revision: 492107

URL: http://svn.apache.org/viewvc?view=revrev=492107
Log:
Fix calendar rollover bug

Modified:

jakarta/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java

Modified: 
jakarta/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java?view=diffrev=492107r1=492106r2=492107
==
--- 
jakarta/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
 (original)
+++ 
jakarta/commons/proper/net/trunk/src/test/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
 Wed Jan  3 03:22:28 2007
@@ -1,10 +1,9 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the License); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
+ * Copyright 2001-2006 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
  * http://www.apache.org/licenses/LICENSE-2.0
  *
@@ -91,6 +90,7 @@
cal.set(Calendar.MINUTE, 12);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
+   cal.set(Calendar.YEAR, f.getTimestamp().get(Calendar.YEAR));

assertEquals(df.format(cal.getTime()), 
df.format(f.getTimestamp()
.getTime()));
@@ -127,3 +127,4 @@


 }
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492108 - /jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java

Author: rwinston
Date: Wed Jan  3 03:23:44 2007
New Revision: 492108

URL: http://svn.apache.org/viewvc?view=revrev=492108
Log:
Test keyword expansion

Modified:

jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
   (contents, props changed)

Modified: 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java?view=diffrev=492108r1=492107r2=492108
==
--- 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
 (original)
+++ 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
 Wed Jan  3 03:23:44 2007
@@ -18,7 +18,7 @@
 import java.util.Calendar;
 
 import junit.framework.TestSuite;
-
+ 
 import org.apache.commons.net.ftp.FTPFile;
 import org.apache.commons.net.ftp.FTPFileEntryParser;
 

Propchange: 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
--
svn:keywords = 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492109 - /jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java

Author: rwinston
Date: Wed Jan  3 03:24:57 2007
New Revision: 492109

URL: http://svn.apache.org/viewvc?view=revrev=492109
Log:
Test keyword expansion

Modified:

jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
   (contents, props changed)

Modified: 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java?view=diffrev=492109r1=492108r2=492109
==
--- 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
 (original)
+++ 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
 Wed Jan  3 03:24:57 2007
@@ -16,7 +16,7 @@
 package org.apache.commons.net.ftp.parser;
 
 import java.util.Calendar;
-
+ 
 import junit.framework.TestSuite;
  
 import org.apache.commons.net.ftp.FTPFile;

Propchange: 
jakarta/commons/proper/net/branches/JDK_1_5_BRANCH/src/test/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParserTest.java
--
--- svn:keywords (original)
+++ svn:keywords Wed Jan  3 03:24:57 2007
@@ -0,0 +1 @@
+Id Date URL HeadURL Rev



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [io] Pre 1.3 build

2007-01-03 Thread Jörg Schaible

Henri Yandell wrote on Tuesday, January 02, 2007 10:56 PM:

 Using:
 
 jvm 1.3  ant dist  jvm 1.4  maven site
 
 I've built the following:
 
 http://people.apache.org/~bayard/commons-io/commons-io-snapshot-build/
 
 Anything need fixing up before doing the real build? I'll make the
 version number 1.3 when I do that etc.
 
 The only thing that stands out for me is that a
 commons-io-1.3-SNAPSHOT-src-ide.zip file is created when we might want
 it to be named commons-io-1.3-SNAPSHOT-src.jar to match the ones
 Maven-2 makes. We could also be creating a javadoc jar.

M2 creates -sources.jar files :)

- Jörg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project commons-jelly-tags-soap (in module commons-jelly) failed

2007-01-03 Thread commons-jelly-tags-soap development

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-soap has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 22 runs.
The current state of this project is 'Failed', with reason 'Configuration 
Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-soap :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-soap-03012007.jar] identifier set to 
project name
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on 
Project:commons-jelly-tags-soap
 -DEBUG- Dependency on ws-axis exists, no need to add for property 
maven.jar.axis.
 -DEBUG- Dependency on ws-axis exists, no need to add for property 
maven.jar.jaxrpc-api.
 -DEBUG- Dependency on ws-axis exists, no need to add for property 
maven.jar.saaj-api.
 -DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for 
property maven.jar.servletapi.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -INFO- Failed with reason configuration failed
 -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace
 -INFO- Failed to extract fallback artifacts from Gump Repository

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 2003012007, vmgump.apache.org:vmgump-public:2003012007
Gump E-mail Identifier (unique within run) #31.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project commons-jelly-tags-soap (in module commons-jelly) failed

2007-01-03 Thread commons-jelly-tags-soap development

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-soap has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 22 runs.
The current state of this project is 'Failed', with reason 'Configuration 
Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-soap :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-soap-03012007.jar] identifier set to 
project name
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on 
Project:commons-jelly-tags-soap
 -DEBUG- Dependency on ws-axis exists, no need to add for property 
maven.jar.axis.
 -DEBUG- Dependency on ws-axis exists, no need to add for property 
maven.jar.jaxrpc-api.
 -DEBUG- Dependency on ws-axis exists, no need to add for property 
maven.jar.saaj-api.
 -DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for 
property maven.jar.servletapi.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -INFO- Failed with reason configuration failed
 -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace
 -INFO- Failed to extract fallback artifacts from Gump Repository

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 2003012007, vmgump.apache.org:vmgump-public:2003012007
Gump E-mail Identifier (unique within run) #31.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[nightly build] net failed.

2007-01-03 Thread psteitz

Failed build logs:
http://people.apache.org/~psteitz/commons-nightlies/20070103/net.log

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed

2007-01-03 Thread commons-jelly-tags-jaxme development

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-jaxme has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 22 runs.
The current state of this project is 'Failed', with reason 'Configuration 
Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-jaxme :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-jaxme-03012007.jar] identifier set to 
project name
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-js on: Maven on 
Project:commons-jelly-tags-jaxme
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme on: Maven on 
Project:commons-jelly-tags-jaxme
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on 
Project:commons-jelly-tags-jaxme
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-xs on: Maven on 
Project:commons-jelly-tags-jaxme
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -INFO- Failed with reason configuration failed
 -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace
 -INFO- Failed to extract fallback artifacts from Gump Repository

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 2003012007, vmgump.apache.org:vmgump-public:2003012007
Gump E-mail Identifier (unique within run) #37.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed

2007-01-03 Thread commons-jelly-tags-jaxme development

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-jaxme has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 22 runs.
The current state of this project is 'Failed', with reason 'Configuration 
Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-jaxme :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-jaxme-03012007.jar] identifier set to 
project name
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- No such project [ws-jaxme] for property.
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-js on: Maven on 
Project:commons-jelly-tags-jaxme
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme on: Maven on 
Project:commons-jelly-tags-jaxme
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on 
Project:commons-jelly-tags-jaxme
 -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme]
 -ERROR- Unhandled Property: maven.jar.jaxme-xs on: Maven on 
Project:commons-jelly-tags-jaxme
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -INFO- Failed with reason configuration failed
 -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace
 -INFO- Failed to extract fallback artifacts from Gump Repository

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.2.
Gump Run 2003012007, vmgump.apache.org:vmgump-public:2003012007
Gump E-mail Identifier (unique within run) #37.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (VFS-105) Make it possible to generate VFS sandbox jar with Ant

2007-01-03 Thread Maarten Coene (JIRA)

Make it possible to generate VFS sandbox jar with Ant
-

 Key: VFS-105
 URL: https://issues.apache.org/jira/browse/VFS-105
 Project: Commons VFS
  Issue Type: Improvement
Reporter: Maarten Coene


I use the VFS-sandbox.jar in my project.
Unfortunately, gump cannot build my project at the moment because the 
VFS-sandbox.jar isn't available in gump since gump doesn't support M2.
If this sandbox jar could be built via Ant, it could be made available in gump.

Maarten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (CONFIGURATION-247) recognize changes in included Propertiefiles

2007-01-03 Thread Mirko Wolf (JIRA)

recognize changes in included Propertiefiles


 Key: CONFIGURATION-247
 URL: https://issues.apache.org/jira/browse/CONFIGURATION-247
 Project: Commons Configuration
  Issue Type: New Feature
Reporter: Mirko Wolf


Properties-Files included in other properties-Files should be recognized by the 
event-listener / reloading-strategie set on the main properties-File. This is 
necessary  in case of modifications in these included Files.

for instance:

main.properties
include=sample.properties


sample.properties
[EMAIL PROTECTED]
...

when i change the value of mail.address i definitly need a restart of my 
application.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Updated: (LANG-306) Extra StrBuilder methods


 [ 
https://issues.apache.org/jira/browse/LANG-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Colebourne updated LANG-306:


Attachment: lang.patch

 Extra StrBuilder methods
 

 Key: LANG-306
 URL: https://issues.apache.org/jira/browse/LANG-306
 Project: Commons Lang
  Issue Type: Improvement
Reporter: Stephen Colebourne
Priority: Minor
 Fix For: 2.3

 Attachments: lang.patch, StrBuilder.java


 Append all the elements in a collection with no separator:
 StrBuilder.appendAll(Collection)
 StrBuilder.appendAll(Object[])
 StrBuilder.appendAll(Iterator)
 Append the data followed by a new line:
 StrBuilder.appendln(...)
 Append a separator if the buffer is not empty:
 StrBuilder.appendSeparator(String)
 Append a separator if the index  0:
 StrBuilder.appendSeparator(String, index)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Closed: (EMAIL-9) [email] Issue with host settings in a shared Server environment

2007-01-03 Thread Paul J DeCoursey (JIRA)


 [ 
https://issues.apache.org/jira/browse/EMAIL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul J DeCoursey closed EMAIL-9.


Resolution: Fixed

I think this was fixed.  I thought that it got closed out already too. I 
discovered what the issue was a few days after I reported this, and then 
discovered that it had been fixed already, we just had an older jar.

 [email] Issue with host settings in a shared Server environment
 ---

 Key: EMAIL-9
 URL: https://issues.apache.org/jira/browse/EMAIL-9
 Project: Commons Email
  Issue Type: Bug
 Environment: Operating System: other
 Platform: All
Reporter: Paul J DeCoursey

 So the quick and dirty is I'm setting up an HTMLEmail and the server is in a
 shared environment, there is another site on the server using commons-email, 
 and
 I have no control over that site.  I set the hostname and the authentication 
 but
 after that it's taking the settings from the System.properies. Below is a snip
 from my code.
 org.apache.commons.mail.HtmlEmail email = new 
 org.apache.commons.mail.HtmlEmail();
 email.setHostName(server);
 email.setAuthentication(username, password);
 After that point I can get the session:
 Session sess = email.getMailSession();
 sess.getProperty(mail.smtp.host);
  and the result of the getProperty(mail.smtp.host) does not equal the 
 setting
 from the above server variable.  It is now set to the value from
 System.propeties, again, not my setting.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release Commons Transaction 1.2

2007-01-03 Thread Niall Pemberton


Hi Oliver,

Since RC3 was created (back in July 2006!) there is now the new
Source Header and Copyright Notice Policy that needs to be complied
with:
 http://www.apache.org/legal/src-headers.html

Henri fixed this in the trunk for transaction a few weeks ago - but
warrants a new RC IMO.

Also Rahul raised the issue about dependency jars held in the
repository - and it looked to me like you were going to change the
build to download these automatically, rather than including them in
the distro:
 http://tinyurl.com/yby9hd

I also think given the long time between cutting the RC and voting
this makes the case for tagging the repository - initially I wondered
where this had been built from as it didn't match any current source -
until I releaized it had been done so long ago.

Niall

On 12/27/06, Oliver Zeigermann [EMAIL PROTECTED] wrote:

We have worked our way through three release candidates now and the
latest has been out there for quite some time without substantial
shortcomings reported:

http://people.apache.org/~ozeigermann/tx-1.2rc3/

To release 1.2 final based on that release candidate here is my

+1

Cheers

Oliver


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (NET-145) Deadlock in TelnetInputStream

2007-01-03 Thread Marco Campelo (JIRA)


[ 
https://issues.apache.org/jira/browse/NET-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461984
 ] 

Marco Campelo commented on NET-145:
---

This deadlock happens when you lost the connection with the FTP server and 
tries to send a logout () command.

Find below the thead dump from a Solaris box:

Full thread dump Java HotSpot(TM) Client VM (1.4.2_08-b03 mixed mode):

Thread-0 daemon prio=6 tid=0x001cbf18 nid=0x9 runnable [f9a7f000..f9a7fc30]
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:129)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:183)
at java.io.BufferedInputStream.read(BufferedInputStream.java:201)
- locked 0xf1845a20 (a java.io.BufferedInputStream)
at java.io.FilterInputStream.read(FilterInputStream.java:66)
at java.io.PushbackInputStream.read(PushbackInputStream.java:120)
at 
org.apache.commons.net.io.FromNetASCIIInputStream.__read(FromNetASCIIInputStream.java:75)
at 
org.apache.commons.net.io.FromNetASCIIInputStream.read(FromNetASCIIInputStream.java:170)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:183)
at java.io.BufferedInputStream.read(BufferedInputStream.java:201)
- locked 0xf1846988 (a 
org.apache.commons.net.telnet.TelnetInputStream)
at 
org.apache.commons.net.telnet.TelnetInputStream.__read(TelnetInputStream.java:114)
at 
org.apache.commons.net.telnet.TelnetInputStream.run(TelnetInputStream.java:535)
at java.lang.Thread.run(Thread.java:534)

Signal Dispatcher daemon prio=10 tid=0x000cddc0 nid=0x6 waiting on condition 
[0..0]

Finalizer daemon prio=8 tid=0x000c7d68 nid=0x4 in Object.wait() 
[fc77f000..fc77fc30]
at java.lang.Object.wait(Native Method)
- waiting on 0xf1f437a8 (a java.lang.ref.ReferenceQueue$Lock)
at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:111)
- locked 0xf1f437a8 (a java.lang.ref.ReferenceQueue$Lock)
at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:127)
at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:159)

Reference Handler daemon prio=10 tid=0x000c72e8 nid=0x3 in Object.wait() 
[fe27f000..fe27fc30]
at java.lang.Object.wait(Native Method)
- waiting on 0xf1f43810 (a java.lang.ref.Reference$Lock)
at java.lang.Object.wait(Object.java:429)
at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:115)
- locked 0xf1f43810 (a java.lang.ref.Reference$Lock)

main prio=5 tid=0x000356b8 nid=0x1 in Object.wait() [ffbfe000..ffbff164]
at java.lang.Object.wait(Native Method)
- waiting on 0xf18475f8 (a [I)
at java.lang.Object.wait(Object.java:429)
at 
org.apache.commons.net.telnet.TelnetInputStream.read(TelnetInputStream.java:339)
- locked 0xf18475f8 (a [I)
at 
org.apache.commons.net.telnet.TelnetInputStream.read(TelnetInputStream.java:466)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:220)
at java.io.BufferedInputStream.read(BufferedInputStream.java:277)
- locked 0xf1849700 (a java.io.BufferedInputStream)
at sun.nio.cs.StreamDecoder$CharsetSD.readBytes(StreamDecoder.java:408)
at sun.nio.cs.StreamDecoder$CharsetSD.implRead(StreamDecoder.java:450)
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:182)
- locked 0xf184a0c0 (a java.io.InputStreamReader)
at java.io.InputStreamReader.read(InputStreamReader.java:167)
at java.io.BufferedReader.fill(BufferedReader.java:136)
at java.io.BufferedReader.readLine(BufferedReader.java:299)
- locked 0xf184a0c0 (a java.io.InputStreamReader)
at java.io.BufferedReader.readLine(BufferedReader.java:362)
at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:264)
at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:460)
at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:520)
at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:569)
at org.apache.commons.net.ftp.FTP.quit(FTP.java:781)
at org.apache.commons.net.ftp.FTPClient.logout(FTPClient.java:706)
at com.nokia.ci.nwg.util.ftp.FTPHandler.disconnect(FTPHandler.java:318)
at 
com.nokia.ci.nwg.CDRTransmitter.doPerformControl(CDRTransmitter.java:71)
at com.nokia.ci.nwg.CDRProcessor.doProccessCDRs(CDRProcessor.java:59)
at com.nokia.ci.nwg.CDRProcessor.main(CDRProcessor.java:85)

VM Thread prio=5 tid=0x000c64a0 nid=0x2 runnable

VM Periodic Task Thread prio=10 tid=0x000d0c20 nid=0x8 waiting on condition
Suspend Checker Thread prio=10 tid=0x000cd488 nid=0x5 runnable

 Deadlock in TelnetInputStream
 -

 Key: NET-145
 URL: https://issues.apache.org/jira/browse/NET-145
 Project:

[jira] Created: (BETWIXT-57) Class loader problem in JBoss version 4.0.4GA

2007-01-03 Thread Surjit Sen (JIRA)

Class loader problem in JBoss version 4.0.4GA
-

 Key: BETWIXT-57
 URL: https://issues.apache.org/jira/browse/BETWIXT-57
 Project: Commons Betwixt
  Issue Type: Bug
 Environment: JBoss application server version 4.0.4GA. Probably 
affects most versions of JBoss
Reporter: Surjit Sen
Priority: Critical


When using betwixt in a JBoss application, Class not found exceptions get 
thrown when Class.forName methods are called in classes 
org.apache.commons.betwixt.digester.ElementRule and 
org.apache.commons.betwixt.digester.ClassRule. Specifically the Class.forName 
method uses the system class loader to load classes and in JBoss the classpath 
normally does not contain the application jar files. The fix is very simple. 
The Class.forName method calls in both the classes were replaced with the 
following code lines in ElementRule and similar changes were made in ClassRule 
as well. This fix ensures that the appropriate class loader is used for loading 
classes and is similar to the fix made in log4j.

ClassLoader loader = 
Thread.currentThread().getContextClassLoader();
if (loader == null) {
loader = 
Class.forName(implementationClass).getClassLoader();
//Class clazz = Class.forName(implementationClass);
}
Class clazz = loader.loadClass(implementationClass);
descriptor.setImplementationClass(clazz);


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (NET-91) commons.net.FTPClient hangs on disconnect or logout

2007-01-03 Thread Marco Campelo (JIRA)


[ 
https://issues.apache.org/jira/browse/NET-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461987
 ] 

Marco Campelo commented on NET-91:
--

It is easy to reproduce this issue.

While you are transmitting a file to the FTP server, disconnect your FTP Server 
from the network.

It will generate the CopyStreamException after around 9 minutes which I believe 
is the default timeout.

At this moment, if you try to logout from the FTP Server, your java code will 
stay in deadlock and will never end.

I already tried to test if the ftp is connected using the isConnected method 
but it always returns true.

 commons.net.FTPClient hangs on disconnect or logout
 ---

 Key: NET-91
 URL: https://issues.apache.org/jira/browse/NET-91
 Project: Commons Net
  Issue Type: Bug
 Environment: Operating System: All
 Platform: PC
Reporter: Joe

 By repetitively calling 
 try { 
 
 // connect and login to the FTP server
 ftpc.connect(getPropertyFromEnv(FTP_SERVER));
 
 ftpc.login(getPropertyFromEnv(USERNAME), getPropertyFromEnv
 (PASSWORD));   //technically we may have to break this into 2 blocks see 
 examples
 // After connection attempt, check the reply code to verify 
 success.
 reply = ftpc.getReplyCode();
 response = ftpc.getReplyString();
 if(!FTPReply.isPositiveCompletion(reply)) {
 System.err.println(FTP server refused connection or login.);
 killFTP(ftpc);
 ftpc = null;
 }
 } catch(IOException e) {
 System.err.println(Can't connect or login to server, reply 
 = +reply+  response =  + response);
 killFTP(ftpc);
 ftpc = null;
 }
 and then
 if (ftpc.isConnected()) {
 try {
 ftpc.logout();
 } catch (Exception e) { // do nothing 
 System.out.println(Exception in ftpc.logout());
 }
 try {
 ftpc.disconnect();
 } catch (Exception e) { // do nothing 
 System.out.println(Exception in ftpc.disconnect());
 }
 }
 one of the two bottom calls hangs and I'm assuming that it's in an infinite
 loop waiting for something that the server isn't sending.  We try and hook to
 a Linux FTP server, and Windows FTP server and 99.99 % of the time it works, 
 but every once in a while, it hangs and we have to kill the FTP daemon.  
 After 
 doing that everything works again!!!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Updated: (NET-91) commons.net.FTPClient hangs on disconnect or logout

2007-01-03 Thread Marco Campelo (JIRA)


 [ 
https://issues.apache.org/jira/browse/NET-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Campelo updated NET-91:
-

Affects Version/s: 1.4 Final

 commons.net.FTPClient hangs on disconnect or logout
 ---

 Key: NET-91
 URL: https://issues.apache.org/jira/browse/NET-91
 Project: Commons Net
  Issue Type: Bug
Affects Versions: 1.4 Final
 Environment: Operating System: All
 Platform: PC
Reporter: Joe

 By repetitively calling 
 try { 
 
 // connect and login to the FTP server
 ftpc.connect(getPropertyFromEnv(FTP_SERVER));
 
 ftpc.login(getPropertyFromEnv(USERNAME), getPropertyFromEnv
 (PASSWORD));   //technically we may have to break this into 2 blocks see 
 examples
 // After connection attempt, check the reply code to verify 
 success.
 reply = ftpc.getReplyCode();
 response = ftpc.getReplyString();
 if(!FTPReply.isPositiveCompletion(reply)) {
 System.err.println(FTP server refused connection or login.);
 killFTP(ftpc);
 ftpc = null;
 }
 } catch(IOException e) {
 System.err.println(Can't connect or login to server, reply 
 = +reply+  response =  + response);
 killFTP(ftpc);
 ftpc = null;
 }
 and then
 if (ftpc.isConnected()) {
 try {
 ftpc.logout();
 } catch (Exception e) { // do nothing 
 System.out.println(Exception in ftpc.logout());
 }
 try {
 ftpc.disconnect();
 } catch (Exception e) { // do nothing 
 System.out.println(Exception in ftpc.disconnect());
 }
 }
 one of the two bottom calls hangs and I'm assuming that it's in an infinite
 loop waiting for something that the server isn't sending.  We try and hook to
 a Linux FTP server, and Windows FTP server and 99.99 % of the time it works, 
 but every once in a while, it hangs and we have to kill the FTP daemon.  
 After 
 doing that everything works again!!!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Deadlock found in Commons Net FTP

2007-01-03 Thread Marco Campelo


Hello All,

I found a deadlock in Commons Net FTP in the following situation:

1) Start transmitting a file to a FTP Server
2) Disconnect the FTP Server from the network (CopyStreamException
will be throw at this point after timeout occurs ~9 minutes)
3) Try to logout from FTP Server:

Application will stay in deadlock. I killed the application using a
kill -3 command and got the output that is available below.

I found two similar bugs already reported:

commons.net.FTPClient hangs on disconnect or logout
https://issues.apache.org/jira/browse/NET-91

Deadlock in TelnetInputStream
https://issues.apache.org/jira/browse/NET-145

I read the the bug fix for the issue Deadlock in TelnetInputStream
is available only in Commons Net FTP 2.0 and it requires JDK 1.5.

The problem is that our application is running on JDK 1.4 and we
wouldn't like to use a unstable version.

Is there any bug fix or workaround available for Commons Net 1.4.1?

Really appreciate your help.

BR,
Marco Campêlo

Full thread dump Java HotSpot(TM) Client VM (1.4.2_08-b03 mixed mode):

Thread-0 daemon prio=6 tid=0x001cbf18 nid=0x9 runnable [f9a7f000..f9a7fc30]
   at java.net.SocketInputStream.socketRead0(Native Method)
   at java.net.SocketInputStream.read(SocketInputStream.java:129)
   at java.io.BufferedInputStream.fill(BufferedInputStream.java:183)
   at java.io.BufferedInputStream.read(BufferedInputStream.java:201)
   - locked 0xf1845a20 (a java.io.BufferedInputStream)
   at java.io.FilterInputStream.read(FilterInputStream.java:66)
   at java.io.PushbackInputStream.read(PushbackInputStream.java:120)
   at 
org.apache.commons.net.io.FromNetASCIIInputStream.__read(FromNetASCIIInputStream.java:75)
   at 
org.apache.commons.net.io.FromNetASCIIInputStream.read(FromNetASCIIInputStream.java:170)
   at java.io.BufferedInputStream.fill(BufferedInputStream.java:183)
   at java.io.BufferedInputStream.read(BufferedInputStream.java:201)
   - locked 0xf1846988 (a
org.apache.commons.net.telnet.TelnetInputStream)
   at 
org.apache.commons.net.telnet.TelnetInputStream.__read(TelnetInputStream.java:114)
   at 
org.apache.commons.net.telnet.TelnetInputStream.run(TelnetInputStream.java:535)
   at java.lang.Thread.run(Thread.java:534)

Signal Dispatcher daemon prio=10 tid=0x000cddc0 nid=0x6 waiting on
condition [0..0]

Finalizer daemon prio=8 tid=0x000c7d68 nid=0x4 in Object.wait()
[fc77f000..fc77fc30]
   at java.lang.Object.wait(Native Method)
   - waiting on 0xf1f437a8 (a java.lang.ref.ReferenceQueue$Lock)
   at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:111)
   - locked 0xf1f437a8 (a java.lang.ref.ReferenceQueue$Lock)
   at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:127)
   at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:159)

Reference Handler daemon prio=10 tid=0x000c72e8 nid=0x3 in
Object.wait() [fe27f000..fe27fc30]
   at java.lang.Object.wait(Native Method)
   - waiting on 0xf1f43810 (a java.lang.ref.Reference$Lock)
   at java.lang.Object.wait(Object.java:429)
   at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:115)
   - locked 0xf1f43810 (a java.lang.ref.Reference$Lock)

main prio=5 tid=0x000356b8 nid=0x1 in Object.wait() [ffbfe000..ffbff164]
   at java.lang.Object.wait(Native Method)
   - waiting on 0xf18475f8 (a [I)
   at java.lang.Object.wait(Object.java:429)
   at 
org.apache.commons.net.telnet.TelnetInputStream.read(TelnetInputStream.java:339)
   - locked 0xf18475f8 (a [I)
   at 
org.apache.commons.net.telnet.TelnetInputStream.read(TelnetInputStream.java:466)
   at java.io.BufferedInputStream.read1(BufferedInputStream.java:220)
   at java.io.BufferedInputStream.read(BufferedInputStream.java:277)
   - locked 0xf1849700 (a java.io.BufferedInputStream)
   at sun.nio.cs.StreamDecoder$CharsetSD.readBytes(StreamDecoder.java:408)
   at sun.nio.cs.StreamDecoder$CharsetSD.implRead(StreamDecoder.java:450)
   at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:182)
   - locked 0xf184a0c0 (a java.io.InputStreamReader)
   at java.io.InputStreamReader.read(InputStreamReader.java:167)
   at java.io.BufferedReader.fill(BufferedReader.java:136)
   at java.io.BufferedReader.readLine(BufferedReader.java:299)
   - locked 0xf184a0c0 (a java.io.InputStreamReader)
   at java.io.BufferedReader.readLine(BufferedReader.java:362)
   at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:264)
   at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:460)
   at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:520)
   at org.apache.commons.net.ftp.FTP.sendCommand(FTP.java:569)
   at org.apache.commons.net.ftp.FTP.quit(FTP.java:781)
   at org.apache.commons.net.ftp.FTPClient.logout(FTPClient.java:706)
   at com.nokia.ci.nwg.util.ftp.FTPHandler.disconnect(FTPHandler.java:318)
   at

svn commit: r492212 - in /jakarta/commons/proper/configuration/trunk: conf/checkstyle.xml project.properties

2007-01-03 Thread oheger

Author: oheger
Date: Wed Jan  3 08:48:47 2007
New Revision: 492212

URL: http://svn.apache.org/viewvc?view=revrev=492212
Log:
Modified checkstyle settings to reduce number of warnings

Modified:
jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml
jakarta/commons/proper/configuration/trunk/project.properties

Modified: jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml?view=diffrev=492212r1=492211r2=492212
==
--- jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml (original)
+++ jakarta/commons/proper/configuration/trunk/conf/checkstyle.xml Wed Jan  3 
08:48:47 2007
@@ -34,6 +34,7 @@
 module name=JavadocMethod
 property name=scope value=public/
 property name=allowUndeclaredRTE value=true/
+   property name=allowMissingJavadoc value=true/
 /module
 module name=JavadocType
 property name=authorFormat value=\S/
@@ -118,14 +119,12 @@
 !-- See http://checkstyle.sf.net/config_coding.html --
 module name=CovariantEquals/
 module name=DoubleCheckedLocking/
-module name=EmptyStatement/
 module name=EqualsHashCode/
 module name=IllegalInstantiation/
 module name=InnerAssignment/
 module name=MagicNumber
 property name=ignoreNumbers value=-1,0,1,2,3/
 /module
-module name=MissingSwitchDefault/
 module name=RedundantThrows
 property name=allowUnchecked value=true/
 /module
@@ -134,7 +133,6 @@
 module name=StringLiteralEquality/
 module name=SuperClone/
 module name=SuperFinalize/
-module name=IllegalType/
 module name=DeclarationOrder/
 module name=ExplicitInitialization/
 module name=DefaultComesLast/

Modified: jakarta/commons/proper/configuration/trunk/project.properties
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/project.properties?view=diffrev=492212r1=492211r2=492212
==
--- jakarta/commons/proper/configuration/trunk/project.properties (original)
+++ jakarta/commons/proper/configuration/trunk/project.properties Wed Jan  3 
08:48:47 2007
@@ -24,13 +24,14 @@
 compile.deprecation = off
 
 maven.checkstyle.properties=conf/checkstyle.xml
+maven.checkstyle.check.tests=false
 maven.pmd.excludes=**/*PropertyListParser*
 
 maven.junit.fork=true
 maven.test.failure.ignore=false
 maven.test.skip=false
 
-maven.javadoc.links=http://java.sun.com/j2se/1.5/docs/api/, 
http://java.sun.com/j2ee/1.4/docs/api/, 
http://jakarta.apache.org/commons/collections/apidocs/, 
http://jakarta.apache.org/commons/digester/apidocs/, 
http://jakarta.apache.org/commons/lang/apidocs/, http://www.dom4j.org/apidocs/
+maven.javadoc.links=http://java.sun.com/j2se/1.5/docs/api/, 
http://java.sun.com/j2ee/1.4/docs/api/, 
http://jakarta.apache.org/commons/collections/apidocs/, 
http://jakarta.apache.org/commons/digester/apidocs/, 
http://jakarta.apache.org/commons/lang/apidocs/, 
http://jakarta.apache.org/commons/beanutils/apidocs/
 
 #cactus settings.  Make sure to point to your Tomcat!
 cactus.home.tomcat4x = c:/java/tomcat



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492216 - in /jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration: ./ beanutils/ interpol/ plist/

2007-01-03 Thread oheger

Author: oheger
Date: Wed Jan  3 08:51:24 2007
New Revision: 492216

URL: http://svn.apache.org/viewvc?view=revrev=492216
Log:
Addressed checkstyle warnings

Added:

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/interpol/package.html
   (with props)
Modified:

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/CompositeConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/ConfigurationMap.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/HierarchicalConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/INIConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/XMLConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/ConfigurationDynaBean.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/ConfigurationDynaClass.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/plist/XMLPropertyListConfiguration.java

Modified: 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java?view=diffrev=492216r1=492215r2=492216
==
--- 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
 (original)
+++ 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
 Wed Jan  3 08:51:24 2007
@@ -636,11 +636,15 @@
 }
 else
 {
-try {
+try
+{
 path = ConfigurationUtils.getURL(getBasePath(),
 getFileName()).getPath();
-} catch (MalformedURLException e) {
+}
+catch (MalformedURLException e)
+{
 // simply ignore it and return null
+;
 }
 }
 }

Modified: 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java?view=diffrev=492216r1=492215r2=492216
==
--- 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java
 (original)
+++ 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java
 Wed Jan  3 08:51:24 2007
@@ -51,16 +51,16 @@
  */
 private FileConfigurationDelegate delegate;
 
-   /**
+/**
  * Creates a new instance of
  * codeAbstractHierarchicalFileConfiguration/code.
  */
-   protected AbstractHierarchicalFileConfiguration()
-   {
-   initialize();
-   }
+protected AbstractHierarchicalFileConfiguration()
+{
+initialize();
+}
 
-   /**
+/**
  * Creates a new instance of
  * codeAbstractHierarchicalFileConfiguration/code and copies the
  * content of the specified configuration into this object.
@@ -68,13 +68,13 @@
  * @param c the configuration to copy
  * @since 1.4
  */
-   protected 
AbstractHierarchicalFileConfiguration(HierarchicalConfiguration c)
-   {
-   super(c);
-   initialize();
-   }
+protected AbstractHierarchicalFileConfiguration(HierarchicalConfiguration 
c)
+{
+super(c);
+initialize();
+}
 
-   /**
+/**
  * Creates and loads the configuration from the specified file.
  *
  * @param fileName The name of the plist file to load.
@@ -125,16 +125,16 @@
 load();
 }
 
-   /**
+/**
  * Initializes this instance, mainly the internally used delegate object.
  */
-

Re: [all] Jira reporting

2007-01-03 Thread Henri Yandell


On 1/3/07, Joerg Heinicke [EMAIL PROTECTED] wrote:

Henri Yandell flamefew at gmail.com writes:

 The aim is to provide us with information on where projects are
 release-wise and where we are in terms of answering new issues. Some
 of our components aren't there - for example Jelly which has 77
 unversioned issues and Attributes/Discovery which are ready to be
 retired. Some of the ones there should probably be removed for having
 too many unversioned issues.

I wonder what's the problem with unversioned issues. It simply says in the
future. Any exact targetting for unresolved issues will lead to this issues
hasn't made it into the latest release, we try to get it into the next one
mails polluting the mailing lists without nearly any additional value.


I think that is a good thing as it means someone is looking at that
issue each release and deciding that it won't go in that release. If
it keeps getting punted all the time then someone can ask if it's ever
going to happen. Lang has a good example of an 'in the future'
version. There's a JDK 1.5 Release version for a couple of issues
that have constraints holding them back from going in any version
soon.

More importantly to the above - my comment that components with lots
of unversioned issues need to be removed is not a slander against
those components but a sign that they're not using the lightweight
workflow I'm creating the report for:

* unversioned = unaccepted
* next version = being worked upon
* post next version = later (though can usually be bumped to next
version if it has a patch/unit test)
* other versions = 


Dennis Lundberg dennisl at apache.org writes:

 And any component with a high number of solved issues deserves a
 release, no matter what the total says, say like 40/300.

If it's just the number of resolved issues, you don't need the number of
unresolved issues assigned to a target release. I tend to agree with this POV.


It can depend. I agree with Dennis' statement that a high number of
resolved should be flagging a release (which is one of the reasons for
the report), but if there were truly 300 issues planned for that
release, then it's possible there was a reason. The first step after
the release has been flagging is for someone to review the 260 and
move them to another version - ie) to rethink the release plan.

Seeing the 300 figure is pretty useful in that it tells us that a
release plan is probably too much. BeanUtils has 79 issues in its
1.8.0. A bunch probably shouldn't go in 1.8.0, but when I went through
the 100+ issues that were there those were the ones that I thought we
should at least be looking at prior to the next release.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [all] Jira reporting

2007-01-03 Thread Martin Cooper


On 1/3/07, Henri Yandell [EMAIL PROTECTED] wrote:


On 1/3/07, Joerg Heinicke [EMAIL PROTECTED] wrote:
 Henri Yandell flamefew at gmail.com writes:

  The aim is to provide us with information on where projects are
  release-wise and where we are in terms of answering new issues. Some
  of our components aren't there - for example Jelly which has 77
  unversioned issues and Attributes/Discovery which are ready to be
  retired. Some of the ones there should probably be removed for having
  too many unversioned issues.

 I wonder what's the problem with unversioned issues. It simply says in
the
 future. Any exact targetting for unresolved issues will lead to this
issues
 hasn't made it into the latest release, we try to get it into the next
one
 mails polluting the mailing lists without nearly any additional value.

I think that is a good thing as it means someone is looking at that
issue each release and deciding that it won't go in that release. If
it keeps getting punted all the time then someone can ask if it's ever
going to happen.



This is exactly why we moved to something like what Hen is proposing for
Struts. We had oodles of issues just sitting there with no indication of
when, if ever, they were likely to be fixed, and no indication of whether
anyone was committed to looking at them. Once you start versioning the
issues, you get the beginnings of a roadmap rather than just a bucket of
issues.

--
Martin Cooper


Lang has a good example of an 'in the future'

version. There's a JDK 1.5 Release version for a couple of issues
that have constraints holding them back from going in any version
soon.

More importantly to the above - my comment that components with lots
of unversioned issues need to be removed is not a slander against
those components but a sign that they're not using the lightweight
workflow I'm creating the report for:

* unversioned = unaccepted
* next version = being worked upon
* post next version = later (though can usually be bumped to next
version if it has a patch/unit test)
* other versions = 

 Dennis Lundberg dennisl at apache.org writes:

  And any component with a high number of solved issues deserves a
  release, no matter what the total says, say like 40/300.

 If it's just the number of resolved issues, you don't need the number of
 unresolved issues assigned to a target release. I tend to agree with
this POV.

It can depend. I agree with Dennis' statement that a high number of
resolved should be flagging a release (which is one of the reasons for
the report), but if there were truly 300 issues planned for that
release, then it's possible there was a reason. The first step after
the release has been flagging is for someone to review the 260 and
move them to another version - ie) to rethink the release plan.

Seeing the 300 figure is pretty useful in that it tells us that a
release plan is probably too much. BeanUtils has 79 issues in its
1.8.0. A bunch probably shouldn't go in 1.8.0, but when I went through
the 100+ issues that were there those were the ones that I thought we
should at least be looking at prior to the next release.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492234 - in /jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration: AbstractFileConfiguration.java FileConfiguration.java

2007-01-03 Thread oheger

Author: oheger
Date: Wed Jan  3 09:39:39 2007
New Revision: 492234

URL: http://svn.apache.org/viewvc?view=revrev=492234
Log:
CONFIGURATION-246: Javadoc improvements

Modified:

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java

jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/FileConfiguration.java

Modified: 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java?view=diffrev=492234r1=492233r2=492234
==
--- 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
 (original)
+++ 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
 Wed Jan  3 09:39:39 2007
@@ -41,7 +41,7 @@
  * pPartial implementation of the codeFileConfiguration/code interface.
  * Developpers of file based configuration may want to extend this class,
  * the two methods left to implement are code[EMAIL PROTECTED] 
FileConfiguration#load(Reader)}/code
- * and code[EMAIL PROTECTED] FileConfiguration#save(Writer)}./p
+ * and code[EMAIL PROTECTED] FileConfiguration#save(Writer)}/code./p
  * pThis base class already implements a couple of ways to specify the 
location
  * of the file this configuration is based on. The following possibilities
  * exist:
@@ -548,6 +548,7 @@
  * Return the base path.
  *
  * @return the base path
+ * @see FileConfiguration#getBasePath()
  */
 public String getBasePath()
 {
@@ -555,8 +556,18 @@
 }
 
 /**
- * Set the base path. Relative configurations are loaded from this path. 
The
- * base path can be either a path to a directory or a URL.
+ * Sets the base path. The base path is typically either a path to a
+ * directory or a URL. Together with the value passed to the
+ * codesetFileName()/code method it defines the location of the
+ * configuration file to be loaded. The strategies for locating the file 
are
+ * quite tolerant. For instance if the file name is already an absolute 
path
+ * or a fully defined URL, the base path will be ignored. The base path can
+ * also be a URL, in which case the file name is interpreted in this URL's
+ * context. Because the base path is used by some of the derived classes 
for
+ * resolving relative file names it should contain a meaningful value. If
+ * other methods are used for determining the location of the configuration
+ * file (e.g. codesetFile()/code or codesetURL()/code), the
+ * base path is automatically set.
  *
  * @param basePath the base path.
  */

Modified: 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/FileConfiguration.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/FileConfiguration.java?view=diffrev=492234r1=492233r2=492234
==
--- 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/FileConfiguration.java
 (original)
+++ 
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/FileConfiguration.java
 Wed Jan  3 09:39:39 2007
@@ -178,14 +178,28 @@
 void setFileName(String fileName);
 
 /**
- * Return the base path.
+ * Returns the base path. One way to specify the location of a 
configuration
+ * source is by setting its base path and its file name. This method 
returns
+ * this base path. The concrete value returned by this method depends on 
the
+ * way the location of the configuration file was set. If methods like
+ * codesetFile()/code or codesetURL()/code were used, the base
+ * path typically points to the parent directory of the configuration file
+ * (e.g. for the URL codefile:/temp/test.properties/code the base path
+ * will be codefile:/temp//code). If the base path was explictly set
+ * using codesetBasePath()/code, this method will return the exact
+ * value specified here without further modifications.
  *
  * @return the base path
+ * @see AbstractFileConfiguration#setBasePath(String)
  */
 String getBasePath();
 
 /**
- * Set the base path. Relative configurations are loaded from this path.
+ * Sets the base path. The methods codesetBasePath()/code and
+ * codesetFileName()/code can be used together to specify the location
+ * of the configuration file to be loaded. If relative file names are to
+ * be resolved (e.g. for the include files supported by
+ *

[jira] Resolved: (CONFIGURATION-246) The method getBasePath() in FileConfiguration suggest other behavior than it is implemented

2007-01-03 Thread Oliver Heger (JIRA)

[
https://issues.apache.org/jira/browse/CONFIGURATION-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oliver Heger resolved CONFIGURATION-246.

Resolution: Fixed
Fix Version/s: Nightly Builds

The Javadocs for getBasePath() and setBasePath() in both FileConfiguration and
AbstractFileConfiguration have been improved. They now explain in more detail
the background of the base path concept.

The method getBasePath() in FileConfiguration suggest other behavior than it
is implemented
---

Key: CONFIGURATION-246
URL: https://issues.apache.org/jira/browse/CONFIGURATION-246
Project: Commons Configuration
Issue Type: Improvement
Reporter: Thomas Wabner
Assigned To: Oliver Heger
Fix For: Nightly Builds

I have tried to use the FileConfiguration#getBasePath method without a look
into the implementation. The documentation is not very useful because it says
simple returns the base path. For me the method suggest that a string for
the configuration file C:\myDir\config.file in form C:\myDir\ is
returned. But the method returns the full path.
I suggest to rename the method to getPath and give a documentation link to
URL#getPath which does in fact the same. Or update the documentation which
describes in more detail that this method returns the complete path for the
associated file for this file configuration.
A documentation entry can then looks like
Returns the base path for the file associated with the current file
configuration. The base path contains the full path to the file and the file
itself.
@see java.net.URL#getPath

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [all] What's in a distribution?

2007-01-03 Thread Rahul Akolkar


On 1/2/07, Henri Yandell [EMAIL PROTECTED] wrote:
snip/


I dislike the website being put in the distributions. It's a cheap way
to think you're documenting your project; but having the documentation
in there is good. I think the solution to this part is to make our
websites leaner (by moving things into Jakarta's site and nightly
builds) so that what is left is a better fit for going in the
distribution.


snap/

IIUC, the cheap bit you are refering to is treating ${reports} as the
entire documentation, though am not sure how much value there is in
breaking them off as you propose. In any case, components like [SCXML]
have a multi-page cross-referenced user guide that is best viewed via
a web browser, IMO, and that is unlikely to be distributed in any
other form in the near future.

-Rahul




Hen



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (SANDBOX-183) Compress should allow for writing to Zip Files

2007-01-03 Thread Will Pugh (JIRA)

Compress should allow for writing to Zip Files
--

 Key: SANDBOX-183
 URL: https://issues.apache.org/jira/browse/SANDBOX-183
 Project: Commons Sandbox
  Issue Type: New Feature
  Components: Compress
Affects Versions: Nightly Builds
Reporter: Will Pugh
 Fix For: Nightly Builds
 Attachments: myzip.zip

Compress should be able to modify existing ZipFiles.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Updated: (SANDBOX-183) Compress should allow for writing to Zip Files

2007-01-03 Thread Will Pugh (JIRA)


 [ 
https://issues.apache.org/jira/browse/SANDBOX-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Will Pugh updated SANDBOX-183:
--

Attachment: myzip.zip

 Compress should allow for writing to Zip Files
 --

 Key: SANDBOX-183
 URL: https://issues.apache.org/jira/browse/SANDBOX-183
 Project: Commons Sandbox
  Issue Type: New Feature
  Components: Compress
Affects Versions: Nightly Builds
Reporter: Will Pugh
 Fix For: Nightly Builds

 Attachments: myzip.zip


 Compress should be able to modify existing ZipFiles.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27320] - DBCP 1.1 incompatible with Informix (driver doesn't support setReadOnly(...))

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27320.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27320


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2007-01-03 10:47 ---
I recieved a similar error using the commons-dbcp-1.2.1 version.

Caused by: java.util.NoSuchElementException: Could not create a validated 
object, cause: Read only mode not supported
at org.apache.commons.pool.impl.GenericObjectPool.borrowObject
(GenericObjectPool.java:806)
at org.apache.commons.dbcp.PoolingDriver.connect
(PoolingDriver.java:175)



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [all] What's in a distribution?

2007-01-03 Thread Henri Yandell


On 1/3/07, Rahul Akolkar [EMAIL PROTECTED] wrote:

On 1/2/07, Henri Yandell [EMAIL PROTECTED] wrote:
snip/

 I dislike the website being put in the distributions. It's a cheap way
 to think you're documenting your project; but having the documentation
 in there is good. I think the solution to this part is to make our
 websites leaner (by moving things into Jakarta's site and nightly
 builds) so that what is left is a better fit for going in the
 distribution.

snap/

IIUC, the cheap bit you are refering to is treating ${reports} as the
entire documentation


that and the overlap between the website and the documentation. A
website is chiefly (I think) concerned with getting someone to a) use
the product and b) join in the community. The documentation should be
much about explaining how to use the product. So the front page for a
website and the frontpage for documentation are completely different
pages.

Reports are also useless on both the website and the documentation -
they're only really of value to the developer. The few that are of
value to the user shouldn't be under reports (imo) - license + javadoc
- neither are reports. A license report would have value to the user
(something that showed the license of all dependencies and linked to
information about them), but Maven doesn't have that afaik.

Reports should be a part of the CI system.


, though am not sure how much value there is in
breaking them off as you propose. In any case, components like [SCXML]
have a multi-page cross-referenced user guide that is best viewed via
a web browser, IMO, and that is unlikely to be distributed in any
other form in the near future.


+1 for HTML as a format for documentation, definitely not arguing for
PDF or OpenOffice etc.

I've been grumbling about the above for a while - generally to myself
but every now and then to the list.

On the other side of things, I get grumbly about the Jakarta site and
thoughts on how to organize a Jakarta with lots of components in it.
One of my thoughts is that it should largely be database driven
(meaning an xml file like downloads.xml but for much more
information). Things like svn url, javadoc page, download page, web
page, nightly builds location. Even better is if most of these things
are name convention based: ie) 'scxml' gets used in each url.

The doap files for proejcts.apache.org should then be generatable
(it's a layer above/below the doap files so we can't use those
directly).

Part of all that would be to take the common information out of the
component sites and into a Jakarta page for that component. Much like
the download section currently. The tricky part is one of lf, it's
very odd to jump out of a site and into another site, however to have
a Jakarta with many components we have to step away from the common
lf attempt we currently have (which I think just causes us pain) and
be more lenient.

One way around lf pain is to generate an xml file for each page and
let the lf be governed by the component. While I think that'll work
for pan-ASF things like people.apache.org and projects.apache.org, I
don't think it'll work well within Jakarta.

Time to do some work - I'll stop rambling on :)

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27320] - DBCP 1.1 incompatible with Informix (driver doesn't support setReadOnly(...))

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=27320.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27320





--- Additional Comments From [EMAIL PROTECTED]  2007-01-03 11:16 ---
Jakarta Commons has moved its issue tracking from Bugzilla to JIRA.

Please make any comments you might have for this issue at:
  https://issues.apache.org/jira/browse/DBCP-127

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (LANG-306) Extra StrBuilder methods

2007-01-03 Thread Henri Yandell (JIRA)


[ 
https://issues.apache.org/jira/browse/LANG-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462038
 ] 

Henri Yandell commented on LANG-306:


LANG-69 is a blocker - so things can go in until that gets fixed.

 Extra StrBuilder methods
 

 Key: LANG-306
 URL: https://issues.apache.org/jira/browse/LANG-306
 Project: Commons Lang
  Issue Type: Improvement
Reporter: Stephen Colebourne
Priority: Minor
 Fix For: 2.3

 Attachments: lang.patch, StrBuilder.java


 Append all the elements in a collection with no separator:
 StrBuilder.appendAll(Collection)
 StrBuilder.appendAll(Object[])
 StrBuilder.appendAll(Iterator)
 Append the data followed by a new line:
 StrBuilder.appendln(...)
 Append a separator if the buffer is not empty:
 StrBuilder.appendSeparator(String)
 Append a separator if the index  0:
 StrBuilder.appendSeparator(String, index)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Closed: (LANG-297) Addition to ObjectUtils: public static List getAllSuperclassesUpTo( Class cls, Class upToClass )

2007-01-03 Thread Henri Yandell (JIRA)


 [ 
https://issues.apache.org/jira/browse/LANG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henri Yandell closed LANG-297.
--

Resolution: Won't Fix

Closing as WONTFIX as the featuritis verdict seems to have consensus. 

 Addition to ObjectUtils: public static List getAllSuperclassesUpTo( Class 
 cls, Class upToClass )
 

 Key: LANG-297
 URL: https://issues.apache.org/jira/browse/LANG-297
 Project: Commons Lang
  Issue Type: Improvement
Affects Versions: 2.3
 Environment: N/A
Reporter: David J. M. Karlsen
 Attachments: CommonsLang-patch-JIRA297.txt


 Add another method: 
 /**
  * Gets a codeList/code of superclasses up to, but not including 
 codeupToClass/code.
  * If upToClass is null this is effectively the same as 
 getAllSuperClasses( cls ) (e.g. the whole hierarchy).
  * returns null if cls is null
  */
 public static List getAllSuperclassesUpTo( Class cls, Class upToClass )
 Patch with code and test will be added.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (DBCP-127) DBCP 1.1 incompatible with Informix (driver doesn't support setReadOnly(...))

2007-01-03 Thread Kimberly Baer (JIRA)


[ 
https://issues.apache.org/jira/browse/DBCP-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462040
 ] 

Kimberly Baer commented on DBCP-127:


I recieved an error using commons-dbcp-1.2.1.jar and ifxjdbc.jar for my 
informix driver:

org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool 
exhausted
at org.apache.commons.dbcp.PoolingDriver.connect(PoolingDriver.java:183)
at java.sql.DriverManager.getConnection(DriverManager.java:539)
at java.sql.DriverManager.getConnection(DriverManager.java:211)
at ConnectionPoolingTest.main(ConnectionPoolingTest.java:105)
Caused by: java.util.NoSuchElementException: Could not create a validated 
object, cause: Read only mode not supported
at 
org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:806)
at org.apache.commons.dbcp.PoolingDriver.connect(PoolingDriver.java:175)

I will look into the comment provided by Dirk, but it appears this bug still 
has an impact.  If anyone has any other suggestions, they would be greatly 
appreciated.


 DBCP 1.1 incompatible with Informix (driver doesn't support setReadOnly(...))
 -

 Key: DBCP-127
 URL: https://issues.apache.org/jira/browse/DBCP-127
 Project: Commons Dbcp
  Issue Type: Bug
Affects Versions: 1.1
 Environment: Operating System: All
 Platform: All
Reporter: Dirk Verbeeck

 DBCP 1.1 is more strict about Exceptions thrown by setReadOnly method of the
 database drivers.
 This results in the following issue with the Informix database driver as
 reported by Andrew Peirson.
 For details see commons-user mailing list 24-2-2004.
 =
 Creating connection.
 org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool 
 exhausted
 at 
 org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:148)
 at 
 ManualPoolingDataSourceExample.main(ManualPoolingDataSourceExample.java:169)
 Caused by: java.util.NoSuchElementException: Could not create a validated 
 object, cause: Read only mode not supported
 at 
 org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:851)
 at 
 org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:140)
 ... 1 more

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [all] What's in a distribution?

2007-01-03 Thread Rahul Akolkar


On 1/3/07, Henri Yandell [EMAIL PROTECTED] wrote:
snip/


Part of all that would be to take the common information out of the
component sites and into a Jakarta page for that component. Much like
the download section currently. The tricky part is one of lf, it's
very odd to jump out of a site and into another site, however to have
a Jakarta with many components we have to step away from the common
lf attempt we currently have (which I think just causes us pain) and
be more lenient.


snap/

I've snipped most bits that I more or less agree with. On the LnF
front, I don't think we're overly concerned about the CSS a component
uses per se, if at all a component wants to use a different one
(though I think its nice that most Commons components have sites that
look similar). Its more about standardization with the objective of
making lives of users and developers easier (for users, fact that
Javadocs, licenses are in a predictable place as you mentioned -- and
for developers, the fact that the site is generated using similar
means etc. which allows, for example, me to jump in and feel at home
with the [digester] site if I want to volunteer RM'ing it). Generally
boiling down to my opinion that a Commons/Jakarta component needs to
have communal responsibility.




Time to do some work - I'll stop rambling on :)


snip/

Thanks for taking time to elaborate :)

-Rahul



Hen



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (DBCP-207) DBCP 1.2.1 incompatible with Informix (driver doesn't support setReadOnly(...))

2007-01-03 Thread Kimberly Baer (JIRA)

DBCP 1.2.1 incompatible with Informix (driver doesn't support setReadOnly(...))
---

 Key: DBCP-207
 URL: https://issues.apache.org/jira/browse/DBCP-207
 Project: Commons Dbcp
  Issue Type: Bug
Affects Versions: 1.2.1
 Environment: using the pooling driver component with an informix driver
Reporter: Kimberly Baer


I recieved an error using commons-dbcp-1.2.1.jar and ifxjdbc.jar for my 
informix driver: 

org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool 
exhausted 
at org.apache.commons.dbcp.PoolingDriver.connect(PoolingDriver.java:183) 
at java.sql.DriverManager.getConnection(DriverManager.java:539) 
at java.sql.DriverManager.getConnection(DriverManager.java:211) 
at ConnectionPoolingTest.main(ConnectionPoolingTest.java:105) 
Caused by: java.util.NoSuchElementException: Could not create a validated 
object, cause: Read only mode not supported 
at 
org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:806)
 
at org.apache.commons.dbcp.PoolingDriver.connect(PoolingDriver.java:175) 

I will look into the comment provided by Dirk in bug ID DBCP-127 (version 1.1), 
but it appears this bug still has an impact in the 1.2.1 version. If anyone has 
any other suggestions, they would be greatly appreciated. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [io] Pre 1.3 build

2007-01-03 Thread Henri Yandell


On 1/3/07, Jörg Schaible [EMAIL PROTECTED] wrote:

Henri Yandell wrote on Tuesday, January 02, 2007 10:56 PM:

 Using:

 jvm 1.3  ant dist  jvm 1.4  maven site

 I've built the following:

 http://people.apache.org/~bayard/commons-io/commons-io-snapshot-build/

 Anything need fixing up before doing the real build? I'll make the
 version number 1.3 when I do that etc.

 The only thing that stands out for me is that a
 commons-io-1.3-SNAPSHOT-src-ide.zip file is created when we might want
 it to be named commons-io-1.3-SNAPSHOT-src.jar to match the ones
 Maven-2 makes. We could also be creating a javadoc jar.

M2 creates -sources.jar files :)


Details!

Thanks, unless anyone's against the idea I'll change the build to
produce a -sources.jar (and possibly a -javadoc.jar) for the vote :)

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [io] Pre 1.3 build

2007-01-03 Thread Jochen Wiedmann


On 1/3/07, Henri Yandell [EMAIL PROTECTED] wrote:


 M2 creates -sources.jar files :)

Details!


The commons-parent POM ensures that the -sources and -javadoc jar
files are built, installed, and deployed automatically if you are
activating the rc or release profiles. In other words, if you do
something like

   mvn -Prc install

or

   mvn -Prelease deploy


Jochen


--
My wife Mary and I have been married for forty-seven years and not
once have we had an argument serious enough to consider divorce;
murder, yes, but divorce, never.
(Jack Benny)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [io] Pre 1.3 build

2007-01-03 Thread Stephen Colebourne


Jörg Schaible wrote:

M2 creates -sources.jar files :)


Personally, I like -src-ide.zip, but I can't be bothered to fight the 
maven god on this.


Stephen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (LANG-309) Add ArrayUtils.addFirst methods.

2007-01-03 Thread Gary Gregory (JIRA)

Add ArrayUtils.addFirst methods.


 Key: LANG-309
 URL: https://issues.apache.org/jira/browse/LANG-309
 Project: Commons Lang
  Issue Type: Improvement
Affects Versions: 2.2
Reporter: Gary Gregory
Priority: Minor


Add ArrayUtils.addFirst methods?

This is pretty trivial, implementation wise. I'd like some feedback before 
implementation. For example, is

ArrayUtils.addFirst (array, newFirstElement);

really better than:

ArrayUtils.add(array, 0, newFirstElement);

?



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492352 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java

Author: scolebourne
Date: Wed Jan  3 15:44:56 2007
New Revision: 492352

URL: http://svn.apache.org/viewvc?view=revrev=492352
Log:
Formatting changes only

Modified:

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java?view=diffrev=492352r1=492351r2=492352
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
 Wed Jan  3 15:44:56 2007
@@ -1034,7 +1034,7 @@
 return str.indexOf(searchStr) = 0;
 }
 
- /**
+/**
  * pChecks if String contains a search String irrespective of case,
  * handling codenull/code. This method uses
  * [EMAIL PROTECTED] #contains(String, String)}./p
@@ -1052,8 +1052,8 @@
  * StringUtils.contains(abc, Z) = false
  * /pre
  *
- * @param str the String to check, may be null
- * @param searchStr the String to find, may be null
+ * @param str  the String to check, may be null
+ * @param searchStr  the String to find, may be null
  * @return true if the String contains the search String irrespective of
  * case or false if not or codenull/code string input
  */



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38586] - [jxpath] Descendant or self axis does not work correctly at root node

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38586.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38586





--- Additional Comments From [EMAIL PROTECTED]  2007-01-03 15:48 ---
Created an attachment (id=19348)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19348action=view)
Path proposal to fix this problem

Adding a patch proposition for this bug. 

As written here before, bug actually appears when xpatch is like //root.
It appears also when a dom is inside any java structure 
(for example: map.put(test, new Document(new Element(root))); xpatch for
//root would return null).

Exactly the same bug was both for JDom and Dom; both are fixed.

Modifies 4 files:
 main:
   JDOMNodePointer.java
   DOMNodePointer.java
 tests:  
   JDOMModelTest.java
   DOMModelTest.java

This patch is to latest version (2.2?), not to version 1.2.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492354 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java

Author: scolebourne
Date: Wed Jan  3 15:48:10 2007
New Revision: 492354

URL: http://svn.apache.org/viewvc?view=revrev=492354
Log:
Formatting changes only

Modified:

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?view=diffrev=492354r1=492353r2=492354
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
 Wed Jan  3 15:48:10 2007
@@ -118,8 +118,7 @@
 /**
  * pForwards to codeReflectionToStringBuilder/code./p
  * 
- * @param object
- *the Object to be output
+ * @param object  the Object to be output
  * @return the String result
  * @see ReflectionToStringBuilder#toString(Object)
  */
@@ -130,10 +129,8 @@
 /**
  * pForwards to codeReflectionToStringBuilder/code./p
  * 
- * @param object
- *the Object to be output
- * @param style
- *the style of the codetoString/code to create, may be 
codenull/code
+ * @param object  the Object to be output
+ * @param style  the style of the codetoString/code to create, may be 
codenull/code
  * @return the String result
  * @see ReflectionToStringBuilder#toString(Object,ToStringStyle)
  */
@@ -144,12 +141,9 @@
 /**
  * pForwards to codeReflectionToStringBuilder/code./p
  * 
- * @param object
- *the Object to be output
- * @param style
- *the style of the codetoString/code to create, may be 
codenull/code
- * @param outputTransients
- *whether to include transient fields
+ * @param object  the Object to be output
+ * @param style  the style of the codetoString/code to create, may be 
codenull/code
+ * @param outputTransients  whether to include transient fields
  * @return the String result
  * @see ReflectionToStringBuilder#toString(Object,ToStringStyle,boolean)
  */
@@ -160,14 +154,10 @@
 /**
  * pForwards to codeReflectionToStringBuilder/code./p
  * 
- * @param object
- *the Object to be output
- * @param style
- *the style of the codetoString/code to create, may be 
codenull/code
- * @param outputTransients
- *whether to include transient fields
- * @param reflectUpToClass
- *the superclass to reflect up to (inclusive), may be 
codenull/code
+ * @param object  the Object to be output
+ * @param style  the style of the codetoString/code to create, may be 
codenull/code
+ * @param outputTransients  whether to include transient fields
+ * @param reflectUpToClass  the superclass to reflect up to (inclusive), 
may be codenull/code
  * @return the String result
  * @see 
ReflectionToStringBuilder#toString(Object,ToStringStyle,boolean,boolean,Class)
  * @since 2.0



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38586] - [jxpath] Descendant or self axis does not work correctly at root node

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38586.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38586





--- Additional Comments From [EMAIL PROTECTED]  2007-01-03 15:51 ---
jakarta commons has moved to JIRA.  Please add updates at
https://issues.apache.org/jira/browse/JXPATH-12 .

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (JXPATH-71) Ponter.asPath() return values not always correct

2007-01-03 Thread Matt Benson (JIRA)


[ 
https://issues.apache.org/jira/browse/JXPATH-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462092
 ] 

Matt Benson commented on JXPATH-71:
---

On the commons-dev mailing list, Dmitri responded:

John,

A similar bug was reported and fixed a long time ago.  Are you sure this is 
still an issue with the current build of JXPath?

Thank you,

- Dmitri

see http://marc.theaimsgroup.com/?l=jakarta-commons-devm=116048423025988w=2

 Ponter.asPath() return values not always correct
 

 Key: JXPATH-71
 URL: https://issues.apache.org/jira/browse/JXPATH-71
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: 1.2 Final
 Environment: WInXP, Java 1.5, Eclipse 3.2
Reporter: John Attwood

 String returned by Pointer.asPath() is incorrect when path starts with '//' 
 and target is a collection. The path returned always has a final subscript 
 equal to the size of the collection, although Pointer.getValue() still 
 returns the correct element  in each case. Below are two classes and a JUnit 
 testcase which reproduce the bug and isolate it to the case where the path 
 starts with '//' and the target is a collection.
 I found this problem whilst trying to write the equivalent of XPathExplorer 
 for my JXPath-based object trees. It does't affect the main app, as 
 getValue() always returns the correct node, but in my explorer it only ever 
 highlights the last element in any collection (the objects in my trees aren't 
 always unique so the path is only way to identify them individually and allow 
 the matching nodes to be highlighted).
 Otherwise an excellent, easy-to-use and really useful package. 
 ///  Parent.java  
 //
 package test;
 import java.util.ArrayList;
 public class Parent {
   private int id;
   private ArrayListChild kids;
   public Parent(int id) {
   this.id = id;
   this.kids = new ArrayListChild();
   }
   public int getId() {
   return id;
   }
   public ArrayListChild getKids() {
   return kids;
   }
   public void addKid(Child kid) {
   kids.add(kid);
   }
   public void setId(int id) {
   this.id = id;
   }
   public void setKids(ArrayListChild kids) {
   this.kids = kids;
   }
 }
 /// Child.java 
 /
 package test;
 public class Child {
   private int id;
   public Child(int id) {
   this.id = id;
   }
   public int getId() {
   return id;
   }
   public void setId(int id) {
   this.id = id;
   }
 }
 ///  
 TestPointerToPath.java 
 ///
 package test;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.Set;
 import junit.framework.TestCase;
 import org.apache.commons.jxpath.JXPathContext;
 import org.apache.commons.jxpath.Pointer;
 public class TestPonterToPath extends TestCase {
   private Parent parent;
   private SetString expectedPaths, actualPaths;
   private SetObject actualObjects, expectedObjects;
   private JXPathContext ctx;
   
   private static final int SIZE = 4;
   
   public void setUp() {
   parent = new Parent(1);
   for (int i = 1; i = SIZE; i++) {
   parent.addKid(new Child(i));
   }   
   expectedPaths = new HashSetString();
   expectedObjects = new HashSetObject();
   actualPaths = new HashSetString();
   actualObjects = new HashSetObject();
   ctx = JXPathContext.newContext(parent);
   }
   
   private void doExpected(String path1, String path2) {
   for (int i = 1; i = SIZE; i++) {
   Pointer p = ctx.getPointer(path1 + i + path2);
   expectedPaths.add(p.asPath());
   expectedObjects.add(p.getValue());
   }
   assertEquals(SIZE, expectedPaths.size());
   assertEquals(SIZE, expectedObjects.size());
   }
   
   private void doActual(String path) {
   Iterator it = ctx.iteratePointers(path);
   while (it.hasNext()) {
   Pointer p = (Pointer) it.next();
   actualPaths.add(p.asPath());
   actualObjects.add(p.getValue());
   }
   assertEquals(SIZE,

[jira] Created: (LANG-310) BooleanUtils isNotTrue/isNotFalse

BooleanUtils isNotTrue/isNotFalse
-

 Key: LANG-310
 URL: https://issues.apache.org/jira/browse/LANG-310
 Project: Commons Lang
  Issue Type: Improvement
Reporter: Stephen Colebourne
 Assigned To: Stephen Colebourne
Priority: Minor
 Fix For: 2.3


Add two methods to BooleanUtils
- isNotTrue
- isNotFalse
These make writing if statements a lot clearer when handling nulls.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492361 - in /jakarta/commons/proper/lang/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/lang/BooleanUtils.java src/test/org/apache/commons/lang/BooleanUtilsTest.java

Author: scolebourne
Date: Wed Jan  3 16:10:13 2007
New Revision: 492361

URL: http://svn.apache.org/viewvc?view=revrev=492361
Log:
LANG-310 - BooleanUtils isNotTrue/isNotFalse

Modified:
jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java

jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/BooleanUtilsTest.java

Modified: jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt?view=diffrev=492361r1=492360r2=492361
==
--- jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt (original)
+++ jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt Wed Jan  3 16:10:13 2007
@@ -81,4 +81,5 @@
 * [LANG-291] - Null-safe comparison methods for finding most recent / 
least recent dates.
 * [LANG-282] - Create more tests to test out the +=31 replacement code in 
DurationFormatUtils.
 * [LANG-266] - Wish for StringUtils.join(Collection, *)
+* [LANG-310] - BooleanUtils isNotTrue/isNotFalse
 

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java?view=diffrev=492361r1=492360r2=492361
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java
 Wed Jan  3 16:10:13 2007
@@ -70,7 +70,8 @@
 // boolean Boolean methods
 //---
 /**
- * pIs a Boolean value codetrue/code, handling codenull/code./p
+ * pChecks if a codeBoolean/code value is codetrue/code,
+ * handling codenull/code by returning codefalse/code./p
  *
  * pre
  *   BooleanUtils.isTrue(Boolean.TRUE)  = true
@@ -78,7 +79,7 @@
  *   BooleanUtils.isTrue(null)  = false
  * /pre
  *
- * @param bool  the boolean to convert
+ * @param bool  the boolean to check, null returns codefalse/code
  * @return codetrue/code only if the input is non-null and true
  * @since 2.1
  */
@@ -90,7 +91,26 @@
 }
 
 /**
- * pIs a Boolean value codefalse/code, handling 
codenull/code./p
+ * pChecks if a codeBoolean/code value is inot/i 
codetrue/code,
+ * handling codenull/code by returning codetrue/code./p
+ *
+ * pre
+ *   BooleanUtils.isNotTrue(Boolean.TRUE)  = false
+ *   BooleanUtils.isNotTrue(Boolean.FALSE) = true
+ *   BooleanUtils.isNotTrue(null)  = true
+ * /pre
+ *
+ * @param bool  the boolean to check, null returns codetrue/code
+ * @return codetrue/code if the input is null or false
+ * @since 2.3
+ */
+public static boolean isNotTrue(Boolean bool) {
+return !isTrue(bool);
+}
+
+/**
+ * pChecks if a codeBoolean/code value is codefalse/code,
+ * handling codenull/code by returning codefalse/code./p
  *
  * pre
  *   BooleanUtils.isFalse(Boolean.TRUE)  = false
@@ -98,7 +118,7 @@
  *   BooleanUtils.isFalse(null)  = false
  * /pre
  *
- * @param bool  the boolean to convert
+ * @param bool  the boolean to check, null returns codefalse/code
  * @return codetrue/code only if the input is non-null and false
  * @since 2.1
  */
@@ -109,6 +129,25 @@
 return bool.booleanValue() ? false : true;
 }
 
+/**
+ * pChecks if a codeBoolean/code value is inot/i 
codefalse/code,
+ * handling codenull/code by returning codetrue/code./p
+ *
+ * pre
+ *   BooleanUtils.isNotTrue(Boolean.TRUE)  = true
+ *   BooleanUtils.isNotTrue(Boolean.FALSE) = false
+ *   BooleanUtils.isNotTrue(null)  = true
+ * /pre
+ *
+ * @param bool  the boolean to check, null returns codetrue/code
+ * @return codetrue/code if the input is null or true
+ * @since 2.3
+ */
+public static boolean isNotFalse(Boolean bool) {
+return !isFalse(bool);
+}
+
+//---
 /**
  * pBoolean factory that avoids creating new Boolean objecs all the 
time./p
  * 

Modified: 
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/BooleanUtilsTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/BooleanUtilsTest.java?view=diffrev=492361r1=492360r2=492361
==
--- 
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/BooleanUtilsTest.java
 (original)
+++

[jira] Closed: (LANG-310) BooleanUtils isNotTrue/isNotFalse


 [ 
https://issues.apache.org/jira/browse/LANG-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Colebourne closed LANG-310.
---

Resolution: Fixed

svn commit C:\dev\commons\lang\RELEASE-NOTES.txt 
C:\dev\commons\lang\src\java\org\apache\commons\lang\BooleanUtils.java 
C:\dev\commons\lang\src\test\org\apache\commons\lang\BooleanUtilsTest.java -N 
-m LANG-310 - BooleanUtils isNotTrue/isNotFalse --username scolebourne
M C:\dev\commons\lang\RELEASE-NOTES.txt
M C:\dev\commons\lang\src\java\org\apache\commons\lang\BooleanUtils.java
M 
C:\dev\commons\lang\src\test\org\apache\commons\lang\BooleanUtilsTest.java
  Transmitting file data: C:\dev\commons\lang\RELEASE-NOTES.txt
  Transmitting file data: 
C:\dev\commons\lang\src\java\org\apache\commons\lang\BooleanUtils.java
  Transmitting file data: 
C:\dev\commons\lang\src\test\org\apache\commons\lang\BooleanUtilsTest.java
Committed revision 492361
*

 BooleanUtils isNotTrue/isNotFalse
 -

 Key: LANG-310
 URL: https://issues.apache.org/jira/browse/LANG-310
 Project: Commons Lang
  Issue Type: Improvement
Reporter: Stephen Colebourne
 Assigned To: Stephen Colebourne
Priority: Minor
 Fix For: 2.3


 Add two methods to BooleanUtils
 - isNotTrue
 - isNotFalse
 These make writing if statements a lot clearer when handling nulls.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492369 - in /jakarta/commons/proper/lang/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/lang/text/StrBuilder.java src/test/org/apache/commons/lang/text/StrBuilderAppendInsertTest.ja

Author: scolebourne
Date: Wed Jan  3 16:35:45 2007
New Revision: 492369

URL: http://svn.apache.org/viewvc?view=revrev=492369
Log:
LANG-306 - StrBuilder appendln/appendAll/appendSeparator

Modified:
jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java

jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/text/StrBuilderAppendInsertTest.java

Modified: jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt?view=diffrev=492369r1=492368r2=492369
==
--- jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt (original)
+++ jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt Wed Jan  3 16:35:45 2007
@@ -56,9 +56,9 @@
 
 BUG FIXES IN 2.3:
 
-* [LANG-69 ] - [lang] ToStringBuilder throws StackOverflowError when an 
Object cycle exists
-* [LANG-102] - [lang] Refactor Entities methods
-* [LANG-153] - [lang] Can't XMLDecode an Enum
+* [LANG-69 ] - ToStringBuilder throws StackOverflowError when an Object 
cycle exists
+* [LANG-102] - Refactor Entities methods
+* [LANG-153] - Can't XMLDecode an Enum
 * [LANG-262] - Use of enum prevents a classloader from being garbage 
collected resuling in out of memory exceptions.
 * [LANG-279] - HashCodeBuilder throws java.lang.StackOverflowError when an 
object contains a cycle.
 * [LANG-281] - DurationFormatUtils returns wrong result
@@ -73,7 +73,6 @@
 
 IMPROVEMENTS IN 2.3:
 
-* [LANG-238] - [lang] Add equals(type[]) to NumberUtils
 * [LANG-258] - Enum JavaDoc
 * [LANG-268] - StringUtils.join should allow you to pass a range for it 
(so it only joins a part of the array)
 * [LANG-287] - Optimize StringEscapeUtils.unescapeXml(String)
@@ -82,4 +81,5 @@
 * [LANG-282] - Create more tests to test out the +=31 replacement code in 
DurationFormatUtils.
 * [LANG-266] - Wish for StringUtils.join(Collection, *)
 * [LANG-310] - BooleanUtils isNotTrue/isNotFalse
+* [LANG-306] - StrBuilder appendln/appendAll/appendSeparator
 

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java?view=diffrev=492369r1=492368r2=492369
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
 Wed Jan  3 16:35:45 2007
@@ -733,6 +733,227 @@
 
 //---
 /**
+ * Appends an object followed by a new line to this string builder.
+ * Appending null will call [EMAIL PROTECTED] #appendNull()}.
+ *
+ * @param obj  the object to append
+ * @return this, to enable chaining
+ */
+public StrBuilder appendln(Object obj) {
+return append(obj).appendNewLine();
+}
+
+/**
+ * Appends a string followed by a new line to this string builder.
+ * Appending null will call [EMAIL PROTECTED] #appendNull()}.
+ *
+ * @param str  the string to append
+ * @return this, to enable chaining
+ */
+public StrBuilder appendln(String str) {
+return append(str).appendNewLine();
+}
+
+/**
+ * Appends part of a string followed by a new line to this string builder.
+ * Appending null will call [EMAIL PROTECTED] #appendNull()}.
+ *
+ * @param str  the string to append
+ * @param startIndex  the start index, inclusive, must be valid
+ * @param length  the length to append, must be valid
+ * @return this, to enable chaining
+ */
+public StrBuilder appendln(String str, int startIndex, int length) {
+return append(str, startIndex, length).appendNewLine();
+}
+
+/**
+ * Appends a string buffer followed by a new line to this string builder.
+ * Appending null will call [EMAIL PROTECTED] #appendNull()}.
+ *
+ * @param str  the string buffer to append
+ * @return this, to enable chaining
+ */
+public StrBuilder appendln(StringBuffer str) {
+return append(str).appendNewLine();
+}
+
+/**
+ * Appends part of a string buffer followed by a new line to this string 
builder.
+ * Appending null will call [EMAIL PROTECTED] #appendNull()}.
+ *
+ * @param str  the string to append
+ * @param startIndex  the start index, inclusive, must be valid
+ * @param length  the length to append, must be valid
+ * @return this, to enable chaining
+ */
+public StrBuilder appendln(StringBuffer str, int startIndex, int length) {
+return append(str, startIndex,

[jira] Closed: (LANG-306) Extra StrBuilder methods


 [ 
https://issues.apache.org/jira/browse/LANG-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Colebourne closed LANG-306.
---

Resolution: Fixed
  Assignee: Stephen Colebourne

svn commit C:\dev\commons\lang\RELEASE-NOTES.txt 
C:\dev\commons\lang\src\java\org\apache\commons\lang\text\StrBuilder.java 
C:\dev\commons\lang\src\test\org\apache\commons\lang\text\StrBuilderAppendInsertTest.java
 -N -m LANG-306 - StrBuilder appendln/appendAll/appendSeparator --username 
scolebourne
M C:\dev\commons\lang\RELEASE-NOTES.txt
M 
C:\dev\commons\lang\src\java\org\apache\commons\lang\text\StrBuilder.java
M 
C:\dev\commons\lang\src\test\org\apache\commons\lang\text\StrBuilderAppendInsertTest.java
  Transmitting file data: C:\dev\commons\lang\RELEASE-NOTES.txt
  Transmitting file data: 
C:\dev\commons\lang\src\java\org\apache\commons\lang\text\StrBuilder.java
  Transmitting file data: 
C:\dev\commons\lang\src\test\org\apache\commons\lang\text\StrBuilderAppendInsertTest.java
Committed revision 492369


 Extra StrBuilder methods
 

 Key: LANG-306
 URL: https://issues.apache.org/jira/browse/LANG-306
 Project: Commons Lang
  Issue Type: Improvement
Reporter: Stephen Colebourne
 Assigned To: Stephen Colebourne
Priority: Minor
 Fix For: 2.3

 Attachments: lang.patch, StrBuilder.java


 Append all the elements in a collection with no separator:
 StrBuilder.appendAll(Collection)
 StrBuilder.appendAll(Object[])
 StrBuilder.appendAll(Iterator)
 Append the data followed by a new line:
 StrBuilder.appendln(...)
 Append a separator if the buffer is not empty:
 StrBuilder.appendSeparator(String)
 Append a separator if the index  0:
 StrBuilder.appendSeparator(String, index)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492371 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java

Author: scolebourne
Date: Wed Jan  3 16:42:05 2007
New Revision: 492371

URL: http://svn.apache.org/viewvc?view=revrev=492371
Log:
Add since tags

Modified:

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java?view=diffrev=492371r1=492370r2=492371
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
 Wed Jan  3 16:42:05 2007
@@ -738,6 +738,7 @@
  *
  * @param obj  the object to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(Object obj) {
 return append(obj).appendNewLine();
@@ -749,6 +750,7 @@
  *
  * @param str  the string to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(String str) {
 return append(str).appendNewLine();
@@ -762,6 +764,7 @@
  * @param startIndex  the start index, inclusive, must be valid
  * @param length  the length to append, must be valid
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(String str, int startIndex, int length) {
 return append(str, startIndex, length).appendNewLine();
@@ -773,6 +776,7 @@
  *
  * @param str  the string buffer to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(StringBuffer str) {
 return append(str).appendNewLine();
@@ -786,6 +790,7 @@
  * @param startIndex  the start index, inclusive, must be valid
  * @param length  the length to append, must be valid
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(StringBuffer str, int startIndex, int length) {
 return append(str, startIndex, length).appendNewLine();
@@ -797,6 +802,7 @@
  *
  * @param str  the string builder to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(StrBuilder str) {
 return append(str).appendNewLine();
@@ -810,6 +816,7 @@
  * @param startIndex  the start index, inclusive, must be valid
  * @param length  the length to append, must be valid
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(StrBuilder str, int startIndex, int length) {
 return append(str, startIndex, length).appendNewLine();
@@ -821,6 +828,7 @@
  *
  * @param chars  the char array to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(char[] chars) {
 return append(chars).appendNewLine();
@@ -834,6 +842,7 @@
  * @param startIndex  the start index, inclusive, must be valid
  * @param length  the length to append, must be valid
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(char[] chars, int startIndex, int length) {
 return append(chars, startIndex, length).appendNewLine();
@@ -844,6 +853,7 @@
  *
  * @param value  the value to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(boolean value) {
 return append(value).appendNewLine();
@@ -854,6 +864,7 @@
  *
  * @param ch  the value to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(char ch) {
 return append(ch).appendNewLine();
@@ -864,6 +875,7 @@
  *
  * @param value  the value to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(int value) {
 return append(value).appendNewLine();
@@ -874,6 +886,7 @@
  *
  * @param value  the value to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(long value) {
 return append(value).appendNewLine();
@@ -884,6 +897,7 @@
  *
  * @param value  the value to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(float value) {
 return append(value).appendNewLine();
@@ -894,6 +908,7 @@
  *
  * @param value  the value to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder appendln(double value) {
 return append(value).appendNewLine();
@@ -907,6 +922,7 @@
  *
  * @param array  the array to append
  * @return this, to enable chaining
+ * @since 2.3
  */
 public StrBuilder

Re: [lang] svn commit: r492361 - in /jakarta/commons/proper/lang/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/lang/BooleanUtils.java src/test/org/apache/commons/lang/BooleanUtilsTest.java

2007-01-03 Thread Rahul Akolkar


On 1/3/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:

Author: scolebourne
Date: Wed Jan  3 16:10:13 2007
New Revision: 492361

URL: http://svn.apache.org/viewvc?view=revrev=492361
Log:
LANG-310 - BooleanUtils isNotTrue/isNotFalse

Modified:
jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java

jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/BooleanUtilsTest.java


snip/

+/**
+ * pChecks if a codeBoolean/code value is inot/i 
codefalse/code,
+ * handling codenull/code by returning codetrue/code./p
+ *
+ * pre
+ *   BooleanUtils.isNotTrue(Boolean.TRUE)  = true
+ *   BooleanUtils.isNotTrue(Boolean.FALSE) = false
+ *   BooleanUtils.isNotTrue(null)  = true
+ * /pre
+ *
+ * @param bool  the boolean to check, null returns codetrue/code
+ * @return codetrue/code if the input is null or true
+ * @since 2.3
+ */
+public static boolean isNotFalse(Boolean bool) {
+return !isFalse(bool);
+}
+

snap/

Javadoc for this method (pre section) has incorrect method name.

-Rahul

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492377 - in /jakarta/commons/proper/lang/trunk: RELEASE-NOTES.txt project.xml src/java/org/apache/commons/lang/StringUtils.java src/test/org/apache/commons/lang/StringUtilsSubstringTest.j

Author: scolebourne
Date: Wed Jan  3 17:20:30 2007
New Revision: 492377

URL: http://svn.apache.org/viewvc?view=revrev=492377
Log:
LANG-275 - StringUtils substringsBetween, implemented by Dave Meikle

Modified:
jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt
jakarta/commons/proper/lang/trunk/project.xml

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java

jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsSubstringTest.java

Modified: jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt?view=diffrev=492377r1=492376r2=492377
==
--- jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt (original)
+++ jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt Wed Jan  3 17:20:30 2007
@@ -82,4 +82,5 @@
 * [LANG-266] - Wish for StringUtils.join(Collection, *)
 * [LANG-310] - BooleanUtils isNotTrue/isNotFalse
 * [LANG-306] - StrBuilder appendln/appendAll/appendSeparator
+* [LANG-275] - StringUtils substringsBetween
 

Modified: jakarta/commons/proper/lang/trunk/project.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/project.xml?view=diffrev=492377r1=492376r2=492377
==
--- jakarta/commons/proper/lang/trunk/project.xml (original)
+++ jakarta/commons/proper/lang/trunk/project.xml Wed Jan  3 17:20:30 2007
@@ -271,6 +271,9 @@
 nameRand McNeely/name
 /contributor
 contributor
+nameDave Meikle/name
+/contributor
+contributor
 nameNikolay Metchev/name
 /contributor
 contributor

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java?view=diffrev=492377r1=492376r2=492377
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
 Wed Jan  3 17:20:30 2007
@@ -1859,14 +1859,16 @@
  *
  * pA codenull/code input String returns codenull/code.
  * A codenull/code open/close returns codenull/code (no match).
- * An empty () open/close returns an empty string./p
+ * An empty () open and close returns an empty string./p
  *
  * pre
+ * StringUtils.substringBetween(wx[b]yz, [, ]) = b
  * StringUtils.substringBetween(null, *, *)  = null
+ * StringUtils.substringBetween(*, null, *)  = null
+ * StringUtils.substringBetween(*, *, null)  = null
  * StringUtils.substringBetween(, , )  = 
- * StringUtils.substringBetween(, , tag)   = null
- * StringUtils.substringBetween(, tag, tag)= null
- * StringUtils.substringBetween(yabcz, null, null) = null
+ * StringUtils.substringBetween(, , ]) = null
+ * StringUtils.substringBetween(, [, ])= null
  * StringUtils.substringBetween(yabcz, , ) = 
  * StringUtils.substringBetween(yabcz, y, z)   = abc
  * StringUtils.substringBetween(yabczyabcz, y, z)   = abc
@@ -1890,6 +1892,60 @@
 }
 }
 return null;
+}
+
+/**
+ * pSearches a String for substrings delimited by a start and end tag,
+ * returning all matching substrings in an array./p
+ *
+ * pA codenull/code input String returns codenull/code.
+ * A codenull/code open/close returns codenull/code (no match).
+ * An empty () open/close returns codenull/code (no match)./p
+ *
+ * pre
+ * StringUtils.substringsBetween([a][b][c], [, ]) = [a,b,c]
+ * StringUtils.substringsBetween(null, *, *)= null
+ * StringUtils.substringsBetween(*, null, *)= null
+ * StringUtils.substringsBetween(*, *, null)= null
+ * StringUtils.substringsBetween(, [, ])  = []
+ * /pre
+ *
+ * @param str  the String containing the substrings, null returns null, 
empty returns empty
+ * @param open  the String identifying the start of the substring, empty 
returns null
+ * @param close  the String identifying the end of the substring, empty 
returns null
+ * @return a String Array of substrings, or codenull/code if no match
+ * @since 2.3
+ */
+public static String[] substringsBetween(String str, String open, String 
close) {
+if (str == null || isEmpty(open) || isEmpty(close)) {
+return null;
+}
+int strLen = str.length();
+if (strLen == 0) {
+return ArrayUtils.EMPTY_STRING_ARRAY;
+}
+int closeLen = close.length();
+

[jira] Closed: (LANG-275) Add a pair of StringUtils.substringsBetween;String[] methods


 [ 
https://issues.apache.org/jira/browse/LANG-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Colebourne closed LANG-275.
---

   Resolution: Fixed
Fix Version/s: (was: 3.0)
   2.3
 Assignee: Stephen Colebourne

svn commit C:\dev\commons\lang\RELEASE-NOTES.txt 
C:\dev\commons\lang\project.xml 
C:\dev\commons\lang\src\java\org\apache\commons\lang\StringUtils.java 
C:\dev\commons\lang\src\test\org\apache\commons\lang\StringUtilsSubstringTest.java
 -N -m LANG-275 - StringUtils substringsBetween, implemented by Dave Meikle 
--username scolebourne
M C:\dev\commons\lang\RELEASE-NOTES.txt
M C:\dev\commons\lang\project.xml
M C:\dev\commons\lang\src\java\org\apache\commons\lang\StringUtils.java
M 
C:\dev\commons\lang\src\test\org\apache\commons\lang\StringUtilsSubstringTest.java
  Transmitting file data: C:\dev\commons\lang\RELEASE-NOTES.txt
  Transmitting file data: C:\dev\commons\lang\project.xml
  Transmitting file data: 
C:\dev\commons\lang\src\java\org\apache\commons\lang\StringUtils.java
  Transmitting file data: 
C:\dev\commons\lang\src\test\org\apache\commons\lang\StringUtilsSubstringTest.java
Committed revision 492377


 Add a pair of StringUtils.substringsBetween;String[] methods
 

 Key: LANG-275
 URL: https://issues.apache.org/jira/browse/LANG-275
 Project: Commons Lang
  Issue Type: Wish
Reporter: Henri Yandell
 Assigned To: Stephen Colebourne
Priority: Minor
 Fix For: 2.3

 Attachments: LANG-275.patch


 I found myself wanting a version of substringBetween(String, String, String) 
 that would return a String[] of the ones between and not just the single 
 String for the first match. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r492378 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java

Author: scolebourne
Date: Wed Jan  3 17:31:24 2007
New Revision: 492378

URL: http://svn.apache.org/viewvc?view=revrev=492378
Log:
Fix javadoc example

Modified:

jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java

Modified: 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java?view=diffrev=492378r1=492377r2=492378
==
--- 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java
 (original)
+++ 
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/BooleanUtils.java
 Wed Jan  3 17:31:24 2007
@@ -134,9 +134,9 @@
  * handling codenull/code by returning codetrue/code./p
  *
  * pre
- *   BooleanUtils.isNotTrue(Boolean.TRUE)  = true
- *   BooleanUtils.isNotTrue(Boolean.FALSE) = false
- *   BooleanUtils.isNotTrue(null)  = true
+ *   BooleanUtils.isNotFalse(Boolean.TRUE)  = true
+ *   BooleanUtils.isNotFalse(Boolean.FALSE) = false
+ *   BooleanUtils.isNotFalse(null)  = true
  * /pre
  *
  * @param bool  the boolean to check, null returns codetrue/code



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [lang] svn commit: r492361 - in /jakarta/commons/proper/lang/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/lang/BooleanUtils.java src/test/org/apache/commons/lang/BooleanUtilsTest.java

2007-01-03 Thread Stephen Colebourne


Rahul Akolkar wrote:

+ *   BooleanUtils.isNotTrue(Boolean.TRUE)  = true
+ *   BooleanUtils.isNotTrue(Boolean.FALSE) = false
+ *   BooleanUtils.isNotTrue(null)  = true
+ */
+public static boolean isNotFalse(Boolean bool) {
+return !isFalse(bool);
+}
+

snap/

Javadoc for this method (pre section) has incorrect method name.


Fixed, ta!

Stephen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (LANG-309) Add ArrayUtils.addFirst methods.