Re: [transaction] svn commit: r494203 - in /jakarta/commons/proper/transaction/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/transaction/file/ResourceManager.java

2007-01-10 Thread Joerg Heinicke
Rahul Akolkar rahul.akolkar at gmail.com writes:

  Generally speaking, an interface-compatible change will at most change the
  private interface of a component, or simply add classes, methods and
  attributes whose use is optional to both internal and external interface
  clients.
 
 And this is not.

In which way is it different from simply add [..] methods [..] whose use is
optional to both internal and external interface clients. ??

Even simply replacing the former jar with the next version should work as the
client does not know about the new methods. Only recompilation of
implementations need adaptions before but that's not what I consider a use or
a client.

Jörg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [all] jarfiles in svn

2007-01-10 Thread Joerg Heinicke
Craig McClanahan craigmcc at apache.org writes:

 Someone had asked earlier about how Commons projects accomplished this goal
 before Maven.  The answer was a convention for using Ant build.xml scripts
 that referenced a series of build.properties files containing definitions
 for things like what commons-digester.jar should I use.  The highest level
 such file consulted was your ${user.home}/build.properties, so it was
 reasonably easy to enforce global usage of common dependencies, as long as
 all the build scripts used the same variable names.

Ah, yes. That's how it works in my company actually.

 In your build script, don't hard code the build to use your particular
 version of the dependency only.  If I have my own version, I'm going to want
 to use it universally.

The build of commons transaction still has some remnants of the above method
(build.properties.sample in root dir and property
file=${basedir}/build.properties/ in build.xml). I have not tried it and it
might need some adaptions. But I'd like to know if this is still an acceptable
way at all for Jakarta Commons before I invest any effort to fix it.

So what's the outcome of this discussion?

Jörg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [all] jarfiles in svn

2007-01-10 Thread Joerg Heinicke
David Blevins david.blevins at visi.com writes:

 Only passively reading the thread, but from some of the comments and  
 your commit message it looks like you just need JDK 1.3 compiled  
 versions of those specs.

Yes, that's it.

 I'd be happy to apply your pom changes in the geronimo tree and put newly 
 built
 versions up for a vote.

That would be fine. But please review my pom changes. I'm not a Maven expert,
but only googled for compiling for target JDK and found different approaches.
Though this approach works for me there might be cases where it does not or
simply better ones.

Jörg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [all] jarfiles in svn

2007-01-10 Thread Henri Yandell

This is an interesting 'request to developers':

http://www.jpackage.org/jpprequest.php

with some reasons for why putting in the external binaries is a pain
for redistributing.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[RESULT] Add Matt Benson as a Jakarta committer

2007-01-10 Thread Henri Yandell

On 1/5/07, Henri Yandell [EMAIL PROTECTED] wrote:

As you can see on the list, Matt would like to help out with JXPath.
Matt's been an Ant committer since Feb 2004. He's been active on the
dev/user lists over the last couple of years, so not a new face here
either.

[ ] +1
[ ] -1

Will end the vote on Tuesday morning.


Little late - sorry. Busy day yesterday.

+1s from:

Niall Pemberton
Oliver Heger
Phil Steitz
Rahul Akolkar
Joerg Schaible
Martin van den Bemt
Joerg Heinicke
Mario Ivankovits
Stephen Colebourne
Stefan Bodewig
Rory Winston

JIRA + SVN karma has been granted - I'll get the unix group done once
I know if it's a root@ mail or a JIRA issue.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r494902 - /jakarta/commons/proper/jxpath/trunk/project.xml

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 09:32:14 2007
New Revision: 494902

URL: http://svn.apache.org/viewvc?view=revrev=494902
Log:
add me

Modified:
jakarta/commons/proper/jxpath/trunk/project.xml

Modified: jakarta/commons/proper/jxpath/trunk/project.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/project.xml?view=diffrev=494902r1=494901r2=494902
==
--- jakarta/commons/proper/jxpath/trunk/project.xml (original)
+++ jakarta/commons/proper/jxpath/trunk/project.xml Wed Jan 10 09:32:14 2007
@@ -90,6 +90,11 @@
   email[EMAIL PROTECTED]/email
   organizationSun Microsystems/organization
 /developer
+developer
+  nameMatt Benson/name
+  idmbenson/id
+  email[EMAIL PROTECTED]/email
+/developer
   /developers
   
   dependencies



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r494917 - in /jakarta/commons/proper/jxpath/trunk/src: java/org/apache/commons/jxpath/ri/model/dom/ java/org/apache/commons/jxpath/ri/model/jdom/ test/org/apache/commons/jxpath/ri/model/do

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 10:27:20 2007
New Revision: 494917

URL: http://svn.apache.org/viewvc?view=revrev=494917
Log:
[JXPATH-12] Descendant or self axis does not work correctly at root node.
Contributed by Marcin Sarniak.

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/dom/DOMModelTest.java

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/jdom/JDOMModelTest.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java?view=diffrev=494917r1=494916r2=494917
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java
 Wed Jan 10 10:27:20 2007
@@ -113,7 +113,8 @@
 int nodeType = node.getNodeType();
 switch (((NodeTypeTest) test).getNodeType()) {
 case Compiler.NODE_TYPE_NODE :
-return nodeType == Node.ELEMENT_NODE;
+return nodeType == Node.ELEMENT_NODE
+|| nodeType == Node.DOCUMENT_NODE;
 case Compiler.NODE_TYPE_TEXT :
 return nodeType == Node.CDATA_SECTION_NODE
 || nodeType == Node.TEXT_NODE;

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java?view=diffrev=494917r1=494916r2=494917
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
 Wed Jan 10 10:27:20 2007
@@ -373,7 +373,7 @@
 else if (test instanceof NodeTypeTest) {
 switch (((NodeTypeTest) test).getNodeType()) {
 case Compiler.NODE_TYPE_NODE :
-return node instanceof Element;
+return (node instanceof Element) || (node instanceof 
Document);
 case Compiler.NODE_TYPE_TEXT :
 return (node instanceof Text) || (node instanceof CDATA);
 case Compiler.NODE_TYPE_COMMENT :

Modified: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/dom/DOMModelTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/dom/DOMModelTest.java?view=diffrev=494917r1=494916r2=494917
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/dom/DOMModelTest.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/dom/DOMModelTest.java
 Wed Jan 10 10:27:20 2007
@@ -65,6 +65,7 @@
 assertXPathNodeType(context, /, Document.class);
 assertXPathNodeType(context, /vendor/location, Element.class);
 assertXPathNodeType(context, //location/@name, Attr.class);
+assertXPathNodeType(context, //vendor, Element.class);
 }
 
 protected String getXMLSignature(

Modified: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/jdom/JDOMModelTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/jdom/JDOMModelTest.java?view=diffrev=494917r1=494916r2=494917
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/jdom/JDOMModelTest.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/jdom/JDOMModelTest.java
 Wed Jan 10 10:27:20 2007
@@ -62,7 +62,8 @@
 assertXPathNodeType(context, /, Document.class);
 assertXPathNodeType(context, /vendor/location, Element.class);
 assertXPathNodeType(context, //location/@name, Attribute.class);
-}
+assertXPathNodeType(context, //vendor, Element.class); //bugzilla 
#38586
+}
 
 public void testID() {
 // id() is not supported by JDOM




svn commit: r494918 - /jakarta/commons/proper/jxpath/trunk/xdocs/contributors.xml

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 10:29:17 2007
New Revision: 494918

URL: http://svn.apache.org/viewvc?view=revrev=494918
Log:
add me

Modified:
jakarta/commons/proper/jxpath/trunk/xdocs/contributors.xml

Modified: jakarta/commons/proper/jxpath/trunk/xdocs/contributors.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/xdocs/contributors.xml?view=diffrev=494918r1=494917r2=494918
==
--- jakarta/commons/proper/jxpath/trunk/xdocs/contributors.xml (original)
+++ jakarta/commons/proper/jxpath/trunk/xdocs/contributors.xml Wed Jan 10 
10:29:17 2007
@@ -35,6 +35,7 @@
  /p
  !-- alphabetical by last name please --
  ul
+liMatt Benson/li
 liCraig R. McClanahan/li
 liDmitri Plotnikov/li
  /ul



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [RESULT] Add Matt Benson as a Jakarta committer

2007-01-10 Thread Matt Benson

--- Henri Yandell [EMAIL PROTECTED] wrote:

 On 1/5/07, Henri Yandell [EMAIL PROTECTED] wrote:
  As you can see on the list, Matt would like to
 help out with JXPath.
  Matt's been an Ant committer since Feb 2004. He's
 been active on the
  dev/user lists over the last couple of years, so
 not a new face here
  either.
 
  [ ] +1
  [ ] -1
 
  Will end the vote on Tuesday morning.
 
 Little late - sorry. Busy day yesterday.
 
 +1s from:
 
 Niall Pemberton
 Oliver Heger
 Phil Steitz
 Rahul Akolkar
 Joerg Schaible
 Martin van den Bemt
 Joerg Heinicke
 Mario Ivankovits
 Stephen Colebourne
 Stefan Bodewig
 Rory Winston
 
 JIRA + SVN karma has been granted - I'll get the
 unix group done once
 I know if it's a root@ mail or a JIRA issue.

I don't seem to be able to close issues in JIRA.  :(

-Matt

 
 Hen
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 


__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [RESULT] Add Matt Benson as a Jakarta committer

2007-01-10 Thread Matt Benson
Oh... beyond that complaint, thanks all!  :)

-Matt

--- Matt Benson [EMAIL PROTECTED] wrote:

 
 --- Henri Yandell [EMAIL PROTECTED] wrote:
 
  On 1/5/07, Henri Yandell [EMAIL PROTECTED]
 wrote:
   As you can see on the list, Matt would like to
  help out with JXPath.
   Matt's been an Ant committer since Feb 2004.
 He's
  been active on the
   dev/user lists over the last couple of years, so
  not a new face here
   either.
  
   [ ] +1
   [ ] -1
  
   Will end the vote on Tuesday morning.
  
  Little late - sorry. Busy day yesterday.
  
  +1s from:
  
  Niall Pemberton
  Oliver Heger
  Phil Steitz
  Rahul Akolkar
  Joerg Schaible
  Martin van den Bemt
  Joerg Heinicke
  Mario Ivankovits
  Stephen Colebourne
  Stefan Bodewig
  Rory Winston
  
  JIRA + SVN karma has been granted - I'll get the
  unix group done once
  I know if it's a root@ mail or a JIRA issue.
 
 I don't seem to be able to close issues in JIRA.  :(
 
 -Matt
 
  
  Hen
  
 

-
  To unsubscribe, e-mail:
  [EMAIL PROTECTED]
  For additional commands, e-mail:
  [EMAIL PROTECTED]
  
  
 
 
 __
 Do You Yahoo!?
 Tired of spam?  Yahoo! Mail has the best spam
 protection around 
 http://mail.yahoo.com 
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 



 

Never Miss an Email
Stay connected with Yahoo! Mail on your mobile.  Get started!
http://mobile.yahoo.com/services?promote=mail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[email] Status and JIRA breakdown

2007-01-10 Thread Ben Speakmon

Greets all,

I'd like to share my impressions of the current open issues for email
and what I think would be a good plan for taking them on. I plan to
prepare patches for most of the outstanding issues, but I wanted to
ask for feedback on them as well.

There are currently 13 open issues in JIRA; happily one was closed
last week when the OP got a new comment on the issue and marked it
closed as being his fault. Of the 13:

4 issues: Fixes for, or new features for, charset support
4 issues: Improvements to how attachments work
2 issues: Simple-looking performance enhancements (both with patches I
reviewed and that seem to be okay)
1 bug: HTML Emails with images don't display in Outlook 2000
(https://issues.apache.org/jira/browse/EMAIL-50)
2 features: adding SSL support and generating Email objects from
InputStreams or Strings (both of which seem useful)

I know that email 1.0 was targeted at javamail 1.3 and jaf 1.0.2, but
since then the 1.1-SNAPSHOT in the maven file has updated to 1.4 and
1.1 respectively, and Henri committed the patch I submitted to enforce
the same versions in the build.xml. Therefore it seems that the
decision to ship a 1.1 with the newer versions has already been made,
so I don't see why any of the current issues should be postponed to a
2.0 release. Right now email is a very simple API, and I don't see a
need either from my own use of it or from the current open issues to
push a lot of new features onto it; rather the focus should be on
making what's already there work better.

In any case, I'm going to take some time to review the charset issues
more closely and see if a good solution pops out. Please let me know
if there's something else someone would like me to examine while I'm
in there :)

--Ben

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [RESULT] Add Matt Benson as a Jakarta committer

2007-01-10 Thread Henri Yandell

On 1/10/07, Matt Benson [EMAIL PROTECTED] wrote:



I don't seem to be able to close issues in JIRA.  :(


Ack :( New JIRA system is a pain in the arse it seems.

It's good for most - means that projects can manage themselves better
by adding project roles so people can administer the project (as in
adding people to the project); but we have many projects and would
have to give Matt a committer role for every single Jakarta project
(30-40 at a guess).

Painful. I've added you to the list for JXPath Matt, so that should
solve the immediate problem. Long-term, it looks like you can tie a
group to a project role, so I'll have a look at that to see if it
solves things. I think it will.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [RESULT] Add Matt Benson as a Jakarta committer

2007-01-10 Thread Matt Benson
Thanks again, Hen (forgive the top post).

-Matt

--- Henri Yandell [EMAIL PROTECTED] wrote:

 On 1/10/07, Matt Benson [EMAIL PROTECTED]
 wrote:
 
 
  I don't seem to be able to close issues in JIRA. 
 :(
 
 Ack :( New JIRA system is a pain in the arse it
 seems.
 
 It's good for most - means that projects can manage
 themselves better
 by adding project roles so people can administer the
 project (as in
 adding people to the project); but we have many
 projects and would
 have to give Matt a committer role for every single
 Jakarta project
 (30-40 at a guess).
 
 Painful. I've added you to the list for JXPath Matt,
 so that should
 solve the immediate problem. Long-term, it looks
 like you can tie a
 group to a project role, so I'll have a look at that
 to see if it
 solves things. I think it will.
 
 Hen
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 



 

Cheap talk?
Check out Yahoo! Messenger's low PC-to-Phone call rates.
http://voice.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (IO-79) [IO][PATCH] - file and directory pollers

2007-01-10 Thread Henri Yandell (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463667
 ] 

Henri Yandell commented on IO-79:
-

Quartz contains a FileScanJob that is a poller - so possibly it might be better 
to point people to that.

 [IO][PATCH] - file and directory pollers
 

 Key: IO-79
 URL: https://issues.apache.org/jira/browse/IO-79
 Project: Commons IO
  Issue Type: Improvement
  Components: Utilities
Affects Versions: 1.1
 Environment: Operating System: other
 Platform: Other
Reporter: Jim Harrington
Priority: Minor
 Fix For: 1.4

 Attachments: file_directory_poller.jar


 Add classes that will monitor a file/directory and notify registered 
 observers 
 creation, deletion and content change events occur.  Source is in the 
 attachement file_directory_poller.jar as they are all new files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JXPATH-12) [jxpath] Descendant or self axis does not work correctly at root node

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-12.
---

Resolution: Fixed

committed to SVN HEAD.  Thanks!

 [jxpath] Descendant or self axis does not work correctly at root node
 -

 Key: JXPATH-12
 URL: https://issues.apache.org/jira/browse/JXPATH-12
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: 1.2 Final
 Environment: Operating System: other
 Platform: Other
Reporter: Simon Raess
 Fix For: 1.3

 Attachments: DescendantOrSelfTest.java, patch.jxpath-12.txt


 Given the following XML document: root id=1234/
 and the XPath: //root/@id/text().
 JXPath returns null instead of 1234.
 JXPathContext context = JXPathContext.newContext(doc);
 assertEquals(value, context.selectSingleNode(//root/@id/text()));
 The attached JUnit test highlights the problem. It seems that JXPath does not
 find the root node if it is accessed with the axis descendant-or-self.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r494925 - /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ClassFunctions.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 10:48:58 2007
New Revision: 494925

URL: http://svn.apache.org/viewvc?view=revrev=494925
Log:
[JXPATH-38] ClassFunctions throws NPE searching for a function in null ns

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ClassFunctions.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ClassFunctions.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ClassFunctions.java?view=diffrev=494925r1=494924r2=494925
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ClassFunctions.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ClassFunctions.java
 Wed Jan 10 10:48:58 2007
@@ -86,7 +86,11 @@
 String name,
 Object[] parameters) 
 {
-if (!namespace.equals(this.namespace)) {
+if (namespace == null) {
+if (this.namespace != null) {
+return null;
+}
+} else if (!namespace.equals(this.namespace)) {
 return null;
 }
 
@@ -117,4 +121,4 @@
 
 return null;
 }
-}
\ No newline at end of file
+}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JXPATH-38) [jxpath] ClassFunctions throws NPE searching for a function in null ns

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-38.
---

Resolution: Fixed

fixed in SVN HEAD.

 [jxpath] ClassFunctions throws NPE searching for a function in null ns
 --

 Key: JXPATH-38
 URL: https://issues.apache.org/jira/browse/JXPATH-38
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: 1.2 Final
 Environment: Operating System: other
 Platform: Other
Reporter: Matt Benson
 Fix For: 1.3

 Attachments: jxpath-38.patch.txt


 First thing in getFunction(...):
 if (!namespace.equals(this.namespace)) {
 return null;
 }
 In contrast PackageFunctions has null checks.  I think I can work around this 
 by
 always using a namespace, but I can't think of any reason this behavior should
 persist into (theoretical) future versions of jxpath.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [transaction] svn commit: r494203 - in /jakarta/commons/proper/transaction/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/transaction/file/ResourceManager.java

2007-01-10 Thread Rahul Akolkar

On 1/10/07, Joerg Heinicke [EMAIL PROTECTED] wrote:

Rahul Akolkar rahul.akolkar at gmail.com writes:

  Generally speaking, an interface-compatible change will at most change the
  private interface of a component, or simply add classes, methods and
  attributes whose use is optional to both internal and external interface
  clients.

 And this is not.

In which way is it different from simply add [..] methods [..] whose use is
optional to both internal and external interface clients. ??

Even simply replacing the former jar with the next version should work as the
client does not know about the new methods. Only recompilation of
implementations need adaptions before but that's not what I consider a use or
a client.


snip/

I suspect that bit is talking about Java classes (rather than
interfaces), though I haven't tried to hunt it down in the guide. I
flagged what I thought would lead to a versioning discussion at 1.2
voting time. Lets please move on, the Commons versioning criteria are
quite objective, and I have nothing to add.

-Rahul



Jörg




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [all] jarfiles in svn

2007-01-10 Thread David Blevins


On Jan 10, 2007, at 2:39 AM, Joerg Heinicke wrote:


David Blevins david.blevins at visi.com writes:


Only passively reading the thread, but from some of the comments and
your commit message it looks like you just need JDK 1.3 compiled
versions of those specs.


Yes, that's it.


Cool.



I'd be happy to apply your pom changes in the geronimo tree and  
put newly built

versions up for a vote.


That would be fine. But please review my pom changes. I'm not a  
Maven expert,
but only googled for compiling for target JDK and found different  
approaches.
Though this approach works for me there might be cases where it  
does not or

simply better ones.


It looks good, I'll give it a try.

-David


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [all] logos?

2007-01-10 Thread Henri Yandell

Wow - could have sworn this thread was newer :)

Anyway, thought I'd point the svg logo creation bit out; I suspect a
bunch of our logos could have come from that.

https://svn.apache.org/repos/asf/forrest/trunk/tools/logos/

Hen

On 9/7/05, James Carman [EMAIL PROTECTED] wrote:

Thank you, Phil.  It worked like a charm once I had my wife show me how to
use Gimp (she's a photoshop expert).

-Original Message-
From: Phil Steitz [mailto:[EMAIL PROTECTED]
Sent: Wednesday, September 07, 2005 6:04 PM
To: Jakarta Commons Developers List
Subject: Re: [all] logos?

We hired a high-end graphics designer who gave us a great deal ;-)
 Just kidding (unless Tim is now doing this commerically ;))
 Have a look in codec/src/media. Most were cloned from the Gimp file there.
 Phil

 On 9/6/05, James Carman [EMAIL PROTECTED] wrote:

 How were the logos for the individual components created? I'd like to
 create one for Commons Proxy.






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (CONFIGURATION-143) [configuration] Support event listeners for configurations

2007-01-10 Thread Oliver Heger (JIRA)

 [ 
https://issues.apache.org/jira/browse/CONFIGURATION-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Heger resolved CONFIGURATION-143.


   Resolution: Fixed
Fix Version/s: 1.4

Basic event support (i.e. the raw event layer) was added a while ago. I would 
like to close this ticket. For enhanced requirements (e.g. filtering of events) 
further tickets can be opened.

 [configuration] Support event listeners for configurations
 --

 Key: CONFIGURATION-143
 URL: https://issues.apache.org/jira/browse/CONFIGURATION-143
 Project: Commons Configuration
  Issue Type: Improvement
Affects Versions: 1.2 Final
 Environment: Operating System: other
 Platform: Other
Reporter: Oliver Heger
Priority: Minor
 Fix For: 1.4

 Attachments: events-tests.diff, events.diff, events.diff


 I would like to suggest creating a ConfigurationEvent class and a
 ConfigurationEventListener interface for monitoring changes on configurations.
 AbstractConfiguration could act as an event source allowing listeners to
 register itself at an instance. Whenever this instance is modified a
 notification is sent out to all registered listeners.
 The event class could contain
 - a reference to the affected Configuration object
 - an ID about the type of the event (e.g. property added, property removed,
 configuration cleared etc.)
 - the name of the affected property if applicable
 - the value of the affected property if applicable
 The listener interface could be quite simple and contain only a single method:
 void configurationChanged(ConfigurationEvent event);
 While an implementation should not be too complicated some details need to be
 cleared:
 - ATM as AbstractConfiguration is implemented an operation could cause 
 multiple
 events. For instance setProperty() is implemented as calling clearProperty() 
 and
 then addProperty(). Should this be caught and treated as a single event?
 - Should a reload of a file based configuration cause an event? Could this be
 problematic if a called listener tries to access the configuration?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (CONFIGURATION-165) [configuration] Use beanutils for conversions

2007-01-10 Thread Oliver Heger (JIRA)

 [ 
https://issues.apache.org/jira/browse/CONFIGURATION-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Heger resolved CONFIGURATION-165.


Resolution: Won't Fix

This issue is now open for a long while. ATM I see no really benefit in 
changing the conversion code to use beanutils. The additional dependency may 
even be considered as harmful by some people. Maybe if the converters in 
beanutils are enhanced to cover all the use cases we need, or if the [convert] 
project wakes up again, we can re-evaluate this issue.

So closing this ticket as won't fix.

 [configuration] Use beanutils for conversions
 -

 Key: CONFIGURATION-165
 URL: https://issues.apache.org/jira/browse/CONFIGURATION-165
 Project: Commons Configuration
  Issue Type: Improvement
 Environment: Operating System: other
 Platform: Other
Reporter: Ittay Dror
Priority: Minor

 Currently AbstractConfiguration has its own logic for conversion. This makes 
 it 
 non standard with commons beanutils. Furthermore, commons beanutils is 
 extendible, so by using it, one can write a method 
 Object getProperty(String key, Class c) 
 which would automatically convert the returned value of getProperty(String 
 key) 
 to the requested class. This means that (as long as I register the right 
 converter) i can use getProperty(my.class, MyClass.class) and get 
 automatically and instance of MyClass. Very usefull, esp. for enumerations 
 (which can easily have their own converter if using commons-lang's enum)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (CONFIGURATION-215) Using relative URLs

2007-01-10 Thread Oliver Heger (JIRA)

[ 
https://issues.apache.org/jira/browse/CONFIGURATION-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463705
 ] 

Oliver Heger commented on CONFIGURATION-215:


I never got a response to my last suggestions. What is the current status of 
this issue? Is this feature still needed?

 Using relative URLs
 ---

 Key: CONFIGURATION-215
 URL: https://issues.apache.org/jira/browse/CONFIGURATION-215
 Project: Commons Configuration
  Issue Type: Improvement
Reporter: Michiel Kalkman
Priority: Minor

 It would be useful to be able to specify URLs in configuration item values 
 that are relative to the configuration.
 A sample. I have the following files.
 A/config.xml   which refers to
 B/specificConfigForB.xml   which refers to
 B/somefile
 Now specifying the location of somefile in specificConfigForB.xml should be 
 possible using a relative URL, such that it is possible to retrieve the 
 absolute URL of somefile through:
 a) the absolute URL of A/config.xml (e.g.: file:/c:/A/config.xml or 
 http://A/config.xml)
 b) the relative URL of somefile specified in B/specificConfigForB.xml (like 
 somefilesomefile/somefile)
 (1) One solution is to make it possible to find the location of the 
 configuration file that specifies the relative URL. Or more general, commons 
 config should know where a given configuration item is stored.
 In this case it might be an idea to implement a getURL() on the Configuration 
 interface which uses:
 1. the absolute URL of the composite configuration file, (A/config.xml)
 2. the relative URL to the specfying configuration file, 
 (B/specificConfigForB.xml)
 3. the relative URL specified (in B/specificConfigForB.xml)
 (2) Another solution is to specify a special meta variable (like ${url}) that 
 can be used to specify the location of the specifying configuration file wrt 
 the composite configuration file. E.g. somefile${url}/somefile/somefile 
 would result in ../B/somefile.
 (3) Another solution would be to specify a special attribute to indicate that 
 the value specified is an URL. Like somefile type=URLsomefile/somefile.
 The advantage of solution (1) is that no extra semantics are introduced to 
 the configuration files. Furthermore, it might possibly be useful in 
 debugging situations. The advantages of solution (2) is that in this manner 
 other meta variables might be introduced. The disadvantage of solution (3) is 
 that this one cannot be applied to property files.
 See also 
 http://mail-archives.apache.org/mod_mbox/jakarta-commons-user/200606.mbox/[EMAIL
  PROTECTED]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[IO][Configuration] BOMs and charset detection

2007-01-10 Thread Oliver Heger
For [configuration] there are two enhancement requests dealing with byte 
order marks and charset detection [1, 2].


I am just wondering if such features would be of interest for [io], too 
- or if [io] would generally be a better place for such functionality.


WDYT?

Oliver

[1] https://issues.apache.org/jira/browse/CONFIGURATION-175
[2] https://issues.apache.org/jira/browse/CONFIGURATION-164

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



UUID number generation problem

2007-01-10 Thread Pradeep Arumalla

hi all,
 I am trying to understand how the UUID generation works, I am trying to
run the *code snippet 1  *,100 times, and it prints the same number 100
times, Is it not supposed to print a different number eachtime.And If I run
the *code snippet 2  * 100 times, I get adifferent number each time .The
documentation says *code snippet 1*   is efficient than *code snippet
2.  ,*forgive my ignorance
*.* Please help
**
**
**
**
*code snippet 1 :*
**
for ( int i=0; i100; i++){
  System.out.println(***+ UUID.nameUUIDFromString(namespace,new
UUID(f807f2fc-b49b-4512-a787-92300367b932),UUID.SHA1_ENCODING));
 }


*code snippet 2 :*
**
for ( int i=0; i100; i++){
  System.out.println(*** +UUID.randomUUID().toString());
 }

Thanks
Pradeep


Re: Introducing commons-skin

2007-01-10 Thread Dennis Lundberg

Dennis Lundberg wrote:

Boris Unckel wrote:

Hi,

yet another issue.


snip


I had a look at the source and found XHTML transistional in the doctype.
Both http://validator.w3.org and http://www.validome.org say it is not 
valid.
I think you know the tools, even when not, they are very easy to use 
(I did not write: give good hint's for hunting the bugs).


Regards
Boris


This turned out to be trickier than I first thought, but here goes:

1. The xdocs for commons-lang are fine.

2. Rendering of links that include the -character, even if they are 
properly encoded as amp; in the xdoc source, seems to be broken. That 
is the -character doesn't get escaped properly, resulting in invalid 
xhtml. This is filed as DOXIA-85 [1].


DOXIA-85 has been solved. Using a locally build version of Doxia I have 
created a staged lang site with validating xhtml code:


  http://people.apache.org/~dennisl/commons-lang6/

3. The rendered documents include a css link to css/site.css - a file 
which doesn't exist, resulting in invalid css. This is filed as DOXIA-86 
[2].


This is an intended behavior, i.e the file is optional for the user to 
put there, and I haven't been able to create a workaround for this. It 
could be done in the velocity template like this:


if( the file css/site.css is available on the file system )
{
  import the css file
}

Unfortunately I don't know how to. Perhaps someone from the Velocity 
project can help out with this?



Anyway, this doesn't involve changing commons-skin.


[1] http://jira.codehaus.org/browse/DOXIA-85
[2] http://jira.codehaus.org/browse/DOXIA-86




--
Dennis Lundberg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Introducing commons-skin

2007-01-10 Thread Dennis Lundberg

Dennis Lundberg wrote:

Dennis Lundberg wrote:

Henri Yandell wrote:

Looks good - nice work :)

Only bit that leaps out to me as missing are the little arrows to
symbolize external links. We may not care.


Yes, I have seen that as well. The problem is that the M2 site plugin 
does not generate a class=externalLink for those links like M1 did. 
I'll have a look and see if that's difficult to add.


I have created a patch for maven-doxia to handle this:

  http://jira.codehaus.org/browse/DOXIA-87

snip


I have fixed this issue. It's not released yet, but using a localy build 
Doxia I have created yet another staged lang site, that shows how it looks:


  http://people.apache.org/~dennisl/commons-lang6/

--
Dennis Lundberg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (DBCP-202) Deadlock creating/closing PreparedStatement

2007-01-10 Thread Ling Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/DBCP-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463735
 ] 

Ling Yu commented on DBCP-202:
--

In a multi-thread environment that can open and close PreparedStatement at the 
same time, one thread may try to obtain a PreparedStatment (eventually called 
to PoolingConnection.prepareStatement), this will lock on the Connection object 
and trying to wait for statement pool object, but if at the same time another 
thread that is executing the PreparedStatment.close() method (eventually called 
to PoolablePreparedStatement.close),  then it will lock on the statement pool 
object and try to obtain a Connection object lock.  As a result, both threads 
will cause a dead lock.

The possible solution is to removed the synchronized keyword in the 
PoolingConnection.prepareStatement() as it does not modify / access any other 
critical resources other than the statement pool.

The above testing and fixing is based on common-dbcp-1.2.1

 Deadlock creating/closing PreparedStatement
 ---

 Key: DBCP-202
 URL: https://issues.apache.org/jira/browse/DBCP-202
 Project: Commons Dbcp
  Issue Type: Bug
Affects Versions: 1.2.2
Reporter: Gustavo Huff Mauch
 Fix For: 1.3


 Hi!
 I´m using DBCP in a multi-threaded app. Sometimes a few threads share the 
 same connection (obtained from the same BasicDatasource) and quite often the 
 application just hangs. Looking a bit further i found out that it hangs when 
 one thread is creating a PreparedStatement and the other one is closing 
 another PreparedStatement.
 I connected to my app with jConsole and i was able to see the stacktrace for 
 two threads that blocked one another. Here is:
  
 Name: pool-1-thread-1
 State: BLOCKED on [EMAIL PROTECTED] owned by: pool-1-thread-2
 Total blocked: 137  Total waited: 1
 Stack trace: 
 org.apache.commons.pool.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:767)
 org.apache.commons.dbcp.PoolingConnection.prepareStatement(PoolingConnection.java:87)
 org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:185)
 org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:278)
 dmview.common.Database.prepareStatement(Database.java:829)
 dmview.monitor.polling.ProxyUpdater.insertAllSlotPortsIntoDb(ProxyUpdater.java:801)
 dmview.monitor.polling.ProxyUpdater.insertSlotIntoDb(ProxyUpdater.java:718)
 dmview.monitor.polling.ProxyUpdater.updateDevice(ProxyUpdater.java:296)
 dmview.monitor.polling.ProxyUpdater.update(ProxyUpdater.java:81)
 dmview.monitor.polling.Poller.run(Poller.java:183)
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
 java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
 java.lang.Thread.run(Unknown Source)
 The stacktrace for the second thread : 
 Name: pool-1-thread-2
 State: BLOCKED on [EMAIL PROTECTED] owned by: pool-1-thread-1
 Total blocked: 107  Total waited: 1
 Stack trace: 
 org.apache.commons.dbcp.AbandonedTrace.removeTrace(AbandonedTrace.java:221)
 org.apache.commons.dbcp.PoolablePreparedStatement.passivate(PoolablePreparedStatement.java:100)
 org.apache.commons.dbcp.PoolingConnection.passivateObject(PoolingConnection.java:239)
 org.apache.commons.pool.impl.GenericKeyedObjectPool.returnObject(GenericKeyedObjectPool.java:970)
 org.apache.commons.dbcp.PoolablePreparedStatement.close(PoolablePreparedStatement.java:78)
 org.apache.commons.dbcp.DelegatingStatement.close(DelegatingStatement.java:165)
 dmview.monitor.polling.ProxyUpdater.insertAllSlotPortsIntoDb(ProxyUpdater.java:883)
 dmview.monitor.polling.ProxyUpdater.insertSlotIntoDb(ProxyUpdater.java:718)
 dmview.monitor.polling.ProxyUpdater.updateDevice(ProxyUpdater.java:296)
 dmview.monitor.polling.ProxyUpdater.update(ProxyUpdater.java:81)
 dmview.monitor.polling.Poller.run(Poller.java:183)
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
 java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
 java.lang.Thread.run(Unknown Source)
 The line 829 from method Database.prepareStatement (last one from my app 
 before DBCP, in first stacktrace) is :
 PreparedStatement ret = conexao.prepareStatement(sql);
 where conexao is a java.sql.Connection obtained from the pool.
 The line 883 in method ProxyUpdater.insertAllSlotPortsIntoDb (last one from 
 my app before DBCP, in second stacktrace) is :
 insertPortTest.close();
 where insertPortTest is a PreparedStatement.
 It all seems to me that creating/closing PreparedStatements using the same 
 connection from a BasicDatasource instance can cause a racing condition where 
 two (or more) threads may block one another. Am i correct? Is this really a 
 bug?
 Thanks in advance!

-- 
This message is automatically generated by JIRA.
-
If you 

svn commit: r495015 - in /jakarta/commons/proper/jxpath/trunk/src: java/org/apache/commons/jxpath/ri/compiler/Expression.java test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:37:24 2007
New Revision: 495015

URL: http://svn.apache.org/viewvc?view=revrev=495015
Log:
[JXPATH-50] properly handle NodeSet returned by extension function.
Submitted by Keith D. Gregory.

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/compiler/Expression.java

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/compiler/Expression.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/compiler/Expression.java?view=diffrev=495015r1=495014r2=495015
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/compiler/Expression.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/compiler/Expression.java
 Wed Jan 10 14:37:24 2007
@@ -16,6 +16,7 @@
  */
 package org.apache.commons.jxpath.ri.compiler;
 
+import org.apache.commons.jxpath.NodeSet;
 import org.apache.commons.jxpath.Pointer;
 import org.apache.commons.jxpath.ri.EvalContext;
 import org.apache.commons.jxpath.ri.model.NodePointer;
@@ -74,6 +75,9 @@
 if (result instanceof EvalContext) {
 return new ValueIterator((EvalContext) result);
 }
+if (result instanceof NodeSet) {
+return new ValueIterator(((NodeSet) 
result).getPointers().iterator());
+}
 return ValueUtils.iterate(result);
 }
 
@@ -85,6 +89,11 @@
 if (result instanceof EvalContext) {
 return (EvalContext) result;
 }
+if (result instanceof NodeSet) {
+return new PointerIterator(((NodeSet) 
result).getPointers().iterator(),
+new QName(null, value),
+
context.getRootContext().getCurrentNodePointer().getLocale());
+}
 return new PointerIterator(ValueUtils.iterate(result),
 new QName(null, value),
 context.getRootContext().getCurrentNodePointer().getLocale());
@@ -95,6 +104,7 @@
 private QName qname;
 private Locale locale;
 
+//to what method does the following comment refer?
 /**
  * @deprecated Use the method that takes a NamespaceManager
  */
@@ -110,7 +120,7 @@
 
 public Object next() {
 Object o = iterator.next();
-return NodePointer.newNodePointer(qname, o, locale);
+return o instanceof Pointer ? o : 
NodePointer.newNodePointer(qname, o, locale);
 }
 
 public void remove() {

Modified: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java?view=diffrev=495015r1=495014r2=495015
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java
 Wed Jan 10 14:37:24 2007
@@ -46,6 +46,7 @@
 public class ExtensionFunctionTest extends JXPathTestCase {
 private Functions functions;
 private JXPathContext context;
+private TestBean testBean;
 
 public static void main(String[] args) {
 TestRunner.run(ExtensionFunctionTest.class);
@@ -62,7 +63,8 @@
 
 public void setUp() {
 if (context == null) {
-context = JXPathContext.newContext(new TestBean());
+testBean = new TestBean();
+context = JXPathContext.newContext(testBean);
 Variables vars = context.getVariables();
 vars.declareVariable(test, new TestFunctions(4, test));
 
@@ -337,6 +339,11 @@
 test:nodeSet()/name,
 list(Name 1, Name 2));
 
+assertXPathValueIterator(
+context,
+test:nodeSet(),
+list(testBean.getBeans()[0], testBean.getBeans()[1]));
+
 assertXPathPointerIterator(
 context,
 test:nodeSet()/name,
@@ -379,4 +386,4 @@
 return 0;
 }
 }
-}
\ No newline at end of file
+}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JXPATH-50) [jxpath] does not properly handle NodeSet returned by extension function

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-50.
---

Resolution: Fixed

applied to SVN HEAD.  Thanks, Keith!

 [jxpath] does not properly handle NodeSet returned by extension function
 

 Key: JXPATH-50
 URL: https://issues.apache.org/jira/browse/JXPATH-50
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: 1.2 Final
 Environment: Operating System: other
 Platform: All
Reporter: Keith D Gregory
 Fix For: 1.3

 Attachments: jxpath-50.patch.txt, jxpath-nodeset-functions.patch


 Per the documentation, my function is returning a BasicNodeSet containing zero
 or more pointers:
   public static NodeSet observations(ExpressionContext context) {
 // the cast below shouldn't break, as this is the only pointer type that
 // makes sense in this context
 ListNodePointer ptrs = extractObservations(
   
 (NodePointer)context.getContextNodePointer(), 
   new ArrayListNodePointer());
 BasicNodeSet result = new BasicNodeSet();
 for (NodePointer ptr : ptrs) {
   result.add(ptr);
 }
 return result;
   }
 However, if I call JXPathContext.selectNodes(ems:observations()), I'm 
 getting
 a single node containing the BasicNodeSet. I notice that there is a testcase 
 for
 functions that return NodeSets, but that it uses expressions that actually
 return the children of the NodeSet (test:nodeSet()/name).
 There appear to be two problems. First, Expression.iterate() and
 Expression.iteratePointers() do not correctly recognize a NodeSet as something
 iterable. I've resolved this by reaching into the NodeSet and getting an
 iterator over its pointers.
 Second, Expression.PointerIterator doesn't recognize when it already has a
 pointer, and instead tries to wrap it in a new pointer. This ends up treating
 the pointer as a bean.
 I've made these changes, and written a testcase that uses an unadorned NodeSet
 function. I also found a class that used a variable named enum, and changed
 this so that it would compile under 1.5.
 The patch is attached. It's relative to commons-jxpath-1.2 (root of extract
 directory).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495019 - /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/JXPathContextReferenceImpl.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:44:18 2007
New Revision: 495019

URL: http://svn.apache.org/viewvc?view=revrev=495019
Log:
[JXPATH-20] removeAll() only removed the first matching element; slightly 
inelegant fix

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/JXPathContextReferenceImpl.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/JXPathContextReferenceImpl.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/JXPathContextReferenceImpl.java?view=diffrev=495019r1=495018r2=495019
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/JXPathContextReferenceImpl.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/JXPathContextReferenceImpl.java
 Wed Jan 10 14:44:18 2007
@@ -52,6 +52,7 @@
 import org.apache.commons.jxpath.ri.model.beans.CollectionPointerFactory;
 import org.apache.commons.jxpath.ri.model.container.ContainerPointerFactory;
 import org.apache.commons.jxpath.ri.model.dynamic.DynamicPointerFactory;
+import org.apache.commons.jxpath.util.ReverseComparator;
 import org.apache.commons.jxpath.util.TypeUtils;
 
 /**
@@ -576,10 +577,14 @@
 while (it.hasNext()) {
 list.add(it.next());
 }
-Collections.sort(list);
-for (int i = list.size() - 1; i = 0; i--) {
-NodePointer pointer = (NodePointer) list.get(i);
+Collections.sort(list, ReverseComparator.INSTANCE);
+it = list.iterator();
+if (it.hasNext()) {
+NodePointer pointer = (NodePointer) it.next();
 pointer.remove();
+while (it.hasNext()) {
+removePath(((NodePointer) it.next()).asPath());
+}
 }
 }
 catch (Throwable ex) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495021 - /jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/BeanModelTestCase.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:45:44 2007
New Revision: 495021

URL: http://svn.apache.org/viewvc?view=revrev=495021
Log:
[JXPATH-20] tests

Modified:

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/BeanModelTestCase.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/BeanModelTestCase.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/BeanModelTestCase.java?view=diffrev=495021r1=495020r2=495021
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/BeanModelTestCase.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/BeanModelTestCase.java
 Wed Jan 10 14:45:44 2007
@@ -17,6 +17,7 @@
 package org.apache.commons.jxpath.ri.model;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
@@ -32,6 +33,7 @@
 import org.apache.commons.jxpath.ri.compiler.TestFunctions;
 import org.apache.commons.jxpath.ri.model.beans.PropertyOwnerPointer;
 import org.apache.commons.jxpath.ri.model.beans.PropertyPointer;
+import org.apache.commons.jxpath.ri.model.dynabeans.DynaBeanModelTest;
 
 /**
  * Abstract superclass for Bean access with JXPath.
@@ -915,6 +917,30 @@
 Remove array element,
 String 2,
 context.getValue(nestedBean/strings[1]));
+}
+
+public void testRemoveAllArrayElements() {
+context.removeAll(nestedBean/strings);
+assertXPathValueIterator(
+context,
+nestedBean/strings,
+list());
+}
+
+public void testRemoveAllListElements() {
+context.removeAll(list);
+assertXPathValueIterator(
+context,
+list,
+this instanceof DynaBeanModelTest ? list(null, null, null) : 
list());
+}
+
+public void testRemoveAllMapEntries() {
+context.removeAll(map/*);
+assertXPathValue(
+context,
+map,
+Collections.EMPTY_MAP);
 }
 
 public void testRemovePathBeanValue() {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JXPATH-20) [jxpath] JXPathContext.removeAll() doesn't remove all (just one)

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-20.
---

Resolution: Fixed

fixed in SVN HEAD.  Thanks for the report.

 [jxpath] JXPathContext.removeAll() doesn't remove all (just one)
 

 Key: JXPATH-20
 URL: https://issues.apache.org/jira/browse/JXPATH-20
 Project: Commons JXPath
  Issue Type: Bug
 Environment: Operating System: other
 Platform: Other
Reporter: Giacomo Pati

 JXPathContext.removeAll() doesn't remove all items for a Collection path 
 supplied.
 TestCase to reproduce:
 public void testRemoveAllFromCollection() {
 final Map map = new HashMap();
 final Collection list = new ArrayList();
 for(int i = 0; i  20; i++) {
 list.add( + i);
 }
 map.put( list, list);
 JXPathContext context = JXPathContext.newContext(null, map);
 context.removeAll( list );
 assertEquals(not all items removed, 0, list.size() );
 }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495022 - /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPropertyPointer.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:48:00 2007
New Revision: 495022

URL: http://svn.apache.org/viewvc?view=revrev=495022
Log:
avoid setting value if it is unchanged

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPropertyPointer.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPropertyPointer.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPropertyPointer.java?view=diffrev=495022r1=495021r2=495022
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPropertyPointer.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPropertyPointer.java
 Wed Jan 10 14:48:00 2007
@@ -237,8 +237,11 @@
 setValue(null);
 }
 else if (isCollection()) {
+Object o = getBaseValue();
 Object collection = ValueUtils.remove(getBaseValue(), index);
-ValueUtils.setValue(getBean(), getPropertyDescriptor(), 
collection);
+if (collection != o) {
+ValueUtils.setValue(getBean(), getPropertyDescriptor(), 
collection);
+}
 }
 else if (index == 0) {
 index = WHOLE_COLLECTION;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495023 - /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/MethodLookupUtils.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:49:09 2007
New Revision: 495023

URL: http://svn.apache.org/viewvc?view=revrev=495023
Log:
formatting  remove unused private constant

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/MethodLookupUtils.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/MethodLookupUtils.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/MethodLookupUtils.java?view=diffrev=495023r1=495022r2=495023
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/MethodLookupUtils.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/MethodLookupUtils.java
 Wed Jan 10 14:49:09 2007
@@ -36,12 +36,11 @@
 private static final int NO_MATCH = 0;
 private static final int APPROXIMATE_MATCH = 1;
 private static final int EXACT_MATCH = 2;
-private static final Object[] EMPTY_ARRAY = new Object[0];
 
- public static Constructor lookupConstructor(
+public static Constructor lookupConstructor(
 Class targetClass,
-Object[] parameters) 
- {
+Object[] parameters)  
+{
 boolean tryExact = true;
 int count = parameters == null ? 0 : parameters.length;
 Class types[] = new Class[count];



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495024 - /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ValueUtils.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:50:38 2007
New Revision: 495024

URL: http://svn.apache.org/viewvc?view=revrev=495024
Log:
[JXPATH-73] catch IndexOutOfBoundsException instead of subclass ArrayIOOBE

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ValueUtils.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ValueUtils.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ValueUtils.java?view=diffrev=495024r1=495023r2=495024
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ValueUtils.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ValueUtils.java
 Wed Jan 10 14:50:38 2007
@@ -421,7 +421,7 @@
 catch (InvocationTargetException ex) {
 Throwable t =
 ((InvocationTargetException) ex).getTargetException();
-if (t instanceof ArrayIndexOutOfBoundsException) {
+if (t instanceof IndexOutOfBoundsException) {
 return null;
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JXPATH-73) ValueUtils should catch IndexOutOfBoundsException instead of ArrayIndexOutOfBoundsException (for XmlBeans support)

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-73.
---

Resolution: Fixed

applied to SVN HEAD.  Thanks for the report.

 ValueUtils should catch IndexOutOfBoundsException instead of 
 ArrayIndexOutOfBoundsException (for XmlBeans support)
 --

 Key: JXPATH-73
 URL: https://issues.apache.org/jira/browse/JXPATH-73
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: 1.2 Final
 Environment: XmlBeans with JDK 1.4.2 and JXpath 1.2
Reporter: James Schopp
 Fix For: 1.3

 Attachments: jxpath-73.patch.txt


 Basically, I want to do createPathAndSetValue on an XmlBean . But, my xpath 
 statement inlcudes a collection (an array, actually), so the missing elements 
 in the array need to be created.
 JXPath checks for this condition (ie. that array elements are missing and 
 need to be created) by catching an ArrayIndexOutOfBoundsException.
 Unfortunately, XmlBeans does not throw that type of exception. It throws an 
 IndexOutOfBoundsException exception instead. So, instead of detecting that 
 the array is too small and needs to be grown (by calling my AbstractFactory), 
 it just propogates the exception up the chain.
 The fix is quite simple: on line 423 of ValueUtils, just change the catch 
 clause to catch a IndexOutOfBoundsException instead. This should not break 
 any existing code since ArrayIndexOutOfBoundsException is actually a subclass 
 of IndexOutOfBoundsException anyway.
 I made this fix to my local source tree, and everything works perfectly (ie. 
 existing code did not break, but now I can also use JXPath on top of my 
 XmlBeans beans too with my own custom AbstractFactory).
 Thanks!
 James

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495025 - in /jakarta/commons/proper/jxpath/trunk/src: java/org/apache/commons/jxpath/ri/model/beans/NullPropertyPointer.java test/org/apache/commons/jxpath/ri/model/beans/BadlyImplemented

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:54:59 2007
New Revision: 495025

URL: http://svn.apache.org/viewvc?view=revrev=495025
Log:
[JXPATH-68] Throw meaningful exception when imminent stack overflow is detected

Added:

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
   (with props)
Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/NullPropertyPointer.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/NullPropertyPointer.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/NullPropertyPointer.java?view=diffrev=495025r1=495024r2=495025
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/NullPropertyPointer.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/NullPropertyPointer.java
 Wed Jan 10 14:54:59 2007
@@ -16,6 +16,8 @@
  */
 package org.apache.commons.jxpath.ri.model.beans;
 
+import org.apache.commons.jxpath.AbstractFactory;
+import org.apache.commons.jxpath.JXPathAbstractFactoryException;
 import org.apache.commons.jxpath.JXPathContext;
 import org.apache.commons.jxpath.JXPathInvalidAccessException;
 import org.apache.commons.jxpath.ri.QName;
@@ -106,12 +108,15 @@
 return newParent.createAttribute(context, getName());
 }
 else {
+if (parent instanceof NullPointer  parent.equals(newParent)) {
+throw createBadFactoryException(context.getFactory());
+}
 // Consider these two use cases:
 // 1. The parent pointer of NullPropertyPointer is 
 //a PropertyOwnerPointer other than NullPointer. When we call 
 //createPath on it, it most likely returns itself. We then
 //take a PropertyPointer from it and get the PropertyPointer
-//to expand the collection for the corresponsing property.
+//to expand the collection for the corresponding property.
 //
 // 2. The parent pointer of NullPropertyPointer is a NullPointer.
 //When we call createPath, it may return a PropertyOwnerPointer
@@ -135,6 +140,9 @@
 return pointer;
 }
 else {
+if (parent instanceof NullPointer  parent.equals(newParent)) {
+throw createBadFactoryException(context.getFactory());
+}
 if (newParent instanceof PropertyOwnerPointer) {
 PropertyOwnerPointer pop = (PropertyOwnerPointer) newParent;
 newParent = pop.getPropertyPointer();
@@ -220,5 +228,11 @@
 index = string.indexOf('\');
 }
 return string;
+}
+
+private JXPathAbstractFactoryException 
createBadFactoryException(AbstractFactory factory) {
+return new JXPathAbstractFactoryException(Factory  + factory
++  reported success creating object for path:  + asPath()
++  but object was null.  Terminating to avoid stack 
recursion.);
 }
 }

Added: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java?view=autorev=495025
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
 (added)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
 Wed Jan 10 14:54:59 2007
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.jxpath.ri.model.beans;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import junit.framework.TestCase;
+
+import 

[jira] Resolved: (JXPATH-68) StackOverflow error on a call to 'JXPathContext.createPath()'

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-68.
---

Resolution: Fixed

The bottom line here is that your AbstractFactory implementation is faulty.  
Per the contract of AbstractFactory.createObject(), when you return true from 
this method you are signifying that you have created a (non-null) value at the 
specified place in the object hierarchy.  The only thing that can be done is to 
install a check to detect the situation and throw a meaningful exception 
informing you of your error.  This change has been made in SVN HEAD for 
commons-jxpath 1.3 .

Regards,
Matt

 StackOverflow error on a call to 'JXPathContext.createPath()'
 -

 Key: JXPATH-68
 URL: https://issues.apache.org/jira/browse/JXPATH-68
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: Nightly Builds, 1.2 Final
 Environment: Windows XP Professional, Sun JDK 1.4.2
 Run with JXPath v1.2 and v20060530
Reporter: Joseph Campolongo
 Fix For: 1.3


 I'm running into a StackOverflow error on a call to
 'JXPathContext.createPath()' whenever I have a path that looks like
 'a/b[1]/c'.  I took a quick look at the code and it appears JXPath, when
 trying to create its parent pointer, simply recreates an equivalent
 pointer(???).
 Here is code to reproduce the problem.
 Map map = new HashMap();
 map.put(a, null);
 
 JXPathContext pathContext = JXPathContext.newContext(map);
 pathContext.setFactory(new AbstractFactory() {
   public boolean createObject(
   JXPathContext context, Pointer pointer, Object parent, String
 name, int index) {
 Map parentMap = (Map)parent;
 System.out.println(parent + : + name + : + index);
 if (index  -1) {
   List list = (List)parentMap.get(name);
   if (list == null) {
 list = new ArrayList();
   }
   int size = list.size();
   for (int i = size; i = index; i++) {
 list.add(i, null);
   }
   parentMap.put(name, list);
 } else {
   parentMap.put(name, new HashMap());
 }
 return true;
   }
   
 });
 pathContext.createPath(a/b[1]/c);
 ***
 I have continued looking into this, and found that the problem is that, if
 the List is created with a 'null' element, JXPath gets stuck in infinite
 recursion.
 To discover this, I changed my Factory to implement the following method:
   public boolean createObject(
   JXPathContext context, Pointer pointer, Object parent, 
   String name, int index) {
 if (pointer instanceof NodePointer) {
   index = ((NodePointer)pointer).getIndex();
 }
 System.out.println(parent + : + name + : + index);
 Map parentMap = (Map)parent;
 if (index  -1) {
   List list = (List)parentMap.get(name);
   if (list == null) {
 list = new ArrayList();
   }
   int size = list.size();
   for (int i = size; i = index; i++) {
 list.add(i, new HashMap());  // !!  Don't set to 'null'
   }
   parentMap.put(name, list);
 } else {
   parentMap.put(name, new HashMap());
 }
 return true;
   }
 Then I ran the following code:
 pathContext.createPath(a/b[1]/c);
 pathContext.createPath(a/b[2]/c);  // STACK OVERFLOW HERE
 Here is the stack trace at the beginning, where
 'ValueUtils.expandCollection()' is called.  It puts 'null' into the list,
 thus causing the stack overflow as we cycle between createPath() 
 createChild().
 Thread [main] (Suspended (breakpoint at line 227 in DynamicPropertyPointer))
   DynamicPropertyPointer.createPath(JXPathContext) line: 227
   DynamicPropertyPointer(PropertyPointer).createChild(JXPathContext,
 QName, int) line: 188
   NullElementPointer.createPath(JXPathContext) line: 82
   NullPointer.createPath(JXPathContext) line: 86
   NullPropertyPointer.createPath(JXPathContext) line: 103
   NullPointer.createPath(JXPathContext) line: 86
   NullPropertyPointer.createPath(JXPathContext) line: 103
   JXPathContextReferenceImpl.createPath(String, Expression) line: 447
   JXPathContextReferenceImpl.createPath(String) line: 427
   Test.test4() line: 75
   Test.main(String[]) line: 38

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, 

svn commit: r495016 - in /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath: ri/EvalContext.java util/ReverseComparator.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 14:41:48 2007
New Revision: 495016

URL: http://svn.apache.org/viewvc?view=revrev=495016
Log:
extract ReverseComparator to its own class

Added:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
   (with props)
Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java?view=diffrev=495016r1=495015r2=495016
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java
 Wed Jan 10 14:41:48 2007
@@ -32,6 +32,7 @@
 import org.apache.commons.jxpath.Pointer;
 import org.apache.commons.jxpath.ri.axes.RootContext;
 import org.apache.commons.jxpath.ri.model.NodePointer;
+import org.apache.commons.jxpath.util.ReverseComparator;
 
 /**
  * An XPath evaluation context.
@@ -52,14 +53,6 @@
 private boolean hasPerformedIteratorStep = false;
 private Iterator pointerIterator;
 
-// Sorts in the reverse order to the one defined by the Comparable
-// interface.
-private static final Comparator REVERSE_COMPARATOR = new Comparator() {
-public int compare(Object o1, Object o2) {
-return ((Comparable) o2).compareTo(o1);
-}
-};
-
 public EvalContext(EvalContext parentContext) {
 this.parentContext = parentContext;
 }
@@ -196,7 +189,7 @@
 Collections.sort(list);
 }
 else {
-Collections.sort(list, REVERSE_COMPARATOR);
+Collections.sort(list, ReverseComparator.INSTANCE);
 }
 pointerIterator = list.iterator();
 return true;

Added: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java?view=autorev=495016
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
 (added)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
 Wed Jan 10 14:41:48 2007
@@ -0,0 +1,27 @@
+package org.apache.commons.jxpath.util;
+
+import java.util.Comparator;
+
+/**
+ * Reverse comparator.
+ *
+ * @author Dmitri Plotnikov
+ * @version $Revision:$ $Date:$
+ */
+public class ReverseComparator implements Comparator {
+/**
+ * Singleton reverse comparator instance.
+ */
+public static final Comparator INSTANCE = new ReverseComparator();
+
+private ReverseComparator() {
+}
+
+/**
+ * [EMAIL PROTECTED]
+ */
+public int compare(Object o1, Object o2) {
+return ((Comparable) o2).compareTo(o1);
+}
+
+}

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
--
svn:eol-style = native

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
--
svn:executable = *



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



UUID exception

2007-01-10 Thread Pradeep Arumalla

Hi all,
 below is what I am trying to do and see if it generates a unique
Id everytime I  run in a loop, and  I get this exception.I know there should
be a file  with java -d option  *
org.apache.commons.id.uuid.config.resource.filename ,* but what should the
file contain.Please help, if any body has done this before.


UUID ns = UUID.fromString(6ba7b810-9dad-11d1-80b4-00c04fd430c8);
System.out.println(*** +ns.timeUUID());



java.lang.RuntimeException: java.lang.IllegalStateException: No value set
for system property: org.apache.commons.id.uuid.config.resource.filename
at org.apache.commons.id.uuid.NodeManagerImpl.init(NodeManagerImpl.java:64)
at org.apache.commons.id.uuid.NodeManagerImpl.currentNode(
NodeManagerImpl.java:96)
at org.apache.commons.id.uuid.VersionOneGenerator.nextUUID(
VersionOneGenerator.java:99)
at org.apache.commons.id.uuid.UUID.timeUUID(UUID.java:417)
at org.apache.commons.id.uuid.UUIDTest.testNameUUIDFromStringSha1(
UUIDTest.java:313)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(
RemoteTestRunner.java:478)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(
RemoteTestRunner.java:344)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(
RemoteTestRunner.java:196)
Caused by: java.lang.IllegalStateException: No value set for system
property: org.apache.commons.id.uuid.config.resource.filename
at org.apache.commons.id.uuid.state.ReadOnlyResourceStateImpl.load(
ReadOnlyResourceStateImpl.java:100)
at org.apache.commons.id.uuid.NodeManagerImpl.init(NodeManagerImpl.java:62)
... 17 more


svn commit: r495029 - /jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 15:10:56 2007
New Revision: 495029

URL: http://svn.apache.org/viewvc?view=revrev=495029
Log:
fix keywords.  :|

Modified:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
   (contents, props changed)

Modified: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java?view=diffrev=495029r1=495028r2=495029
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
 Wed Jan 10 15:10:56 2007
@@ -6,7 +6,7 @@
  * Reverse comparator.
  *
  * @author Dmitri Plotnikov
- * @version $Revision:$ $Date:$
+ * @version $Revision$ $Date$
  */
 public class ReverseComparator implements Comparator {
 /**

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
--
svn:keywords = Date Author Id Revision HeadURL



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495030 - /jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 15:12:14 2007
New Revision: 495030

URL: http://svn.apache.org/viewvc?view=revrev=495030
Log:
fix keywords

Modified:

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
   (contents, props changed)

Modified: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java?view=diffrev=495030r1=495029r2=495030
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
 Wed Jan 10 15:12:14 2007
@@ -31,7 +31,7 @@
  * Badly-implemented Factory test.  From JIRA JXPATH-68.
  *
  * @author Matt Benson
- * @version $Revision:$ $Date:$
+ * @version $Revision$ $Date$
  */
 public class BadlyImplementedFactoryTest extends TestCase {
 

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java
--
svn:keywords = Date Author Id Revision HeadURL



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495033 - in /jakarta/commons/proper/jxpath/trunk/src: java/org/apache/commons/jxpath/util/ test/org/apache/commons/jxpath/ri/compiler/

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 15:15:33 2007
New Revision: 495033

URL: http://svn.apache.org/viewvc?view=revrev=495033
Log:
[JXPATH-10] Provide 1.1 backward-compatibility workaround with 1.3

Added:

jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
   (with props)
Modified:

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java

jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/TestFunctions.java

Added: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java?view=autorev=495033
==
--- 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
 (added)
+++ 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
 Wed Jan 10 15:15:33 2007
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.jxpath.util;
+
+import org.apache.commons.jxpath.NodeSet;
+
+/**
+ * TypeConverter implementation to circumvent automagic NodeSet decoding. 
Suggested by JIRA issue JXPATH-10.
+ *
+ * @since JXPath 1.3
+ * @author Matt Benson
+ * @version $Revision$ $Date$
+ */
+public class JXPath11CompatibleTypeConverter extends BasicTypeConverter {
+/**
+ * [EMAIL PROTECTED]
+ */
+public boolean canConvert(Object object, Class toType) {
+return object instanceof NodeSet ? toType.isInstance(object) : 
super.canConvert(object, toType);
+}
+
+/**
+ * [EMAIL PROTECTED]
+ */
+public Object convert(Object object, Class toType) {
+return object instanceof NodeSet  toType.isInstance(object) ? object 
: super.convert(object, toType);
+}
+}

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
--
svn:eol-style = native

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
--
svn:executable = *

Propchange: 
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java
--
svn:keywords = Date Author Id Revision HeadURL

Modified: 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java?view=diffrev=495033r1=495032r2=495033
==
--- 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java
 (original)
+++ 
jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java
 Wed Jan 10 15:15:33 2007
@@ -30,11 +30,15 @@
 import org.apache.commons.jxpath.Functions;
 import org.apache.commons.jxpath.JXPathContext;
 import org.apache.commons.jxpath.JXPathTestCase;
+import org.apache.commons.jxpath.NodeSet;
 import org.apache.commons.jxpath.PackageFunctions;
 import org.apache.commons.jxpath.Pointer;
 import org.apache.commons.jxpath.TestBean;
 import org.apache.commons.jxpath.Variables;
 import org.apache.commons.jxpath.ri.model.NodePointer;
+import org.apache.commons.jxpath.util.JXPath11CompatibleTypeConverter;
+import org.apache.commons.jxpath.util.TypeConverter;
+import org.apache.commons.jxpath.util.TypeUtils;
 
 /**
  * Test extension functions.
@@ -47,6 +51,7 @@
 private Functions functions;
 private JXPathContext context;
 private TestBean 

[jira] Resolved: (JXPATH-10) [jxpath] JXPath 1.1 code using custom functions failing when run in 1.2 onwards

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-10.
---

Resolution: Fixed

Hi Paul, I have committed to SVN HEAD a TypeConverter implementation that 
bypasses the Pointer conversions introduced in version 1.2 .  In order to use 
it, you must first execute the following:

TypeUtils.setTypeConverter(new JXPath11CompatibleTypeConverter());

And I think that's the best I'll be able to do for you.

 [jxpath] JXPath 1.1 code using custom functions failing when run in 1.2 
 onwards
 ---

 Key: JXPATH-10
 URL: https://issues.apache.org/jira/browse/JXPATH-10
 Project: Commons JXPath
  Issue Type: Bug
Affects Versions: 1.2 Final
 Environment: Operating System: other
 Platform: PC
Reporter: Paul Parisi
Priority: Blocker
 Fix For: 1.3


 We have recently attempted to upgrade from a 1.1 release of jxpath
 to 1.2 and found a great deal of our jxpath code fails to run correctly. 
 We isolated the problem to relating to the use of Custom Extension
 Functions and have included sample junit test case snippets that should 
 demonstrate the issue clearly. 
 The background on what we are trying to do with jxpath is as follows
 (included so its clear on what we are trying to use jxpath to achieve):
 Within our project, we make extensive use of Custom Extension Functions in 
 JXPath.  
 We also use JXPath variables significantly, in combination with these 
 functions, 
 that often take a JXPath variable as an argument(s) to the function.
 We now rely heavily on the use of the ExpressionContext interface as the 
 first 
 argument to many of our functions.  The reason for this is that we need a
 convienient way to obtain access to 'original' object references within the
 context invoked by the function (as you would expect).
 However, we have also begun using a very useful combination of features, which
 the API supports in version 1.1, where the first argument always defines the
 ExpressionContext interface (which isn't really part of the method signature -
 from a caller perspective), and a 2nd argument as 'Object' type. Within body 
 of
 the function, we then cast the object of the 2nd argument as a NodeSet (or
 define the NodeSet type within the method signature - either appears to work),
 which provides us with access to the pointers for the object. 
 As previously mentioned, a jxpath variable is passed from the caller of the
 function (received via the 2nd argument in the method signature), which is
 automatically resolved, by jxpath, to the object itself.
 The benefit of casting the object to NodeSet (interface) enables us to 
 retrieve
 the first pointer in the NodeSet list. The first pointer concerns us, as it
 refers to the String value passed to the argument of the function which we 
 need
 access to.  The object reference itself is of little concern in this case, as
 once we have access to the variable name sent to the function, we can access 
 the
 object via the ExpressionContext.
 This all works fine in jxpath 1.1, however, in version 1.2 this functionality 
 is
 now broken, since our objects are no longer being cast to NodeSet (previously
 achieved via the internal implementation of jxpath NodeSet using a 
 SimpleNodeSet
 - as per inspecting jxpath 1.1 source code).
 Note on the use of ExpressionContext: For those methods that declare the
 ExpressionContext interface (which must be the first argument, if used), as 
 part
 of the argument list, the method signature from the caller perspective, 
 excludes
 it from the argument list, as it is implied by jxpath.  In other words, there
 will be one less argument from the caller when the interface is used.  In the
 case where this interface was the only argument, which is common, then the
 caller would be invoking a zero-argument method.  This is behaviour we expect.
 Here is a simplified example of one of our functions using the techniques
 discussed:-
 public static void deleteSomeObject(ExpressionContext expContext, Object obj) 
 {
  // create a local jxpath context to retrieve values for jxpath variables
  JXPathContext localContext = expContext.getJXPathContext();
  // Nodeset of the object passed to method
  NodeSet nodeset = (NodeSet)obj;
  // Retrieve variable name passed to function
  String declaredVariable = nodeset.getPointers().get(0).toString();
  Object objectToDelete = null;
 // If this method was passed the $obj1 var to delete, then retrieve 'Object 
 Type
 1' via $obj1 variable 
if (declaredVariable.equals($obj1)) {
   objectToDelete = (ObjectType1)localContext.getValue($obj1);
   }
   // If this method was passed the $obj2 var to delete, then retrieve 
 'Object
 Type 2' via $obj2 variable 
   if 

svn commit: r495035 - /jakarta/commons/proper/jxpath/trunk/build.xml

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 15:21:34 2007
New Revision: 495035

URL: http://svn.apache.org/viewvc?view=revrev=495035
Log:
add junitreport ; remove Ant dependencies that AFAICT are really needed,
and cause conflicts with Ant.

Modified:
jakarta/commons/proper/jxpath/trunk/build.xml

Modified: jakarta/commons/proper/jxpath/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/build.xml?view=diffrev=495035r1=495034r2=495035
==
--- jakarta/commons/proper/jxpath/trunk/build.xml (original)
+++ jakarta/commons/proper/jxpath/trunk/build.xml Wed Jan 10 15:21:34 2007
@@ -76,6 +76,13 @@
 fail message=There were test failures.
 /fail
   /target
+  target name=test-reports description=junitreport
+mkdir dir=${testreportdir}/html /
+junitreport todir=${testreportdir}/html
+  fileset dir=${testreportdir} includes=TEST-*.xml /
+  report format=frames todir=${testreportdir}/html /
+/junitreport
+  /target
   target name=internal-test depends=compile-tests
 mkdir dir=${testreportdir}
 /mkdir
@@ -157,8 +164,6 @@
 /get
 get dest=${libdir}/junit-3.8.jar usetimestamp=true 
ignoreerrors=true src=http://www.ibiblio.org/maven/junit/jars/junit-3.8.jar;
 /get
-get dest=${libdir}/ant-optional-1.5.1.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/ant/jars/ant-optional-1.5.1.jar;
-/get
 get dest=${libdir}/xml-apis-2.0.2.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/xml-apis/jars/xml-apis-2.0.2.jar;
 /get
 get dest=${libdir}/jdom-1.0.jar usetimestamp=true ignoreerrors=true 
src=http://www.ibiblio.org/maven/jdom/jars/jdom-1.0.jar;
@@ -171,10 +176,6 @@
 /get
 get dest=${libdir}/junit-3.8.1.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/junit/jars/junit-3.8.1.jar;
 /get
-get dest=${libdir}/ant-1.5.jar usetimestamp=true ignoreerrors=true 
src=http://www.ibiblio.org/maven/ant/jars/ant-1.5.jar;
-/get
-get dest=${libdir}/ant-optional-1.5.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/ant/jars/ant-optional-1.5.jar;
-/get
   /target
   target name=install-maven
 get dest=${user.home}/maven-install-latest.jar usetimestamp=true 
src=${repo}/maven/maven-install-latest.jar
@@ -182,4 +183,4 @@
 unjar dest=${maven.home} src=${user.home}/maven-install-latest.jar
 /unjar
   /target
-/project
\ No newline at end of file
+/project



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495036 - in /jakarta/commons/proper/jxpath/trunk: build.xml project.xml

2007-01-10 Thread mbenson
Author: mbenson
Date: Wed Jan 10 15:23:42 2007
New Revision: 495036

URL: http://svn.apache.org/viewvc?view=revrev=495036
Log:
[JXPATH-75] upgrade xerces dependency to 2.4.0

Modified:
jakarta/commons/proper/jxpath/trunk/build.xml
jakarta/commons/proper/jxpath/trunk/project.xml

Modified: jakarta/commons/proper/jxpath/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/build.xml?view=diffrev=495036r1=495035r2=495036
==
--- jakarta/commons/proper/jxpath/trunk/build.xml (original)
+++ jakarta/commons/proper/jxpath/trunk/build.xml Wed Jan 10 15:23:42 2007
@@ -158,7 +158,7 @@
 /javadoc
   /target
   target name=get-deps unless=noget depends=init
-get dest=${libdir}/xerces-1.2.3.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/xerces/jars/xerces-1.2.3.jar;
+get dest=${libdir}/xerces-2.4.0.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/xerces/jars/xerces-2.4.0.jar;
 /get
 get dest=${libdir}/servletapi-2.2.jar usetimestamp=true 
ignoreerrors=true 
src=http://www.ibiblio.org/maven/servletapi/jars/servletapi-2.2.jar;
 /get

Modified: jakarta/commons/proper/jxpath/trunk/project.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/project.xml?view=diffrev=495036r1=495035r2=495036
==
--- jakarta/commons/proper/jxpath/trunk/project.xml (original)
+++ jakarta/commons/proper/jxpath/trunk/project.xml Wed Jan 10 15:23:42 2007
@@ -101,7 +101,7 @@
 dependency
   groupIdxerces/groupId
   artifactIdxerces/artifactId
-  version1.2.3/version
+  version2.4.0/version
 /dependency
 dependency
   groupIdservletapi/groupId



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JXPATH-75) The dependency for xerces in commons-jxpath-1.2.pom is too old

2007-01-10 Thread Matt Benson (JIRA)

 [ 
https://issues.apache.org/jira/browse/JXPATH-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Benson resolved JXPATH-75.
---

Resolution: Fixed

done in SVN HEAD.

 The dependency for xerces in commons-jxpath-1.2.pom is too old
 --

 Key: JXPATH-75
 URL: https://issues.apache.org/jira/browse/JXPATH-75
 Project: Commons JXPath
  Issue Type: Improvement
Affects Versions: 1.2 Final
 Environment: java version 1.5.0_04
 maven2
 commons-configuration-1.3
 commons-jxpath-1.2
 spring-context-2.0.1
Reporter: Dmitry Katsubo
Priority: Minor
 Fix For: 1.3


 The following dependency in commons-jxpath-1.2.pom (see 
 http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-jxpath/commons-jxpath/1.2/commons-jxpath-1.2.pom)
  is out-of-date:
 dependency
   groupIdxerces/groupId
   artifactIdxerces/artifactId
   version1.2.3/version
 /dependency
 The side effect from this dependency is, that some component, that implicitly 
 uses xerces, may fail with this old xerces version. For example, I am using 
 commons-configuration with spring framework which assumes, that XML parser is 
 able to make XSD verification of configuration files, but xerces-1.2.3 is not 
 able to do this.
 Solutions are:
 a) remove all dependencies from commons-jxpath.pom, related with xerces (I 
 hope, most of the community uses at least java1.5, or one may include 
 dependency on xerces in his .pom, as in (c) )
 b) update version of xerces in commons-jxpath.pom up to 2.4.0
 c) include dependency in your .pom, that overrides version of xerces

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r495069 - /jakarta/commons/proper/io/trunk/project.xml

2007-01-10 Thread bayard
Author: bayard
Date: Wed Jan 10 16:48:36 2007
New Revision: 495069

URL: http://svn.apache.org/viewvc?view=revrev=495069
Log:
Commenting out Cobertura for the release - it's a GPL plugin

Modified:
jakarta/commons/proper/io/trunk/project.xml

Modified: jakarta/commons/proper/io/trunk/project.xml
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/project.xml?view=diffrev=495069r1=495068r2=495069
==
--- jakarta/commons/proper/io/trunk/project.xml (original)
+++ jakarta/commons/proper/io/trunk/project.xml Wed Jan 10 16:48:36 2007
@@ -246,6 +246,7 @@
/comment
   /properties
 /dependency
+!--
 dependency
   groupIdmaven-plugins/groupId
   artifactIdmaven-cobertura-plugin/artifactId
@@ -259,6 +260,7 @@
/comment
   /properties
 /dependency
+--
   /dependencies
 
   build
@@ -300,7 +302,7 @@
 reportmaven-junit-report-plugin/report
 reportmaven-jxr-plugin/report
 reportmaven-license-plugin/report
-reportmaven-cobertura-plugin/report
+!--reportmaven-cobertura-plugin/report--
 reportmaven-pmd-plugin/report
 !-- reportmaven-jdiff-plugin/report --
   /reports



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: UUID exception

2007-01-10 Thread Phil Steitz

Have a look at the documentation here:
http://jakarta.apache.org/commons/sandbox/id/uuid.html

The test cases in the src/test directory might also be useful.

Phil

On 1/10/07, Pradeep Arumalla [EMAIL PROTECTED] wrote:


Hi all,
  below is what I am trying to do and see if it generates a unique
Id everytime I  run in a loop, and  I get this exception.I know there
should
be a file  with java -d option  *
org.apache.commons.id.uuid.config.resource.filename ,* but what should
the
file contain.Please help, if any body has done this before.


UUID ns = UUID.fromString(6ba7b810-9dad-11d1-80b4-00c04fd430c8);
System.out.println(*** +ns.timeUUID());



java.lang.RuntimeException: java.lang.IllegalStateException: No value set
for system property: org.apache.commons.id.uuid.config.resource.filename
at org.apache.commons.id.uuid.NodeManagerImpl.init(NodeManagerImpl.java
:64)
at org.apache.commons.id.uuid.NodeManagerImpl.currentNode(
NodeManagerImpl.java:96)
at org.apache.commons.id.uuid.VersionOneGenerator.nextUUID(
VersionOneGenerator.java:99)
at org.apache.commons.id.uuid.UUID.timeUUID(UUID.java:417)
at org.apache.commons.id.uuid.UUIDTest.testNameUUIDFromStringSha1(
UUIDTest.java:313)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(
RemoteTestRunner.java:478)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(
RemoteTestRunner.java:344)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(
RemoteTestRunner.java:196)
Caused by: java.lang.IllegalStateException: No value set for system
property: org.apache.commons.id.uuid.config.resource.filename
at org.apache.commons.id.uuid.state.ReadOnlyResourceStateImpl.load(
ReadOnlyResourceStateImpl.java:100)
at org.apache.commons.id.uuid.NodeManagerImpl.init(NodeManagerImpl.java
:62)
... 17 more




[jira] Commented: (VFS-105) Make it possible to generate VFS sandbox jar with Ant

2007-01-10 Thread Gilles Scokart (JIRA)

[ 
https://issues.apache.org/jira/browse/VFS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463832
 ] 

Gilles Scokart commented on VFS-105:


Actually, the real need is to have vfs sandbox in gump in order to have the ivy 
project build in gump as well.  That's why I vote.

 Make it possible to generate VFS sandbox jar with Ant
 -

 Key: VFS-105
 URL: https://issues.apache.org/jira/browse/VFS-105
 Project: Commons VFS
  Issue Type: Improvement
Reporter: Maarten Coene

 I use the VFS-sandbox.jar in my project.
 Unfortunately, gump cannot build my project at the moment because the 
 VFS-sandbox.jar isn't available in gump since gump doesn't support M2.
 If this sandbox jar could be built via Ant, it could be made available in 
 gump.
 Maarten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]