[jira] Created: (JELLY-278) Missing link to SVN repository (not WebSVN)
Missing link to SVN repository (not WebSVN) --- Key: JELLY-278 URL: https://issues.apache.org/jira/browse/JELLY-278 Project: Commons Jelly Issue Type: Wish Reporter: Stepan Koltsov On the page http://jakarta.apache.org/commons/jelly/cvs-usage.html there iis only link to websvn, and I don't know where can I download sources from. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-66) [lang] StringEscaper.escapeXml() escapes characters 0x7f
[ http://issues.apache.org/jira/browse/LANG-66?page=comments#action_12455221 ] Stepan Koltsov commented on LANG-66: escapeJava and escapeJavaScript also escapes characters 0x7f. This is also undesired and undocumented. [lang] StringEscaper.escapeXml() escapes characters 0x7f -- Key: LANG-66 URL: http://issues.apache.org/jira/browse/LANG-66 Project: Commons Lang Issue Type: Bug Affects Versions: 2.1 Environment: Operating System: All Platform: All Reporter: Sandor Vroemisse Fix For: 3.0 StringEscaper.escapeXml() escapes characters 0x7f. That's both undesired and undocumented. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (COLLECTIONS-234) Please provide nightly builds of collections_jdk5_branch
Please provide nightly builds of collections_jdk5_branch Key: COLLECTIONS-234 URL: http://issues.apache.org/jira/browse/COLLECTIONS-234 Project: Commons Collections Issue Type: Wish Affects Versions: Generics Reporter: Stepan Koltsov Please provide nightly builds of collections_jdk5_branch. I'd like to use generified commons-collections right now, and not wait until it will be released. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LANG-292) unescapeXml(12345678;) should be 12345678;
unescapeXml(12345678;) should be 12345678;
Key: LANG-292
URL: http://issues.apache.org/jira/browse/LANG-292
Project: Commons Lang
Issue Type: Bug
Affects Versions: Nightly Builds
Reporter: Stepan Koltsov
Priority: Minor
Following test (in EntitiesTest.java) fails:
public void testNumberOverflow() throws Exception {
doTestUnescapeEntity(#12345678;, #12345678;);
doTestUnescapeEntity(x#12345678;y, x#12345678;y);
doTestUnescapeEntity(#x12345678;, #x12345678;);
doTestUnescapeEntity(x#x12345678;y, x#x12345678;y);
}
Maximim value for char is 0x, so #12345678; is invalid entity reference,
and so should be left as is.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LANG-293) StringEscapeUtils.unescape* can be faster
StringEscapeUtils.unescape* can be faster - Key: LANG-293 URL: http://issues.apache.org/jira/browse/LANG-293 Project: Commons Lang Issue Type: Improvement Affects Versions: Nightly Builds Reporter: Stepan Koltsov Typical string that need to be unescaped contains almost no XML entities, so copying input string to output buffer char by char is slow. I've refactored Entities.unescape() so it works faster. Going to submitting patch and tests. Patch contains both hacked and original versions of unescape, to run tests. Test shows that performance remains same on short strings, and much better or large strings with rare entities. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-293) StringEscapeUtils.unescape* can be faster
[ http://issues.apache.org/jira/browse/LANG-293?page=all ] Stepan Koltsov updated LANG-293: Attachment: commons-lang-unescape-performace2-stepancheg-2006-10-31.diff StringEscapeUtils.unescape* can be faster - Key: LANG-293 URL: http://issues.apache.org/jira/browse/LANG-293 Project: Commons Lang Issue Type: Improvement Affects Versions: Nightly Builds Reporter: Stepan Koltsov Attachments: commons-lang-unescape-performace2-stepancheg-2006-10-31.diff Typical string that need to be unescaped contains almost no XML entities, so copying input string to output buffer char by char is slow. I've refactored Entities.unescape() so it works faster. Going to submitting patch and tests. Patch contains both hacked and original versions of unescape, to run tests. Test shows that performance remains same on short strings, and much better or large strings with rare entities. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-293) StringEscapeUtils.unescape* can be faster
[ http://issues.apache.org/jira/browse/LANG-293?page=all ] Stepan Koltsov updated LANG-293: Attachment: EntitiesPerformance2TestSecret.java StringEscapeUtils.unescape* can be faster - Key: LANG-293 URL: http://issues.apache.org/jira/browse/LANG-293 Project: Commons Lang Issue Type: Improvement Affects Versions: Nightly Builds Reporter: Stepan Koltsov Attachments: commons-lang-unescape-performace2-stepancheg-2006-10-31.diff, EntitiesPerformance2TestSecret.java Typical string that need to be unescaped contains almost no XML entities, so copying input string to output buffer char by char is slow. I've refactored Entities.unescape() so it works faster. Going to submitting patch and tests. Patch contains both hacked and original versions of unescape, to run tests. Test shows that performance remains same on short strings, and much better or large strings with rare entities. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (COLLECTIONS-8) Comparator Predicate
[
http://issues.apache.org/jira/browse/COLLECTIONS-8?page=comments#action_12445781
]
Stepan Koltsov commented on COLLECTIONS-8:
--
I think, that such predicate should have only three criterions: 1, 0, -1, for
greater, equals and less. GE and LE can be constructed as not(less),
not(greater). PredicateUtils should have methods:
Predicate greaterPredicate(Object) { ... }
Predicate lessPredicate(Object) { ... }
Predicate greaterOrEqualsPredicate(Object) { return
notPredicate(lessPredicate(object)); }
Predicate lessOrEqualsPredicate(Object) { return
notPredicate(greaterPredicate(object)); }
equality through comparator is not often needed, so need not to be exposed to
PredicateUtils.
Comparator Predicate
Key: COLLECTIONS-8
URL: http://issues.apache.org/jira/browse/COLLECTIONS-8
Project: Commons Collections
Issue Type: New Feature
Components: Functor
Affects Versions: 3.1
Environment: Operating System: other
Platform: Other
Reporter: Rune Peter Bjørnstad
Priority: Minor
Fix For: 3.3
Attachments: ComparatorPredicate.diff, ComparatorPredicate.java
A predicate that makes use of a Comparator object for evaluation is, in my
opinion, missing in the functors package.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (COLLECTIONS-230) CollectionUtils.size(null) should return 0
CollectionUtils.size(null) should return 0 -- Key: COLLECTIONS-230 URL: http://issues.apache.org/jira/browse/COLLECTIONS-230 Project: Commons Collections Issue Type: Wish Affects Versions: 3.2 Reporter: Stepan Koltsov Hello, CollectionUtils.size(null) currently throws IllegalArgumentException(Unsupported object type: null). I think CollectionUtils.size(null) should return 0. Why? The aim of library is to minimize the amount of code that uses this library. In my experience, in the most cases null collections can be threated as as zero-length. Current behavior causes the need of many trivial null-checks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-287) Optimize StringEscapeUtils.unescapeXml(String)
[ http://issues.apache.org/jira/browse/LANG-287?page=all ]
Stepan Koltsov updated LANG-287:
Attachment: commons-lang-unescape-performace-stepancheg-2006-10-24.diff
This is a patch, that optimizes unescape* as Holger suggested.
Optimize StringEscapeUtils.unescapeXml(String)
--
Key: LANG-287
URL: http://issues.apache.org/jira/browse/LANG-287
Project: Commons Lang
Issue Type: Improvement
Affects Versions: 2.2
Reporter: Stepan Koltsov
Priority: Minor
Attachments:
commons-lang-unescape-performace-stepancheg-2006-10-24.diff
StringEscapeUtils.unescapeXml(String) (and other unescaes) works too slowly
if String has nothing to unescape, that is very common situation.
To make unescape faster, following check should be added to be start of
Entities.unescape(str)
if (str.indexOf('') 0)
return str;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LANG-287) Optimize StringEscapeUtils.unescapeXml(String)
Optimize StringEscapeUtils.unescapeXml(String)
--
Key: LANG-287
URL: http://issues.apache.org/jira/browse/LANG-287
Project: Commons Lang
Issue Type: Improvement
Affects Versions: 2.2
Reporter: Stepan Koltsov
Priority: Minor
StringEscapeUtils.unescapeXml(String) (and other unescaes) works too slowly if
String has nothing to unescape, that is very common situation.
To make unescape faster, following check should be added to be start of
Entities.unescape(str)
if (str.indexOf('') 0)
return str;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-266) Wish for StringUtils.join(Collection, *)
[
http://issues.apache.org/jira/browse/LANG-266?page=comments#action_12436050 ]
Stepan Koltsov commented on LANG-266:
-
Thank you for adding method.
There are typos in the last commit:
Index: src/java/org/apache/commons/lang/StringUtils.java
===
--- src/java/org/apache/commons/lang/StringUtils.java (revision 448007)
+++ src/java/org/apache/commons/lang/StringUtils.java (working copy)
@@ -2692,7 +2692,7 @@
*
* @param collection the codeCollection/code of values to join
together, may be null
* @param separator the separator character to use
- * @return the joined String, codenull/code if null iterator input
+ * @return the joined String, codenull/code if null collection input
* @since 2.3
*/
public static String join(Collection collection, char separator) {
@@ -2713,7 +2713,7 @@
*
* @param collection the codeCollection/code of values to join
together, may be null
* @param separator the separator character to use, null treated as
- * @return the joined String, codenull/code if null iterator input
+ * @return the joined String, codenull/code if null collection input
* @since 2.3
*/
public static String join(Collection collection, String separator) {
Wish for StringUtils.join(Collection, *)
Key: LANG-266
URL: http://issues.apache.org/jira/browse/LANG-266
Project: Commons Lang
Issue Type: Wish
Affects Versions: Nightly Builds
Reporter: Stepan Koltsov
Priority: Trivial
Fix For: 2.3
Attachments: commons-lang-join-collection-stepancheg.diff
There is a lack of StringUtils.join(Collection, String) method in
commons-lang. Could you please add it?
Commons-lang has method join(Iterator, String), however join(Collection,
String) is still useful. Join is used very often, and in most situations it
is used with Collection, not with Iterator, because almost all methods return
Collections, not Iterators and a lot of data is stored as Collections, not as
Iterators. The string .iterator() has 11 characters while line for code is
only 72 chars. I've found that in my code there are several methods that
could be one line shorter if it was StringUtils.join(Collection, String).
Compare:
// with StringUtils.join(Collection, String)
return UNIQUE ( + StringUtils.join(unique.getColumnNames(), , ) + );
against:
// without
Iterator columnNames = unique.getColumnNames().iterator();
return UNIQUE ( + StringUtils.join(columnNames, , ) + );
Motivation is almost same as Why we have StringUtils.join(Object[], String)
while we could write StringUtils.join(Arrays.asList(array).iterator(),
separator)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LANG-265) [patch] Cannot build tests from latest SVN
[patch] Cannot build tests from latest SVN -- Key: LANG-265 URL: http://issues.apache.org/jira/browse/LANG-265 Project: Commons Lang Type: Bug Reporter: Stepan Koltsov Priority: Trivial Invoking ant test results in error message: === [javac] /Users/yozh/devel/left/commons-lang/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java:969: reference to reflectionEquals is ambiguous, both method reflectionEquals(java.lang.Object,java.lang.Object,java.util.Collection) in org.apache.commons.lang.builder.EqualsBuilder and method reflectionEquals(java.lang.Object,java.lang.Object,java.lang.String[]) in org.apache.commons.lang.builder.EqualsBuilder match [javac] assertTrue(!EqualsBuilder.reflectionEquals(x1, x2, null)); [javac] ^ [javac] /Users/yozh/devel/left/commons-lang/src/test/org/apache/commons/lang/builder/HashCodeBuilderTest.java:445: reference to reflectionHashCode is ambiguous, both method reflectionHashCode(java.lang.Object,java.util.Collection) in org.apache.commons.lang.builder.HashCodeBuilder and method reflectionHashCode(java.lang.Object,java.lang.String[]) in org.apache.commons.lang.builder.HashCodeBuilder match [javac] assertEquals17 * 37 + 1) * 37 + 2) * 37 + 3), HashCodeBuilder.reflectionHashCode(x, null)); === -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-265) [patch] Cannot build tests from latest SVN
[ http://issues.apache.org/jira/browse/LANG-265?page=all ] Stepan Koltsov updated LANG-265: Attachment: commons-lang-ambiguous-reference-stepancheg.diff The patch. [patch] Cannot build tests from latest SVN -- Key: LANG-265 URL: http://issues.apache.org/jira/browse/LANG-265 Project: Commons Lang Type: Bug Reporter: Stepan Koltsov Priority: Trivial Attachments: commons-lang-ambiguous-reference-stepancheg.diff Invoking ant test results in error message: === [javac] /Users/yozh/devel/left/commons-lang/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java:969: reference to reflectionEquals is ambiguous, both method reflectionEquals(java.lang.Object,java.lang.Object,java.util.Collection) in org.apache.commons.lang.builder.EqualsBuilder and method reflectionEquals(java.lang.Object,java.lang.Object,java.lang.String[]) in org.apache.commons.lang.builder.EqualsBuilder match [javac] assertTrue(!EqualsBuilder.reflectionEquals(x1, x2, null)); [javac] ^ [javac] /Users/yozh/devel/left/commons-lang/src/test/org/apache/commons/lang/builder/HashCodeBuilderTest.java:445: reference to reflectionHashCode is ambiguous, both method reflectionHashCode(java.lang.Object,java.util.Collection) in org.apache.commons.lang.builder.HashCodeBuilder and method reflectionHashCode(java.lang.Object,java.lang.String[]) in org.apache.commons.lang.builder.HashCodeBuilder match [javac] assertEquals17 * 37 + 1) * 37 + 2) * 37 + 3), HashCodeBuilder.reflectionHashCode(x, null)); === -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LANG-266) Wish for StringUtils.join(Collection, *)
Wish for StringUtils.join(Collection, *) Key: LANG-266 URL: http://issues.apache.org/jira/browse/LANG-266 Project: Commons Lang Type: Wish Versions: Nightly Builds Reporter: Stepan Koltsov Priority: Trivial There is a lack of StringUtils.join(Collection, String) method in commons-lang. Could you please add it? Commons-lang has method join(Iterator, String), however join(Collection, String) is still useful. Join is used very often, and in most situations it is used with Collection, not with Iterator, because almost all methods return Collections, not Iterators and a lot of data is stored as Collections, not as Iterators. The string .iterator() has 11 characters while line for code is only 72 chars. I've found that in my code there are several methods that could be one line shorter if it was StringUtils.join(Collection, String). Compare: // with StringUtils.join(Collection, String) return UNIQUE ( + StringUtils.join(unique.getColumnNames(), , ) + ); against: // without Iterator columnNames = unique.getColumnNames().iterator(); return UNIQUE ( + StringUtils.join(columnNames, , ) + ); Motivation is almost same as Why we have StringUtils.join(Object[], String) while we could write StringUtils.join(Arrays.asList(array).iterator(), separator)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-266) Wish for StringUtils.join(Collection, *)
[ http://issues.apache.org/jira/browse/LANG-266?page=all ] Stepan Koltsov updated LANG-266: Attachment: commons-lang-join-collection-stepancheg.diff The patch. Also hacks join(Iterator, *) to aviod creation of StringBuffer if iterator gives zero or one elements. Wish for StringUtils.join(Collection, *) Key: LANG-266 URL: http://issues.apache.org/jira/browse/LANG-266 Project: Commons Lang Type: Wish Versions: Nightly Builds Reporter: Stepan Koltsov Priority: Trivial Attachments: commons-lang-join-collection-stepancheg.diff There is a lack of StringUtils.join(Collection, String) method in commons-lang. Could you please add it? Commons-lang has method join(Iterator, String), however join(Collection, String) is still useful. Join is used very often, and in most situations it is used with Collection, not with Iterator, because almost all methods return Collections, not Iterators and a lot of data is stored as Collections, not as Iterators. The string .iterator() has 11 characters while line for code is only 72 chars. I've found that in my code there are several methods that could be one line shorter if it was StringUtils.join(Collection, String). Compare: // with StringUtils.join(Collection, String) return UNIQUE ( + StringUtils.join(unique.getColumnNames(), , ) + ); against: // without Iterator columnNames = unique.getColumnNames().iterator(); return UNIQUE ( + StringUtils.join(columnNames, , ) + ); Motivation is almost same as Why we have StringUtils.join(Object[], String) while we could write StringUtils.join(Arrays.asList(array).iterator(), separator)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
