[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[
https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901336#action_12901336
]
Karl Wright commented on CONNECTORS-91:
---
I looked at this. The patch seems correct for some classes, but for others it
is clearly incorrect, e.g. SynchronizeAll:
{
System.err.println("Usage: SynchronizeAll");
System.exit(1);
+ System.err.println("Successfully synchronized all agents");
}
Can you review your change for accuracy please?
Also, responding to the logging change - the log settings are global, and we
are trying for the least amount of setup work necessary to achieve a functional
system. Clearly, all log messages to stderr is not going to be reasonable for
people doing real crawls, so we'd need some way to segregate command output in
order to direct it differently than everything else, which implies at the least
you'd want a different logger, and then you'd also want to revise the
documented log4j properties, if you think we should go that route.
Re: testing. The testing you've done so far is best we can do at the moment,
unless you'd also like to write some unit tests. I don't think this would be
terribly difficult, but once again it would be time consuming. ;-)
> Making the initialization commands more useable
> ---
>
> Key: CONNECTORS-91
> URL: https://issues.apache.org/jira/browse/CONNECTORS-91
> Project: Apache Connectors Framework
> Issue Type: Improvement
> Components: Framework core
>Reporter: Jettro Coenradie
> Fix For: LCF Release 0.5
>
> Attachments: change_commands.patch,
> change_commands_with_system_err_println.patch
>
>
> At the moment LCF comes with some classes that can be used to run command
> line to interact with the system. Examples are DBCreate, DBDrop and
> LockClean. I wanted to create a class that rebuilds my complete environment.
> So dropping a database, creating a database, cleaning the synch folder,
> registering agents, etc. Due to the structure of the classes with all the
> logic in the main method, I could not easily reuse these classes. In the
> patch I submit with issue I have refactored the current solution in a better
> reuseable solution that can still be called command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901316#action_12901316 ] Jettro Coenradie commented on CONNECTORS-91: Hmm, I think the logging option is better, if people provide the right configuration you have what you need and even more. But I understand what you mean with the main method implementation. I'll add it back and provide a new patch. I also tried the sample with the new classes and it all seems to work. Is that good enough? > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: change_commands.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901312#action_12901312 ] Karl Wright commented on CONNECTORS-91: --- Another thing I had not noticed before is that this patch removes all stderr success confirmation messages for those folks who use the commands, and replaces them with log output. The log output is perfectly fine, but removing the feedback that the command was successful is, I think, not great. If the log were going to stderr typically that would be OK, but it typically is not, so I think you are going to want to do both. You would, obviously, want to do the stderr output within the main() method. Would it be possible to fix that up before I commit this? > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: change_commands.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901309#action_12901309 ] Karl Wright commented on CONNECTORS-91: --- This patch file worked properly. Since the automated tests do not exercise the commands, it would be good to set up a database instance from scratch using the changed code. If you have already done this, please let me know and I will go ahead and commit the changes. > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: change_commands.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901193#action_12901193 ] Karl Wright commented on CONNECTORS-91: --- Yes, your trunk version is too out of date. For example: kwri...@osore:~/wip/lcf-command-patch$ svn info trunk/modules/framework/agents/org/apache/lcf/agents/SynchronizeAll.java Path: trunk/modules/framework/agents/org/apache/lcf/agents/SynchronizeAll.java Name: SynchronizeAll.java URL: https://svn.apache.org/repos/asf/incubator/lcf/trunk/modules/framework/agents/org/apache/lcf/agents/SynchronizeAll.java Repository Root: https://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 987926 Node Kind: file Schedule: normal Last Changed Author: kwright Last Changed Rev: 921329 Last Changed Date: 2010-03-10 07:44:20 -0500 (Wed, 10 Mar 2010) Text Last Updated: 2010-08-22 12:50:36 -0400 (Sun, 22 Aug 2010) Checksum: 42dcca2a9eab1c6d5b48bdcd5c083a0b ... and the patch says: Index: modules/framework/agents/org/apache/lcf/agents/SynchronizeAll.java === --- modules/framework/agents/org/apache/lcf/agents/SynchronizeAll.java (revision 987465) +++ modules/framework/agents/org/apache/lcf/agents/SynchronizeAll.java (working copy) so, I am afraid you will need to synch up and reissue the patch. > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: changesToCommandClasses.patch, commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901186#action_12901186 ] Karl Wright commented on CONNECTORS-91: --- The patch failed to apply, fairly catastrophically. Only some 50% of files actually patched successfully. I don't know why this happened yet. Are you synchronized with the current version of trunk? Karl > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: changesToCommandClasses.patch, commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900902#action_12900902 ] Karl Wright commented on CONNECTORS-91: --- It is not clear whether the package name change (org.apache.acf vs org.apache.lcf) needs to be decided before your patch. I am happy to do your stuff first. For a list of classes, look in: core/org/apache/lcf/core agents/org/apache/lcf/agents pull-agent/org/apache/lcf/crawler pull-agent/org/apache/lcf/authorities ... Or, look at the how-to-build-and-deploy wiki page, which lists them all. Karl --- original message --- From: "ext Jettro Coenradie (JIRA)" Subject: [jira] Commented: (CONNECTORS-91) Making the initialization commands more useable Date: August 20, 2010 Time: 4:11:16 PM [ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900844#action_12900844 ] Jettro Coenradie commented on CONNECTORS-91: I am going though the classes, but they are not all easy to do. It actually is a lot of work. Can we split the work in the most important classes first and maybe later on the. You talk about the actual command classes, can you provide a list with the classes you mean? They would help me a lot. Also for the patch it is easier to know if the package is actually going to be changed now that the name of the project is changed -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900844#action_12900844 ] Jettro Coenradie commented on CONNECTORS-91: I am going though the classes, but they are not all easy to do. It actually is a lot of work. Can we split the work in the most important classes first and maybe later on the. You talk about the actual command classes, can you provide a list with the classes you mean? They would help me a lot. Also for the patch it is easier to know if the package is actually going to be changed now that the name of the project is changed > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Apache Connectors Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898929#action_12898929 ] Karl Wright commented on CONNECTORS-91: --- I suggest, then, that you create a patch that is complete, so that I can commit it all at once. For now, I would limit the work to actual "commands", and try not to include anything special like the quickstart main class. > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Lucene Connector Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898925#action_12898925 ] Jettro Coenradie commented on CONNECTORS-91: There should be no subtleties, I mainly moved code from the main method into a new method and indeed a bit of class-inheritance. > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Lucene Connector Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898920#action_12898920 ] Karl Wright commented on CONNECTORS-91: --- It looks like this is simply using class-inheritance to separate out common functionality. As such, I'm in favor of including this contribution. Are there any subtleties I am missing? > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Lucene Connector Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONNECTORS-91) Making the initialization commands more useable
[ https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898857#action_12898857 ] Jettro Coenradie commented on CONNECTORS-91: If you feel this is the way to go, I will change the other classes that have a main method as well. > Making the initialization commands more useable > --- > > Key: CONNECTORS-91 > URL: https://issues.apache.org/jira/browse/CONNECTORS-91 > Project: Lucene Connector Framework > Issue Type: Improvement > Components: Framework core >Reporter: Jettro Coenradie > Fix For: LCF Release 0.5 > > Attachments: commandsPatch.patch > > > At the moment LCF comes with some classes that can be used to run command > line to interact with the system. Examples are DBCreate, DBDrop and > LockClean. I wanted to create a class that rebuilds my complete environment. > So dropping a database, creating a database, cleaning the synch folder, > registering agents, etc. Due to the structure of the classes with all the > logic in the main method, I could not easily reuse these classes. In the > patch I submit with issue I have refactored the current solution in a better > reuseable solution that can still be called command line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
