Re: [PATCH 0/3] Some memory issue fixes
On Mon, 2014-09-29 at 09:19 +0300, Hannu Mallat wrote: > Some fixes to memory issues I've encountered in testing, please review. > > These have all come up when testing connecting to and disconnecting > from different networks while restarting wpa_supplicant and/or > reloading wlan kernel module in the background, so that things can > fail during pending operations for various reasons. Patches 1/3 and 2/3 applied, thanks! > The fix I made to wifi_tethering_info pointer to freed memory feels a > bit clumsy to me, so feedback is appreciated. This is the quickes fix for the issue. All other options require more code shuffling and writing. It's a bit difficult to see immediately what the best solution is, so I'll sit on patch 3/3 for a while and see if something comes to mind. Cheers, Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
[PATCH 0/3] Some memory issue fixes
Some fixes to memory issues I've encountered in testing, please review. These have all come up when testing connecting to and disconnecting from different networks while restarting wpa_supplicant and/or reloading wlan kernel module in the background, so that things can fail during pending operations for various reasons. The fix I made to wifi_tethering_info pointer to freed memory feels a bit clumsy to me, so feedback is appreciated. Hannu Mallat (3): gsupplicant: Fix D-Bus cancellation for interface creation wifi: set interface pointer to null on deallocation wifi: fix access to freed memory via wifi_tethering_info gsupplicant/supplicant.c | 2 +- plugins/wifi.c | 51 ++-- 2 files changed, 37 insertions(+), 16 deletions(-) -- 1.9.1 ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
