RE: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello Goetz.
Thank you for your suggestion.
I just open JDK-8217880 [1].
I just restart clean build.
I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open.
[1] https://bugs.openjdk.java.net/browse/JDK-8217880
Thanks,
Ichiroh Takiguchi
On 2019-01-28 22:11, Lindenmaier, Goetz wrote:
Hi Ichiroh,
just open a bug, like "Fix aix build after 8214533" and post a RFR for
it.
I assume the fix is quite trivial so we can review it quick.
Best regards,
Goetz.
-Original Message-
From: ppc-aix-port-dev On
Behalf Of Ichiroh Takiguchi
Sent: Montag, 28. Januar 2019 14:13
To: Baesken, Matthias
Cc: build-dev ; ppc-aix-port-dev
d...@openjdk.java.net>; core-libs-dev@openjdk.java.net; Alan Bateman
Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default
charset
Hello.
I'm very sorry. It's my fault.
EUC_JP class was moved to java.base module.
(sun.nio.cs.EUC_JP).
make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and
EUC_JP_Open.
Could you suggest me how I should provide new webrev files ?
Thanks,
Ichiroh Takiguchi
On 2019-01-28 17:03, Baesken, Matthias wrote:
> Hello, seems 8214533 got pushed recently into jdk/jdk. Now
> we see build errors on AIX , are they related to this change ?
>
>
> /nb/rs6000_64/nightly/output-jdk-
test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63:
> error: Decoder is not public in EUC_JP; cannot be accessed from
> outside package
> private static class Decoder extends EUC_JP.Decoder {
>^
> /nb/rs6000_64/nightly/output-jdk-
test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69:
> error: Encoder is not public in EUC_JP; cannot be accessed from
> outside package
> private static class Encoder extends EUC_JP.Encoder {
>^
> /nb/rs6000_64/nightly/output-jdk-
test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65:
> error: Decoder is not public in EUC_JP; cannot be accessed from
> outside package
> private static class Decoder extends EUC_JP.Decoder {
>^
> /nb/rs6000_64/nightly/output-jdk-
test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85:
> error: Encoder is not public in EUC_JP; cannot be accessed from
> outside package
> private static class Encoder extends EUC_JP.Encoder {
>
> Best regards, Matthias
>
>
>
>> -Original Message-
>> From: ppc-aix-port-dev On
>> Behalf Of Ichiroh Takiguchi
>> Sent: Dienstag, 15. Januar 2019 01:51
>> To: Alan Bateman
>> Cc: build-dev ; ppc-aix-port-dev > port-...@openjdk.java.net>; core-libs-dev@openjdk.java.net
>> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default
>> charset
>>
>> Hello Alan.
>>
>> Could you review the fix again ?
>>
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8214533
>> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/
>>
>> I added IBM29626C charset as standard way.
>> Please give any suggestion and question.
>>
>> Thanks,
>> Ichiroh Takiguchi
>> IBM Japan, Ltd.
>>
>> On 2018-12-14 18:58, Ichiroh Takiguchi wrote:
>> > Hello Alan.
>> >
>> > I opened JDK-8215333 for Charset filtering issue [1].
>> > I cannot wait until JDK-8215333 is closed.
>> > Is it possible to put IBM-29626C charset with standard way ?
>> >
>> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333
>> >
>> > Thanks,
>> > Ichiroh Takiguchi
>> >
>> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote:
>> >> Hello Roger, Magnus and Alan.
>> >> I may need to put alias information into charsets file.
>> >> stdcs-xxx cannot handle this information...
>> >>
>> >> Still AIX needs IBM-29626C charset for default encoding...
>> >>
>> >> I appreciate if you give me further suggestions.
>> >>
>> >> Thanks,
>> >> Ichiroh Takiguchi
>> >>
>> >> On 2018-12-10 20:50, Alan Bateman wrote:
>> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote:
>> >>>> On 2018-12-07 21:20, Roger Riggs wrote:
>> >>>>> Hi,
>> >>>>>
>> >>>>> It is a nice feature that charsets are selected at build time using
>> >>>>> the stdcs-xxx files.
>> >>>>> This change breaks that pattern and embeds os specific information
>> >>>>> in more than one place.
>> >>>>> That does not seem like an improvement. Is there any alternative?
>> >>>> I agree. Why is it not enough just to add it to stdcs-aix?
>> >>> My reading of the patch is that the "os" key is to avoid generating
>> >>> it
>> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on
>> >>> non-AIX platforms. The general direction is welcome but I think
>> >>> further work and discussion will be needed to get the right set of
>> >>> changes to support filtering in the build. It can probably be
>> >>> separated from the changes to add IBM-29626C to AIX's java.base.
>> >>>
>> >>> -Alan
RE: RFR: 8214533 IBM-29626C is required for AIX default charset
Hi Ichiroh,
just open a bug, like "Fix aix build after 8214533" and post a RFR for it.
I assume the fix is quite trivial so we can review it quick.
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev On
> Behalf Of Ichiroh Takiguchi
> Sent: Montag, 28. Januar 2019 14:13
> To: Baesken, Matthias
> Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>; core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default charset
>
> Hello.
>
> I'm very sorry. It's my fault.
> EUC_JP class was moved to java.base module.
> (sun.nio.cs.EUC_JP).
>
> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and
> EUC_JP_Open.
>
> Could you suggest me how I should provide new webrev files ?
>
> Thanks,
> Ichiroh Takiguchi
>
>
> On 2019-01-28 17:03, Baesken, Matthias wrote:
> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now
> > we see build errors on AIX , are they related to this change ?
> >
> >
> > /nb/rs6000_64/nightly/output-jdk-
> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63:
> > error: Decoder is not public in EUC_JP; cannot be accessed from
> > outside package
> > private static class Decoder extends EUC_JP.Decoder {
> >^
> > /nb/rs6000_64/nightly/output-jdk-
> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69:
> > error: Encoder is not public in EUC_JP; cannot be accessed from
> > outside package
> > private static class Encoder extends EUC_JP.Encoder {
> >^
> > /nb/rs6000_64/nightly/output-jdk-
> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65:
> > error: Decoder is not public in EUC_JP; cannot be accessed from
> > outside package
> > private static class Decoder extends EUC_JP.Decoder {
> >^
> > /nb/rs6000_64/nightly/output-jdk-
> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85:
> > error: Encoder is not public in EUC_JP; cannot be accessed from
> > outside package
> > private static class Encoder extends EUC_JP.Encoder {
> >
> > Best regards, Matthias
> >
> >
> >
> >> -----Original Message-----
> >> From: ppc-aix-port-dev On
> >> Behalf Of Ichiroh Takiguchi
> >> Sent: Dienstag, 15. Januar 2019 01:51
> >> To: Alan Bateman
> >> Cc: build-dev ; ppc-aix-port-dev >> port-...@openjdk.java.net>; core-libs-dev@openjdk.java.net
> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default
> >> charset
> >>
> >> Hello Alan.
> >>
> >> Could you review the fix again ?
> >>
> >> Bug:https://bugs.openjdk.java.net/browse/JDK-8214533
> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/
> >>
> >> I added IBM29626C charset as standard way.
> >> Please give any suggestion and question.
> >>
> >> Thanks,
> >> Ichiroh Takiguchi
> >> IBM Japan, Ltd.
> >>
> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote:
> >> > Hello Alan.
> >> >
> >> > I opened JDK-8215333 for Charset filtering issue [1].
> >> > I cannot wait until JDK-8215333 is closed.
> >> > Is it possible to put IBM-29626C charset with standard way ?
> >> >
> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333
> >> >
> >> > Thanks,
> >> > Ichiroh Takiguchi
> >> >
> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote:
> >> >> Hello Roger, Magnus and Alan.
> >> >> I may need to put alias information into charsets file.
> >> >> stdcs-xxx cannot handle this information...
> >> >>
> >> >> Still AIX needs IBM-29626C charset for default encoding...
> >> >>
> >> >> I appreciate if you give me further suggestions.
> >> >>
> >> >> Thanks,
> >> >> Ichiroh Takiguchi
> >> >>
> >> >> On 2018-12-10 20:50, Alan Bateman wrote:
> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote:
> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote:
> >> >>>>> Hi,
> >> >>>>>
> >> >>>>> It is a nice feature that charsets are selected at build time using
> >> >>>>> the stdcs-xxx files.
> >> >>>>> This change breaks that pattern and embeds os specific information
> >> >>>>> in more than one place.
> >> >>>>> That does not seem like an improvement. Is there any alternative?
> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix?
> >> >>> My reading of the patch is that the "os" key is to avoid generating
> >> >>> it
> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on
> >> >>> non-AIX platforms. The general direction is welcome but I think
> >> >>> further work and discussion will be needed to get the right set of
> >> >>> changes to support filtering in the build. It can probably be
> >> >>> separated from the changes to add IBM-29626C to AIX's java.base.
> >> >>>
> >> >>> -Alan
RE: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello.
I'm very sorry. It's my fault.
EUC_JP class was moved to java.base module.
(sun.nio.cs.EUC_JP).
make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and
EUC_JP_Open.
Could you suggest me how I should provide new webrev files ?
Thanks,
Ichiroh Takiguchi
On 2019-01-28 17:03, Baesken, Matthias wrote:
Hello, seems 8214533 got pushed recently into jdk/jdk. Now
we see build errors on AIX , are they related to this change ?
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63:
error: Decoder is not public in EUC_JP; cannot be accessed from
outside package
private static class Decoder extends EUC_JP.Decoder {
^
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69:
error: Encoder is not public in EUC_JP; cannot be accessed from
outside package
private static class Encoder extends EUC_JP.Encoder {
^
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65:
error: Decoder is not public in EUC_JP; cannot be accessed from
outside package
private static class Decoder extends EUC_JP.Decoder {
^
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85:
error: Encoder is not public in EUC_JP; cannot be accessed from
outside package
private static class Encoder extends EUC_JP.Encoder {
Best regards, Matthias
-Original Message-
From: ppc-aix-port-dev On
Behalf Of Ichiroh Takiguchi
Sent: Dienstag, 15. Januar 2019 01:51
To: Alan Bateman
Cc: build-dev ; ppc-aix-port-dev ; core-libs-dev@openjdk.java.net
Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default
charset
Hello Alan.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/
I added IBM29626C charset as standard way.
Please give any suggestion and question.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-12-14 18:58, Ichiroh Takiguchi wrote:
> Hello Alan.
>
> I opened JDK-8215333 for Charset filtering issue [1].
> I cannot wait until JDK-8215333 is closed.
> Is it possible to put IBM-29626C charset with standard way ?
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8215333
>
> Thanks,
> Ichiroh Takiguchi
>
> On 2018-12-10 21:21, Ichiroh Takiguchi wrote:
>> Hello Roger, Magnus and Alan.
>> I may need to put alias information into charsets file.
>> stdcs-xxx cannot handle this information...
>>
>> Still AIX needs IBM-29626C charset for default encoding...
>>
>> I appreciate if you give me further suggestions.
>>
>> Thanks,
>> Ichiroh Takiguchi
>>
>> On 2018-12-10 20:50, Alan Bateman wrote:
>>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote:
>>>> On 2018-12-07 21:20, Roger Riggs wrote:
>>>>> Hi,
>>>>>
>>>>> It is a nice feature that charsets are selected at build time using
>>>>> the stdcs-xxx files.
>>>>> This change breaks that pattern and embeds os specific information
>>>>> in more than one place.
>>>>> That does not seem like an improvement. Is there any alternative?
>>>> I agree. Why is it not enough just to add it to stdcs-aix?
>>> My reading of the patch is that the "os" key is to avoid generating
>>> it
>>> on non-AIX platforms, it will otherwise end up in jdk.charsets on
>>> non-AIX platforms. The general direction is welcome but I think
>>> further work and discussion will be needed to get the right set of
>>> changes to support filtering in the build. It can probably be
>>> separated from the changes to add IBM-29626C to AIX's java.base.
>>>
>>> -Alan
RE: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello, seems 8214533 got pushed recently into jdk/jdk. Now we see
build errors on AIX , are they related to this change ?
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63:
error: Decoder is not public in EUC_JP; cannot be accessed from outside package
private static class Decoder extends EUC_JP.Decoder {
^
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69:
error: Encoder is not public in EUC_JP; cannot be accessed from outside package
private static class Encoder extends EUC_JP.Encoder {
^
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65:
error: Decoder is not public in EUC_JP; cannot be accessed from outside package
private static class Decoder extends EUC_JP.Decoder {
^
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85:
error: Encoder is not public in EUC_JP; cannot be accessed from outside package
private static class Encoder extends EUC_JP.Encoder {
Best regards, Matthias
> -Original Message-
> From: ppc-aix-port-dev On
> Behalf Of Ichiroh Takiguchi
> Sent: Dienstag, 15. Januar 2019 01:51
> To: Alan Bateman
> Cc: build-dev ; ppc-aix-port-dev port-...@openjdk.java.net>; core-libs-dev@openjdk.java.net
> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default charset
>
> Hello Alan.
>
> Could you review the fix again ?
>
> Bug:https://bugs.openjdk.java.net/browse/JDK-8214533
> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/
>
> I added IBM29626C charset as standard way.
> Please give any suggestion and question.
>
> Thanks,
> Ichiroh Takiguchi
> IBM Japan, Ltd.
>
> On 2018-12-14 18:58, Ichiroh Takiguchi wrote:
> > Hello Alan.
> >
> > I opened JDK-8215333 for Charset filtering issue [1].
> > I cannot wait until JDK-8215333 is closed.
> > Is it possible to put IBM-29626C charset with standard way ?
> >
> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333
> >
> > Thanks,
> > Ichiroh Takiguchi
> >
> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote:
> >> Hello Roger, Magnus and Alan.
> >> I may need to put alias information into charsets file.
> >> stdcs-xxx cannot handle this information...
> >>
> >> Still AIX needs IBM-29626C charset for default encoding...
> >>
> >> I appreciate if you give me further suggestions.
> >>
> >> Thanks,
> >> Ichiroh Takiguchi
> >>
> >> On 2018-12-10 20:50, Alan Bateman wrote:
> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote:
> >>>> On 2018-12-07 21:20, Roger Riggs wrote:
> >>>>> Hi,
> >>>>>
> >>>>> It is a nice feature that charsets are selected at build time using
> >>>>> the stdcs-xxx files.
> >>>>> This change breaks that pattern and embeds os specific information
> >>>>> in more than one place.
> >>>>> That does not seem like an improvement. Is there any alternative?
> >>>> I agree. Why is it not enough just to add it to stdcs-aix?
> >>> My reading of the patch is that the "os" key is to avoid generating
> >>> it
> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on
> >>> non-AIX platforms. The general direction is welcome but I think
> >>> further work and discussion will be needed to get the right set of
> >>> changes to support filtering in the build. It can probably be
> >>> separated from the changes to add IBM-29626C to AIX's java.base.
> >>>
> >>> -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hi Ichiroh, Sorry for the delay, yes, the change looks fine. I'll sponsor, and push it tomorrow. Thanks, Roger On 01/23/2019 07:21 AM, Ichiroh Takiguchi wrote: Hello. Could you review the fix and give your suggestion ? Thanks, Ichiroh Takiguchi On 2019-01-16 21:32, Ichiroh Takiguchi wrote: Hello Alan and Roger. I appreciate your suggestions. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.02/ I used "hg cp" command. If I should use git format, please let me know. I changed Copyright year on IBM29626C.java.template and charsets file. Thanks, Ichiroh Takiguchi On 2019-01-16 01:01, Roger Riggs wrote: Hi, I'd suggest using 2002, 2019, for the copyright, since much of the code in the new file comes from an older source. $.02, Roger On 01/15/2019 10:43 AM, Alan Bateman wrote: On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. This looks okay, assuming it's `hg copy` of EUR_JP.template to create IBM29626C.java.template rather than a `hg mv` (the webrev makes it look like a move/rename). -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello. Could you review the fix and give your suggestion ? Thanks, Ichiroh Takiguchi On 2019-01-16 21:32, Ichiroh Takiguchi wrote: Hello Alan and Roger. I appreciate your suggestions. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.02/ I used "hg cp" command. If I should use git format, please let me know. I changed Copyright year on IBM29626C.java.template and charsets file. Thanks, Ichiroh Takiguchi On 2019-01-16 01:01, Roger Riggs wrote: Hi, I'd suggest using 2002, 2019, for the copyright, since much of the code in the new file comes from an older source. $.02, Roger On 01/15/2019 10:43 AM, Alan Bateman wrote: On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. This looks okay, assuming it's `hg copy` of EUR_JP.template to create IBM29626C.java.template rather than a `hg mv` (the webrev makes it look like a move/rename). -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello Alan and Roger. I appreciate your suggestions. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.02/ I used "hg cp" command. If I should use git format, please let me know. I changed Copyright year on IBM29626C.java.template and charsets file. Thanks, Ichiroh Takiguchi On 2019-01-16 01:01, Roger Riggs wrote: Hi, I'd suggest using 2002, 2019, for the copyright, since much of the code in the new file comes from an older source. $.02, Roger On 01/15/2019 10:43 AM, Alan Bateman wrote: On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. This looks okay, assuming it's `hg copy` of EUR_JP.template to create IBM29626C.java.template rather than a `hg mv` (the webrev makes it look like a move/rename). -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hi, I'd suggest using 2002, 2019, for the copyright, since much of the code in the new file comes from an older source. $.02, Roger On 01/15/2019 10:43 AM, Alan Bateman wrote: On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. This looks okay, assuming it's `hg copy` of EUR_JP.template to create IBM29626C.java.template rather than a `hg mv` (the webrev makes it look like a move/rename). -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. This looks okay, assuming it's `hg copy` of EUR_JP.template to create IBM29626C.java.template rather than a `hg mv` (the webrev makes it look like a move/rename). -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello Alan. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-12-14 18:58, Ichiroh Takiguchi wrote: Hello Alan. I opened JDK-8215333 for Charset filtering issue [1]. I cannot wait until JDK-8215333 is closed. Is it possible to put IBM-29626C charset with standard way ? [1] https://bugs.openjdk.java.net/browse/JDK-8215333 Thanks, Ichiroh Takiguchi On 2018-12-10 21:21, Ichiroh Takiguchi wrote: Hello Roger, Magnus and Alan. I may need to put alias information into charsets file. stdcs-xxx cannot handle this information... Still AIX needs IBM-29626C charset for default encoding... I appreciate if you give me further suggestions. Thanks, Ichiroh Takiguchi On 2018-12-10 20:50, Alan Bateman wrote: On 10/12/2018 11:01, Magnus Ihse Bursie wrote: On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement. Is there any alternative? I agree. Why is it not enough just to add it to stdcs-aix? My reading of the patch is that the "os" key is to avoid generating it on non-AIX platforms, it will otherwise end up in jdk.charsets on non-AIX platforms. The general direction is welcome but I think further work and discussion will be needed to get the right set of changes to support filtering in the build. It can probably be separated from the changes to add IBM-29626C to AIX's java.base. -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello Alan. I opened JDK-8215333 for Charset filtering issue [1]. I cannot wait until JDK-8215333 is closed. Is it possible to put IBM-29626C charset with standard way ? [1] https://bugs.openjdk.java.net/browse/JDK-8215333 Thanks, Ichiroh Takiguchi On 2018-12-10 21:21, Ichiroh Takiguchi wrote: Hello Roger, Magnus and Alan. I may need to put alias information into charsets file. stdcs-xxx cannot handle this information... Still AIX needs IBM-29626C charset for default encoding... I appreciate if you give me further suggestions. Thanks, Ichiroh Takiguchi On 2018-12-10 20:50, Alan Bateman wrote: On 10/12/2018 11:01, Magnus Ihse Bursie wrote: On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement. Is there any alternative? I agree. Why is it not enough just to add it to stdcs-aix? My reading of the patch is that the "os" key is to avoid generating it on non-AIX platforms, it will otherwise end up in jdk.charsets on non-AIX platforms. The general direction is welcome but I think further work and discussion will be needed to get the right set of changes to support filtering in the build. It can probably be separated from the changes to add IBM-29626C to AIX's java.base. -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hello Roger, Magnus and Alan. I may need to put alias information into charsets file. stdcs-xxx cannot handle this information... Still AIX needs IBM-29626C charset for default encoding... I appreciate if you give me further suggestions. Thanks, Ichiroh Takiguchi On 2018-12-10 20:50, Alan Bateman wrote: On 10/12/2018 11:01, Magnus Ihse Bursie wrote: On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement. Is there any alternative? I agree. Why is it not enough just to add it to stdcs-aix? My reading of the patch is that the "os" key is to avoid generating it on non-AIX platforms, it will otherwise end up in jdk.charsets on non-AIX platforms. The general direction is welcome but I think further work and discussion will be needed to get the right set of changes to support filtering in the build. It can probably be separated from the changes to add IBM-29626C to AIX's java.base. -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
On 10/12/2018 11:01, Magnus Ihse Bursie wrote: On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement. Is there any alternative? I agree. Why is it not enough just to add it to stdcs-aix? My reading of the patch is that the "os" key is to avoid generating it on non-AIX platforms, it will otherwise end up in jdk.charsets on non-AIX platforms. The general direction is welcome but I think further work and discussion will be needed to get the right set of changes to support filtering in the build. It can probably be separated from the changes to add IBM-29626C to AIX's java.base. -Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
On 2018-12-07 21:20, Roger Riggs wrote:
Hi,
It is a nice feature that charsets are selected at build time using
the stdcs-xxx files.
This change breaks that pattern and embeds os specific information in
more than one place.
That does not seem like an improvement. Is there any alternative?
I agree. Why is it not enough just to add it to stdcs-aix?
/Magnus
Thanks, Roger
On 12/06/2018 12:05 PM, Ichiroh Takiguchi wrote:
Hello.
(I'm sorry, I made a mistake, I forgot to change Subject)
Could you review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.00/
IBM29626C charset is required for AIX default charset.
Java cannot start because of java/lang/ExceptionInInitializerError on
AIX ja_JP locale.
To build team,
I'd like to change following charsetmapping tool.
* make/jdk/src/classes/build/tools/charsetmapping/Main.java
* make/jdk/src/classes/build/tools/charsetmapping/SPI.java
* make/jdk/src/classes/build/tools/charsetmapping/SRC.java
build.tools.charsetmapping,Main supports "os" tag, but it seems it's
not used.
Currently, "os" supports "windows" or "unix".
I extended "os" tag's feature.
If "os aix" is there, this charset is only added into AIX platform.
(I assume "type template" should be used)
"aix" comes from "stdcs-aix" file name.
==
charset x-IBM29626C IBM29626C
package sun.nio.cs.ext
typetemplate
os aix <=
alias cp29626C # JDK historical
alias ibm29626C
alias ibm-29626C
alias 29626C
alias ibm-eucjp
==
If cs.os is null,
this charset is stored into gensrc directory.
Charset name is added into StandardCharsets.java or
ExtendedCharsets.java
If cs.os is "false",
this charset is NOT stored into gensrc directory.
Charset name is NOT added into StandardCharsets.java or
ExtendedCharsets.java
"os" tag supports multiple entries by using ",", like "aix,linux"
Then we can store new charset into
src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory
$ locale charmap
IBM-eucJP
$ jshell
| JShell -- 12-internal
|: /help intro
jshell> var cs = java.nio.charset.Charset.defaultCharset()
cs ==> x-IBM29626C
jshell> cs.getClass().getName()
$2 ==> "sun.nio.cs.IBM29626C"
jshell> System.out.println(String.join("\n", cs.aliases()))
cp29626C
ibm-29626C
ibm-eucjp
ibm29626C
29626C
jshell> /exit
|
$
I tested Linux and Windows build.
==
$ grep 29626 build.log
IBM29626C, x-IBM29626C, null, sun.nio.cs.ext, template false
$ find support/gensrc/ | grep 29626
$ find support/gensrc/ | grep Charsets
support/gensrc/java.base/sun/nio/cs/StandardCharsets.java
support/gensrc/jdk.charsets/sun/nio/cs/ext/ExtendedCharsets.java
$ find support/gensrc/ | grep Charsets | xargs grep 29626
$
==
I'd like to obtain a sponsor for this issue.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-11-28 19:10, Magnus Ihse Bursie wrote:
On 2018-11-28 10:36, Alan Bateman wrote:
On 28/11/2018 09:28, Magnus Ihse Bursie wrote:
I'm quite unsatisfied with the current handling of character sets
in the build in general. :-( I'd really like to modernize it. I
have a, slightly fuzzy, laundry list of things I want to fix from
a build perspective, but I'm not sure of what "external"
requirements are coming from AIX and the general core-libs agenda
regarding character sets in general.
I think there is a good opportunity to solve many problems at the
same time here, as long as everyone agrees on what is the
preferred outcome.
The support in the build to configure the charsets to include in
java.base on each platform has been working well. Charsets that
aren't in java.base go into the jdk.charsets service provider
module and that has been working well too. From the result point of
view, perhaps, but definitely not from the build perspective. ;-)
But yes, I understand this is functionality that should be kept.
One thing that we lack is some way to add charsets for specific
platforms and this comes up with the IBM patches where they are
looking to adding several additional IBM charsets. One starting
point that we've touched on in several threads here is dropping the
EBCDIC charsets from the main stream builds. Going there will need
build support.
So build support for trivially adding specific charsets to specific
platforms? Both to java.base (for AIX) and jdk.charsets, I presume,
then?
Can you expand on the issue of dropping ebcdic? What's the problem
that needs build support?
/Magnus
-Alan
Re: RFR: 8214533 IBM-29626C is required for AIX default charset
Hi,
It is a nice feature that charsets are selected at build time using the
stdcs-xxx files.
This change breaks that pattern and embeds os specific information in
more than one place.
That does not seem like an improvement. Is there any alternative?
Thanks, Roger
On 12/06/2018 12:05 PM, Ichiroh Takiguchi wrote:
Hello.
(I'm sorry, I made a mistake, I forgot to change Subject)
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.00/
IBM29626C charset is required for AIX default charset.
Java cannot start because of java/lang/ExceptionInInitializerError on
AIX ja_JP locale.
To build team,
I'd like to change following charsetmapping tool.
* make/jdk/src/classes/build/tools/charsetmapping/Main.java
* make/jdk/src/classes/build/tools/charsetmapping/SPI.java
* make/jdk/src/classes/build/tools/charsetmapping/SRC.java
build.tools.charsetmapping,Main supports "os" tag, but it seems it's
not used.
Currently, "os" supports "windows" or "unix".
I extended "os" tag's feature.
If "os aix" is there, this charset is only added into AIX platform.
(I assume "type template" should be used)
"aix" comes from "stdcs-aix" file name.
==
charset x-IBM29626C IBM29626C
package sun.nio.cs.ext
type template
os aix <=
alias cp29626C # JDK historical
alias ibm29626C
alias ibm-29626C
alias 29626C
alias ibm-eucjp
==
If cs.os is null,
this charset is stored into gensrc directory.
Charset name is added into StandardCharsets.java or ExtendedCharsets.java
If cs.os is "false",
this charset is NOT stored into gensrc directory.
Charset name is NOT added into StandardCharsets.java or
ExtendedCharsets.java
"os" tag supports multiple entries by using ",", like "aix,linux"
Then we can store new charset into
src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory
$ locale charmap
IBM-eucJP
$ jshell
| JShell -- 12-internal
| : /help intro
jshell> var cs = java.nio.charset.Charset.defaultCharset()
cs ==> x-IBM29626C
jshell> cs.getClass().getName()
$2 ==> "sun.nio.cs.IBM29626C"
jshell> System.out.println(String.join("\n", cs.aliases()))
cp29626C
ibm-29626C
ibm-eucjp
ibm29626C
29626C
jshell> /exit
|
$
I tested Linux and Windows build.
==
$ grep 29626 build.log
IBM29626C, x-IBM29626C, null, sun.nio.cs.ext, template false
$ find support/gensrc/ | grep 29626
$ find support/gensrc/ | grep Charsets
support/gensrc/java.base/sun/nio/cs/StandardCharsets.java
support/gensrc/jdk.charsets/sun/nio/cs/ext/ExtendedCharsets.java
$ find support/gensrc/ | grep Charsets | xargs grep 29626
$
==
I'd like to obtain a sponsor for this issue.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-11-28 19:10, Magnus Ihse Bursie wrote:
On 2018-11-28 10:36, Alan Bateman wrote:
On 28/11/2018 09:28, Magnus Ihse Bursie wrote:
I'm quite unsatisfied with the current handling of character sets
in the build in general. :-( I'd really like to modernize it. I
have a, slightly fuzzy, laundry list of things I want to fix from a
build perspective, but I'm not sure of what "external" requirements
are coming from AIX and the general core-libs agenda regarding
character sets in general.
I think there is a good opportunity to solve many problems at the
same time here, as long as everyone agrees on what is the preferred
outcome.
The support in the build to configure the charsets to include in
java.base on each platform has been working well. Charsets that
aren't in java.base go into the jdk.charsets service provider module
and that has been working well too. From the result point of view,
perhaps, but definitely not from the build perspective. ;-) But yes,
I understand this is functionality that should be kept.
One thing that we lack is some way to add charsets for specific
platforms and this comes up with the IBM patches where they are
looking to adding several additional IBM charsets. One starting
point that we've touched on in several threads here is dropping the
EBCDIC charsets from the main stream builds. Going there will need
build support.
So build support for trivially adding specific charsets to specific
platforms? Both to java.base (for AIX) and jdk.charsets, I presume,
then?
Can you expand on the issue of dropping ebcdic? What's the problem
that needs build support?
/Magnus
-Alan
