Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-06-13 Thread Bhaktavatsal R Maram 
Hi Thomas,

I've added testcase along with fix. Please find webrev at 
http://cr.openjdk.java.net/~aleonard/8202329/webrev.01/

Thanks,
Bhaktavatsal Reddy

  

-"core-libs-dev"  wrote: -
To: "Thomas Stüfe" 
From: "Bhaktavatsal R Maram" 
Sent by: "core-libs-dev" 
Date: 06/01/2018 01:34PM
Cc: Java Core Libs 
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

Hi Thomas,

Sorry, I was on vacation. I will submit webrev with jtreg testcase.

Thanks,
Bhaktavatsal
 

  

-"Thomas Stüfe"  wrote: -
To: Bhaktavatsal R Maram 
From: "Thomas Stüfe" 
Date: 05/23/2018 12:32AM
Cc: Ichiroh Takiguchi , Volker Simonis 
, Java Core Libs 
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

Hi Bhaktavatsal,

the fix is fine. Reviewed. Thanks a lot for your work!

Could you please (its okay in a future patch) add a regression test
for IBM943 and IBM943C, in the form of a jtreg test? I would like to
test conversions for both code pages (at least for the crucial
tilde/backslash code points).

Additionally, that when started on AIX with Ja_JP.IBM-943, we
correctly default to IBM943C.

As an example, here is an old test I wrote years ago. You won't be
able to use it verbatim, so it is just a suggestion. Feel free to do
it differently.

http://cr.openjdk.java.net/~stuefe/other/IBM943MappingTest.java

If you have not written jtreg tests before:

http://openjdk.java.net/jtreg/

Also, under /test are many many examples.

Best Regards, Thomas

On Mon, May 21, 2018 at 9:47 AM, Bhaktavatsal R Maram
 wrote:
> Hi Thomas,
>
> Is this fix ready to merge?
>
> Thanks,
> Bhaktavatsal
>
>
>
>
> -"Thomas Stüfe"  wrote: -
> To: Ichiroh Takiguchi , Bhaktavatsal R Maram 
> 
> From: "Thomas Stüfe" 
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis , Java Core Libs 
> 
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and review next week. We also have some in-house tests which
> I'd like to run.
>
> You IBM folks should really apply for authorship so that this
> contribution process gets streamlined. After all, if something breaks
> in this code, you want to be able to fix it, yes? So even if you do
> not contribute much else, more patches may be forthcoming.
>
> Of course I hope these are not your last contributions :)
>
> Best, Thomas
>
>
>
> On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
>  wrote:
>> Hi.
>>
>> I tested this fix on AIX.
>>
>> I got following results.
>> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW   x-IBM950IBM-950 IBM-950
>> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>>
>> Also I reviewed source code, it's fine
>>
>> Since this testing requires locale installation for Ja_JP and Zh_TW,
>> so it's not easy to test it...
>> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
>> required)
>>
>>
>> On 2018-05-02 18:32, Volker Simonis wrote:
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> your change looks good. I can sponsor it.
>>>
>>> Just waiting for a second review...
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>>  wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review the fix.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>>
>>>> Thanks,
>>>> Bhaktavatsal Reddy
>>>>
>>>> -"core-libs-dev"  wrote:
>>>> -
>>>> To: Volker Simonis 
>>>> From: "Bhaktavatsal R Maram"
>>>> Sent by: "core-libs-dev"
>>>> Date: 04/26/2018 09:31PM
>>>> Cc: Java Core Libs 
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Volker,
>>>>
>>>> Thank you. I will address your review comments and send webrev for
>>>> review.
>>>>
>>>> - Bhaktavatsal Reddy
>>>>
>>>>
>>>>
>>>> -Volker Simonis  wrote: -
>

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-06-01 Thread Bhaktavatsal R Maram 
Hi Thomas,

Sorry, I was on vacation. I will submit webrev with jtreg testcase.

Thanks,
Bhaktavatsal
 

  

-"Thomas Stüfe"  wrote: -
To: Bhaktavatsal R Maram 
From: "Thomas Stüfe" 
Date: 05/23/2018 12:32AM
Cc: Ichiroh Takiguchi , Volker Simonis 
, Java Core Libs 
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

Hi Bhaktavatsal,

the fix is fine. Reviewed. Thanks a lot for your work!

Could you please (its okay in a future patch) add a regression test
for IBM943 and IBM943C, in the form of a jtreg test? I would like to
test conversions for both code pages (at least for the crucial
tilde/backslash code points).

Additionally, that when started on AIX with Ja_JP.IBM-943, we
correctly default to IBM943C.

As an example, here is an old test I wrote years ago. You won't be
able to use it verbatim, so it is just a suggestion. Feel free to do
it differently.

http://cr.openjdk.java.net/~stuefe/other/IBM943MappingTest.java

If you have not written jtreg tests before:

http://openjdk.java.net/jtreg/

Also, under /test are many many examples.

Best Regards, Thomas

On Mon, May 21, 2018 at 9:47 AM, Bhaktavatsal R Maram
 wrote:
> Hi Thomas,
>
> Is this fix ready to merge?
>
> Thanks,
> Bhaktavatsal
>
>
>
>
> -"Thomas Stüfe"  wrote: -
> To: Ichiroh Takiguchi , Bhaktavatsal R Maram 
> 
> From: "Thomas Stüfe" 
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis , Java Core Libs 
> 
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and review next week. We also have some in-house tests which
> I'd like to run.
>
> You IBM folks should really apply for authorship so that this
> contribution process gets streamlined. After all, if something breaks
> in this code, you want to be able to fix it, yes? So even if you do
> not contribute much else, more patches may be forthcoming.
>
> Of course I hope these are not your last contributions :)
>
> Best, Thomas
>
>
>
> On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
>  wrote:
>> Hi.
>>
>> I tested this fix on AIX.
>>
>> I got following results.
>> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW   x-IBM950IBM-950 IBM-950
>> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>>
>> Also I reviewed source code, it's fine
>>
>> Since this testing requires locale installation for Ja_JP and Zh_TW,
>> so it's not easy to test it...
>> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
>> required)
>>
>>
>> On 2018-05-02 18:32, Volker Simonis wrote:
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> your change looks good. I can sponsor it.
>>>
>>> Just waiting for a second review...
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>>  wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review the fix.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>>
>>>> Thanks,
>>>> Bhaktavatsal Reddy
>>>>
>>>> -"core-libs-dev"  wrote:
>>>> -
>>>> To: Volker Simonis 
>>>> From: "Bhaktavatsal R Maram"
>>>> Sent by: "core-libs-dev"
>>>> Date: 04/26/2018 09:31PM
>>>> Cc: Java Core Libs 
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Volker,
>>>>
>>>> Thank you. I will address your review comments and send webrev for
>>>> review.
>>>>
>>>> - Bhaktavatsal Reddy
>>>>
>>>>
>>>>
>>>> -Volker Simonis  wrote: -
>>>> To: Bhaktavatsal R Maram 
>>>> From: Volker Simonis 
>>>> Date: 04/26/2018 09:12PM
>>>> Cc: Java Core Libs 
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Bhaktavatsal Reddy,
>>>>
>>>> I've opened the following issue for this problem:
>>>>
>>>>

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-22 Thread Thomas Stüfe 
Hi Bhaktavatsal,

the fix is fine. Reviewed. Thanks a lot for your work!

Could you please (its okay in a future patch) add a regression test
for IBM943 and IBM943C, in the form of a jtreg test? I would like to
test conversions for both code pages (at least for the crucial
tilde/backslash code points).

Additionally, that when started on AIX with Ja_JP.IBM-943, we
correctly default to IBM943C.

As an example, here is an old test I wrote years ago. You won't be
able to use it verbatim, so it is just a suggestion. Feel free to do
it differently.

http://cr.openjdk.java.net/~stuefe/other/IBM943MappingTest.java

If you have not written jtreg tests before:

http://openjdk.java.net/jtreg/

Also, under /test are many many examples.

Best Regards, Thomas

On Mon, May 21, 2018 at 9:47 AM, Bhaktavatsal R Maram
<bhama...@in.ibm.com> wrote:
> Hi Thomas,
>
> Is this fix ready to merge?
>
> Thanks,
> Bhaktavatsal
>
>
>
>
> -"Thomas Stüfe" <thomas.stu...@gmail.com> wrote: -
> To: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com>, Bhaktavatsal R Maram 
> <bhama...@in.ibm.com>
> From: "Thomas Stüfe" <thomas.stu...@gmail.com>
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs 
> <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and review next week. We also have some in-house tests which
> I'd like to run.
>
> You IBM folks should really apply for authorship so that this
> contribution process gets streamlined. After all, if something breaks
> in this code, you want to be able to fix it, yes? So even if you do
> not contribute much else, more patches may be forthcoming.
>
> Of course I hope these are not your last contributions :)
>
> Best, Thomas
>
>
>
> On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
> <taki...@linux.vnet.ibm.com> wrote:
>> Hi.
>>
>> I tested this fix on AIX.
>>
>> I got following results.
>> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW   x-IBM950IBM-950 IBM-950
>> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>>
>> Also I reviewed source code, it's fine
>>
>> Since this testing requires locale installation for Ja_JP and Zh_TW,
>> so it's not easy to test it...
>> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
>> required)
>>
>>
>> On 2018-05-02 18:32, Volker Simonis wrote:
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> your change looks good. I can sponsor it.
>>>
>>> Just waiting for a second review...
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>> <bhama...@in.ibm.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review the fix.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>>
>>>> Thanks,
>>>> Bhaktavatsal Reddy
>>>>
>>>> -"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote:
>>>> -
>>>> To: Volker Simonis <volker.simo...@gmail.com>
>>>> From: "Bhaktavatsal R Maram"
>>>> Sent by: "core-libs-dev"
>>>> Date: 04/26/2018 09:31PM
>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Volker,
>>>>
>>>> Thank you. I will address your review comments and send webrev for
>>>> review.
>>>>
>>>> - Bhaktavatsal Reddy
>>>>
>>>>
>>>>
>>>> -Volker Simonis <volker.simo...@gmail.com> wrote: -
>>>> To: Bhaktavatsal R Maram <bhama...@in.ibm.com>
>>>> From: Volker Simonis <volker.simo...@gmail.com>
>>>> Date: 04/26/2018 09:12PM
>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>>

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-22 Thread Thomas Stüfe 
On Mon, May 21, 2018 at 10:00 AM, Alan Bateman  wrote:
> On 21/05/2018 08:53, Thomas Stüfe wrote:
>>
>> On Mon, May 21, 2018 at 9:52 AM, Thomas Stüfe 
>> wrote:
>>>
>>> Hi Bhaktavatsal,
>>>
>>> sorry, I have not had time to look at it yet. Too much unforeseen work.
>>>
>>> If there is another one wanting to review
>>
>> (preferably someone from Oracles core libs group? Someone?)
>>
>>
> The #ifdef AIX additions to java_props_md.c look okay to me.
>
> (Separately, I think we should start a discussion here about moving some or
> all of the IBM charsets to their own service provider module. I realize the
> AIX port might want to include some of them in its build of java.base but
> they aren't interesting to include in java.base, or even jdk.charsets, on
> most platforms).
>

I agree.

..Thomas

> -Alan

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-21 Thread Alan Bateman 

On 21/05/2018 08:53, Thomas Stüfe wrote:

On Mon, May 21, 2018 at 9:52 AM, Thomas Stüfe  wrote:

Hi Bhaktavatsal,

sorry, I have not had time to look at it yet. Too much unforeseen work.

If there is another one wanting to review

(preferably someone from Oracles core libs group? Someone?)



The #ifdef AIX additions to java_props_md.c look okay to me.

(Separately, I think we should start a discussion here about moving some 
or all of the IBM charsets to their own service provider module. I 
realize the AIX port might want to include some of them in its build of 
java.base but they aren't interesting to include in java.base, or even 
jdk.charsets, on most platforms).


-Alan

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-21 Thread Thomas Stüfe 
On Mon, May 21, 2018 at 9:52 AM, Thomas Stüfe <thomas.stu...@gmail.com> wrote:
> Hi Bhaktavatsal,
>
> sorry, I have not had time to look at it yet. Too much unforeseen work.
>
> If there is another one wanting to review

(preferably someone from Oracles core libs group? Someone?)

, please do. If noone steps
> up, I'll try to do it next week, but unfortunately I cannot promise
> anything.
>
> ..Thomas
>
> On Mon, May 21, 2018 at 9:47 AM, Bhaktavatsal R Maram
> <bhama...@in.ibm.com> wrote:
>> Hi Thomas,
>>
>> Is this fix ready to merge?
>>
>> Thanks,
>> Bhaktavatsal
>>
>>
>>
>>
>> -"Thomas Stüfe" <thomas.stu...@gmail.com> wrote: -
>> To: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com>, Bhaktavatsal R Maram 
>> <bhama...@in.ibm.com>
>> From: "Thomas Stüfe" <thomas.stu...@gmail.com>
>> Date: 05/11/2018 11:49AM
>> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs 
>> <core-libs-dev@openjdk.java.net>
>> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and 
>> Big5
>>
>> Hi,
>>
>> I'll test and review next week. We also have some in-house tests which
>> I'd like to run.
>>
>> You IBM folks should really apply for authorship so that this
>> contribution process gets streamlined. After all, if something breaks
>> in this code, you want to be able to fix it, yes? So even if you do
>> not contribute much else, more patches may be forthcoming.
>>
>> Of course I hope these are not your last contributions :)
>>
>> Best, Thomas
>>
>>
>>
>> On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
>> <taki...@linux.vnet.ibm.com> wrote:
>>> Hi.
>>>
>>> I tested this fix on AIX.
>>>
>>> I got following results.
>>> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
>>> Ja_JP   x-IBM943C   IBM-943CIBM-943C
>>> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
>>> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
>>> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
>>> Zh_TW   x-IBM950IBM-950 IBM-950
>>> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
>>> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>>>
>>> Also I reviewed source code, it's fine
>>>
>>> Since this testing requires locale installation for Ja_JP and Zh_TW,
>>> so it's not easy to test it...
>>> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
>>> required)
>>>
>>>
>>> On 2018-05-02 18:32, Volker Simonis wrote:
>>>>
>>>> Hi Bhaktavatsal Reddy,
>>>>
>>>> your change looks good. I can sponsor it.
>>>>
>>>> Just waiting for a second review...
>>>>
>>>> Thank you and best regards,
>>>> Volker
>>>>
>>>>
>>>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>>> <bhama...@in.ibm.com> wrote:
>>>>>
>>>>> Hi All,
>>>>>
>>>>> Please review the fix.
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Bhaktavatsal Reddy
>>>>>
>>>>> -"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote:
>>>>> -
>>>>> To: Volker Simonis <volker.simo...@gmail.com>
>>>>> From: "Bhaktavatsal R Maram"
>>>>> Sent by: "core-libs-dev"
>>>>> Date: 04/26/2018 09:31PM
>>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>>
>>>>> Hi Volker,
>>>>>
>>>>> Thank you. I will address your review comments and send webrev for
>>>>> review.
>>>>>
>>>>> - Bhaktavatsal Reddy
>>>>>
>>>>>
>>>>>
>>>>> -Volker Simonis <volker.simo...@gmail.com> wrote: -
>>>>> To: Bhaktavatsal R Maram <bhama...@in.ibm.com>
>>>>> From: Volker Simonis <volker.simo...@gmail.com>
>>>>> Date: 04/26/2018 09:12PM
>>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-21 Thread Thomas Stüfe 
Hi Bhaktavatsal,

sorry, I have not had time to look at it yet. Too much unforeseen work.

If there is another one wanting to review, please do. If noone steps
up, I'll try to do it next week, but unfortunately I cannot promise
anything.

..Thomas

On Mon, May 21, 2018 at 9:47 AM, Bhaktavatsal R Maram
<bhama...@in.ibm.com> wrote:
> Hi Thomas,
>
> Is this fix ready to merge?
>
> Thanks,
> Bhaktavatsal
>
>
>
>
> -"Thomas Stüfe" <thomas.stu...@gmail.com> wrote: -
> To: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com>, Bhaktavatsal R Maram 
> <bhama...@in.ibm.com>
> From: "Thomas Stüfe" <thomas.stu...@gmail.com>
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs 
> <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and review next week. We also have some in-house tests which
> I'd like to run.
>
> You IBM folks should really apply for authorship so that this
> contribution process gets streamlined. After all, if something breaks
> in this code, you want to be able to fix it, yes? So even if you do
> not contribute much else, more patches may be forthcoming.
>
> Of course I hope these are not your last contributions :)
>
> Best, Thomas
>
>
>
> On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
> <taki...@linux.vnet.ibm.com> wrote:
>> Hi.
>>
>> I tested this fix on AIX.
>>
>> I got following results.
>> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW   x-IBM950IBM-950 IBM-950
>> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>>
>> Also I reviewed source code, it's fine
>>
>> Since this testing requires locale installation for Ja_JP and Zh_TW,
>> so it's not easy to test it...
>> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
>> required)
>>
>>
>> On 2018-05-02 18:32, Volker Simonis wrote:
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> your change looks good. I can sponsor it.
>>>
>>> Just waiting for a second review...
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>> <bhama...@in.ibm.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review the fix.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>>
>>>> Thanks,
>>>> Bhaktavatsal Reddy
>>>>
>>>> -"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote:
>>>> -
>>>> To: Volker Simonis <volker.simo...@gmail.com>
>>>> From: "Bhaktavatsal R Maram"
>>>> Sent by: "core-libs-dev"
>>>> Date: 04/26/2018 09:31PM
>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Volker,
>>>>
>>>> Thank you. I will address your review comments and send webrev for
>>>> review.
>>>>
>>>> - Bhaktavatsal Reddy
>>>>
>>>>
>>>>
>>>> -Volker Simonis <volker.simo...@gmail.com> wrote: -
>>>> To: Bhaktavatsal R Maram <bhama...@in.ibm.com>
>>>> From: Volker Simonis <volker.simo...@gmail.com>
>>>> Date: 04/26/2018 09:12PM
>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Bhaktavatsal Reddy,
>>>>
>>>> I've opened the following issue for this problem:
>>>>
>>>> 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8202329
>>>>
>>>> Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
>>>> AIX" and the original "#else" by "#ifdef __solaris__". The original
&g

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-21 Thread Bhaktavatsal R Maram 
Hi Thomas,

Is this fix ready to merge?

Thanks,
Bhaktavatsal
 

  

-"Thomas Stüfe" <thomas.stu...@gmail.com> wrote: -
To: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com>, Bhaktavatsal R Maram 
<bhama...@in.ibm.com>
From: "Thomas Stüfe" <thomas.stu...@gmail.com>
Date: 05/11/2018 11:49AM
Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs 
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

Hi,

I'll test and review next week. We also have some in-house tests which
I'd like to run.

You IBM folks should really apply for authorship so that this
contribution process gets streamlined. After all, if something breaks
in this code, you want to be able to fix it, yes? So even if you do
not contribute much else, more patches may be forthcoming.

Of course I hope these are not your last contributions :)

Best, Thomas



On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
<taki...@linux.vnet.ibm.com> wrote:
> Hi.
>
> I tested this fix on AIX.
>
> I got following results.
> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
> Ja_JP   x-IBM943C   IBM-943CIBM-943C
> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
> Zh_TW   x-IBM950IBM-950 IBM-950
> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>
> Also I reviewed source code, it's fine
>
> Since this testing requires locale installation for Ja_JP and Zh_TW,
> so it's not easy to test it...
> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
> required)
>
>
> On 2018-05-02 18:32, Volker Simonis wrote:
>>
>> Hi Bhaktavatsal Reddy,
>>
>> your change looks good. I can sponsor it.
>>
>> Just waiting for a second review...
>>
>> Thank you and best regards,
>> Volker
>>
>>
>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>> <bhama...@in.ibm.com> wrote:
>>>
>>> Hi All,
>>>
>>> Please review the fix.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>
>>> Thanks,
>>> Bhaktavatsal Reddy
>>>
>>> -"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote:
>>> -
>>> To: Volker Simonis <volker.simo...@gmail.com>
>>> From: "Bhaktavatsal R Maram"
>>> Sent by: "core-libs-dev"
>>> Date: 04/26/2018 09:31PM
>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>
>>> Hi Volker,
>>>
>>> Thank you. I will address your review comments and send webrev for
>>> review.
>>>
>>> - Bhaktavatsal Reddy
>>>
>>>
>>>
>>> -Volker Simonis <volker.simo...@gmail.com> wrote: -
>>> To: Bhaktavatsal R Maram <bhama...@in.ibm.com>
>>> From: Volker Simonis <volker.simo...@gmail.com>
>>> Date: 04/26/2018 09:12PM
>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> I've opened the following issue for this problem:
>>>
>>> 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8202329
>>>
>>> Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
>>> AIX" and the original "#else" by "#ifdef __solaris__". The original
>>> else branch contains Solaris-only code anyway and it is an historical
>>> omission that there are still a lot of places in the code where "not
>>> Linux" implicitly means "Solaris", but that's often wrong.
>>>
>>> Regards,
>>> Volker
>>>
>>>
>>> On Thu, Apr 26, 2018 at 4:02 PM, Bhaktavatsal R Maram
>>> <bhama...@in.ibm.com> wrote:
>>>>
>>>> Oops! Looks like there is problem with attachment (might be because I
>>>> attached .class file as well). I'm pasting the fix and test program here in
>>>> mail.
>>>>
>>>> Test Program:
>>>>
>>>> import java.nio.charset.*;
>>>> class PrintDefaultCharset {
>>&g

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-11 Thread Thomas Stüfe 
Great!

So far we (sap) have developed the AIX port alone, good to finally
have IBM on our side :)

For authorship/committership info, see:

See: http://openjdk.java.net/contribute/

Among other things, your patches need to be ran through a battery of
tests at http://hg.openjdk.java.net/jdk/submit/. Currently your
sponsor has to do this, once you have committer rights (after a number
of contributed patches), you will be able to do that yourself.

But the first thing for you would be to become ojdk author, that gives
you a real username at http://openjdk.java.net/census and allows you
to upload your webrevs yourself to cr.openjdk.java.net.

Kind Regards, Thomas


On Fri, May 11, 2018 at 8:30 AM, Bhaktavatsal R Maram
<bhama...@in.ibm.com> wrote:
> Hi Thomas,
>
> Yes, there are many more to come :)
>
> - Bhaktavatsal
>
>
> -"Thomas Stüfe" <thomas.stu...@gmail.com> wrote: -
> To: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com>, Bhaktavatsal R Maram 
> <bhama...@in.ibm.com>
> From: "Thomas Stüfe" <thomas.stu...@gmail.com>
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs 
> <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and review next week. We also have some in-house tests which
> I'd like to run.
>
> You IBM folks should really apply for authorship so that this
> contribution process gets streamlined. After all, if something breaks
> in this code, you want to be able to fix it, yes? So even if you do
> not contribute much else, more patches may be forthcoming.
>
> Of course I hope these are not your last contributions :)
>
> Best, Thomas
>
>
>
> On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
> <taki...@linux.vnet.ibm.com> wrote:
>> Hi.
>>
>> I tested this fix on AIX.
>>
>> I got following results.
>> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
>> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
>> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW   x-IBM950IBM-950 IBM-950
>> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
>> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>>
>> Also I reviewed source code, it's fine
>>
>> Since this testing requires locale installation for Ja_JP and Zh_TW,
>> so it's not easy to test it...
>> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
>> required)
>>
>>
>> On 2018-05-02 18:32, Volker Simonis wrote:
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> your change looks good. I can sponsor it.
>>>
>>> Just waiting for a second review...
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>> <bhama...@in.ibm.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review the fix.
>>>>
>>>> bug: 
>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=EObjWXMYLV3tP7TlWXJqeLzR7hJkCsURSqJDb0dSnTc=YRbmsm-yoh4kURT2ZktLR6ayWpHpmxdqdOrEFmmDqT4=
>>>> webrev: 
>>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Ealeonard_8202329_webrev.00_=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=EObjWXMYLV3tP7TlWXJqeLzR7hJkCsURSqJDb0dSnTc=-9QkhLYlAZtChOxa4KOBBrycxbhYS8BfxdMahwSwjOw=
>>>>
>>>> Thanks,
>>>> Bhaktavatsal Reddy
>>>>
>>>> -"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote:
>>>> -
>>>> To: Volker Simonis <volker.simo...@gmail.com>
>>>> From: "Bhaktavatsal R Maram"
>>>> Sent by: "core-libs-dev"
>>>> Date: 04/26/2018 09:31PM
>>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>>
>>>> Hi Volker,
>>>>
>>>> Thank you. I will address your review comments and send webrev for
>>>> review.
>>>>
>>>> - Bhaktavatsal Reddy
>>>>
>>>>
>>>>
>>>> -Volker Simonis <volker.simo...@gmail.com> wrote: -
>>>> To: Bha

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-11 Thread Bhaktavatsal R Maram 
Hi Thomas,

Yes, there are many more to come :)

- Bhaktavatsal
  

-"Thomas Stüfe" <thomas.stu...@gmail.com> wrote: -
To: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com>, Bhaktavatsal R Maram 
<bhama...@in.ibm.com>
From: "Thomas Stüfe" <thomas.stu...@gmail.com>
Date: 05/11/2018 11:49AM
Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs 
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

Hi,

I'll test and review next week. We also have some in-house tests which
I'd like to run.

You IBM folks should really apply for authorship so that this
contribution process gets streamlined. After all, if something breaks
in this code, you want to be able to fix it, yes? So even if you do
not contribute much else, more patches may be forthcoming.

Of course I hope these are not your last contributions :)

Best, Thomas



On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
<taki...@linux.vnet.ibm.com> wrote:
> Hi.
>
> I tested this fix on AIX.
>
> I got following results.
> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
> Ja_JP   x-IBM943C   IBM-943CIBM-943C
> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
> Zh_TW   x-IBM950IBM-950 IBM-950
> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>
> Also I reviewed source code, it's fine
>
> Since this testing requires locale installation for Ja_JP and Zh_TW,
> so it's not easy to test it...
> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
> required)
>
>
> On 2018-05-02 18:32, Volker Simonis wrote:
>>
>> Hi Bhaktavatsal Reddy,
>>
>> your change looks good. I can sponsor it.
>>
>> Just waiting for a second review...
>>
>> Thank you and best regards,
>> Volker
>>
>>
>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>> <bhama...@in.ibm.com> wrote:
>>>
>>> Hi All,
>>>
>>> Please review the fix.
>>>
>>> bug: 
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=EObjWXMYLV3tP7TlWXJqeLzR7hJkCsURSqJDb0dSnTc=YRbmsm-yoh4kURT2ZktLR6ayWpHpmxdqdOrEFmmDqT4=
>>> webrev: 
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Ealeonard_8202329_webrev.00_=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=EObjWXMYLV3tP7TlWXJqeLzR7hJkCsURSqJDb0dSnTc=-9QkhLYlAZtChOxa4KOBBrycxbhYS8BfxdMahwSwjOw=
>>>
>>> Thanks,
>>> Bhaktavatsal Reddy
>>>
>>> -"core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> wrote:
>>> -
>>> To: Volker Simonis <volker.simo...@gmail.com>
>>> From: "Bhaktavatsal R Maram"
>>> Sent by: "core-libs-dev"
>>> Date: 04/26/2018 09:31PM
>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>
>>> Hi Volker,
>>>
>>> Thank you. I will address your review comments and send webrev for
>>> review.
>>>
>>> - Bhaktavatsal Reddy
>>>
>>>
>>>
>>> -Volker Simonis <volker.simo...@gmail.com> wrote: -
>>> To: Bhaktavatsal R Maram <bhama...@in.ibm.com>
>>> From: Volker Simonis <volker.simo...@gmail.com>
>>> Date: 04/26/2018 09:12PM
>>> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> I've opened the following issue for this problem:
>>>
>>> 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=iQCg2Acve4LeG-Zymt7gpXuSgJLFbCFHsSVHCETqGt8=3KL9rSzXZgjLGz-ayIEaq94QK5rTY0PlEgewOjarNPE=
>>>
>>> Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
>>> AIX" and the original "#else" by "#ifdef __solaris__". The original
>>> else branch contains Solaris-only code anyway and it is an historical
>>> omission that there are still a lot of places in the code where "not
>>

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-11 Thread Thomas Stüfe 
Hi,

I'll test and review next week. We also have some in-house tests which
I'd like to run.

You IBM folks should really apply for authorship so that this
contribution process gets streamlined. After all, if something breaks
in this code, you want to be able to fix it, yes? So even if you do
not contribute much else, more patches may be forthcoming.

Of course I hope these are not your last contributions :)

Best, Thomas



On Fri, May 11, 2018 at 7:57 AM, Ichiroh Takiguchi
 wrote:
> Hi.
>
> I tested this fix on AIX.
>
> I got following results.
> $ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
> Ja_JP   x-IBM943C   IBM-943CIBM-943C
> $ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
> Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
> $ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
> Zh_TW   x-IBM950IBM-950 IBM-950
> $ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
> Zh_TW.big5  x-IBM950IBM-950 IBM-950
>
> Also I reviewed source code, it's fine
>
> Since this testing requires locale installation for Ja_JP and Zh_TW,
> so it's not easy to test it...
> (At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are
> required)
>
>
> On 2018-05-02 18:32, Volker Simonis wrote:
>>
>> Hi Bhaktavatsal Reddy,
>>
>> your change looks good. I can sponsor it.
>>
>> Just waiting for a second review...
>>
>> Thank you and best regards,
>> Volker
>>
>>
>> On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
>>  wrote:
>>>
>>> Hi All,
>>>
>>> Please review the fix.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
>>> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>>>
>>> Thanks,
>>> Bhaktavatsal Reddy
>>>
>>> -"core-libs-dev"  wrote:
>>> -
>>> To: Volker Simonis 
>>> From: "Bhaktavatsal R Maram"
>>> Sent by: "core-libs-dev"
>>> Date: 04/26/2018 09:31PM
>>> Cc: Java Core Libs 
>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>
>>> Hi Volker,
>>>
>>> Thank you. I will address your review comments and send webrev for
>>> review.
>>>
>>> - Bhaktavatsal Reddy
>>>
>>>
>>>
>>> -Volker Simonis  wrote: -
>>> To: Bhaktavatsal R Maram 
>>> From: Volker Simonis 
>>> Date: 04/26/2018 09:12PM
>>> Cc: Java Core Libs 
>>> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>>
>>> Hi Bhaktavatsal Reddy,
>>>
>>> I've opened the following issue for this problem:
>>>
>>> 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=iQCg2Acve4LeG-Zymt7gpXuSgJLFbCFHsSVHCETqGt8=3KL9rSzXZgjLGz-ayIEaq94QK5rTY0PlEgewOjarNPE=
>>>
>>> Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
>>> AIX" and the original "#else" by "#ifdef __solaris__". The original
>>> else branch contains Solaris-only code anyway and it is an historical
>>> omission that there are still a lot of places in the code where "not
>>> Linux" implicitly means "Solaris", but that's often wrong.
>>>
>>> Regards,
>>> Volker
>>>
>>>
>>> On Thu, Apr 26, 2018 at 4:02 PM, Bhaktavatsal R Maram
>>>  wrote:

 Oops! Looks like there is problem with attachment (might be because I
 attached .class file as well). I'm pasting the fix and test program here in
 mail.

 Test Program:

 import java.nio.charset.*;
 class PrintDefaultCharset {
  public static void main(String[] args) {
 System.out.println("LANG = "+System.getenv("LANG"));
 System.out.println("Default charset =
 "+Charset.defaultCharset().name());
 System.out.println("file.encoding =
 "+System.getProperty("file.encoding"));
 System.out.println("sun.jnu.encoding =
 "+System.getProperty("sun.jnu.encoding"));
  }
 }


 Fix:

 diff --git a/src/java.base/unix/native/libjava/java_props_md.c
 b/src/java.base/unix/native/libjava/java_props_md.c
 --- a/src/java.base/unix/native/libjava/java_props_md.c
 +++ b/src/java.base/unix/native/libjava/java_props_md.c
 @@ -1,5 +1,5 @@
  /*
 - * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights
 reserved.
 + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights
 reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
 @@ -297,6 +297,18 @@
  if (strcmp(p, "EUC-JP") == 0) {
  *std_encoding = "EUC-JP-LINUX";
  }
 +#elif defined _AIX
 +

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-10 Thread Ichiroh Takiguchi 

Hi.

I tested this fix on AIX.

I got following results.
$ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
Ja_JP   x-IBM943C   IBM-943CIBM-943C
$ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
Ja_JP.IBM-943   x-IBM943C   IBM-943CIBM-943C
$ LANG=Zh_TW ~/jdk/bin/java PrintDefaultCharset
Zh_TW   x-IBM950IBM-950 IBM-950
$ LANG=Zh_TW.big5 ~/jdk/bin/java PrintDefaultCharset
Zh_TW.big5  x-IBM950IBM-950 IBM-950

Also I reviewed source code, it's fine

Since this testing requires locale installation for Ja_JP and Zh_TW,
so it's not easy to test it...
(At least, I think bos.loc.pc.Ja_JP and bos.loc.iso.Zh_TW filesets are 
required)


On 2018-05-02 18:32, Volker Simonis wrote:

Hi Bhaktavatsal Reddy,

your change looks good. I can sponsor it.

Just waiting for a second review...

Thank you and best regards,
Volker


On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
 wrote:

Hi All,

Please review the fix.

bug: https://bugs.openjdk.java.net/browse/JDK-8202329
webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/

Thanks,
Bhaktavatsal Reddy

-"core-libs-dev"  wrote: 
-

To: Volker Simonis 
From: "Bhaktavatsal R Maram"
Sent by: "core-libs-dev"
Date: 04/26/2018 09:31PM
Cc: Java Core Libs 
Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi Volker,

Thank you. I will address your review comments and send webrev for 
review.


- Bhaktavatsal Reddy



-Volker Simonis  wrote: -
To: Bhaktavatsal R Maram 
From: Volker Simonis 
Date: 04/26/2018 09:12PM
Cc: Java Core Libs 
Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi Bhaktavatsal Reddy,

I've opened the following issue for this problem:

8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=iQCg2Acve4LeG-Zymt7gpXuSgJLFbCFHsSVHCETqGt8=3KL9rSzXZgjLGz-ayIEaq94QK5rTY0PlEgewOjarNPE=

Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
AIX" and the original "#else" by "#ifdef __solaris__". The original
else branch contains Solaris-only code anyway and it is an historical
omission that there are still a lot of places in the code where "not
Linux" implicitly means "Solaris", but that's often wrong.

Regards,
Volker


On Thu, Apr 26, 2018 at 4:02 PM, Bhaktavatsal R Maram
 wrote:
Oops! Looks like there is problem with attachment (might be because I 
attached .class file as well). I'm pasting the fix and test program 
here in mail.


Test Program:

import java.nio.charset.*;
class PrintDefaultCharset {
 public static void main(String[] args) {
System.out.println("LANG = "+System.getenv("LANG"));
System.out.println("Default charset = 
"+Charset.defaultCharset().name());
System.out.println("file.encoding = 
"+System.getProperty("file.encoding"));
System.out.println("sun.jnu.encoding = 
"+System.getProperty("sun.jnu.encoding"));

 }
}


Fix:

diff --git a/src/java.base/unix/native/libjava/java_props_md.c 
b/src/java.base/unix/native/libjava/java_props_md.c

--- a/src/java.base/unix/native/libjava/java_props_md.c
+++ b/src/java.base/unix/native/libjava/java_props_md.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All 
rights reserved.
+ * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All 
rights reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify 
it

@@ -297,6 +297,18 @@
 if (strcmp(p, "EUC-JP") == 0) {
 *std_encoding = "EUC-JP-LINUX";
 }
+#elif defined _AIX
+if (strcmp(p, "big5") == 0) {
+/* On AIX Traditional Chinese Big5 codeset is mapped to 
IBM-950 */

+*std_encoding = "IBM-950";
+} else if (strcmp(p, "IBM-943") == 0) {
+/*
+ * On AIX, IBM-943 is mapped to IBM-943C in which symbol 
'yen' and
+ * 'overline' are replaced with 'backslash' and 'tilde' 
from ASCII

+ * making first 96 code points same as ASCII.
+ */
+*std_encoding = "IBM-943C";
+}
 #else
 if (strcmp(p,"eucJP") == 0) {
 /* For Solaris use customized vendor defined character


Thanks,
Bhaktavatsal Reddy


-"core-libs-dev"  wrote: 
-

To: "Java Core Libs" 
From: "Bhaktavatsal R Maram"
Sent by: "core-libs-dev"
Date: 04/26/2018 07:26PM
Subject: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi All,

This issue is continuation to bug

Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-05-02 Thread Volker Simonis 
Hi Bhaktavatsal Reddy,

your change looks good. I can sponsor it.

Just waiting for a second review...

Thank you and best regards,
Volker


On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
 wrote:
> Hi All,
>
> Please review the fix.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8202329
> webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
>
> Thanks,
> Bhaktavatsal Reddy
>
> -"core-libs-dev"  wrote: -
> To: Volker Simonis 
> From: "Bhaktavatsal R Maram"
> Sent by: "core-libs-dev"
> Date: 04/26/2018 09:31PM
> Cc: Java Core Libs 
> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>
> Hi Volker,
>
> Thank you. I will address your review comments and send webrev for review.
>
> - Bhaktavatsal Reddy
>
>
>
> -Volker Simonis  wrote: -
> To: Bhaktavatsal R Maram 
> From: Volker Simonis 
> Date: 04/26/2018 09:12PM
> Cc: Java Core Libs 
> Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>
> Hi Bhaktavatsal Reddy,
>
> I've opened the following issue for this problem:
>
> 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=iQCg2Acve4LeG-Zymt7gpXuSgJLFbCFHsSVHCETqGt8=3KL9rSzXZgjLGz-ayIEaq94QK5rTY0PlEgewOjarNPE=
>
> Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
> AIX" and the original "#else" by "#ifdef __solaris__". The original
> else branch contains Solaris-only code anyway and it is an historical
> omission that there are still a lot of places in the code where "not
> Linux" implicitly means "Solaris", but that's often wrong.
>
> Regards,
> Volker
>
>
> On Thu, Apr 26, 2018 at 4:02 PM, Bhaktavatsal R Maram
>  wrote:
>> Oops! Looks like there is problem with attachment (might be because I 
>> attached .class file as well). I'm pasting the fix and test program here in 
>> mail.
>>
>> Test Program:
>>
>> import java.nio.charset.*;
>> class PrintDefaultCharset {
>>  public static void main(String[] args) {
>> System.out.println("LANG = "+System.getenv("LANG"));
>> System.out.println("Default charset = 
>> "+Charset.defaultCharset().name());
>> System.out.println("file.encoding = 
>> "+System.getProperty("file.encoding"));
>> System.out.println("sun.jnu.encoding = 
>> "+System.getProperty("sun.jnu.encoding"));
>>  }
>> }
>>
>>
>> Fix:
>>
>> diff --git a/src/java.base/unix/native/libjava/java_props_md.c 
>> b/src/java.base/unix/native/libjava/java_props_md.c
>> --- a/src/java.base/unix/native/libjava/java_props_md.c
>> +++ b/src/java.base/unix/native/libjava/java_props_md.c
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights 
>> reserved.
>> + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights 
>> reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -297,6 +297,18 @@
>>  if (strcmp(p, "EUC-JP") == 0) {
>>  *std_encoding = "EUC-JP-LINUX";
>>  }
>> +#elif defined _AIX
>> +if (strcmp(p, "big5") == 0) {
>> +/* On AIX Traditional Chinese Big5 codeset is mapped to IBM-950 
>> */
>> +*std_encoding = "IBM-950";
>> +} else if (strcmp(p, "IBM-943") == 0) {
>> +/*
>> + * On AIX, IBM-943 is mapped to IBM-943C in which symbol 'yen' 
>> and
>> + * 'overline' are replaced with 'backslash' and 'tilde' from 
>> ASCII
>> + * making first 96 code points same as ASCII.
>> + */
>> +*std_encoding = "IBM-943C";
>> +}
>>  #else
>>  if (strcmp(p,"eucJP") == 0) {
>>  /* For Solaris use customized vendor defined character
>>
>>
>> Thanks,
>> Bhaktavatsal Reddy
>>
>>
>> -"core-libs-dev"  wrote: -
>> To: "Java Core Libs" 
>> From: "Bhaktavatsal R Maram"
>> Sent by: "core-libs-dev"
>> Date: 04/26/2018 07:26PM
>> Subject: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>>
>> Hi All,
>>
>> This issue is continuation to bug 8201540 (Extend the set of supported 
>> charsets in java.base on AIX) in which we have moved default charsets of 
>> most of the locales supported by Operating System to java.base module thus 
>> enabling OpenJDK on those locales for AIX platform.
>>
>> As part of that, charsets for locales Ja_JP (IBM-943) and Zh_TW (big5) also 
>> have been moved. However, corresponding charsets mapped in Java is not 
>> correct for them on AIX. Following are

RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5

2018-04-30 Thread Bhaktavatsal R Maram 
Hi All,

Please review the fix.

bug: https://bugs.openjdk.java.net/browse/JDK-8202329
webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/

Thanks,
Bhaktavatsal Reddy  

-"core-libs-dev"  wrote: -
To: Volker Simonis 
From: "Bhaktavatsal R Maram" 
Sent by: "core-libs-dev" 
Date: 04/26/2018 09:31PM
Cc: Java Core Libs 
Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi Volker,

Thank you. I will address your review comments and send webrev for review.

- Bhaktavatsal Reddy 

  

-Volker Simonis  wrote: -
To: Bhaktavatsal R Maram 
From: Volker Simonis 
Date: 04/26/2018 09:12PM
Cc: Java Core Libs 
Subject: Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi Bhaktavatsal Reddy,

I've opened the following issue for this problem:

8202329: [AIX] Fix codepage mappings for IBM-943 and Big5
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202329=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg=iQCg2Acve4LeG-Zymt7gpXuSgJLFbCFHsSVHCETqGt8=3KL9rSzXZgjLGz-ayIEaq94QK5rTY0PlEgewOjarNPE=

Looking at you fix, can you please replace the "#elif AIX" by "#ifdef
AIX" and the original "#else" by "#ifdef __solaris__". The original
else branch contains Solaris-only code anyway and it is an historical
omission that there are still a lot of places in the code where "not
Linux" implicitly means "Solaris", but that's often wrong.

Regards,
Volker


On Thu, Apr 26, 2018 at 4:02 PM, Bhaktavatsal R Maram
 wrote:
> Oops! Looks like there is problem with attachment (might be because I 
> attached .class file as well). I'm pasting the fix and test program here in 
> mail.
>
> Test Program:
>
> import java.nio.charset.*;
> class PrintDefaultCharset {
>  public static void main(String[] args) {
> System.out.println("LANG = "+System.getenv("LANG"));
> System.out.println("Default charset = 
> "+Charset.defaultCharset().name());
> System.out.println("file.encoding = 
> "+System.getProperty("file.encoding"));
> System.out.println("sun.jnu.encoding = 
> "+System.getProperty("sun.jnu.encoding"));
>  }
> }
>
>
> Fix:
>
> diff --git a/src/java.base/unix/native/libjava/java_props_md.c 
> b/src/java.base/unix/native/libjava/java_props_md.c
> --- a/src/java.base/unix/native/libjava/java_props_md.c
> +++ b/src/java.base/unix/native/libjava/java_props_md.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -297,6 +297,18 @@
>  if (strcmp(p, "EUC-JP") == 0) {
>  *std_encoding = "EUC-JP-LINUX";
>  }
> +#elif defined _AIX
> +if (strcmp(p, "big5") == 0) {
> +/* On AIX Traditional Chinese Big5 codeset is mapped to IBM-950 
> */
> +*std_encoding = "IBM-950";
> +} else if (strcmp(p, "IBM-943") == 0) {
> +/*
> + * On AIX, IBM-943 is mapped to IBM-943C in which symbol 'yen' 
> and
> + * 'overline' are replaced with 'backslash' and 'tilde' from 
> ASCII
> + * making first 96 code points same as ASCII.
> + */
> +*std_encoding = "IBM-943C";
> +}
>  #else
>  if (strcmp(p,"eucJP") == 0) {
>  /* For Solaris use customized vendor defined character
>
>
> Thanks,
> Bhaktavatsal Reddy
>
>
> -"core-libs-dev"  wrote: -
> To: "Java Core Libs" 
> From: "Bhaktavatsal R Maram"
> Sent by: "core-libs-dev"
> Date: 04/26/2018 07:26PM
> Subject: [AIX] Fix codepage mappings in Java for IBM-943 and Big5
>
> Hi All,
>
> This issue is continuation to bug 8201540 (Extend the set of supported 
> charsets in java.base on AIX) in which we have moved default charsets of most 
> of the locales supported by Operating System to java.base module thus 
> enabling OpenJDK on those locales for AIX platform.
>
> As part of that, charsets for locales Ja_JP (IBM-943) and Zh_TW (big5) also 
> have been moved. However, corresponding charsets mapped in Java is not 
> correct for them on AIX. Following are the details:
>
> 1. IBM-943 [1] for locale Ja_JP should be mapped to IBM-943C [2]
>
> Fundamental difference between IBM-943 and IBM-943C is that IBM-943C is ASCII 
> compatible which means code points 'yen' and 'overline' of IBM-943 is 
> replaced with 'backslash' and 'tilde' from ASCII character set.
>
>
> 2. Big5 for locale Zh_TW should be mapped to IBM-950 [3]
>
> I've attached