Re: RFR: 8284444: Sting typo [v2]
On Wed, 6 Apr 2022 16:48:38 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63: >> >>> 61: * http://www.ietf.org/rfc/rfc3454.txt;>RFC 3454. >>> 62: * StringPrep prepares Unicode strings for use in network protocols. >>> 63: * Profiles of StringPrep are set of rules and data according to which >>> the >> >> These also come from the upstream ICU4J project and should be corrected >> there. >> https://github.com/unicode-org/icu/blob/4833cc89b2fae2e8863b46bf1dc785964847e882/icu4j/main/classes/core/src/com/ibm/icu/text/StringPrep.java#L27 > > Thanks, reverted. Also reverted Xalan changes. Good. Thanks for reverting it. - PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v2]
On Wed, 6 Apr 2022 15:49:06 GMT, Naoto Sato wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert liblcms changes > > src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63: > >> 61: * http://www.ietf.org/rfc/rfc3454.txt;>RFC 3454. >> 62: * StringPrep prepares Unicode strings for use in network protocols. >> 63: * Profiles of StringPrep are set of rules and data according to which >> the > > These also come from the upstream ICU4J project and should be corrected there. > https://github.com/unicode-org/icu/blob/4833cc89b2fae2e8863b46bf1dc785964847e882/icu4j/main/classes/core/src/com/ibm/icu/text/StringPrep.java#L27 Thanks, reverted. Also reverted Xalan changes. - PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v2]
On Wed, 6 Apr 2022 14:12:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Revert liblcms changes src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63: > 61: * http://www.ietf.org/rfc/rfc3454.txt;>RFC 3454. > 62: * StringPrep prepares Unicode strings for use in network protocols. > 63: * Profiles of StringPrep are set of rules and data according to which the These also come from the upstream ICU4J project and should be corrected there. https://github.com/unicode-org/icu/blob/4833cc89b2fae2e8863b46bf1dc785964847e882/icu4j/main/classes/core/src/com/ibm/icu/text/StringPrep.java#L27 - PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v2]
On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert liblcms changes
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
> line 63:
>
>> 61: message.creating-association-with-null-extension=Creating association
>> with null extension.
>> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2} is
>> required.
>> 63: message.version-string-too-many-components=Version string may have up to
>> 3 components - major.minor.build .
>
> I wonder whether the space before the period is required at the end of the
> sentence. Perhaps, it's to separate a property name from the end of the
> sentence.
right; without the space the period would appear to be part of the version
pattern.
-
PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v2]
> This patch adds missing `r` in `string`s Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Revert liblcms changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/8125/files - new: https://git.openjdk.java.net/jdk/pull/8125/files/755c7084..68ce6ebd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8125=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8125=00-01 Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk/pull/8125.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8125/head:pull/8125 PR: https://git.openjdk.java.net/jdk/pull/8125
