Re: RFR JDK-8186751: Add ISO-8859-16 Charset support

2017-09-01 Thread Florent Guillaume
Hi,

>From https://www.cs.tut.fi/~jkorpela/latin9.html:

> Originally (http://www.indigo.ie/egt/standards/iso8859/latin00.html) the
project
> which lead to the creation of ISO Latin 9 used the working name "Latin
Alphabet
> Number Zero" for it. Therefore it has often been referred to as "Latin 0".

I don't think it should be included in the aliases.

Florent

On Fri, Sep 1, 2017 at 8:22 PM, Ulf Zibis  wrote:

> Hi again,
>
> Am 31.08.2017 um 23:29 schrieb Xueming Shen:
>
> The 8859-16 aliases are the copy/paste from
> https://www.iana.org/assignments/character-sets/character-sets.xhtml
>
> From the same page we have the followings for 8859-15
> ISO_8859-15
> Latin-9
> csISO885915
>
> It appears only the first one is listed in our alias list (explicitly
> commented).
> Don't have the memory for the history (8859-15 was added a long time ago),
> not sure whether the other two were missed at the very beginning or were
> added later in the iana. Since we are here, I added them in.
>
>
> Fine!
>
> http://cr.openjdk.java.net/~sherman/8186751/webrev
> (the old one is copied to webrev.00)
>
>
> - I think, the comment should now be in plural: # IANA alias
> *es *- Also I think, it would make sense to at least add "ISO8859-16" and
> "ISO8859_16" as # Other aliases
> - "ISO-8859-15" must not be listed as alias, as it already is the
> canonical name.
> - Not sure, where "LATIN0" and "csISOlatin0" come from.
>
> -Ulf
>
>


-- 
[image: Nuxeo]

Florent Guillaume
Head of R&D

Twitter: @efge


Re: RFR JDK-8186751: Add ISO-8859-16 Charset support

2017-09-01 Thread Ulf Zibis

Hi again,


Am 31.08.2017 um 23:29 schrieb Xueming Shen:

The 8859-16 aliases are the copy/paste from
https://www.iana.org/assignments/character-sets/character-sets.xhtml

From the same page we have the followings for 8859-15
ISO_8859-15
Latin-9
csISO885915

It appears only the first one is listed in our alias list (explicitly 
commented).

Don't have the memory for the history (8859-15 was added a long time ago),
not sure whether the other two were missed at the very beginning or were
added later in the iana. Since we are here, I added them in.


Fine!


http://cr.openjdk.java.net/~sherman/8186751/webrev
(the old one is copied to webrev.00)


- I think, the comment should now be in plural: # IANA alias*es
*- Also I think, it would make sense to at least add "ISO8859-16" and 
"ISO8859_16" as # Other aliases
- "ISO-8859-15" must not be listed as alias, as it already is the 
canonical name.

- Not sure, where "LATIN0" and "csISOlatin0" come from.

-Ulf



Re: RFR JDK-8186751: Add ISO-8859-16 Charset support

2017-09-01 Thread Alan Bateman



On 31/08/2017 03:14, Xueming Shen wrote:

Hi,

Please help review the changeset to add the 8859_1 charset support.

issue: https://bugs.openjdk.java.net/browse/JDK-8186751
webrev: http://cr.openjdk.java.net/~sherman/8186751/webrev

Looks good.

-Alan