Re: [Crosswalk-dev] GN and Crosswalk: status update and plans

[Raphael Kubo da Costa]

Raphael Kubo da Costa  writes:

> Here's what we have in mind for the next steps:
> * Before moving Crosswalk 23 (master) to M53:
>   - Finish the Linux porting work.
>   - Port Android to GN _before_ moving to M53 (otherwise we'll need to
> carry our own patches making gyp work in chromium-crosswalk).
>   - Add a few Buildbot slaves building Crosswalk with GN in parallel
> with the existing ones, so that we know building with both build
> systems is working.

We are here.

> * After moving Crosswalk 23 to M53:
>   - Stop supporting gyp on Android and Linux.
>   - Switch our Android and Linux Buildbot slaves to GN and drop gyp from
> them.
>   - Investigate whether Windows is in good shape for the migration or
> whether we will need to wait for M54 to port it.

Linux and Android support in GN are both done and (hopefully) working. I
intend to switch our Android and Linux canary builds to GN today to
catch any regressions as early as possible. I will send a separate email
recommending everyone switch to GN.
___
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

Re: [Crosswalk-dev] GN and Crosswalk: status update and plans

[Raphael Kubo da Costa]

Raphael Kubo da Costa  writes:

> Here's what we have in mind for the next steps:
> * Before moving Crosswalk 23 (master) to M53:
>   - Finish the Linux porting work.
>   - Port Android to GN _before_ moving to M53 (otherwise we'll need to
> carry our own patches making gyp work in chromium-crosswalk).
>   - Add a few Buildbot slaves building Crosswalk with GN in parallel
> with the existing ones, so that we know building with both build
> systems is working.
> * After moving Crosswalk 23 to M53:
>   - Stop supporting gyp on Android and Linux.
>   - Switch our Android and Linux Buildbot slaves to GN and drop gyp from
> them.
>   - Investigate whether Windows is in good shape for the migration or
> whether we will need to wait for M54 to port it.

We landed initial support for building Crosswalk Android with GN earlier
today, and I added some Android GN bots to our waterfalls a few hours
ago.

Pretty much all targets from gyp are there, except for the ones in
xwalk_core_library_android.gypi (which is being a nightmare to port).
This means it's not possible to create apps with app-tools because we
are not creating the app template yet, but building the "xwalk_builder"
generates all the APKs we need to run our device tests.

I have also rebased our "next" branch (tracking Chromium 53) on top of
our latest master to inherit all those GN changes. This has led to a few
more pull requests being sent to master (which I've temporarily
cherry-picked into next), but it is now possible to call "gn gen" and
generate an Android build on next.

People wanting to try out Android + GN (documentation on the website is
coming soon):

cd /path/to/src
gn args out/Release

  a text editor will pop up and you should enter the following:
  import("//xwalk/build/android.gni")
  target_os = "android"
  target_cpu = "x86"  # or "x64", or "arm" etc
  is_debug = false  # unless you want a debug build

That should be enough to call gn gen automatically, after which you can
use ninja as usual.
___
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

Re: [Crosswalk-dev] GN and Crosswalk: status update and plans

[Raphael Kubo da Costa]

"Kapade, Mrunal"  writes:

> It's great to hear this is finally landing in the master.
> Can you also make sure the documentation on our website is updated with 
> appropriate GN config?
> Especially this page, 
> https://crosswalk-project.org/contribute/building_crosswalk.html and other 
> related pages.

I'm basically just waiting for the Android GN code to land to make sure
everything is stable before updating the build instructions.

If you are feeling adventurous, here's what you need to do:
* Set the GYP_CHROMIUM_NO_ACTION environment variable to 1.
  It makes sure gyp_xwalk does not run as part of our hooks.
* cd /path/to/src
* gn gen --args='import("//xwalk/build/linux.gni") is_debug=false' //out/Release
  OR
  gn args //out/Release
  (and type import("//xwalk/build/linux.gni") and other arguments there)
* Run ninja as usual.

GN is also run automatically when you change any BUILD.gn or *.gni file,
so you don't have to manually invoke a script to regenerate your ninja
files every time you change the build system as is the case with gyp.
___
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

Re: [Crosswalk-dev] GN and Crosswalk: status update and plans

[Kapade, Mrunal]

It's great to hear this is finally landing in the master.
Can you also make sure the documentation on our website is updated with 
appropriate GN config? 
Especially this page, 
https://crosswalk-project.org/contribute/building_crosswalk.html and other 
related pages.

Mrunal

From: Crosswalk-dev [crosswalk-dev-boun...@lists.crosswalk-project.org] on 
behalf of Raphael Kubo da Costa [raphael.kubo.da.co...@intel.com]
Sent: Friday, August 26, 2016 4:35 AM
To: crosswalk-dev@lists.crosswalk-project.org
Subject: [Crosswalk-dev] GN and Crosswalk: status update and plans

Hi, everyone,

Ke He and I have been working on porting Crosswalk to GN, Chromium's
(not so) new build system. gyp has been on the deprecation path for a
few releases now, and things are getting more serious with the most
recent Chromium milestones: IIRC, Android and Linux are using GN by
default starting with M53 (Android does not even seem to build by
default with gyp in M53, and gyp_chromium.py is no longer run
automatically in those platforms), and in M54 gyp is also not officially
supported on Windows and Mac. [1][2]

[1] 
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/PaDTGJFkUnk/llV3sJnTPgAJ
[2] 
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/NZkPr-CXvQ0/dn1rb8E8CAAJ

So far, we've recently landed (as in "a few hours ago") some patches
laying the groundwork in chromium-crosswalk and crosswalk, and it is now
possible to build Crosswalk for Linux on GN (with some missing features,
such as Web Notifications and our Debian package generator).

Here's what we have in mind for the next steps:
* Before moving Crosswalk 23 (master) to M53:
  - Finish the Linux porting work.
  - Port Android to GN _before_ moving to M53 (otherwise we'll need to
carry our own patches making gyp work in chromium-crosswalk).
  - Add a few Buildbot slaves building Crosswalk with GN in parallel
with the existing ones, so that we know building with both build
systems is working.
* After moving Crosswalk 23 to M53:
  - Stop supporting gyp on Android and Linux.
  - Switch our Android and Linux Buildbot slaves to GN and drop gyp from
them.
  - Investigate whether Windows is in good shape for the migration or
whether we will need to wait for M54 to port it.
___
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
___
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

[Crosswalk-dev] GN and Crosswalk: status update and plans

[Raphael Kubo da Costa]

Hi, everyone,

Ke He and I have been working on porting Crosswalk to GN, Chromium's
(not so) new build system. gyp has been on the deprecation path for a
few releases now, and things are getting more serious with the most
recent Chromium milestones: IIRC, Android and Linux are using GN by
default starting with M53 (Android does not even seem to build by
default with gyp in M53, and gyp_chromium.py is no longer run
automatically in those platforms), and in M54 gyp is also not officially
supported on Windows and Mac. [1][2]

[1] 
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/PaDTGJFkUnk/llV3sJnTPgAJ
[2] 
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/NZkPr-CXvQ0/dn1rb8E8CAAJ

So far, we've recently landed (as in "a few hours ago") some patches
laying the groundwork in chromium-crosswalk and crosswalk, and it is now
possible to build Crosswalk for Linux on GN (with some missing features,
such as Web Notifications and our Debian package generator).

Here's what we have in mind for the next steps:
* Before moving Crosswalk 23 (master) to M53:
  - Finish the Linux porting work.
  - Port Android to GN _before_ moving to M53 (otherwise we'll need to
carry our own patches making gyp work in chromium-crosswalk).
  - Add a few Buildbot slaves building Crosswalk with GN in parallel
with the existing ones, so that we know building with both build
systems is working.
* After moving Crosswalk 23 to M53:
  - Stop supporting gyp on Android and Linux.
  - Switch our Android and Linux Buildbot slaves to GN and drop gyp from
them.
  - Investigate whether Windows is in good shape for the migration or
whether we will need to wait for M54 to port it.
___
Crosswalk-dev mailing list
Crosswalk-dev@lists.crosswalk-project.org
https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev