Re: Perl 5.13.3+ MAY BREAK COMPILED DRIVERS - Please test DBI 1.613_71!

2010-08-27 Thread Darren Duncan

Tim Bunce wrote [to dbi-dev]:

Short version:

Please download build test *and install* DBI 1.613_71, then download build
and test any compiled drivers you use to check they work with DBI 1.613_71.

Let us know about any failures *and* successes.

Also grep the source code of the driver to see if it defines
PERL_POLUTE. If it does, let us know.

Long version:

Perl 5.13.3+ removes support for PERL_POLUTE. PERL_POLUTE enables use of
old-style variables names, without the PL_ prefix (e.g. sv_undef instead
of PL_sv_undef).

The DBI has, for many years, enabled PERL_POLUTE mode in DBIXS.h, so
it's likely that compiled drivers are use some old-style variables names.
These drivers won't work with Perl 5.13.3+.

To aid testing for this, the DBI 1.613_71 doesn't enabled PERL_POLUTE mode.

So please test compiled drivers against DBI 1.613_71.


I didn't try to build them with DBI 1.613_71, but I did a grep search for 
PERL_POLLUTE in the latest CPAN versions of DBD-SQLite and DBD-Pg.


* DBD-SQLite-1.30_05 *does* #define PERL_POLLUTE, once in SQLiteXS.h

* DBD-Pg-2.17.1 does not have any PERL_POLLUTE

Obviously, then, DBD::SQLite will need an update to fix this problem, though it 
sounds like the fix should be some relatively simple symbol renaming.


I could probably do this, but not until at least a few days from now when I have 
more time to do that *and* test it.


-- Darren Duncan


Re: Perl 5.13.3+ MAY BREAK COMPILED DRIVERS - Please test DBI 1.613_71!

2010-08-27 Thread Tim Bunce
On Fri, Aug 27, 2010 at 09:53:09PM +0100, Tim Bunce wrote:
> 
> Perl 5.13.3+ removes support for PERL_POLUTE. [...]

[Sigh]  s/PERL_POLUTE/PERL_POLLUTE/g

Tim [a little too much wine with friends this evening me'thinks]


Perl 5.13.3+ MAY BREAK COMPILED DRIVERS - Please test DBI 1.613_71!

2010-08-27 Thread Tim Bunce
Short version:

Please download build test *and install* DBI 1.613_71, then download build
and test any compiled drivers you use to check they work with DBI 1.613_71.

Let us know about any failures *and* successes.

Also grep the source code of the driver to see if it defines
PERL_POLUTE. If it does, let us know.

Long version:

Perl 5.13.3+ removes support for PERL_POLUTE. PERL_POLUTE enables use of
old-style variables names, without the PL_ prefix (e.g. sv_undef instead
of PL_sv_undef).

The DBI has, for many years, enabled PERL_POLUTE mode in DBIXS.h, so
it's likely that compiled drivers are use some old-style variables names.
These drivers won't work with Perl 5.13.3+.

To aid testing for this, the DBI 1.613_71 doesn't enabled PERL_POLUTE mode.

So please test compiled drivers against DBI 1.613_71.

Thanks!

Tim.


Re: ANNOUNCE: DBD::Oracle 1.25 Release Candidate

2010-08-27 Thread John Scoles

Martin J. Evans wrote:
Rather than blasting out a whole new RC for this can you make this quick 
fix to


ocitrace.h

#define OCILobLocatorIsInit_log_stat(envhp,errhp,loc,is_initp,stat)\
--stat =OCILobLocatorIsInit (envhp,errhp,loc,is_init );\
++stat =OCILobLocatorIsInit (envhp,errhp,loc,is_initp );\

Hopefully that will get it

Cheers
John Scoles
  



John Scoles wrote:
  

Well story two of the  'two bit' version of DBD::Oracle 1.25

You can find release candidate 2 here

http://svn.perl.org/modules/dbd-oracle/trunk/DBD-Oracle-1.25-RC2.tar.gz

This one has some minor changes from Martin Evans, though I could not
find any issues with the Makfile.PL myself.
and hopefully I got rid of the warning error in the .xs file for
OCILobLocatorIsInit_log_stat

And of course the usual bunch of POD changes.

Cheers
John Scoles

--
New! Learn why & how to love your data with Pythian's new webinar  series.
Topics, details & register: http://www.pythian.com/webinars




Sorry for taking so long to try this RC.

The gzipped tar file you reference appears to be doubly gzipped BTW.

OCILobLocatorIsInit problem still seems to exist for me:

cc -c  -I/home/oracle/instantclient_11_1//sdk/include
-I/usr/local/lib/perl/5.10.0/auto/DBI -D_REENTRANT -D_GNU_SOURCE
-DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g   -DVERSION=\"1.25\"
-DXS_VERSION=\"1.25\" -fPIC "-I/usr/lib/perl/5.10/CORE"  -Wall
-Wno-comment -DUTF8_SUPPORT -DORA_OCI_VERSION=\"11.1.0.6\" -DORA_OCI_102
Oracle.c
Oracle.xs: In function ‘XS_DBD__Oracle__db_ora_lob_is_init’:
Oracle.xs:486: warning: passing argument 4 of ‘OCILobLocatorIsInit’
makes pointer from integer without a cast
/home/oracle/instantclient_11_1//sdk/include/ociap.h:7297: note:
expected ‘boolean *’ but argument is of type ‘boolean’

Other than the usual 26exe_array test this seems to work ok here.

Hope you enjoyed YAPC::EU 2010.

Martin
  




Re: DBD::Oracle DRCP_1.25

2010-08-27 Thread Cliff Martin
On Jul 6, 7:36 am, sco...@pythian.com (John Scoles) wrote:
>
> Gee didn't know anyone else was even interested in DRCP.  good to see
> there is some interest


I know this post is more than a month old, but I am very excited about
this. I just found that DBD::Oracle 1.2.5 was nearly ready. I have
been looking forward to DRCP support for awhile now. We have Oracle
11.1 and 11.2 running on HP-UX with Perl 5.10, and we have a
production app that makes thousands of connections a day using Perl
(and a web interface in PHP that does the same thing, but it has
pooling there.)

Anyway, I am looking forward to getting this onto our test system, and
trying it out.

Thanks for all your hard work.

--
Cliff