Re: [patch] kfreebsd-i386 kernel udeb: fix ABI and fix dependency version
On Thu, Jul 16, 2009 at 11:47:18AM +0200, Luca Favatella wrote: This patch fixes in the kfreebsd-i386 kernel udeb * ABI (see also [0]) * a dependency version Sorry for writing one patch and one mail for two fixes, but I decided to do so because the fixes are very simple. Looks fine; OK to commit. -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb: fix ABI and fix dependency version
On 17/07/2009, Colin Watson cjwat...@debian.org wrote: On Thu, Jul 16, 2009 at 11:47:18AM +0200, Luca Favatella wrote: This patch fixes in the kfreebsd-i386 kernel udeb * ABI (see also [0]) * a dependency version Sorry for writing one patch and one mail for two fixes, but I decided to do so because the fixes are very simple. Looks fine; OK to commit. Committed to trunk. Thanks, Luca Favatella -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
[patch] kfreebsd-i386 kernel udeb: fix ABI and fix dependency version
This patch fixes in the kfreebsd-i386 kernel udeb * ABI (see also [0]) * a dependency version Sorry for writing one patch and one mail for two fixes, but I decided to do so because the fixes are very simple. Cheers, Luca Favatella [0] http://lists.debian.org/debian-boot/2009/07/msg00346.html Index: kfreebsd-kernel-di-i386/debian/control.stub === --- kfreebsd-kernel-di-i386/debian/control.stub (.../trunk/packages/kernel) (revision 59351) +++ kfreebsd-kernel-di-i386/debian/control.stub (.../branches/d-i/kfreebsd/packages/kernel) (revision 59363) @@ -3,4 +3,4 @@ Priority: optional Maintainer: Debian Install System Team debian-boot@lists.debian.org Uploaders: Otavio Salvador ota...@debian.org -Build-Depends: kernel-wedge (= 2.22) +Build-Depends: kernel-wedge (= 2.59) Index: kfreebsd-kernel-di-i386/kernel-versions === --- kfreebsd-kernel-di-i386/kernel-versions (.../trunk/packages/kernel) (revision 59351) +++ kfreebsd-kernel-di-i386/kernel-versions (.../branches/d-i/kfreebsd/packages/kernel) (revision 59363) @@ -1,2 +1,2 @@ # arch version flavour installedname suffix build-depends -kfreebsd-i386 7.2-2 486 7.2-1-486 - kfreebsd-image-7.2-1-486 +kfreebsd-i386 7.2-1 486 7.2-1-486 - kfreebsd-image-7.2-1-486
Re: [patch] kfreebsd-i386 kernel udeb
On Tuesday 23 June 2009, Frans Pop wrote: Also, the proposed kfreebsd-i386 file *is* different from all existing ones (did you even see that?). I don't know why, but that would at least have to be carefully checked. IMO it's not reasonable to dump that on Luca, especially as he has minimal experience with kernel-wedge yet. I just see that this is not relevant as kfreebsd uses a different tree within k-w than linux. I'd already started wondering why k-w could be used at all for a totally different kernel without modification, but that is because support was already added in 2006 (#365074). Still, the basic argument remains the same: the current definition inside the udeb itself is consistent with what's currently done for Linux and I really don't see any maintenance cost associated with it. In fact, given that apparently apparently no changes are needed in k-w at all even though it reflects a kfreebsd kernel from *2006* kind of indicates it'slikely hardly any maintenance will be needed... If only the Linux kernel were that stable :-P -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
Hello Frans, On Tue, Jun 23, 2009 at 2:34 AM, Frans Popelen...@planet.nl wrote: IMO this is making a change for absolutely NO measurable gain at all. It is also pushing work towards someone who has other goals than what you are asking him to do, making his work needlessly complicated (as the change would have to be a separate patch) and there is absolutely ZERO benefit to kfreebsd-i386. I disagree. I think we could merge the code in trunk also to make the kfreebsd branch as small as possible and reduce the work for maintainence POV from their developers (Aurien and Luca ATM). Doing it with a know possible improvement is non-sense IMO. I prefer if Luca could fix it and get it ready so we can merge it in trunk and make the branch smaller. It doesn't hurt either sides and allow us to keep it going. desire Please disable your sarcasm mode off. /desire -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
On Tuesday 23 June 2009, Otavio Salvador wrote: I think we could merge the code in trunk also to make the kfreebsd branch as small as possible and reduce the work for maintainence POV from their developers (Aurien and Luca ATM). Doing it with a know possible improvement is non-sense IMO. That is not at all what I was talking about! I now see that I probably misunderstood but that's really your own fault. Please look at your mail again: On Mon, Jun 22, 2009 at 3:44 PM, Otavio Salvador wrote: Good work; IMO the best way of doing it is to moving it to kernel-wedge to make the work for other arches easier in future and avoid duplication. The only thing that could be done in kernel-wedge is the ntfs one that you could fix it now and use it in the package. There's no reason to let it to later since it will make your life easier. There is *absolutely nothing* there that should have made me understand the last sentence is about merging the patch into trunk! And all 3 sentences are about the worst English I've ever seen from you. Your English is much better than this. I understood that as a demand to move the specification of the ntfs modules to kernel-wedge. That *is* mostly useless and for no gain. moving it to kernel-wedge is a completely wrong description for committing this patch to trunk: - the patch introduces no changes in kernel-wedge at all - there is no move to k-w as there was not some other method that was used before - the packages/kernel directory does not only contain k-w so again nothing is moved to k-w; at best it is moved to packages/kernel If you had said something like move the new udeb to trunk or commit this patch to trunk, then it would have been clear what you were talking about and I would not have replied, simply because I agree with that. So, I apologize for my sarcastic comments because what I was replied to was not what you meant, but *please* spend a bit more time on your mails before you send them so that such misunderstandings can be avoided. Cheers, FJP -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
[sorry for the double mail, I forgot to cc the list] On 23/06/2009, Otavio Salvador ota...@ossystems.com.br wrote: [...] I prefer if Luca could fix it and get it ready so we can merge it in trunk and make the branch smaller. It doesn't hurt either sides and allow us to keep it going. Done in version 4 attached. Index: packages/kernel/kfreebsd-kernel-di-i386/debian/changelog === --- packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1,6 @@ +kfreebsd-kernel-di-i386 (0.1) UNRELEASED; urgency=low + + [ Luca Favatella ] + * Initial version, based on earlier work by Robert Millan. + + -- Robert Millan r...@aybabtu.com Thu, 27 Apr 2006 20:50:53 +0200 Index: packages/kernel/kfreebsd-kernel-di-i386/debian/copyright === --- packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1,5 @@ +This package is Copyright (c) 2006 Robert Millan r...@aybabtu.com and +Copyright 2009 by Luca Favatella slacky...@gmail.org. + +It is licensed under the terms of the GNU GPL, see +/usr/share/common-licenses/GPL Index: packages/kernel/kfreebsd-kernel-di-i386/debian/rules === --- packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1,2 @@ +#!/usr/bin/make -f +include /usr/share/kernel-wedge/generic-rules Property changes on: packages/kernel/kfreebsd-kernel-di-i386/debian/rules ___ Added: svn:executable + * Index: packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub === --- packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1,6 @@ +Source: kfreebsd-kernel-di-i386 +Section: debian-installer +Priority: optional +Maintainer: Debian Install System Team debian-boot@lists.debian.org +Uploaders: Otavio Salvador ota...@debian.org +Build-Depends: kernel-wedge (= 2.22) Index: packages/kernel/kfreebsd-kernel-di-i386/package-list === --- packages/kernel/kfreebsd-kernel-di-i386/package-list (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/package-list (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1,29 @@ +# This file is used to build up the control file. The kernel version and +# -di are appended to the package names. Section can be left out. So can +# architecture, which is derived from the files in the modules directory. +# It overwrites specifications from /usr/share/kernel-wedge/package-list. +# +Package: kernel-image +Depends: acpi-modules +Provides: ufs-modules + +Package: fat-modules +Priority: standard + +Package: nic-modules +Depends: kernel-image, nic-shared-modules, firmware-modules, firewire-core-modules + +Package: scsi-modules +Depends: kernel-image, isa-pnp-modules, scsi-core-modules, parport-modules, cdrom-core-modules, firmware-modules + +Package: nic-extra-modules +Depends: kernel-image, isa-pnp-modules, nic-shared-modules, firmware-modules, crc-modules + +Package: nic-usb-modules +Depends: kernel-image, nic-shared-modules, usb-modules, firmware-modules + +Package: ppp-modules +Depends: serial-modules, kernel-image, crc-modules + +Package: pcmcia-modules +Depends: kernel-image, isa-pnp-modules, firmware-modules Index: packages/kernel/kfreebsd-kernel-di-i386/kernel-versions === --- packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1,2 @@ +# arch version flavour installedname suffix build-depends +kfreebsd-i386 7.2-2 486 7.2-1-486 - kfreebsd-image-7.2-1-486 Index: packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules === --- packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules (.../branches/d-i/kfreebsd) (revision 59046) @@ -0,0 +1 @@ +#include kfreebsd/floppy-modules Index: packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/loop-modules === ---
Re: [patch] kfreebsd-i386 kernel udeb
Hello Luca, Please commit them on trunk since both looks OK from my POV. On Tue, Jun 23, 2009 at 8:30 AM, Luca Favatellaslacky...@gmail.com wrote: [sorry for the double mail, I forgot to cc the list] On 23/06/2009, Otavio Salvador ota...@ossystems.com.br wrote: [...] I prefer if Luca could fix it and get it ready so we can merge it in trunk and make the branch smaller. It doesn't hurt either sides and allow us to keep it going. Done in version 4 attached. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
On 23/06/2009, Otavio Salvador ota...@ossystems.com.br wrote: Hello Luca, Please commit them on trunk since both looks OK from my POV. Ok, thanks. -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
[patch] kfreebsd-i386 kernel udeb
This patch (against d-i trunk) adds a kfreebsd-i386 kernel udeb. This work was done in the previous d-i kfreeebsd branch (svn://svn.debian.org/d-i/branches/d-i/kfree...@47541). I updated it, writing my changes in the changelog. It builds with an unmodified kernel-wedge. Its build process is not very clean (there are some warnings), nevertheless I think this package should not introduce regressions in trunk. I tested the kernel image and the acpi modules in kfreebsd-i386 d-i monolithic mini.iso (it boots). Cheers, Luca Favatella Index: packages/kernel/kfreebsd-kernel-di-i386/debian/changelog === --- packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,11 @@ +kfreebsd-kernel-di-i386 (0.1) UNRELEASED; urgency=low + + [ Robert Millan ] + * First upload. + + [ Luca Favatella ] + * Update kernel version. + * Disable mouse modules for building success. + * Enable building kernel image. + + -- Robert Millan r...@aybabtu.com Thu, 27 Apr 2006 20:50:53 +0200 Index: packages/kernel/kfreebsd-kernel-di-i386/debian/copyright === --- packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,5 @@ +This package is Copyright (c) 2001-2002 Herbert Xu herb...@debian.org +and Copyright 2001, 2003 by Joey Hess jo...@debian.org. + +It is licensed under the terms of the GNU GPL, see +/usr/share/common-licenses/GPL Index: packages/kernel/kfreebsd-kernel-di-i386/debian/rules === --- packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,2 @@ +#!/usr/bin/make -f +include /usr/share/kernel-wedge/generic-rules Property changes on: packages/kernel/kfreebsd-kernel-di-i386/debian/rules ___ Added: svn:executable + * Index: packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub === --- packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,6 @@ +Source: kfreebsd-kernel-di-i386 +Section: debian-installer +Priority: optional +Maintainer: Debian Install System Team debian-boot@lists.debian.org +Uploaders: Otavio Salvador ota...@debian.org +Build-Depends: kernel-wedge (= 2.22) Index: packages/kernel/kfreebsd-kernel-di-i386/package-list === --- packages/kernel/kfreebsd-kernel-di-i386/package-list (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/package-list (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,29 @@ +# This file is used to build up the control file. The kernel version and +# -di are appended to the package names. Section can be left out. So can +# architecture, which is derived from the files in the modules directory. +# It overwrites specifications from /usr/share/kernel-wedge/package-list. +# +Package: kernel-image +Depends: acpi-modules +Provides: ufs-modules + +Package: fat-modules +Priority: standard + +Package: nic-modules +Depends: kernel-image, nic-shared-modules, firmware-modules, firewire-core-modules + +Package: scsi-modules +Depends: kernel-image, isa-pnp-modules, scsi-core-modules, parport-modules, cdrom-core-modules, firmware-modules + +Package: nic-extra-modules +Depends: kernel-image, isa-pnp-modules, nic-shared-modules, firmware-modules, crc-modules + +Package: nic-usb-modules +Depends: kernel-image, nic-shared-modules, usb-modules, firmware-modules + +Package: ppp-modules +Depends: serial-modules, kernel-image, crc-modules + +Package: pcmcia-modules +Depends: kernel-image, isa-pnp-modules, firmware-modules Index: packages/kernel/kfreebsd-kernel-di-i386/kernel-versions === --- packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,2 @@ +# arch version flavour installedname suffix build-depends +kfreebsd-i386 7.2-2 486 7.2-1-486 - kfreebsd-image-7.2-1-486 Index: packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules === --- packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules (.../trunk) (revision 0) +++
Re: [patch] kfreebsd-i386 kernel udeb
On Monday 22 June 2009, Luca Favatella wrote: This patch (against d-i trunk) adds a kfreebsd-i386 kernel udeb. Your changelog here does not make much sense: +kfreebsd-kernel-di-i386 (0.1) UNRELEASED; urgency=low + + [ Robert Millan ] + * First upload. + + [ Luca Favatella ] + * Update kernel version. + * Disable mouse modules for building success. + * Enable building kernel image. As this will still be the initial version in the archive, so there is no reason to mention Update kernel version or Disable mouse modules. What could make sense is something like: [ Luca Favatella ] * Initial version, based on earlier work by Robert Millan. maybe add some specific comments here about known issues or ToDo items Have you tested if kfreebsd kernel udebs can be built using the massbuild script? I suspect that it will require special handling in a few places. An additional (separate) patch would be much appreciated. Cheers, FJP -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
On 22/06/2009, Frans Pop elen...@planet.nl wrote: On Monday 22 June 2009, Luca Favatella wrote: This patch (against d-i trunk) adds a kfreebsd-i386 kernel udeb. Your changelog here does not make much sense: [...] What could make sense is something like: [ Luca Favatella ] * Initial version, based on earlier work by Robert Millan. maybe add some specific comments here about known issues or ToDo items Attached version 2 of the patch, fixing this. Have you tested if kfreebsd kernel udebs can be built using the massbuild script? I suspect that it will require special handling in a few places. No, not tested. An additional (separate) patch would be much appreciated. I hope to quickly take a look at this. Thanks for your feedback, Luca Favatella Index: packages/kernel/kfreebsd-kernel-di-i386/debian/changelog === --- packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../branches/d-i/kfreebsd) (revision 59040) @@ -0,0 +1,6 @@ +kfreebsd-kernel-di-i386 (0.1) UNRELEASED; urgency=low + + [ Luca Favatella ] + * Initial version, based on earlier work by Robert Millan. + + -- Robert Millan r...@aybabtu.com Thu, 27 Apr 2006 20:50:53 +0200 Index: packages/kernel/kfreebsd-kernel-di-i386/debian/copyright === --- packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../branches/d-i/kfreebsd) (revision 59040) @@ -0,0 +1,5 @@ +This package is Copyright (c) 2001-2002 Herbert Xu herb...@debian.org +and Copyright 2001, 2003 by Joey Hess jo...@debian.org. + +It is licensed under the terms of the GNU GPL, see +/usr/share/common-licenses/GPL Index: packages/kernel/kfreebsd-kernel-di-i386/debian/rules === --- packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../branches/d-i/kfreebsd) (revision 59040) @@ -0,0 +1,2 @@ +#!/usr/bin/make -f +include /usr/share/kernel-wedge/generic-rules Property changes on: packages/kernel/kfreebsd-kernel-di-i386/debian/rules ___ Added: svn:executable + * Index: packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub === --- packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../branches/d-i/kfreebsd) (revision 59040) @@ -0,0 +1,6 @@ +Source: kfreebsd-kernel-di-i386 +Section: debian-installer +Priority: optional +Maintainer: Debian Install System Team debian-boot@lists.debian.org +Uploaders: Otavio Salvador ota...@debian.org +Build-Depends: kernel-wedge (= 2.22) Index: packages/kernel/kfreebsd-kernel-di-i386/package-list === --- packages/kernel/kfreebsd-kernel-di-i386/package-list (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/package-list (.../branches/d-i/kfreebsd) (revision 59040) @@ -0,0 +1,29 @@ +# This file is used to build up the control file. The kernel version and +# -di are appended to the package names. Section can be left out. So can +# architecture, which is derived from the files in the modules directory. +# It overwrites specifications from /usr/share/kernel-wedge/package-list. +# +Package: kernel-image +Depends: acpi-modules +Provides: ufs-modules + +Package: fat-modules +Priority: standard + +Package: nic-modules +Depends: kernel-image, nic-shared-modules, firmware-modules, firewire-core-modules + +Package: scsi-modules +Depends: kernel-image, isa-pnp-modules, scsi-core-modules, parport-modules, cdrom-core-modules, firmware-modules + +Package: nic-extra-modules +Depends: kernel-image, isa-pnp-modules, nic-shared-modules, firmware-modules, crc-modules + +Package: nic-usb-modules +Depends: kernel-image, nic-shared-modules, usb-modules, firmware-modules + +Package: ppp-modules +Depends: serial-modules, kernel-image, crc-modules + +Package: pcmcia-modules +Depends: kernel-image, isa-pnp-modules, firmware-modules Index: packages/kernel/kfreebsd-kernel-di-i386/kernel-versions === --- packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../branches/d-i/kfreebsd) (revision 59040) @@ -0,0 +1,2 @@ +# arch version flavour installedname suffix build-depends +kfreebsd-i386 7.2-2 486 7.2-1-486 - kfreebsd-image-7.2-1-486 Index: packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules
Re: [patch] kfreebsd-i386 kernel udeb
On Monday 22 June 2009, Luca Favatella wrote: Attached version 2 of the patch, fixing this. Thanks. One more issue (should have seen that earlier). The copyright file seems to have been copied blindly, which is incorrect. These people clearly are NOT the people who created the package, and it was not created 8 years ago: +This package is Copyright (c) 2001-2002 Herbert Xu herb...@debian.org +and Copyright 2001, 2003 by Joey Hess jo...@debian.org. -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
On 22/06/2009, Frans Pop elen...@planet.nl wrote: On Monday 22 June 2009, Luca Favatella wrote: Attached version 2 of the patch, fixing this. Thanks. One more issue (should have seen that earlier). No problem. The copyright file seems to have been copied blindly, which is incorrect. These people clearly are NOT the people who created the package, and it was not created 8 years ago: +This package is Copyright (c) 2001-2002 Herbert Xu herb...@debian.org +and Copyright 2001, 2003 by Joey Hess jo...@debian.org. Attached version 3 of the patch, fixing this. Index: packages/kernel/kfreebsd-kernel-di-i386/debian/changelog === --- packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../branches/d-i/kfreebsd) (revision 59041) @@ -0,0 +1,6 @@ +kfreebsd-kernel-di-i386 (0.1) UNRELEASED; urgency=low + + [ Luca Favatella ] + * Initial version, based on earlier work by Robert Millan. + + -- Robert Millan r...@aybabtu.com Thu, 27 Apr 2006 20:50:53 +0200 Index: packages/kernel/kfreebsd-kernel-di-i386/debian/copyright === --- packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../branches/d-i/kfreebsd) (revision 59041) @@ -0,0 +1,5 @@ +This package is Copyright (c) 2006 Robert Millan r...@aybabtu.com and +Copyright 2009 by Luca Favatella slacky...@gmail.org. + +It is licensed under the terms of the GNU GPL, see +/usr/share/common-licenses/GPL Index: packages/kernel/kfreebsd-kernel-di-i386/debian/rules === --- packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../branches/d-i/kfreebsd) (revision 59041) @@ -0,0 +1,2 @@ +#!/usr/bin/make -f +include /usr/share/kernel-wedge/generic-rules Property changes on: packages/kernel/kfreebsd-kernel-di-i386/debian/rules ___ Added: svn:executable + * Index: packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub === --- packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../branches/d-i/kfreebsd) (revision 59041) @@ -0,0 +1,6 @@ +Source: kfreebsd-kernel-di-i386 +Section: debian-installer +Priority: optional +Maintainer: Debian Install System Team debian-boot@lists.debian.org +Uploaders: Otavio Salvador ota...@debian.org +Build-Depends: kernel-wedge (= 2.22) Index: packages/kernel/kfreebsd-kernel-di-i386/package-list === --- packages/kernel/kfreebsd-kernel-di-i386/package-list (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/package-list (.../branches/d-i/kfreebsd) (revision 59041) @@ -0,0 +1,29 @@ +# This file is used to build up the control file. The kernel version and +# -di are appended to the package names. Section can be left out. So can +# architecture, which is derived from the files in the modules directory. +# It overwrites specifications from /usr/share/kernel-wedge/package-list. +# +Package: kernel-image +Depends: acpi-modules +Provides: ufs-modules + +Package: fat-modules +Priority: standard + +Package: nic-modules +Depends: kernel-image, nic-shared-modules, firmware-modules, firewire-core-modules + +Package: scsi-modules +Depends: kernel-image, isa-pnp-modules, scsi-core-modules, parport-modules, cdrom-core-modules, firmware-modules + +Package: nic-extra-modules +Depends: kernel-image, isa-pnp-modules, nic-shared-modules, firmware-modules, crc-modules + +Package: nic-usb-modules +Depends: kernel-image, nic-shared-modules, usb-modules, firmware-modules + +Package: ppp-modules +Depends: serial-modules, kernel-image, crc-modules + +Package: pcmcia-modules +Depends: kernel-image, isa-pnp-modules, firmware-modules Index: packages/kernel/kfreebsd-kernel-di-i386/kernel-versions === --- packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../branches/d-i/kfreebsd) (revision 59041) @@ -0,0 +1,2 @@ +# arch version flavour installedname suffix build-depends +kfreebsd-i386 7.2-2 486 7.2-1-486 - kfreebsd-image-7.2-1-486 Index: packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules === --- packages/kernel/kfreebsd-kernel-di-i386/modules/kfreebsd-i386/floppy-modules (.../trunk) (revision 0) +++
Re: [patch] kfreebsd-i386 kernel udeb
Hello Luca, On Mon, Jun 22, 2009 at 7:21 AM, Luca Favatellaslacky...@gmail.com wrote: It builds with an unmodified kernel-wedge. Good work; IMO the best way of doing it is to moving it to kernel-wedge to make the work for other arches easier in future and avoid duplication. Rest of issues has already been commented by Frans :-) -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
On Mon, Jun 22, 2009 at 12:21:31PM +0200, Luca Favatella wrote: This patch (against d-i trunk) adds a kfreebsd-i386 kernel udeb. This work was done in the previous d-i kfreeebsd branch (svn://svn.debian.org/d-i/branches/d-i/kfree...@47541). I updated it, writing my changes in the changelog. It builds with an unmodified kernel-wedge. Its build process is not very clean (there are some warnings), nevertheless I think this package should not introduce regressions in trunk. Given it only adds a new kfreebsd only package, it should not be a problem for trunk. I tested the kernel image and the acpi modules in kfreebsd-i386 d-i monolithic mini.iso (it boots). I only have a single comment for now (see below), but that should not prevent this patch to be committed in the SVN, it will be improved with time. Index: packages/kernel/kfreebsd-kernel-di-i386/debian/changelog === --- packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/changelog (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,11 @@ +kfreebsd-kernel-di-i386 (0.1) UNRELEASED; urgency=low + + [ Robert Millan ] + * First upload. + + [ Luca Favatella ] + * Update kernel version. + * Disable mouse modules for building success. + * Enable building kernel image. + + -- Robert Millan r...@aybabtu.com Thu, 27 Apr 2006 20:50:53 +0200 Index: packages/kernel/kfreebsd-kernel-di-i386/debian/copyright === --- packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/copyright (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,5 @@ +This package is Copyright (c) 2001-2002 Herbert Xu herb...@debian.org +and Copyright 2001, 2003 by Joey Hess jo...@debian.org. + +It is licensed under the terms of the GNU GPL, see +/usr/share/common-licenses/GPL Index: packages/kernel/kfreebsd-kernel-di-i386/debian/rules === --- packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/rules (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,2 @@ +#!/usr/bin/make -f +include /usr/share/kernel-wedge/generic-rules Property changes on: packages/kernel/kfreebsd-kernel-di-i386/debian/rules ___ Added: svn:executable + * Index: packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub === --- packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/debian/control.stub (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,6 @@ +Source: kfreebsd-kernel-di-i386 +Section: debian-installer +Priority: optional +Maintainer: Debian Install System Team debian-boot@lists.debian.org +Uploaders: Otavio Salvador ota...@debian.org +Build-Depends: kernel-wedge (= 2.22) Index: packages/kernel/kfreebsd-kernel-di-i386/package-list === --- packages/kernel/kfreebsd-kernel-di-i386/package-list (.../trunk) (revision 0) +++ packages/kernel/kfreebsd-kernel-di-i386/package-list (.../branches/d-i/kfreebsd) (revision 59039) @@ -0,0 +1,29 @@ +# This file is used to build up the control file. The kernel version and +# -di are appended to the package names. Section can be left out. So can +# architecture, which is derived from the files in the modules directory. +# It overwrites specifications from /usr/share/kernel-wedge/package-list. +# +Package: kernel-image +Depends: acpi-modules +Provides: ufs-modules + +Package: fat-modules +Priority: standard + +Package: nic-modules +Depends: kernel-image, nic-shared-modules, firmware-modules, firewire-core-modules + +Package: scsi-modules +Depends: kernel-image, isa-pnp-modules, scsi-core-modules, parport-modules, cdrom-core-modules, firmware-modules + +Package: nic-extra-modules +Depends: kernel-image, isa-pnp-modules, nic-shared-modules, firmware-modules, crc-modules + +Package: nic-usb-modules +Depends: kernel-image, nic-shared-modules, usb-modules, firmware-modules + +Package: ppp-modules +Depends: serial-modules, kernel-image, crc-modules + +Package: pcmcia-modules +Depends: kernel-image, isa-pnp-modules, firmware-modules Index: packages/kernel/kfreebsd-kernel-di-i386/kernel-versions === --- packages/kernel/kfreebsd-kernel-di-i386/kernel-versions (.../trunk) (revision 0) +++
Re: [patch] kfreebsd-i386 kernel udeb
Hello Luca, On Mon, Jun 22, 2009 at 3:44 PM, Otavio Salvadorota...@ossystems.com.br wrote: Good work; IMO the best way of doing it is to moving it to kernel-wedge to make the work for other arches easier in future and avoid duplication. The only thing that could be done in kernel-wedge is the ntfs one that you could fix it now and use it in the package. There's no reason to let it to later since it will make your life easier. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [patch] kfreebsd-i386 kernel udeb
On Tuesday 23 June 2009, Otavio Salvador wrote: Hello Luca, On Mon, Jun 22, 2009 at 3:44 PM, Otavio Salvadorota...@ossystems.com.br wrote: Good work; IMO the best way of doing it is to moving it to kernel-wedge to make the work for other arches easier in future and avoid duplication. The only thing that could be done in kernel-wedge is the ntfs one that you could fix it now and use it in the package. There's no reason to let it to later since it will make your life easier. sarcasm Yes, I agree it is *really* important to make that change now. Not having that defined in kernel-wedge but instead having it separately for 3 different arches is a really major issue and fixing that will save HUGE amounts of work in the future. Let's see, the files contain exactly ONE module, and have never yet been changed since they were created. So yes: a really major improvement. /sarcasm IMO this is making a change for absolutely NO measurable gain at all. It is also pushing work towards someone who has other goals than what you are asking him to do, making his work needlessly complicated (as the change would have to be a separate patch) and there is absolutely ZERO benefit to kfreebsd-i386. Also, the proposed kfreebsd-i386 file *is* different from all existing ones (did you even see that?). I don't know why, but that would at least have to be carefully checked. IMO it's not reasonable to dump that on Luca, especially as he has minimal experience with kernel-wedge yet. The kfreebsd-i386 patch is consistent with current code and should IMO be accepted as is and not complicated unnecessarily. Just my 2 cents. -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
