Bug#956178: libjna-jni libjnidispatch.system.so has build directory in soname

2020-04-07 Thread Bart Massey
Package: libjna-jni
Version: 4.5.2-1+b1
Severity: normal
Tags: patch

Dear Maintainer,

Placed the following in /etc/ld.so.conf.d/java-jni.conf

/usr/lib/x86_64-linux-gnu/jni
/usr/lib/jni

and ran ldconfig, which reported

ldconfig: Can't link 
/usr/lib/x86_64-linux-gnu/jni//build/libjna-java-ayrlgf/libjna-java-4.5.2/build/native-linux-x86-64/libjnidispatch.system.so
 to libjnidispatch.system.so

This didn't seem right, so after some tracking down
discovered that the Makefile was borked.

Attached is a tested patch that resolves the problem by
removing the build path from the library soname.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (400, 'oldoldstable'), (400, 'experimental'), 
(400, 'testing'), (400, 'stable'), (400, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.4.0-4-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND, 
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libjna-jni depends on:
ii  libc62.30-4
ii  libffi7  3.3-4

libjna-jni recommends no packages.

libjna-jni suggests no packages.

-- no debconf information

--- native/Makefile.dist2020-04-07 19:57:15.443971156 -0700
+++ native/Makefile 2020-04-07 19:57:44.708059780 -0700
@@ -268,10 +268,10 @@
 PCFLAGS+=-fPIC
 CDEFINES+=-DHAVE_PROTECTION
 ifeq ($(DYNAMIC_LIBFFI),true)
-LDFLAGS+=-Wl,-soname,$@
+LDFLAGS+=-Wl,-soname,$(F@)
 else
 # Ensure we bind to local libffi symbols
-LDFLAGS+=-Wl,-soname,$@,-Bsymbolic
+LDFLAGS+=-Wl,-soname,$(F@),-Bsymbolic
 endif
 endif
 



Bug#870836: imake generated makefile use deprecated -D_BSD_SOURCE and -D_SVID_SOURCE

2018-11-24 Thread Bart Massey
Hilariously, I just ran into this today when building a program I wrote in
1987. Thanks huge to Teemu for working out the patch; I have verified that
it works for me. It would be great if this could be packaged.


Bug#839660: libmlt6: cannot load second LADSPA plugin

2016-10-03 Thread Bart Massey
Package: libmlt6
Version: 6.2.0-1
Severity: normal
Tags: upstream patch

Dear Maintainer,

When using Flowblade or OpenShot to edit videos, trying to
apply a second LADSPA effect from the swh-tools package to
an audio stream caused a coredump in MLT's jackrack module.

After some debugging, this proved to be lack of a null
pointer check in jackrack: the null pointer was unexpected,
since it corresponded to the LADSPA plugin having been
incorrectly loaded.

After fixing MLT jackrack to not dump core and fixing up the
logging, the problem with LADSPA loading was traced to
unnecessarily using RTLD_GLOBAL in the dlopen() call for the
LADSPA plugin in one of two locations where the plugin was
opened. This (for some reason I don't understand) prevented
the swh_init constructor for the LADSPA plugin from being
called at load time, which in turn caused the plugin to
fail to be configured properly.

With RTLD_GLOBAL removed, MLT worked as expected. Flowblade
applied multiple swh-plugins LADSPA effects to an audio
track successfully.

This patch cleans up the debug logging for MLT jackrack,
prevents a coredump in the case that a LADSPA plugin reports
no configuration, and removes the offending RTLD_GLOBAL.

diff -ru /usr/src/mlt-6.2.0/src/modules/jackrack/jack_rack.c 
./src/modules/jackrack/jack_rack.c
--- /usr/src/mlt-6.2.0/src/modules/jackrack/jack_rack.c 2016-04-20 
19:24:55.0 -0700
+++ ./src/modules/jackrack/jack_rack.c  2016-10-02 16:01:44.0 -0700
@@ -103,7 +103,11 @@
 {
   plugin_t * plugin = jack_rack_instantiate_plugin (jack_rack, 
saved_plugin->settings->desc);
   if (!plugin)
-return;
+{
+  mlt_log_warning( NULL, "%s: could not instantiate object file '%s'\n",
+   __FUNCTION__, 
saved_plugin->settings->desc->object_file);
+  return;
+}
   jack_rack->saved_plugins = g_slist_append (jack_rack->saved_plugins, 
saved_plugin);
   process_add_plugin (jack_rack->procinfo, plugin);
   jack_rack_add_plugin (jack_rack, plugin);
diff -ru /usr/src/mlt-6.2.0/src/modules/jackrack/plugin.c 
./src/modules/jackrack/plugin.c
--- /usr/src/mlt-6.2.0/src/modules/jackrack/plugin.c2016-04-20 
19:24:55.0 -0700
+++ ./src/modules/jackrack/plugin.c 2016-10-03 07:53:19.0 -0700
@@ -287,26 +287,35 @@
   void * dl_handle;
   const char * dlerr;
   LADSPA_Descriptor_Function get_descriptor;
-
+  
+  /* clear the error report */
+  dlerror ();
+
   /* open the object file */
+#if 0
   dl_handle = dlopen (desc->object_file, RTLD_NOW|RTLD_GLOBAL);
-  if (!dl_handle)
+#else
+  dl_handle = dlopen (desc->object_file, RTLD_NOW);
+#endif
+  dlerr = dlerror ();
+  if (!dl_handle || dlerr)
 {
+  if (!dlerr)
+  dlerr = "unknown error";
   mlt_log_warning( NULL, "%s: error opening shared object file '%s': %s\n",
-   __FUNCTION__, desc->object_file, dlerror());
+   __FUNCTION__, desc->object_file, dlerr);
   return 1;
 }
 
   
   /* get the get_descriptor function */
-  dlerror (); /* clear the error report */
-  
   get_descriptor = (LADSPA_Descriptor_Function)
 dlsym (dl_handle, "ladspa_descriptor");
-  
   dlerr = dlerror();
   if (dlerr)
 {
+  if (!dlerr)
+  dlerr = "unknown error";
   mlt_log_warning( NULL, "%s: error finding descriptor symbol in object 
file '%s': %s\n",
__FUNCTION__, desc->object_file, dlerr);
   dlclose (dl_handle);
@@ -321,6 +330,13 @@
 #endif
 
   *descriptor_ptr = get_descriptor (desc->index);
+  if (!*descriptor_ptr)
+{
+  mlt_log_warning( NULL, "%s: error finding index %lu in object file 
'%s'\n",
+  __FUNCTION__, desc->index, desc->object_file);
+  dlclose (dl_handle);
+  return 1;
+}
   *dl_handle_ptr = dl_handle;
   
   return 0;
diff -ru /usr/src/mlt-6.2.0/src/modules/jackrack/plugin_mgr.c 
./src/modules/jackrack/plugin_mgr.c
--- /usr/src/mlt-6.2.0/src/modules/jackrack/plugin_mgr.c2016-04-20 
19:24:55.0 -0700
+++ ./src/modules/jackrack/plugin_mgr.c 2016-10-03 07:53:19.0 -0700
@@ -147,7 +147,7 @@
   plugin_mgr->plugin_count++;
   
   /* print in the splash screen */
-  /* mlt_log_verbose( NULL, "Loaded plugin '%s'\n", desc->name); */
+  mlt_log_verbose( NULL, "Loaded plugin '%s'\n", desc->name);
 }
   
   err = dlclose (dl_handle);



-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (400, 'oldoldstable'), (400, 'testing'), (400, 
'stable'), (400, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libmlt6 depends on:
ii  libavcodec57  7:3.1.3-1+b3
ii  libavdevice57 7:3.1.3-1+b3
ii  libavfilter6  7:3.1.3-1+b3
ii  

Bug#671056: Looks like a dup of #641662

2012-07-04 Thread Bart Massey
Looks like a dup of 641662. Wish someone would fix this; it's
annoying, and should be easy.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#535534:

2011-08-15 Thread Bart Massey
OK, here's a backtrace. Sorry I don't have more stuff with symbol
tables. I'll work on it.

#0  exit (status=1) at exit.c:100
#1  0xb779d1dc in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#2  0xb621ebba in xkl_process_error () from /usr/lib/libxklavier.so.16
#3  0xb76330d3 in _XError (dpy=0x806ab30, rep=0x824c968)
at ../../src/XlibInt.c:1583
#4  0xb762fd7d in handle_error (dpy=0x806ab30, err=0x824c968, in_XReply=1)
at ../../src/xcb_io.c:212
#5  0xb7630d67 in _XReply (dpy=0x806ab30, rep=0xbfffe620, extra=0, discard=0)
at ../../src/xcb_io.c:698
#6  0xb762651f in XQueryTree (dpy=0x806ab30, w=39846027, root=0xbfffe6f4,
parent=0xbfffe6f0, children=0xbfffe6f8, nchildren=0xbfffe68c)
at ../../src/QuTree.c:46
#7  0xb622698a in xkl_engine_query_tree () from /usr/lib/libxklavier.so.16
#8  0xb621de26 in xkl_engine_process_focus_in_evt ()
   from /usr/lib/libxklavier.so.16
#9  0xb621e9f4 in xkl_engine_filter_events () from /usr/lib/libxklavier.so.16
#10 0xb6292613 in gsd_keyboard_xkb_evt_filter (xev=0xbfffe8d0, event=0x807e6e0)
at gsd-keyboard-xkb.c:829
#11 0xb7792d72 in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#12 0xb7794c2b in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#13 0xb7794ccd in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#14 0xb7988252 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#15 0xb7988a30 in ?? () from /lib/libglib-2.0.so.0
---Type return to continue, or q return to quit---
#16 0xb79890f3 in g_main_loop_run () from /lib/libglib-2.0.so.0
#17 0xb7c74caf in gtk_main () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#18 0x0804bb96 in main ()



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#535534: me too

2011-08-12 Thread Bart Massey
This happens to me on i686 / sid. It also happened with the wheezy version.

I tried compiling gnome-settings-daemon for debugging and running it with
--no-daemon --sync under gdb with a breakpoint set at gdk_x_error but for
some reason it did not actually stop for a backtrace when it crashed. It
seems much harder to get gnome-settings-daemon to crash when compiled and
running in this way :-) and so I had to wait a couple of days. I'll let you
know if I find any more info.


Bug#344698: Me too

2011-06-09 Thread Bart Massey
It's now 2011. This bug was submitted 5.5 years ago with a patch, which
still applies just fine and works as advertised for me. Would somebody
pretty please just patch the thing?


Bug#426938: git-core: Conflict markers should always have a SHA1

2011-03-13 Thread Bart Massey
It's been a long time. Thanks huge for checking back!

IIRC, my specific scenario was that I had accidentally committed with
some unresolved conflict markers still in a large README file.
Happens. :-) When I discovered the markers, much much later, I wanted
to figure out which merge they had come from. I did of course figure
it out, but it would have been much more convenient if I just had a
handle on the commit ids of both sides of the merge.

At least, that's the best I can remember. If you want to just close
this bug, I'm cool with it. If I have more trouble I can always file
another, and this time actually record my specific scenario. :-)

I'd say that in general it should always be harmless to include the
commit id anytime you print a symbolic revision id, and it might very
occasionally be helpful. But it's no big deal, I think.

Again, thanks for your time on this.

Bart

On Sat, Mar 12, 2011 at 12:57 PM, Jonathan Nieder jrnie...@gmail.com wrote:
 tags 426938 + moreinfo
 quit

 Hi again,

 4 years ago, Bart Massey wrote[1]:

 As of now, the conflict markers generated by merges
 sometimes include only a relative symbolic name such as
 HEAD.  A SHA1 should also always be included, so that
 months later the marker is still meaningful.

 My response was that it is not obvious what that would buy, given that
 conflict markers are supposed to be ephemeral things that do not make
 it into permanent history.  That is, in order to change HEAD, you
 would need to run git merge --abort or git reset --merge first
 anyway.

 The conflict labels should be easy to change given a reason to do so,
 so I'm marking the bug accordingly.

 Thanks for your work.
 Jonathan

 [1] http://bugs.debian.org/426938




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#511456: time: defaults to POSIX non-compliance

2011-02-08 Thread Bart Massey
Thanks! I agree that this is much better. Only thing better yet would
be to fix the POSIX standard to require that format by default, and I
can't see that happening anytime soon. :-)

Thanks much for working on this.

Bart

On Mon, Feb 7, 2011 at 6:02 PM, Jonathan Nieder jrnie...@gmail.com wrote:
 tags 511456 - moreinfo
 retitle 511456 time: documentation of -p is unclear
 severity 511456 minor
 tags 511456 + upstream
 quit

 Bart Massey wrote:

 Sorry, I hadn' t realized the POSIX standard was so broken that it
 required a flag to get a guarantee of predictable formatting. I guess
 under those circumstances I'll just have to get used to writing time
 -p and hoping that everyone's time implementation is
 POSIX-compliant.

 Ok, cc-ing the bug log.  Now that I check the manpage and info
 documentation, I can agree that it is downright misleading:

        -p, --portability
                Use the following format string, for conformance with
                POSIX standard 1003.2:

                        real %e
                        user %U
                        sys %S

 It would be better to say:

        -p, --portability
                Use the following format string:

                        real %e
                        user %U
                        sys %S

                The default output format of time differs widely
                between implementations.  This option (in its
                short form -p) is supported by all POSIX-compliant
                'time' implementations to retrieve basic
                information in the described format.

 Roughly like this, maybe.
 ---
 diff --git a/time.texi b/time.texi
 index c725f8a..8da3727 100644
 --- a/time.texi
 +++ b/time.texi
 @@ -182,8 +182,7 @@ Use @var{format} as the format string.

  @item -p
  @itemx --portability
 -Use the following format string, for conformance with POSIX standard
 -1003.2:
 +Use the following format string:

  @example
  real %e
 @@ -191,6 +190,11 @@ user %U
  sys %S
  @end example

 +The default output format of time differs widely between
 +implementations.  This option (in its short form -p) is supported by all
 +POSIX-compliant 'time' implementations to retrieve basic information in
 +the described format.
 +
  @item -q
  @itemx --quiet
  Suppress non-zero error code from the executed program.




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#602360: pnmquant: fails on stdin

2010-11-03 Thread Bart Massey
Package: netpbm
Version: 2:10.0-12.2+b1
Severity: normal
Tags: upstream patch


When invoked without a filename argument, pnmquant fails.
Upon inspection, this is because pnmquant is a perl script
that performs the two-pass pnmcolormap pnmremap sequence,
and it does not bother to save stdin for the second pass.

A patch is attached.  Alternatively, one could simply change
the documentation to indicate that pnmquant must receive a
filename argument.

(BTW, I'm not sure whether the this code is in the public
domain license of pnmquant is OK, but I'm too lazy to file
a separate bug report on this.)

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages netpbm depends on:
ii  libc6   2.11.2-2 Embedded GNU C Library: Shared lib
ii  libjpeg62   6b1-1The Independent JPEG Group's JPEG 
ii  libnetpbm10 2:10.0-12.2+b1   Graphics conversion tools shared l
ii  libpng12-0  1.2.44-1 PNG library - runtime
ii  libtiff43.9.4-1  Tag Image File Format (TIFF) libra
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages netpbm recommends:
ii  ghostscript 8.71~dfsg2-3 The GPL Ghostscript PostScript/PDF

netpbm suggests no packages.

-- no debconf information

--- pnmquant.dist   2010-11-03 10:27:30.0 -0700
+++ pnmquant2010-11-03 21:58:20.0 -0700
@@ -9,6 +9,7 @@
 use Getopt::Long;
 use File::Temp tempfile;
 use File::Spec;
+use File::Copy;
 
 my ($TRUE, $FALSE) = (1,0);
 
@@ -39,7 +40,13 @@
 if (@ARGV  1) {
 $infile = $ARGV[1];
 } else {
-$infile = -;
+my ($savefileFh, $savefileSpec) =
+   tempfile(pnmquantSave, 
+SUFFIX = .pnm,
+UNLINK = $TRUE,
+DIR = File::Spec-tmpdir());
+copy(\*STDIN, $savefileFh);
+$infile = $savefileSpec;
 }
 
 my $averageOpt;



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#599017: openssh-client: Global User setting in .ssh/config fails

2010-10-03 Thread Bart Massey
Package: openssh-client
Version: 1:5.5p1-5
Severity: normal
Tags: upstream


To save typing, my .ssh/config started with User = bart,
which was intended to apply globally unless overriden by the
User setting for a particularly connection.  Although I
may be mistaken, I think the manual implies that this is
supposed to work.

Sadly, it doesn't; with this configuration, when publickey
authentication fails, rather than fall back to password
authentication the client simply repeatedly sends some bogus
public key until the server dies.  Here's a trace:

OpenSSH_5.5p1 Debian-5, OpenSSL 0.9.8o 01 Jun 2010
debug1: Reading configuration data /home/bart/.ssh/config
debug1: Applying options for test
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: Applying options for *
debug1: Connecting to bartfan.po8.org [192.168.1.7] port 22.
debug1: Connection established.
debug1: identity file /home/bart/.ssh/id-rsa-test type 1
debug1: Checking blacklist file /usr/share/ssh/blacklist.RSA-4096
debug1: Checking blacklist file /etc/ssh/blacklist.RSA-4096
debug1: identity file /home/bart/.ssh/id-rsa-test-cert type -1
debug1: Remote protocol version 2.0, remote software version OpenSSH_5.5p1 
Debian-5
debug1: match: OpenSSH_5.5p1 Debian-5 pat OpenSSH*
debug1: Enabling compatibility mode for protocol 2.0
debug1: Local version string SSH-2.0-OpenSSH_5.5p1 Debian-5
debug1: SSH2_MSG_KEXINIT sent
debug1: SSH2_MSG_KEXINIT received
debug1: kex: server-client aes128-ctr hmac-md5 none
debug1: kex: client-server aes128-ctr hmac-md5 none
debug1: SSH2_MSG_KEX_DH_GEX_REQUEST(102410248192) sent
debug1: expecting SSH2_MSG_KEX_DH_GEX_GROUP
debug1: SSH2_MSG_KEX_DH_GEX_INIT sent
debug1: expecting SSH2_MSG_KEX_DH_GEX_REPLY
debug1: Host 'bartfan.po8.org' is known and matches the RSA host key.
debug1: Found key in /home/bart/.ssh/known_hosts:59
debug1: ssh_rsa_verify: signature correct
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug1: SSH2_MSG_NEWKEYS received
debug1: Roaming not allowed by server
debug1: SSH2_MSG_SERVICE_REQUEST sent
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug1: Authentications that can continue: publickey,password
debug1: Next authentication method: publickey
debug1: Offering public key: /home/bart/.ssh/id-rsa-test
debug1: Authentications that can continue: publickey,password
debug1: Offering public key: b...@bartfan
debug1: Authentications that can continue: publickey,password
debug1: Offering public key: b...@bartfan
debug1: Authentications that can continue: publickey,password
debug1: Offering public key: b...@bartfan
debug1: Authentications that can continue: publickey,password
debug1: Offering public key: b...@bartfan
debug1: Authentications that can continue: publickey,password
debug1: Offering public key: b...@bartfan
Received disconnect from 192.168.1.7: 2: Too many authentication failures 
for bart

Moving the User option to be private to each connection in
the config file seems to solve the problem.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages openssh-client depends on:
ii  adduser 3.112add and remove users and groups
ii  debconf [debconf-2.0]   1.5.33   Debian configuration management sy
ii  dpkg1.15.7.2 Debian package management system
ii  libc6   2.11.2-2 Embedded GNU C Library: Shared lib
ii  libedit22.11-20080614-1  BSD editline and history libraries
ii  libgssapi-krb5-21.8.1+dfsg-5 MIT Kerberos runtime libraries - k
ii  libssl0.9.8 0.9.8o-1 SSL shared libraries
ii  passwd  1:4.1.4.2-1  change and administer password and
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages openssh-client recommends:
ii  openssh-blacklist 0.4.1  list of default blacklisted OpenSS
ii  openssh-blacklist-extra   0.4.1  list of non-default blacklisted Op
ii  xauth 1:1.0.4-1  X authentication utility

Versions of packages openssh-client suggests:
pn  keychain none  (no description available)
pn  libpam-ssh   none  (no description available)
ii  ssh-askpass  1:1.2.4.1-9 under X, asks user for a passphras

-- Configuration Files:
/etc/ssh/ssh_config changed:
Host *
ForwardX11 = yes
CheckHostIP = no
StrictHostKeyChecking = no
SendEnv = LANG LC_*
HashKnownHosts = no


-- no debconf information



-- 
To UNSUBSCRIBE, email to 

Bug#386791: Come on, fix the package already...

2010-01-13 Thread Bart Massey
This is several years old now, and the fix is pretty well understood:

  1) Add to /etc/bind/named.conf the line


Bug#386791: Let's try again

2010-01-13 Thread Bart Massey
This bug can be fixed by:
  1) Adding a line that says
  include /etc/bind/rndc.key;
  to /etc/bind/named.conf
and then
  2) Making /etc/bind/rndc.key be owner root:bind mode 640

Given the number of years this bug has been outstanding, it would be really
nice if someone would fix it.


Bug#559755: For pity's sake, no.

2010-01-03 Thread Bart Massey
My backup system is built entirely around the cryptoloop module, and I have
no real interest in re-engineering it.  In my application, the weakness
referred to in CVE-2004-2135 is largely irrelevant.   I'm not sure what
cryptoloop doesn't work with journaling filesystems is supposed to mean;
it has seemed to work fine for me for years and years.

Please put cryptoloop back.  I don't have a week to mess with dmcrypt right
now, so I'm just going to have to compile my own kernel (or at least my own
cryptoloop module)  if you don't.  I would be really, really annoyed by
this.  I can't believe I'm the only one.


Bug#561023: libc6-dev: dirent.h scandir() has wrong function prototype

2009-12-13 Thread Bart Massey
Package: libc6-dev
Version: 2.7-18
Severity: minor


In /usr/include/dirent.h, the fourth and final argument of
scandir() is prototyped to be

  int (*)(const void *, const void *).

However, the manpage documents it to be

  int (*)(const struct dirent **, const struct dirent **)

Sadly, the difference appears to cause GCC 4.3.2 to emit a
warning on correct use, even without -Wall.

-- System Information:
Debian Release: 5.0.3
  APT prefers stable
  APT policy: (990, 'stable'), (150, 'unstable'), (150, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libc6-dev depends on:
ii  libc6 2.7-18 GNU C Library: Shared libraries
ii  linux-libc-dev2.6.26-19  Linux support headers for userspac

Versions of packages libc6-dev recommends:
ii  gcc [c-compiler] 4:4.3.2-2   The GNU C compiler
ii  gcc-2.95 [c-compiler]1:2.95.4-27 The GNU C compiler
ii  gcc-3.3 [c-compiler] 1:3.3.6-15  The GNU C compiler
ii  gcc-4.1 [c-compiler] 4.1.2-25The GNU C compiler
ii  gcc-4.2 [c-compiler] 4.2.4-6 The GNU C compiler
ii  gcc-4.3 [c-compiler] 4.3.2-1.1   The GNU C compiler

Versions of packages libc6-dev suggests:
ii  glibc-doc 2.7-18 GNU C Library: Documentation
ii  manpages-dev  3.05-1 Manual pages about using GNU/Linux

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#522086: synce-sync-engine does not install against python2.3

2009-03-31 Thread Bart Massey
Package: synce-sync-engine
Version: 0.13-1
Severity: normal


Installation of synce-sync-engine fails when python2.3 is
installed, by trying to compile incompatible code.  Removing
python2.3 works around the problem.  Presumably the
dependencies should just be changed?

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.9 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages synce-sync-engine depends on:
ii  odccm   0.13-1   Daemon to keep a connection to Win
ii  python  2.5.4-2  An interactive high-level object-o
ii  python-central  0.6.11   register and build utility for Pyt
ii  python-dateutil 1.4.1-3  powerful extensions to the standar
ii  python-dbus 0.83.0-1 simple interprocess messaging syst
ii  python-gobject  2.14.2-1 Python bindings for the GObject li
ii  python-libxml2  2.7.3.dfsg-1 Python bindings for the GNOME XML 
ii  python-libxslt1 1.1.24-2 Python bindings for libxslt1
ii  python-rapi20.13.1-2 Make RAPI calls to a Windows Mobil
ii  python-rra  0.13-1   Library for syncing with Windows M
ii  python-rtfcomp  1.1-4Library to read compressed RTF fil
ii  python-tz   2009d-1  Python version of the Olson timezo

synce-sync-engine recommends no packages.

synce-sync-engine suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#182626: dpkg-deb: patch to allow setgid control directory

2009-03-19 Thread Bart Massey
Package: dpkg
Version: 1.14.25
Followup-For: Bug #182626


As noted, dpkg-deb will currently fail if the control
directory is setgid.  (The error message is also incorrect.)
Abset some reason for this behavior, the following patch
fixes it.

--- build.c.dist2009-02-02 06:46:10.0 -0800
+++ build.c 2009-03-18 23:36:33.0 -0700
@@ -271,9 +271,10 @@
 strcat(controlfile, / BUILDCONTROLDIR /);
 if (lstat(controlfile,mscriptstab)) ohshite(unable to stat control 
directory);
 if (!S_ISDIR(mscriptstab.st_mode)) ohshit(control directory is not a 
directory);
-if ((mscriptstab.st_mode  07757) != 0755)
-  ohshit(_(control directory has bad permissions %03lo (must be =0755 
- and =0775)), (unsigned long)(mscriptstab.st_mode  0));
+if ((mscriptstab.st_mode  05757) != 0755)
+  ohshit(_(control directory has bad permissions %03lo (must be 0755, 
+ 0775, 02755, or 02775)),
+ (unsigned long)(mscriptstab.st_mode  0));
 
 for (mscriptp= maintainerscripts; *mscriptp; mscriptp++) {
   strcpy(controlfile, directory);


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.4 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dpkg depends on:
ii  coreutils 6.10-6 The GNU core utilities
ii  libc6 2.9-4  GNU C Library: Shared libraries
ii  lzma  4.43-14Compression method of 7z format in

dpkg recommends no packages.

Versions of packages dpkg suggests:
ii  apt   0.7.20.2   Advanced front-end for dpkg

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#514482: kernel-package: make-kpkg fails with permission error on control directory

2009-02-07 Thread Bart Massey
Package: kernel-package
Version: 11.016
Severity: important


Running make-kpkg buildpackage in the 2.6.28.4 Git
directory as root eventually yields

  dpkg-deb: building package `linux-headers-2.6.28.4' in 
`../linux-headers-2.6.28.4_2.6.28.4-10.00.Custom_i386.deb'.
  dpkg-deb: control directory has bad permissions 2755 (must be =0755 and 
=0775)

and then fails out.  Of course, the control directory was
created by make-kpkg, and changing its permissions doesn't
solve the problem.

-- System Information:
Debian Release: 5.0
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.2 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages kernel-package depends on:
ii  binutils2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  debianutils 2.30 Miscellaneous utilities specific t
ii  dpkg1.14.24  Debian package management system
ii  dpkg-dev1.14.24  Debian package development tools
ii  file4.26-1   Determines file type using magic
ii  gcc [c-compiler]4:4.3.2-2The GNU C compiler
ii  gcc-2.95 [c-compile 1:2.95.4-27  The GNU C compiler
ii  gcc-3.3 [c-compiler 1:3.3.6-15   The GNU C compiler
ii  gcc-3.4 [c-compiler 3.4.6-9  The GNU C compiler
ii  gcc-4.0 [c-compiler 4.0.3-7  The GNU C compiler
ii  gcc-4.1 [c-compiler 4.1.2-25 The GNU C compiler
ii  gcc-4.2 [c-compiler 4.2.4-6  The GNU C compiler
ii  gcc-4.3 [c-compiler 4.3.2-1.1The GNU C compiler
ii  gettext 0.17-4   GNU Internationalization utilities
ii  make3.81-5   The GNU version of the make util
ii  module-init-tools   3.4-1tools for managing Linux kernel mo
ii  perl5.10.0-19Larry Wall's Practical Extraction 
ii  po-debconf  1.0.15   manage translated Debconf template
ii  util-linux  2.13.1.1-1   Miscellaneous system utilities

Versions of packages kernel-package recommends:
ii  bzip2 1.0.5-1high-quality block-sorting file co
ii  libc6-dev [libc-dev]  2.7-18 GNU C Library: Development Librari

Versions of packages kernel-package suggests:
pn  docbook-utils none (no description available)
ii  e2fsprogs 1.41.3-1   ext2/ext3/ext4 file system utiliti
ii  initramfs-tools [linux-in 0.92o  tools for generating an initramfs
pn  libdb3-devnone (no description available)
ii  libncurses5-dev [libncurs 5.7+20081213-1 developer's libraries and docs for
ii  linux-source-2.6.17 [linu 2.6.17-9   Linux kernel source for version 2.
ii  xmlto 0.0.20-5   XML-to-any converter

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#511456: time: defaults to POSIX non-compliance

2009-01-10 Thread Bart Massey
Package: time
Version: 1.7-23
Severity: normal


GNU time has a --portability flag to get the
POSIX-mandated formatting of its output.  The BASH time
builtin is used in /bin/sh invocations and is
POSIX-compliant.  The combination of these features means
that it is difficult to write portable shell scripts that
examine the output of time but work under Debian.  A
workaround is to set the TIME environment variable to the
POSIX format, but since other programs may use an
environment variable named something as generic as TIME in
other ways, one must be fairly selective about it; in any
case, it's a gratuitous painful wart.

The default behavior of time should be POSIX-compliant.  A
flag and/or environment variable could instead give the
current non-standard behavior.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (150, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages time depends on:
ii  libc6 2.7-16 GNU C Library: Shared libraries

time recommends no packages.

time suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#450802: sox: Bad missing dependency!!!

2008-01-19 Thread Bart Massey
Package: sox
Version: 14.0.0-5
Followup-For: Bug #450802


Bug #450802, #454177, and #460503 are all from the same
underlying cause.  To be at all useful, sox needs to depend
on libsox-fmt-base, not just recommend or suggest it.
Otherwise, sox is more-or-less nonfunctional.

This bug and fix were reported in #454177 more than a month
ago---please fix!!

In the meantime, the workaround of #454177 will get the
desperate who can find this bug report going again. Install
libsox-fmt-base or one of its dependents; I recommend
libsox-fmt-all.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages sox depends on:
ii  libc6 2.7-5  GNU C Library: Shared libraries
ii  libltdl3  1.5.22-4   A system independent dlopen wrappe
ii  libsamplerate00.1.2-5audio rate conversion library
ii  libsox0   14.0.0-5   SoX library

Versions of packages sox recommends:
pn  libsox-fmt-alsa | libsox-fmt- none (no description available)
ii  libsox-fmt-base   14.0.0-5   Minimal set of SoX format librarie

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#435470: tasksel: Tasks (and distro images) should be created by popcon clustering

2007-07-31 Thread Bart Massey
Package: tasksel
Severity: wishlist

Since popcon submissions are per-user, there is important
information there about the correlations between packages.
This information could easily be used to compute
(automatically, and in a privacy-preserving way) clusters of
packages that are commonly installed together.  This would
provide a set of tasks that is well-adapted to being
installed as a unit.  In particular, these tasks would
presumably include both vertical and horizontal
components, i.e., things that are associated by similar
function as well as similar underlying userbase.

In addition, clustered tasks would make a nice way
to create customized disk images for offline installs.  The
tasks created by clustering would probably have to be named
by hand; names could be chosen from the existing task names,
or from a whole new set.

Bart Massey
[EMAIL PROTECTED]


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#423561: ghc6-doc 6.6.1-2 should depend on haddock 0.8-2

2007-06-12 Thread Bart Massey
Package: ghc6-doc
Version: 6.6.1-2
Followup-For: Bug #423561


It's not enough for ghc6-doc to depend on haddock: the
latest version of ghc6-doc (6.6.1-2) needs the latest
version of haddock (0.8-2) to correctly compile the index.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (950, 'testing'), (650, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.20-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages ghc6-doc depends on:
ii  haddock   0.8-2  Documentation tool for annotated H

ghc6-doc recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#428043: cupsys-driver-gutenprint: Prefer no broken PPDs

2007-06-11 Thread Bart Massey
Package: cupsys-driver-gutenprint
Version: 5.0.0-3
Followup-For: Bug #428043

Confirming the HP Color LaserJet PPD bug.  If gutenprint
can't do color for these printers, I'd prefer if it refused
to handle them at all: the HP PPD for my 2500 seems to work
fine with CUPS once I found out I needed to go there.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (495, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages cupsys-driver-gutenprint depends on:
ii  cupsys1.2.11-3   Common UNIX Printing System(tm) - 
ii  libc6 2.5-7  GNU C Library: Shared libraries
ii  libcupsimage2 1.2.11-3   Common UNIX Printing System(tm) - 
ii  libcupsys21.2.7-4Common UNIX Printing System(tm) - 
ii  libgnutls13   1.6.3-1the GNU TLS library - runtime libr
ii  libgutenprint25.0.0-3runtime for the Gutenprint printer
ii  libjpeg62 6b-13  The Independent JPEG Group's JPEG 
ii  libpng12-01.2.15~beta5-1 PNG library - runtime
ii  libtiff4  3.8.2-7Tag Image File Format (TIFF) libra
ii  perl  5.8.8-7Larry Wall's Practical Extraction 
ii  zlib1g1:1.2.3-13 compression library - runtime

cupsys-driver-gutenprint recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#426938: git-core: Conflict markers should always have a SHA1

2007-05-31 Thread Bart Massey
Package: git-core
Version: 1:1.5.1.1-1
Severity: wishlist

As of now, the conflict markers generated by merges
sometimes include only a relative symbolic name such as
HEAD.  A SHA1 should also always be included, so that
months later the marker is still meaningful.

Bart Massey
[EMAIL PROTECTED]

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (495, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages git-core depends on:
ii  libc6 2.5-7  GNU C Library: Shared libraries
ii  libcurl3-gnutls   7.15.5-1   Multi-protocol file transfer libra
ii  libdigest-sha1-perl   2.11-2 NIST SHA-1 message digest algorith
ii  liberror-perl 0.15-8 Perl module for error/exception ha
ii  libexpat1 1.95.8-3.4 XML parsing C library - runtime li
ii  perl-modules  5.8.8-7Core Perl modules
ii  zlib1g1:1.2.3-13 compression library - runtime

Versions of packages git-core recommends:
ii  curl  7.15.5-1   Get a file from an HTTP, HTTPS, FT
pn  git-doc   none (no description available)
ii  less  394-4  Pager program similar to more
ii  openssh-client [ssh-client]   1:4.3p2-10 Secure shell client, an rlogin/rsh
ii  patch 2.5.9-4Apply a diff file to an original
ii  rsync 2.6.9-3fast remote file copy program (lik

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#426942: reportbug: Prompt for email subject should identify it as such

2007-05-31 Thread Bart Massey
Package: reportbug
Version: 3.38
Severity: normal

When reportbug prompts for a subject for the bug email, it
should indicate somewhere in the prompt that this is how the
supplied text will be used; otherwise, it is quite tempting
to type a few sentences there.

Bart Massey
[EMAIL PROTECTED]

-- Package-specific info:
** Environment settings:
EDITOR=/home/bart/bin/mi/emacsnw
VISUAL=/home/bart/bin/mi/emacsnw
INTERFACE=text

** /home/bart/.reportbugrc:
reportbug_version 3.38
mode advanced
ui text
email [EMAIL PROTECTED]

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (495, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages reportbug depends on:
ii  apt 0.6.46.4-0.1 Advanced front-end for dpkg
ii  python  2.4.4-2  An interactive high-level object-o
ii  python-central  0.5.13-0.1   register and build utility for Pyt

reportbug recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#310534: acknowledged by developer ([m@mullenweg.com: Re: [debian-bugs@po8.org: Bug#310534: wordpress: does not handle article visibility correctly]])

2005-05-25 Thread Bart Massey
Oops.   That's what I get for sending bug reports in the
middle of the night.  My apologies for the confusion.

Bart Massey
[EMAIL PROTECTED]

References: [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]
Comments: In-reply-to [EMAIL PROTECTED] (Debian Bug Tracking System)
   message dated Tue, 24 May 2005 20:48:08 -0700.

In message [EMAIL PROTECTED] you wrote:
 This is an automatic notification regarding your Bug report
 #310534: wordpress: does not handle article visibility correctly,
 which was filed against the wordpress package.
 
 It has been closed by one of the developers, namely
 Kai Hendry [EMAIL PROTECTED].
 
 Their explanation is attached below.  If this explanation is
 unsatisfactory and you have not received a better one in a separate
 message then please contact the developer, by replying to this email.
 
 Debian bug tracking system administrator
 (administrator, Debian Bugs database)
 
 Received: (at 310534-done) by bugs.debian.org; 25 May 2005 03:37:16 +
 From [EMAIL PROTECTED] Tue May 24 20:37:16 2005
 Return-path: [EMAIL PROTECTED]
 Received: from host-83-146-8-59.bulldogdsl.com (bible) [83.146.8.59] 
   by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
   id 1Damho-0005J4-00; Tue, 24 May 2005 20:37:16 -0700
 Received: from hendry by bible with local (Exim 4.50)
   id 1Dami4-9s-Pg; Wed, 25 May 2005 04:37:32 +0100
 Date: Wed, 25 May 2005 04:37:32 +0100
 From: Kai Hendry [EMAIL PROTECTED]
 To: [EMAIL PROTECTED]
 Cc: [EMAIL PROTECTED]
 Subject: [EMAIL PROTECTED]: Re: [EMAIL PROTECTED]: Bug#310534: wordpress: 
 does not handle article visibility correctly]]
 Message-ID: [EMAIL PROTECTED]
 Mime-Version: 1.0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 User-Agent: Mutt/1.5.9i
 Delivered-To: [EMAIL PROTECTED]
 X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
   (1.212-2003-09-23-exp) on spohr.debian.org
 X-Spam-Status: No, hits=-4.5 required=4.0 tests=BAYES_10,HAS_BUG_NUMBER 
   autolearn=no version=2.60-bugs.debian.org_2005_01_02
 X-Spam-Level: 
 
 Not a bug relating to the Debian package of Wordpress.
 
 Thank you Matt. In future I'll vet these bug reports a bit better. :)
 
 - Forwarded message from Matthew Mullenweg [EMAIL PROTECTED] -
 
 From: Matthew Mullenweg [EMAIL PROTECTED]
 To: Kai Hendry [EMAIL PROTECTED]
 Subject: Re: [EMAIL PROTECTED]: Bug#310534: wordpress: does not handle
  article visibility correctly]
 Date: Tue, 24 May 2005 20:17:58 -0700
 
 Kai Hendry wrote:
 because the CAT_id field was missing.  After some onerous
 debugging, I found that a couple of fields were misnamed in
 visible.php --- renaming them fixed our problem.
 
 There is nothing included with WordPress called visible.php, it must be 
 an unsupported third-party plugin that was added in.
 
 -- 
 Matt Mullenweg
  http://photomatt.net | http://wordpress.org
 http://pingomatic.com | http://cnet.com
 
 - End forwarded message -


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#310534: wordpress: does not handle article visibility correctly

2005-05-24 Thread Bart Massey
Package: wordpress
Version: 1.5.1-1
Severity: normal
Tags: patch


Our wordpress installation (at http://bart-massey.com and
http://bart-massey.com/uplift/) is a bit complex.  After
cleaning up some cruft that was probably our fault in
/etc/wordpress and /etc/apache/conf.d/wordpress, the latest
upgrade still didn't work quite right: hitting the front
page (at http://bart-massey.com/uplift/) and/or pushing the
home button (at the same URL) caused an SQL query error
because the CAT_id field was missing.  After some onerous
debugging, I found that a couple of fields were misnamed in
visible.php --- renaming them fixed our problem.

No idea whether this is also an upstream problem.  A quick
grep through the source found a couple of other places where
the same bug probably occurs, so this patch is not
necessarily exhaustive.

--- wp-content/plugins/visible.php.dist 2005-04-07 11:32:41.0 -0700
+++ wp-content/plugins/visible.php  2005-05-24 00:56:38.017837540 -0700
@@ -211,10 +211,10 @@
if($categories = get_the_category($post-ID)) {
foreach ($categories as $category) {
if(isset ($q['feed'])) {
-   if($wpdb-query(SELECT cat_ID FROM 
cat_visibility WHERE cat_ID=$category-category_id AND feed=1)) {
+   if($wpdb-query(SELECT cat_ID FROM 
cat_visibility WHERE cat_ID=$category-cat_ID AND feed=1)) {
$visible = 1;
}
-   } elseif ($wpdb-query(SELECT cat_ID FROM 
cat_visibility WHERE cat_ID=$category-category_id AND front=1)) {
+   } elseif ($wpdb-query(SELECT cat_ID FROM 
cat_visibility WHERE cat_ID=$category-cat_ID AND front=1)) {
$visible = 1;
}
}


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.10
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages wordpress depends on:
ii  apache [httpd]   1.3.33-6versatile, high-performance HTTP s
ii  mysql-server [virtual-mysql- 4.0.24-10   mysql database server binaries
ii  php4 4:4.3.10-15 server-side, HTML-embedded scripti
ii  php4-mysql   4:4.3.10-15 MySQL module for php4

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]