Bug#1069743: Removal of features from default keepassxc package

2024-05-10 Thread James Lu

Hi,

Chiming in as another regular keepassxc user. When I first saw the 
keepassxc / keepassxc-full split I did not think much of it. But reading 
the comments on the upstream issue has gotten me frustrated.


Please consider resolving this in a way that doesn't break existing 
installations. It's easy to catch these changes when they're presented 
one-by-one when upgrading e.g. a system running testing regularly, but 
they're far more likely to miss when dozens of packages update all at 
once with the next stable release. Either the minimal package should 
only be applied as default for new installations, or the minimal package 
should explicitly warn when attempting to use a feature that's unavailable.


The second part I take issue with is the wording with which this is 
being communicated. There is no need to use charged terminology like 
"feature creep"[1], "crappy version"[2], or "use at your own risk"[3] 
when describing variants. This reads as disrespectful to both upstream 
and the userbase at large - let people decide for themselves what 
features are useful instead of dismissing their use-case outright.


[1]: 
https://salsa.debian.org/debian/keepassxc/-/blob/main/debian/NEWS?ref_type=heads
[2]: 
https://github.com/keepassxreboot/keepassxc/issues/10725#issuecomment-2104401817
[3]: 
https://salsa.debian.org/debian/keepassxc/-/blob/main/debian/control?ref_type=heads#L76-78


Best,
James


OpenPGP_0x2EC3F60DE71C0B9D.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1060326: Removing OBS plugins from ppc64el (unsatisfied B-D on luajit) (Re: #1060326)

2024-03-02 Thread James Lu

(Bumping as it's been a week or so)

Joao, Daniel, do you have any objection to removing these on ppc64el?

Best,
James

On 2024-02-20 20:21, James Lu wrote:

Hi,

Forwarding this along to maintainers of the affected packages. If 
there's no objection, I can look at opening those RM bugs.


(Chiming in here as I'm also affected by obs-studio being kicked from 
testing with looking-glass)


Best,
James

On Sun, 14 Jan 2024 17:16:55 + (UTC) Thorsten Alteholz 
 wrote:

Control: tags -1 + moreinfo

Hi IOhannes,

there are reverse dependencies that need to be taken care of:


Checking reverse dependencies...
# Broken Depends:
obs-3d-effect: obs-3d-effect
obs-advanced-scene-switcher: obs-advanced-scene-switcher
obs-ashmanix-blur-filter: obs-ashmanix-blur-filter
obs-ashmanix-countdown: obs-ashmanix-countdown
obs-color-monitor: obs-color-monitor
obs-command-source: obs-command-source
obs-downstream-keyer: obs-downstream-keyer
obs-gradient-source: obs-gradient-source
obs-move-transition: obs-move-transition
obs-ptz: obs-ptz
obs-scene-as-transition: obs-scene-as-transition
obs-scene-collection-manager: obs-scene-collection-manager
obs-scene-notes-dock: obs-scene-notes-dock
obs-scene-tree-view: obs-scene-tree-view
obs-source-clone: obs-source-clone
obs-source-copy: obs-source-copy
obs-time-source: obs-time-source
obs-transition-table: obs-transition-table
obs-vintage-filter: obs-vintage-filter
obs-websocket: obs-websocket

# Broken Build-Depends:
looking-glass: libobs-dev
obs-3d-effect: libobs-dev (29 >=)
obs-advanced-scene-switcher: libobs-dev (26.1.2 >=)
obs-ashmanix-blur-filter: libobs-dev
obs-ashmanix-countdown: libobs-dev (29 >=)
obs-color-monitor: libobs-dev (29 >=)
obs-command-source: libobs-dev (29 >=)
obs-downstream-keyer: libobs-dev (29 >=)
obs-gradient-source: libobs-dev (29 >=)
obs-move-transition: libobs-dev (28.0.1 >=)
obs-ptz: libobs-dev
obs-scene-as-transition: libobs-dev (29 >=)
obs-scene-collection-manager: libobs-dev (28.0.1 >=)
obs-scene-notes-dock: libobs-dev (29 >=)
obs-scene-tree-view: libobs-dev (29 >=)
obs-source-clone: libobs-dev (29 >=)
obs-source-copy: libobs-dev (29 >=)
obs-time-source: libobs-dev
obs-transition-table: libobs-dev (29 >=)
obs-vintage-filter: libobs-dev (29 >=)
obs-websocket: libobs-dev (26.1 >=)


In case they matter, this needs to be addressed first. Please remove 
the moreinfo tag once that is done.


   Thorsten




OpenPGP_0x2EC3F60DE71C0B9D.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1060326: #1060326,RM: obs-studio [ppc64el] -- ROM; unsatisfied build-dependency

2024-02-20 Thread James Lu

Hi,

Forwarding this along to maintainers of the affected packages. If 
there's no objection, I can look at opening those RM bugs.


(Chiming in here as I'm also affected by obs-studio being kicked from 
testing with looking-glass)


Best,
James

On Sun, 14 Jan 2024 17:16:55 + (UTC) Thorsten Alteholz 
 wrote:

Control: tags -1 + moreinfo

Hi IOhannes,

there are reverse dependencies that need to be taken care of:


Checking reverse dependencies...
# Broken Depends:
obs-3d-effect: obs-3d-effect
obs-advanced-scene-switcher: obs-advanced-scene-switcher
obs-ashmanix-blur-filter: obs-ashmanix-blur-filter
obs-ashmanix-countdown: obs-ashmanix-countdown
obs-color-monitor: obs-color-monitor
obs-command-source: obs-command-source
obs-downstream-keyer: obs-downstream-keyer
obs-gradient-source: obs-gradient-source
obs-move-transition: obs-move-transition
obs-ptz: obs-ptz
obs-scene-as-transition: obs-scene-as-transition
obs-scene-collection-manager: obs-scene-collection-manager
obs-scene-notes-dock: obs-scene-notes-dock
obs-scene-tree-view: obs-scene-tree-view
obs-source-clone: obs-source-clone
obs-source-copy: obs-source-copy
obs-time-source: obs-time-source
obs-transition-table: obs-transition-table
obs-vintage-filter: obs-vintage-filter
obs-websocket: obs-websocket

# Broken Build-Depends:
looking-glass: libobs-dev
obs-3d-effect: libobs-dev (29 >=)
obs-advanced-scene-switcher: libobs-dev (26.1.2 >=)
obs-ashmanix-blur-filter: libobs-dev
obs-ashmanix-countdown: libobs-dev (29 >=)
obs-color-monitor: libobs-dev (29 >=)
obs-command-source: libobs-dev (29 >=)
obs-downstream-keyer: libobs-dev (29 >=)
obs-gradient-source: libobs-dev (29 >=)
obs-move-transition: libobs-dev (28.0.1 >=)
obs-ptz: libobs-dev
obs-scene-as-transition: libobs-dev (29 >=)
obs-scene-collection-manager: libobs-dev (28.0.1 >=)
obs-scene-notes-dock: libobs-dev (29 >=)
obs-scene-tree-view: libobs-dev (29 >=)
obs-source-clone: libobs-dev (29 >=)
obs-source-copy: libobs-dev (29 >=)
obs-time-source: libobs-dev
obs-transition-table: libobs-dev (29 >=)
obs-vintage-filter: libobs-dev (29 >=)
obs-websocket: libobs-dev (26.1 >=)


In case they matter, this needs to be addressed first. Please remove the 
moreinfo tag once that is done.


   Thorsten




OpenPGP_0x2EC3F60DE71C0B9D.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1057763: qt5-style-kvantum: add Qt 6 build

2023-12-07 Thread James Lu

Source: qt5-style-kvantum
Version: 1.0.10-1
Severity: wishlist
Tags: patch

Dear maintainers,

As apps inside Debian migrate from Qt 5 to Qt 6, I noticed that my theme 
configuration stopped working due to missing theme engines on Qt 6.


Kvantum already supports Qt 6, though it's currently a compile time 
option (ENABLE_QT5) that enables one or the other. I've created a merge 
request[1] that adapts the package to run two separate package builds, 
one against Qt 5, and another against Qt 6. As far as I can tell, the 
Arch package[2] uses a similar approach.


I've built and tested the package locally, and it seems to work - tested 
against audacious and wireshark in unstable with the materia-kde theme. 
Changing the active theme in Kvantum Manager updates both Qt 5 and 6 
simultaneously, so it's more or less transparent.


[1]: https://salsa.debian.org/lxqt-team/qt5-style-kvantum/-/merge_requests/7
[2]: 
https://gitlab.archlinux.org/archlinux/packaging/packages/kvantum/-/blob/main/PKGBUILD#L28


Best,
James


OpenPGP_0x2EC3F60DE71C0B9D.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1005061: #1005061 - looking-glass-client: Please package new upstream version

2023-05-19 Thread James Lu

Control: tags 1005061 + patch

Hi all,

I've made a branch of the packaging sources on Salsa and opened a merge 
request at 
https://salsa.debian.org/lhw-guest/looking-glass/-/merge_requests/2


For me, the big game-changer in b6 is integrated SPICE audio support 
using either PipeWire or PulseAudio - this is way easier to configure 
compared to QEMU audio backends. I've built + tested this on a couple of 
Windows 10 VMs and it seems to be working fine.


Looking Glass is one of the key apps that let me use Linux as my daily 
driver, and I'd be happy to co-maintain the package as well.


Best,
James


OpenPGP_0x2EC3F60DE71C0B9D.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Bug#903517: (no subject)

2021-09-04 Thread James Lu
Control: tag -1 - help



Bug#890947: Tag #890947 as unreproducible

2021-05-24 Thread James Lu
Control: tag 890947 + unreproducible

I forgot to follow up with this formally. I've tried changing settings
like font, background, etc. from l-g-g-s locally and never got any sort
of truncation issues.

I suspect that if this happens again, the app will log some errors,
maybe in ~/.xsession-errors or the terminal if you run l-g-g-s from one?

Best,
James



Bug#984851: Re ITA: qalculate-gtk -- Powerful and easy to use desktop calculator

2021-03-14 Thread James Lu
Hi all,

I've been a longtime Qalculate user and I'm also willing to help keep
qalculate-gtk + libqalculate up to date.

My Salsa account is jlu-guest and I've also subscribed myself to the
tracker.

I'll happily extend Norbert's suggestion here:

Maintainer: team+qalcul...@tracker.debian.org
Uploaders: Phil Morrell ,
Norbert Preining ,
James Lu 

Best,
James



Bug#981617: RM: exe-thumbnailer -- ROM; superseded by icoextract

2021-02-02 Thread James Lu
Package: ftp.debian.org
Severity: normal

Dear ftp-masters,

exe-thumbnailer has been superseded by icoextract in sid, which provides
equivalent functionality in the icoextract-thumbnailer package.
Currently src:exe-thumbnailer only includes a dummy transitional package
(gnome-exe-thumbnailer) carried over from stretch.

I've been the upstream maintainer of exe-thumbnailer since 2016 after
taking over from the original Ubuntu upstream. icoextract is a rewrite
of the project in Python that has much better support for large files
and 256x256 (Vista+) app icons.

Best,
James



Bug#947199: ITP: icoextract -- icon extractor for Windows PE files

2019-12-22 Thread James Lu
Package: wnpp
Severity: wishlist
Owner: James Lu 

* Package name: icoextract
  Version : 0.1.0
  Upstream Author : James Lu 
* URL : https://github.com/jlu5/icoextract
* License : MIT/Expat
  Programming Lang: Python
  Description : icon extractor for Windows PE files

icoextract is an icon extractor for Windows PE files (.exe/.dll),
written in Python. It also includes a thumbnailer script
(exe-thumbnailer) for Linux desktops.

This project is intended to supersede the current exe-thumbnailer[1],
which has technical limitations such as not supporting 256x256 (Vista+)
icons.

This package will be maintained in the Debian Wine Team.

Best,
James

[1]: https://github.com/exe-thumbnailer/exe-thumbnailer/issues/17



signature.asc
Description: OpenPGP digital signature


Bug#931728: variety: privacy breach in variety

2019-11-21 Thread James Lu
Control: tags 931728 - patch
Control: severity 931728 wishlist
Control: retitle 931728 Allow disabling online access features

In version 0.7.2-2 I backported a patch adding a privacy policy notice
to Variety's first start - hopefully this addresses the transparency
part of what data Variety collects in order to function.

Unfortunately upstream does not consider a complete offline mode to be a
priority, since the bulk of Variety's features would become unusable.
See
https://github.com/varietywalls/variety/issues/198#issuecomment-510664947
for more background.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#944829: ITP: materia-kde -- Port of the Materia theme to KDE Plasma 5

2019-11-15 Thread James Lu
Package: wnpp
Severity: wishlist
Owner: James Lu 

* Package name: materia-kde
  Version : 2019
  Upstream Author : Alexey Varfolomeev 
* URL : https://github.com/PapirusDevelopmentTeam/materia-kde
* License : GPL-3
  Programming Lang: CSS
  Description : Port of the Materia theme to KDE Plasma 5

materia-kde is a port of the popular Materia GTK theme (materia-gtk-theme)
to the Plasma 5 desktop.

The theme package contains:
  - Aurorae Theme
  - Konsole Color Scheme
  - Kvantum Theme (for Qt 5)
  - Plasma Color Scheme
  - Plasma Desktop Theme
  - Plasma Look-and-Feel Settings
  - Yakuake Skin



Bug#902288: GNOME/nautilus thumbnail helper script from /usr/share/thumbnailers fails with ENOENT due to bwrap

2019-08-17 Thread James Lu
Hello,

It would appear that this affects exe-thumbnailer[1] too: the default
bwrap settings cause thumbnails to be missing entirely on buster / GNOME
3.30.

This issue is fairly new to me, so I'll have to look at what calls in
particular are causing issues with the sandbox. (exe-thumbnailer wraps
around imagemagick, icotools, and msitools to do the bulk of its work,
so it be one of its subprocesses too.)

[1]: https://github.com/exe-thumbnailer/exe-thumbnailer/issues/13

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#932860: wine can not be installed after updating libglib2.0-0 to 2.60

2019-07-23 Thread James Lu
Hi,

It looks like you're trying to install the Wine packages from WineHQ,
which are not the same ones provided by Debian. It doesn't look like the
WineHQ repository has been updated for Bullseye yet, so it's likely
you'll have to wait for them to add those missing builds.

Best,
James

On 2019-07-23 5:02 p.m., fin4478 fin4478 wrote:
> Package: wine32
> Version: 4.0-2
> 
> To prevent warnings in the file .xsession-errors with the Xfce 4.13.3
> desktop libglib2.0-0 must be updated to the version 2.60. This removes
> wine and many of its libraries. Reinstalling wine shows the following
> problems:
> xfce@optipc:~$ sudo aptitude install winehq-staging
> The following NEW packages will be installed:
>   acl{a} glib-networking:i386{a} gstreamer1.0-plugins-base:i386{a} 
>   libasound2-plugins:i386{a} libatk-bridge2.0-0:i386{a} libatk1.0-0:i386{a} 
>   libatspi2.0-0:i386{a} libavcodec58:i386{a} libbz2-1.0:i386{a} 
>   libcairo-gobject2:i386{a} libcolord2:i386{a} libcroco3:i386{a} 
>   libgdbm-compat4:i386{a} libgdbm6:i386{a} libgdk-pixbuf2.0-0:i386{a} 
>   libgstreamer-plugins-base1.0-0:i386{a} libgstreamer1.0-0:i386{a} 
>   libgtk-3-0:i386{a} libharfbuzz0b:i386{a} libieee1284-3{a} 
>   libieee1284-3:i386{a} libjson-glib-1.0-0:i386{a} libmariadb3:i386{a} 
>   libpango-1.0-0:i386{a} libpangocairo-1.0-0:i386{a} 
>   libpangoft2-1.0-0:i386{a} libpci3:i386{a} libperl5.28:i386{a} 
>   librest-0.7-0:i386{a} librsvg2-2:i386{a} librsvg2-common:i386{a} 
>   libsane{a} libsane:i386{a} libsane-common{a} libsensors-config{ab} 
>   libsensors5{a} libsensors5:i386{a} libsnmp-base{a} libsnmp30{a} 
>   libsnmp30:i386{a} libsoup-gnome2.4-1:i386{a} libsoup2.4-1:i386{a} 
>   sane-utils{a} update-inetd{a} wine-staging{a} wine-staging-amd64{a} 
>   wine-staging-i386:i386{a} winehq-staging 
> The following packages will be REMOVED:
>   bind9-host{u} cgroupfs-mount{u} dkms{u} fonts-wine{u} geoip-database{u} 
>   gtk2-engines-xfce{u} i965-va-driver:i386{u} intel-media-va-driver:i386{u} 
>   libasyncns0:i386{u} libavahi-common-data:i386{u} libavahi-core7{u} 
>   libavcodec57:i386{u} libavutil55:i386{u} libbind9-161{u} 
>   libcom-err2:i386{u} libdaemon0{u} libdatrie1:i386{u} libdns1104{u} 
>   libexif12:i386{u} libexo-1-0{u} libfaudio0{u} libflac8:i386{u} 
>   libfstrm0{u} libgcrypt20:i386{u} libgd3:i386{u} libgeoip1{u} 
>   libgeos-3.7.1{u} libgmp10:i386{u} libgomp1:i386{u} libgpm2:i386{u} 
>   libgsoap-2.8.75{u} libgtksourceview-3.0-1{u} 
>   libgtksourceview-3.0-common{u} libhogweed4:i386{u} libice6:i386{u} 
>   libicu63:i386{u} libigdgmm9:i386{u} libintl-perl{u} libintl-xs-perl{u} 
>   libisc1100{u} libisccc161{u} libisccfg163{u} libjbig0:i386{u} 
>   libjim0.77{u} libk5crypto3:i386{u} libkeybinder-3.0-0{u} 
>   libkeyutils1:i386{u} libkrb5support0:i386{u} libllvm7{u} libltdl7:i386{u} 
>   liblwres161{u} liblz4-1:i386{u} libmbim-glib4{u} libmbim-proxy{u} 
>   libmodule-find-perl{u} libmodule-scandeps-perl{u} libnettle6:i386{u} 
>   libnotify-bin{u} libnuma1:i386{u} libp11-kit0:i386{u} 
>   libpixman-1-0:i386{u} libproc-processtable-perl{u} libprotobuf-c1{u} 
>   libqmi-glib5{u} libqmi-proxy{u} libreadline7{u} libsasl2-2:i386{u} 
>   libsasl2-modules:i386{u} libsasl2-modules-db:i386{u} libsm6:i386{u} 
>   libsndfile1:i386{u} libsndio7.0:i386{u} libsort-naturally-perl{u} 
>   libsoxr0:i386{u} libstb0{u} libstb0:i386{u} libswresample2:i386{u} 
>   libsystemd0:i386{u} libtasn1-6:i386{u} libterm-readkey-perl{u} 
>   libv4lconvert0:i386{u} libva-drm1:i386{u} libva-x11-1:i386{u} 
>   libva1:i386{u} libvdpau-va-gl1:i386{u} libvdpau1:i386{u} libvncserver1{u} 
>   libvpx4:i386{u} libwebpmux2:i386{u} libwnck-common{u} libwnck22{u} 
>   libx264-148:i386{u} libx265-95:i386{u} libxcb-render0:i386{u} 
>   libxcb-shm0:i386{u} libxcb-xfixes0:i386{u} libxfce4ui-utils{u} 
>   libxpm4:i386{u} libxtst6:i386{u} libzstd1:i386{u} mesa-va-drivers:i386{u} 
>   mesa-vdpau-drivers:i386{u} needrestart{u} runc{u} tini{u} 
>   usb-modeswitch{u} usb-modeswitch-data{u} va-driver-all:i386{u} 
>   vdpau-driver-all:i386{u} xfce4-appfinder{u} 
> 0 packages upgraded, 48 newly installed, 110 to remove and 15 not upgraded.
> Need to get 173 MB of archives. After unpacking 1,145 MB will be used.
> The following packages have unmet dependencies:
>  libx265-165:i386 : Depends: libnuma1:i386 (>= 2.0.11) but it is not going to 
> be installed
>  libkrb5-3:i386 : Depends: libcom-err2:i386 (>= 1.43.9) but it is not going 
> to be installed
>   Depends: libk5crypto3:i386 (>= 1.15~beta1) but it is not 
> going to be installed
>   Depends: libkeyutils1:i386 (>= 1.5.9) but it is not going 
> to be installed
>   Depends: libkrb5support0:i386 (= 1.17-5) but it is not 
> going to be installed
>  libgssapi-krb5-2:i386 : Depends: libcom-err2:i386 (>= 1.43.9) but it is not 
> going to be installed
>  Depends: libk5crypto3:i386 (>= 1.16) but it is not 
> going to be installed
>  Depends: 

Bug#931728: variety: privacy breach in variety

2019-07-23 Thread James Lu
Control: tags -1 + help

A brief trip upstream reveals that the settings fetching is to (1) rate
limit API calls to prevent going over limits (2) provide usage
statistics for remote APIs that mandate them.

These are sort of tied to the online fetching bits of Variety, so
perhaps a solution might be to have a confirmation window at first run
to opt-in to the online features. I want to work on this soon, but my
knowledge of GTK and Variety's config system aren't super thorough...

Best,
James

On 2019-07-09 10:07 a.m., James Lu wrote:
> Control: forwarded -1 https://github.com/varietywalls/variety/issues/198
> 
> Hi Damyan,
> 
> I've copied this upstream, thanks for spotting this.
> 
> Best,
> James
> 
> On 2019-07-09 9:43 a.m., Damyan Ivanov wrote:
>> Package: variety
>> Version: 0.7.1-2
>> Severity: important
>> Tags: upstream
>>
>> Hi,
>>
>> Thank you for packaging variety. It is a very nice program and does its work 
>> smoothly.
>>
>> Sadly, it contains code which attempts to load "options" from a remove 
>> server 
>> without user's consent. See [1] and [2].
>>
>> [1] 
>> https://sources.debian.org/src/variety/0.7.1-2/variety/VarietyWindow.py/?hl=81#L609
>> [2] 
>> https://sources.debian.org/src/variety/0.7.1-2/variety/VarietyWindow.py/?hl=81#L932
>>
>> I'll prepare a merge request that removes the start of the background thread 
>> which does the fetch. Variety works just fine without it.
>>
>>
>> Thanks for considering,
>> Damyan
>>
>> -- System Information:
>> Debian Release: 10.0
>>   APT prefers unstable-debug
>>   APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'stable'), 
>> (1, 'experimental')
>> Architecture: amd64 (x86_64)
>>
>> Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
>> Kernel taint flags: TAINT_OOT_MODULE
>> Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), 
>> LANGUAGE=bg_BG.UTF-8 (charmap=UTF-8)
>> Shell: /bin/sh linked to /bin/dash
>> Init: systemd (via /run/systemd/system)
>> LSM: AppArmor: enabled
>>
>> Versions of packages variety depends on:
>> ii  gir1.2-gdkpixbuf-2.0 2.38.1+dfsg-1
>> ii  gir1.2-gexiv2-0.10   0.10.9-1
>> ii  gir1.2-glib-2.0  1.58.3-2
>> ii  gir1.2-gtk-3.0   3.24.5-1
>> ii  gir1.2-notify-0.70.7.7-4
>> ii  gir1.2-pango-1.0 1.42.4-6
>> ii  imagemagick  8:6.9.10.23+dfsg-2.1
>> ii  imagemagick-6.q16 [imagemagick]  8:6.9.10.23+dfsg-2.1
>> ii  python3  3.7.3-1
>> ii  python3-bs4  4.7.1-1
>> ii  python3-cairo1.16.2-1+b1
>> ii  python3-configobj5.0.6-3
>> ii  python3-dbus 1.2.8-3
>> ii  python3-gi   3.30.4-1
>> ii  python3-gi-cairo 3.30.4-1
>> ii  python3-lxml 4.3.3-2
>> ii  python3-pil  5.4.1-2
>> ii  python3-pkg-resources41.0.1-1
>> ii  python3-requests 2.21.0-1
>>
>> Versions of packages variety recommends:
>> ii  gir1.2-appindicator3-0.1  0.4.92-7
>> ii  python3-httplib2  0.11.3-2
>>
>> Versions of packages variety suggests:
>> pn  feh | nitrogen  
>> ii  gnome-shell-extension-appindicator  22-1
>>
>> -- no debconf information
>>
> 



signature.asc
Description: OpenPGP digital signature


Bug#931728: variety: privacy breach in variety

2019-07-09 Thread James Lu
Control: forwarded -1 https://github.com/varietywalls/variety/issues/198

Hi Damyan,

I've copied this upstream, thanks for spotting this.

Best,
James

On 2019-07-09 9:43 a.m., Damyan Ivanov wrote:
> Package: variety
> Version: 0.7.1-2
> Severity: important
> Tags: upstream
> 
> Hi,
> 
> Thank you for packaging variety. It is a very nice program and does its work 
> smoothly.
> 
> Sadly, it contains code which attempts to load "options" from a remove server 
> without user's consent. See [1] and [2].
> 
> [1] 
> https://sources.debian.org/src/variety/0.7.1-2/variety/VarietyWindow.py/?hl=81#L609
> [2] 
> https://sources.debian.org/src/variety/0.7.1-2/variety/VarietyWindow.py/?hl=81#L932
> 
> I'll prepare a merge request that removes the start of the background thread 
> which does the fetch. Variety works just fine without it.
> 
> 
> Thanks for considering,
> Damyan
> 
> -- System Information:
> Debian Release: 10.0
>   APT prefers unstable-debug
>   APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'stable'), 
> (1, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
> Kernel taint flags: TAINT_OOT_MODULE
> Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), 
> LANGUAGE=bg_BG.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
> 
> Versions of packages variety depends on:
> ii  gir1.2-gdkpixbuf-2.0 2.38.1+dfsg-1
> ii  gir1.2-gexiv2-0.10   0.10.9-1
> ii  gir1.2-glib-2.0  1.58.3-2
> ii  gir1.2-gtk-3.0   3.24.5-1
> ii  gir1.2-notify-0.70.7.7-4
> ii  gir1.2-pango-1.0 1.42.4-6
> ii  imagemagick  8:6.9.10.23+dfsg-2.1
> ii  imagemagick-6.q16 [imagemagick]  8:6.9.10.23+dfsg-2.1
> ii  python3  3.7.3-1
> ii  python3-bs4  4.7.1-1
> ii  python3-cairo1.16.2-1+b1
> ii  python3-configobj5.0.6-3
> ii  python3-dbus 1.2.8-3
> ii  python3-gi   3.30.4-1
> ii  python3-gi-cairo 3.30.4-1
> ii  python3-lxml 4.3.3-2
> ii  python3-pil  5.4.1-2
> ii  python3-pkg-resources41.0.1-1
> ii  python3-requests 2.21.0-1
> 
> Versions of packages variety recommends:
> ii  gir1.2-appindicator3-0.1  0.4.92-7
> ii  python3-httplib2  0.11.3-2
> 
> Versions of packages variety suggests:
> pn  feh | nitrogen  
> ii  gnome-shell-extension-appindicator  22-1
> 
> -- no debconf information
> 



signature.asc
Description: OpenPGP digital signature


Bug#928154: qt5ct: very slow startup due to enumerating icon themes

2019-04-28 Thread James Lu
Package: qt5ct
Version: 0.37-1
Severity: normal

Dear maintainers,

On my system I have several large icon themes installed (Numix-Circle,
Moka, Papirus, ...), and this causes qt5ct to start up very slowly.

Running qt5ct in gdb and breaking during the delay consistently points
to IconThemePage::findIcon being called a lot.

(gdb) bt
#0  __getdents64 (fd=12, buf=buf@entry=0x55f46060 "DF0",
nbytes=32768) at ../sysdeps/unix/sysv/linux/getdents64.c:27
#1  0x769e5214 in __GI___readdir64 (dirp=0x55f46030) at
../sysdeps/posix/readdir.c:65
#2  0x770d3140 in QFileSystemIterator::advance
(this=this@entry=0x55b954b0, fileEntry=..., metaData=...) at
io/qfilesystemiterator_unix.cpp:81
#3  0x77066e2c in QDirIteratorPrivate::advance
(this=0x5595f470) at
../../include/QtCore/../../src/corelib/tools/qvector.h:87
#4  0x77067688 in QDirIteratorPrivate::QDirIteratorPrivate
(this=0x5595f470, entry=..., Python Exception 
Type is not a template.:
nameFilters=, filters=..., flags=..., resolveEngine=) at
io/qdiriterator.cpp:179
#5  0x77067835 in QDirIterator::QDirIterator
(this=0x7fffd6d8, dir=..., flags=...) at
../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:148
#6  0x77065b7d in QDirPrivate::initFileLists
(this=0x55f27900, dir=...) at
../../include/QtCore/../../src/corelib/global/qflags.h:120
#7  0x77061e16 in QDir::entryInfoList (this=0x7fffd898,
Python Exception  Type is not a template.:
nameFilters=, filters=..., sort=...) at io/qdir.cpp:1448
#8  0x77061eaf in QDir::entryInfoList
(this=this@entry=0x7fffd898, filters=..., filters@entry=...,
sort=..., sort@entry=...) at io/qdir.cpp:1376
#9  0x555773a0 in IconThemePage::findIcon (this=0x5590bb80,
themePath="/usr/share/icons/Numix/index.theme", size=24,
name="document-save") at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qflags.h:120
#10 0x55577d90 in IconThemePage::findIcon (this=0x5590bb80,
themePath="/usr/share/icons/Numix-Circle/index.theme", size=24,
name="document-save") at iconthemepage.cpp:211
#11 0x555787e8 in IconThemePage::loadTheme (this=0x5590bb80,
path="/usr/share/icons/Numix-Circle/index.theme") at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:693
#12 0x555799f0 in IconThemePage::loadThemes
(this=0x5590bb80) at iconthemepage.cpp:98
#13 0x55579ec3 in IconThemePage::IconThemePage
(this=0x5590bb80, parent=) at iconthemepage.cpp:45
#14 0x55567ad0 in MainWindow::MainWindow (this=0x7fffdf50,
parent=) at mainwindow.h:43
#15 0x55566721 in main (argc=, argv=) at main.cpp:53
(gdb)

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#928089: Acknowledgement (chromium: crash when opening a new instance)

2019-04-27 Thread James Lu
OK, I admit I forgot to check the bug list.

I do believe this should be a higher severity, since it can result in
actual work being lost (web forms, etc.). This would also warn people
with apt-listbugs installed when they try to upgrade the package.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#928089: chromium: crash when opening a new instance

2019-04-27 Thread James Lu
Package: chromium
Version: 74.0.3729.108-1
Severity: grave
Justification: renders average web browser use impossible

Hello,

On a recent upgrade to Chromium 74.0.3729.108-1, any attempts to open a
new instance of the browser (via the app launcher or by clicking an
external link) hang for several seconds before crashing the previous
Chromium instance and opening a new window. This causes work to be
potentially lost.

Downgrading to version 73.0.3683.75-1 in testing makes the problem go away.

I can reproduce this with two systems, one running the NVIDIA binary
driver (version 418.56-2 in unstable) and another running an Intel iGPU.
Based on the command line output I've seen, I think the graphics setup
might be related?

On my NVIDIA system, running chromium from the terminal gives this:

$ chromium
[17554:17554:0427/125307.938566:ERROR:vaapi_wrapper.cc(335)]
vaInitialize failed: unknown libva error

Then I tried to install vdpau-va-driver and got this instead:

james@intrepid:~$ chromium
[13422:13422:0427/124503.122545:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122582:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 0 and entrypoint 1
[13422:13422:0427/124503.122591:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122596:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 1 and entrypoint 1
[13422:13422:0427/124503.122601:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122606:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 2 and entrypoint 1
[13422:13422:0427/124503.122612:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122616:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 3 and entrypoint 1
[13422:13422:0427/124503.122621:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122626:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 5 and entrypoint 1
[13422:13422:0427/124503.122632:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122636:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 6 and entrypoint 1
[13422:13422:0427/124503.122640:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122643:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 7 and entrypoint 1
[13422:13422:0427/124503.122647:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122650:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 8 and entrypoint 1
[13422:13422:0427/124503.122654:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122658:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 9 and entrypoint 1
[13422:13422:0427/124503.122662:ERROR:vaapi_wrapper.cc(684)]
vaQuerySurfaceAttributes failed VA error: invalid parameter
[13422:13422:0427/124503.122666:ERROR:vaapi_wrapper.cc(574)]
GetMaxResolution failed for va_profile 10 and entrypoint 1
[13375:13375:0427/124511.868642:ERROR:http_bridge.cc(127)] Not
implemented reached in virtual void
syncer::HttpBridgeFactory::OnSignalReceived()
[13375:13403:0427/124511.949307:ERROR:browser_process_sub_thread.cc(217)]
Waited 13 ms for network service

On my Intel system I see the following:
$ chromium

(chromium:17594): Gtk-WARNING **: 13:04:19.122: Theme parsing error:
gtk.css:68:35: The style property GtkButton:child-displacement-x is
deprecated and shouldn't be used anymore. It will be removed in a future
version

(chromium:17594): Gtk-WARNING **: 13:04:19.122: Theme parsing error:
gtk.css:69:35: The style property GtkButton:child-displacement-y is
deprecated and shouldn't be used anymore. It will be removed in a future
version

(chromium:17594): Gtk-WARNING **: 13:04:19.122: Theme parsing error:
gtk.css:73:46: The style property
GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be
used anymore. It will be removed in a future version
[17638:17638:0427/130419.283245:ERROR:sandbox_linux.cc(368)]
InitializeSandbox() called with multiple threads in process gpu-process.
[17638:17638:0427/130439.725484:ERROR:buffer_manager.cc(488)]
[.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <-
error from previous GL command

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#927732: unblock: variety/0.7.1-2 (pre-approval)

2019-04-22 Thread James Lu
Control: tags -1 moreinfo

Hi Niels,

I've uploaded the package and it should be in unstable now.

Best,
James

On 2019-04-21 10:45 p.m., Niels Thykier wrote:
> Control: tags -1 moreinfo confirmed
> 
> James Lu:
>> Package: release.debian.org
>> Severity: normal
>> User: release.debian@packages.debian.org
>> Usertags: unblock
>>
>> Dear Release Team,
>>
>> Please consider unblocking variety 0.7.1-2. I've backported a couple of
>> fixes from the newest upstream version, which fix a couple of subtle but
>> annoying bugs. The changelog is as follows:
>>
>> variety (0.7.1-2) unstable; urgency=medium
>>
>>   * Backport bugfixes from Variety 0.7.2:
>> - fix-crash-on-help-version.patch: Don't forward --help or --version to
>>   running Variety instances, as this causes it to crash.
>> - fix-spurious-error-when-analyzing-gifs.patch: Fix spurious
>>   FileNotFoundError when analyzing GIFs inside a wallpaper folder
>>
>>  -- James Lu   Sun, 21 Apr 2019 19:10:58 -0700
>>
>> The debdiff is attached.
>>
>> Best,
>> James
>>
> 
> Hi James,
> 
> Please go ahead with this upload and remove the moreinfo tag when it is
> in unstable and ready to be unblocked.
> 
> Thanks,
> ~Niels
> 



Bug#927732: unblock: variety/0.7.1-2 (pre-approval)

2019-04-21 Thread James Lu
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Dear Release Team,

Please consider unblocking variety 0.7.1-2. I've backported a couple of
fixes from the newest upstream version, which fix a couple of subtle but
annoying bugs. The changelog is as follows:

variety (0.7.1-2) unstable; urgency=medium

  * Backport bugfixes from Variety 0.7.2:
- fix-crash-on-help-version.patch: Don't forward --help or --version to
  running Variety instances, as this causes it to crash.
- fix-spurious-error-when-analyzing-gifs.patch: Fix spurious
  FileNotFoundError when analyzing GIFs inside a wallpaper folder

 -- James Lu   Sun, 21 Apr 2019 19:10:58 -0700

The debdiff is attached.

Best,
James
diff -Nru variety-0.7.1/debian/changelog variety-0.7.1/debian/changelog
--- variety-0.7.1/debian/changelog  2018-10-28 20:45:18.0 -0700
+++ variety-0.7.1/debian/changelog  2019-04-21 19:10:58.0 -0700
@@ -1,3 +1,13 @@
+variety (0.7.1-2) unstable; urgency=medium
+
+  * Backport bugfixes from Variety 0.7.2:
+- fix-crash-on-help-version.patch: Don't forward --help or --version to
+  running Variety instances, as this causes it to crash.
+- fix-spurious-error-when-analyzing-gifs.patch: Fix spurious
+  FileNotFoundError when analyzing GIFs inside a wallpaper folder
+
+ -- James Lu   Sun, 21 Apr 2019 19:10:58 -0700
+
 variety (0.7.1-1) unstable; urgency=medium
 
   [ Jelmer Vernooij ]
diff -Nru variety-0.7.1/debian/patches/fix-crash-on-help-version.patch 
variety-0.7.1/debian/patches/fix-crash-on-help-version.patch
--- variety-0.7.1/debian/patches/fix-crash-on-help-version.patch
1969-12-31 16:00:00.0 -0800
+++ variety-0.7.1/debian/patches/fix-crash-on-help-version.patch
2019-04-21 19:10:58.0 -0700
@@ -0,0 +1,33 @@
+Description: Don't forward --help or --version to running Variety instances, 
as this causes it to crash.
+ Parse options before checking for running instance to show help.
+Author: Pedro Romano 
+Origin: upstream, 
https://github.com/varietywalls/variety/commit/4977f86ffc662ae3909cf97f6baa892ea17b4fc5
+Applied-Upstream: 0.7.2
+---
+ variety/__init__.py | 6 --
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+--- a/variety/__init__.py
 b/variety/__init__.py
+@@ -148,6 +148,9 @@
+ 
+ arguments = sys.argv[1:]
+ 
++# validate arguments
++options, args = VarietyWindow.VarietyWindow.parse_options(arguments)
++
+ bus = dbus.SessionBus()
+ # ensure singleton
+ if bus.request_name(DBUS_KEY) != 
dbus.bus.REQUEST_NAME_REPLY_PRIMARY_OWNER:
+@@ -161,10 +164,9 @@
+ safe_print(result)
+ return
+ 
+-# validate arguments and set up logging
++# set up logging
+ # set_up_logging must be called after the DBus checks, only by one 
running instance,
+ # or the log file can be corrupted
+-options, args = VarietyWindow.VarietyWindow.parse_options(arguments)
+ set_up_logging(options.verbose)
+ 
+ if options.verbose >= 2:
diff -Nru 
variety-0.7.1/debian/patches/fix-spurious-error-when-analyzing-gifs.patch 
variety-0.7.1/debian/patches/fix-spurious-error-when-analyzing-gifs.patch
--- variety-0.7.1/debian/patches/fix-spurious-error-when-analyzing-gifs.patch   
1969-12-31 16:00:00.0 -0800
+++ variety-0.7.1/debian/patches/fix-spurious-error-when-analyzing-gifs.patch   
2019-04-21 19:10:58.0 -0700
@@ -0,0 +1,45 @@
+Description: Fix spurious FileNotFoundError when analyzing GIFs inside a 
wallpaper folder.
+ The path being passed to the helper function was not correct.
+Author: James Lu 
+Origin: upstream, 
https://github.com/varietywalls/variety/commit/25714cd13e80602a5e08bf02ab1baf2dd9e1a97e
+Bug: https://github.com/varietywalls/variety/issues/132
+Applied-Upstream: 0.7.2
+---
+ variety/Util.py | 9 ++---
+ 1 file changed, 6 insertions(+), 3 deletions(-)
+
+diff --git a/variety/Util.py b/variety/Util.py
+index 86c70de..e038ff0 100644
+--- a/variety/Util.py
 b/variety/Util.py
+@@ -363,6 +363,7 @@ class Util:
+ def list_files(files=(), folders=(), filter_func=(lambda f: True), 
max_files=1, randomize=True):
+ count = 0
+ for filepath in files:
++logger.debug(lambda: 'checking file %s against filter_func %s' % 
(filepath, filter_func))
+ if filter_func(filepath) and os.access(filepath, os.R_OK):
+ count += 1
+ yield filepath
+@@ -379,14 +380,16 @@ class Util:
+ random.shuffle(files)
+ random.shuffle(subFolders)
+ for filename in files:
+-if filter_func(filename):
++logger.debug(lambda: 'checking file %s against 
filter_func %s (root=%s)' % (filename, filter_func, root))
++path = os.path.join(root, filename)
++if filter_func(p

Bug#898448: Makes vinagre segfault on authentication failure

2018-11-04 Thread James Lu
Dear maintainers,

With libfreerdp2-2 2.0.0~git20180411.1.7a7b1802+dfsg1-2+b1 and vinagre
3.22.0-5, I get a very similar crash if the target host is unreachable
or does not have RDP open.
When running in gdb, an "Error connecting to host." dialog pops up and
vinagre immediately segfaults afterwards.

The backtrace is as follows:

(gdb) bt full
#0  clear_context_free (clear=0x1) at ./libfreerdp/codec/clear.c:1216
i = 
clear = 0x1
i = 
i = 
#1  0x76d8b67d in codecs_free (codecs=0x55de8560) at
./libfreerdp/core/codecs.c:213
No locals.
#2  0x76d85907 in freerdp_disconnect (instance=0x55dd0ff0)
at ./libfreerdp/core/freerdp.c:508
rc = 1
rdp = 
#3  0x55584769 in vinagre_rdp_tab_dispose
(object=0x55c8a880) at plugins/rdp/vinagre-rdp-tab.c:182
rdp_tab = 0x55c8a880
priv = 0x55c8a690
#4  0x7734dc13 in g_object_unref () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#5  0x778e0099 in gtk_container_remove () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#6  0x55570748 in vinagre_notebook_close_tab (nb=0x55b6e240,
tab=0x55c8a880) at vinagre/vinagre-notebook.c:697
position = 0
notebook = 0x55b6e240
previous_active_tab = 0x55c8a880
__func__ = "vinagre_notebook_close_tab"
#7  0x55583074 in idle_close (tab=0x55c8a880) at
plugins/rdp/vinagre-rdp-tab.c:272
No locals.
#8  0x77268ae8 in g_main_context_dispatch () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#9  0x77268ed8 in ?? () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#10 0x77268f6c in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#11 0x7742f13d in g_application_run () from
/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
No symbol table info available.
#12 0x555655cf in main (argc=1, argv=0x7fffe118) at
vinagre/vinagre-main.c:196
app = 0x557ed1a0
res = 

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#911420: ITP: numix-icon-theme-square -- Square icon theme from the Numix project

2018-10-19 Thread James Lu
Package: wnpp
Severity: wishlist
Owner: James Lu 

* Package name: numix-icon-theme-square
  Version : 18-10-03-1
  Upstream Author : Numix Project Ltd. 
* URL : https://numixproject.github.io/
* License : GPL
  Programming Lang: N/A (it's an image set that can be installed as is)
  Description : Square icon theme from the Numix project

Numix Square is an extensive icon theme for Linux desktops, with over
4000 application icons. It is developed by the Numix project and serves
as a companion to the base Numix icon theme (numix-icon-theme).

The Numix Circle variant of the icon theme (numix-icon-theme-circle) has
been packaged for some months now. This package will likewise be
maintained under the Debian Desktop Themes Team.



Bug#894112: qalculate-gtk: please package/update qalculate to 2.4 released 11/04/2018

2018-10-19 Thread James Lu
Control: retitle 895465 qalculate-gtk: please update qalculate to 2.6.2
released 2018-08-13
Control: tags 895465 + patch
Control: tags 894112 + patch

Dear Maintainer,

Some months ago I experimented with bringing newer libqalculate /
qalculate-gtk to Debian, using the packaging here as a base. Hopefully
these can be useful in bringing updates into Debian proper:

libqalculate:
https://github.com/utopia-repository/libqalculate/tree/for-upstream
qalculate-gtk:
https://github.com/utopia-repository/qalculate-gtk/tree/for-upstream

qalculate-gtk required minimal changes to update, besides bumping the
libqalculate-dev requirement to 2.6.x.

libqalculate had another ABI bump (from SONAME 14 in experimental/2.2.x
to SONAME 19). I added Breaks+Replaces for libqalculate6*,
libqalculate14* packages, which should resolve #894112. Since
libqalculate has a few build-deps, I'm assuming that pushing this to
unstable would involve a package transition - I have not tested any
reverse deps yet.

Also it appears that upstream switched to doxygen for building
libqalculate docs (at least for sources based off Git), so I
incorporated that into the build process as well.

Best,
James




signature.asc
Description: OpenPGP digital signature


Bug#905783: dunno if I should add this to the current bug or make a new bug -

2018-09-21 Thread James Lu
Hi Shirish,

Re title: Filing new bugs for each distinct problem / error is easiest
to manage on any BTS :)

Also, was the original autostart issue fixed? Everything else previously
mentioned here should be fixed as of 0.7.0.

On 2018-09-21 01:55 AM, shirish शिरीष wrote:
> Dear James,
> 
> After today's update, I took the plunge and removed -
> 
> ~/.config$ rm -rf variety
> 
> $ variety
> ERROR: 2018-09-21 14:10:30,552: _generate_pencil_tile() 'Could not
> generate pencil_tile.png'
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/variety/VarietyWindow.py", line
> 302, in _generate_pencil_tile
> "-motion-blur 0x20+135 -charcoal 2 -resize 50%% %s" %
> pipes.quote(pencil_tile_filename.encode('utf8')))
>   File "/usr/lib/python3.6/shlex.py", line 314, in quote
> if _find_unsafe(s) is None:
> TypeError: cannot use a string pattern on a bytes-like object

Fixed in
https://github.com/varietywalls/variety/commit/a6eaec2e5f5ef3836919d4ce70303cf94899f83c
for next release

> WARNING: 2018-09-21 14:10:30,653: load_history() 'Could not load
> history file, continuing without it, no worries'
> WARNING: 2018-09-21 14:10:30,846: create_menu() 'Variety Slideshow is
> not installed. This is an optional extension adding pan-and-zoom
> slideshows to Variety: see
> https://github.com/peterlevi/variety-slideshow for details'
> 
> (variety:1800): Gdk-CRITICAL **: 14:10:30.994:
> gdk_window_thaw_toplevel_updates: assertion
> 'window->update_and_descendants_freeze_count > 0' failed
> ERROR: 2018-09-21 14:10:31,145: image_ok() 'Error in image_ok for file
> /usr/share/backgrounds/bluebird.svg'
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/variety/VarietyWindow.py", line
> 1478, in image_ok
> i = PILImage.open(img)
>   File "/usr/lib/python3/dist-packages/PIL/Image.py", line 2622, in open
> % (filename if filename else fp))
> OSError: cannot identify image file '/usr/share/backgrounds/bluebird.svg'
> ERROR: 2018-09-21 14:10:31,319: image_ok() 'Error in image_ok for file
> /usr/share/backgrounds/greybird.svg'
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/variety/VarietyWindow.py", line
> 1478, in image_ok
> i = PILImage.open(img)
>   File "/usr/lib/python3/dist-packages/PIL/Image.py", line 2622, in open
> % (filename if filename else fp))
> OSError: cannot identify image file '/usr/share/backgrounds/greybird.svg'
> ERROR: 2018-09-21 14:10:31,605: image_ok() 'Error in image_ok for file
> /usr/share/backgrounds/albatross-wall-source.svg'
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/variety/VarietyWindow.py", line
> 1478, in image_ok
> i = PILImage.open(img)
>   File "/usr/lib/python3/dist-packages/PIL/Image.py", line 2622, in open
> % (filename if filename else fp))
> OSError: cannot identify image file
> '/usr/share/backgrounds/albatross-wall-source.svg'
> 
> Looks like variety doesn't understand svg files :(

This might be a worthwhile feature request, though I have no idea how
common desktop environment support for SVG backgrounds is.

> Seems the scripts are not regenerated and guess variety has to be
> purged and installed as new .
> 
> Did that and still came with the error above.

They should be copied even if the pencil_tile generation breaks?
Double check whether ~/.config/variety/scripts/ looks correct.

> Also nice to see variety using libayatana-appindicator instead of the
> way out appindicator.

:)

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#905783: marked as done (variety doesn't startup in mate and throws a bunch of python warnings)

2018-09-11 Thread James Lu
Control: notfixed bdfproxy 0.3.9-3
Control: reopen -1

Hello,

I think you got the wrong bug number, reopening

James

On 2018-09-11 01:42 PM, Debian Bug Tracking System wrote:
> Your message dated Tue, 11 Sep 2018 20:39:33 +
> with message-id 
> and subject line Bug#905783: fixed in bdfproxy 0.3.9-3
> has caused the Debian Bug report #905783,
> regarding variety doesn't startup in mate and throws a bunch of python 
> warnings
> to be marked as done.
> 
> This means that you claim that the problem has been dealt with.
> If this is not the case it is now your responsibility to reopen the
> Bug report if necessary, and/or fix the problem forthwith.
> 
> (NB: If you are a system administrator and have no idea what this
> message is talking about, this may indicate a serious mail system
> misconfiguration somewhere. Please contact ow...@bugs.debian.org
> immediately.)
> 
> 



signature.asc
Description: OpenPGP digital signature


Bug#863383: Reclaiming ITP #863383

2018-08-29 Thread James Lu
Control: owner 863383 -1
Control: retitle 863383 ITP: numix-icon-theme-circle -- Circle icon theme from 
the Numix project

For posterity, numix-icon-theme-circle is currently in NEW[1]

[1]: https://ftp-master.debian.org/new/numix-icon-theme-circle_18-04-04-1.html

Best,
James



Bug#906620: Please build with --enable-xnvctrl to enable Nvidia support

2018-08-18 Thread James Lu
Package: xfce4-sensors-plugin
Version: 1.3.0-1
Tags: patch
Severity: wishlist

Dear maintainer,

When enabled at build time, xfce4-sensors-plugin can show GPU
temperatures when using the proprietary Nvidia driver. The attached
patch enables this feature and adds libxnvctrl-dev to build-deps
accordingly.

I've tested this locally and it seems to work fine.

Best,
James
From 9e0cf0200bb70baba81f6829aad452d1d6ffe33e Mon Sep 17 00:00:00 2001
From: James Lu 
Date: Sat, 18 Aug 2018 14:45:49 -0700
Subject: [PATCH] Build with --enable-xnvctrl to enable Nvidia support

---
 debian/control | 3 ++-
 debian/rules   | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 09b2c26..f119bb6 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,8 @@ Build-Depends: debhelper (>= 9),
libxfce4panel-2.0-dev,
libxfce4ui-2-dev,
libxml-parser-perl,
-   libxml2-dev
+   libxml2-dev,
+   libxnvctrl-dev
 Standards-Version: 4.1.4
 Homepage: http://goodies.xfce.org/
 Vcs-Git: https://salsa.debian.org/xfce-team/goodies/xfce4-sensors-plugin.git
diff --git a/debian/rules b/debian/rules
index 4f0a15c..3f32fd0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,7 +6,7 @@ export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 	dh $@ --parallel
 
 override_dh_auto_configure:
-	dh_auto_configure -- --enable-libsensors=yes --enable-procacpi --enable-hddtemp=yes --enable-notification --disable-static
+	dh_auto_configure -- --enable-libsensors=yes --enable-procacpi --enable-hddtemp=yes --enable-notification --disable-static --enable-xnvctrl
 
 override_dh_makeshlibs:
 	dh_makeshlibs  -X debian/xfce4-sensors-plugin/usr/lib/$(DEB_HOST_MULTIARCH)/xfce4/modules/libxfce4sensors.so.*.*.*
-- 
2.18.0



signature.asc
Description: OpenPGP digital signature


Bug#901875: chromium: 2 non chrome extensions installed by default. crypto mining and pdf reader

2018-08-15 Thread James Lu
Crypto miner? what even...

Actually, these two are built in Chromium features that happen to show
up as extensions. For example, CryptoTokenExtension is actually used for
hardware two-factor authentication[1][2].

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=412308
[2]:
https://askubuntu.com/questions/844090/what-is-cryptotokenextension-in-chromium-extensions

I'm not a maintainer here, but I'm pretty convinced this is not a bug
and can be closed.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#905783: variety doesn't startup in mate and throws a bunch of python warnings

2018-08-15 Thread James Lu
Forwarding my last reply to the bug tracker as I had missed it:

On 2018-08-10 07:29 AM, James Lu wrote:
> 
> 
> On 2018-08-10 12:11 AM, shirish शिरीष wrote:
>> Reply in-line :-
>>
>> On 09/08/2018, James Lu  wrote:
>>> Control: tags -1 +moreinfo
>>>
>>> Hi,
>>>
>>
>> Hi,
>>
>>> On 2018-08-09 06:18 AM, shirish शिरीष wrote:
>>>> Package: variety
>>>> Version: 0.6.9-1
>>>> Severity: normal
>>>>
>>>> Dear Maintainer,
>>>>
>>>> First I checked why variety isn't startup applications because I had
>>>> put it in startup applications.
>>>>
>>>> It used to work for quite sometime but recently didn't start. I saw
>>>> for some reason it
>>>> was now showing as variety only instead of /usr/bin/variety which I
>>>> fixed. I have shared
>>>> screenshots of both.
>>>
>>> I don't see how this would make a difference unless you have a
>>> conflicting "variety" binary elsewhere. What does "which variety" on the
>>> command line show you?
>>>
>>
>> $ which variety
>> /usr/bin/variety
> 
> That looks OK..
> 
>>>>
>>>> Then I tried triggering variety via command-line and got the following
>>>> messages -
>>>>
>>>> $ variety> WARNING: 2018-08-09 18:09:04,714: create_menu() 'Variety
>>>> Slideshow is
>>>> not installed. This is an optional extension adding pan-and-zoom
>>>> slideshows to Variety: see
>>>> https://github.com/peterlevi/variety-slideshow for details'
>>>> /home/shirish/.config/variety/scripts/set_wallpaper: line 121: [: ==:
>>>> unary operator expected
>>>>
>>>> (variety:23253): Gdk-CRITICAL **: 18:09:05.488:
>>>> gdk_window_thaw_toplevel_updates: assertion
>>>> 'window->update_and_descendants_freeze_count > 0' failed
>>>> /home/shirish/.config/variety/scripts/set_wallpaper: line 121: [: ==:
>>>> unary operator expected
>>>
>>> If you haven't edited set_wallpaper directly, delete
>>> ~/.config/variety/scripts/set_wallpaper and restart Variety. This will
>>> make Variety copy over the newest set_wallpaper (this bug was fixed in
>>> set_wallpaper since 0.6.7)
>>>
>>
>> shirish@debian:~/.config/variety/scripts$ rm -rf set_wallpaper
>>
>> I restarted variety and on another console tab shows this now -
>>
>> ~/.config/variety/scripts$ ls -lh
>> total 16K
>> -rwxr-xr-x 1 shirish shirish 1.6K Mar 22 06:32 get_wallpaper
>> -rwxr-xr-x 1 shirish shirish 9.5K Aug 10 12:28 set_wallpaper
>>
>> dunno if I should also delete the get_wallpaper script and it
>> will take the new one or not. For now Not touching till you say so.
>>
> 
> get_wallpaper is not affected, don't worry about that.
> 
>>>> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
>>>> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
>>>> certificate verification is strongly advised. See:
>>>> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>>>>   InsecureRequestWarning)
>>>> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
>>>> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
>>>> certificate verification is strongly advised. See:
>>>> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>>>>   InsecureRequestWarning)
>>>> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
>>>> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
>>>> certificate verification is strongly advised. See:
>>>> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>>>>   InsecureRequestWarning)
>>>> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
>>>> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
>>>> certificate verification is strongly advised. See:
>>>> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>>>>   InsecureRequestWarning)
>>>> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
>>>> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
>>>> certificate verification is strongly advised. See:
>>>> https://urllib

Bug#905783: variety doesn't startup in mate and throws a bunch of python warnings

2018-08-09 Thread James Lu
Control: tags -1 +moreinfo

Hi,

On 2018-08-09 06:18 AM, shirish शिरीष wrote:
> Package: variety
> Version: 0.6.9-1
> Severity: normal
> 
> Dear Maintainer,
> 
> First I checked why variety isn't startup applications because I had
> put it in startup applications.
> 
> It used to work for quite sometime but recently didn't start. I saw
> for some reason it
> was now showing as variety only instead of /usr/bin/variety which I
> fixed. I have shared
> screenshots of both.

I don't see how this would make a difference unless you have a
conflicting "variety" binary elsewhere. What does "which variety" on the
command line show you?

> 
> Then I tried triggering variety via command-line and got the following
> messages -
> 
> $ variety> WARNING: 2018-08-09 18:09:04,714: create_menu() 'Variety Slideshow 
> is
> not installed. This is an optional extension adding pan-and-zoom
> slideshows to Variety: see
> https://github.com/peterlevi/variety-slideshow for details'
> /home/shirish/.config/variety/scripts/set_wallpaper: line 121: [: ==:
> unary operator expected
> 
> (variety:23253): Gdk-CRITICAL **: 18:09:05.488:
> gdk_window_thaw_toplevel_updates: assertion
> 'window->update_and_descendants_freeze_count > 0' failed
> /home/shirish/.config/variety/scripts/set_wallpaper: line 121: [: ==:
> unary operator expected

If you haven't edited set_wallpaper directly, delete
~/.config/variety/scripts/set_wallpaper and restart Variety. This will
make Variety copy over the newest set_wallpaper (this bug was fixed in
set_wallpaper since 0.6.7)

> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)
> /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:860:
> InsecureRequestWarning: Unverified HTTPS request is being made. Adding
> certificate verification is strongly advised. See:
> https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
>   InsecureRequestWarning)

We'll likely fix this in 0.7.0:
https://github.com/varietywalls/variety/pull/48#discussion_r208742549

> /home/shirish/.config/variety/scripts/set_wallpaper: line 121: [: ==:
> unary operator expected
> 
> I see a bunch of ssl warnings along with line 121, line 121 of the
> script says -
> 
> if [ ${KDE_FULL_SESSION} == "true" ]; then
> 
> but this is mate-desktop. Also that gdk-critical error seems something
> to look at.

OK, maybe the Gdk-CRITICAL stuff is related but it looks like a bit of a
red herring. Reason being that Variety is still working after displaying
that error. It's more important to know if there actual missing
elements, e.g. a broken tray icon.

> I do not know whether it's a debian issue or something that upstream
> needs to take a look at ?

I happen to be upstream so I'm looking at it either way ;)
> 
> Look forward to your response to know what to do .
> 
> Is there a possibility of having variety-slideshow as a binary too ?

You can request a new package through the RFP process:
https://wiki.debian.org/RFP

> -- System Information:
> 

Bug#903517: Variety takes a long time to quit and ends up force killed by a watchdog thread

2018-07-10 Thread James Lu
Package: variety
Version: 0.6.3-5
Severity: normal
Tags: help
Control: found -1 0.6.7-1
Control: fixed -1 0.6.9-1

Variety versions < 0.6.8 essentially hang if you try to quit (at least,
when you do so right after starting the program). If run from a
terminal, Variety shows that it is killed by its own watchdog thread
(force_exit) after a few seconds.

I suspect that some thread is locking up due to VRTY.org being closed
down[1], because the issue is gone in 0.6.8 and later (where all of this
integration code was removed). However, I have *not* been able to
isolate the exact cause of the freeze, and a giant patch removing a
large portion of code is probably too invasive to backport.

Interestingly enough, I have not been able to reproduce with 0.6.3 even
more serious startup hangs that sporadically hit 0.6.7-1 in Ubuntu
bionic.[2]

[1]: https://bugs.launchpad.net/variety/+bug/1635912
[2]: https://bugs.launchpad.net/variety/+bug/1770187



signature.asc
Description: OpenPGP digital signature


Bug#902634: RFS: flashplugin-nonfree/1:3.7+nmu1 [NMU] [RC] -- Adobe Flash Player - browser plugin

2018-06-28 Thread James Lu
Package: sponsorship-requests
Severity: important
Control: block 851066 by -1
Control: block 889804 by -1

Dear mentors,

I'm looking for a sponsor for an NMU of flashplugin-nonfree, which fixes
some old bugs making the downloader unusable since at least January
2017[1]. The maintainer (Bart Martens) has not responded to that bug at
all, nor has anyone replied to the intent to NMU that I posted last week[2].

This upload includes a patch from Gianluigi Tiesi which removes all
references to Bart's people.debian.org page, which has not seen any
updates during his apparent absence. These include tarball checksum and
GPG verification checks via his site that are *removed* since Adobe
doesn't seem to provide them (instead, they rely on HTTPS).

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851066
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851066;msg=127

At the same time, I've also included changes to fix some trivial but
non-RC bugs[3][4].

[3]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862144
[4]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885119

The source of the package is available at mentors[5] as well as Salsa[6]
- note that the current package in unstable never defined a Vcs, so I'm
only using the latter so far as tracking for these fixes.

[5]: https://mentors.debian.net/package/flashplugin-nonfree
[6]: https://salsa.debian.org/jlu-guest/flashplugin-nonfree/

A debdiff (as of writing) is attached, which should be equivalent to the
Salsa diff
https://salsa.debian.org/jlu-guest/flashplugin-nonfree/compare/f9cdfd78a...master

The RFS info:

 * Package name: flashplugin-nonfree
   Version : 1:3.7+nmu1
   Upstream Author : Bart Martens 
 * URL : http://wiki.debian.org/FlashPlayer
 * License : GPL-2
   Section : web

Full changelog:

flashplugin-nonfree (1:3.7+nmu1) unstable; urgency=medium

  * Non-maintainer upload.
  * Remove broken references to https://people.debian.org/~bartm/; patch
from
Gianluigi Tiesi (Closes: #851066, #889804, #884262)
- This removes checksum verification of the Flash tarballs and PGP
  validation of get-upstream-version.pl, which were previously
provided by
  that site.
- It also rewrites the upstream version parsing to fetch from Adobe
  directly.
- Remaining changes to this patch: don't use --no-check-certificate
  with wget
  * Add Recommends: libwebkit2gtk-4.0-37-gtk2. (Closes: #862144)
  * Remove remaining calls to gpg and the dependency on gnupg.
(Closes: #885119)

 -- James Lu   Fri, 22 Jun 2018 16:27:56 -0700

Best,
James
diff -Nru flashplugin-nonfree-3.7/debian/changelog 
flashplugin-nonfree-3.7+nmu1/debian/changelog
--- flashplugin-nonfree-3.7/debian/changelog2016-08-03 22:49:06.0 
-0700
+++ flashplugin-nonfree-3.7+nmu1/debian/changelog   2018-06-22 
16:27:56.0 -0700
@@ -1,3 +1,21 @@
+flashplugin-nonfree (1:3.7+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove broken references to https://people.debian.org/~bartm/; patch from
+Gianluigi Tiesi (Closes: #851066, #889804, #884262)
+- This removes checksum verification of the Flash tarballs and PGP
+  validation of get-upstream-version.pl, which were previously provided by
+  that site.
+- It also rewrites the upstream version parsing to fetch from Adobe
+  directly.
+- Remaining changes to this patch: don't use --no-check-certificate
+  with wget
+  * Add Recommends: libwebkit2gtk-4.0-37-gtk2. (Closes: #862144)
+  * Remove remaining calls to gpg and the dependency on gnupg.
+(Closes: #885119)
+
+ -- James Lu   Fri, 22 Jun 2018 16:27:56 -0700
+
 flashplugin-nonfree (1:3.7) unstable; urgency=medium
 
   * update-flashplugin-nonfree: Delete old cached get-upstream-version.pl.
diff -Nru flashplugin-nonfree-3.7/debian/control 
flashplugin-nonfree-3.7+nmu1/debian/control
--- flashplugin-nonfree-3.7/debian/control  2016-08-03 22:49:06.0 
-0700
+++ flashplugin-nonfree-3.7+nmu1/debian/control 2018-06-22 15:45:59.0 
-0700
@@ -8,7 +8,8 @@
 
 Package: flashplugin-nonfree
 Architecture: i386 amd64
-Depends: debconf | debconf-2.0, wget, gnupg | gnupg2, libatk1.0-0, libcairo2, 
libfontconfig1, libfreetype6, libgcc1, libglib2.0-0, libgtk2.0-0 (>= 2.14), 
libnspr4, libnss3, libpango1.0-0, libstdc++6, libx11-6, libxext6, libxt6, 
libcurl3-gnutls, binutils, ${misc:Depends}, ${shlibs:Depends}
+Depends: debconf | debconf-2.0, wget, libatk1.0-0, libcairo2, libfontconfig1, 
libfreetype6, libgcc1, libglib2.0-0, libgtk2.0-0 (>= 2.14), libnspr4, libnss3, 
libpango1.0-0, libstdc++6, libx11-6, libxext6, libxt6, libcurl3-gnutls, 
binutils, ${misc:Depends}, ${shlibs:Depends}
+Recommends: libwebkit2gtk-4.0-37-gtk2
 Pre-Depends: ca-certificates
 Suggests: iceweasel, firefox-esr, konqueror-nsplugins, 
ttf-mscorefonts-installer, fonts-dejavu, ttf-xfree86-nonfree, 
flashplugin-nonfree-extrasound [i386], hal-flash
 Conflicts: flashplugin

Bug#897928:

2018-06-26 Thread James Lu
Hello,

Unstable has version 5.2.12-dfsg-3 right now which supersedes[1] the
version you mentioned. This version seems to be be blocked from testing
because of an Xserver migration, see [2].

[1]:
http://metadata.ftp-master.debian.org/changelogs/contrib/v/virtualbox/unstable_changelog
[2]: https://tracker.debian.org/pkg/virtualbox

Best,
James

On 2018-06-26 05:42 AM, Andrea Villa wrote:
> Any news on when virtualbox/5.2.10-dfsg-7 will be uploaded to the Debian
> FTP?
> This bug is marked as resolved, but there is no package available to
> users with this bug fixed.
> 
> Sincerely,
> 
> Andrea



Bug#851066: flashplugin-nonfree: Mismatch between detected and available versions (Download file not available at people.debian.org)

2018-06-22 Thread James Lu
Hello,

I can confirm that this patch works and fixes not only this bug but some
others[1][2] affecting the download process too.

I'll look at making an NMU (currently staged in Salsa[3]), which will
also fix a couple of unrelated but trivial bugs[4][5]. The changes are
effectively at
https://salsa.debian.org/jlu-guest/flashplugin-nonfree/compare/f9cdfd78a...master

[1]: https://bugs.debian.org/889804
[2]: https://bugs.debian.org/884262
[3]: https://salsa.debian.org/jlu-guest/flashplugin-nonfree/commits/master
[4]: https://bugs.debian.org/862144
[5]: https://bugs.debian.org/885119

Best,
James

On Wed, 13 Dec 2017 08:41:11 +0100 Gianluigi Tiesi 
wrote:
> Package: flashplugin-nonfree
> Followup-For: Bug #851066
> 
> please use the attached script, it gets and parses vesion directly without 
> sha or checksums



signature.asc
Description: OpenPGP digital signature


Bug#896550: kazam: Binding 'R' failed!

2018-05-31 Thread James Lu
Control: severity -1 important
Control: retitle -1 kazam does not work under Wayland

Hi everyone,

I did some digging on this issue in a VM running buster/testing + GNOME,
only to find that Kazam does not work at all on Wayland.

The keybinding errors are caused by Keybinder not supporting
Wayland[1][2], but I've also found several other problems. Some of these
can be worked around by running kazam with GDK_BACKEND=x11 set, but
others are not.

- Screenshots fail under Wayland unless GDK_BACKEND=x11 is set:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/kazam/app.py", line 567, in
cb_counter_finished
self.grabber.grab()
  File "/usr/lib/python3/dist-packages/kazam/backend/grabber.py", line
146, in grab
c_picbuf.composite(self.pixbuf, 0, 0, w - 1, h - 1,
AttributeError: 'NoneType' object has no attribute 'composite'

- Choosing to record a window under Wayland fails because libwnck only
supports X11 (worked around with GDK_BACKEND=x11):

(kazam:3789): Wnck-WARNING **: 13:08:48.693: libwnck is designed to work
in X11 only, no valid display found
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/kazam/frontend/window_select.py",
line 111, in cb_button_press_event
screen.force_update()
AttributeError: 'NoneType' object has no attribute 'force_update'

- Screen recording under Wayland shows a black screen with only the
cursor, even when GDK_BACKEND=x11 is set

In this case, no explicit errors are shown.



All of these issues are Wayland specific and do not affect GNOME on Xorg
or other X11-based desktops. I'm therefore lowering the severity.

Best,
James

[1]: https://github.com/kupferlauncher/keybinder/issues/11
[2]: https://github.com/Guake/guake/issues/1109



signature.asc
Description: OpenPGP digital signature


Bug#899785: exe-thumbnailer: Invalid maintainer address pkg-wine-pa...@lists.alioth.debian.org

2018-05-24 Thread James Lu
Control: tags 899785 + pending

Hello,

This will be fixed in the next release (0.10.0-3), which is currently
staged in Salsa at https://salsa.debian.org/jlu-guest/exe-thumbnailer
(I've pinged my usual sponsor about it already)

Best,
James

On 2018-05-24 12:43 AM, Christoph Biedl wrote:
> Package: src:exe-thumbnailer
> Version: 0.10.0-2
> Severity: serious
> User: ad...@alioth-lists.debian.net
> Usertag: alioth-lists-maintainer
> 
> Dear uploader of exe-thumbnailer,
> 
> as you've probably heard, Debian's alioth services are shutting down.
> This affects your package exe-thumbnailer since the list address
> pkg-wine-pa...@lists.alioth.debian.org used in the Maintainer: field
> was not transferred to the alioth-lists service that provides a
> continuation for the lists in the @lists.alioth.debian.org domain.
> 
> Addresses that were not migrated have been disabled some time  ago. As
> a result your package is now in violation of a "must" in the Debian
> policy (3.3, working email address), making it unfit for release.
> 
> Please fix this before long. Among other reasons, keep in mind bug
> reports and important notifications about your package might not reach
> you.
> 
> Your options:
> 
> * Upload another version with a new maintainer address of your choice,
> 
> * Migrate the list to the new system. This is still possible,
>   please appoint a Debian developer as a list owner first, then
>   contact the alioth lists migration team 
>   and provide all the necessary information.
> 
>   More information about the new service can be found here:
>   
> 
> * More options, even if imperfect, can be found at
>   
> 
> 
> The first option is probably suitable only if the address was used just
> in a small number of packages since this requires an upload for each of
> them. To our knowledge, the usage count of
> pkg-wine-pa...@lists.alioth.debian.org is 1.
> 
> The second option is available for a limited time only, by end of
> May 2018 the most. So if you're interested in going this way, start the
> process as soon as possible.
> 
> Note, as mails to the maintainer address will not get through, this
> bugreport is Cc'ed (X-Debbugs-CC:) to all uploaders of the package.
> 
> Regards,
> 
> Christoph and some alioth-lists maintainers
> 



Bug#898641: variety: please package upstream variety 0.6.8

2018-05-14 Thread James Lu
Hello,

Actually, I (the maintainer here) was the same person who synced the
packaging back upstream, so it wouldn't make much of a difference
personally. :)

FWIW 0.6.8 was a bit rushed and led to some regressions[1], so I'll skip
that and upload the next version (0.6.9) which I plan to tag today.

[1]:
https://github.com/varietywalls/variety/commit/b4f12693bddf5fefc1e41d6e22903c4f5273f348

Best,
James

On 2018-05-14 07:50 AM, shirish शिरीष wrote:
> Package: variety
> Version: 0.6.7-1
> Severity: wishlist
> 
> Dear Maintainer,
> 
> Just saw that the upstream has made a new release of variety and also
> done some changes in the /debian/ directory which should make for
> easier packaging. See
> https://github.com/varietywalls/variety/tree/master/debian. Look
> forward to see the new version in Debian soonish.
> 
> -- System Information:
> Debian Release: buster/sid
>   APT prefers testing
>   APT policy: (900, 'testing'), (500, 'unstable-debug'), (500,
> 'testing-debug'), (100, 'experimental'), (100, 'unstable'), (1,
> 'experimental-debug')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.16.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8), LANGUAGE=en_IN:en
> (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
> 
> Versions of packages variety depends on:
> ii  gir1.2-gdkpixbuf-2.0 2.36.11-2
> ii  gir1.2-gexiv2-0.10   0.10.8-1
> ii  gir1.2-glib-2.0  1.56.1-1
> ii  gir1.2-gtk-3.0   3.22.29-3
> ii  gir1.2-notify-0.70.7.7-3
> ii  gir1.2-pango-1.0 1.42.0-1
> ii  imagemagick  8:6.9.9.39+dfsg-1
> ii  imagemagick-6.q16 [imagemagick]  8:6.9.9.39+dfsg-1
> ii  python   2.7.15~rc1-1
> ii  python-bs4   4.6.0-1
> ii  python-cairo 1.16.2-1
> ii  python-configobj 5.0.6-2
> ii  python-dbus  1.2.6-1
> ii  python-gi-cairo  3.28.2-1
> ii  python-pil   4.3.0-2
> ii  python-pycurl7.43.0.1-0.2
> ii  python-requests  2.18.4-2
> ii  python2.72.7.15-1
> 
> Versions of packages variety recommends:
> ii  gir1.2-appindicator3-0.1  0.4.92-5
> ii  python-httplib2   0.9.2+dfsg-1
> 
> Versions of packages variety suggests:
> ii  feh
> 2.23.2-1
> pn  gnome-shell-extension-appindicator | gnome-shell-extension-top-ic  
> 
> -- no debconf information
> 



signature.asc
Description: OpenPGP digital signature


Bug#822989: HTTP 500 error after logging in to alioth SSO

2018-05-11 Thread James Lu
Dear SSO team / server admins,

When I try to sign on to sso.debian.org with my Alioth (-guest) account,
I am redirected to https://sso.debian.org/alioth/certs/ where I get a
HTTP 500 error.

The contents are as follows:


Internal Server Error
The server encountered an internal error or misconfiguration and was
unable to complete your request.

Please contact the server administrator at debian-ad...@lists.debian.org
to inform them of the time this error occurred, and the actions you
performed just before this error.

More information about this error may be available in the server error log.

Apache Server at sso.debian.org Port 443



My password does not contain any non-ASCII characters, so I believe this
is a separate issue from bug 780460 (which was mentioned earlier in the
discussion for bug 822989).

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#898066: New mailing list: debian-wine (move from alioth)

2018-05-06 Thread James Lu
Hello everyone,

As the current exe-thumbnailer maintainer I'm seconding this request.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#893759: variety: launching variety gives quite a few python 2.7 warnings

2018-05-02 Thread James Lu
Control: tags 893759 + fixed-upstream upstream

Hello,

The "unsupported format" error detailed here has been fixed in upstream
Git[1] and will be available in the next release.

Best,
James

[1]:
https://github.com/varietywalls/variety/commit/1a834b3912ba3b0cacf94706b397a8e10180f23e



signature.asc
Description: OpenPGP digital signature


Bug#897385: Existence of Dropbox plugin is not documented

2018-05-01 Thread James Lu
Package: src:dolphin-plugins
Version: 4:18.04.0-1
Severity: minor

Dear maintainers,

The dolphin-plugins package provides a Dropbox integration plugin[1],
which works well but isn't documented in e.g. the package description.
This makes it fairly difficult to find.

Because Dropbox is not technically a VCS, perhaps it would also make
sense to split it into a separate package for better searchability.

Best,
James

[1]: https://packages.debian.org/sid/amd64/dolphin-plugins/filelist



Bug#893759: variety: launching variety gives quite a few python 2.7 warnings

2018-03-26 Thread James Lu
Hello,

This actually looks like three different bugs.

The first traceback (relating to
/usr/share/images/desktop-base/desktop-background) seems to involve
misdetecting image file formats somewhere. To help debug this further,
could you reply with the output of:

ls /etc/alternatives/desktop-background -lah

For the second error (cannot identify image file), I suspect a corrupt
image file. Does the file it mentions
(/home/shirish/.config/variety/Downloaded/flickr_user_www_flickr_com_photos_peter_levi__user_id_93647178_N00_/7527884976_7d72041417_o.jpg)
seem like a working JPEG? If not, try deleting it and see if the issue
disappears.

The "unary operator expected" issue is a mistake on my part and will be
fixed in the next upstream release (0.6.7)

Hope this helps,
James




signature.asc
Description: OpenPGP digital signature


Bug#890947: lightdm-gtk-greeter-settings: l-g-g-settings truncate /etc/lightdm/lightdm-gtk-greeter.conf

2018-03-10 Thread James Lu
Hi Yves-Alexis,

It might be helpful to include the contents of
/etc/lightdm/lightdm-gtk-greeter.conf.d/*, as well as the
lightdm-gtk-greeter.conf before and after attempting to modify it using
l-g-g-s.

Toggling the "Redefine indicators" option seems to work fine here with a
single conf file and with a split setup: I tested briefly by copying my
background entry from lightdm-gtk-greeter.conf into a new file under
/etc/lightdm/lightdm-gtk-greeter.conf.d/. That said, I haven't tried the
external indicators feature as I'm honestly not sure how to set it up -
I don't know if there even are relevant indicator libs on my system.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#887169: libc6: recent upgrade to 2.26-3 broke Steam games (Civ5)

2018-01-14 Thread James Lu
Hello,

The GLIBC_TUNABLES solution indeed works. Thanks for the quick response!

Best,
James

On 2018-01-14 03:22 PM, Aurelien Jarno wrote:
> clone 887169 -1
> reassign -1 gcc-7
> retitle -1 gcc-7: missed optimization of glibc strspn SSE 4.2 variant
> forwarded -1 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81481
> block 887169 by -1
> thanks
> 
> On 2018-01-14 10:35, James Lu wrote:
>> Package: libc6
>> Version: 2.26-3
>> Severity: normal
>>
>> Dear maintainers,
>>
>> On a recent glibc upgrade on buster/sid (first to 2.26-2 and then
>> 2.26-3), one Steam game (Civilization V) consistently segfaults on startup.
>>
>> Similar issues have been reported in Arch Linux[1], Fedora[2], and
>> OpenSUSE[3], where the consensus was that building glibc with
> 
> From what I get about the above reported issues, this bug is caused by:
> - the Steam games not following the Linux/x86 ABI wrt stack alignement
> - the SSE4.2 version of the strspn function needing to push an SSE
>   register to the stack when build with GCC 7, due to a missed
>   optimization.
> 
>> -mstackrealign fixed the issue. (I haven't been able to get such a local
>> build working though)
> 
> I don't think it is actually the consensus, only Arch Linux has chosen
> this solution, and building the whole glibc with this option will have
> an impact of the performances for all binaries, not only the broken
> Steam ones. I therefore don't think it's the right way to fix the bug.
> 
> Instead it looks like fixing PR81481 [1] on the GCC 7 side, and then
> rebuilding glibc is the way to go. I am therefore cloning this bug to
> gcc-7 so that it can happens.
> 
> In the meantime I guess you can run the Steam games by disabling SSE4.2
> optimized function using the glibc tunables. Run the game with the
> GLIBC_TUNABLES environment variable defined as follow:
> 
>   GLIBC_TUNABLES=glibc.tune.hwcaps=-SSE4_2
> 
> Aurelien
> 
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81481
> 



Bug#887169: libc6: recent upgrade to 2.26-3 broke Steam games (Civ5)

2018-01-14 Thread James Lu
Package: libc6
Version: 2.26-3
Severity: normal

Dear maintainers,

On a recent glibc upgrade on buster/sid (first to 2.26-2 and then
2.26-3), one Steam game (Civilization V) consistently segfaults on startup.

Similar issues have been reported in Arch Linux[1], Fedora[2], and
OpenSUSE[3], where the consensus was that building glibc with
-mstackrealign fixed the issue. (I haven't been able to get such a local
build working though)

[1]:
https://bugs.archlinux.org/task/54136?project=0=id=desc=glibc
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1471427
[3]: https://bugzilla.opensuse.org/show_bug.cgi?id=1048861

The gdb traceback is as follows:

Thread 14 "Civ5XP" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xedaffb40 (LWP 30672)]
__strspn_sse42 (s=0xedafb148 "# This file is part of PulseAudio.\n",
a=0xe696ec2d " \t\n") at ../sysdeps/x86_64/multiarch/strspn-c.c:74
74  ../sysdeps/x86_64/multiarch/strspn-c.c: No such file or directory.
(gdb) bt
#0  __strspn_sse42 (s=0xedafb148 "# This file is part of PulseAudio.\n",
a=0xe696ec2d " \t\n") at ../sysdeps/x86_64/multiarch/strspn-c.c:74
#1  0xe6933896 in parse_line (state=0xedafb128) at
pulsecore/conf-parser.c:85
#2  pa_config_parse (filename=0xe6be4510 "/etc/pulse/client.conf",
f=0xe6bd89b0, t=0xedafc1b0, proplist=0x0, use_dot_d=true, userdata=0x0)
at pulsecore/conf-parser.c:204
#3  0xe69250cb in pa_client_conf_load (c=0xe6bac7c0, load_from_x11=true,
load_from_env=true) at pulse/client-conf.c:153
#4  0xe69b10a4 in pa_context_new_with_proplist (mainloop=0xe6bc3bd0,
name=0xedafc340 "Civ5XP", p=0x0) at pulse/context.c:171
#5  0xe69b120e in pa_context_new (mainloop=0xe6bc3bd0, name=0xedafc340
"Civ5XP") at pulse/context.c:103
#6  0xf7839f48 in ?? () from ./libopenal.so.1
#7  0xf783a4ab in ?? () from ./libopenal.so.1
#8  0xf783ce06 in ?? () from ./libopenal.so.1
#9  0xf78120a3 in alcOpenDevice () from ./libopenal.so.1
#10 0x09126f34 in YUV12 ()
#11 0x091264a2 in YUV12 ()
#12 0x09113bee in check_for_pending_io ()
#13 0x09114188 in BinkOpen ()
#14 0x085f7553 in ASL::PlayBinkMovieGL(char const*, float, unsigned int,
unsigned int, bool*) ()
#15 0x0884c26c in PlayMovieState::Begin() ()
#16 0x086e0fc3 in Civ5App::PlayOpeningMovie() ()
#17 0x086e1c46 in Civ5App::Init(char const*) ()
#18 0x0865b3ed in WinMain ()
#19 0x085f5487 in ?? ()
#20 0x085d8e3e in ThreadHANDLE::ThreadProc(void*) ()
#21 0xf7b6b326 in start_thread (arg=0xedaffb40) at pthread_create.c:465
#22 0xf79b42b6 in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:108

Best,
James



Bug#885562: RFS: lightdm-gtk-greeter-settings/1.2.2-1

2017-12-27 Thread James Lu
Package: sponsorship-requests
Severity: normal

Dear mentors,

I'm looking for a sponsor for my package "lightdm-gtk-greeter-settings".
This package is already in the Debian archive, but my last sponsor
(Christian Kastner) has been inactive for some months and has since
suggested that I open a new RFS.

 * Package name: lightdm-gtk-greeter-settings
   Version : 1.2.2-1
   Upstream Author : Sean Davis 
 * URL : https://launchpad.net/lightdm-gtk-greeter-settings
 * License : GPL-3
   Section : x11

It builds those binary packages:
lightdm-gtk-greeter-settings - settings editor for the LightDM GTK+
Greeter

To access further information about this package, please see:
https://mentors.debian.net/package/lightdm-gtk-greeter-settings

Alternatively, one can download the package with dget using this command:

 dget -x
https://mentors.debian.net/debian/pool/main/l/lightdm-gtk-greeter-settings/lightdm-gtk-greeter-settings_1.2.2-1.dsc

The changelog for this version is as following:

lightdm-gtk-greeter-settings (1.2.2-1) unstable; urgency=medium

  * New upstream release.
  * patches: drop, applied upstream.
  * Bump standards version to 4.1.2, no changes needed.
  * Remove alternate recommends on gksu. Closes: #885547

Thanks in advance,
James



signature.asc
Description: OpenPGP digital signature


Bug#882197: stretch-pu: package variety/0.6.3-5+deb9u1

2017-11-19 Thread James Lu
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Dear Release Team,

I've prepared an update for Variety to fix some shell injection bugs caused by
crafted filenames. These fixes are backported from the 0.6.6 release which is
currently in unstable.

The debdiff is attached, and the full changelog is below:

variety (0.6.3-5+deb9u1) stretch; urgency=medium

  * Backport various security fixes from Variety 0.6.6:
- Fix shell injection on deleting files to trash, from upstream commit
https://github.com/varietywalls/variety/commit/475a5e076b9c8c7c83176214f84455dc78834723
- Fix shell injection in filter and clock with specially crafted
  filenames; upstream commit
https://github.com/varietywalls/variety/commit/65722237baa996b0ef2389cea693bfeeba62b224
- Harden ImageMagick calls against potential shell injection:
https://github.com/varietywalls/variety/commit/a7c134ecd494bb878c73df9f65cb838dbb57413a

Best,
James

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500,
'testing'), (450, 'unstable'), (101, 'experimental'), (1, 'experimental-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8),
LANGUAGE=en_CA.utf8 (charmap=UTF-8)
diff -Nru variety-0.6.3/debian/changelog variety-0.6.3/debian/changelog
--- variety-0.6.3/debian/changelog  2017-05-06 16:43:32.0 -0700
+++ variety-0.6.3/debian/changelog  2017-11-14 12:42:11.0 -0800
@@ -1,3 +1,16 @@
+variety (0.6.3-5+deb9u1) stretch; urgency=medium
+
+  * Backport various security fixes from Variety 0.6.6:
+- Fix shell injection on deleting files to trash, from upstream commit
+  
https://github.com/varietywalls/variety/commit/475a5e076b9c8c7c83176214f84455dc78834723
+- Fix shell injection in filter and clock with specially crafted
+  filenames; upstream commit
+  
https://github.com/varietywalls/variety/commit/65722237baa996b0ef2389cea693bfeeba62b224
+- Harden ImageMagick calls against potential shell injection:
+  
https://github.com/varietywalls/variety/commit/a7c134ecd494bb878c73df9f65cb838dbb57413a
+
+ -- James Lu <bitfl...@gmail.com>  Tue, 14 Nov 2017 12:42:11 -0800
+
 variety (0.6.3-5) unstable; urgency=medium
 
   * Add fix-autoscroll-high-cpu.patch backported from upstream Bzr revision
diff -Nru 
variety-0.6.3/debian/patches/0001-Fix-shell-injection-on-deleting-to-trash-via-special.patch
 
variety-0.6.3/debian/patches/0001-Fix-shell-injection-on-deleting-to-trash-via-special.patch
--- 
variety-0.6.3/debian/patches/0001-Fix-shell-injection-on-deleting-to-trash-via-special.patch
1969-12-31 16:00:00.0 -0800
+++ 
variety-0.6.3/debian/patches/0001-Fix-shell-injection-on-deleting-to-trash-via-special.patch
2017-11-14 12:42:11.0 -0800
@@ -0,0 +1,65 @@
+From 475a5e076b9c8c7c83176214f84455dc78834723 Mon Sep 17 00:00:00 2001
+From: James Lu <ja...@overdrivenetworks.com>
+Date: Sun, 10 Sep 2017 10:39:13 -0700
+Subject: [PATCH 1/3] Fix shell injection on deleting to trash via specially
+ crafted filenames
+
+Rewrite this code in subprocess.call (which doesn't spawn a shell by default), 
and explicitly check whether trash programs are installed before running them.
+---
+ variety/VarietyWindow.py | 31 +--
+ 1 file changed, 25 insertions(+), 6 deletions(-)
+
+diff --git a/variety/VarietyWindow.py b/variety/VarietyWindow.py
+index b99cd1a..c9bb770 100644
+--- a/variety/VarietyWindow.py
 b/variety/VarietyWindow.py
+@@ -43,6 +43,10 @@ import urlparse
+ import webbrowser
+ from PIL import Image as PILImage
+ 
++# Replacement for shutil.which, which (no pun intended) only exists on Python 
3.3+
++# unless we want another 3rd party dependency.
++from distutils.spawn import find_executable
++
+ random.seed()
+ logger = logging.getLogger('variety')
+ 
+@@ -1721,14 +1725,29 @@ class VarietyWindow(Gtk.Window):
+ def _go():
+ self.smart.report_file(file, 'trash', async=False)
+ 
+-command = 'gvfs-trash "%s" || trash-put "%s" || kfmclient 
move "%s" trash:/' % (file, file, file)
+-logger.info(lambda: "Running trash command %s" % command)
+-result = os.system(command.encode('utf8'))
+-if result != 0:
+-logger.error(lambda: "Trash resulted in error code 
%d" % result)
++command = ''
++if find_executable('gvfs-trash'):
++command = ['gvfs-trash', file.encode('utf-8')]
++elif find_executable('trash-put'):
++command = ['trash-put', file.encode('utf-8')]
++elif f

Bug#878114: racket: Print Definitions does not work, creates empty pages instead

2017-10-09 Thread James Lu
Package: racket
Version: 6.10.1+dfsg1-1

Dear maintainer,

I recently noticed that the "Print Definitions" option in Racket does
not work, and creates empty files instead. Regardless of the printer I
pick (I tried GTK's "Print to File", cups-pdf, and my physical printer's
Preview), the only output I get is empty page(s).

I've attached a sample .rkt file and the PDF file I got when trying to
print it.

Best,
James


test.pdf
Description: Adobe PDF document
;; The first three lines of this file were inserted by DrRacket. They record 
metadata
;; about the language level of this file in a form that our tools can easily 
process.
#reader(lib "htdp-beginner-reader.ss" "lang")((modname test) 
(read-case-sensitive #t) (teachpacks ()) (htdp-settings #(#t constructor 
repeating-decimal #f #t none #f () #f)))
; this is a comment
(define abc 123)

signature.asc
Description: OpenPGP digital signature


Bug#822246: ITP: qt5ct -- Qt5 configuration tool

2017-09-02 Thread James Lu
Hi again,

With some experimentation, I replaced the contents of
/etc/X11/Xsession.d/99qt5ct with the following:

# Enable qt5ct by default unless another PLATFORMTHEME option is set
# or KDE is running.
if [ -z "$QT_QPA_PLATFORMTHEME" ] && [ "$XDG_CURRENT_DESKTOP" != "KDE" ]
then
export QT_QPA_PLATFORMTHEME=qt5ct
fi

This seemed to work: the end result is that qt5ct is enabled on Xfce,
GNOME and Budgie, but not enabled on Plasma 5. I also went ahead and
removed the QT_PLATFORMTHEME and QT_PLATFORM_PLUGIN defines because they
aren't necessary based on the upstream readme and my own testing.

A git-style patch with this change is attached.

Best,
James

On 01/09/17 07:31 AM, Lisandro Damián Nicanor Pérez Meyer wrote:
> On 27 August 2017 at 17:03, James Lu <bitfl...@gmail.com> wrote:
>> Hi everyone,
>>
>> From what I read at
>> https://forum.antergos.com/topic/6487/qt5ct-has-priority-over-standard-plasma-settings-app/2,
>> Lisandro's concerns are correct and qt5ct does appear to override
>> Plasma's settings entirely. However, since qt5ct requires an Xsession
>> file[1] to be enabled by default, could one solution be having the
>> script exit silently if it finds any KDE environment variables? (This is
>> assuming that the order at which vars are set make this possible, but I
>> haven't verified that)
> 
> This is definitely something to try, yes.
> 
>> Alternatively, would it make sense for qt5ct to Break or Conflict with
>> Plasma, at least until these issues are worked around?
> 
> And a nice way around it in case the above fails.
> 
> If you are interested in trying this I'll be more than happy to sponsor you.
> 
> Dmitry/team: any comments from you?
> 
> 
From d0738c2146e02a5dd553f1d96ba37b506f6e8727 Mon Sep 17 00:00:00 2001
From: James Lu <ja...@overdrivenetworks.com>
Date: Sat, 2 Sep 2017 01:29:41 -0700
Subject: [PATCH] Don't enable qt5ct on KDE, or when another platform theme is
 set

---
 debian/99qt5ct | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/debian/99qt5ct b/debian/99qt5ct
index 0362b72..32d7105 100644
--- a/debian/99qt5ct
+++ b/debian/99qt5ct
@@ -1,3 +1,6 @@
-export QT_QPA_PLATFORMTHEME=qt5ct
-export QT_PLATFORMTHEME=qt5ct
-export QT_PLATFORM_PLUGIN=qt5ct
+# Enable qt5ct by default unless another PLATFORMTHEME option is set
+# or KDE is running.
+if [ -z "$QT_QPA_PLATFORMTHEME" ] && [ "$XDG_CURRENT_DESKTOP" != "KDE" ]
+then
+export QT_QPA_PLATFORMTHEME=qt5ct
+fi
-- 
2.14.1



signature.asc
Description: OpenPGP digital signature


Bug#822246: ITP: qt5ct -- Qt5 configuration tool

2017-08-27 Thread James Lu
Hi everyone,

From what I read at
https://forum.antergos.com/topic/6487/qt5ct-has-priority-over-standard-plasma-settings-app/2,
Lisandro's concerns are correct and qt5ct does appear to override
Plasma's settings entirely. However, since qt5ct requires an Xsession
file[1] to be enabled by default, could one solution be having the
script exit silently if it finds any KDE environment variables? (This is
assuming that the order at which vars are set make this possible, but I
haven't verified that)

Alternatively, would it make sense for qt5ct to Break or Conflict with
Plasma, at least until these issues are worked around?

Best,
James

[1]: https://github.com/mati75/qt5ct/blob/master/debian/99qt5ct



signature.asc
Description: OpenPGP digital signature


Bug#709899: virtualbox: please move guest tools back to main

2017-08-27 Thread James Lu
Control: reassign 709899 virtualbox-guest-x11
Control: tag 709899 + patch
Control: block 709899 by 824169

This is no longer true: Source packages are again allowed to build for
both main and contrib, but this is in practice problematic due to
824169. So, hopefully adding a block here is the right way to go.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#870121: mate-power-manager: sometimes hits not-reached assertion on startup

2017-08-13 Thread James Lu
Control: retitle -1 mate-power-manager: crashes with upower 0.99.5 on any 
device with a backlit keyboard
Control: severity -1 grave
Justification: renders package unusable on a large range of systems

Hi everyone,

According to the upstream issue, mate-power-manager is now completely broken 
with upower
0.99.5 on any device with a backlit keyboard. This makes it effectively 
unusable on a wide
slew of devices, so I'm bumping the severity to make the issue more notable.

Best,
James



Bug#869676: stretch-pu: package gnome-exe-thumbnailer/0.9.4-2+deb9u1

2017-08-10 Thread James Lu
Hello,

This was uploaded! (CC'ing my sponsor as well)

Best,
James

On 08/08/17 08:52 AM, Adam D. Barratt wrote:
> Control: tags -1 + confirmed
> 
> On Tue, 2017-07-25 at 22:50 +0800, James Lu wrote:
>> I've prepared an update to gnome-exe-thumbnailer which includes two changes
>> backported from the 0.9.5 release:
>>
>> 1) Migrating away from insecure Wine+VBScript based parsing of .msi files to
>> msitools, as part of the fix for CVE-2017-11421[1] (VBScript code injection 
>> via
>> filenames containing code). This issue was marked no-dsa, so I'm sending the
>> update here instead. I also adjusted the dependencies to add msitools, but 
>> IIRC
>> this means that users upgrading will need to run dist-upgrade (if such a 
>> change
>> is too disruptive, I will probably look at disabling version info for .msi
>> files entirely).
>>
>> 2) Fix readability of version labels by using a dark background colour.
>> Previously, the version label exe-thumbnailer adds to generated thumbnails 
>> used
>> a transparent background, which shows up as white text on white with a 
>> default
>> configuration.
>>
>> [1]: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11421
> 
> Please go ahead.
> 
> Regards,
> 
> Adam
> 



signature.asc
Description: OpenPGP digital signature


Bug#869676: stretch-pu: package gnome-exe-thumbnailer/0.9.4-2+deb9u1

2017-07-25 Thread James Lu
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hi Release Team,

I've prepared an update to gnome-exe-thumbnailer which includes two changes
backported from the 0.9.5 release:

1) Migrating away from insecure Wine+VBScript based parsing of .msi files to
msitools, as part of the fix for CVE-2017-11421[1] (VBScript code injection via
filenames containing code). This issue was marked no-dsa, so I'm sending the
update here instead. I also adjusted the dependencies to add msitools, but IIRC
this means that users upgrading will need to run dist-upgrade (if such a change
is too disruptive, I will probably look at disabling version info for .msi
files entirely).

2) Fix readability of version labels by using a dark background colour.
Previously, the version label exe-thumbnailer adds to generated thumbnails used
a transparent background, which shows up as white text on white with a default
configuration.

[1]: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11421

The debdiff is attached.

Best,
James

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8),
LANGUAGE=en_CA:en (charmap=UTF-8)
diff -Nru gnome-exe-thumbnailer-0.9.4/debian/changelog 
gnome-exe-thumbnailer-0.9.4/debian/changelog
--- gnome-exe-thumbnailer-0.9.4/debian/changelog2016-12-12 
04:55:32.0 +0800
+++ gnome-exe-thumbnailer-0.9.4/debian/changelog2017-07-25 
22:28:41.0 +0800
@@ -1,3 +1,17 @@
+gnome-exe-thumbnailer (0.9.4-2+deb9u1) stretch; urgency=high
+
+  * Add patch switch-to-msiinfo.patch:
+- Switch to msitools' msiinfo for ProductVersion fetching, replacing the
+  insecure VBScript-based parsing as described at
+  
http://news.dieweltistgarnichtso.net/posts/gnome-thumbnailer-msi-fail.html
+  (Closes: #868705; LP: #651610; CVE-2017-11421)
+  * Add msitools to recommends; it is now used to fetch .msi version info.
+  * Add patch fix-version-label-readability.patch backported from
+
https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/commit/1cf4df81836985d9660f950287232b3255ee17bb
+to fix unreadable white-on-white text on version labels.
+
+ -- James Lu <bitfl...@gmail.com>  Tue, 25 Jul 2017 07:28:41 -0700
+
 gnome-exe-thumbnailer (0.9.4-2) unstable; urgency=medium
 
   * Add recommends on wine and wine-tools, as these are needed for .lnk and
diff -Nru gnome-exe-thumbnailer-0.9.4/debian/control 
gnome-exe-thumbnailer-0.9.4/debian/control
--- gnome-exe-thumbnailer-0.9.4/debian/control  2016-12-12 04:55:32.0 
+0800
+++ gnome-exe-thumbnailer-0.9.4/debian/control  2017-07-25 22:05:01.0 
+0800
@@ -14,8 +14,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}, icoutils, imagemagick, libglib2.0-bin
 # wine and wine(32|64)-tools are needed for .lnk and .msi thumbnailing
-# wine provides winepath and cscript, while wine(32|64)-tools provides winedump
-Recommends: wine,
+# wine provides winepath, while wine(32|64)-tools provides winedump
+# mistools provides msiinfo to fetch version tags on .msi files
+Recommends: msitools,
+wine,
 wine64-tools | wine32-tools | wine64-development-tools | 
wine32-development-tools
 Description: Wine .exe and other executable thumbnailer for GNOME
  gnome-exe-thumbnailer is a thumbnailer for Windows executable files
diff -Nru 
gnome-exe-thumbnailer-0.9.4/debian/patches/fix-version-label-readability.patch 
gnome-exe-thumbnailer-0.9.4/debian/patches/fix-version-label-readability.patch
--- 
gnome-exe-thumbnailer-0.9.4/debian/patches/fix-version-label-readability.patch  
1970-01-01 08:00:00.0 +0800
+++ 
gnome-exe-thumbnailer-0.9.4/debian/patches/fix-version-label-readability.patch  
2017-07-25 22:27:25.0 +0800
@@ -0,0 +1,20 @@
+Author: James Lu <ja...@overdrivenetworks.com>
+Subject: Fix readability of version labels by using a dark background colour
+ Previously, the version label used a transparent background, which would show
+ up as white text on white in many cases.
+Origin: upstream, 
https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/commit/1cf4df81836985d9660f950287232b3255ee17bb
+
+Index: g-e-t/usr/bin/gnome-exe-thumbnailer
+===
+--- g-e-t.orig/usr/bin/gnome-exe-thumbnailer   2017-07-25 07:23:52.269571939 
-0700
 g-e-t/usr/bin/gnome-exe-thumbnailer2017-07-25 07:23:52.269571939 
-0700
+@@ -403,7 +403,7 @@
+ if [ "$VERSION" ]
+ then
+   convert -font -*-clean-medium-r-*-*-6-*-*-*-*-*-*-* \
+-  -background transparent -fill white label:"$VERSION" \
++  -background '#1090' -fill white label:"$VERSION" \
+ 

Bug#868705: [pkg-wine-party] Bug#868705: gnome-exe-thumbnailer: Thumbnail generation for MSI files executes arbitrary VBScript

2017-07-17 Thread James Lu
Control: tag 868705 + pending fixed-upstream

Hi,

msiinfo is part of msitools, just like wixl:
https://github.com/GNOME/msitools. I haven't audited the code, but being
under the GNOME umbrella and having a history of 5 years probably means
that it's reliable enough.

(I've also heard reports so far that msiinfo is a lot /faster/ than
running code through Wine's cscript, which is not really much of a
surprise.)

Best,
James

On 18/07/17 09:02 AM, Nils Dagsson Moskopp wrote:
> I like that the patch is less code. Deleted code is debugged code!
> Btw, are you sure that using mssiinfo does not introduce new bugs?
> 
> Cheers,
> Nils
> 
> James Lu <bitfl...@gmail.com> writes:
> 
>> [ Unknown signature status ]
>> Hi Nils,
>>
>> I wasn't able to reproduce the exploit on my (64-bit) system with either
>> Caja and Nautilus (it also required setting up a new wineprefix in
>> ~/.wine). The msi thumbnail ended up generating without any version
>> information tag at all.
>>
>> Regardless, I've gone and replaced the VBScript-based parsing entirely
>> with msitools' msiinfo in
>> https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/commit/1d8e3102dd8fd23431ae6127d14a236da6b4a4a5;
>> hopefully this should fix the issue. I'll tag a new release soon and
>> look at pushing the fix to Debian.
>>
>> (Also CC'ing the other maintainers, who I don't think are on the Debian
>> Wine list)
>>
>> Best,
>> James
>>
>> On 18/07/17 05:01 AM, Nils Dagsson Moskopp wrote:
>>> Package: gnome-exe-thumbnailer
>>> Version: 0.9.4-2
>>> Severity: grave
>>> Tags: security
>>> Justification: user security hole
>>>
>>> Dear Maintainer,
>>>
>>> the following PoC is copied verbatim from my post about the parsing issue:
>>> http://news.dieweltistgarnichtso.net/posts/gnome-thumbnailer-msi-fail.html
>>>
>>> Proof of Concept
>>>
>>> Install Dependencies
>>>
>>> On Debian GNU/Linux, install the packages gnome-exe-thumbnailer, nautilus 
>>> and wixl. The wixl package is only needed to create MSI files that trigger 
>>> the thumbnailer.
>>>
>>> If the proof of concept does not work, install winetricks and run 
>>> winetricks wsh56 to upgrade the Windows Script Host.
>>>
>>> Create MSI Files
>>>
>>> Create a file named poc.xml with the following content:
>>>
>>> 
>>> http://schemas.microsoft.com/wix/2006/wi;>
>>> 
>>> 
>>>
>>> Execute the following Bourne Shell code:
>>>
>>> wixl -o poc.msi poc.xml
>>> cp poc.msi "poc.msi\",0):Set 
>>> fso=CreateObject(\"Scripting.FileSystemObject\"):Set 
>>> poc=fso.CreateTextFile(\"badtaste.txt\")'.msi"
>>>
>>> Trigger Execution
>>>
>>> Start GNOME Files and navigate to the folder with the MSI files. An empty 
>>> file with the name badtaste.txt should appear.
>>>
>>> *** End of the template - remove these template lines ***
>>>
>>>
>>> -- System Information:
>>> Debian Release: 9.0
>>>   APT prefers stable
>>>   APT policy: (500, 'stable')
>>> Architecture: i386 (i686)
>>>
>>> Kernel: Linux 3.16.0-4-686-pae (SMP w/1 CPU core)
>>> Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
>>> Shell: /bin/sh linked to /bin/dash
>>> Init: sysvinit (via /sbin/init)
>>>
>>> Versions of packages gnome-exe-thumbnailer depends on:
>>> ii  icoutils 0.31.2-1.1
>>> ii  imagemagick  8:6.9.7.4+dfsg-11
>>> ii  imagemagick-6.q16 [imagemagick]  8:6.9.7.4+dfsg-11
>>> ii  libglib2.0-bin   2.50.3-2
>>>
>>> Versions of packages gnome-exe-thumbnailer recommends:
>>> pn  wine 
>>> 
>>> pn  wine64-tools | wine32-tools | wine64-development-tools | wine32-dev  
>>> 
>>>
>>> gnome-exe-thumbnailer suggests no packages.
>>>
>>> -- no debconf information
>>>
>>> ___
>>> pkg-wine-party mailing list
>>> pkg-wine-pa...@lists.alioth.debian.org
>>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-wine-party
>>>
>>
> 



signature.asc
Description: OpenPGP digital signature


Bug#868705: [pkg-wine-party] Bug#868705: gnome-exe-thumbnailer: Thumbnail generation for MSI files executes arbitrary VBScript

2017-07-17 Thread James Lu
Hi Nils,

I wasn't able to reproduce the exploit on my (64-bit) system with either
Caja and Nautilus (it also required setting up a new wineprefix in
~/.wine). The msi thumbnail ended up generating without any version
information tag at all.

Regardless, I've gone and replaced the VBScript-based parsing entirely
with msitools' msiinfo in
https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/commit/1d8e3102dd8fd23431ae6127d14a236da6b4a4a5;
hopefully this should fix the issue. I'll tag a new release soon and
look at pushing the fix to Debian.

(Also CC'ing the other maintainers, who I don't think are on the Debian
Wine list)

Best,
James

On 18/07/17 05:01 AM, Nils Dagsson Moskopp wrote:
> Package: gnome-exe-thumbnailer
> Version: 0.9.4-2
> Severity: grave
> Tags: security
> Justification: user security hole
> 
> Dear Maintainer,
> 
> the following PoC is copied verbatim from my post about the parsing issue:
> http://news.dieweltistgarnichtso.net/posts/gnome-thumbnailer-msi-fail.html
> 
> Proof of Concept
> 
> Install Dependencies
> 
> On Debian GNU/Linux, install the packages gnome-exe-thumbnailer, nautilus and 
> wixl. The wixl package is only needed to create MSI files that trigger the 
> thumbnailer.
> 
> If the proof of concept does not work, install winetricks and run winetricks 
> wsh56 to upgrade the Windows Script Host.
> 
> Create MSI Files
> 
> Create a file named poc.xml with the following content:
> 
> 
> http://schemas.microsoft.com/wix/2006/wi;>
> 
> 
> 
> Execute the following Bourne Shell code:
> 
> wixl -o poc.msi poc.xml
> cp poc.msi "poc.msi\",0):Set 
> fso=CreateObject(\"Scripting.FileSystemObject\"):Set 
> poc=fso.CreateTextFile(\"badtaste.txt\")'.msi"
> 
> Trigger Execution
> 
> Start GNOME Files and navigate to the folder with the MSI files. An empty 
> file with the name badtaste.txt should appear.
> 
> *** End of the template - remove these template lines ***
> 
> 
> -- System Information:
> Debian Release: 9.0
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: i386 (i686)
> 
> Kernel: Linux 3.16.0-4-686-pae (SMP w/1 CPU core)
> Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
> 
> Versions of packages gnome-exe-thumbnailer depends on:
> ii  icoutils 0.31.2-1.1
> ii  imagemagick  8:6.9.7.4+dfsg-11
> ii  imagemagick-6.q16 [imagemagick]  8:6.9.7.4+dfsg-11
> ii  libglib2.0-bin   2.50.3-2
> 
> Versions of packages gnome-exe-thumbnailer recommends:
> pn  wine 
> 
> pn  wine64-tools | wine32-tools | wine64-development-tools | wine32-dev  
> 
> 
> gnome-exe-thumbnailer suggests no packages.
> 
> -- no debconf information
> 
> ___
> pkg-wine-party mailing list
> pkg-wine-pa...@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-wine-party
> 



signature.asc
Description: OpenPGP digital signature


Bug#868282: virtualbox-dkms: kernel modules fail to build due to missing files

2017-07-13 Thread James Lu
Hi everyone,

I ran into this issue today as well and can confirm that downgrading to
virtualbox-dkms 5.1.22-dfsg-2 fixes it.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#866655: variety: depends on libwebkitgtk-3.0-0 which is deprecated

2017-06-30 Thread James Lu
Control: forwarded 866655 https://bugs.launchpad.net/variety/+bug/1701724

Hi Jeremy,

To speed up the process, is there any simple porting guide between WebKitGTK 3 
and WebKit2GTK 4? The only working feature in Variety using WebKit at the 
moment is Facebook integration, which is difficult for me to test because I 
don't feel comfortable with programs posting to Facebook on my behalf.

I've forwarded the issue upstream and I'll see how they respond; if there's 
nothing within a week or two I will probably just patch out Facebook 
integration for the time being.

Best,
James

On 30/06/17 09:22 AM, Jeremy Bicha wrote:
> Source: variety
> Severity: serious
> Tags: sid buster
> User: pkg-webkit-maintain...@lists.alioth.debian.org
> Usertags: oldlibs libwebkitgtk-3.0-0 webkit1
> 
> Hi,
> 
> variety depends on gir1.2-webkit-3.0, which is deprecated
> in favor of gir1.2-webkit2-4.0 (provided in Debian by webkit2gtk). It
> should be ported to the new webkitgtk version so we
> can remove the old, unmaintained one.
> 
> Please try to do soon as we're going to try to remove the old webkitgtk soon.
> 
> I am filing this bug as "serious" since the old webkitgtk will not be
> available in the next major stable release of Debian (codenamed
> "buster").
> 
> If you have any question don't hesitate to ask.
> 
> On behalf of the Debian WebKit Maintainers,
> Jeremy Bicha
> 



Bug#806852: systemd: rescue.service fails if root password is not set, needs sulogin --force

2017-06-22 Thread James Lu
Control: severity -1 important
Justification: potentially leaves the system in an unbootable,
unrecoverable state

Hi all,

This issue is extremely frustrating to say the least because I've been
locked out of my own computer over a simple fstab issue that could have
easily been fixed with a root shell... Instead I had to prepare a
bootdisk from another machine etc. because the root account was locked?
I happen to use sudo exclusively and I'm a bit annoyed that no warnings
for cases like these were ever displayed.

Seeing that a patch was already proposed in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802211, can
*something* be done about this problem? Requiring login to a sudoer
account when root is locked sounds like a great compromise solution if
possible.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#802505: RFP: paper-icon-theme -- Paper Icon Theme

2017-06-10 Thread James Lu
Hi,

I have some unofficial packaging for paper-icon-theme at
https://github.com/utopia-repository/paper-icon-theme. If there is
adequate interest, I can continue working on it (though the polish
up+finding a sponsor process takes time!)

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#862403: RFP: paper-gtk-theme -- modern desktop GTK2/GTK3 theme suite

2017-06-10 Thread James Lu
Hi,

For anyone interested, I have some working unofficial packaging over at
https://github.com/utopia-repository/paper-gtk-theme. However, I don't
want to maintain this in Debian alone because my CSS skills are limited
and GTK 3 themes are prone to break every point release.

That said, I'm happy to work alongside someone knowledgeable if they
feel the extra manpower would be helpful.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#864075: unblock: icoutils/0.31.2-1.1

2017-06-03 Thread James Lu
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi Release Team,

Please consider unblocking package icoutils:

This upload fixes an important bug which caused icoutils' wrestool utility to
break completely, due to a regression in version 0.31.2. wrestool is a program
used to extract icons from Windows programs, and its breakage caused dependant
packages (e.g. kde-runtime, gnome-exe-thumbnailer, gextractwinicons) to fail at
icon extraction entirely.

The full debdiff is attached.

unblock icoutils/0.31.2-1.1

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 'testing-
debug'), (500, 'unstable'), (101, 'experimental'), (1, 'experimental-debug')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8)
diff -Nru icoutils-0.31.2/debian/changelog icoutils-0.31.2/debian/changelog
--- icoutils-0.31.2/debian/changelog2017-03-07 14:18:53.0 -0800
+++ icoutils-0.31.2/debian/changelog2017-05-30 23:12:09.0 -0700
@@ -1,3 +1,13 @@
+icoutils (0.31.2-1.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Add patch fix-wrestool.patch from upstream commit
+
http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=3c990fcc754c81a02ab5981d59b01025f1596b2c
+to fix wrestool not extracting icons - this is a regression from 0.31.2.
+Closes: #860220
+
+ -- James Lu <bitfl...@gmail.com>  Tue, 30 May 2017 23:12:09 -0700
+
 icoutils (0.31.2-1) unstable; urgency=high
 
   * New upstream release.
diff -Nru icoutils-0.31.2/debian/.git-dpm icoutils-0.31.2/debian/.git-dpm
--- icoutils-0.31.2/debian/.git-dpm 2017-03-07 09:30:30.0 -0800
+++ icoutils-0.31.2/debian/.git-dpm 2017-05-30 23:12:09.0 -0700
@@ -1,6 +1,6 @@
 # see git-dpm(1) from git-dpm package
-c50ee01e3bbbc846f7b17e7de1d7c092e7b950c9
-c50ee01e3bbbc846f7b17e7de1d7c092e7b950c9
+f06d6e83d1b3256a5b6a0d42b8fc5293e6005bab
+f06d6e83d1b3256a5b6a0d42b8fc5293e6005bab
 c50ee01e3bbbc846f7b17e7de1d7c092e7b950c9
 c50ee01e3bbbc846f7b17e7de1d7c092e7b950c9
 icoutils_0.31.2.orig.tar.bz2
diff -Nru icoutils-0.31.2/debian/patches/fix-wrestool.patch 
icoutils-0.31.2/debian/patches/fix-wrestool.patch
--- icoutils-0.31.2/debian/patches/fix-wrestool.patch   1969-12-31 
16:00:00.0 -0800
+++ icoutils-0.31.2/debian/patches/fix-wrestool.patch   2017-05-30 
23:12:09.0 -0700
@@ -0,0 +1,37 @@
+From f06d6e83d1b3256a5b6a0d42b8fc5293e6005bab Mon Sep 17 00:00:00 2001
+From: Frank Richter <frank.rich...@gmail.com>
+Date: Sat, 11 Mar 2017 14:10:50 +0100
+Subject: Revert "Add additional sanity checks to do_resource(). Found by Jerzy
+ Kramarz <op7...@gmail.com>."
+
+That "sanity check" rather broke everything.
+Also, I couldn't reproduce the issue it this change was intended to catch from 
the files I have
+any more, so it's probably not needed anyway.
+
+Origin: upstream, 
http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=3c990fcc754c81a02ab5981d59b01025f1596b2c
+Bug-Debian: https://bugs.debian.org/860220
+Last-Update: 2017-05-30
+
+Patch-Name: fix-wrestool.patch
+---
+ wrestool/restable.c | 4 
+ 1 file changed, 4 deletions(-)
+
+diff --git a/wrestool/restable.c b/wrestool/restable.c
+index c60806f..f568434 100644
+--- a/wrestool/restable.c
 b/wrestool/restable.c
+@@ -87,13 +87,9 @@ do_resources_recurs (WinLibrary *fi, WinResource *base, 
WinResource *type_wr,
+   wr = list_resources (fi, base, );
+   if (wr == NULL)
+   return;
+-  if (!check_offset(fi->memory, fi->total_size, fi->name, [0], 
sizeof(WinResource)))
+-  return;
+ 
+   /* process each resource listed */
+   for (c = 0 ; c < rescnt ; c++) {
+-  if (!check_offset(fi->memory, fi->total_size, fi->name, [c], 
sizeof(WinResource)))
+-  break;
+   /* (over)write the corresponding WinResource holder with the 
current */
+   memcpy(WINRESOURCE_BY_LEVEL(wr[c].level), wr+c, 
sizeof(WinResource));
+ 
diff -Nru icoutils-0.31.2/debian/patches/series 
icoutils-0.31.2/debian/patches/series
--- icoutils-0.31.2/debian/patches/series   1969-12-31 16:00:00.0 
-0800
+++ icoutils-0.31.2/debian/patches/series   2017-05-30 23:12:09.0 
-0700
@@ -0,0 +1 @@
+fix-wrestool.patch


Bug#864056: RFS: icoutils/0.31.2-1.1 [NMU]

2017-06-03 Thread James Lu
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for package "icoutils"

 * Package name: icoutils
   Version : 0.31.2-1.1
   Upstream Author : Frank Richter <frank.rich...@gmail.com>
 * URL : http://www.nongnu.org/icoutils/
 * License : GPL-3+
   Section : graphics

It builds those binary packages:

  icoutils   - Create and extract MS Windows icons and cursors

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/icoutils

Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/i/icoutils/icoutils_0.31.2-1.1.dsc

Changes since the last upload:

icoutils (0.31.2-1.1) unstable; urgency=high

  * Non-maintainer upload.
  * Add patch fix-wrestool.patch from upstream commit
http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=3c990fcc754c81a02ab5981d59b01025f1596b2c
to fix wrestool not extracting icons - this is a regression from 0.31.2.
Closes: #860220


I want to upload this low threshold NMU[1] because the bug being fixed
(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860220) breaks
icoutils' wrestool entirely, and prevents gnome-exe-thumbnailer (which I
maintain) and likely others[2] from properly working. Per the regular
NMU guidelines[3], I've also waited 5 days before pushing a fix for this
severity 'important' bug. Although the stretch upload deadline is coming
up soon, I really want to fix this bug for stretch so that programs
depending on wrestool are fully functional.

[1]: https://wiki.debian.org/LowThresholdNmu
[2]: https://codesearch.debian.net/search?q=wrestool
[3]:
https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-guidelines

Regards,
James Lu



signature.asc
Description: OpenPGP digital signature


Bug#860220: icoutils: Cannot parse/extract icons using icotool or wrestool

2017-05-31 Thread James Lu
Hi again,

Some more testing from Unit 193 (CC'd) and I shows that the commit
fixing this is actually
http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=3c990fcc754c81a02ab5981d59b01025f1596b2c

The attached patch imports this commit as a patch. (Hopefully this can
be fixed in time for stretch!)

Best,
James

On 30/05/17 10:31 PM, James Lu wrote:
> Control: affects 860220 gnome-exe-thumbnailer
> Control: tag 860220 + fixed-upstream
> 
> Hi,
> 
> According to
> http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=050fbec35c3ab39f71b4e814506692e2006e950d,
> this bug is fixed in icoutils 0.31.3. When I build a package for this
> version and install it locally, I can confirm that wrestool is fixed.
> 
> Before (0.31.2-1):
> $ wrestool -l PatchCleaner_1.4.2.0.exe
> wrestool: PatchCleaner_1.4.2.0.exe: premature end
> 
> After (0.31.3-0utopia1, local build):
> $ wrestool -l PatchCleaner_1.4.2.0.exe
> --type=3 --name=1 --language=1033 [type=icon offset=0x274a0 size=744]
> --type=3 --name=2 --language=1033 [type=icon offset=0x27788 size=296]
> --type=5 --name=500 --language=1033 [type=dialog offset=0x278d8 size=184]
> --type=6 --name=1 --language=1033 [type=string offset=0x27990 size=148]
> --type=6 --name=5 --language=1033 [type=string offset=0x27a28 size=52]
> --type=14 --name=1 --language=1033 [type=group_icon offset=0x278b0 size=34]
> 
> However, there have been numerous commits between 0.31.2 and 0.31.3[1],
> and it's not clear to me which commit actually unbricks wrestool. At
> this point, it's probably too late to ship an entirely new version into
> Stretch.
> 
> This bug impacts gnome-exe-thumbnailer (a .exe thumbnailer for
> GNOME-like systems), because wrestool failing causes it to fall back to
> a relatively useless generic icon. This in turn erodes away at the
> thumbnailer's whole purpose, and I'm undecided so far whether that
> should be an RC bug on g-e-t's side (I am the maintainer).
> 
> Best,
> James
> 
> [1]: http://git.savannah.nongnu.org/cgit/icoutils.git/log
> 
From 8c6c39e351fc97b49a922905a169f0607ebc862c Mon Sep 17 00:00:00 2001
From: James Lu <ja...@overdrivenetworks.com>
Date: Tue, 30 May 2017 23:21:07 -0700
Subject: [PATCH] Add patch fix-wrestool.patch to fix wrestool not extracting
 icons (0.31.2 regression)

Bug: https://bugs.debian.org/860220
---
 debian/patches/fix-wrestool.patch | 38 ++
 debian/patches/series |  1 +
 2 files changed, 39 insertions(+)
 create mode 100644 debian/patches/fix-wrestool.patch
 create mode 100644 debian/patches/series

diff --git a/debian/patches/fix-wrestool.patch b/debian/patches/fix-wrestool.patch
new file mode 100644
index 000..4d2079b
--- /dev/null
+++ b/debian/patches/fix-wrestool.patch
@@ -0,0 +1,38 @@
+From: Frank Richter <frank.rich...@gmail.com>
+Last-Update: 2017-05-30
+Origin: upstream, http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=3c990fcc754c81a02ab5981d59b01025f1596b2c
+Bug-Debian: https://bugs.debian.org/860220
+Subject: Fix wrestool and icoutils not extracting icons
+ The original commit message is as follows:
+ .
+ Revert "Add additional sanity checks to do_resource(). Found by Jerzy Kramarz <op7...@gmail.com>."
+ .
+ That "sanity check" rather broke everything.
+ Also, I couldn't reproduce the issue it this change was intended to catch from the files I have
+ any more, so it's probably not needed anyway.
+
+---
+ wrestool/restable.c | 4 
+ 1 file changed, 4 deletions(-)
+
+diff --git a/wrestool/restable.c b/wrestool/restable.c
+index fd0ba49..f14dddf 100644
+--- a/wrestool/restable.c
 b/wrestool/restable.c
+@@ -87,13 +87,9 @@ do_resources_recurs (WinLibrary *fi, WinResource *base, WinResource *type_wr,
+ 	wr = list_resources (fi, base, );
+ 	if (wr == NULL)
+ 		return;
+-	if (!check_offset(fi->memory, fi->total_size, fi->name, [0], sizeof(WinResource)))
+-		return;
+ 
+ 	/* process each resource listed */
+ 	for (c = 0 ; c < rescnt ; c++) {
+-		if (!check_offset(fi->memory, fi->total_size, fi->name, [c], sizeof(WinResource)))
+-			break;
+ 		/* (over)write the corresponding WinResource holder with the current */
+ 		memcpy(WINRESOURCE_BY_LEVEL(wr[c].level), wr+c, sizeof(WinResource));
+ 
+-- 
+cgit v1.0-41-gc330
+
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000..a683131
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-wrestool.patch
-- 
2.11.0



signature.asc
Description: OpenPGP digital signature


Bug#860220: icoutils: Cannot parse/extract icons using icotool or wrestool

2017-05-30 Thread James Lu
Control: affects 860220 gnome-exe-thumbnailer
Control: tag 860220 + fixed-upstream

Hi,

According to
http://git.savannah.nongnu.org/cgit/icoutils.git/commit/?id=050fbec35c3ab39f71b4e814506692e2006e950d,
this bug is fixed in icoutils 0.31.3. When I build a package for this
version and install it locally, I can confirm that wrestool is fixed.

Before (0.31.2-1):
$ wrestool -l PatchCleaner_1.4.2.0.exe
wrestool: PatchCleaner_1.4.2.0.exe: premature end

After (0.31.3-0utopia1, local build):
$ wrestool -l PatchCleaner_1.4.2.0.exe
--type=3 --name=1 --language=1033 [type=icon offset=0x274a0 size=744]
--type=3 --name=2 --language=1033 [type=icon offset=0x27788 size=296]
--type=5 --name=500 --language=1033 [type=dialog offset=0x278d8 size=184]
--type=6 --name=1 --language=1033 [type=string offset=0x27990 size=148]
--type=6 --name=5 --language=1033 [type=string offset=0x27a28 size=52]
--type=14 --name=1 --language=1033 [type=group_icon offset=0x278b0 size=34]

However, there have been numerous commits between 0.31.2 and 0.31.3[1],
and it's not clear to me which commit actually unbricks wrestool. At
this point, it's probably too late to ship an entirely new version into
Stretch.

This bug impacts gnome-exe-thumbnailer (a .exe thumbnailer for
GNOME-like systems), because wrestool failing causes it to fall back to
a relatively useless generic icon. This in turn erodes away at the
thumbnailer's whole purpose, and I'm undecided so far whether that
should be an RC bug on g-e-t's side (I am the maintainer).

Best,
James

[1]: http://git.savannah.nongnu.org/cgit/icoutils.git/log



signature.asc
Description: OpenPGP digital signature


Bug#863383: ITP: numix-icon-theme-circle -- Circle icon theme from the Numix project

2017-05-25 Thread James Lu
Package: wnpp
Severity: wishlist
Owner: James Lu <bitfl...@gmail.com>

* Package name: numix-icon-theme-circle
  Version : 17-04-05-1
  Upstream Author : Numix Project Ltd. <t...@numixproject.org>
* URL : https://numixproject.org/
* License : GPL
  Programming Lang: N/A (it's an image set that can be installed as is)
  Description : Circle icon theme from the Numix project

Numix Circle is an extensive icon theme for Linux desktops, with over 4000
application icons. It is developed by the Numix project and serves as a
companion to the base Numix icon theme (numix-icon-theme).



Packaging rationale: Numix Circle is an actively maintained, modern icon theme
which covers a wide range of application icons. I have been using it for many
months with no problems, and it helps polish the look of a desktop with a
consistent icon style. This theme complements numix-icon-theme, which only
contains a base set of system (e.g. panel, settings) icons.

Maintenance: I plan to maintain this within the Debian MATE team, as discussed
on #debian-mate (IRC).



Bug#862051: Refer #862051 to ctte (WAS: nodejs-legacy: possibly drop this package, now that ax25-node has been removed?)

2017-05-18 Thread James Lu
Control: reassign -1 tech-ctte
Control: retitle -1 Rename nodejs back to node for buster, now that
ax25-node has been removed?

Dear tech-ctte,

In 2012, the decision was made to rename Node.js' "node" name to
nodejs-legacy, and transition the existing "node" package to ax25-node.
However, ax25-node (and the "node" package following) were removed in
2015 citing lack of activity:
https://packages.qa.debian.org/n/node.html

Thus, would it be possible to revert the original decision, and rename
nodejs back to node in the next Debian release? Doing so would make
working with JavaScript programs outside of Debian a lot easier, as
projects tend to hardcode the "node" interpreter name.

Best,
James

On Thu, 18 May 2017 22:12:00 +0200 =?utf-8?b?SsOpcsOpbXkgTGFs?=
 wrote:
> Package: nodejs-legacy
> Version: 6.10.2~dfsg-1
> Followup-For: Bug #862051
> 
> I would love to do that, but the reason behind the rename came from
> https://bugs.debian.org/614907.
> 
> Feel free to ask TC to find a new solution.
> 
> Jérémy



Bug#862051: nodejs-legacy: possibly drop this package, now that ax25-node has been removed?

2017-05-07 Thread James Lu
Package: nodejs-legacy
Version: 4.8.2~dfsg-1
Severity: wishlist

Hi maintainers,

Back in 2015, ax25-node (and the "node" package following) were removed citing
lack of activity:
https://packages.qa.debian.org/n/node/news/20150915T000109Z.html

Would it be possible to drop nodejs-legacy in the next Debian release and
rename nodejs back to node? IMO doing so would make working with JS programs
outside of Debian a lot easier.

Best,
James



-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages nodejs-legacy depends on:
ii  nodejs  4.8.2~dfsg-1

nodejs-legacy recommends no packages.

nodejs-legacy suggests no packages.

-- no debconf information



Bug#861985: unblock: variety/0.6.3-5 (pre-upload approval)

2017-05-06 Thread James Lu
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi Release Team,

I've prepared variety 0.6.3-5 with two changes: the first is fixing a bug that
caused wallpaper selection panels to eat up 100% CPU when open, and the second
is updating the package's extended description to match the list of supported
wallpaper sources as of Variety 0.6.3.

The relevant debdiff is attached.

unblock variety/0.6.3-5

Best,
James

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 'testing-
debug'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
diff -Nru variety-0.6.3/debian/changelog variety-0.6.3/debian/changelog
--- variety-0.6.3/debian/changelog  2017-04-27 22:49:27.0 -0700
+++ variety-0.6.3/debian/changelog  2017-05-06 16:43:32.0 -0700
@@ -1,3 +1,15 @@
+variety (0.6.3-5) unstable; urgency=medium
+
+  * Add fix-autoscroll-high-cpu.patch backported from upstream Bzr revision
+592 (https://bazaar.launchpad.net/~variety/variety/trunk/revision/592)
+This fixes an issue where the Wallpaper Selector and History panels
+drain entire CPU cores when open. (LP: #1494992)
+  * Fix list of supported sites in package extended description: Wallbase.cc
+support was removed in 0.6.3, while Wallhaven.cc was never mentioned even
+though it is supported.
+
+ -- James Lu <bitfl...@gmail.com>  Sat, 06 May 2017 16:43:32 -0700
+
 variety (0.6.3-4) unstable; urgency=medium
 
   * Upload to unstable.
diff -Nru variety-0.6.3/debian/control variety-0.6.3/debian/control
--- variety-0.6.3/debian/control2017-04-27 22:49:27.0 -0700
+++ variety-0.6.3/debian/control2017-05-06 16:40:03.0 -0700
@@ -45,5 +45,5 @@
 Description: Wallpaper changer, downloader and manager
  Variety is an open-source wallpaper changer, downloader, and manager for
  Linux. It supports a variety of sources for wallpapers, including local
- files, online services such as Flickr, Wallbase.cc, NASA Astronomy Picture of
- the Day, Desktoppr.co, and media RSS feeds (Picasa, deviantART, etc.).
+ files, online services such as Flickr, Wallhaven.cc, NASA Astronomy Picture
+ of the Day, Desktoppr.co, and media RSS feeds (Picasa, deviantART, etc.).
diff -Nru variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch 
variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch
--- variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch  1969-12-31 
16:00:00.0 -0800
+++ variety-0.6.3/debian/patches/fix-autoscroll-high-cpu.patch  2017-05-06 
16:32:20.0 -0700
@@ -0,0 +1,30 @@
+From: James Lu <ja...@overdrivenetworks.com>
+Subject: Fix autoscroll in wallpaper selector & history panels using 100% CPU
+ .
+ Previously, the autoscroll event was never cleared when the user moved the
+ mouse away from the Thumbnails panel. This caused the
+ self.autoscroll_event.wait(10) call in _autoscroll_thread() to always
+ instantly succeed, and created an infinite loop eating up CPU.
+Origin: upstream, 
https://bazaar.launchpad.net/~variety/variety/trunk/revision/592
+Bug: https://bugs.launchpad.net/variety/+bug/1494992
+Last-Update: 2017-05-06
+
+---
+ variety/ThumbsWindow.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/variety/ThumbsWindow.py b/variety/ThumbsWindow.py
+index 6cd730c..48ebc43 100644
+--- a/variety/ThumbsWindow.py
 b/variety/ThumbsWindow.py
+@@ -79,6 +79,7 @@ class ThumbsWindow(Gtk.Window):
+ self.mouse_in = False
+ self.mouse_position = None
+ self.previous_speed = 0
++self.autoscroll_event.clear()
+
+ eventbox = Gtk.EventBox()
+ eventbox.set_visible(True)
+--
+2.11.0
+
diff -Nru variety-0.6.3/debian/patches/series 
variety-0.6.3/debian/patches/series
--- variety-0.6.3/debian/patches/series 2017-04-27 22:49:27.0 -0700
+++ variety-0.6.3/debian/patches/series 2017-05-06 16:30:06.0 -0700
@@ -1,3 +1,4 @@
+fix-autoscroll-high-cpu.patch
 disable-panoramio.patch
 menu-position-varargs.patch
 remove-timebombs.patch


Bug#855380: reportbug: UI offers "Back", but doesn't allow to edit the data

2017-05-05 Thread James Lu
Control: severity -1 important
Control: found -1 7.1.6

Dear maintainers,

This bug is quite problematic IMO because it allows reportbug to get
into a state where all useful UI elements are disabled, including the
buttons on the final navigation screen (e.g. "Submit the bug report via
email"). At this point, reportbug is unusable and all info inputed in
the current session is essentially lost to the average user.

I found this bug specifically by clicking the "Choose a mailer to edit
the report" button on the final navigation screen and then hitting Back.
(In my case, I tried that option only to learn that my mail client isn't
in the mailers list, and in the process broke the bug reporter!)

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#861929: furiusisomount: please demote the nautilus dependency

2017-05-05 Thread James Lu
Control: found -1 0.11.3.1~repack1-1
Control: notfound -1 0.11.3.1~repack1-1utopia1

Hi again,

Sorry for the noise, but ignore the spurious "0.11.3.1~repack1-1utopia1"
version - this happened because I applied the attached patch and rebuilt
with a version bump locally.

On 05/05/17 06:16 PM, James Lu wrote:
> Package: furiusisomount
> Version: 0.11.3.1~repack1-1utopia1
> Severity: wishlist
> Tags: patch
> 
> Dear maintainer,
> 
> furiusisomount lists nautilus as a dependency, but doesn't actually require it
> to work. Please consider demoting nautilus to either suggests or enhances, as
> it's otherwise quite inconvenient to use furiusisomount on non-GNOME desktops.
> 
> Best,
> James
> 
> 
> 
> -- System Information:
> Debian Release: 9.0
>   APT prefers testing
>   APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 
> 'testing-debug'), (500, 'unstable'), (101, 'experimental')
> Architecture: amd64
>  (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages furiusisomount depends on:
> ii  fuseiso20070708-3.2+b1
> ii  fuseiso96600.3-1.1+b1
> ii  python-glade2  2.24.0-5.1
> ii  python-gtk22.24.0-5.1
> pn  python:any 
> 
> furiusisomount recommends no packages.
> 
> Versions of packages furiusisomount suggests:
> ii  brasero   3.12.1-4
> pn  nautilus  
> 
> -- no debconf information
> 



signature.asc
Description: OpenPGP digital signature


Bug#861929: furiusisomount: please demote the nautilus dependency

2017-05-05 Thread James Lu
Package: furiusisomount
Version: 0.11.3.1~repack1-1utopia1
Severity: wishlist
Tags: patch

Dear maintainer,

furiusisomount lists nautilus as a dependency, but doesn't actually require it
to work. Please consider demoting nautilus to either suggests or enhances, as
it's otherwise quite inconvenient to use furiusisomount on non-GNOME desktops.

Best,
James



-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages furiusisomount depends on:
ii  fuseiso20070708-3.2+b1
ii  fuseiso96600.3-1.1+b1
ii  python-glade2  2.24.0-5.1
ii  python-gtk22.24.0-5.1
pn  python:any 

furiusisomount recommends no packages.

Versions of packages furiusisomount suggests:
ii  brasero   3.12.1-4
pn  nautilus  

-- no debconf information
>From b74aa14b58f1852e9cbf8d59ab9e6d8803f44893 Mon Sep 17 00:00:00 2001
From: James Lu <ja...@overdrivenetworks.com>
Date: Fri, 5 May 2017 18:12:31 -0700
Subject: [PATCH] d/control: demote nautilus to suggests

---
 debian/control | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 35bcde3..cfa6799 100644
--- a/debian/control
+++ b/debian/control
@@ -18,8 +18,7 @@ Depends: ${python:Depends},
  fuseiso9660,
  python-gtk2,
  python-glade2,
- nautilus
-Suggests: brasero
+Suggests: brasero, nautilus
 Description: ISO, IMG, BIN, MDF and NRG image management utility
  Furius ISO Mount is a simple application for mounting ISO, IMG,
  BIN, MDF and NG image files even without burning them to disk.
-- 
2.11.0



Bug#861376: unblock: variety/0.6.3-4 (pre-upload approval)

2017-04-28 Thread James Lu
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi Release Team,

In the last few months I've prepared quite a few changes for variety, mostly
involving the removal of online wallpaper sources that no longer work, and also
fixing one fairly annoying bug causing menus to show up at the top left of the
screen. I realize this diff is quite significant, so here's a breakdown:

- The menu bug was reported at https://bugs.launchpad.net/variety/+bug/1598298
and fixed in Ubuntu zesty with SRUs to xenial and yakkety pending. The fix
first landed as 0.6.3-2 on March 17 and no regressions have been reported
since.
- The disable-panoramio.patch was based off a similar patch from Arch Linux's
0.6.3-3 package version, and disables Panoramio sources which have been shut
down per https://www.panoramio.com/maps-faq. I modified further also migrate
away from any configured Panoramio, and this change has been in experimental
for 10 days with no regressions reported.
- Cleaning up after the earlier Wallpapers.net source removal from 0.6.3-1:
removing its dependencies (libjs-underscore, python-lxml) which aren't used
anywhere else, and also removing Wallpapers.net from the package description.
- Finally, patch refreshes and updates as part of maintenance: I've also
removed an old setup.py-install-requires.diff patch which was never used in the
build in unstable.
- The only change that hasn't been previously pushed is removing python-lxml
from the build-dependencies, as I forgot to include that with 0.6.3-3.

Attached is a debdiff between 0.6.3-1 (currently in unstable) and 0.6.3-4,
which I plan to release if this is okay.

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500, 'testing-
debug'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
diff -Nru variety-0.6.3/debian/changelog variety-0.6.3/debian/changelog
--- variety-0.6.3/debian/changelog  2016-11-09 20:55:55.0 -0800
+++ variety-0.6.3/debian/changelog  2017-04-27 22:49:27.0 -0700
@@ -1,3 +1,35 @@
+variety (0.6.3-4) unstable; urgency=medium
+
+  * Upload to unstable.
+  * Remove python-lxml from build dependencies as well.
+
+ -- James Lu <bitfl...@gmail.com>  Thu, 27 Apr 2017 22:49:27 -0700
+
+variety (0.6.3-3) experimental; urgency=medium
+
+  * d/control: Remove Wallpapers.net from the extended description; it was
+removed upstream in Variety 0.6.1.
+  * Remove lxml dependency, it is unused since the Wallpapers.net removal in
+Variety 0.6.1.
+  * Drop unused patch setup.py-install-requires.diff
+  * Add disable-panoramio.patch from Arch Linux version 0.6.3-3, modifying
+it to also migrate away from Panoramio sources (LP: #1636389)
+- Also remove libjs-underscore dependency, as Panoramio was the only
+  source using it.
+  * Refresh menu-position-varargs.patch.
+  * Refresh forwarded state & dates of most patches.
+
+ -- James Lu <bitfl...@gmail.com>  Mon, 17 Apr 2017 11:13:39 -0700
+
+variety (0.6.3-2) experimental; urgency=medium
+
+  * Add menu-position-varargs.patch from upstream Bzr revision 582
+(https://bazaar.launchpad.net/~peterlevi/variety/trunk/revision/582)
+to fix menus showing up at the top left of the screen on some systems.
+(LP: #1598298)
+
+ -- James Lu <bitfl...@gmail.com>  Wed, 15 Mar 2017 12:12:09 -0700
+
 variety (0.6.3-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru variety-0.6.3/debian/control variety-0.6.3/debian/control
--- variety-0.6.3/debian/control2016-11-09 20:53:19.0 -0800
+++ variety-0.6.3/debian/control2017-04-27 22:49:24.0 -0700
@@ -8,7 +8,6 @@
  python-pyexiv2,
  python-pycurl,
  python-configobj,
- python-lxml,
  python-imaging,
  python-cairo,
  python-dbus
@@ -41,13 +40,10 @@
  gir1.2-appindicator3-0.1,
  imagemagick,
  python-gi-cairo,
- python-lxml,
- libjs-underscore (>= 1.6.0~)
 Recommends: yelp
 Suggests: feh
 Description: Wallpaper changer, downloader and manager
  Variety is an open-source wallpaper changer, downloader, and manager for
  Linux. It supports a variety of sources for wallpapers, including local
- files, online services such as Flickr, Wallbase.cc, Wallpapers.net,
- NASA Astronomy Picture of the Day, Desktoppr.co, and media RSS feeds
- (Picasa, deviantART, etc.).
+ files, online services such as Flickr, Wallbase.cc, NASA Astronomy Picture of
+ the Day, Desktoppr.co, and media RSS feeds (Picasa, deviantART, etc.).
diff -Nru variety-0.6.3/debian/patches/desktop-file-keywords.diff 
variety-0.6.3/debian/patches/desktop-file-keywords.diff
--- variety-0.6.3/debian/patches/desktop-file-keywords.diff 2016-11-09 
20:53:19.0 -0800
+++ variety-0.6.3/debian/patches/desktop-file-keyword

Bug#854522: ruby-debian: dpkg-checkdeps raises errors with dpkg >= 1.18.11

2017-02-07 Thread James Lu
Package: ruby-debian
Version: 0.3.9+b6
Tags: patch
Severity: minor

dpkg >= 1.18.11 dropped the --print-installation-architecture option as
obsolete, causing dpkg-checkdeps to throw an error on start. The
attached patch replaces that call with 'dpkg --print-architecture' instead.

The exact error looks like this:

dpkg: error: unknown option --print-installation-architecture

Type dpkg --help for help about installing and deinstalling packages [*];
Use 'apt' or 'aptitude' for user-friendly package management;
Type dpkg -Dhelp for a list of dpkg debug flag values;
Type dpkg --force-help for a list of forcing options;
Type dpkg-deb --help for help about manipulating *.deb files;

Options marked [*] produce a lot of output - pipe it through 'less' or
'more' !

Best,
James

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable-debug'), (500,
'testing-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages ruby-debian depends on:
ii  libapt-pkg5.0  1.4~beta4
ii  libc6  2.24-9
ii  libgcc11:6.3.0-5
ii  libgmp10   2:6.1.2+dfsg-1
ii  libruby2.3 2.3.3-1
ii  libstdc++6 6.3.0-5
ii  ruby   1:2.3.3

ruby-debian recommends no packages.

ruby-debian suggests no packages.

-- no debconf information
From c86bc1cc028208bd5274581394cb845330c5618b Mon Sep 17 00:00:00 2001
From: James Lu <ja...@overdrivenetworks.com>
Date: Tue, 7 Feb 2017 15:37:28 -0800
Subject: [PATCH] Call 'dpkg --print-architecture' instead of 'dpkg
 --print-installation-architecture'

--print-installation-architectured was removed as obsolete in dpkg 1.18.11.
---
 lib/debian.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/debian.rb b/lib/debian.rb
index 128e5c1..701943d 100644
--- a/lib/debian.rb
+++ b/lib/debian.rb
@@ -101,7 +101,7 @@ module Debian
 end
 def installation_architecture() 
   # dpkg build time configuration?
-  %x{#{DPKG} --print-installation-architecture}.chomp!
+  %x{#{DPKG} --print-architecture}.chomp!
 end
 module_function :status, :selections, :avail
 module_function :listfiles, :search
-- 
2.11.0



signature.asc
Description: OpenPGP digital signature


Bug#845334: [pkg-wine-party] Bug#845334: wine32: breaks xdg-open, which wants to start wine and crashes

2017-01-05 Thread James Lu
Hi Jens,

That looks good, though I would recommend removing .vbs (VBScript) and
.url (Windows bookmark) from the blacklist as well, because those are
fairly Windows specific files.

On 04/01/17 05:57 PM, Jens Reyer wrote:
> On 05.01.2017 02:03, Jens Reyer wrote:
>> I will probably commit this tomorrow. We may add some information to the
>> README about this, and how to create an association manually.
>
> Alternatively we may change wine.inf (drop "-a") which should help
> normally (?) to prevent native associations, *and* do the blacklisting
> for file types so that if this is still triggered by e.g. installing
> Foxit Reader at least not too many associations are created.
>
> This way anybody preferring the old behavior could just manually run
> "winemenubuilder -a" to create all not-blacklisted associations.
>
> I'd blacklist all extensions for which Wine always creates associations,
> presumably:
> pdf
> rtf
> xml
> gif
> jfif
> jpe
> jpeg
> png
> htm
> html
> txt
> url
> wri - application/x-mswrite=libreoffice-writer.desktop
> msp - Microsoft Paint Image (in Windows 2.0), or
>   application/mspowerpoint=libreoffice-impress.desktop
> vbs - Visual Basic Script
> vbs - Visual Basic Script
> ini - open with notepad or with native editor?
>
>
> Except maybe these:
> chm - Compiled HTML Help is the standard help system for Windows.
> hlp - Microsoft Windows Help file.
>
> ___
> pkg-wine-party mailing list
> pkg-wine-pa...@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-wine-party
>



signature.asc
Description: OpenPGP digital signature


Bug#847482: cinnamon-session: Qt theme overrides no longer work on Qt >= 5.7

2016-12-22 Thread James Lu
Control: reopen 847482

Hi maintainers,

Unfortunately I forgot to mention that for the Qt 5.7 theme override to
work, the build time option --enable-qt57-theme-support also has to be
set. Otherwise, cinnamon-session will still set QT_STYLE_OVERRIDE=gtk
and QT_QPA_PLATFORMTHEME=qgnomeplatform.

Another patch is attached to address this. Thanks for all the hard work
in maintaining Cinnamon in Debian! :)

Best,
James

From 6f54c45b512adba25ef8b0f5eee13948994d1979 Mon Sep 17 00:00:00 2001
From: James Lu <glo...@overdrivenetworks.com>
Date: Thu, 22 Dec 2016 01:01:04 -0800
Subject: [PATCH] debian/rules: add --enable-qt57-theme-support option

---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index aa935e6..9323812 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,7 +12,8 @@ override_dh_autoreconf:
 override_dh_auto_configure:
 	dh_auto_configure -- \
 	--localstatedir=/var/lib \
-	--enable-ipv6
+	--enable-ipv6 \
+	--enable-qt57-theme-support
 
 override_dh_install:
 	dh_install --list-missing
-- 
2.11.0




signature.asc
Description: OpenPGP digital signature


Bug#847482: qt5t not to be expected for stretch

2016-12-09 Thread James Lu
Hi Lisandro,

I think the consensus upstream was that using qt5ct to set themes was
more flexible than simply hardcoding it to gtk2 (e.g. if someone wants
to use adwaita-qt instead). Granted though, I haven't tested qt5ct
outside Cinnamon.

I also haven't tested whether setting the override to 'gtk2' instead of
'gtk' would solve the problem, as I'd have to patch+build
cinnamon-session again. Either way, this still requires qt-styleplugins
to be a newer version; I previously pulled a 5.0.0+git20161024-0.1
version off Mentors that has the latest code, but it looks like that no
longer exists.

Another note: there seems to be some work on getting Cinnamon 3.2
packaged, though I'm not sure whether that's destined for stretch (3.2
includes the patch I mentioned).

Best,
James

On 09/12/16 06:26 AM, Lisandro Damián Nicanor Pérez Meyer wrote:
> Hi! With my Qt maintainer hat on I'm still reluctant to packaging qt5ct 
> because it intereferes with how plasma works *and* uses Qt5's private headers 
> (although I know it doesn't have any options but that).
> 
> So if we ever get to push it it will be for Buster.
> 
> With respect to qtstyleplugins the author of the theme is Qt's othe 
> rmaintainer, CCing him in case he sees something I don't.
> 
> With respect to the patch, isn't there a way to use the gtk plugin instead?
> 



signature.asc
Description: OpenPGP digital signature


Bug#847482: cinnamon-session: Qt theme overrides no longer work on Qt >= 5.7

2016-12-08 Thread James Lu
Package: cinnamon-session
Version: 3.0.1-2
Control: block -1 by 822246 843257

Dear maintainers,

Qt 5.7 moved the GTK+ 2 theme engine from qtbase to qt-style-plugins[1].
In the process, this caused the old setting of QT_STYLE_OVERRIDE=gtk to
stop working, so Qt 5 programs will default to the out-of-place Fusion
theme.

A backported fix from upstream to fix this is attached: it sets Qt to
use qt5ct as a backend, which in turn allows the user to specify what Qt
5 theme to use globally. However, neither qt5ct[2] nor the new
qt5-style-plugins with GTK+2 support[3] have made it into Debian yet, so
there may be a need for a simpler fix.

Best,
James

[1]:
https://github.com/qt/qtstyleplugins/commit/102da7d50231fc5723dba6e72340bef3d29471aa

[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822246

[3]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843257
Description: Make QT5 apps follow the GTK style on Qt >= 5.7
Origin: upstream, https://github.com/linuxmint/cinnamon-session/pull/75
Last-Update: 2016-12-08
Bug: https://github.com/linuxmint/Cinnamon/issues/5440

Index: cinnamon-session/cinnamon-session/main.c
===
--- cinnamon-session.orig/cinnamon-session/main.c	2016-11-24 22:33:52.233384319 -0800
+++ cinnamon-session/cinnamon-session/main.c	2016-11-24 22:33:52.229384394 -0800
@@ -296,6 +296,7 @@
 { "whale", 0, 0, G_OPTION_ARG_NONE, _fail, N_("Show the fail whale dialog for testing"), NULL },
 { NULL, 0, 0, 0, NULL, NULL, NULL }
 };
+char *qt_platform_theme_new = NULL;
 
 /* Make sure that we have a session bus */
 if (!require_dbus_session (argc, argv, )) {
@@ -383,8 +384,23 @@
  */
 csm_util_setenv ("GNOME_DESKTOP_SESSION_ID", "this-is-deprecated");
 
-/* Make QT5 apps follow the GTK style */
-csm_util_setenv ("QT_STYLE_OVERRIDE", "gtk");
+
+/* Make QT5 apps follow the GTK style. Starting with QT 5.7, a different
+ * env var has to be set than what worked in previous versions.
+ */
+qt_platform_theme_new = HAVE_QT57 ? "qt5ct" : "qgnomeplatform";
+
+if (NULL == g_getenv ("QT_QPA_PLATFORMTHEME")) {
+csm_util_setenv ("QT_QPA_PLATFORMTHEME", qt_platform_theme_new);
+}
+
+if ( ! HAVE_QT57 && NULL == g_getenv ("QT_STYLE_OVERRIDE") ) {
+csm_util_setenv ("QT_STYLE_OVERRIDE", "gtk");
+
+} else if (HAVE_QT57 && NULL != g_getenv ("QT_STYLE_OVERRIDE")) {
+g_unsetenv ("QT_STYLE_OVERRIDE");
+}
+
 
 /* GTK Overlay scrollbars */
 settings = g_settings_new ("org.cinnamon.desktop.interface");
Index: cinnamon-session/configure.ac
===
--- cinnamon-session.orig/configure.ac	2016-11-24 22:33:52.233384319 -0800
+++ cinnamon-session/configure.ac	2016-11-24 22:33:55.0 -0800
@@ -108,6 +108,20 @@
 AC_SUBST(LOGIND_LIBS)
 
 dnl 
+dnl Check for qt 5.7+ to set correct env var for theme/styling
+dnl 
+AC_ARG_ENABLE(qt57_theme_support,
+  AS_HELP_STRING([--enable-qt57-theme-support], [Support GTK styles for QT apps with QT 5.7+]),
+  [enable_qt57_theme_support=yes],
+  [enable_qt57_theme_support=no])
+
+if test x$enable_qt57_theme_support = xyes; then
+AC_DEFINE([HAVE_QT57], [1], [Have QT 5.7+])
+else
+AC_DEFINE([HAVE_QT57], [0], [Have QT 5.7+])
+fi
+
+dnl 
 dnl X development libraries check
 dnl 
 
@@ -349,12 +363,13 @@
 
 GConf support:${enable_gconf}
 Logind support:   ${have_logind}
+Qt 5.7+ theme support:${enable_qt57_theme_support}
 IPv6 support: ${have_full_ipv6}
 Backtrace support:${have_backtrace}
 XRender support:  ${have_xrender}
 XSync support:${have_xsync}
 XTest support:${have_xtest}
-	Legacy UPower backend:${have_old_upower}
+Legacy UPower backend:${have_old_upower}
 Build documentation:  ${enable_docbook_docs}
 
 "


signature.asc
Description: OpenPGP digital signature


Bug#845334: [pkg-wine-party] Bug#845334: wine32: breaks xdg-open, which wants to start wine and crashes

2016-11-22 Thread James Lu
Hi Vincent,

As a workaround, you can use the instructions at
https://wiki.winehq.org/FAQ#How_do_I_clean_the_Open_With_List.3F to
remove Wine's file associations:

rm -f ~/.local/share/mime/packages/x-wine*
rm -f ~/.local/share/applications/wine-extension*
rm -f ~/.local/share/icons/hicolor/*/*/application-x-wine-extension*
rm -f ~/.local/share/mime/application/x-wine-extension*

Best,
James

On 22/11/16 07:39 AM, Vincent Lefevre wrote:
> Package: wine32
> Version: 1.8.5-1
> Severity: critical
> Justification: breaks unrelated software
> 
> With wine installed, xdg-open wants to start it, and it crashes:
> 
> cventin:~> echo > foo.html
> cventin:~> xdg-open foo.html
> wine: invalid directory "/home/vlefevre/.wine" in WINEPREFIX: not an absolute 
> path
> Aborted (core dumped)
> cventin:~> file core
> core: ELF 32-bit LSB core file Intel 80386, version 1 (SYSV), SVR4-style, 
> from '/usr/lib/wine/wine start /ProgIDOpen htmlfile foo.html', real uid: 
> 1000, effective uid: 1000, real gid: 1000, effective gid: 1000, execfn: 
> '/usr/lib/wine/wine', platform: 'i686'
> 
> This makes no sense to run wine as the default rule for HTML files!
> 
> -- Package-specific info:
> /usr/bin/wine points to /usr/bin/wine-stable.
> 
> -- System Information:
> Debian Release: stretch/sid
>   APT prefers unstable-debug
>   APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 
> 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.8.0-1-amd64 (SMP w/12 CPU cores)
> Locale: LANG=POSIX, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages wine32 depends on:
> ii  libc62.24-5
> ii  libwine  1.8.5-1
> 
> Versions of packages wine32 recommends:
> ii  wine  1.8.5-1
> 
> Versions of packages wine32 suggests:
> pn  wine32-preloader  
> 
> Versions of packages wine32 is related to:
> ii  fonts-wine  1.8.5-1
> ii  wine1.8.5-1
> ii  wine32  1.8.5-1
> ii  wine64  1.8.5-1
> 
> -- no debconf information
> 
> ___
> pkg-wine-party mailing list
> pkg-wine-pa...@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-wine-party
> 



signature.asc
Description: OpenPGP digital signature


Bug#838858: firmware-amd-graphics: missing SI/CI smc firmware files

2016-11-19 Thread James Lu
Control: merge 838858 843061
Control: tags 838858 + patch

Hi everyone,

I recently upgraded to the 4.8 kernel in Stretch and was hit by this as
well.

The problem seems to be that firmware-amd-graphics doesn't ship the
required radeon/*_k_smc.bin binaries at all. The attached patch adds
these to the build system, and fixes this problem, at least for me.

Best,
James
From 0386d70cb8f490bd4dfa3cfa26e58a6e57569cb2 Mon Sep 17 00:00:00 2001
From: James Lu <glo...@overdrivenetworks.com>
Date: Sat, 19 Nov 2016 13:26:34 -0800
Subject: [PATCH] Ship SI/CI smc firmware files (radeon/*_k_smc.bin)

Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838858
---
 debian/config/amd-graphics/defines | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/debian/config/amd-graphics/defines b/debian/config/amd-graphics/defines
index e727494..7ab6785 100644
--- a/debian/config/amd-graphics/defines
+++ b/debian/config/amd-graphics/defines
@@ -321,6 +321,13 @@ files:
  radeon/VERDE_rlc.bin
  radeon/verde_smc.bin
  radeon/VERDE_smc.bin
+ radeon/verde_k_smc.bin
+ radeon/bonaire_k_smc.bin
+ radeon/hawaii_k_smc.bin
+ radeon/oland_k_smc.bin
+ radeon/pitcairn_k_smc.bin
+ radeon/hainan_k_smc.bin
+ radeon/tahiti_k_smc.bin
 uri: http://git.kernel.org/?p=linux/kernel/git/firmware/linux-firmware.git
 
 [r128/r128_cce.bin_base]
-- 
2.10.2



signature.asc
Description: OpenPGP digital signature


Bug#836706: certificate spoofing via crafted SASL messages

2016-09-05 Thread James Lu
Hi,

Just to narrow things down a bit, the relevant fix for InspIRCd 2.0 is
this commit
https://github.com/inspircd/inspircd/commit/74fafb7f11b06747f69f182ad5e3769b665eea7a

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#796414: ITP: vertex-theme -- Vertex themes for GTK 2/3

2016-08-20 Thread James Lu
Hi Jack,

Creating a CRX file looks a bit problematic because it requires a key
signature, ideally from upstream. I don't think signing on behalf of
upstream developers (or Debian itself) is something that can be easily done.

The closest example I found of packing a Chromium/Chrome extension in
Debian was https://packages.debian.org/sid/chromium-lwn4chrome. There,
it looks like assets (*.png, *.js*, and _locales) are installed raw into
/usr/share/chromium/extensions/lwn4chrome, and a custom loader named
lwn4chrome is installed into /etc/chromium.d/

Below is the contents of the loader (debian/loader/lwn4chrome in the
source). It looks fairly straightforward, working by appending
--load-extension to the flags chromium starts with.

# lwn4chrome extension loader
export CHROMIUM_FLAGS="$CHROMIUM_FLAGS
--load-extension=/usr/share/chromium/extensions/lwn4chrome"

For what it's worth, it might be useful to split up the Firefox and
Chrome-specific themes into separate binaries, and have those recommend
firefox | firefox-esr (depending on which versions are supported) and
chromium respectively. That way, people who aren't using those specific
browsers don't have to install extras they don't need.

Best,
James

On 19/08/2016 2:28 PM, Jack Henschel wrote:
> Hi James,
> 
> thanks for your suggestions!
> 
> I have updated the dependencies and fixed the spelling errors.
> Also, thanks for hinting at README.Debian, that is indeed a better place for 
> these setup instruction (although fewer people might look there).
> 
> I'll still have to look at packaging the Chrome theme.
> The Firefox is no problem, since it is just plain CSS (I have already 
> included it in vertex-theme.install).
> However the Chrome theme (in extra/Chrome) features CRX files [0] as well as 
> a source directive.
> Maybe I can figure out how to 'create' those CRX files and then ship them.
> 
> Best Regards,
> Jack Henschel
> 
> On 08/18/2016 02:32 AM, James Lu wrote:
>> (Disclaimer: I'm not a DD with upload privileges or anything, just a
>> customization enthusiast with a bit of packaging knowledge.)
>>
>> But, some notes anyways on a first glance:
>>
>> * https://github.com/horst3180/vertex-theme lists gnome-themes-standard
>> as a dependency, but that's missing from debian/control
>>
>> * A man page for something like a theme set seems a bit odd to me;
>> aren't those usually for binaries or config files? AFAIK,  README.debian
>> is the most common way of writing notes such as how to configure extras:
>> see https://www.debian.org/doc/manuals/maint-guide/dother.en.html#readme
>>
>> * I noticed some typos in the man page: enviroments instead of
>> environments (line 8), IceWeasel instead of Iceweasel (line 9)
>>
>> Other than that, the package looks fine to me :)
>>
>> Best,
>> James
>>
>> On 17/08/2016 2:48 PM, Jack Henschel wrote:
>>> My progress is now in collab-maint (vertex-theme):
>>>
>>>  https://anonscm.debian.org/git/collab-maint/vertex-theme.git
>>>  git://anonscm.debian.org/collab-maint/vertex-theme.git
>>>
>>> I'm using gbp with the branches master, upstream and pristine-tar.
>>>
>>> What still needs to be done:
>>>
>>>  * Check dependencies
>>>  * Complete and verify manpage
>>>
>>> Oh, and also I still need to fix all the other mistakes I probably made :-)
>>>
>>
> 



signature.asc
Description: OpenPGP digital signature


Bug#796414: ITP: vertex-theme -- Vertex themes for GTK 2/3

2016-08-17 Thread James Lu
(Disclaimer: I'm not a DD with upload privileges or anything, just a
customization enthusiast with a bit of packaging knowledge.)

But, some notes anyways on a first glance:

* https://github.com/horst3180/vertex-theme lists gnome-themes-standard
as a dependency, but that's missing from debian/control

* A man page for something like a theme set seems a bit odd to me;
aren't those usually for binaries or config files? AFAIK,  README.debian
is the most common way of writing notes such as how to configure extras:
see https://www.debian.org/doc/manuals/maint-guide/dother.en.html#readme

* I noticed some typos in the man page: enviroments instead of
environments (line 8), IceWeasel instead of Iceweasel (line 9)

Other than that, the package looks fine to me :)

Best,
James

On 17/08/2016 2:48 PM, Jack Henschel wrote:
> My progress is now in collab-maint (vertex-theme):
> 
>  https://anonscm.debian.org/git/collab-maint/vertex-theme.git
>  git://anonscm.debian.org/collab-maint/vertex-theme.git
> 
> I'm using gbp with the branches master, upstream and pristine-tar.
> 
> What still needs to be done:
> 
>  * Check dependencies
>  * Complete and verify manpage
> 
> Oh, and also I still need to fix all the other mistakes I probably made :-)
> 



signature.asc
Description: OpenPGP digital signature


Bug#834539: RFS: zuki-themes/3.20-1-1 [ITP]

2016-08-16 Thread James Lu
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "zuki-themes"

* Package name: zuki-themes
* Version : 3.20-1-1
* Upstream Author : Mattias 
* URL : https://github.com/lassekongo83/zuki-themes
* License : GPL-3
* Section : x11

It builds those binary packages:

zuki-themes - Zuki themes for GNOME, Xfce and more

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/zuki-themes

Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/z/zuki-themes/zuki-themes_3.20-1-1.dsc

Changes since the last upload:
* Initial Debian release. (Closes: #834278)

One particular note: I'm not quite sure why the debian/watch check on
mentors fails: on my system running stretch/sid, uscan works fine.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#834375: RM: gtk3-engines-unico -- RoM; broken by GTK+ 3.16+

2016-08-14 Thread James Lu
Package: ftp.debian.org
Severity: normal
Control: blocked 822976 by -1

Hi everyone,

I'm requesting the removal of gtk3-engines-unico because it no longer
works with newer GTK+ versions (3.16+). This is the consensus of the
original report at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822976.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#834278: ITP: zuki-themes -- Zuki themes for GNOME, Xfce, and more

2016-08-13 Thread James Lu
Package: wnpp
Severity: wishlist
Owner: James Lu <bitfl...@gmail.com>

* Package name: zuki-themes
  Version : 3.20+git20160813~c8bc920-1
  Upstream Author : lassekongo83
* URL : https://github.com/lassekongo83/zuki-themes
* License : GPL-3
  Description : Zuki themes for GNOME, Xfce, and more

The Zuki themes (Zukitwo, Zukitre) are set of GTK+ themes for GNOME,
Xfce, and other desktops.


The package version is based off a Git snapshot right now because there
are no official versions yet.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#796414: ITP: vertex-theme -- Vertex themes for GTK 2/3

2016-08-13 Thread James Lu
Hi,

Is there any update on this package?

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#831678: Fw: gtk2-engines-murrine: Text shadow misaligned for desktop icons on XFCE

2016-07-23 Thread James Lu
Oh, sorry. I forgot to check who the murrine maintainers were. :s

Best,
James

On Jul 21, 2016 12:17 AM, "Yves-Alexis Perez" <cor...@corsac.net> wrote:

> On mer., 2016-07-20 at 20:34 -0700, James Lu wrote:
> > Hi everyone, forwarding this to pkg-xfce-devel so they're in the loop.
>
> Thanks (although “they” are the same people as the murrine maintainers :)
> --
> Yves-Alexis


Bug#831678: Fw: gtk2-engines-murrine: Text shadow misaligned for desktop icons on XFCE

2016-07-20 Thread James Lu
Control: affects 831678 xfdesktop4

Hi everyone, forwarding this to pkg-xfce-devel so they're in the loop.

Best,
James

On Mon, 18 Jul 2016 08:20:41 -0400 Jeremy Bicha  wrote:
> Package: gtk2-engines-murrine
> Version: 0.98.1.1-6
> 
> The most recent gtk2-engines-murrine update (0.98.1.1-6) to fix bug
> 827134 caused a regression in some themes on the Xfce desktop. The
> text shadow is significantly misaligned with the text for Xfce desktop
> icons. See https://launchpad.net/bugs/1598316
> 
> You can verify using arc-theme which was recently packaged in Debian.
> 
> In my testing, I was not able to duplicate this issue on Ubuntu MATE
> which also uses GTK2 but uses Nautilus to draw the desktop. Therefore,
> I'm thinking this bug should be raised with Xfce.
> 
> Thanks,
> Jeremy Bicha
> 
> 



signature.asc
Description: OpenPGP digital signature


Bug#831678: Re: Bug#831678: gtk2-engines-murrine: Text shadow misaligned for desktop icons on XFCE

2016-07-18 Thread James Lu
Hi everyone,

As far as I'm concerned, what the patches for Numix and Arc actually do
is turn off desktop text shadows entirely, so they're more workarounds
than actual fixes. From my experience, Xfce desktop icon labels without
shadowing become blandly white, which doesn't contrast well with lighter
wallpapers.

A quick look at
https://github.com/shimmerproject/Greybird/blob/master/gtk-2.0/gtkrc
finds no results for "textstyle = 5", which I believe is what enables
shadowing in the first place. That's probably why it's not affected. Arc
[1], Vertex [2], and Numix [3] on the other hand, have all used this
styling.

[1] https://github.com/horst3180/arc-theme/pull/606/files
[2]
https://github.com/horst3180/vertex-theme/blob/60a868e/common/gtk-2.0/gtkrc#L2351
[3] https://github.com/numixproject/numix-gtk-theme/pull/496/files

Best,
James

On Mon, 18 Jul 2016 16:27:38 +0300 =?UTF-8?B?VmxhZCBPcmxvdg==?=
 wrote:
> Hi,
> 
> Sorry guys, I mostly tested the patch in various Debian & Ubuntu 
> installations with MATE.
> The only Xfce system I've tried was Xubuntu 14.04, and I didn't see any 
> regressions there.
> 
> Looking at bug reports linked to the mentioned LP report, I noticed a 
> screenshot showing
> that GreyBird theme isn't affected [1]. Also it seems to be fixed now in 
> Numix theme [2].
> 
> Are Numix, Arc and Vertex themes related somehow?
> 
> [1] https://github.com/horst3180/arc-theme/issues/607
> [2] https://github.com/numixproject/numix-gtk-theme/pull/496



signature.asc
Description: OpenPGP digital signature


Bug#789243: RFS: git-up (WAS: Bug#789243: git-up -- fetch and rebase all locally-tracked remote Git branches)

2016-07-09 Thread James Lu
Agreed. Should I close the ITP then?

Best,
James

On 09/07/2016 1:38 AM, Christian Hofstaedtler wrote:
> * James Lu <bitfl...@gmail.com> [160709 08:37]:
>> Many few months ago, me and David prepared an upload of git-up 0.5.12-1,
>> which can be found in the Debian Ruby Git repository at
>> https://anonscm.debian.org/cgit/pkg-ruby-extras/git-up.git
> [..]
>> Upstream has not done anything so far to fix the bugs with Git 2.5
>> worktrees: https://github.com/aanand/git-up/pull/100. I'm wondering if
>> this is worth including as a patch until it is merged upstream.
> 
> Note that upstream now says:
> 
> | This project is no longer maintained, for several reasons:
> | 
> | * I've stopped using the workflow that made it relevant to me.
> | * Git 2.0 updated the default behaviour to remove the main problem it
> | was solving (by changing the default behaviour of git push so it
> | acts only on the current branch, instead of all branches).
> | * Auto-stashing is now supported natively with git rebase --autostash.
> 
> Therefore I'd strongly suggest not uploading this when it's upstream
> is already gone.
> 
> Best,
> 



signature.asc
Description: OpenPGP digital signature


Bug#650394: ITP: tigervnc -- High-speed Virtual Network Computing (VNC)

2016-06-24 Thread James Lu
Control: block 814959 by 650394

Hi everyone,

I managed to compile tigervnc on Jessie by switching to xserver116.patch
and dropping the X 1.18 compat patch. The standalone server works great,
and I can probably do some similar tests too on sid.

TigerVNC is very modern! It supports screen resizing and fixes my
XKEYBOARD issues under Qt5, so I'm really looking forward to seeing it
in Debian!

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#827128: Please provide/conflict/replace python-nemo

2016-06-12 Thread James Lu
Package: nemo-python
Version: 3.0.0-2
Tags: patch
Severity: wishlist

Many upstream and 3rd party extensions (e.g.
https://launchpad.net/folder-color and
https://github.com/linuxmint/nemo-extensions) still hardcode python-nemo
as a dependency, and this makes transitioning to the new name
(nemo-python) a lot easier. A provides/conflicts/replaces entry should
allow the dependency of python-nemo to be satisfied, but simultaneously
block the upstream python-nemo from being installed.

A patch to do this is attached.

Thanks,
James
From ffb1f8beebf65c6180391fefb75a80c4069e697d Mon Sep 17 00:00:00 2001
From: James Lu <bitfl...@gmail.com>
Date: Sun, 12 Jun 2016 09:18:32 -0700
Subject: [PATCH] d/control: Provide/Conflict/Replace upstream name python-nemo

Many upstream and 3rd party extensions (e.g. https://launchpad.net/folder-color 
and https://github.com/linuxmint/nemo-extensions) still hardcode python-nemo as 
a dependency, so this makes transitioning to the new name a lot easier.
---
 debian/control | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/control b/debian/control
index 8538ee2..75bbece 100644
--- a/debian/control
+++ b/debian/control
@@ -21,6 +21,9 @@ Architecture: any
 Depends: ${misc:Depends},
  ${shlibs:Depends},
  gir1.2-nemo-3.0,
+Provides: python-nemo
+Conflicts: python-nemo
+Replaces: python-nemo
 Description: Python bindings for nemo components
  Python bindings for Nemo, to allow creation of Nemo extensions in Python.
  This allows creating property page and menu item extensions.
-- 
2.8.1



signature.asc
Description: OpenPGP digital signature


Bug#826454: ITP: nemo-emblems -- folder and file emblem support for Nemo

2016-06-05 Thread James Lu
Package: wnpp
Severity: wishlist
Owner: James Lu <bitfl...@gmail.com>

* Package name: nemo-emblems
  Version : 3.0.0
  Upstream Author : Clement Lefebvre <r...@linuxmint.com>
* URL : https://github.com/linuxmint/nemo-extensions
* License : GPL-3
  Programming Lang: Python
  Description : folder and file emblem support for Nemo

Nemo-emblems adds folder and file emblem support to Nemo, the official
file manager for the Cinnamon desktop.



signature.asc
Description: OpenPGP digital signature


Bug#822976: gtk3-engines-unico: Package broken by GTK 3.16

2016-05-03 Thread James Lu
Hi George,

As far as I'm concerned, Unico itself isn't even a theme - it's an
engine that theme authors can borrow from. I don't think it has any
reverse dependencies in Debian, but various themes in Ubuntu (where the
package originates) have it listed as a dependency or used to.

Perhaps I should inquire with upstream on what exactly still uses Unico
in the coming days.



gl@millennium:~$ reverse-depends gtk3-engines-unico -r xenial
Reverse-Depends
===
* lubuntu-artwork-11-10
* lubuntu-artwork-12-04
* lubuntu-artwork-12-10
* lubuntu-artwork-13-04
* lubuntu-artwork-13-10
* lubuntu-artwork-14-04
* lubuntu-artwork-14-10
* lubuntu-artwork-15-04
* lubuntu-artwork-15-10
* lubuntu-artwork-16-04
* mythbuntu-default-settings

Packages without architectures listed are reverse-dependencies in:
amd64, arm64, armhf, i386, powerpc, ppc64el, s390x

gl@millennium:~$ reverse-depends gtk3-engines-unico -r sid
No reverse dependencies found

Best,
James

On 03/05/2016 8:19 AM, George B. wrote:
> Hi James,
> 
> On 30/04/16 06:13, James Lu wrote:
>> Since newer GTK versions have already made it into the archive, does
>> that mean that this package no longer serves any purpose?
> 
> It would appear so - oxygen-gtk3 package was removed for the same
> reason.[1]
> 
>> From what I
>> can tell, GTK3 engines for Breeze and Xfce still exist elsewhere in the
>> archive: https://packages.debian.org/search?keywords=gtk3-engines-
> 
> Breeze was actually ported to CSS - I have already filed a bug with a
> request to rename the package to avoid confusion.[2]
> 
> The Xfce package contains a mix of partially converted and broken
> themes. [3]
> 
>> If this inevitably ends with Unico being removed, I guess I'm okay with
>> that too. What might be the best course of action here?
> 
> I guess the best solution would be to port the theme to CSS, but it is
> not the easiest. ;)
> 
> 
> Best regards,
> 
> George
> 
> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797796
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822975
> [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762936
> 
> 



signature.asc
Description: OpenPGP digital signature


Bug#822976: gtk3-engines-unico: Package broken by GTK 3.16

2016-04-29 Thread James Lu
Hi,

Since newer GTK versions have already made it into the archive, does
that mean that this package no longer serves any purpose? From what I
can tell, GTK3 engines for Breeze and Xfce still exist elsewhere in the
archive: https://packages.debian.org/search?keywords=gtk3-engines-

If this inevitably ends with Unico being removed, I guess I'm okay with
that too. What might be the best course of action here?

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#820388: variety: Section should be “x11”

2016-04-07 Thread James Lu
package variety
unarchive 814705
reopen 814705
merge 814705 820388
tags 814705 + fixed
thanks

Hi,

I've already fixed this error in the package; I'm just waiting for
FTP-masters to fix up the section on their side. Perhaps I closed the
old bug too early, but I'll reopen it now.

Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#650394: ITP: tigervnc -- High-speed Virtual Network Computing (VNC)

2016-03-31 Thread James Lu
Hi everyone,

Is there any update to this ITP? I came upon the pkg-tigervnc sources in
Alioth, but I can't get it to build on my Debian 8 server due to
differences in the X server versions. Is there any possibility of
creating an up-to-date build for stable based on what's already done?

I've also found the NeuroDebian packages for Jessie, but that seems to
be of a pretty old version 1.2.0+X1.12.4-1~nd70+1, and isn't installable
at all.

Getting TigerVNC to work may be a workaround to issues I'm having with
TightVNC lacking XKEYBOARD support.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=814959 makes
everything using Qt 5 quite difficult to use.

Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 tigervnc-standalone-server : Depends: tigervnc-common but it is not
going to be installed
  Depends: libaudit0 (>= 1.7.13) but it is
not installable
  Depends: libgcrypt11 (>= 1.4.5) but it is
not installable
  Depends: libgnutls26 (>= 2.12.17-0) but it
is not installable
  Depends: libjpeg8 (>= 8c) but it is not
installable
E: Unable to correct problems, you have held broken packages.


Best,
James



signature.asc
Description: OpenPGP digital signature


Bug#792089: gnome-screenshot: GNOME Screenshot flash doesn't go away until the app exits

2016-03-26 Thread James Lu
Control: fixed 792089 3.18.0-1

I can no longer reproduce this in GNOME Screenshot 3.18 in
testing/unstable. So I assume this was either fixed upstream or
something similar.

Best,
James



signature.asc
Description: OpenPGP digital signature


  1   2   >