Bug#1043317: duck: Please drop "parked domain" test

2023-08-12 Thread gregor herrmann
On Sat, 12 Aug 2023 14:54:16 +0200, Baptiste Beauplat wrote:

> > Checking for "deprecated" (on upstream websites which document
> > functions) or "replaced (by|with)" doesn't make any sense IMO …
> > Please just remove tese tests …
> First, I agree with you, "replaced (by|with)" and "deprecated" are too
> generic not to trigger false positives. I'll be removing them from the
> list.

Excellent!
I guess that solves most of my grievances with duck.
 
> Secondly, even if, as stated by the check certainty, the suggestion is
> at most a wild-guess, I would like to keep the test as it can still be
> useful to catch deprecated projets or links that moved on to another
> page. However, I want to have a way for users to filter the checks
> based on certainty. I'll be adding an option for that both in the cli
> arguments and the configuration file. Although, I'll keep the default
> to show all checks.

Sounds good as well.
 
> Finally, the checks for obsoletes sites is currently at a certainty of
> wild-guess. I'll be bumping that to possible as, to the contrary of the
> parked test, its a list of well known deprecated sites, and virtually
> has no chance of false positive.

I guess that makes sense for well-known obsolete sites.

Thanks for maintaining and improving duck!


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature


Bug#1043317: duck: Please drop "parked domain" test

2023-08-12 Thread Baptiste Beauplat
Hi Gregor,

On Wed, 2023-08-09 at 03:21 +0200, gregor herrmann wrote:
> I like duck and run it after each package build.
> Unfortunately typically I get output from the wild-guess check for
> some strings on websites where duck tells me that the upstream
> homepage or the Debian BTS or a well-known license is a "parked
> domain of for sale", and this test is almost always a false positive.
> 
> Current example, package rex:
> 
> I: debian/copyright:62: URL:
> https://www.apache.org/licenses/LICENSE-2.0: INFORMATION
> (Certainty:wild-guess)
>    Curl:0 HTTP:200 No error 
>    Website seems to be outdated, is probably a parked domain or for
> sale. Please update your links!
>    Matching regular expression(s):
>     m/\breplaced with\b/i
> 
> I: debian/control: Homepage: https://www.rexify.org/: INFORMATION
> (Certainty:wild-guess)
>    Curl:0 HTTP:200 No error 
>    Website seems to be outdated, is probably a parked domain or for
> sale. Please update your links!
>    Matching regular expression(s):
>     m/\breplace .* with\b/i
> 
> I: debian/upstream/metadata:URL: https://github.com/RexOps/Rex.git:
> INFORMATION (Certainty:wild-guess)
>    Curl:0 HTTP:200 No error 
>    Website seems to be outdated, is probably a parked domain or for
> sale. Please update your links!
>    Matching regular expression(s):
>     m/\breplace .* with\b/i
> 
> I: debian/upstream/metadata:URL: https://github.com/RexOps/Rex:
> INFORMATION (Certainty:wild-guess)
>    Curl:0 HTTP:200 No error 
>    Website seems to be outdated, is probably a parked domain or for
> sale. Please update your links!
>    Matching regular expression(s):
>     m/\breplace .* with\b/i
> 
> 
> Checking for "deprecated" (on upstream websites which document
> functions) or "replaced (by|with)" doesn't make any sense IMO …
> Please just remove tese tests …

There are a couple of different points I'd like to address in order to
fix this issue.

First, I agree with you, "replaced (by|with)" and "deprecated" are too
generic not to trigger false positives. I'll be removing them from the
list.

Secondly, even if, as stated by the check certainty, the suggestion is
at most a wild-guess, I would like to keep the test as it can still be
useful to catch deprecated projets or links that moved on to another
page. However, I want to have a way for users to filter the checks
based on certainty. I'll be adding an option for that both in the cli
arguments and the configuration file. Although, I'll keep the default
to show all checks.

Finally, the checks for obsoletes sites is currently at a certainty of
wild-guess. I'll be bumping that to possible as, to the contrary of the
parked test, its a list of well known deprecated sites, and virtually
has no chance of false positive.

Best,
-- 
Baptiste Beauplat



signature.asc
Description: This is a digitally signed message part


Bug#1043317: duck: Please drop "parked domain" test

2023-08-08 Thread gregor herrmann
Package: duck
Version: 0.14.2
Severity: wishlist

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

I like duck and run it after each package build.
Unfortunately typically I get output from the wild-guess check for
some strings on websites where duck tells me that the upstream
homepage or the Debian BTS or a well-known license is a "parked
domain of for sale", and this test is almost always a false positive.

Current example, package rex:

I: debian/copyright:62: URL: https://www.apache.org/licenses/LICENSE-2.0: 
INFORMATION (Certainty:wild-guess)
   Curl:0 HTTP:200 No error 
   Website seems to be outdated, is probably a parked domain or for sale. 
Please update your links!
   Matching regular expression(s):
m/\breplaced with\b/i

I: debian/control: Homepage: https://www.rexify.org/: INFORMATION 
(Certainty:wild-guess)
   Curl:0 HTTP:200 No error 
   Website seems to be outdated, is probably a parked domain or for sale. 
Please update your links!
   Matching regular expression(s):
m/\breplace .* with\b/i

I: debian/upstream/metadata:URL: https://github.com/RexOps/Rex.git: INFORMATION 
(Certainty:wild-guess)
   Curl:0 HTTP:200 No error 
   Website seems to be outdated, is probably a parked domain or for sale. 
Please update your links!
   Matching regular expression(s):
m/\breplace .* with\b/i

I: debian/upstream/metadata:URL: https://github.com/RexOps/Rex: INFORMATION 
(Certainty:wild-guess)
   Curl:0 HTTP:200 No error 
   Website seems to be outdated, is probably a parked domain or for sale. 
Please update your links!
   Matching regular expression(s):
m/\breplace .* with\b/i


Checking for "deprecated" (on upstream websites which document
functions) or "replaced (by|with)" doesn't make any sense IMO …
Please just remove tese tests …


Cheers,
gregor

-BEGIN PGP SIGNATURE-

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmTS6ixfFIAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgahWhAAuUO8pMaL8fa+Ev1Y4VZZHJ8ggKB3zRjmoAouYPHdhC0UGonJCCxwYT/R
nLRxe60k2cRPE+Zog6XuD888vUqvy1XKQDbdTvE+Xk11clmJVabnAnYYF6xsNe1B
trlfBP+P54xBFUMxDxu0JNEvUc9mdQ0gGf+HeNFWdIVzxXsw7ipj3C/igDMG0DeC
d7rPYbt1SuESh3sAsusxyTdp60s7vn8Hpa4mXByQcpop6l19qA32TOG1qWJdIldf
8y6PNrOubYt5rl+aZKbuxzPe5HgfO0C4wfFEtGgOXRj9LplZc2Qw9fEEDOWETCXt
XRlAr9JwZSLZcOQmw3vGCnDPVERCBdFdbOH102QVfq6Hk5xsoTk/fRFWoBMOtnEl
2V4sLGoaOuCgCCj9rgVH9ZO8noGAhPKgi0O5WSAtm2rOYGyr4YHclPr935uuz1iR
m1LIFoHQOFP6lwETFFnyo9SjegrGZ0HqE5mTLTMa43nKI7e5qrLXsBM4kScMy21x
trn+lcp6H7Ngy+41r4Lc93XoVTnhT1hlKPvtgsx2tfQ1SEEZvR6janTFEuZCM2wg
IC0RvAw9UqhRiU7lL6y40Goa8PcmPRRCMudcx486dEI0u0r5bL30vq4NB1QphMsw
PwOemyLoay01URDcI+SR50Lqz4isBD7LOO3BcU2k1YcXCZEdPJ8=
=V19B
-END PGP SIGNATURE-