Bug#351394: All debconf stuff can probably be cleaned from the qmail package
Jon Marler [EMAIL PROTECTED] (15/01/2007): Quoting Thomas Huriaux [EMAIL PROTECTED]: I don't see any reason to close this bug. If you don't want to fix this issue, please tag it as wontfix. In order to have this bug fixed, I wrote a full patch. Here are my comments on the debconf templates, as the rest just depends on these fixes: The reason to close this bug is that is has been fixed. The problem was that I included information using debconf that didn't need to be there. All of the qmail-src debconf entries did not fit the policy, and have been removed. I am the package maintainer, and I am allowed to make decisions on what information is included and displayed when the package is installed. I have decided that my previous use of debconf has been deprecated, and therefore, I have no further use for debconf. In fact, I have removed all dependency on debconf from qmail-src. Sure, but my patch is for the debconf system used by the *qmail binary* package, not the qmail-src one. Cheers, -- Thomas Huriaux signature.asc Description: Digital signature
Bug#351394: All debconf stuff can probably be cleaned from the qmail package
reopen 351394 tag 351394 patch thanks Hi, Jon Marler [EMAIL PROTECTED] (01/11/2006): Go and get the latest qmail-src package. That patch won't even apply to it. Check qmail-src version -40. Most of that has already been done. I can probably close those bugs without any additional modifications even necessary. I don't see any reason to close this bug. If you don't want to fix this issue, please tag it as wontfix. In order to have this bug fixed, I wrote a full patch. Here are my comments on the debconf templates, as the rest just depends on these fixes: -Template: qmail/readme -Type: note -Description: README - Before making any changes to your qmail configuration, please read - /usr/share/doc/qmail/README.Debian.gz. This contains a description of the - differences bewtween other mailers on Debian, qmail on Debian, and qmail on - other systems. - . - If you were using sendmail (or smail) previously, you will also want to read - the qmail-upgrade manpage, which details user-visible differences between - sendmail and qmail. - . - If you are new to qmail, you will want to at least peruse the qmail FAQ, which - can be found in /usr/doc/qmail This one should go to the inline documentation. Template: qmail/start -Type: select -Choices: yes, no -Description: Do you want to start qmail now? - -Template: qmail/reboot -Type: note -Description: Qmail will be started at the next reboot. - Or you can start qmail manually when - you are ready by typing (as root) /etc/init.d/qmail start at a shell prompt. +Type: boolean +Default: true +_Description: Do you want to start qmail now? + If you do not want to start qmail now, it will be started at the next + reboot. You can also start qmail manually when you are ready by typing + (as root) /etc/init.d/qmail start at a shell prompt. These two templates should be merged so that the user knows what will happen if he/she chooses no. A yes/no select choice is a boolean template. Template: qmail/userpurge -Type: select -Choices: yes, no -Description: Remove qmail users during a purge? +Type: boolean +Default: true +_Description: Remove qmail users during a purge? A yes/no select choice is a boolean template. -Template: qmail/recipientmap -Type: note -Description: WARNING! - recipientmap is gone from qmail-1.03. The virtualdomains mechanism - has been expanded to support virtual users. You will need to fix your setup. - -Template: qmail/qlist -Type: note -Description: WARNING! - qlist has been split into a separate package by Dan Bernstein (the - author of qmail) since qmail-1.02. - . - I was not planning on debianising qlist, because ezmlm does a better job, - so if you still want qlist, you can either get it direct from - http://pobox.com/~djb/qlist.html - . - Please check in /usr/doc/qmail and the man pages for changes since qmail 1.01 These templates should go to a NEWS.Debian file. However, as 1.03 appears with Potato, they can simply be removed (Slink - Etch transitions are of course not supported). Template: qmail/inetd -Type: note -Description: inetd.conf changes - inetd does not handle qmail terribly effectively, so I have decided - to make the default instalation use tcpserver from ucspi-tcp instead. +Type: error +_Description: SMTP entry in /etc/inetd.conf + The /etc/inetd.conf file of your system contains an smtp entry. + . + inetd does not handle qmail terribly effectively, so the default + installation uses tcpserver from ucspi-tcp instead. . - For this reason, I have disabled the smtp line in /etc/inetd.conf. + For this reason, the smtp line in /etc/inetd.conf was disabled. . This means that you must configure things such as RELAYCLIENT using - /etc/tcp.smtp, rather than hosts allow (see /usr/doc/qmail/README for details) + /etc/tcp.smtp, rather than hosts allow (see /usr/doc/qmail/README for + details). This one should use the error type and should be rephrased to fit the dev-ref. -Template: qmail/tcpupdate -Type: note -Description: Updating /etc/tcp.smtp database for tcpserver I don't see any reason to stop the installation to display this information. -Template: qmail/override -Type: select -Choices: yes, no -Description: Pre-existing qmail installation detected. Override? This template is not use anywhere. I hope this help. Cheers, -- Thomas Huriaux diff -Nur qmail-1.03/debian/control qmail-1.03.fixed/debian/control --- qmail-1.03/debian/control 2007-01-15 22:28:00.0 +0100 +++ qmail-1.03.fixed/debian/control 2007-01-15 22:28:14.0 +0100 @@ -6,7 +6,7 @@ Package: qmail-src Architecture: all -Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, adduser +Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, adduser, po-debconf Build-Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make, fakeroot | sudo, groff-base, adduser Conflicts: qmail-run, qmail-uids-gids Section: non-free/mail diff -Nur
Bug#351394: All debconf stuff can probably be cleaned from the qmail package
Quoting Thomas Huriaux [EMAIL PROTECTED]: I don't see any reason to close this bug. If you don't want to fix this issue, please tag it as wontfix. In order to have this bug fixed, I wrote a full patch. Here are my comments on the debconf templates, as the rest just depends on these fixes: The reason to close this bug is that is has been fixed. The problem was that I included information using debconf that didn't need to be there. All of the qmail-src debconf entries did not fit the policy, and have been removed. I am the package maintainer, and I am allowed to make decisions on what information is included and displayed when the package is installed. I have decided that my previous use of debconf has been deprecated, and therefore, I have no further use for debconf. In fact, I have removed all dependency on debconf from qmail-src. I won't close this bug, but I'll move it to the wishlist. The package does not violate the spirit of what debconf was intended for, or any Debian policies, or even interact in any way with debconf. Technically, what you are now asking, is that I add in new debconf support. Thank you for the suggestion, I will add it to the wishlist. If that is not enough to placate you, please feel free to waste more of everyone's time and whine on. Jon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#351394: All debconf stuff can probably be cleaned from the qmail package
Oh no, not him again, says Jon...:-)
Actually, this contribution is less invasive and controversial than
the former we had to deal with, I think.
With the removal of debconf stuff, I think that #351394 can be closed
as it becomes obviously useless to switch to po-debconf for templates.
This means that debian/qmail.templates and debian/qmail.config can be
removed from the package. Some references to debconf perl modules can
also probably be removed from the maintainer scripts and, finally, the
dependencies and build dependencies on debconf can be removed as well.
(BTW, having Build-Depends for the qmail-src binary package sounds
weird to me).
Attached is a patch. That patch should close the following bug
reports:
#351394, #330785, #331009
--
diff -Nru qmail-1.03.ori/debian/control qmail-1.03/debian/control
--- qmail-1.03.ori/debian/control 2006-10-31 20:34:47.819191126 +0100
+++ qmail-1.03/debian/control 2006-11-01 11:30:44.412404207 +0100
@@ -2,13 +2,13 @@
Maintainer: Jon Marler [EMAIL PROTECTED]
Section: non-free/mail
Priority: extra
-Build-Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make,
fakeroot | sudo, groff-base, debconf | debconf-2.0
+Build-Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make,
fakeroot | sudo, groff-base
Standards-Version: 3.5.0.0
Package: qmail-src
Architecture: all
-Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make, fakeroot |
sudo, groff-base, debconf | debconf-2.0
-Build-Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make,
fakeroot | sudo, groff-base, debconf | debconf-2.0
+Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make, fakeroot |
sudo, groff-base
+Build-Depends: dpkg-dev (= 1.4.0.20), patch (= 2.5-0bo1), gcc, make,
fakeroot | sudo, groff-base
Conflicts: qmail-run, qmail-uids-gids
Section: non-free/mail
Recommends: ucspi-tcp-src, procmail
diff -Nru qmail-1.03.ori/debian/postinst qmail-1.03/debian/postinst
--- qmail-1.03.ori/debian/postinst 2006-10-31 20:34:47.835191288 +0100
+++ qmail-1.03/debian/postinst 2006-11-01 11:28:53.723514891 +0100
@@ -1,8 +1,5 @@
#!/usr/bin/perl
-use Debconf::Client::ConfModule ':all';
-version('2.0');
-
# do not print anything to STDOUT, as debconf will interpret it as a command
sub debug ($) {
my($msg) = @_;
diff -Nru qmail-1.03.ori/debian/postrm qmail-1.03/debian/postrm
--- qmail-1.03.ori/debian/postrm2006-10-31 20:34:47.835191288 +0100
+++ qmail-1.03/debian/postrm2006-11-01 11:29:14.003677734 +0100
@@ -1,8 +1,5 @@
#!/usr/bin/perl
-use Debconf::Client::ConfModule ':all';
-version('2.0');
-
$| = 1;
$action = shift @ARGV;
diff -Nru qmail-1.03.ori/debian/preinst qmail-1.03/debian/preinst
--- qmail-1.03.ori/debian/preinst 2006-10-31 20:34:47.835191288 +0100
+++ qmail-1.03/debian/preinst 2006-11-01 11:29:53.139992106 +0100
@@ -3,7 +3,6 @@
require 5.002;
use strict 'subs';
use English;
-use Debconf::Client::ConfModule ':all';
# do not print anything to STDOUT, as debconf will interpret it as a command.
# This is not an issue with preinst/postinst scripts written in shell,
diff -Nru qmail-1.03.ori/debian/qmail.config qmail-1.03/debian/qmail.config
--- qmail-1.03.ori/debian/qmail.config 2006-10-31 20:34:47.851191450 +0100
+++ qmail-1.03/debian/qmail.config 1970-01-01 01:00:00.0 +0100
@@ -1,5 +0,0 @@
-#!/bin/sh -e
-
-# Source debconf library.
-. /usr/share/debconf/confmodule
-
diff -Nru qmail-1.03.ori/debian/qmail.templates
qmail-1.03/debian/qmail.templates
--- qmail-1.03.ori/debian/qmail.templates 2006-10-31 20:34:47.851191450
+0100
+++ qmail-1.03/debian/qmail.templates 1970-01-01 01:00:00.0 +0100
@@ -1,69 +0,0 @@
-Template: qmail/readme
-Type: note
-Description: README
- Before making any changes to your qmail configuration, please read
- /usr/share/doc/qmail/README.Debian.gz. This contains a description of the
- differences bewtween other mailers on Debian, qmail on Debian, and qmail on
- other systems.
- .
- If you were using sendmail (or smail) previously, you will also want to read
- the qmail-upgrade manpage, which details user-visible differences between
- sendmail and qmail.
- .
- If you are new to qmail, you will want to at least peruse the qmail FAQ, which
- can be found in /usr/doc/qmail
-
-Template: qmail/start
-Type: select
-Choices: yes, no
-Description: Do you want to start qmail now?
-
-Template: qmail/reboot
-Type: note
-Description: Qmail will be started at the next reboot.
- Or you can start qmail manually when
- you are ready by typing (as root) /etc/init.d/qmail start at a shell prompt.
-
-Template: qmail/userpurge
-Type: select
-Choices: yes, no
-Description: Remove qmail users during a purge?
-
-Template: qmail/recipientmap
-Type: note
-Description: WARNING!
- recipientmap is gone from qmail-1.03. The virtualdomains mechanism
- has been expanded to support virtual users. You will need to fix your setup.
-
-Template: qmail/qlist
-Type: note
-Description:
