Bug#575384: ethos: diff for NMU version 0.2.2-1.1
Hello Mathieu! (I stripped off zack from CC as he's not interested in this descussion) On Wed, Apr 07, 2010 at 11:02:32AM -0400, Mathieu Trudel-Lapierre wrote: > Andreas or Stefano, would you be able to review my package for > emerillon, since it is complete? (see > http://mentors.debian.net/debian/pool/main/e/emerillon/ ) > We're getting quite off topic for this bugreport, but here's my quick review anyway. (In the future, please post RFS to debian-ment...@lists.debian.org and feel free to CC me). General nitpicks: please remove empty/useless files/directories under debian/ (e.g. patches/series) You should fix the libethos-ui-dev bug rather then working around it by adding libethos-ui-1.0-0 to you build-dependecies. More importantly: I'm not particularily found of you building an "orig" tarball from upstream git. The upstream git repo and the upstream orig tarball doesn't match. Your tarball will miss any files added by upstream during make dist. Your tarball checksum will not match the upstream checksum making it hard to verify it's not been tampered with. You have many build-dependencies which is only needed because you're using a git snapshot rather then the actual release tarball. Since you're using CDBS anyway, I suggest you look at gnome-pkg-tools helper script for downloading the actual orig tarballs from ftp.gnome.org instead. This way you could also have a functional debian/watch file. Another suggestion would be to ask for this package to be maintained in pkg-gnome by the gnome packaging team. Since emerillon is very "gnomey", it would likely be accepted and you'd get the benefit of team maintenance when you're busy while it would lower the barrier for you to help out with other gnome(-related) packages which I'm sure the gnome packaging team would appreciate. :) > Also, I'm not entirely familiar with the NMU process, could someone > clarify what I am supposed to do at this point, either by email, or we > could get in contact on IRC... To summarize what zack said, if you do nothing the bug will be fixed in 2 days... after that you should make sure to incorporate zacks changes in your next ethos upload. -- Andreas Henriksson signature.asc Description: Digital signature
Bug#575384: ethos: diff for NMU version 0.2.2-1.1
Le mercredi 07 avril 2010 à 16:10 +0200, Andreas Henriksson a écrit : > On Wed, Apr 07, 2010 at 03:38:20PM +0200, Stefano Zacchiroli wrote: > > Andreas: I've uploaded more or less the same patch of yours. Given that > > you are a DD, next time you might want to consider doing a very long > > DELAYED upload straight ahead when you prepare your NMU. That way, if > > the maintainer does not intervene, there is no need to give an > > additional stab at the patch to have it hit the archive. Of course, > > YMMV. Thanks a lot for your patch! > > AFAIK nothing uses ethos in debian yet, so there was no immediate hurry > to fix it since it could easily be removed from testing if needed. > > Given that Mathieu actually replies to my mails, I wanted to give him > a chance to take care of the packages himself. > (Mathieu, please group-reply instead of private replies to me > so others can see your replies.) > Yikes, sorry, I am still intending to get this completed. I apologize again for the time it takes. I'm not going to get into the reasons for these delays :) Andreas or Stefano, would you be able to review my package for emerillon, since it is complete? (see http://mentors.debian.net/debian/pool/main/e/emerillon/ ) Also, I'm not entirely familiar with the NMU process, could someone clarify what I am supposed to do at this point, either by email, or we could get in contact on IRC... Regards, -- Mathieu Trudel-Lapierre Freenode: cyphermox, Jabber: mathieu...@gmail.com 4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93 signature.asc Description: Ceci est une partie de message numériquement signée
Bug#575384: ethos: diff for NMU version 0.2.2-1.1
On Wed, Apr 07, 2010 at 11:02:32AM -0400, Mathieu Trudel-Lapierre wrote:
> Andreas or Stefano, would you be able to review my package for
> emerillon, since it is complete? (see
> http://mentors.debian.net/debian/pool/main/e/emerillon/ )
I'll leave this up to Andreas, I'm currently not interested in ethos at
large, I just wanted to squash this specific RC bug.
> Also, I'm not entirely familiar with the NMU process, could someone
> clarify what I am supposed to do at this point, either by email, or we
> could get in contact on IRC...
In fact, this one is a *delayed* NMU, delayed by 2 days. So for the next
2 days nothing will happen. If they pass without anyone doing anything,
the NMU will hit the archive. It just means that at the next upload of
yours you should acknowledge the NMU (check developer's reference for a
bit more info on this).
If your upload (sponsored) hits the archive before the expiration, it
will just "override" my NMU as yours version will be newer than mine,
and everybody will be happy :-)
If you need more time for the sponsoring (you and/or Andreas, of course)
just let me know and I can postpone of a few days---or even cancel, if
you want so---my DELAYED NMU.
Cheers.
--
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..| . |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...| ..: | Je dis tu à tous ceux que j'aime
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#575384: ethos: diff for NMU version 0.2.2-1.1
On Wed, Apr 07, 2010 at 03:38:20PM +0200, Stefano Zacchiroli wrote: > Andreas: I've uploaded more or less the same patch of yours. Given that > you are a DD, next time you might want to consider doing a very long > DELAYED upload straight ahead when you prepare your NMU. That way, if > the maintainer does not intervene, there is no need to give an > additional stab at the patch to have it hit the archive. Of course, > YMMV. Thanks a lot for your patch! AFAIK nothing uses ethos in debian yet, so there was no immediate hurry to fix it since it could easily be removed from testing if needed. Given that Mathieu actually replies to my mails, I wanted to give him a chance to take care of the packages himself. (Mathieu, please group-reply instead of private replies to me so others can see your replies.) If Mathieus words continues to fails become action, I'm interested in taking over the packages (ethos and the emerillon ITP) rather then NMUing them. With the problem in ethos fixed, I guess I'll hold off on that hijack for a while more. Watch out for my emerillon ITP hijack coming soon! Regards, Andreas Henriksson -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#575384: ethos: diff for NMU version 0.2.2-1.1
On Wed, Apr 07, 2010 at 04:10:49PM +0200, Andreas Henriksson wrote:
> AFAIK nothing uses ethos in debian yet, so there was no immediate hurry
> to fix it since it could easily be removed from testing if needed.
Agreed on this specific package, but remember that the overall number of
RC bugs is anyhow an indication of how far we're from releasing, so
keeping it low is useful anyhow :-)
> Given that Mathieu actually replies to my mails, I wanted to give him
Uh? That was not clear from the bug log ...
> (Mathieu, please group-reply instead of private replies to me so
> others can see your replies.)
Indeed.
> If Mathieus words continues to fails become action, I'm interested in
> taking over the packages (ethos and the emerillon ITP) rather then
> NMUing them.
I'll leave this up to you. Just let me know if any of you wants my
DELAYED NMU to be rescheduled (anticipated/postponed, either way),
otherwise it'll expire in 2 days.
Cheers.
--
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..| . |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...| ..: | Je dis tu à tous ceux que j'aime
signature.asc
Description: Digital signature
Bug#575384: ethos: diff for NMU version 0.2.2-1.1
tags 575384 + pending
thanks
Dear maintainer,
I've prepared an NMU for ethos (versioned as 0.2.2-1.1) and uploaded it
to DELAYED/2, according to devref §5.11.1. Please feel free to tell me
if I should delay it reschedule it somehow.
Andreas: I've uploaded more or less the same patch of yours. Given that
you are a DD, next time you might want to consider doing a very long
DELAYED upload straight ahead when you prepare your NMU. That way, if
the maintainer does not intervene, there is no need to give an
additional stab at the patch to have it hit the archive. Of course,
YMMV. Thanks a lot for your patch!
Regards.
--
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..| . |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...| ..: | Je dis tu à tous ceux que j'aime
diff -u ethos-0.2.2/debian/control ethos-0.2.2/debian/control
--- ethos-0.2.2/debian/control
+++ ethos-0.2.2/debian/control
@@ -62,7 +62,8 @@
Package: libethos-ui-dev
Section: libdevel
Architecture: any
-Depends: libethos-1.0-0 (= ${binary:Version}),
+Depends: libethos-dev,
+ libethos-ui-1.0-0 (= ${binary:Version}),
${misc:Depends},
libglib2.0-dev (>= 2.16.0),
libgtk2.0-dev (>= 2.10.0)
diff -u ethos-0.2.2/debian/libethos-dev.install ethos-0.2.2/debian/libethos-dev.install
--- ethos-0.2.2/debian/libethos-dev.install
+++ ethos-0.2.2/debian/libethos-dev.install
@@ -1,4 +1,3 @@
-debian/tmp/usr/lib/libethos-1.0.la
debian/tmp/usr/lib/libethos-1.0.so
debian/tmp/usr/lib/pkgconfig/ethos-1.0*
debian/tmp/usr/share/vala/vapi/ethos-1.0.vapi
diff -u ethos-0.2.2/debian/libethos-ui-dev.install ethos-0.2.2/debian/libethos-ui-dev.install
--- ethos-0.2.2/debian/libethos-ui-dev.install
+++ ethos-0.2.2/debian/libethos-ui-dev.install
@@ -1,4 +1,3 @@
-debian/tmp/usr/lib/libethos-ui-1.0.la
debian/tmp/usr/lib/libethos-ui-1.0.so
debian/tmp/usr/lib/pkgconfig/ethos-ui-1.0*
debian/tmp/usr/share/vala/vapi/ethos-ui-1.0.vapi
diff -u ethos-0.2.2/debian/changelog ethos-0.2.2/debian/changelog
--- ethos-0.2.2/debian/changelog
+++ ethos-0.2.2/debian/changelog
@@ -1,3 +1,14 @@
+ethos (0.2.2-1.1) unstable; urgency=low
+
+ * Non-maintainer upload
+ * Make libethos-ui-dev depend on libethos-dev since it
+needs ethos.h, and libethos-ui-1.0-0 instead of libethos-1.0-0
+(which will now be pulled in by the added libethos-ui-dev dep);
+patch by Andreas Henriksson. (Closes: #575384)
+ * Don't install .la files (Squeeze release goal)
+
+ -- Stefano Zacchiroli Wed, 07 Apr 2010 15:07:09 +0200
+
ethos (0.2.2-1) unstable; urgency=low
* Initial packaging. (Closes: #551100)
