Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
Bill,
Thanks for reminding us of this one.
A fix has now been committed:
http://public.kitware.com/cgi-bin/viewcvs.cgi/Wrapping/CSwig/CMakeLists.txt?root=Insightr1=1.64r2=1.65
and I'm running an Experimental build
with CableSwig Python wrapping with
make -j8.
Luis
On Mon, Apr 19, 2010 at 9:10 PM, Bill Hoffman bill.hoff...@kitware.comwrote:
On 4/19/2010 8:36 PM, Steve M. Robbins wrote:
On Mon, Apr 19, 2010 at 09:26:13AM -0400, Luis Ibanez wrote:
Steve,
Excellent!.
Just to confirm:
are you using the traditional wrapping ?
Yes, I'm using CSwig.
or are you using WrapITK ?
Is that fully supported now? Last fall there was some issues with
using it and NOT using Review [1]. Note also that for Debian we
need to wrap all three languages: python, tcl, and java.
I just checked the code and it is still broken in CVS.
SET(ITK_WRAP_NEEDS_DEPEND 1)
IF(${CMAKE_MAKE_PROGRAM} MATCHES make)
SET(ITK_WRAP_NEEDS_DEPEND 0)
ENDIF(${CMAKE_MAKE_PROGRAM} MATCHES make)
That should be removed, for all generators ITK_WRAP_NEEDS_DEPEND should be
set to 1, or parallel builds will not work.
That code is in Insight/Wrapping/CSwig/CMakeLists.txt
-Bill
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
Steve, Excellent!. Just to confirm: are you using the traditional wrapping ? or are you using WrapITK ? Thanks Luis --- On Mon, Apr 19, 2010 at 1:14 AM, Steve M. Robbins st...@sumost.ca wrote: On Sun, Apr 18, 2010 at 07:59:58PM -0400, Luis Ibanez wrote: Steve, Thanks for the offer, Setting up a parallel build will be very helpful. OK, so it turns out I've build building in parallel all along! I've just enabled wrapping for Java, Python and Tcl to see if that works in parallel. -Steve -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLy殍⋙돒ᶳ᱑ု㓰ਊ툟웡腏䚑衍瓳ﱀ� lP2I2bCUMywmXNSDqfRB11E= =RIxz -END PGP SIGNATURE-
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
On Mon, Apr 19, 2010 at 09:26:13AM -0400, Luis Ibanez wrote: Steve, Excellent!. Just to confirm: are you using the traditional wrapping ? Yes, I'm using CSwig. or are you using WrapITK ? Is that fully supported now? Last fall there was some issues with using it and NOT using Review [1]. Note also that for Debian we need to wrap all three languages: python, tcl, and java. OK, so it failed last night. The first problem is that it doesn't build with tcl 8.5 http://public.kitware.com/Bug/view.php?id=10532 so I applied my proposed patch. If you see 1 file modified from CVS, that is why. I still have some java issue to work out before it even builds in a single process. I hope to fix it up before tonight's run. Cheers, -Steve [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=550496 http://lists.debian.org/debian-med/2009/11/msg00059.html signature.asc Description: Digital signature
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
On 4/19/2010 8:36 PM, Steve M. Robbins wrote:
On Mon, Apr 19, 2010 at 09:26:13AM -0400, Luis Ibanez wrote:
Steve,
Excellent!.
Just to confirm:
are you using the traditional wrapping ?
Yes, I'm using CSwig.
or are you using WrapITK ?
Is that fully supported now? Last fall there was some issues with
using it and NOT using Review [1]. Note also that for Debian we
need to wrap all three languages: python, tcl, and java.
I just checked the code and it is still broken in CVS.
SET(ITK_WRAP_NEEDS_DEPEND 1)
IF(${CMAKE_MAKE_PROGRAM} MATCHES make)
SET(ITK_WRAP_NEEDS_DEPEND 0)
ENDIF(${CMAKE_MAKE_PROGRAM} MATCHES make)
That should be removed, for all generators ITK_WRAP_NEEDS_DEPEND should
be set to 1, or parallel builds will not work.
That code is in Insight/Wrapping/CSwig/CMakeLists.txt
-Bill
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
Gaetan, Brad, Bill, Is there something we could do to make possible to build the ITK Wrappers using CMake's parallel building capabilities ? Thanks for any advice, Luis -- On Sun, Apr 18, 2010 at 3:57 PM, Lucas Nussbaum lu...@lucas-nussbaum.netwrote: Source: insighttoolkit Version: 3.16.0-2 Hi, insighttoolkit takes a very long time to build. On my setup, the 10 packages that take the most time are (with build duration in seconds): axiom 7036 qt4-x11 7050 python3.1 7255 gcc-4.4 7774 installation-guide 8141 mysql-dfsg-5.1 8445 life 9397 openoffice.org 11265 insighttoolkit 14791 atlas 29688 Please support building the package in parallel to leverage multicore CPUs or SMP systems (see policy 4.9.1 for details). I've seen the note in debian/rules saying that parallel building of wrappers is broken. Is there really nothing we can do? Couldn't it be possible to build most of the package in parallel, and then build the wrappers sequentially, for example? -- | Lucas Nussbaum | lu...@lucas-nussbaum.net http://www.lucas-nussbaum.net/ | | jabber: lu...@nussbaum.fr GPG: 1024D/023B3F4F | ___ Debian-med-packaging mailing list debian-med-packag...@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-med-packaging
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
On 4/18/2010 4:26 PM, Luis Ibanez wrote: Gaetan, Brad, Bill, Is there something we could do to make possible to build the ITK Wrappers using CMake's parallel building capabilities ? Thanks for any advice, This has been fixed/broken so many times No one reports the errors back. It should be pretty easy to fix, just add a few add_dependencies statements. In fact, Luis you and I looked at this about 6 months ago, and there was an ifdef windows thing. Because the windows build would not work at all since VS always does parallel these days. So, I would first look for add_dependencies calls in the ITK cmake lists files. If they are conditional on WIN32 get rid of that and always do it. If that is not the problem, I would need a list of the errors in the parallel build. After that we need a dashboard that does a parallel build of ITK with wrapping so this does not break again, and again, and again :) -Bill Luis -- On Sun, Apr 18, 2010 at 3:57 PM, Lucas Nussbaum lu...@lucas-nussbaum.net mailto:lu...@lucas-nussbaum.net wrote: Source: insighttoolkit Version: 3.16.0-2 Hi, insighttoolkit takes a very long time to build. On my setup, the 10 packages that take the most time are (with build duration in seconds): axiom 7036 qt4-x11 7050 python3.1 7255 gcc-4.4 7774 installation-guide 8141 mysql-dfsg-5.1 8445 life 9397 openoffice.org http://openoffice.org 11265 insighttoolkit 14791 atlas 29688 Please support building the package in parallel to leverage multicore CPUs or SMP systems (see policy 4.9.1 for details). I've seen the note in debian/rules saying that parallel building of wrappers is broken. Is there really nothing we can do? Couldn't it be possible to build most of the package in parallel, and then build the wrappers sequentially, for example? -- | Lucas Nussbaum | lu...@lucas-nussbaum.net mailto:lu...@lucas-nussbaum.net http://www.lucas-nussbaum.net/ | | jabber: lu...@nussbaum.fr mailto:lu...@nussbaum.fr GPG: 1024D/023B3F4F | ___ Debian-med-packaging mailing list debian-med-packag...@lists.alioth.debian.org mailto:debian-med-packag...@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-med-packaging -- Bill Hoffman Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 bill.hoff...@kitware.com http://www.kitware.com 518 881-4905 (Direct) 518 371-3971 x105 Fax (518) 371-4573 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
On Sun, Apr 18, 2010 at 05:00:35PM -0400, Bill Hoffman wrote: This has been fixed/broken so many times No one reports the errors back. The last time I reported it was http://www.cmake.org/pipermail/insight-users/2009-October/033352.html which includes a report with make output from a build last July. I have not tried recently to see if it was fixed. WIN32 get rid of that and always do it. If that is not the problem, I would need a list of the errors in the parallel build. After that we need a dashboard that does a parallel build of ITK with wrapping so this does not break again, and again, and again For the latter: I'm happy to turn on parallel building with wrapping for riemann.sumost.ca! Regards, -Steve signature.asc Description: Digital signature
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
Bill, Agree, we need a Nightly build that exercises the parallel build for wrapping. We are also missing Windows and Mac Nightly builds for the wrapping. Luis - On Sun, Apr 18, 2010 at 5:00 PM, Bill Hoffman bill.hoff...@kitware.comwrote: On 4/18/2010 4:26 PM, Luis Ibanez wrote: Gaetan, Brad, Bill, Is there something we could do to make possible to build the ITK Wrappers using CMake's parallel building capabilities ? Thanks for any advice, This has been fixed/broken so many times No one reports the errors back. It should be pretty easy to fix, just add a few add_dependencies statements. In fact, Luis you and I looked at this about 6 months ago, and there was an ifdef windows thing. Because the windows build would not work at all since VS always does parallel these days. So, I would first look for add_dependencies calls in the ITK cmake lists files. If they are conditional on WIN32 get rid of that and always do it. If that is not the problem, I would need a list of the errors in the parallel build. After that we need a dashboard that does a parallel build of ITK with wrapping so this does not break again, and again, and again :) -Bill Luis -- On Sun, Apr 18, 2010 at 3:57 PM, Lucas Nussbaum lu...@lucas-nussbaum.net mailto:lu...@lucas-nussbaum.net wrote: Source: insighttoolkit Version: 3.16.0-2 Hi, insighttoolkit takes a very long time to build. On my setup, the 10 packages that take the most time are (with build duration in seconds): axiom 7036 qt4-x11 7050 python3.1 7255 gcc-4.4 7774 installation-guide 8141 mysql-dfsg-5.1 8445 life 9397 openoffice.org http://openoffice.org 11265 insighttoolkit 14791 atlas 29688 Please support building the package in parallel to leverage multicore CPUs or SMP systems (see policy 4.9.1 for details). I've seen the note in debian/rules saying that parallel building of wrappers is broken. Is there really nothing we can do? Couldn't it be possible to build most of the package in parallel, and then build the wrappers sequentially, for example? -- | Lucas Nussbaum | lu...@lucas-nussbaum.net mailto:lu...@lucas-nussbaum.net http://www.lucas-nussbaum.net/ | | jabber: lu...@nussbaum.fr mailto:lu...@nussbaum.fr GPG: 1024D/023B3F4F | ___ Debian-med-packaging mailing list debian-med-packag...@lists.alioth.debian.org mailto:debian-med-packag...@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-med-packaging -- Bill Hoffman Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 bill.hoff...@kitware.com http://www.kitware.com 518 881-4905 (Direct) 518 371-3971 x105 Fax (518) 371-4573
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
Steve, Thanks for the offer, Setting up a parallel build will be very helpful. Luis On Sun, Apr 18, 2010 at 5:27 PM, Steve M. Robbins st...@sumost.ca wrote: On Sun, Apr 18, 2010 at 05:00:35PM -0400, Bill Hoffman wrote: This has been fixed/broken so many times No one reports the errors back. The last time I reported it was http://www.cmake.org/pipermail/insight-users/2009-October/033352.html which includes a report with make output from a build last July. I have not tried recently to see if it was fixed. WIN32 get rid of that and always do it. If that is not the problem, I would need a list of the errors in the parallel build. After that we need a dashboard that does a parallel build of ITK with wrapping so this does not break again, and again, and again For the latter: I'm happy to turn on parallel building with wrapping for riemann.sumost.ca! Regards, -Steve -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLy3ks0i2bPSHbMcURAiDoAKCv2x+wxueePr9rAu1uxK7bGgAezACgrwF2 orHmGHVlKke8B+eJuxjavdA= =fnLB -END PGP SIGNATURE-
Bug#578313: [Debian-med-packaging] Bug#578313: insighttoolkit: please support parallel building
On Sun, Apr 18, 2010 at 07:59:58PM -0400, Luis Ibanez wrote: Steve, Thanks for the offer, Setting up a parallel build will be very helpful. OK, so it turns out I've build building in parallel all along! I've just enabled wrapping for Java, Python and Tcl to see if that works in parallel. -Steve signature.asc Description: Digital signature
