Bug#611855: [sylpheed:34472] Re: Bug#611855: sylpheed crashes (perhaps during mailbox check)
tags 611855 + fixed-upstream patch
thanks
On Thu, Feb 17, 2011 at 03:30:34PM +0900, Hiroyuki Yamamoto wrote:
It seems that I have found the cause of problem.
Please try the attached patch to see it fixes the crash.
The change has been made since 3.1beta2. Actually messages are added
with sorted but without threading until receiving will be completed.
Before 3.1beta2, messages were not appeared at all until completing
receiving.
It has been a month since this fix applied, sylpheed does not crash.
So I set tags and attach fix patch from upstream SVN.
--
Regards,
dai
GPG Fingerprint = 0B29 D88E 42E6 B765 B8D8 EA50 7839 619D D439 668E
Index: sylpheed/src/summaryview.c
===
--- sylpheed/src/summaryview.c (revision 2818)
+++ sylpheed/src/summaryview.c (revision 2845)
@@ -1120,6 +1120,7 @@
summaryview-all_mlist = g_slist_concat(summaryview-all_mlist, qlist);
item-cache_dirty = TRUE;
+ summary_selection_list_free(summaryview);
summary_status_show(summaryview);
@@ -2204,10 +2205,12 @@
GtkTreeIter iter;
GtkTreePath *path = (GtkTreePath *)cur-data;
- gtk_tree_model_get_iter(model, iter, path);
- gtk_tree_model_get(model, iter, S_COL_MSG_INFO, msginfo, -1);
- sel_size += msginfo-size;
- n_selected++;
+ if (gtk_tree_model_get_iter(model, iter, path)) {
+ gtk_tree_model_get(model, iter,
+ S_COL_MSG_INFO, msginfo, -1);
+ sel_size += msginfo-size;
+ n_selected++;
+ }
}
if (FOLDER_TYPE(summaryview-folder_item-folder) == F_NEWS) {
signature.asc
Description: Digital signature
Bug#611855: [sylpheed:34472] Re: Bug#611855: sylpheed crashes (perhaps during mailbox check)
On Tue, 15 Feb 2011 16:46:05 +0900 Hiroyuki Yamamoto hir...@kcn.ne.jp wrote: Hello, On Tue, 15 Feb 2011 11:52:54 +0900 d+sylph...@vdr.jp wrote: It seems that everyone crashed at the same point: summaryview.c: summary_show_queued_msgs() - summary_status_show() The GtkTreeStore iterator somehow became invalid there. I haven't figure out the reason yet. Yeah, yesterday I reproduced it. While I opened some folder, I sent test mail that filtered to there, sylpheed always crashed. But today I could not reproduce it by same way. I did not change any settings. It is very strange. It seems that I have found the cause of problem. Please try the attached patch to see it fixes the crash. The patch seems to be working so far. In two days I couldn't get sylpheed to crash anymore (using a recent svn checkout with this change in it already). Hiro-san, am I right that this change may defer sorting messages to after all messages are downloaded? I can see that new messages are moved to a certain folder due to filter rules but not reordered until all the downloads complete. Totally acceptable BTW. Maybe it has always been that way but I am noticing only now, if so, sorry for the noise. Thanks and Regards, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? pgpFdvDowaP6k.pgp Description: PGP signature
Bug#611855: [sylpheed:34472] Re: Bug#611855: sylpheed crashes (perhaps during mailbox check)
Hello, On Wed, 16 Feb 2011 16:09:41 +0100 Antonio Ospite osp...@studenti.unina.it wrote: On Tue, 15 Feb 2011 16:46:05 +0900 Hiroyuki Yamamoto hir...@kcn.ne.jp wrote: It seems that I have found the cause of problem. Please try the attached patch to see it fixes the crash. The patch seems to be working so far. In two days I couldn't get sylpheed to crash anymore (using a recent svn checkout with this change in it already). I'm glad to hear that. Hiro-san, am I right that this change may defer sorting messages to after all messages are downloaded? I can see that new messages are moved to a certain folder due to filter rules but not reordered until all the downloads complete. Totally acceptable BTW. Maybe it has always been that way but I am noticing only now, if so, sorry for the noise. The change has been made since 3.1beta2. Actually messages are added with sorted but without threading until receiving will be completed. Before 3.1beta2, messages were not appeared at all until completing receiving. -- Hiroyuki Yamamoto hir...@kcn.ne.jp -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
