Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
On Sat, Jun 30, 2012 at 12:35:28AM +0200, Gonéri Le Bouder wrote: 2012/6/30 Michael Biebl bi...@debian.org: On 30.06.2012 00:18, Gonéri Le Bouder wrote: On Thu, Jan 19, 2012 at 10:49:29AM +, Roger Leigh wrote: On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: /dev/.udev/db has been deprecated a long time ago. If fusioninventory-agent does not actually need that information, why keep the code? The agent can still run on older system. When you're packaging this software for Debian, you're targetting it at the versions of the packages in unstable. This code is useless for wheezy, since all systems will be using the udev version provided with wheezy, which doesn't include /dev/.udev/db irrespective of whether or not udev is using /run/udev or /dev/.udev as its directory. It's long gone, and so is useless to even attempt to use. It might be fine to conditionally enable it /if /dev/.udev is present/, but it should certainly not be using these paths now by default. I would recommend patching it out in Debian if you do choose to retain it upstream. Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
2012/6/30 Roger Leigh rle...@codelibre.net: On Sat, Jun 30, 2012 at 12:35:28AM +0200, Gonéri Le Bouder wrote: 2012/6/30 Michael Biebl bi...@debian.org: On 30.06.2012 00:18, Gonéri Le Bouder wrote: On Thu, Jan 19, 2012 at 10:49:29AM +, Roger Leigh wrote: On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: /dev/.udev/db has been deprecated a long time ago. If fusioninventory-agent does not actually need that information, why keep the code? The agent can still run on older system. When you're packaging this software for Debian, you're targetting it at the versions of the packages in unstable. This code is useless for wheezy, since all systems will be using the udev version provided with wheezy, which doesn't include /dev/.udev/db irrespective of whether or not udev is using /run/udev or /dev/.udev as its directory. It's long gone, and so is useless to even attempt to use. /dev/.udev doesn't exist anymore on up to date Debian release but the directory, will remains here on older Linux installations. I don't see a good reason to patch that in the Debian package. At best we will avoid a stat() call on a virtual filesystem and the code is designed to deal with that. It might be fine to conditionally enable it /if /dev/.udev is present/, but it should certainly not be using these paths now by default. I would recommend patching it out in Debian if you do choose to retain it upstream. Do you know a similar alternative solution to get the list of the block devices and the associated information? Best regards, -- Gonéri Le Bouder -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
On 30.06.2012 00:18, Gonéri Le Bouder wrote: On Thu, Jan 19, 2012 at 10:49:29AM +, Roger Leigh wrote: On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: There is no db directory with the current version of udev, hence the function getDevicesFromUdev will always fail given that the glob will always fail. This is something that needs additional work. As the original bug report stated, using udev internals directly is a bad plan, given that they have now changed. Hello Roger and Michael, First, sorry for the delay. FusionInventory-Agent try various different way to get information about the system. I belive it's hameless to keep the current code. At worst glob() will return an empty list. /dev/.udev/db has been deprecated a long time ago. If fusioninventory-agent does not actually need that information, why keep the code? signature.asc Description: OpenPGP digital signature
Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
2012/6/30 Michael Biebl bi...@debian.org: On 30.06.2012 00:18, Gonéri Le Bouder wrote: On Thu, Jan 19, 2012 at 10:49:29AM +, Roger Leigh wrote: On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: /dev/.udev/db has been deprecated a long time ago. If fusioninventory-agent does not actually need that information, why keep the code? The agent can still run on older system. Best regards, -- Gonéri Le Bouder -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
On 30.06.2012 00:35, Gonéri Le Bouder wrote: 2012/6/30 Michael Biebl bi...@debian.org: On 30.06.2012 00:18, Gonéri Le Bouder wrote: On Thu, Jan 19, 2012 at 10:49:29AM +, Roger Leigh wrote: On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: /dev/.udev/db has been deprecated a long time ago. If fusioninventory-agent does not actually need that information, why keep the code? The agent can still run on older system. That doesn't explain my question, does it? If fusioninventory-agent needs that information, it should be updated to use /run/udev If it doesn't need that information, it should drop the relevant code. signature.asc Description: OpenPGP digital signature
Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
2012/6/30 Michael Biebl bi...@debian.org: On 30.06.2012 00:35, Gonéri Le Bouder wrote: 2012/6/30 Michael Biebl bi...@debian.org: On 30.06.2012 00:18, Gonéri Le Bouder wrote: On Thu, Jan 19, 2012 at 10:49:29AM +, Roger Leigh wrote: On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: /dev/.udev/db has been deprecated a long time ago. If fusioninventory-agent does not actually need that information, why keep the code? The agent can still run on older system. That doesn't explain my question, does it? If fusioninventory-agent needs that information, it should be updated to use /run/udev If it doesn't need that information, it should drop the relevant code. FusionInventory will try different methods to get the list of the block devices, so no, it won't hurt. The patch was imported some years ago to get manufacturer/serial/module for the given device. http://gitorious.org/fusioninventory/agent/commit/0aecefcf99a09f826c078ebf92b2b0370ce47a6d Best regards, -- Gonéri Le Bouder -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#644312: fusioninventory-agent: /run transition: Please update use of /dev/.udev
On Tue, Oct 04, 2011 at 11:48:06PM +0200, bi...@debian.org wrote: During an automated test your package fusioninventory-agent was flagged to reference files/directories matching /dev/.udev A log of this test can be found at [2]. In most cases checking for /dev/.udev is used to determine if udev is active. This check no longer works with udev using /run/udev now. I've attached a patch which uses /run/udev, falling back to /dev/.udev if present. However, note that there's a fundamental flaw in your program: foreach my $file (glob (/dev/.udev/db/*)) % ls /run/udev control data links queue.bin rules.d tags watch There is no db directory with the current version of udev, hence the function getDevicesFromUdev will always fail given that the glob will always fail. This is something that needs additional work. As the original bug report stated, using udev internals directly is a bad plan, given that they have now changed. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `-GPG Public Key: 0x25BFB848 Please GPG sign your mail. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
