Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
Am 04.07.13 12:05, schrieb Vincent Cheng: On Thu, Jul 4, 2013 at 2:22 AM, Christian Zigotzky wrote: Am 04.07.13 03:46, schrieb Vincent Cheng: On Wed, Jul 3, 2013 at 1:42 PM, Christian Zigotzky wrote: Hi Vincent, The issue with the wrong colors has been solved. :) Please insert the following line into file COpenGLExtensionHandler.cpp, line 372 (directly before MultiTextureExtension = FeatureAvailable[IRR_ARB_multitexture] ;) FeatureAvailable[IRR_ARB_vertex_array_bgra]=FeatureAvailable[IRR_EXT_vertex_array_bgra]=false; Is it safe to change this for all platforms, i.e. will this cause any rendering issues on non-ppc and/or little endian systems? Does upstream endorse making this change permanent, e.g. link to upstream svn commit please? Regards, Vincent Hi Vincent, This patch is only for ppc systems. It isn't suitable for other systems like x86, ARM etc. The reason I ask whether this is suitable for non-ppc systems is that if I apply your patch in Debian/Ubuntu stk source package, that will affect all binary packages built from that source, including on non-ppc archs (there's no way for me to upload a ppc-specific source package and/or have this patch applied _only_ on ppc). Although I suppose I can just wrap the additional line of code that fixes this bug on ppc with an #ifdef __powerpc__ statement? I'm very happy about this patch. STK 0.8 works as well as the x86 version of STK 0.8. I have released a static package of STK 0.8 with AltiVec support and integrated Irrlicht patch: http://sourceforge.net/projects/supertuxkart/files/SuperTuxKart/0.8/supertuxkart-0.8-altivec-linux-glibc2.13-ppc.tar.bz2/download The Irrlicht patch is an unofficial patch for ppc systems at time. Unfortunately there isn't a link to a upstream svn commit. I'm sorry. Can you please push upstream to include this patch in their svn repo? I'd feel a lot more comfortable applying it in Debian if I knew for certain that upstream approves of it, and that it's going to be included in future releases so I don't have to maintain that patch any longer than necessary. I'll readily admit that I don't know anything about opengl and/or irrlicht, hence why I'm a bit averse to including this patch without upstream's approval. Regards, Vincent Hi Vincent, Thank you for your answer. I'll try to get a patch from the irrlicht team (http://irrlicht.sourceforge.net/forum/viewtopic.php?f=7&t=48577&p=281596#p281541). :) Regards, Christian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
On Thu, Jul 4, 2013 at 2:31 AM, Fabian Greffrath wrote: > Am Donnerstag, den 04.07.2013, 11:22 +0200 schrieb Christian Zigotzky: >> The Irrlicht patch is an unofficial patch for ppc systems at time. >> Unfortunately there isn't a link to a upstream svn commit. I'm sorry. > > No commit, but the forum where this workaround has been discussed: > > http://irrlicht.sourceforge.net/forum/viewtopic.php?f=7&t=48577&p=281620&hilit=IRR_ARB_vertex_array_bgra#p281599 > > - Fabian > > Ack, but the points I've raised in my previous reply still stand. I don't want to inadvertently break anything, and it also provides a measure of accountability if I have an upstream commit I can reference in the proposed patch. :) Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
On Thu, Jul 4, 2013 at 2:22 AM, Christian Zigotzky wrote: > Am 04.07.13 03:46, schrieb Vincent Cheng: > >> On Wed, Jul 3, 2013 at 1:42 PM, Christian Zigotzky >> wrote: >>> >>> Hi Vincent, >>> >>> The issue with the wrong colors has been solved. :) >>> >>> Please insert the following line into file COpenGLExtensionHandler.cpp, >>> line >>> 372 (directly before MultiTextureExtension = >>> FeatureAvailable[IRR_ARB_multitexture] ;) >>> >>> FeatureAvailable[IRR_ARB_vertex_array_bgra]=FeatureAvailable[IRR_EXT_vertex_array_bgra]=false; >>> >> Is it safe to change this for all platforms, i.e. will this cause any >> rendering issues on non-ppc and/or little endian systems? Does >> upstream endorse making this change permanent, e.g. link to upstream >> svn commit please? >> >> Regards, >> Vincent >> >> > Hi Vincent, > > This patch is only for ppc systems. It isn't suitable for other systems like > x86, ARM etc. The reason I ask whether this is suitable for non-ppc systems is that if I apply your patch in Debian/Ubuntu stk source package, that will affect all binary packages built from that source, including on non-ppc archs (there's no way for me to upload a ppc-specific source package and/or have this patch applied _only_ on ppc). Although I suppose I can just wrap the additional line of code that fixes this bug on ppc with an #ifdef __powerpc__ statement? > I'm very happy about this patch. STK 0.8 works as well as the x86 version of > STK 0.8. > I have released a static package of STK 0.8 with AltiVec support and > integrated Irrlicht patch: > > http://sourceforge.net/projects/supertuxkart/files/SuperTuxKart/0.8/supertuxkart-0.8-altivec-linux-glibc2.13-ppc.tar.bz2/download > > The Irrlicht patch is an unofficial patch for ppc systems at time. > Unfortunately there isn't a link to a upstream svn commit. I'm sorry. Can you please push upstream to include this patch in their svn repo? I'd feel a lot more comfortable applying it in Debian if I knew for certain that upstream approves of it, and that it's going to be included in future releases so I don't have to maintain that patch any longer than necessary. I'll readily admit that I don't know anything about opengl and/or irrlicht, hence why I'm a bit averse to including this patch without upstream's approval. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
Am Donnerstag, den 04.07.2013, 11:22 +0200 schrieb Christian Zigotzky: > The Irrlicht patch is an unofficial patch for ppc systems at time. > Unfortunately there isn't a link to a upstream svn commit. I'm sorry. No commit, but the forum where this workaround has been discussed: http://irrlicht.sourceforge.net/forum/viewtopic.php?f=7&t=48577&p=281620&hilit=IRR_ARB_vertex_array_bgra#p281599 - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
Am 04.07.13 03:46, schrieb Vincent Cheng: On Wed, Jul 3, 2013 at 1:42 PM, Christian Zigotzky wrote: Hi Vincent, The issue with the wrong colors has been solved. :) Please insert the following line into file COpenGLExtensionHandler.cpp, line 372 (directly before MultiTextureExtension = FeatureAvailable[IRR_ARB_multitexture] ;) FeatureAvailable[IRR_ARB_vertex_array_bgra]=FeatureAvailable[IRR_EXT_vertex_array_bgra]=false; Is it safe to change this for all platforms, i.e. will this cause any rendering issues on non-ppc and/or little endian systems? Does upstream endorse making this change permanent, e.g. link to upstream svn commit please? Regards, Vincent Hi Vincent, This patch is only for ppc systems. It isn't suitable for other systems like x86, ARM etc. I'm very happy about this patch. STK 0.8 works as well as the x86 version of STK 0.8. I have released a static package of STK 0.8 with AltiVec support and integrated Irrlicht patch: http://sourceforge.net/projects/supertuxkart/files/SuperTuxKart/0.8/supertuxkart-0.8-altivec-linux-glibc2.13-ppc.tar.bz2/download The Irrlicht patch is an unofficial patch for ppc systems at time. Unfortunately there isn't a link to a upstream svn commit. I'm sorry. Regards, Christian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
On Wed, Jul 3, 2013 at 1:42 PM, Christian Zigotzky wrote: > Hi Vincent, > > The issue with the wrong colors has been solved. :) > > Please insert the following line into file COpenGLExtensionHandler.cpp, line > 372 (directly before MultiTextureExtension = > FeatureAvailable[IRR_ARB_multitexture] ;) > FeatureAvailable[IRR_ARB_vertex_array_bgra]=FeatureAvailable[IRR_EXT_vertex_array_bgra]=false; > Is it safe to change this for all platforms, i.e. will this cause any rendering issues on non-ppc and/or little endian systems? Does upstream endorse making this change permanent, e.g. link to upstream svn commit please? Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#714519: supertuxkart: Wrong colors in the powerpc version -solved-
Hi Vincent, The issue with the wrong colors has been solved. :) Please insert the following line into file COpenGLExtensionHandler.cpp, line 372 (directly before MultiTextureExtension = FeatureAvailable[IRR_ARB_multitexture] ;) FeatureAvailable[IRR_ARB_vertex_array_bgra]=FeatureAvailable[IRR_EXT_vertex_array_bgra]=false; Regards, Christian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
