Bug#737614: subversion: When updating a repository, please tell from which revision we update
Am Mittwoch, den 05.02.2014, 15:51 -0600 schrieb Peter Samuelson: 'svn update' always updates to a single revision (HEAD by default, or you can specify a revision with -r), so it prints that single revision. So, the question boils down to What should be shown as old revision, if not all files in the repo had the same old revision?. Honestly, I don't know. :/ - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#737614: subversion: When updating a repository, please tell from which revision we update
[Fabian Greffrath] So, the question boils down to What should be shown as old revision, if not all files in the repo had the same old revision?. If you really want this feature and are trying to figure out the design, look at 'svnversion'. In the mixed-rev case, it shows a range. (It also explicitly indicates whether there are any switched subdirs or modified files, which you probably don't need here.) Also, note that 'svn update' can be thought of as just a special case of 'svn switch'. (That is, switch does 2 things, changes the repository path _and_ updates to a specified revision, or to HEAD.) With that in mind, as you implement this, you should probably make sure it works for both 'svn update' and 'svn switch'. Peter -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#737614: subversion: When updating a repository, please tell from which revision we update
Am Dienstag, den 04.02.2014, 23:37 -0600 schrieb Peter Samuelson: What would you expect the software to say in a mixed-rev wc? I don't know, I have never worked with such a repository (and my patch only addresses the simple single-rev wc case). What does it say which revision it updated to in a mixed-rev wc? If it tells you multiple current revisions, it could as well tell you multiple previous revisions. Or in other words, if the nb-revision variable is set, the nb-old_revision variable should be set as well. - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#737614: subversion: When updating a repository, please tell from which revision we update
Am Dienstag, den 04.02.2014, 23:37 -0600 schrieb Peter Samuelson: What would you expect the software to say in a mixed-rev wc? [Fabian Greffrath] I don't know, I have never worked with such a repository (and my patch only addresses the simple single-rev wc case). I doubt that. Mixed-rev working copies are the common case, not the exception. Almost every time you run 'svn commit', you get a mixed-rev wc. The files you commit are updated to the revision you committed, while the rest of the wc is not. To understand why this happens, consider 2 facts: - You are permitted to commit from an out-of-date wc, so long as the specific files you are committing are up to date; - 'svn commit' does not automatically run 'svn update'. What does it say which revision it updated to in a mixed-rev wc? 'svn update' always updates to a single revision (HEAD by default, or you can specify a revision with -r), so it prints that single revision. (Well, except for externals, but those are handled separately, as though you were running 'svn update' individually for each external.) Of course you can update just a subset of the wc (e.g., 'svn update foo.txt'), to create a mixed-rev wc, but 'update' itself still only has a single target revision to report. Peter -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#737614: subversion: When updating a repository, please tell from which revision we update
Package: subversion Version: 1.7.14-1+b1 Severity: wishlist Tags: patch Hi, when updating a repository, svn tells me to which revision it has been updated, but not from which revision. I have attached an untested draft patch that is expected to do exact this. Please consider applying it to the Debian package or forwarding it upstream. Thank you! - Fabian -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (900, 'unstable'), (800, 'experimental'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages subversion depends on: ii libapr1 1.5.0-1 ii libc6 2.17-97 ii libsasl2-2 2.1.25.dfsg1-17 ii libsvn1 1.7.14-1+b1 subversion recommends no packages. Versions of packages subversion suggests: ii db5.1-util5.1.29-6 ii patch 2.7.1-4 pn subversion-tools none -- no debconf information diff --git a/subversion/svn/notify.c b/home/greffrath/notify.c index 6498fb1..7146b27 100644 --- a/subversion/svn/notify.c +++ b/home/greffrath/notify.c @@ -740,9 +740,9 @@ notify(void *baton, const svn_wc_notify_t *n, apr_pool_t *pool) nb-received_some_change = FALSE; if ((err = svn_cmdline_printf (pool, nb-in_external - ? _(Updated external to revision %ld.\n) - : _(Updated to revision %ld.\n), - n-revision))) + ? _(Updated external to revision %ld (from %ld).\n) + : _(Updated to revision %ld (from %ld).\n), + n-revision, n-old_revision))) goto print_error; } else
