Bug#783904: dh-linktree: fails on invalid actions
On Fri, 01 May 2015, Dmitry Smirnov wrote: Actually it makes sense but then I'd prefer to have an equivalent of dh_install's --fail-missing (or the opposite) to have more flexibility in controlling this behaviour. Then it should be something like --ignore-unknown-actions and still fail by default. I'm not sure it really brings anything until you have a concrete use case of a possible usage extension of the .linktree file... Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#783904: dh-linktree: fails on invalid actions
Package: dh-linktree
Version: 0.4
Severity: wishlist
Tags: patch
I think it would be better if dh-linktree would not fail on invaid actions.
dh-linktree functionality may be extended to support new experimental actions
or additional actions may be used by some hypothetical alternative tools that
understand .linktree format.
Perhaps it could be useful to warn about unknown actions but continue to
process known ones. The change is trivial:
--- a/dh_linktree
+++ b/dh_linktree
@@ -176,9 +176,9 @@
while (@srclinks) {
my $action=shift @srclinks;
my $src=File::Spec-canonpath(shift @srclinks);
my $dest=File::Spec-canonpath(shift @srclinks);
- error(invalid action '$action')
+ warning(invalid action '$action')
if $action !~ /^(embed|replace|deduplicate)$/;
if (! -l /$src and -d _) {
find(sub {
return if -d and ! -l;
Thank you.
--
Cheers,
Dmitry Smirnov
GPG key : 4096R/53968D1B
---
You have enemies? Good. That means you've stood up for something,
sometime in your life.
-- Victor Hugo, Villemain, 1845
(often misattributed to Winston Churchill)
signature.asc
Description: This is a digitally signed message part.
Bug#783904: dh-linktree: fails on invalid actions
Control: tag -1 + wontfix Hi, On Fri, 01 May 2015, Dmitry Smirnov wrote: I think it would be better if dh-linktree would not fail on invaid actions. I don't agree. If the tool is not able to do what the user is requesting then it should fail and not just warn. Otherwise you might get a build that is not working... Thus I believe this bug should eventually be closed. I'm just tagging it wontfix for now so that you and other have a second chance to convince me. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#783904: dh-linktree: fails on invalid actions
On Fri, 1 May 2015 14:20:45 Raphael Hertzog wrote: If the tool is not able to do what the user is requesting then it should fail and not just warn. Otherwise you might get a build that is not working... Actually it makes sense but then I'd prefer to have an equivalent of dh_install's --fail-missing (or the opposite) to have more flexibility in controlling this behaviour. Thus I believe this bug should eventually be closed. I'm just tagging it wontfix for now so that you and other have a second chance to convince me. Very nice, thanks. :) -- Regards, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
