Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

On Sat, Mar 12, 2016 at 02:15:14AM +0100, gregor herrmann wrote:
> Thanks for all your work, that's really exciting, and I'm happy to
> sponsor this upload.

Yay \o/

> The order of the paragraphs is a bit unusual; normally the "Files"
> sections come before the "License" sections.

Fixed.

> Cool. - I just think that the newsbeuter-dbg transition package
> should depend on newsbeuter-dbgsym instead of newsbeuter. (Or you can
> just drop it; I see the point but so far I haven't seen any other
> transition packages for debugging symbols; but it's fine for me to
> keep it.)

I'm going to keep it for now, fixed the dependency.

> And in the future, modernizing d/rules would be nice.

I haven't messed around with automatic dh that much yet, I'll try to have that
in the next revision.

-- 
Best Regards,
Nikos Tsipinakis

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[gregor herrmann]

Control: owner -1 !
Control: tag -1 + moreinfo

On Fri, 11 Mar 2016 23:34:06 +0200, Nikos Tsipinakis wrote:

Thanks for all your work, that's really exciting, and I'm happy to
sponsor this upload.

> On Fri, Mar 11, 2016 at 12:49:38AM +0100, gregor herrmann wrote:
> > Will take a closer look tomorrow; a first look shows that the package
> > might profit from some modernization (d/copyright in Copyright Format
> > 1.0;
> Done.

The order of the paragraphs is a bit unusual; normally the "Files"
sections come before the "License" sections.
 
> > dh(1) in debian/rules; migration to new dbgsym packages (cf.
> > dh_strip(1)'s --dbgsym-migration)), etc.).
> Done.

Cool. - I just think that the newsbeuter-dbg transition package
should depend on newsbeuter-dbgsym instead of newsbeuter. (Or you can
just drop it; I see the point but so far I haven't seen any other
transition packages for debugging symbols; but it's fine for me to
keep it.)
 
> > I: newsbeuter: spelling-error-in-binary usr/bin/newsbeuter occured occurred
> Sneaked this one in the translation-fix patch.

Nice :)
 
> > I: newsbeuter: hardening-no-fortify-functions usr/bin/newsbeuter
> > I: newsbeuter: hardening-no-fortify-functions usr/bin/podbeuter
> Fixed.

Excellent!
 
So alltogether there are no real blockers for me to upload this
version; I'd just like to wait for you on a decision about the
newsbeuter-dbg package, and if you want to keep it, to change the
dependency to newsbeuter-dbgsym.

A little reformatting of d/copyright would be nice but this is just
aesthetical. And in the future, modernizing d/rules would be nice.


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Flying Pickets: Space Oddity


signature.asc
Description: Digital Signature

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

On Fri, Mar 11, 2016 at 12:49:38AM +0100, gregor herrmann wrote:
> Will take a closer look tomorrow; a first look shows that the package
> might profit from some modernization (d/copyright in Copyright Format
> 1.0;

Done.

> dh(1) in debian/rules; migration to new dbgsym packages (cf.
> dh_strip(1)'s --dbgsym-migration)), etc.).

Done.

> lintian and blhc report:
> 
> P: newsbeuter source: no-dep5-copyright

Done.

> I: newsbeuter: spelling-error-in-binary usr/bin/newsbeuter occured occurred

Sneaked this one in the translation-fix patch.

> I: newsbeuter: hardening-no-fortify-functions usr/bin/newsbeuter
> I: newsbeuter: hardening-no-fortify-functions usr/bin/podbeuter

Fixed.

> W-dpkg-buildflags-missing|CPPFLAGS 59 (of 59) missing|

Fixed.


-- 
Best Regards,
Nikos Tsipinakis

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[gregor herrmann]

On Thu, 10 Mar 2016 16:48:39 +0200, Nikos Tsipinakis wrote:

> > The highlighting feature seems to be broken (no idea if this is a
> > problem in newsbeuter or ncurses; I haven't retried to rebuild 2.8-2
> > to check). Too show what I mean: I have in my ~/.newsbeuter/config
> Apparently this issue was already reported and fixed upstream. Added a patch 
> and it should work as intended now.

/me tries the new version from mentors

Yay \o/
Excellent, works again. Thank you!


So I guess I should consider sponsoring this upload :)

Will take a closer look tomorrow; a first look shows that the package
might profit from some modernization (d/copyright in Copyright Format
1.0; dh(1) in debian/rules; migration to new dbgsym packages (cf.
dh_strip(1)'s --dbgsym-migration)), etc.).

lintian and blhc report:

P: newsbeuter source: no-dep5-copyright
I: newsbeuter: spelling-error-in-binary usr/bin/newsbeuter occured occurred
I: newsbeuter: hardening-no-fortify-functions usr/bin/newsbeuter
I: newsbeuter: hardening-no-fortify-functions usr/bin/podbeuter
I: newsbeuter: possible-documentation-but-no-doc-base-registration

W-dpkg-buildflags-missing|CPPFLAGS 59 (of 59) missing|


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: La Tresca: Caravanserraglio


signature.asc
Description: Digital Signature

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

On Wed, Mar 09, 2016 at 11:25:01PM +0100, gregor herrmann wrote:
> Thanks for your interest in newsbeuter; I like it and use it daily :)
> And I was looking forward to a version which needs less memory than
> Iceweasel; but for me 2.9 has a massive problem:
> 
> The highlighting feature seems to be broken (no idea if this is a
> problem in newsbeuter or ncurses; I haven't retried to rebuild 2.8-2
> to check). Too show what I mean: I have in my ~/.newsbeuter/config

Apparently this issue was already reported and fixed upstream. Added a patch 
and it should work as intended now.

-- 
Best Regards,
Nikos Tsipinakis

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[gregor herrmann]

On Sun, 06 Mar 2016 19:48:37 +0200, Nikos Tsipinakis wrote:

> I am looking for a sponsor for my package "newsbeuter"
> 
> * Package name: newsbeuter
>   Version : 2.9-1
>   Upstream Author : Andreas Krennmair 
> * URL : https://github.com/akrennmair/newsbeuter
> * License : MIT
>   Section : net
> 
> Alternatively, one can download the package with dget using this command:
> 
>dget -x 
> http://mentors.debian.net/debian/pool/main/n/newsbeuter/newsbeuter_2.9-1.dsc

Thanks for your interest in newsbeuter; I like it and use it daily :)
And I was looking forward to a version which needs less memory than
Iceweasel; but for me 2.9 has a massive problem:

The highlighting feature seems to be broken (no idea if this is a
problem in newsbeuter or ncurses; I haven't retried to rebuild 2.8-2
to check). Too show what I mean: I have in my ~/.newsbeuter/config

#v+
# colours
highlight article "^Feed:.+$" yellow black bold
highlight article "^Title:.+$" red black bold
highlight article "^Author:.+$" yellow black bold
highlight article "^Link: " white black bold
highlight article "^Date:.+$" yellow black bold

highlight article "https?://[^][ $)\"]+" cyan black underline
highlight article "?" cyan black
#v-

And the result is --> see attachments.

Maybe you could look into this issue and/or discuss with ak?


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Funny van Dannen: Junge Christen


signature.asc
Description: Digital Signature

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

On Tue, 8 Mar 2016 17:53:01 +0100 Jakub Wilk  wrote:
> You can (and should) forward the bugs upstream.
> You can mark the incorrectly translated messages as "fuzzy", so that 
> the translations won't be used.

I forwarded the issue upstream, and patched the erroneous translations.

To summarize the last few mails the current changelog is:

  * New upstream release. (Closes: #776728)
  * Fix segfault when downloading podcasts
  * Patch erroneous Portuguese, Ukrainian and Chinese translations.
  * Bumped standards to 3.9.7
  * Updated watch file.
  * Removed upstream README from docs.
  * New maintainer. (Closes: #800752)

-- 
Best Regards,
Nikos Tsipinakis

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Jakub Wilk]

* Nikos Tsipinakis , 2016-03-08, 18:22:

E: po/uk.po: c-format-string-missing-arguments msgid "`%s' is not a valid regular 
expression: %s": 1 (msgstr) < 2 (msgid)
E: po/zh.po: c-format-string-argument-type-mismatch msgid "Error while processing 
command `%s' (%s line %u): %s": int * (msgstr) != unsigned int (msgid)
E: po/zh.po: c-format-string-missing-arguments msgid "Error: couldn't mark feed read: 
%s": 0 (msgstr) < 1 (msgid)

(plus some other, less severe problems)


Unfortunately most of these errors are left for the translators to fix 
as they are related to the translated message format, nothing I can do 
since I do not know any of the languages.


You can (and should) forward the bugs upstream.
You can mark the incorrectly translated messages as "fuzzy", so that 
the translations won't be used.


This one is particularly concerning:

#, c-format
msgid "Error while processing command `%s' (%s line %u): %s"
msgstr "当处理命令`%s'(%s 第 %n 行)时出错: %s"

because the use of %n will inevitably cause crashes.

--
Jakub Wilk

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

Hello Jakub,

On Tue, 8 Mar 2016 14:53:58 +0100 Jakub Wilk  wrote:
> Speaking of PO files, i18nspector finds some interesting bugs in them:
> 
> E: po/uk.po: c-format-string-missing-arguments msgid "`%s' is not a valid 
> regular expression: %s": 1 (msgstr) < 2 (msgid)
> E: po/zh.po: c-format-string-argument-type-mismatch msgid "Error while 
> processing command `%s' (%s line %u): %s": int * (msgstr) != unsigned int 
> (msgid)
> E: po/zh.po: c-format-string-missing-arguments msgid "Error: couldn't mark 
> feed read: %s": 0 (msgstr) < 1 (msgid)
> 
> (plus some other, less severe problems)

Unfortunately most of these errors are left for the translators to fix as they 
are
related to the translated message format, nothing I can do since I do not know
any of the languages.

Best Regards,
Nikos Tsipinakis

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

Hello Dmitry,

On Tue, Mar 08, 2016 at 12:01:28PM +0300, Dmitry Bogatov wrote:
> [NO DD, can't sponsor]

Input is always appreciated :)

> There is nice tool `check-all-the-things'. It reveals
> 
>  * loads of spelling errors in po/

The 'spelling errors' are mostly ispell trying to correct non-english
translations i.e.

"./newsbeuter-2.9/po/es.po:438: Autor  ==> Author"

es.po:436-8
#: src/controller.cpp:1355 src/itemview_formaction.cpp:90
msgid "Author: "
msgstr "Autor: "

Thats clearly a translation that ispell is trying to parse as english. There
are a few minor spelling mistakes in english but very few if any are in
user-viewable files(docs) in my opinion not worth making a patch for them, they
can easily be patched upstream and pulled down at the next release.

>  * wrong formatting of your email (email is formatted this way: Name 
> ,
>your formatting in patches/podbeuter-segfault-fix misses <> symbols)

Author: Nikos Tsipinakis 

Formatting seems correct to me as it is?

>  * installation instruction (README) should not find way into binary package

Agreed, README has been removed from the docs, package re-uploaded.

Best Regards,
Nikos Tsipinakis

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Jakub Wilk]

* Dmitry Bogatov , 2016-03-08, 12:01:

[NO DD, can't sponsor]


[DD, but won't sponsor either]


There is nice tool `check-all-the-things'. It reveals


check-all-the-things output greatly depends on which packages you have 
installed, so it would be helpful to say which underlying tools found 
the problems...



* loads of spelling errors in po/


check-all-the-things supports multiple spell-checker and none of them 
are IMO helpful for automated spell-checking all PO files:


* spellintian and codespell assume that the checked text is English; so 
they will found misspelling in the original messages, which should be 
fix elsewhere; and false positives in the translated messages.


* POFileSpell flags every single word in the translated messages if 
there's no dictionary installed for the target language. (Even if you had 
the appropriate dictionaries installed, you probably don't know most of 
the languages enough to discern between true and false positives...)



Speaking of PO files, i18nspector finds some interesting bugs in them:

E: po/uk.po: c-format-string-missing-arguments msgid "`%s' is not a valid regular 
expression: %s": 1 (msgstr) < 2 (msgid)
E: po/zh.po: c-format-string-argument-type-mismatch msgid "Error while processing 
command `%s' (%s line %u): %s": int * (msgstr) != unsigned int (msgid)
E: po/zh.po: c-format-string-missing-arguments msgid "Error: couldn't mark feed read: 
%s": 0 (msgstr) < 1 (msgid)

(plus some other, less severe problems)

--
Jakub Wilk

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Dmitry Bogatov]

[2016-03-06 19:48] Nikos Tsipinakis 
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "newsbeuter"
> 
> * Package name: newsbeuter
>   Version : 2.9-1
>   Upstream Author : Andreas Krennmair 
> * URL : https://github.com/akrennmair/newsbeuter
> * License : MIT
>   Section : net
>
> It builds those binary packages:
>
>newsbeuter - text mode rss feed reader with podcast support
>newsbeuter-dbg - debugging symbols for newsbeuter

[NO DD, can't sponsor]

There is nice tool `check-all-the-things'. It reveals

 * loads of spelling errors in po/
 * wrong formatting of your email (email is formatted this way: Name 
,
   your formatting in patches/podbeuter-segfault-fix misses <> symbols)
 * installation instruction (README) should not find way into binary package

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]

[Nikos Tsipinakis]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "newsbeuter"

* Package name: newsbeuter
  Version : 2.9-1
  Upstream Author : Andreas Krennmair 
* URL : https://github.com/akrennmair/newsbeuter
* License : MIT
  Section : net

It builds those binary packages:

   newsbeuter - text mode rss feed reader with podcast support
   newsbeuter-dbg - debugging symbols for newsbeuter

To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/newsbeuter


Alternatively, one can download the package with dget using this command:

   dget -x 
http://mentors.debian.net/debian/pool/main/n/newsbeuter/newsbeuter_2.9-1.dsc

Changes since the last upload:

  * New upstream release. (Closes: #776728)
  * Fix sefault when downloading podcasts.
  * Bumped standards to 3.9.7
  * Updated watch file.
  * New maintainer.

Best Regards,
 Nikos Tsipinakis