Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
On Thu, May 11, 2017 at 10:39:22AM -0400, Nicholas D Steeves wrote: > I think src:writegood-mode is ready to upload. Since Antoine is going > to be busy for a while would you please consider sponsoring this one? I hope to take a look, but it will probably have to wait until the end of next week -- I'm changing continents for the summer. On Thu, May 11, 2017 at 10:46:47AM -0400, Nicholas D Steeves wrote: > P.S. I had already filed RFS Bug #861699. For future reference, which > is correct? > > 1) I. someone files an RFP, II. one takes ownership and retitles it to an > ITP, III. if one then needs a sponsor one drops ownership and retitles to > an RFS ... [ITP] > > 2) I and II remain the same, but instead of III, file a new RFS. (2). The RFP/ITP and RFS are completely separate. The RFS should block the ITP. -- Sean Whitton signature.asc Description: PGP signature
Bug#861125: P.S. Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
P.S. I had already filed RFS Bug #861699. For future reference, which is correct? 1) I. someone files an RFP, II. one takes ownership and retitles it to an ITP, III. if one then needs a sponsor one drops ownership and retitles to an RFS ... [ITP] 2) I and II remain the same, but instead of III, file a new RFS.
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
On Thu, Apr 27, 2017 at 04:04:17PM -0700, Sean Whitton wrote: > On Thu, Apr 27, 2017 at 05:23:45PM -0400, Nicholas D Steeves wrote: > > Thank you for mentoring me to err on the side of caution :-) As a > > rule, for Debian, is it most correct that the embedded version in the > > headers be patched to reflect x.y.z tag, even if upstream only updates > > the header version for x.y? Also, to make this stranger yet, the > > MELPA uses date-based snapshot versioning. eg: 20160802.1405 > > > > https://melpa.org/#/writegood-mode > > It shouldn't be patched to add a minor version. This is because other > ELPA package authors won't include this in their versioned > dependencies. > > > I fixed this as a team upload, and pushed the changes. > > The package is also available here: > > > > https://mentors.debian.net/package/helm > > dget -x https://mentors.debian.net/debian/pool/main/h/helm/helm_2.5.0-2.dsc > > > > I only tested that it built and installed without error because I'm > > not familiar with helm. > > Thanks for the fix -- though this would need to go to experimental due > to the freeze. Hi Sean, You're welcome, and thank you for the assistance. 'Hope you're enjoying settling into your new home :-) I think src:writegood-mode is ready to upload. Since Antoine is going to be busy for a while would you please consider sponsoring this one? It builds these binary packages: elpa-writegood-mode - Minor mode for Emacs to improve English writing To access further information about this package, please visit the following URL: https://mentors.debian.net/package/writegood-mode Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc Also available here: git clone ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git Sincerely, Nicholas signature.asc Description: Digital signature
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
On Thu, Apr 27, 2017 at 05:23:45PM -0400, Nicholas D Steeves wrote: > Thank you for mentoring me to err on the side of caution :-) As a > rule, for Debian, is it most correct that the embedded version in the > headers be patched to reflect x.y.z tag, even if upstream only updates > the header version for x.y? Also, to make this stranger yet, the > MELPA uses date-based snapshot versioning. eg: 20160802.1405 > > https://melpa.org/#/writegood-mode It shouldn't be patched to add a minor version. This is because other ELPA package authors won't include this in their versioned dependencies. > I fixed this as a team upload, and pushed the changes. > The package is also available here: > > https://mentors.debian.net/package/helm > dget -x https://mentors.debian.net/debian/pool/main/h/helm/helm_2.5.0-2.dsc > > I only tested that it built and installed without error because I'm > not familiar with helm. Thanks for the fix -- though this would need to go to experimental due to the freeze. -- Sean Whitton signature.asc Description: PGP signature
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Hi Sean, On Thu, Apr 27, 2017 at 01:36:10PM -0700, Sean Whitton wrote: > Hello Nicholas, > > On Wed, Apr 26, 2017 at 09:22:23PM -0400, Nicholas Steeves wrote: > > The questions we need help with are at 2. and especially 4. > > Okay -- I'll answer those. > > > > 2. that version patch - really necessary? if upstream screwed up their > > > versioning, it's kind of their problem no? since it's just a > > > cosmetic change, I would avoid it, personnally. > > > > Is it just a cosmetic change? > > Nicholas is right. It's not just a cosmetic change. It's important > that ELPA package versions match Debian package versions. Thank you for mentoring me to err on the side of caution :-) As a rule, for Debian, is it most correct that the embedded version in the headers be patched to reflect x.y.z tag, even if upstream only updates the header version for x.y? Also, to make this stranger yet, the MELPA uses date-based snapshot versioning. eg: 20160802.1405 https://melpa.org/#/writegood-mode > In addition to enabling users to mix package.el packages and Debian > elpa-* packages, it ensures that Emacs has the right information to tell > whether versioned ELPA dependencies are satisfied. Otherwise it can > refuse to load packages/try to download new versions from MELPA. > > > > 4. picking a random elpa package (elpa-helm), i notice it depends on > > > "emacs" while yours depend on "emacs-common" - why? and why the > > > versioned dependencies? > > > > > > > > > https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control > > > > My best guess is it's the difference between a package converted to > > elpa vs a package created with dh-make-elpa, and I Sean has reasons > > for generating versioned dependencies by default. This is actually > > one of the reasons I was paranoid about 2. ;-) > > That's a bug in elpa-helm. It should be emacsen-common. See the Debian > Emacs policy. I fixed this as a team upload, and pushed the changes. The package is also available here: https://mentors.debian.net/package/helm dget -x https://mentors.debian.net/debian/pool/main/h/helm/helm_2.5.0-2.dsc I only tested that it built and installed without error because I'm not familiar with helm. Cheers, Nicholas signature.asc Description: Digital signature
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Hello Nicholas, On Wed, Apr 26, 2017 at 09:22:23PM -0400, Nicholas Steeves wrote: > The questions we need help with are at 2. and especially 4. Okay -- I'll answer those. > > 2. that version patch - really necessary? if upstream screwed up their > > versioning, it's kind of their problem no? since it's just a > > cosmetic change, I would avoid it, personnally. > > Is it just a cosmetic change? Nicholas is right. It's not just a cosmetic change. It's important that ELPA package versions match Debian package versions. In addition to enabling users to mix package.el packages and Debian elpa-* packages, it ensures that Emacs has the right information to tell whether versioned ELPA dependencies are satisfied. Otherwise it can refuse to load packages/try to download new versions from MELPA. > > 4. picking a random elpa package (elpa-helm), i notice it depends on > > "emacs" while yours depend on "emacs-common" - why? and why the > > versioned dependencies? > > > > > > https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control > > My best guess is it's the difference between a package converted to > elpa vs a package created with dh-make-elpa, and I Sean has reasons > for generating versioned dependencies by default. This is actually > one of the reasons I was paranoid about 2. ;-) That's a bug in elpa-helm. It should be emacsen-common. See the Debian Emacs policy. -- Sean Whitton signature.asc Description: PGP signature
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Hi! I unfortunately won't have time to review this further - but don't block on anything from me, all is good if spwhitton goes it. ;) And i'm fine with licensing the description as you see fit. A. -- Ce que les siècles des grands abatoirs nous aura appris Devrait être inscrit au fond de toutes les écoles; Voici l'homme: le destructeur des mondes est arrivé. - [no one is innocent]
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Hi Antoine and Sean, If you don't know each other yet, I'll just say that you two of the most friendly and patient people I've met through Debian. Sean, I've CC'ed you because Antoine expressed interest in joining the pkg-emacsen team, and he asked me a couple of questions about dh-elpa and dh-make-elpa that I couldn't answer. I'd be happy to work your replies into a documentation patch, or a wiki page if you're busy. The questions we need help with are at 2. and especially 4. On 25 April 2017 at 19:07, Antoine Beaupré wrote: > On 2017-04-25 18:27:11, Nicholas D Steeves wrote: >> On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote: >>> On 2017-04-25 11:17:28, Nicholas D Steeves wrote: >>> > >>> > It will take some time to learn how this one works, but another reason >>> > I'm interested in maintaining writegood-mode is I'm certain I can >>> > contribute to it. Preliminary packaging is here: >>> > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git >>> >>> Excellent. Same remark than writeroom about uploading to >>> mentors.debian.net. :) But it's great you pushed into git! >>> >>> (It's just that I'm lazy: mentors.debian.net shows lintian output for >>> me... ;)) >> >> I've uploaded a package for review. Since I'm still a DM, would you >> please sponsor it if it looks good? I'd be happy to add you to >> uploaders, if you'd like. >> >> https://mentors.debian.net/package/writegood-mode >> dget -x >> https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc > > thanks! > > here's a short review. > > 1. the package's description doesn't mention "emacs" or "english" - in > the original RFP, i used this instead: > > Description : Minor mode for Emacs to improve English writing > This is a minor mode to aid in finding common writing > problems. Matt Might’s weaselwords scripts inspired this mode. > . > It highlights text based on a set of weasel-words, passive-voice > and duplicate words. My apologies, I failed to scrutinise the differences between the description you provided and the one dh-make-elpa generated. I've merged your copy and credited you in d/copyright. D/* uses the same license as upstream package, which you said was your preference in another thread, so I assume this is ok. By the way, dh-make-elpa and gbp make it really easy to do these packages. From the manpage (plus addition of the gbp repo creation) % git clone -o upstream https://foo.org/foo.git % cd foo % git reset --hard 1.0.0# package latest stable release % dh-make-elpa --pkg-emacsen % git add debian && git commit -m "initial Debianisation" % git deborig % dpkg-buildpackage -us -uc % gbp create-remote-repo --remote-url-pattern=ssh://git.debian.org/git/pkg-emacsen/pkg/foo.git > 2. that version patch - really necessary? if upstream screwed up their > versioning, it's kind of their problem no? since it's just a > cosmetic change, I would avoid it, personnally. Is it just a cosmetic change? I chose to be cautious out of ignorance of how elpa/MELPA works, because I wonder if it uses this versioning to decide whether to download local-to-$USER updates. We don't recommend that users mix packaging systems like this, of course, and I guess it could be argued that if the system provided version (unpatched is 2.1) is higher than the upstream one (2.0.1), then MELPA would refuse to download locale-to-$USER updates until upstream tagged 2.1.0. I plan to drop a similar patch for writeroom-mode, because the convention of most of these upstreams seems to be to only increment major and minor versions but not patch-level versions. > 3. if you still think it's necessary, explain *why* it is there in the > changelog, not just "it's there". :) same in the patch: not "what" > but "why" in commitlogs... " * Add filename.patch for maximal correctness and just to be extra safe" didn't seem like a strong enough case, and I prefer to do the work when I have time and revert if unnecessary. If it's truly just cosmetic I'll drop it. 'good for some gbp pq practice and another lesson in how *self describing file names are not sufficient for debian changelogs* ;-) > 4. picking a random elpa package (elpa-helm), i notice it depends on > "emacs" while yours depend on "emacs-common" - why? and why the > versioned dependencies? > > > https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control My best guess is it's the difference between a package converted to elpa vs a package created with dh-make-elpa, and I Sean has reasons for generating versioned dependencies by default. This is actually one of the reasons I was paranoid about 2. ;-) > I'm not very familiar with "elpa" packages, so I don't know if it works > or not - did you actually test this? :) Yes, and I was surprised to see teal squiggly lines appear...for passive voice :-o Also, at the moment, the versioned dependencies for sid can be satisfie
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
On 2017-04-25 18:27:11, Nicholas D Steeves wrote: > On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote: >> On 2017-04-25 11:17:28, Nicholas D Steeves wrote: >> > >> > It will take some time to learn how this one works, but another reason >> > I'm interested in maintaining writegood-mode is I'm certain I can >> > contribute to it. Preliminary packaging is here: >> > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git >> >> Excellent. Same remark than writeroom about uploading to >> mentors.debian.net. :) But it's great you pushed into git! >> >> (It's just that I'm lazy: mentors.debian.net shows lintian output for >> me... ;)) > > I've uploaded a package for review. Since I'm still a DM, would you > please sponsor it if it looks good? I'd be happy to add you to > uploaders, if you'd like. > > https://mentors.debian.net/package/writegood-mode > dget -x > https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc thanks! here's a short review. 1. the package's description doesn't mention "emacs" or "english" - in the original RFP, i used this instead: Description : Minor mode for Emacs to improve English writing This is a minor mode to aid in finding common writing problems. Matt Might’s weaselwords scripts inspired this mode. . It highlights text based on a set of weasel-words, passive-voice and duplicate words. 2. that version patch - really necessary? if upstream screwed up their versioning, it's kind of their problem no? since it's just a cosmetic change, I would avoid it, personnally. 3. if you still think it's necessary, explain *why* it is there in the changelog, not just "it's there". :) same in the patch: not "what" but "why" in commitlogs... 4. picking a random elpa package (elpa-helm), i notice it depends on "emacs" while yours depend on "emacs-common" - why? and why the versioned dependencies? https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control I'm not very familiar with "elpa" packages, so I don't know if it works or not - did you actually test this? :) Thanks! A. -- Never be deceived that the rich will allow you to vote away their wealth. - Lucy Parsons
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote: > On 2017-04-25 11:17:28, Nicholas D Steeves wrote: > > > > It will take some time to learn how this one works, but another reason > > I'm interested in maintaining writegood-mode is I'm certain I can > > contribute to it. Preliminary packaging is here: > > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git > > Excellent. Same remark than writeroom about uploading to > mentors.debian.net. :) But it's great you pushed into git! > > (It's just that I'm lazy: mentors.debian.net shows lintian output for > me... ;)) I've uploaded a package for review. Since I'm still a DM, would you please sponsor it if it looks good? I'd be happy to add you to uploaders, if you'd like. https://mentors.debian.net/package/writegood-mode dget -x https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc > > Oh, I failed to ask in the writeroom RFP thread: Do you like the idea > > of teaming up for that mini project (or a similar project). > > Sure, I can try - but I don't have much time unfortunately. I would > rather see the other emacsen people join in here - I'm not even part of > that team yet! I'd even appreciate occasional mockups/screenshots, brainstorming, or wish lists, because I find they're good for staying motivated and avoiding the "questions have more than one answer" pitfall when implementing solutions ;-) Cheers, Nicholas
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
On 2017-04-25 11:17:28, Nicholas D Steeves wrote: > control: tags -1 pending > > Hi Antoine, > > On Tue, Apr 25, 2017 at 08:06:50AM -0400, Antoine Beaupré wrote: >> On 2017-04-24 20:46:13, Nicholas D Steeves wrote: >> >> > Y-a-t'il une version française? >> > C'est quelque dont j'apprécierais énormément! >> >> This is for english, and is rather simple, as I mentioned. A french >> version would require a completely different package, or a severe >> reconfiguration of this one... I looked into Grammalecte here: >> >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860579 >> >> .. but it's not quite ready to be packaged just yet... > > It will take some time to learn how this one works, but another reason > I'm interested in maintaining writegood-mode is I'm certain I can > contribute to it. Preliminary packaging is here: > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git Excellent. Same remark than writeroom about uploading to mentors.debian.net. :) But it's great you pushed into git! (It's just that I'm lazy: mentors.debian.net shows lintian output for me... ;)) > Oh, I failed to ask in the writeroom RFP thread: Do you like the idea > of teaming up for that mini project (or a similar project). Sure, I can try - but I don't have much time unfortunately. I would rather see the other emacsen people join in here - I'm not even part of that team yet! > I can't wait until Grammalecte is ready! :-) How does it compare to a > famous business wordprocessor's grammar check, or to bonpatron? I don't quite know yet. A. -- Code is law. - Lawrence Lessig
Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
control: tags -1 pending Hi Antoine, On Tue, Apr 25, 2017 at 08:06:50AM -0400, Antoine Beaupré wrote: > On 2017-04-24 20:46:13, Nicholas D Steeves wrote: > > > Y-a-t'il une version française? > > C'est quelque dont j'apprécierais énormément! > > This is for english, and is rather simple, as I mentioned. A french > version would require a completely different package, or a severe > reconfiguration of this one... I looked into Grammalecte here: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860579 > > .. but it's not quite ready to be packaged just yet... It will take some time to learn how this one works, but another reason I'm interested in maintaining writegood-mode is I'm certain I can contribute to it. Preliminary packaging is here: ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git Oh, I failed to ask in the writeroom RFP thread: Do you like the idea of teaming up for that mini project (or a similar project). I can't wait until Grammalecte is ready! :-) How does it compare to a famous business wordprocessor's grammar check, or to bonpatron? Cheers, Nicholas
