Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Fri, 23 Mar 2018 15:33:38 +0100, gregor herrmann wrote:
> I tried the same for Vcs-Git and got interesting errors, but they
> also appear with Vcs-Browser:
>
> If I add
>
> [ 'Vcs-Browser', 'http://anonscm.debian.org/cgit/foo-team/bar.git','',
> $expected_warn ],
>
> to the @vcs_tests array in t/dependency-check.t, I get
>
> # Failed test 'fixed Vcs-Browser URL'
> # at t/dependency-check.t line 478.
> # got:
> 'https://salsa.debian.org/perl-team/modules/packages/libdist-zilla-plugins-cjm-perl'
> # expected: ''
>
> Looks like the "old" value is still there somehow?
I've pushed some commits re Vcs-Git and a test for the fixup
mechanism to a branch gregoa/nomorealioth.
Unfortunately the tests in t/dependency-check.t still fails, as
decribed above.
I guess we also need a change for the other Vcs-* fields. I've played
a bit with ideas like
@@ -437,13 +437,11 @@ The information is meant to be useful for a user
knowledgeable in the given Vers
'summary' => 'URL of the VCS repository',
'type' => 'leaf',
'value_type' => 'uniline',
-'warn_unless' => {
- 'debian-uri' => {
-'code' => '!defined $_ or ! /debian.org/ or
m{^https?://anonscm.debian.org/arch} ;',
-'fix' =>
's!https?://[\\w\\.-]+/(arch/)*!https://anonscm.debian.org/arch/!;',
-'msg' => 'URL is not the canonical one for repositories hosted on
Debian infrastructure.'
+'warn_if_match' => {
+ '(?:alioth|arch|anonscm)\.debian\.org' => {
+'msg' => 'URL points to old Debian infrastructure.'
}
-}
+},
},
'Vcs-Bzr',
{
but maybe we need to unset the value as well with a "fix => $_ =
undef" here?
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Andrew Lloyd Webber & Tim Rice: Gethsemane (I Only Want To Say)
signature.asc
Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Fri, 23 Mar 2018 13:35:22 +0100, domi.dum...@free.fr wrote: > > Good news: I've added the computed values for Debian-Med and > > Debian-Science in git. > Thanks :-) That was the easy part :) > > Bad news: That's not enough; AFAICS cme fix doesn't change existing > > values, and besides that anonscm and friends are still considered > > valid. > The "compute" specification is used as a default value. I.e. an old value > (even wrong) > is not replaced Right, that's what I found out as well. > > Even worse news: Trying to rip out anonscm and other alioth URLs is > > beyond my understanding of Config::Model, I can only trigger huge > > amounts of test failures. > > I'm afraid that's a case for Dominique alone ... > ok. I'll fix this. Thanks. And I saw your commit with $_ = undef. Nice :) I tried the same for Vcs-Git and got interesting errors, but they also appear with Vcs-Browser: If I add [ 'Vcs-Browser', 'http://anonscm.debian.org/cgit/foo-team/bar.git','', $expected_warn ], to the @vcs_tests array in t/dependency-check.t, I get # Failed test 'fixed Vcs-Browser URL' # at t/dependency-check.t line 478. # got: 'https://salsa.debian.org/perl-team/modules/packages/libdist-zilla-plugins-cjm-perl' # expected: '' Looks like the "old" value is still there somehow? Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Andrew Lloyd Webber & Tim Rice: Gethsemane (I Only Want To Say) signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Le 2018-03-23 00:30, gregor herrmann a écrit : Good news: I've added the computed values for Debian-Med and Debian-Science in git. Thanks :-) Bad news: That's not enough; AFAICS cme fix doesn't change existing values, and besides that anonscm and friends are still considered valid. The "compute" specification is used as a default value. I.e. an old value (even wrong) is not replaced Even worse news: Trying to rip out anonscm and other alioth URLs is beyond my understanding of Config::Model, I can only trigger huge amounts of test failures. I'm afraid that's a case for Dominique alone ... ok. I'll fix this. All the best
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Thu, 22 Mar 2018 17:04:06 +0100, Andreas Tille wrote: > > For debian med this looks pretty straight-forward: > > if: $maintainer =~ /debian-med-packaging/ > > then: https://salsa.debian.org/med-team/$pkgname.git > > > > Correct? > > I'm afraid there are two or three exceptions but most probably we need > to fix these exceptions manually since these are rather considered as > bugs in our VCS repositories. So yes, that's correct. Thanks. Good news: I've added the computed values for Debian-Med and Debian-Science in git. Bad news: That's not enough; AFAICS cme fix doesn't change existing values, and besides that anonscm and friends are still considered valid. Even worse news: Trying to rip out anonscm and other alioth URLs is beyond my understanding of Config::Model, I can only trigger huge amounts of test failures. I'm afraid that's a case for Dominique alone ... > > For the R team I'm not so sure. I looked at some packages, and 7 or 8 > > of 10 had > > $maintainer =~ debian-science-maintainers > > but I've also seen other values in Maintainers. > > Is there some unique value in debian/source to filter on? > > > > The URLs seem to be https://salsa.debian.org/r-pkg-team/$pkgname.git > > I think you could filter for > >( $pkgname =~ /^r-cran-.*/ || $pkgname =~ /^r-bioc-.*/ ) && Vcs-fields > "exists" > > I'm not sure about the latter. Dirk Eddelbüttel does not maintain his > packages in Vcs and I do not know his plans to do so. It might be > irrelevant since I doubt he is using cme. I'm CCing debian-r list for > review - may be Dirk can pronounce whether he considers it helpful if > cme would insert Vcs fields also for his packages. This would simplify > migrating his packages easily to Salsa by using cme in case he might > decide to do this. Ok, let's wait and see. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Die Tontauben: shine signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
I forgot if: $maintainer =~ /debian-science-maintainers@/ then: https://salsa.debian.org/science-team/$pkgname.git That is true for a large majority of Debian Science packages and will fail for a few packages in fenics (and may be two or three other subdirs). I have no idea whether we need to care for those and as far as I checked some examples these are converted anyway like Vcs-Git: https://salsa.debian.org/science-team/fenics/ufl.git Vcs-Browser: https://salsa.debian.org/science-team/fenics/ufl Kind regards Andreas. On Thu, Mar 22, 2018 at 05:04:06PM +0100, Andreas Tille wrote: > Hi Gregor, > > On Thu, Mar 22, 2018 at 04:37:02PM +0100, gregor herrmann wrote: > > > Currently we have for Vcs-Git: > > > > > > 'formula' => ' $maintainer =~ /pkg-perl/ > > > ? "https://salsa.debian.org/perl-team/modules/packages/$pkgname.git; > > > : $maintainer =~ /pkg-ruby-extras/ ? > > > "https://salsa.debian.org/ruby-team/$pkgname.git; > > > : $maintainer =~ /pkg-javascript/ ? > > > "https://salsa.debian.org/js-team/$pkgname.git; > > > :\'\' ;', > > > > > > (And the same for Vcs-Browser minus the trailing .git) > > > > > > So for the med-team and the r-pkg-team we would need a string for the > > > maintainer address, and the base git URL at salsa. > > > > This part is still open, and I'm happy to add the missing runes for > > med-team and r-pkg-team; I just need confirmation for the values. > > > > I took a quick look today: > > > > For debian med this looks pretty straight-forward: > > if: $maintainer =~ /debian-med-packaging/ > > then: https://salsa.debian.org/med-team/$pkgname.git > > > > Correct? > > I'm afraid there are two or three exceptions but most probably we need > to fix these exceptions manually since these are rather considered as > bugs in our VCS repositories. So yes, that's correct. > > > For the R team I'm not so sure. I looked at some packages, and 7 or 8 > > of 10 had > > $maintainer =~ debian-science-maintainers > > but I've also seen other values in Maintainers. > > Is there some unique value in debian/source to filter on? > > > > The URLs seem to be https://salsa.debian.org/r-pkg-team/$pkgname.git > > I think you could filter for > >( $pkgname =~ /^r-cran-.*/ || $pkgname =~ /^r-bioc-.*/ ) && Vcs-fields > "exists" > > I'm not sure about the latter. Dirk Eddelbüttel does not maintain his > packages in Vcs and I do not know his plans to do so. It might be > irrelevant since I doubt he is using cme. I'm CCing debian-r list for > review - may be Dirk can pronounce whether he considers it helpful if > cme would insert Vcs fields also for his packages. This would simplify > migrating his packages easily to Salsa by using cme in case he might > decide to do this. > > Kind regards > >Andreas. > > -- > http://fam-tille.de -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Hi Gregor, On Thu, Mar 22, 2018 at 04:37:02PM +0100, gregor herrmann wrote: > > Currently we have for Vcs-Git: > > > > 'formula' => ' $maintainer =~ /pkg-perl/ > > ? "https://salsa.debian.org/perl-team/modules/packages/$pkgname.git; > > : $maintainer =~ /pkg-ruby-extras/ ? > > "https://salsa.debian.org/ruby-team/$pkgname.git; > > : $maintainer =~ /pkg-javascript/ ? > > "https://salsa.debian.org/js-team/$pkgname.git; > > :\'\' ;', > > > > (And the same for Vcs-Browser minus the trailing .git) > > > > So for the med-team and the r-pkg-team we would need a string for the > > maintainer address, and the base git URL at salsa. > > This part is still open, and I'm happy to add the missing runes for > med-team and r-pkg-team; I just need confirmation for the values. > > I took a quick look today: > > For debian med this looks pretty straight-forward: > if: $maintainer =~ /debian-med-packaging/ > then: https://salsa.debian.org/med-team/$pkgname.git > > Correct? I'm afraid there are two or three exceptions but most probably we need to fix these exceptions manually since these are rather considered as bugs in our VCS repositories. So yes, that's correct. > For the R team I'm not so sure. I looked at some packages, and 7 or 8 > of 10 had > $maintainer =~ debian-science-maintainers > but I've also seen other values in Maintainers. > Is there some unique value in debian/source to filter on? > > The URLs seem to be https://salsa.debian.org/r-pkg-team/$pkgname.git I think you could filter for ( $pkgname =~ /^r-cran-.*/ || $pkgname =~ /^r-bioc-.*/ ) && Vcs-fields "exists" I'm not sure about the latter. Dirk Eddelbüttel does not maintain his packages in Vcs and I do not know his plans to do so. It might be irrelevant since I doubt he is using cme. I'm CCing debian-r list for review - may be Dirk can pronounce whether he considers it helpful if cme would insert Vcs fields also for his packages. This would simplify migrating his packages easily to Salsa by using cme in case he might decide to do this. Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Tue, 06 Mar 2018 23:27:04 +0100, gregor herrmann wrote: > > If you could add med-team and r-pkg-team which both have a flat > > package structure that would be great. The science-team has in > > most cases a flat structure but (IMHO unfortunately) some people > > decided to create subdirs ... > > I think that's fine, and I'm happy to add them unless Dominique has > some objections. > > Currently we have for Vcs-Git: > > 'formula' => ' $maintainer =~ /pkg-perl/? > "https://salsa.debian.org/perl-team/modules/packages/$pkgname.git; > : $maintainer =~ /pkg-ruby-extras/ ? > "https://salsa.debian.org/ruby-team/$pkgname.git; > : $maintainer =~ /pkg-javascript/ ? > "https://salsa.debian.org/js-team/$pkgname.git; > :\'\' ;', > > (And the same for Vcs-Browser minus the trailing .git) > > So for the med-team and the r-pkg-team we would need a string for the > maintainer address, and the base git URL at salsa. This part is still open, and I'm happy to add the missing runes for med-team and r-pkg-team; I just need confirmation for the values. I took a quick look today: For debian med this looks pretty straight-forward: if: $maintainer =~ /debian-med-packaging/ then: https://salsa.debian.org/med-team/$pkgname.git Correct? For the R team I'm not so sure. I looked at some packages, and 7 or 8 of 10 had $maintainer =~ debian-science-maintainers but I've also seen other values in Maintainers. Is there some unique value in debian/source to filter on? The URLs seem to be https://salsa.debian.org/r-pkg-team/$pkgname.git Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Element of Crime: Die letzte U-Bahn geht später signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Tuesday, 6 March 2018 23:27:04 CET gregor herrmann wrote: > I think that's fine, and I'm happy to add them unless Dominique has > some objections. No objections at all :-) Thanks -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Sat, 03 Mar 2018 18:08:59 +0100, Andreas Tille wrote: > > - update the hardcoded values for the perl, ruby, and javascript > > teams > If you could add med-team and r-pkg-team which both have a flat > package structure that would be great. The science-team has in > most cases a flat structure but (IMHO unfortunately) some people > decided to create subdirs ... I think that's fine, and I'm happy to add them unless Dominique has some objections. Currently we have for Vcs-Git: 'formula' => ' $maintainer =~ /pkg-perl/? "https://salsa.debian.org/perl-team/modules/packages/$pkgname.git; : $maintainer =~ /pkg-ruby-extras/ ? "https://salsa.debian.org/ruby-team/$pkgname.git; : $maintainer =~ /pkg-javascript/ ? "https://salsa.debian.org/js-team/$pkgname.git; :\'\' ;', (And the same for Vcs-Browser minus the trailing .git) So for the med-team and the r-pkg-team we would need a string for the maintainer address, and the base git URL at salsa. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: [DKP]: Lied vom Frieden (Portugal) signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Mon, 05 Mar 2018 18:55:15 +0100, Dominique Dumont wrote: > On Saturday, 3 March 2018 17:56:11 CET gregor herrmann wrote: > > Please review/merge/improve/ignore at your discretion > Merged. Thanks for the update :-) Thanks to you :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Bettina Wegner: Man sagt (The Rose) signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Saturday, 3 March 2018 17:56:11 CET gregor herrmann wrote: > Please review/merge/improve/ignore at your discretion Merged. Thanks for the update :-) -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Sat, Mar 03, 2018 at 05:56:11PM +0100, gregor herrmann wrote: > > So I'll remove the code that sets up Vcs-Git and Vcs-Browser from the team > > name. > > Hm? At least for known teams and their URLs I'd like to keep the > hardcoded values. +1 > - update the hardcoded values for the perl, ruby, and javascript > teams If you could add med-team and r-pkg-team which both have a flat package structure that would be great. The science-team has in most cases a flat structure but (IMHO unfortunately) some people decided to create subdirs ... Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Fri, 02 Mar 2018 16:48:03 +0100, Dominique Dumont wrote:
> So I'll remove the code that sets up Vcs-Git and Vcs-Browser from the team
> name.
Hm? At least for known teams and their URLs I'd like to keep the
hardcoded values.
> On the other hand, I can provide a cme script that would update Vcs-Git
> and Vcs-Browser from the remote URL (provided user specifies the right
> remote name).
Sounds like a nice addition.
I just pushed a branch gregoa/salsa which does two thing:
- accept m{^https://salsa.debian.org/} as a valid URL for Vcs-Browser
and Vcs-Git; while not 100% clever this at least avoids the
warnings about uncanonical URLs (the start of this bug report)
- update the hardcoded values for the perl, ruby, and javascript
teams
Please review/merge/improve/ignore at your discretion :)
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Element of Crime: Mittelpunkt der Welt
signature.asc
Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Wednesday, 21 February 2018 19:30:57 CET Andreas Tille wrote: > > How about starting from the value given by 'git remote show -v' ? (may be > > with a "|grep debian.org" ) > > For a totally random example I get: > > $ git remote -v show > origin g...@salsa.debian.org:r-pkg-team/r-cran-htmlwidgets.git (fetch) > origin g...@salsa.debian.org:r-pkg-team/r-cran-htmlwidgets.git (push) > > I have no idea what might happen for private clones / forks. Indeed. I can't find a generic way that would work with 'cme fix' because the remote name is not always 'origin'. So I'll remove the code that sets up Vcs-Git and Vcs-Browser from the team name. On the other hand, I can provide a cme script that would update Vcs-Git and Vcs-Browser from the remote URL (provided user specifies the right remote name). For instance: $ cme run set-vcs-git cme: using Dpkg::Control model Reading package lists... Done Building dependency tree Reading state information... Done Changes applied to dpkg-control configuration: - source Vcs-Browser: 'https://anonscm.debian.org/cgit/pkg-perl/packages/cme.git' -> 'https://salsa.debian.org/perl-team/modules/packages/cme' - source Vcs-Git: 'https://anonscm.debian.org/git/pkg-perl/packages/cme.git' -> 'https://salsa.debian.org/perl-team/modules/packages/cme.git' Would this be useful ? All the best PS: I first named the script "salsify", but it can be used even if the Debian files are not hosted on salsa.debian.org. Too bad, I liked this name :-) -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Hi Dominique, On Wed, Feb 21, 2018 at 05:48:18PM +0100, Dominique Dumont wrote: > > Well, to be fair, the URLs (the path part after the host) won't match > > anyway, and I don't see a way to come up with a generic rewriting > > scheme. > > How about starting from the value given by 'git remote show -v' ? (may be > with > a "|grep debian.org" ) For a totally random example I get: $ git remote -v show origin g...@salsa.debian.org:r-pkg-team/r-cran-htmlwidgets.git (fetch) origin g...@salsa.debian.org:r-pkg-team/r-cran-htmlwidgets.git (push) I have no idea what might happen for private clones / forks. I'm not sure whether I'd understand the full plan, whether you want to save anonscm or whether we'll give up again and will be back here in 2-3 years once salsa will change to something else again. :-( Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Monday, 12 February 2018 18:23:02 CET gregor herrmann wrote: > Well, to be fair, the URLs (the path part after the host) won't match > anyway, and I don't see a way to come up with a generic rewriting > scheme. How about starting from the value given by 'git remote show -v' ? (may be with a "|grep debian.org" ) -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Tue, 20 Feb 2018 22:40:51 +0100, Andreas Tille wrote: > > > In the Debian Med case the rewrite would need to do > > > s/debian-med/med-team/ > > > but in how far should this be a problem? > > Just that AFAIK we don't have any sufficiently advanced AI packaged > > yet which can guess the new team names for all teams :) > Replacing the per packaging project AliothRewriter by some team name > rewriter should be pretty simple, no? Yup, that would work for many cases, I guess. In the end that would be a simpler rewriter than what we have today, but still more than pointing anonscm to a new host. And that's all I wanted to say with my side note :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Schmetterlinge: Demokratielied signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Tue, Feb 20, 2018 at 09:14:09PM +0100, gregor herrmann wrote: > On Tue, 20 Feb 2018 19:15:07 +0100, Andreas Tille wrote: > > > > It might work though if the team name and the path beyond it stay the > > > same ... > > In the Debian Med case the rewrite would need to do > > s/debian-med/med-team/ > > but in how far should this be a problem? > > Just that AFAIK we don't have any sufficiently advanced AI packaged > yet which can guess the new team names for all teams :) Replacing the per packaging project AliothRewriter by some team name rewriter should be pretty simple, no? Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Tue, 20 Feb 2018 19:15:07 +0100, Andreas Tille wrote: > > It might work though if the team name and the path beyond it stay the > > same ... > In the Debian Med case the rewrite would need to do > s/debian-med/med-team/ > but in how far should this be a problem? Just that AFAIK we don't have any sufficiently advanced AI packaged yet which can guess the new team names for all teams :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Cat Stevens: Portobello Road signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Hi Gregor, On Tue, Feb 20, 2018 at 06:14:15PM +0100, gregor herrmann wrote: > > Med team are created automatically in most cases (well some exceptions > > where r-* packages are moved to a different team). So what exactly do > > you have in mind when you doubt the generic rewriting scheme? > > Sorry for being unclear, what I meant is that a rewrite from > > Vcs-Git: https://anonscm.debian.org/git/pkg-perl/packages/.git", > Vcs-Browser: https://anonscm.debian.org/cgit/pkg-perl/packages/.git", > > to > > Vcs-Git: https://salsa.debian.org/perl-team/modules/packages/.git", > Vcs-Browser: https://salsa.debian.org/perl-team/modules/packages/ > > will be impossible to find for a generic automatic rewriting scheme. Since you are doing a split between modules and "non-modules"? If yes this would be a perl team specific issue and does not really apply for all teams. > It might work though if the team name and the path beyond it stay the > same ... In the Debian Med case the rewrite would need to do s/debian-med/med-team/ but in how far should this be a problem? Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Tue, 20 Feb 2018 14:30:58 +0100, Andreas Tille wrote: > > > people (including me) who consider this totally insane since this just > > > continues the "Update Vcs-fields every second year" cycle and I really > > > hope that this insanity will be broken by simply pointing anonscm to > > > salsa in general once the migration is done. > > Well, to be fair, the URLs (the path part after the host) won't match > > anyway, and I don't see a way to come up with a generic rewriting > > scheme. > What do you mean here? The AliothRewriter rules at least for the Debian > Med team are created automatically in most cases (well some exceptions > where r-* packages are moved to a different team). So what exactly do > you have in mind when you doubt the generic rewriting scheme? Sorry for being unclear, what I meant is that a rewrite from Vcs-Git: https://anonscm.debian.org/git/pkg-perl/packages/.git", Vcs-Browser: https://anonscm.debian.org/cgit/pkg-perl/packages/.git", to Vcs-Git: https://salsa.debian.org/perl-team/modules/packages/.git", Vcs-Browser: https://salsa.debian.org/perl-team/modules/packages/ will be impossible to find for a generic automatic rewriting scheme. It might work though if the team name and the path beyond it stay the same ... Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Cat Stevens: Portobello Road signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Hi Gregor, On Mon, Feb 12, 2018 at 06:23:02PM +0100, gregor herrmann wrote: > > people (including me) who consider this totally insane since this just > > continues the "Update Vcs-fields every second year" cycle and I really > > hope that this insanity will be broken by simply pointing anonscm to > > salsa in general once the migration is done. > > Well, to be fair, the URLs (the path part after the host) won't match > anyway, and I don't see a way to come up with a generic rewriting > scheme. What do you mean here? The AliothRewriter rules at least for the Debian Med team are created automatically in most cases (well some exceptions where r-* packages are moved to a different team). So what exactly do you have in mind when you doubt the generic rewriting scheme? > (And at that point we could argue again that Vcs-* and other > information shouldn't be in the source package but that won't help > for this bug.) Yes, please do not discuss this here! Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Mon, 12 Feb 2018 15:34:58 +0100, Andreas Tille wrote: > > No, TTBOMK it won't. (So much for generic hostnames.) > > There's a rewriter [0] in place, but anonscm.debian.org won't go > > anywhere, AFAIK. > Or more precisely: There are people who are not interested to let > anonscm.debian.org go anywhere. On the other hand there are lots of > people (including me) who consider this totally insane since this just > continues the "Update Vcs-fields every second year" cycle and I really > hope that this insanity will be broken by simply pointing anonscm to > salsa in general once the migration is done. Well, to be fair, the URLs (the path part after the host) won't match anyway, and I don't see a way to come up with a generic rewriting scheme. (And at that point we could argue again that Vcs-* and other information shouldn't be in the source package but that won't help for this bug.) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Bob Dylan: Drifter's Escape signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Hi Gregor, On Fri, Feb 09, 2018 at 01:09:21AM +0100, gregor herrmann wrote: > > cme issues a warning is the vcs browser URL does not point to > > anonscm.debian.org. This host currently redirects to alioth. IIRC, it will > > point to salsa once the transition is done. > > No, TTBOMK it won't. (So much for generic hostnames.) > There's a rewriter [0] in place, but anonscm.debian.org won't go > anywhere, AFAIK. Or more precisely: There are people who are not interested to let anonscm.debian.org go anywhere. On the other hand there are lots of people (including me) who consider this totally insane since this just continues the "Update Vcs-fields every second year" cycle and I really hope that this insanity will be broken by simply pointing anonscm to salsa in general once the migration is done. > > What can we do in the meantime with cme ? > > - accepts both salsa and anonscm ? (this is a change that would need to be > > reverted once alioth to salsa transition is done) > > - remove the check until the transition is done, so no warning is emitted > > - do nothing (may be update the doc) > > Maybe accept alioth/anonscm and salsa for now, and remove the former > once it's shut down. > Or just switch to salsa. Or don't do nothing now and switch to salsa > once alioth is history. IMHO alowing salsa a valid Vcs field for the moment makes sense but rather deprecate it once sanity has won over insanity. :-P Kind regards Andreas. -- http://fam-tille.de
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Friday, 9 February 2018 01:09:21 CET gregor herrmann wrote: > Maybe accept alioth/anonscm and salsa for now, and remove the former > once it's shut down. > Or just switch to salsa. Or don't do nothing now and switch to salsa > once alioth is history. Currently cme warns if anonscm is not used and tries to provide default value for some known case. I.e the Vcds_Browser value is computed for pkg-perl, ruby javascript team. Currently, I don't really know which are the convention that will be used by these teams. I think I'll sit on this bug until some packaging have migrated on salsa. All the best -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
On Thu, 08 Feb 2018 20:36:39 +0100, Dominique Dumont wrote: > > Warning in 'control source Vcs-Browser' value > > 'https://salsa.debian.org/blahblah-team/blah.git': URL is not the canonical > > one for repositories hosted on Alioth. > I wonder what is the best solution here. > cme issues a warning is the vcs browser URL does not point to > anonscm.debian.org. This host currently redirects to alioth. IIRC, it will > point to salsa once the transition is done. No, TTBOMK it won't. (So much for generic hostnames.) There's a rewriter [0] in place, but anonscm.debian.org won't go anywhere, AFAIK. > What can we do in the meantime with cme ? > - accepts both salsa and anonscm ? (this is a change that would need to be > reverted once alioth to salsa transition is done) > - remove the check until the transition is done, so no warning is emitted > - do nothing (may be update the doc) Maybe accept alioth/anonscm and salsa for now, and remove the former once it's shut down. Or just switch to salsa. Or don't do nothing now and switch to salsa once alioth is history. Cheers, gregor [0] https://salsa.debian.org/salsa/AliothRewriter -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Eagles signature.asc Description: Digital Signature
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Hello team On Tue, 06 Feb 2018 21:57:19 +0800 Boyuan Yang <073p...@gmail.com> wrote: > When the check encounters Vcs-* fields with salsa.debian.org, > it will (wrongly) report warnings, like: > > Warning in 'control source Vcs-Browser' value > 'https://salsa.debian.org/blahblah-team/blah.git': URL is not the canonical > one for repositories hosted on Alioth. I wonder what is the best solution here. cme issues a warning is the vcs browser URL does not point to anonscm.debian.org. This host currently redirects to alioth. IIRC, it will point to salsa once the transition is done. What can we do in the meantime with cme ? - accepts both salsa and anonscm ? (this is a change that would need to be reverted once alioth to salsa transition is done) - remove the check until the transition is done, so no warning is emitted - do nothing (may be update the doc) Thoughts ? -- https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/ http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Bug#889732: libconfig-model-dpkg-perl: Does not recognize Salsa platform in Vcs field
Package: libconfig-model-dpkg-perl Version: 2.105 Severity: normal When the check encounters Vcs-* fields with salsa.debian.org, it will (wrongly) report warnings, like: Warning in 'control source Vcs-Browser' value 'https://salsa.debian.org/blahblah-team/blah.git': URL is not the canonical one for repositories hosted on Alioth. Warning in 'control source Vcs-Git' value 'https://salsa.debian.org/blahblah- team/blah.git': URL is not the canonical one for repositories hosted on Alioth. Please fix this problem soon since Salsa will completely replace Alioth before May 2018. -- Regards, Boyuan Yang -- System Information: Debian Release: buster/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=zh_CN.UTF-8, LC_CTYPE=zh_CN.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages libconfig-model-dpkg-perl depends on: ii libapt-pkg-perl 0.1.33 ii libarray-intspan-perl2.003-1 ii libconfig-model-perl 2.116-1 ii libexporter-lite-perl0.08-1 ii liblog-log4perl-perl 1.49-1 ii libmouse-perl2.5.1-1 ii libparse-recdescent-perl 1.967015+dfsg-1 ii libsoftware-license-perl 0.103012-1 ii libtext-autoformat-perl 1.74-2 ii libtext-levenshtein-damerau-perl 0.41-1 ii liburi-perl 1.73-1 ii libwww-perl 6.31-1 ii libyaml-perl 1.24-1 ii licensecheck 3.0.31-2 ii lintian 2.5.73 ii perl 5.26.1-4+b1 ii perl-modules-5.26 [libmodule-corelist-perl] 5.26.1-4 Versions of packages libconfig-model-dpkg-perl recommends: ii libconfig-model-tkui-perl 1.365-1 libconfig-model-dpkg-perl suggests no packages. -- no debconf information
