Bug#890728: nmap: zenmap (as root) .desktop file missing.

[Raphael Hertzog]

Hi,

On Tue, 23 Oct 2018, Samuel Henrique wrote:
> > Thanks for the report. But the menu package is something that we should
> > really phase out and try to avoid so I would suggest to switch to pkexec
> > instead and to add a "Recommends: policykit-1" which is likely already
> > satisfied on most desktops.
> 
> I can see that there was some action towards your suggestion on
> launchpad[0] some time ago, but I think they may have stopped working
> on that.

So what about picking it up? I think they have done everything needed
except maybe using the right command name in the .desktop. I believe
you have to use the full path (i.e. "pkexec /usr/bin/zenmap %F").

I'm speaking of this debdiff:
https://launchpadlibrarian.net/357861735/nmap-zenmap-use-pkexec-experimental.debdiff

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#890728: nmap: zenmap (as root) .desktop file missing.

[Samuel Henrique]

> Thanks for the report. But the menu package is something that we should
> really phase out and try to avoid so I would suggest to switch to pkexec
> instead and to add a "Recommends: policykit-1" which is likely already
> satisfied on most desktops.

I can see that there was some action towards your suggestion on
launchpad[0] some time ago, but I think they may have stopped working
on that.

Meanwhile, do you think it's worth fixing this by adding menu as a
dependency, Raphaël? I wonder if the benefit of fixing the menu entry
is worth depending on it, this will make our package equal to Ubuntu's
AFAIK[1].

[0]https://bugs.launchpad.net/ubuntu/+source/nmap/+bug/1263311/comments/11
[1]http://changelogs.ubuntu.com/changelogs/pool/main/n/nmap/nmap_7.60-1ubuntu5/changelog

Thanks,

-- 
Samuel Henrique 

Bug#890728: nmap: zenmap (as root) .desktop file missing.

[Raphael Hertzog]

Hello,

On Sat, 17 Feb 2018, David Britton wrote:
> In Ubuntu, the attached patch was applied to achieve the following:
> 
> The .desktop file for running zenmap as root does not function correctly
> without the 'menu' package that provides the `su-to-root` binary.  This
> patch simply adds 'menu' as a dependency of the zenmap binary package.
> 
>   * debian/control: Add dependency menu for zenmap. (LP #126331)
> 
> Thanks for considering the patch.

Thanks for the report. But the menu package is something that we should
really phase out and try to avoid so I would suggest to switch to pkexec
instead and to add a "Recommends: policykit-1" which is likely already
satisfied on most desktops.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#890728: nmap: zenmap (as root) .desktop file missing.

[David Britton]

Package: nmap
Version: 7.60-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Dear Maintainer,

Ubuntu Bug reference:
https://bugs.launchpad.net/ubuntu/+source/nmap/+bug/1263311


*** /tmp/tmpjg9w1z/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

The .desktop file for running zenmap as root does not function correctly
without the 'menu' package that provides the `su-to-root` binary.  This
patch simply adds 'menu' as a dependency of the zenmap binary package.

  * debian/control: Add dependency menu for zenmap. (LP #126331)

Thanks for considering the patch.


-- System Information:
Debian Release: buster/sid
  APT prefers bionic
  APT policy: (500, 'bionic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-32-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru nmap-7.60/debian/control nmap-7.60/debian/control
--- nmap-7.60/debian/control2018-02-05 09:51:25.0 -0700
+++ nmap-7.60/debian/control2018-02-17 21:19:25.0 -0700
@@ -1,8 +1,7 @@
 Source: nmap
 Section: net
 Priority: extra
-Maintainer: Ubuntu Developers 
-XSBC-Original-Maintainer: Debian Security Tools Packaging Team 

+Maintainer: Debian Security Tools Packaging Team 

 Uploaders: Hilko Bengen ,
Samuel Henrique 
 Build-Depends: bison,
@@ -46,6 +45,7 @@
  python (>= 2.5) | python-pysqlite2,
  python-gobject-2 | python-gobject,
  python-gtk2,
+ menu, 
  ${misc:Depends},
  ${python:Depends},
  ${shlibs:Depends}