Bug#923931: upgrade breaks old containers
On Mon, Mar 11, 2019 at 09:54:14AM +0100, Harald Dunkel wrote: > Hi Pierre, > > On 3/8/19 2:30 PM, Pierre-Elliott Bécue wrote: > > > > I'm sorry, but lxc-templates is not needed to have lxc3 working, so it > > won't become a Dependency. Moving the files from src:lxc-templates to > > src:lxc and subsequently creating two DS uploads is not a fine solution > > either. > > > > lxc-templates is necessary for a successful migration of the containers > generated on Stretch. I do not know what else I can say about this. I'm not going to repeat the explanation why lxc-templates is not a hard dependency of lxc. This hard dependency will need to be dropped at some point, either now or in the future. Now or then, people who blindly disable Recommends: AND don't read NEWS entries will be affected, and we will have to live with that. signature.asc Description: PGP signature
Bug#923931: upgrade breaks old containers
Hi Pierre, On 3/8/19 2:30 PM, Pierre-Elliott Bécue wrote: I'm sorry, but lxc-templates is not needed to have lxc3 working, so it won't become a Dependency. Moving the files from src:lxc-templates to src:lxc and subsequently creating two DS uploads is not a fine solution either. lxc-templates is necessary for a successful migration of the containers generated on Stretch. I do not know what else I can say about this. Regards Harri
Bug#923931: upgrade breaks old containers
Control: tags -1 + wontfix Le vendredi 08 mars 2019 à 10:09:14+0100, Harald Dunkel a écrit : > Hi Antonio, > > wven if Recommends is turned off, its obvious that the template > specific include files are *required* for a successful migration > to lxc 3. It shouldn't matter that Recommends is turned off. > > Platform specific template scripts might be considered as deprecated > by upstream [1], but > > * the promised "distrobuilder" is not in Debian, AFAICT > * we are talking about the platform specific config files here > > Regards Hi Harald, I'm sorry, but lxc-templates is not needed to have lxc3 working, so it won't become a Dependency. Moving the files from src:lxc-templates to src:lxc and subsequently creating two DS uploads is not a fine solution either. I admit the situation is not perfect, and lxc-update-config is not able to see such issues and warn you. I assume that whoever disables the recommends know what they do and can find a solution by themselves. I'm eager to put a specific warning in the debian/NEWS file for those using apt-listchanges, or even a prompt warning for the issue in the upgrade script, but at some point, there is no perfect solution. In any case I'll have th have this accepted by the release managers as the timeline for the freeze crosses the delay for such a change to be included. If you have a better suggestion I'm open to it, but for now I don't intend to fix this issue with one of the solutions you suggested. Best regards, -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#923931: upgrade breaks old containers
Hi Antonio, wven if Recommends is turned off, its obvious that the template specific include files are *required* for a successful migration to lxc 3. It shouldn't matter that Recommends is turned off. Platform specific template scripts might be considered as deprecated by upstream [1], but * the promised "distrobuilder" is not in Debian, AFAICT * we are talking about the platform specific config files here Regards Harri [1]: https://brauner.github.io/2018/02/27/lxc-removes-legacy-template-build-system.html
Bug#923931: upgrade breaks old containers
On Thu, Mar 07, 2019 at 12:49:21PM +0100, Harald Dunkel wrote: > Package: lxc > Version: 1:3.1.0+really3.0.3-5 > > After the upgrade to lxc 3 the old containers created by > lxc 2 don't work anymore, even though lxc-update-config has > been run (manually). The config files still contain template > specific include statements, e.g. > > lxc.include = /usr/share/lxc/config/debian.common.conf > > These files are not included in lxc 3. They are included in > lxc-templates, but this package was not installed during the > upgrade. > > I would suggest to either add "Depends: lxc-templates" to > the package dependencies, or to move the lost template specific > include files back into the lxc 3 package. This only happens if you turn recommends off. templates are considered deprecated by upstream, and while we are keepking them around I don't think we should have a hard dependency on them. Under the default APT settings lxc-templates will come together with lxc on upgrades, but maybe we could add a NEWS entry about needing lxc-templates if you have legacy containers *and* turns recommends off. signature.asc Description: PGP signature
Bug#923931: upgrade breaks old containers
Package: lxc Version: 1:3.1.0+really3.0.3-5 After the upgrade to lxc 3 the old containers created by lxc 2 don't work anymore, even though lxc-update-config has been run (manually). The config files still contain template specific include statements, e.g. lxc.include = /usr/share/lxc/config/debian.common.conf These files are not included in lxc 3. They are included in lxc-templates, but this package was not installed during the upgrade. I would suggest to either add "Depends: lxc-templates" to the package dependencies, or to move the lost template specific include files back into the lxc 3 package. Regards Harri
