Bug#932290:

2021-03-21 Thread Matteo Croce
On Sun, Mar 21, 2021 at 12:38 PM Matthew Vernon  wrote:
> Have you upgraded to the later version of insserv? And if so, has this
> resolved the problem for you?
>

How to trigger it? Maybe with:

apt --reinstall install rsync

In case, I don't get any warning.

Regards,
-- 
per aspera ad upstream



Bug#932290:

2021-03-21 Thread Matthew Vernon

On 04/03/2021 14:20, Matthew Vernon wrote:

On 04/03/2021 14:01, Matteo Croce wrote:

On Thu, Mar 4, 2021 at 2:53 PM Matthew Vernon  wrote:

On 04/03/2021 13:36, Matteo Croce wrote:

I'm seeing it multiple times now during an upgrade:


Which version of insserv have you got? 1.21.0-1.1 (which we expect to
fix this) isn't yet in testing.



ii  insserv    1.21.0-1 amd64


Right. I think you have a duplicate of #971713 here.


Have you upgraded to the later version of insserv? And if so, has this 
resolved the problem for you?


Regards,

Matthew



Bug#932290:

2021-03-04 Thread Matthew Vernon

On 04/03/2021 14:01, Matteo Croce wrote:

On Thu, Mar 4, 2021 at 2:53 PM Matthew Vernon  wrote:

On 04/03/2021 13:36, Matteo Croce wrote:

I'm seeing it multiple times now during an upgrade:


Which version of insserv have you got? 1.21.0-1.1 (which we expect to
fix this) isn't yet in testing.



ii  insserv1.21.0-1 amd64


Right. I think you have a duplicate of #971713 here.

Regards,

Matthew



Bug#932290:

2021-03-04 Thread Matteo Croce
On Thu, Mar 4, 2021 at 2:53 PM Matthew Vernon  wrote:
>
> Hi,
>
> On 04/03/2021 13:36, Matteo Croce wrote:
> > I'm seeing it multiple times now during an upgrade:
>
> Which version of insserv have you got? 1.21.0-1.1 (which we expect to
> fix this) isn't yet in testing.
>

ii  insserv1.21.0-1 amd64

-- 
per aspera ad upstream



Bug#932290:

2021-03-04 Thread Matthew Vernon

Hi,

On 04/03/2021 13:36, Matteo Croce wrote:

I'm seeing it multiple times now during an upgrade:


Which version of insserv have you got? 1.21.0-1.1 (which we expect to 
fix this) isn't yet in testing.


Regards,

Matthew



Bug#932290:

2021-03-04 Thread Matteo Croce
I'm seeing it multiple times now during an upgrade:

Setting up initscripts (2.96-6) ...
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
Processing triggers for man-db (2.9.4-2) ...

-- 
per aspera ad upstream



Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2020-09-21 Thread Timo van Roermund

Same issue here. I get the following output when upgrading initscripts:

Preparing to unpack .../07-initscripts_2.96-5_all.deb ...
Unpacking initscripts (2.96-5) over (2.96-4) ...
(...)
Setting up initscripts (2.96-5) ...
Installing new version of config file /etc/init.d/mountdevsubfs.sh ...
insserv: Script sysstat has overlapping Default-Start and Default-Stop 
runlevels (2 3 4 5) and (2 3 4 5). This should be fixed.


(the last line is repeated another 27 times)

Any idea why this is happening? Anything I should check on my PC?



Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2019-08-30 Thread Jesse Smith
When I applied the patch provided above it causes insserv to segfault
when running the testsuite (make check). Looks like the program is
crashing using one of the LSB header checks. I haven't looked into it in
any detail yet, but it seems moving that check to a sooner point causes
a memory issue.

- Jesse



Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2019-07-25 Thread Dmitry Bogatov


control: tags -1 +confirmed +help +upstream +patch

[2019-07-24 14:12] Lorenz 
> Control: severity -1 normal
>
> Ok, here is what I've found out; to reproduce the issue you need to
> disable with update-rc.d a script that has an empty ' Default-Stop: ' field
> in the LSB header.
> [...]

Yes, I reproduced.

> This is a minor issue, but still i have few suggestions:
>
> 1. the message looks like an error, but insserv exits 0, so i guess it' a
> warning,
> maybe it should be ' insserv: warning: Script ssh has ...'
> 2. disabling a service is a legit action and insserv already prints a
> warning about
> overriding LSB defaults, so what is this warning about (what is to be
> fixed)?
> Is an empty ' Default-Stop: ' field a bug, or it's something else?

This check is about LSB headers, where some runlevel is listed both in
Default-Start and Default-Stop. It is really serious.  But behaviour you
are reporing is false-positive. There is no need to change message --
only to make sure it is printed in apporiate situations.

I prepared patch that fix problem at hand (I believe), but I am not sure
that it does not introduce problems in another cases. The whole point is
that `script_inf.default_stop' value gets overrided around
insserv.c:3698, so I moved overlap check up. Jesse, can you please take
a look?

By the way, `if (!service)' conditional is always true -- `service'
variable gets initialized to `0' and is not modified before this
conditional.

diff --git a/insserv.c b/insserv.c
index 0c638dd..fa02b23 100644
--- a/insserv.c
+++ b/insserv.c
@@ -3475,6 +3475,12 @@ int main (int argc, char *argv[])
}   /* !findservice(, script_inf.provides) */
}
 
+   overlap = Start_Stop_Overlap(script_inf.default_start, 
script_inf.default_stop);
+   if (overlap) {
+   warn("Script %s has overlapping Default-Start and Default-Stop 
runlevels (%s) and (%s). This should be fixed.\n",
+d->d_name, script_inf.default_start, 
script_inf.default_stop);
+   }
+
/*
 * Use guessed service to find it within the the runlevels
 * (by using the list from the first scan for script locations).
@@ -3733,13 +3739,6 @@ int main (int argc, char *argv[])
}
 #endif /* not SUSE */
 
-overlap = Start_Stop_Overlap(script_inf.default_start, 
script_inf.default_stop);
-if (overlap)
-{
-warn("Script %s has overlapping Default-Start and Default-Stop 
runlevels (%s) and (%s). This should be fixed.\n",
-  d->d_name, script_inf.default_start, 
script_inf.default_stop);
-}
-
if (isarg && !defaults && !del) {
if (argr[curr_argc]) {
char * ptr = argr[curr_argc];

-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.



Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2019-07-24 Thread Lorenz
Control: severity -1 normal

Ok, here is what I've found out; to reproduce the issue you need to
disable with update-rc.d a script that has an empty ' Default-Stop: ' field
in the LSB header.

# update-rc.d ssh disable
insserv: warning: current start runlevel(s) (empty) of script `ssh'
overrides LSB defaults (2 3 4 5).
insserv: warning: current stop runlevel(s) (2 3 4 5) of script `ssh'
overrides LSB defaults (empty).
insserv: Script ssh has overlapping Default-Start and Default-Stop
runlevels (2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script rsync has overlapping Default-Start and Default-Stop
runlevels (2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script lvm2 has overlapping Default-Start and Default-Stop
runlevels (S) and (S). This should be fixed.

there are other scripts that can trigger this, for example on my system I
also
have Cron and Anacron.

This is a minor issue, but still i have few suggestions:

1. the message looks like an error, but insserv exits 0, so i guess it' a
warning,
maybe it should be ' insserv: warning: Script ssh has ...'
2. disabling a service is a legit action and insserv already prints a
warning about
overriding LSB defaults, so what is this warning about (what is to be
fixed)?
Is an empty ' Default-Stop: ' field a bug, or it's something else?

Thanks,
Lorenzo


Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2019-07-23 Thread Dmitry Bogatov


[2019-07-21 15:36] Lorenz 
> Il giorno gio 18 lug 2019 alle ore 14:45 Dmitry Bogatov 
> ha scritto:
> >Are there overrides in /etc/insserv/overrides/?  Does this warning
> >appear if you invoke:
> >
> > 1. # insserv
> > 2. # insserv apparmor
> > 3. If either 1. or 2. reproduces problem, please invoke them under strace
> and
> > show output.
>
> overrides directory is empty; both 1. and 2. trigger the warning,
> output of 'strace insserv' is attached.
> [...]

Thanks, but nothing I found suspicious. Okay, let us try another way.

$ mkdir /tmp/testing
$ cd /tmp/testing
$ cp -r /etc/init.d .
$ cp -r /etc/insserv.conf .
$ /sbin/insserv -p init.d -c insserv.conf -i init.d ./init.d/apparmor

Does it produce error about overlapping runlevels on your system?

(On my system it outputs warning:
   insserv: warning: could not find all dependencies for $portmap
 Wierd.)

Can you reproduce problem in chroot (debootstrap) or in VM?
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.



Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2019-07-18 Thread Dmitry Bogatov


control: tags -1 +help +moreinfo

[2019-07-17 13:25] Lorenzo Puliti 
> [...]
> insserv: Script rsync has overlapping Default-Start and Default-Stop 
> runlevels (2 3 4 5) and (2 3 4 5). This s
> hould be fixed.
> insserv: Script lvm2 has overlapping Default-Start and Default-Stop runlevels 
> (S) and (S). This should be fixe
> d.
> insserv: Script apparmor has overlapping Default-Start and Default-Stop 
> runlevels (S) and (S). This should be 
> fixed.
> [...]
> I'm not sure why it detects that start and stop runlevels are overlapping, 
> all rsync lvm2 and apparmor
> have empty 'Default-Stop' field in the header like this
>
> ### BEGIN INIT INFO
> # Provides: apparmor
> # Required-Start: $local_fs
> # Required-Stop: umountfs
> # Default-Start: S
> # Default-Stop:
> # Short-Description: AppArmor initialization

Are there overrides in /etc/insserv/overrides/?  Does this warning
appear if you invoke:

 1. # insserv
 2. # insserv apparmor
 3. If either 1. or 2. reproduces problem, please invoke them under strace and
 show output.

> Downgrading insserv to 1.18.0-2 fix the issue for me

Sure, this check was introduced in 1.20 (a06c7fae, to be exact).
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.



Bug#932290: insserv: Script has overlapping Default-Start and Default-Stop runlevels

2019-07-17 Thread Lorenzo Puliti
Package: insserv
Version: 1.20.0-1
Severity: important

Dear insserv maintainers,

upgrading the system lead to several warnings from insserv; maybe this is a 
duplicate of 
932199, but i have some additional lines related to rsync, lvm2 and apparmor

[...]
Unpacking initscripts (2.95-1) over (2.95-1) ...
Preparing to unpack .../10-libassuan0_2.5.3-6_amd64.deb ...
Unpacking libassuan0:amd64 (2.5.3-6) over (2.5.3-6) ...
Setting up anacron (2.3-29) ...
insserv: warning: could not find all dependencies for $portmap
insserv: warning: could not find all dependencies for $portmap
insserv: warning: could not find all dependencies for $portmap
insserv: warning: could not find all dependencies for $portmap
insserv: Script rsync has overlapping Default-Start and Default-Stop runlevels 
(2 3 4 5) and (2 3 4 5). This should be fixed.
insserv: Script lvm2 has overlapping Default-Start and Default-Stop runlevels 
(S) and (S). This should be fixed.
insserv: Script apparmor has overlapping Default-Start and Default-Stop 
runlevels (S) and (S). This should be fixed.
Setting up hdparm (9.58+ds-2) ...
[...]

I'm not sure why it detects that start and stop runlevels are overlapping, all 
rsync lvm2 and apparmor
have empty 'Default-Stop' field in the header like this

### BEGIN INIT INFO
# Provides: apparmor
# Required-Start: $local_fs
# Required-Stop: umountfs
# Default-Start: S
# Default-Stop:
# Short-Description: AppArmor initialization

Downgrading insserv to 1.18.0-2 fix the issue for me

Lorenzo



-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)

Versions of packages insserv depends on:
ii  libc6  2.28-10

insserv recommends no packages.

Versions of packages insserv suggests:
pn  bootchart2  

-- no debconf information