Bug#985231: [Pkg-javascript-devel] Bug#985231: Bug#985231: TypeError: Cannot use 'in' operator to search for 'dependencies' in ../package.json
Hi, On 2021-03-18 18:55, Nilesh Patra wrote: > On 18 March 2021 8:22:54 pm IST, Andrius Merkys wrote: > > On 2021-03-15 13:45, Pirate Praveen wrote: >>> If no one steps in to fix this, then we can consider removing it. >> Codesearch does not list any uses of node-sass binary. Thus I think it >> is safe to remove it. > ACK. This should be done after freeze, right? I would be better to not ship broken things in bullseye, and remove them afterwards. I suggest removing it before bullseye, and re-adding in the next point release. Also maybe this bug should be reassigned to >> node-normalize-package-data? >>> Is node-node-sass using a compatible version of node-normalize-path? >>> >>> May be it is expecting a different API? (If the version >> node-node-sass expects in its package.json is different from the >> version available in the archive, this can happen). >> >> In package.json, node-node-sass does not mention neither >> node-normalize-package-data nor node-normalize-path. > It might not be a direct dependency but a transitive one. True. I prefer leaving it for someone with appropriate knowledge to investigate further. Best, Andrius
Bug#985231: [Pkg-javascript-devel] Bug#985231: Bug#985231: TypeError: Cannot use 'in' operator to search for 'dependencies' in ../package.json
On 18 March 2021 8:22:54 pm IST, Andrius Merkys wrote: >Hello, > >On 2021-03-15 13:45, Pirate Praveen wrote: >> On 2021, മാർച്ച് 15 4:21:37 PM IST, Nilesh Patra >wrote: $ node-sass /usr/share/nodejs/normalize-package-data/lib/fixer.js:138 if (!(deps in data)) return ^ >>> >>> Since node-node-sass is supposed to be used as a library, probably >we do not need to vendor this binary: /usr/bin/node-sass -> >../lib/x86_64-linux-gnu/nodejs/node-sass/bin/node-sass >> >> If someone wants to use the binary and someone cares to make it work, >we can fix it. >> >> If no one steps in to fix this, then we can consider removing it. > >Codesearch does not list any uses of node-sass binary. Thus I think it >is safe to remove it. ACK. This should be done after freeze, right? Nilesh > >>> Also maybe this bug should be reassigned to >node-normalize-package-data? >> >> Is node-node-sass using a compatible version of node-normalize-path? >> >> May be it is expecting a different API? (If the version >node-node-sass expects in its package.json is different from the >version available in the archive, this can happen). > >In package.json, node-node-sass does not mention neither >node-normalize-package-data nor node-normalize-path. It might not be a direct dependency but a transitive one. Nilesh -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Bug#985231: [Pkg-javascript-devel] Bug#985231: Bug#985231: TypeError: Cannot use 'in' operator to search for 'dependencies' in ../package.json
Hello, On 2021-03-15 13:45, Pirate Praveen wrote: > On 2021, മാർച്ച് 15 4:21:37 PM IST, Nilesh Patra wrote: >>> $ node-sass >>> /usr/share/nodejs/normalize-package-data/lib/fixer.js:138 >>> if (!(deps in data)) return >>> ^ >> >> Since node-node-sass is supposed to be used as a library, probably we do not >> need to vendor this binary: /usr/bin/node-sass -> >> ../lib/x86_64-linux-gnu/nodejs/node-sass/bin/node-sass > > If someone wants to use the binary and someone cares to make it work, we can > fix it. > > If no one steps in to fix this, then we can consider removing it. Codesearch does not list any uses of node-sass binary. Thus I think it is safe to remove it. >> Also maybe this bug should be reassigned to node-normalize-package-data? > > Is node-node-sass using a compatible version of node-normalize-path? > > May be it is expecting a different API? (If the version node-node-sass > expects in its package.json is different from the version available in the > archive, this can happen). In package.json, node-node-sass does not mention neither node-normalize-package-data nor node-normalize-path. Best, Andrius
Bug#985231: [Pkg-javascript-devel] Bug#985231: Bug#985231: TypeError: Cannot use 'in' operator to search for 'dependencies' in ../package.json
On 2021, മാർച്ച് 15 4:21:37 PM IST, Nilesh Patra wrote: >> Dear Maintainer, >> >> * What led up to the situation? >> >> I installed node-node-sass, and ran its installed binary node-sass. >> >> * What exactly did you do (or not do) that was effective (or >> ineffective)? >> >> Ran the command "node-sass". I tried running in different paths, with >> different parameters, and on a different system, but the result was >> the same. >> >> * What was the outcome of this action? >> >> $ node-sass >> /usr/share/nodejs/normalize-package-data/lib/fixer.js:138 >> if (!(deps in data)) return >> ^ > >Since node-node-sass is supposed to be used as a library, probably we do not >need to vendor this binary: /usr/bin/node-sass -> >../lib/x86_64-linux-gnu/nodejs/node-sass/bin/node-sass If someone wants to use the binary and someone cares to make it work, we can fix it. If no one steps in to fix this, then we can consider removing it. >Also maybe this bug should be reassigned to node-normalize-package-data? Is node-node-sass using a compatible version of node-normalize-path? May be it is expecting a different API? (If the version node-node-sass expects in its package.json is different from the version available in the archive, this can happen). >@Team, thoughts? > >Nilesh > -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
