Bug#1056563: kodi: arm platforms should use gles APP_RENDER_SYSTEM

2023-11-23 Thread Vasyl Gello
Dear Jianfeng,

I am aware about your patch and appreciate the efforts you put in it.

However, I want to be sure all armel / armhf / aarch64 devices will benefit 
from this change.

I raised this question with the team here: 
https://github.com/xbmc/xbmc/pull/18534

Can you please participate in discussion so I understand how to solve the 
drmprime issue properly?

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1072426: kodi-inputstream-ffmpegdirect: FTBFS with ffmpeg 7.0: FFmpegStream.cpp:1067:35: error: ‘const AVInputFormat’ {aka ‘const struct AVInputFormat’} has no member named ‘read_probe’

2024-06-02 Thread Vasyl Gello
Control: forwarded -1 https://github.com/xbmc/xbmc/pull/24972

Hi Sebastian,

The MR is underway but the issues are slowly fixed.

Bug#1072427: kodi: FTBFS with ffmpeg 7.0: DVDDemuxFFmpeg.cpp:424:37: error: ‘const AVInputFormat’ {aka ‘const struct AVInputFormat’} has no member named ‘read_probe’

2024-06-02 Thread Vasyl Gello
Control: forwarded -1 https://github.com/xbmc/xbmc/pull/24972

Bug#1032413: kodi-inputstream-adaptive FTCBFS: assumes a toolchain file

2023-03-06 Thread Vasyl Gello
Hi Helmut!

Thanks for the patch! There is a typo (COMPILR instead of COMPILER).
But let me try cross-building that addon first. I recall I tried crossbuilding 
addons for big-endian architectures at least.
If it does not work, I would better generate the toolchain file in configure 
step and apply that to all Kodi addons.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1032413: kodi-inputstream-adaptive FTCBFS: assumes a toolchain file

2023-03-06 Thread Vasyl Gello
I reproduced the behavior and it appears that the CMake project for 
kodi-inputstream-adaptive is instantiated correctly,
but the external project for embedded Bento4 is not. I encountered the same 
issue with libdate-tz in src:kodi, but there
I ended up building libdate-tz prior to configuring Kodi build. I think we can 
either ask CMake to generate a toolchain file
or apply your patch (yet I'd pass only a toolchain file if its specified).

Anyway, thanks for the investigation!

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1000113: kodi: depends on obsolete pcre3 library

2023-07-05 Thread Vasyl Gello
Dear Nicholas,

Yes I definitely see the bug. However, Kodi extensively uses pcrecpp and the 
only replacement I see for pcre2 is jpcre2 [1]
There is an ITP bug about it since 2017 but no package.

Matthew, from your experience, is jpcre2 the only C++ wrapper for pcre2 or 
there is something more recommended / maintainable?
I did the search but found only jpcre2.

[1] https://github.com/jpcre2/jpcre2

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1040593: kodi: CVE-2023-30207

2023-07-07 Thread Vasyl Gello
Control: fixed -1 2:20.0~rc2+dfsg-2

Dear Moritz,

Thanks for the report! I fixed it proactively back in 20.0~rc2+dfsg-2 so only 
oldstable and oldstable-bpo are affected.
I will upload the backport from bookworm to bullseye-bpo soon.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1016925: Re: Bug#1016925: kodi: Video playback not working in latest version of kodi

2022-09-21 Thread Vasyl Gello
Dear Alban,

> Maybe there is no way out of reverting the commit upstream ?

I got the private message from James on how to fix that issue however Alwin 
have not managed to fix it yet.
I have to change hotels because of situation around Ukraine, thus I have very 
limited time.

I can try building the latest Kodi from Debian in the next few days but I can 
not 100% guarantee I craft the fix
for the issue in question.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1020452: kodi: 20 Nexus with upstream/Debian libdvdnav4 6.1.1 does not work - call to undefined functions

2022-09-21 Thread Vasyl Gello
Hi Alban,

Do you mean the currently available Kodi stopped working after update or the 
one you built from source?
libdvdnav patches were upstreamed by enen92 and some of these were accepted.
We just need to check which patches in the debian folder are still relevant.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1020452: kodi: 20 Nexus with upstream/Debian libdvdnav4 6.1.1 does not work - call to undefined functions

2022-09-21 Thread Vasyl Gello
> Do you mean the currently available Kodi stopped working after update or the 
> one you built from source?

P.S: Recently BTS reports started dropping into spam so I had to double-check 
it before replying the second email.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1020452: kodi: 20 Nexus with upstream/Debian libdvdnav4 6.1.1 does not work - call to undefined functions

2022-09-23 Thread Vasyl Gello
Dear Alban,

Thanks for the PRs! Let me check all them tonight.
Just FYI, to prepare release there will be some extra work on my side (i.e 
rebase cdatetime patchset upstream
and check if ffmpeg thumbnailer code also works with 5.1.1).

I dont have any DVDs at hand so I will need you to be my tester :)
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#993806: Fwd: Bug#993806: kodi: No audio on DVD playback, AC3 Support

2022-10-04 Thread Vasyl Gello
Dear colleagues,

I have a monthly break in the travels and I am going to package Alpha3/4 and 
sort the issues spotted by all of you.
Please prepare your 19.4 profile backups before testing 20. There will be 
probably several rounds of unofficial builds
signed with my GPG key that will be replaced by official upload once the bugs 
are fixed.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1027913: kodi: FTBFS in bookworm (undeclared build-dependency on tzdata)

2023-01-04 Thread Vasyl Gello
Control: reassign -1 howardhinnant-date 3.0.1+ds-3
Control: retitle -1 howardhinnant-date must runtime-depend on tzdata
Control: affects -1 = kodi

Dear Santiago,

Thanks for the bug report! The "discover_tz_dir" function is directly not used 
by Kodi
and is part of howardhinnant-date. I looked through d/control of 
howardhinnant-date
and it appears that libhowardhinnant-tz3 must explicitly depend on tzdata just 
like
the source package build-depends on it.

I can craft the Salsa MR if Andrea wants me to do that.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1023848: kodi-pvr-hts: Packet requires kodi-api-pvr but is not available in sid

2022-11-11 Thread Vasyl Gello
Hi Leela,

To resolve this I will need to upload src:kodi once more to fix an overlooked 
issue breaking builds on non-x86 platforms and then, after it gets built for 
all arches, upload the addons again. Mattia might help me early next week with 
it, because my status (Debian Contributor) does not allow me uploading packages 
directly.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1023848: kodi-pvr-hts: Packet requires kodi-api-pvr but is not available in sid

2022-11-15 Thread Vasyl Gello
Control: close -1

Hi Leela,

The new versions of addons are uploaded to sid and will be built overnight.
I am closing this bug in hope the api version mismatch is now resolved.

Please re-open this bug if it is not the case!

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1034430: kodi-inputstream-adaptive: crash when resuming video

2023-04-14 Thread Vasyl Gello
Hi David!

Thanks for the report!
Can you please send me specific playlist used to reproduce the bug in private 
messages?

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1027903: Co-maintainer access

2023-01-22 Thread Vasyl Gello
Hi Jonathan!

Thanks for packaging this one!

Is it OK for you to move the Salsa repo to of kodi-game-libretro
to  https://salsa.debian.org/multimedia-team/kodi-media-center ?
Then all Kodi stuff will be in one place :)

If you dont want to move it, please grant me the co-maintainer
access so I can keep the addon in sync with all others.

Cheers!

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1027903: Co-maintainer access

2023-01-22 Thread Vasyl Gello
Hi Jonathan,

My Salsa username is basilgello (as in nm.d.o)

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1028434: kodi: FTBFS in bullseye (fatal error: date/tz.h: No such file or directory)

2023-01-26 Thread Vasyl Gello
Hi Alban,

bullseye-proposed-updates needs 19.5 while bullseye-backports needs 20.0 (and 
corresponding set of addons!)
19.5 will be different from 19.4 currently in bullseye-backports because we can 
not introduce new binary packages into
anything that is frozen. Doing 19.5 is on my plans for a month but I had to 
package 20.0 first.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1030890: libwebm: Provide additional headers to alllow building aom with the system libwebm

2023-02-14 Thread Vasyl Gello
Hi Vladimir,

Thanks for the patch!

I have not built it yet, but from the debdiff I see it only adds symbols, not 
removes them?
If yes, I think we can accept it. Removing symbols would need a transition 
which is no-go
at this stage of bookworm freeze.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1031975: kodi: Windowed kodi takes wrong size when run under KDE Plasma Wayland with fractional scaling

2023-02-26 Thread Vasyl Gello
Hi Mark!

So the fractional scaling doubles each dimension of the window on next start?

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1032208: ITP: python-aiohttp-retry -- Simple aiohttp retry client

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-aiohttp-retry
  Version : 2.8.3
  Upstream Author : Dmitry Inyutin 
* URL : https://github.com/inyutin/aiohttp_retry
* License : MIT
  Programming Lang: Python
  Description : Simple aiohttp retry client

This package provides aiohttp-retry - the python3 library extending
aiohttp with retry support.

Bug#1032209: ITP: python-linesep -- Python3 library for manipulation with lines with separators

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-linesep
  Version : 0.5.0
  Upstream Author : John Thorvald Wodder II 
* URL : https://linesep.readthedocs.org/
* License : MIT
  Programming Lang: Python
  Description : Python3 library for manipulation with lines with separators

linesep provides basic functions & classes for reading, writing, splitting,
& joining text with custom separators that can occur either before, between, or
after the segments they separate

Bug#1032211: ITP: python-outdated -- Check if a version of a PyPI package is outdated

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko , Vasyl Gello 

Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-outdated
  Version : 0.2.2
  Upstream Author : Alex Hall 
* URL : https://github.com/alexmojaki/outdated
* License : MIT
  Programming Lang: Python
  Description : Check if a version of a PyPI package is outdated

This is a mini-library which, given a package name and a version,
checks if it's the latest version available on PyPI.

It does not check which version of package is actually installed,
but only checks if the provided version string of the given package
is latest or not.

Bug#1032210: ITP: python-methodtools -- Python3 library expanding standard functools to methods

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-methodtools
  Version : 0.4.7
  Upstream Author : Jeong YunWon 
* URL : https://methodtools.readthedocs.org/
* License : BSD-2-clause
  Programming Lang: Python
  Description : Python3 library expanding standard functools to methods

Expand functools features to methods, classmethods, staticmethods
and even for (unofficial) hybrid methods.

For now, methodtools only provides `methodtools.lru_cache`.

Bug#1032212: ITP: python-wirerope -- Python3 library for manipulation with methods

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-wirerope
  Version : 0.4.7
  Upstream Author : Jeong YunWon 
* URL : https://wirerope.readthedocs.org/
* License : BSD-2-clause
  Programming Lang: Python
  Description : Python3 library for manipulation with methods

It turns functions and methods into fully controllable object

Used in conjunction with methodtools.

Bug#1032214: ITP: python-www-authenticate -- Parser for WWW-Authentication headers for Python 3

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko , Vasyl Gello 

Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-www-authenticate
  Version : 0.9.2
  Upstream Author : Alexandre Dutton 
* URL : https://github.com/alexsdutton/www-authenticate
* License : BSD-3-clause
  Programming Lang: Python
  Description : Parser for WWW-Authentication headers for Python 3

This Python 3 library parses various WWW-Authenticate headers
including ones emitted by servers not conformant to RFCs.

Bug#1032213: ITP: python-wsgidav -- Generic and extendable WebDAV server

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: python-wsgidav
  Version : 4.2.0
  Upstream Author : Martin Wendt 
* URL : https://wsgidav.readthedocs.org/
* License : MIT
  Programming Lang: Python
  Description : Generic and extendable WebDAV server

WsgiDAV is a stand-alone WebDAV server with SSL support,
that can be installed and run as Python command line script
on Linux, OSX, and Windows

Bug#1032226: ITP: datalad-next -- Preview functionaity extension for DataLad

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: 
Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: datalad-next
  Version : 1.0.0~beta1
  Upstream Author : DataLad Project Authors
* URL : https://datalad-gooey.rtfd.org
* License : MIT
  Programming Lang: Python
  Description : Preview functionaity extension for DataLad

This extension provides the preview functionality extension
for DataLad (http://datalad.org).

It will eventually be merged into core DataLad codebase

Bug#1032228: ITP: datalad-fuse -- User-mode filesystem DataLad extension

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: 
Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: datalad-fuse
  Version : 0.4.2
  Upstream Author : DataLad Project Authors
* URL : https://datalad-fuse.rtfd.org
* License : MIT
  Programming Lang: Python
  Description : User-mode filesystem DataLad extension

This extension provides filesystems in userspace (FUSE) extension
for DataLad (http://datalad.org)

Bug#1032229: ITP: datalad-gooey -- Simple Graphical User Interface (GUI) for DataLad

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: 
Yaroslav Halchenko ,
Vasyl Gello 
Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: datalad-gooey
  Version : 0.2.0
  Upstream Author : DataLad Project Authors
* URL : https://datalad-gooey.rtfd.org
* License : MIT
  Programming Lang: Python
  Description : Simple Graphical User Interface (GUI) for DataLad

This extension provides a graphical user interface (GUI)
for DataLad (http://datalad.org).

It is specifically aiming at making key data management tasks more accessible
and more convenient, without requiring to become familiar with the command line.

This simplified interface to DataLad is built on a foundation that is capable
of providing graphical user interfaces for any DataLad command, including those
provided by extension packages. Moreover, extension packages can even provide
their own GUI suites, by mixing and tuning a custom set of commands and
parameters.

To try it out, install this package, and run `datalad gooey`.

Bug#1032230: ITP: datalad-deprecated -- DataLad extension for phased-out functionality

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko , Vasyl Gello 

Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: datalad-deprecated
  Version : 0.2.8
  Upstream Author : DataLad Project Authors
* URL : https://datalad-deprecated.rtfd.org
* License : MIT
  Programming Lang: Python
  Description : DataLad extension for phased-out functionality

This extension provides deprecated modules for DataLad (https://datalad.org)
like web interface running on https://datasets.datalad.org

Bug#1032231: ITP: datalad-deprecated -- DataLad extension for phased-out functionality

2023-03-01 Thread Vasyl Gello
Package: wnpp
Owner: Yaroslav Halchenko , Vasyl Gello 

Severity: wishlist
X-Debbugs-CC: debian-de...@lists.debian.org

* Package name: datalad-deprecated
  Version : 0.2.8
  Upstream Author : DataLad Project Authors
* URL : https://datalad-deprecated.rtfd.org
* License : MIT
  Programming Lang: Python
  Description : DataLad extension for phased-out functionality

This extension provides deprecated modules for DataLad (https://datalad.org)
like web interface running on https://datasets.datalad.org

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1054463: kodi: FTBFS: add support for loongarch64

2023-10-30 Thread Vasyl Gello
Hi Dandan,

I approved the upstream PR. It will be merged before 21.0~beta2. And I will 
upload 21.0~beta2 to experimental when it comes.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1054463: kodi: FTBFS: add support for loongarch64

2023-10-24 Thread Vasyl Gello
Dear colleagues,

Thanks for the patch and yes it should be upstreamed.

One question: is there a perspective for anything TV-related poweted by 
loongarch64?
If one can build a TV box on this platform, we should mention that because some 
Kodi teammates argued to me in the past that I should not bloat the platform 
code with platforms no user would run Kodi on. To minimize this friction, lets 
mention TV boxes are possible with that CPU :)


-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1054463: kodi: FTBFS: add support for loongarch64

2023-10-24 Thread Vasyl Gello
Hi Adrian,

>That's not really a convincing argument. Kodi has build support for various 
>POWER targets and
>even IBM zSeries. I don't think we will ever see a TV box with a mainframe CPU 
>in it, will we?
>
>FWIW, I think the changes required are so minimal that "bloat" is not really 
>an argument here.
>
>It's an excuse.

You should not convince me - I keep adding architectures as needed :)
I just mentioned what concerns some other people may have (and had in the past).

>
>And, while we're at it, we should also add support for mips64el.

Yep, and from upstream PR I see the includes are not touched.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1054463: kodi: FTBFS: add support for loongarch64

2023-10-24 Thread Vasyl Gello
Hi Dandan,

Please ensure you have arch-specific constants in include files fixed like 
here: 
https://github.com/xbmc/xbmc/commit/69611c8fa937800d1c5d7897e798d56d770d7d3c

Your upstream PR touches only system info display.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1018203: kodi-inputstream-adaptive: FTBFS on ppc64el (regression in endian detection)

2022-08-26 Thread Vasyl Gello
Hi Steve!

Thanks for reminding me on this!

I will upstream the patch and get a new tag along with security fixes for 
embedded Bento4 fork.
After that, we can upload new version. Then the only thing it takes is to 
upload new release to unstable.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1019190: Iptvsimple addon is not shown under addons

2022-09-05 Thread Vasyl Gello
Hi!

Does the addon not prompt to configure itself on first Kodi run after 
iptvsimple is installed?

Also, you can just replace m3u and xml playlists and epg in 
~/.kodi/userdata/addon_data/pvr.iptvsimple/ via cronscript
or use IPTV Merge / PseudoTV Live to combine multiple playlists into single one.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

5 вересня 2022 р. 08:40:33 UTC, mYnDstrEAm  
написав(-ла):
>Package: kodi-pvr-iptvsimple
>Version: 19.1.0
>
>The addon is not shown in the addons. This is a problem because you need to 
>configure it before TV streaming works and currently need to update the 
>configs from time to time so that it keeps working.
>
>It can only be found by going to Addons->User addons->PVR clients->IPTV simple
>
>It should show like all the other addons under Addons with an icon that you 
>can click on (or press c) to change its settings.
>


Bug#1019190: Iptvsimple addon is not shown under addons

2022-09-05 Thread Vasyl Gello
I think I should check the issue against testing, where 20.x is packaged. Or 
you can check it in VM or container if you want.

Anyway, I am in the midst of IFA 2022 expo so I will need minimum 2-3 days to 
settle things back on track.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

5 вересня 2022 р. 18:49:59 UTC, mYnDstrEAm  
написав(-ла):
>I don't remember but I don't think so and even if it did, the files/URLs 
>needed to get changed.
>
>The addon should show under addons in any case (except if it's intentionally 
>hidden via one of its options). If it's not I'm not sure if this is an issue 
>with the Debian packaged version or with IPTVSimple itself (if it is I would 
>file the issue there instead).
>
>I don't know what IPTV Merge / PseudoTV Live is and where to get that from and 
>more importantly I don't think most Kodi users would know that or about them 
>either. A problem with IPTV Simple is that EPG info is missing for some 
>channels, I don't know if this can be solved by merging files somehow...more 
>info at https://github.com/kodi-pvr/pvr.iptvsimple/issues/640
>


Bug#1000113: kodi: depends on obsolete pcre3 library

2024-01-07 Thread Vasyl Gello
Hi Yavor,

Thanks for the patch! Greatly appreciated!!!

Upstream we discussed the pcre PR and there is an old branch porting some stuff 
to std::regex.
I have checked that branch but some problems remained.

I can test your patch because I am both the user and the maintainer as you 
requested.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1060672: kodi: High CPU usage even when idle

2024-01-12 Thread Vasyl Gello
Hi Giuseppe,

Thanks for report! The reportbug contents was probably truncated, as I see
no information about hardware, architecture etc.

What is your device specs?

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#1060672: kodi: High CPU usage even when idle

2024-01-19 Thread Vasyl Gello
Control: forwarded -1 https://github.com/xbmc/xbmc/issues/24539

Hello Giuseppe,

I opened an issue [1] and hope to resolve your issue with there.

[1] https://github.com/xbmc/xbmc/issues/24539

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#985942: kodi: Cannot shutdown computer from kodi

2021-05-30 Thread Vasyl Gello
Control: close -1

Dear colleagues,

I am closing this bug as it was a 3rd party Kodi addon causing this.
Feel free to re-open it if new clues appear.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988615: unblock: kodi-inputstream-adaptive/2.6.14+ds1-1

2021-05-30 Thread Vasyl Gello
Hi Sebastian!

Please check this pending unblock request as we need it to close #988862.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988611: unblock: kodi/2:19.1+dfsg1-1

2021-05-30 Thread Vasyl Gello
Package: release.debian.org
Followup-For: Bug #988611
X-Debbugs-Cc: mat...@debian.org, sramac...@debian.org

I also prepared (but have not uploaded to Salsa yet) the 2:19.1+dfsg2-1 that 
uses
the same embedded copies that were used in 2:19.0+dfsg1-1 that is currently in
bullseye.

Filtered diff from 2:19.0+dfsg1-2 to 2:19.1+dfsg2-1 is attached with the 
following
filtrdiff options:

filterdiff kodi_19.0+dfsg1-2_19.1+dfsg2-1.diff \
-x "*/addons/*.xml" \
-x "*/cmake/scripts/windows/*" \
-x "*/docs/*" \
-x "*/Changelog" \
-x "*/Makefile.in" \
-x "*/*.m4" \
-x "*/configure" \
-x "*/msvc/*" \
-x "*/media/*" \
-x "*/system/*" \
-x "*/tools/buildsteps/windows/*" \
-x "*/xbmc/cores/VideoPlayer/VideoRenderers/windows/*" \
-x "*/xbmc/windowing/win10/*" \
-x "*/xbmc/windowing/windows/*" \
1>kodi_19.0+dfsg1-2_19.1+dfsg2-1.filtered.diff

Regards,
Vasyl


kodi_19.0+dfsg1-2_19.1+dfsg2-1.filtered.diff.gz
Description: application/gzip


Bug#988611: unblock: kodi/2:19.1+dfsg2-1

2021-06-06 Thread Vasyl Gello
Package: release.debian.org
Followup-For: Bug #988611
X-Debbugs-Cc: davebl...@kodi.tv, phunkyf...@kodi.tv

Hi Sebastian,

>Unfortunately your descriptions of the changes in kodi (and all the
>plugins) are very terse and only highlight changes that sound like they
>would fit the freeze policy. The other changes -- like the
>reimplementation of kodi's logging which is a few hundred lines if not
>more or newly added features -- are swept under the rug. We do not have
>the time to dig into upstream's decision to include those changes and the
>associated risks. If you as maintainer think that it's worth having
>these changes in bullseye, please help us reviewing the changes by
>explaining why the changes are needed and the potential regressions
>they could introduce.

Sorry for ponging this late! Let me answer the question as per bullseye FAQ 
([1]),
mentioned in the #debian-multimedia channel.

1. Is this a targeted bug fix release, and how does that show?

Yes, it is a bug fix release that addresses various bugs reported to Kodi
upstream and backported from current development branch (master) to stable
release (Matrix). As per Kodi's release policy, only changes tagged with
'Type: Backport' get merged into stable branches.

The 19.1 bugfix release features 89 commits and 80 PRs are closed in
'19.1-Matrix' milestone [2]:

$ git log --oneline --no-merges 19.0-Matrix..19.1-Matrix | wc -l
89

The total number of commits in the PRs counted by script below is 90:

# ===
#!/bin/sh
TOTAL_COUNT=0
while read _1
do
COMMIT_COUNT=$(gh api "repos/xbmc/xbmc/pulls/$_1/commits" | jq length)
TOTAL_COUNT=$(( TOTAL_COUNT + COMMIT_COUNT ))
#echo "$_1: $COMMIT_COUNT"
gh api "repos/xbmc/xbmc/pulls/$_1/commits" | jq ".[].commit.message" | 
sed 's/\\n.*"$/"/' | while read _2
do
echo "- $_2"
done
done <<.p
$(gh pr list \
--limit 100 \
--search 'milestone:"Matrix 19.1"' \
--state merged -R xbmc/xbmc \
--json number |
jq -r '.[].number')
.p

echo "---"
echo "Total commit count = $TOTAL_COUNT"
# ===

The missing commit is:

"[Subtitles][Plugins] Do not browse plugin directory when browsing for 
subtitles"

which has not been merged due to reasons unknown to me. This proves there are
only bug and code quality fixes in the point release.

2. What are the risks of the changes for the quality of the Debian release?

Given that every upstream change must pass the CI pipeline for every supported
architecture to be merged, and the changes were tested by bug reporters and
Kodi users on the forums, I see no significant risks for Debian release quality.

3. Is there a policy that describes what upstream considers acceptable for this
   upstream release?

Yes, see the Kodi official wiki page [3]. Also, there are unwritten rules that
are considered the rule of thumb in merging the fixes.

4. Does that policy align with our bug severity important or higher?

The perception of bugs cab be clearly mapped from Debian to Kodi and vice versa.

For example, the 18.9 point release (the last bugfix release of now old-stable
18.x "Leia" branch) was caused by Cloudflare's decision to break Kodi's SSL
over HTTP/2 implementation. Such a bug would get an RC status in Debian if 
reported.

5. Does upstream test thoroughly?

Yes. First of all, the fix must build at the committer's machine (see [3]). 
Then.
code owners and other members of Kodi team review the changes and make sure the
fix does not introduce new regressions. Then, the bug reporters download the
build artifacts produced by Jenkins and confirm the issue is resolved. Finally,
once the PR is approved, the final run of Jenkins builds ensures all 
architectures
pass the build smoothly and the change gets merged into master. Another build 
run
is done for stable backports.

6. Has this package seen new upstream version uploads to stable in the past to
   facilitate security support?

Yes, 17.5 fixed two CVEs and was uploaded into stretch, if my memory still 
serves
me.

7. Look at the diff. If it's long, you probably need a targeted fix.
8. Look at the diff. If there's a number of changes not relevant for Debian,
   you probably need a targeted fix.
9. Look at the diff. If there something in there that is difficult to explain,
   but not directly related to the (RC or important) bugs you are fixing,
   you probably need a targeted fix.

The most controversial change here is removal of 'CStaticLoggerBase' class.
The reasoning behind the change is explained at [4]:

"Yes please do, we will be working with log files from Matrix for some time
to come so may as well have any benifits." (c) Dave Blake. I am adding Dave
to the converation in case the question arises whether it is OK to discard
changes approved by upstream.

The rest of changes are targeted fixes that I already tested manually and
via Podman container with (sort of) autopkgtest. This work is done by me to
ensure release quality at Debian, ap

Bug#988616: release.debian.org: kodi-inputstream-ffmpegdirect/1.21.3+ds1-1

2021-06-07 Thread Vasyl Gello
Package: release.debian.org
Followup-For: Bug #988616

Hi Sebastian,

I made a new release under a 'bullseye' branch at Salsa repo, with backported
patches excluding ffmpeg 4.4 integration. The debdiff attached.

Cheers,
Vasyl
diff -Nru kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/changelog 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/changelog
--- kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/changelog   2021-02-18 
23:38:47.0 +
+++ kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/changelog   2021-06-07 
06:45:39.0 +
@@ -1,3 +1,11 @@
+kodi-inputstream-ffmpegdirect (1.19.2+ds1-2) UNRELEASED; urgency=medium
+
+  * Branch out bullseye
+  * Backport fixes into bullseye
+  * Fix link to github release tarball
+
+ -- Vasyl Gello   Mon, 07 Jun 2021 06:45:39 +
+
 kodi-inputstream-ffmpegdirect (1.19.2+ds1-1) unstable; urgency=medium
 
   * New upstream version 1.19.2+ds1
diff -Nru kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/control 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/control
--- kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/control 2021-02-18 
23:38:47.0 +
+++ kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/control 2021-06-07 
06:45:39.0 +
@@ -22,7 +22,7 @@
 Standards-Version: 4.5.1
 Rules-Requires-Root: no
 Vcs-Browser: 
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi-inputstream-ffmpegdirect
-Vcs-Git: 
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi-inputstream-ffmpegdirect.git
+Vcs-Git: 
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi-inputstream-ffmpegdirect.git
 -b bullseye
 Homepage: https://kodi.tv/
 
 Package: kodi-inputstream-ffmpegdirect
diff -Nru kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/gbp.conf 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/gbp.conf
--- kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/gbp.conf2021-02-18 
23:38:47.0 +
+++ kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/gbp.conf2021-06-07 
06:45:39.0 +
@@ -1,4 +1,5 @@
 # Configuration file for git-buildpackage and friends
 
 [DEFAULT]
+debian-branch = bullseye
 filter = */.git*
diff -Nru 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/patches/bullseye-freeze/-move-verbose-playback-timeshift-logging-to-debug-lev.patch
 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/patches/bullseye-freeze/-move-verbose-playback-timeshift-logging-to-debug-lev.patch
--- 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/patches/bullseye-freeze/-move-verbose-playback-timeshift-logging-to-debug-lev.patch
 1970-01-01 00:00:00.0 +
+++ 
kodi-inputstream-ffmpegdirect-1.19.2+ds1/debian/patches/bullseye-freeze/-move-verbose-playback-timeshift-logging-to-debug-lev.patch
 2021-06-07 06:45:39.0 +
@@ -0,0 +1,66 @@
+From 972b9033434a71b218d6a51cd7375a8e20c04d79 Mon Sep 17 00:00:00 2001
+From: phunkyfish 
+Date: Thu, 18 Mar 2021 08:56:39 +
+Subject: [PATCH 01/19] move verbose playback timeshift logging to debug level
+
+---
+ src/stream/TimeshiftBuffer.cpp  | 8 
+ src/stream/TimeshiftSegment.cpp | 2 +-
+ 2 files changed, 5 insertions(+), 5 deletions(-)
+
+diff --git a/src/stream/TimeshiftBuffer.cpp b/src/stream/TimeshiftBuffer.cpp
+index 3128ef8..1167924 100644
+--- a/src/stream/TimeshiftBuffer.cpp
 b/src/stream/TimeshiftBuffer.cpp
+@@ -128,7 +128,7 @@ void TimeshiftBuffer::AddPacket(DEMUX_PACKET* packet)
+   std::shared_ptr m_previousWriteSegment = 
m_writeSegment;
+   m_previousWriteSegment->MarkAsComplete();
+ 
+-  Log(LOGLEVEL_INFO, "%s - Writing new segment - seconds: %d, last seg 
seconds: %d, last seg packet count: %d, new seg index: %d, pts %.2f, dts: %.2f, 
pts sec: %.0f, dts sec: %.0f",
++  Log(LOGLEVEL_DEBUG, "%s - Writing new segment - seconds: %d, last seg 
seconds: %d, last seg packet count: %d, new seg index: %d, pts %.2f, dts: %.2f, 
pts sec: %.0f, dts sec: %.0f",
+  __FUNCTION__, secondsSinceStart, 
m_lastSegmentSecondsSinceStart, m_previousWriteSegment->GetPacketCount(), 
m_currentSegmentIndex,
+  packet->pts, packet->dts, packet->pts / 
STREAM_TIME_BASE, packet->dts / STREAM_TIME_BASE);
+ 
+@@ -176,7 +176,7 @@ void 
TimeshiftBuffer::RemoveOldestInMemoryAndOnDiskSegments()
+   if (kodi::vfs::FileExists(m_timeshiftBufferPath + "/" + 
segmentFilename))
+   {
+ kodi::vfs::DeleteFile(m_timeshiftBufferPath + "/" + segmentFilename);
+-Log(LOGLEVEL_INFO, "%s - Removed oldest on disk segment with ID: %d - 
currentDemuxTimeSeconds: %d, min on disk time: %d", __FUNCTION__, 
m_earliestOnDiskSegmentId, m_currentDemuxTimeIndex, m_minOnDiskSeekTimeIndex);
++Log(LOGLEVEL_DEBUG, "%s - Removed oldest on disk segment with ID: %d 
- currentDemuxTimeSeconds: %d, min on disk time: %d", __FUNCTION__, 
m_earliestOnDiskSegmentId,

Bug#988618: unblock: kodi-pvr-iptvsimple/7.6.5+ds1-1

2021-06-07 Thread Vasyl Gello
Package: release.debian.org
Followup-For: Bug #988618
X-Debbugs-Cc: phunkyf...@kodi.tv

Hi Sebastian,

> The new version also introduces some new features and is not a targeted
> bug fix release. Please cherry pick the fixes if you deem them
> important.

You are right in the part that this upload is not *solely* a bugfix release.
Unlike Kodi itself, Kodi add-ons may implement new features per release policy.
The only requirement is not to introduce breaking changes in release branch
targeting current stable Kodi version (19.x). Branches targeting old-stable
Kodi version (18.x) receive only targeted fixes for security & grave functional
issues.

However, as a user of PVR IPTVSimple, I insist that it is better for an end-user
to have this release in bullseye rather not to have.

Let's consider the changelog for the release chain (omitting commits that touch
only version in addon XML manifest and the changelog file):

> v7.6.5:
> Allow embedded commas in channel name in M3U

This change has numerously been asked on Kodi forums in the past years.
Plus, I had to strip excessive commas from Divan.TV channel names not to break
M3U parser for my HTPC.

> v7.6.4:
> Only use Local logo location if file is relative
> Add string initialisation from macros as some linux fail to compile without it

This is a low-risk change because the release on Debian compiles without issues.
The logo commit is a fix for buggy logic for *some* users who provide custom 
logo
packs for their IPTV channels.

> v7.6.2:
> Always load EPG data if we prefer XMLTV logos or catchup is enabled
> Allow catchup correction (timezone shift) when live URLs have catchup 
> placeholders

This commit is another correction for a previously buggy behavior that resulted 
in
irregular updates of EPG data. The PVR timeshift mode introduced in Kodi 19.0 
requires
daily update of EPG info, and this commit ensures the update takes place.

> v7.6.1:
> Update readme
> update text for path type option
> Allow ignoring M3U logos when using local logo path

This is a requested feature correcting previously buggy behavior (see [1]).
The readme part is a documentation fix reflecting the new logic.

> v7.6.0:
> Support xeev XC catchup prefixes
> Add setting for catchup correction
> Disable other catchup settings if catched is not enabled
> Allow flusonnic channel ids containing forward slashes
> Support url-tvg in M3U header in addition to x-tvg-url
> Add support for XZ compression of XMLTV data

This was requested in Kodi reddit group (if my memory serves me well.
because I can not find the exact post).

> v7.5.1:
> Ensure channel's catchup window is used instead of value from settings
> Treat 'tvg-rec' catchup tag like the siptv 'timeshift' tag
> Fix typo

This is a correction to timeshift ('catchup') code making the addon to
recognize M3U 'tvg-rec' tag supplying the path to TV archive stream.

> v7.5.0:
> Allow setting scope for channels using catchup mode setting to enable 
> overriding
> Support sub channel numbers

This was requested in [2].

Given that I use IPTVSimple daily on testing, I hope the release gets accepted 
as
is.

I am also CC'ing Ross Nicholson aka phunkyfish so he is aware about the matter.

Cheers, 
vasyl

---

[1] https://github.com/kodi-pvr/pvr.iptvsimple/issues/505
[2] https://github.com/kodi-pvr/pvr.iptvsimple/issues/467



Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-14 Thread Vasyl Gello
Source: kodi
Followup-For: Bug #989814

Control: forwarded -1 https://github.com/xbmc/xbmc/issues/19883

Hi Hakan!

I was able to reproduce the issue and forwarded it upstream.

It looks the problem manifests itself if the following conditions are met:

  * Turkish locale is generated on the system
  * It is also activated by means of Kodi's Turkish language addon,
or externally by means of LC_CTYPE, LANG or LC_ALL environment variables
pointing to `tr_TR.UTF-8`.

For me it is still unclear if it is XBT decompressor's fault or XML parser.
We will try to dig this problem away :)

Regards,
Vasyl

-- System Information:
Debian Release: 11.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-7-amd64 (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect



Bug#988618: unblock: kodi-pvr-iptvsimple/7.6.5+ds1-1

2021-06-18 Thread Vasyl Gello
Control: tag -1 -moreinfo

Hi Sebastian!

Hope this one can be unblocked, too :)
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988616: Acknowledgement (unblock: kodi-inputstream-ffmpegdirect/1.21.3+ds1-1)

2021-06-18 Thread Vasyl Gello
Control: tag -1 -moreinfo

Hi Sebastian!

Dropping moreinfo tag since bullseye branch with picked fixes in in Salsa for a 
week.

Cheers!

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#990083: kodi: Kodi hangs on transitions between playlist items with spinning wheel and no control

2021-06-19 Thread Vasyl Gello
Hi Fabrice!

Can you please attach the Kodi log with debug settings on? I need at least 
FFmpeg, Windowing, cURL, and NFS logs in separare log selectors.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-24 Thread Vasyl Gello
Package: kodi
Followup-For: Bug #989814
X-Debbugs-Cc: aure...@debian.org, mat...@debian.org, ha...@bayindir.org

Control: reassign -1 glibc
Control: retitle -1 Broken CTYPE in Turkish and Azeri UTF-8 locales
Control: severity -1 serious

Dear colleagues,

I was able to track down the issue reported in Kodi and unfortunately
it is a glibc / locales issue.

Specifically, all functions relying on LC_CTYPE set to Turkish or Azeri
UTF-8 locales (like 'tolower()' for example) produce incorrect results.

I linked the reproducer in Kodi upstream Github issue:
https://github.com/xbmc/xbmc/issues/19883#issuecomment-867911187

I upgraded the severity of the bug because the flawed behavior of locale
functions definitely needs further investigation.

Hakan, maybe you can shed somelight on what can be wrong with lower / upper
conversions in Turkish?


Sincerely,
Vasyl

-- System Information:
Debian Release: 11.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-7-amd64 (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages kodi depends on:
pn  kodi-bin   
pn  kodi-data  

Versions of packages kodi recommends:
pn  kodi-repository-kodi | kodi-repository  
pn  kodi-visualization-spectrum 

kodi suggests no packages.



Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-25 Thread Vasyl Gello
Hi Hakan!

> I’ll provide similar information to the official bugzilla today.

This means glibc is correct and my proposed fix for Kodi upstream ( 
https://github.com/xbmc/xbmc/pull/19905 ) is technically not…

Does it make sense to catch this edge case in the linked PR rather than just 
fall back into non-UTF-8 C locale if "Turkish I" problem is detected?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-25 Thread Vasyl Gello
Hi Hakan!

Can you please test this build with workaround I mentioned?

https://fex.net/s/vbdtzs6

Please test video library, search, PVR, whatever you use. It might break some 
things but let's see.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

25 червня 2021 р. 08:20:58 UTC, Vasyl Gello  
написав(-ла):
>Hi Hakan!
>
>> I’ll provide similar information to the official bugzilla today.
>
>This means glibc is correct and my proposed fix for Kodi upstream ( 
>https://github.com/xbmc/xbmc/pull/19905 ) is technically not…
>
>Does it make sense to catch this edge case in the linked PR rather than just 
>fall back into non-UTF-8 C locale if "Turkish I" problem is detected?
>-- 
>Vasyl Gello
>==
>Certified SolidWorks Expert
>
>Mob.:+380 (98) 465 66 77
>
>E-Mail: vasek.ge...@gmail.com
>
>Skype: vasek.gello
>==
>호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-27 Thread Vasyl Gello
Hi Hakan!

That's strange! Please send the debug Kodi log and pay attention if the string 
"19883" is present in it (that's the upstream ticket number).
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

27 червня 2021 р. 10:28:48 UTC, "Hakan Bayındır"  
написав(-ла):
>Hi Vasyl,
>
>First of all, thanks for all the hard work! I finally had time to install the 
>latest version you've sent. Unfortunately, the problem still persists. I have 
>the following packages installed related to kodi:
>
>- kodi 2:19.1+dfsg2-2~local amd64
>- kodi-bin 2:19.1+dfsg2-2~local amd64
>- kodi-data2:19.1+dfsg2-2~local all
>- kodi-repository-kodi 2:19.1+dfsg2-2~local all
>
>Note: I've just upgraded what is already installed using the files you've 
>sent, in order to keep the environment the same. Upgrading didn't pull in any 
>new dependencies.
>
>When I start kodi without any locale changes, which is as follows for 
>reference:
>
>LANG=tr_TR.UTF-8
>LANGUAGE=en_US
>LC_CTYPE="tr_TR.UTF-8"
>LC_NUMERIC="tr_TR.UTF-8"
>LC_TIME="tr_TR.UTF-8"
>LC_COLLATE="tr_TR.UTF-8"
>LC_MONETARY="tr_TR.UTF-8"
>LC_MESSAGES="tr_TR.UTF-8"
>LC_PAPER="tr_TR.UTF-8"
>LC_NAME="tr_TR.UTF-8"
>LC_ADDRESS="tr_TR.UTF-8"
>LC_TELEPHONE="tr_TR.UTF-8"
>LC_MEASUREMENT="tr_TR.UTF-8"
>LC_IDENTIFICATION="tr_TR.UTF-8"
>LC_ALL=
>
>I get the same empty screens for movies, TV Shows, Settings and many more. I 
>have attached a screenshot of the problem.
>
>Changing locale to en_US.UTF-8 for everything works around the problem like in 
>the previous versions. Since the problem is still reproducible, I was unable 
>to test further.
>
>Will try to get more detailed logs and send them,
>
>Best regards,
>
>Hakan
>
>On 26 Haziran 2021 Cumartesi 00:30:25 +03 Vasyl Gello wrote:
>> Hi Hakan!
>> 
>> Can you please test this build with workaround I mentioned?
>> 
>> https://fex.net/s/vbdtzs6
>> 
>> Please test video library, search, PVR, whatever you use. It might break
>> some things but let's see. --
>> Vasyl Gello
>> ==
>> Certified SolidWorks Expert
>> 
>> Mob.:+380 (98) 465 66 77
>> 
>> E-Mail: vasek.ge...@gmail.com
>> 
>> Skype: vasek.gello
>> ==
>> 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
>> 
>> 25 червня 2021 р. 08:20:58 UTC, Vasyl Gello  
>написав(-ла):
>> >Hi Hakan!
>> >
>> >> I’ll provide similar information to the official bugzilla today.
>> >
>> >This means glibc is correct and my proposed fix for Kodi upstream (
>> >https://github.com/xbmc/xbmc/pull/19905 ) is technically not…
>> >
>> >Does it make sense to catch this edge case in the linked PR rather than
>> >just fall back into non-UTF-8 C locale if "Turkish I" problem is detected?
>> >--
>> >Vasyl Gello
>> >==
>> >Certified SolidWorks Expert
>> >
>> >Mob.:+380 (98) 465 66 77
>> >
>> >E-Mail: vasek.ge...@gmail.com
>> >
>> >Skype: vasek.gello
>> >==
>> >호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다


Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-27 Thread Vasyl Gello
Hi Hakan!

Looks like I forgot adding "unset LANG LC_ALL LC_CTYPE" at the beginning of 
/usr/bin/kodi
With that line added, everything starts properly in both cases.

I am building a ~local1 but if you can, please quickly test the solution!
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#989814: kodi: Kodi UI breaks with tr_TR.UTF-8 charset.

2021-06-27 Thread Vasyl Gello
Hi Hakan!

Updated ~local1: https://fex.net/s/fvdo3rs
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#981188: kodi: Crash on playing some streams with recent tvheadend+ffmpeg+libva+radeonsi

2021-01-27 Thread Vasyl Gello
Package: kodi
Version: 19.0~rc1+20210119.8c761c4+dfsg1-1
Severity: important
X-Debbugs-Cc: sramac...@debian.org

Dear colleagues,

The Debian testing user reported a crash when playing some recorded streams with
19.0~rc1 that has migrated to testing today.

The log he provided ( https://pastebin.com/F49QHxnh ) shows an SSE2 misalign 
deep inside
radeonsi driver, invoked by ffmpeg and libva.

Sebastian, can you please look into the ffmpeg part? I do run 19.0 with ffmpeg 
4.3.1-6
compiled on buster/amd64 and I did not see such crashes since probably Debian 
jessie times.

Vasyl


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-64-generic (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages kodi depends on:
pn  kodi-bin   
pn  kodi-data  

Versions of packages kodi recommends:
pn  kodi-repository-kodi | kodi-repository  
pn  kodi-visualization-spectrum 

kodi suggests no packages.



Bug#981188: kodi: Crash on playing some streams with recent tvheadend+ffmpeg+libva+radeonsi

2021-01-27 Thread Vasyl Gello
Another relevant logfile is: https://pastebin.com/CFunEvWN

What I don't like that ffmpeg compains about unimplemented h264 slice encoding 
feature.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#981188: kodi: Crash on playing some streams with recent tvheadend+ffmpeg+libva+radeonsi

2021-01-27 Thread Vasyl Gello
Hi Andreas,

Can you please look at the radeonsi part of the stacktrace? Sebastian thinks it 
is related to mesa.

Vasyl

Bug#981188: kodi: Crash on playing some streams with recent tvheadend+ffmpeg+libva+radeonsi

2021-01-29 Thread Vasyl Gello
Hi Jurek!

Let's try downgrading ffmpeg, libva and mesa packages from Debian snapshot. 
When approximately did you notice bug manifested?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#914314: git-buildpackage: import-orig --uscan passes --symlink unconditionally

2021-02-01 Thread Vasyl Gello
Hi Ian!

> I read this report and I don't see any explanation for the RC status.
> As far as I can tell this is not a regression ?  And it doesn't seem
> likely that it causes unrecoverable data loss or the upload of badly
> corrupted packsges ?  And it only affects one aspect of gbp's
> functionality.

This is a regression that is easily fixable.
The problem is, I couls not reach Guido by email or push a request to his Git.
Should I attach the patch here with appropriate patch tag instead?

As for "it does not cause unrecoverable data loss" - yes, the loss is 
recoverable.
But what if you notice that an inappropriate tarball has been imported by a 
script
only when your CI pipeline fails? And the same wrong tarball poisoned ~10 repos
by the time you noticed it?

I raised the severity in hope Guido notices it and the new release gets rolled.
My intention is not to remove gbp from bullseye, definitely.

Adding Guido directly because my previous email semt from Gmail has never been
answered.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#914314: Re: git-buildpackage: import-orig --uscan passes --symlink unconditionally

2021-02-01 Thread Vasyl Gello
Hi Ian,

> You mean it works correctly in buster ?

Unfortunately, no. So it is a bug not a regression, you are right.

> Certainly.

Then I will just leave the patch here.

> I don't think this is really an appropriate way to use the "serious"
> severity.

OK, noted tgat. Thanks for pointing that!

> This seems a bit unfriendly to me.  Maybe Guido is busy right now.
> We're all volunteers here.  If you think you know how to fix the
> problem, you could propose to fix it yourself eg with an NMU, using
> the usual process.

Well, I might have misunderstood the Policy but isnt the NMU while maintainer 
is active
a kind of unfriendly takeover? I might misunderstand the Policy then!

If NMU is appropriate here, let me fix other bugs in gbp while Guido is busy.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

1 лютого 2021 р. 12:55:34 UTC, Ian Jackson  
написав(-ла):
>Vasyl Gello writes ("Re: git-buildpackage: import-orig --uscan passes 
>--symlink unconditionally"):
>> This is a regression that is easily fixable.
>
>You mean it works correctly in buster ?
>
>> Should I attach the patch here with appropriate patch tag instead?
>
>Certainly.
>
>> As for "it does not cause unrecoverable data loss" - yes, the loss
>> is recoverable.  But what if you notice that an inappropriate
>> tarball has been imported by a script only when your CI pipeline
>> fails? And the same wrong tarball poisoned ~10 repos by the time you
>> noticed it?
>
>I can see that this is a nuisance but I think it still does not
>warrant an RC bug.  Presumably some script can also fix up the bad git
>trees.
>
>> I raised the severity in hope Guido notices it and the new release
>> gets rolled.  My intention is not to remove gbp from bullseye,
>> definitely.
>
>I don't think this is really an appropriate way to use the "serious"
>severity.
>
>> Adding Guido directly because my previous email semt from Gmail has
>> never been answered.
>
>This seems a bit unfriendly to me.  Maybe Guido is busy right now.
>We're all volunteers here.  If you think you know how to fix the
>problem, you could propose to fix it yourself eg with an NMU, using
>the usual process.
>
>Thanks,
>Ian.
>



Bug#914314: Re: Re: git-buildpackage: import-orig --uscan passes --symlink unconditionally

2021-02-01 Thread Vasyl Gello
Hi Ian, Guido!

> I'm going to reply to your next part in general terms. I hope Guido will 
> agree with me.

Thanks for explanation! :) NMU looks not that scary thing for me!
There is no need for NMU since Guido is here, but noted for the future.

Guido, how is it best for you to review patches?

* Attaching to bugs
* Using Salsa cloned repo in my personal space

As for breakage, the best solution I see here is to introduce new gbp.conf 
parameter
like USCAN_SYMLINK={rename|symlink} plus check and warn the user if uscan's 
behavior
is overridden by environment variable somewhere.

What do you think? If the approach is fine, let me craft a PR!
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#981188: kodi: Crash on playing some streams with recent tvheadend+ffmpeg+libva+radeonsi

2021-02-02 Thread Vasyl Gello
Hi Jurek!

First of all, please make sure no deb-multimedia remnants exist. Also, can you 
please upload a recording to https://fex.net and send me a link privately by 
email? I will check it on my setup.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#981188: kodi: Crash on playing some streams with recent tvheadend+ffmpeg+libva+radeonsi

2021-02-07 Thread Vasyl Gello
Hi Jurek!

First of all, thanks for the test file! Stepping forward and backward via arrow 
keys (+10 / -10 seconds) works for me without crash.

The system is Debian bullseye reinstalled from scratch, GPU is AMD E-300 (HP 
635 laptop using radeonsi).
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#993377: kodi forget display video calibration after restart

2021-08-31 Thread Vasyl Gello
Hi Henning!

So basically, you apply video calibration settings and after Kodi restart the 
settings are reset to default?

Can you please post a screenshot of your settings so I can reproduce them in my 
lab?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#993806: kodi: No audio on DVD playback, AC3 Support

2021-09-06 Thread Vasyl Gello
Hi Aaron!

Can you please enable debugging of FFmpeg and capture Kodi log reproducing the 
issue?
I recall there was an issue described on Kodi forums, but I want to check once 
more against your log.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#993806: kodi: No audio on DVD playback, AC3 Support

2021-09-08 Thread Vasyl Gello
Hi Markus!

Yes, it is possible to add that patch for bookworm/sid.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988261: librsvg2-2: Please drop libcroco3 dependency on alpha, hppa, m68k, sh4, x32

2021-05-08 Thread Vasyl Gello
Package: librsvg2-2
Version: 2.40.20-3
Severity: important
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: jrt...@jrtc27.com, mat...@debian.org

Dear colleagues,

I encountered the gone dependency of lubrsvg2-2 on libcroco3 doing the test 
build
of Kodi 19.1 on x32. Please rebuild librsvg without libcroco3 on the ports.

Vasyl

-- System Information:
Debian Release: 11.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-72-generic (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages librsvg2-2 depends on:
ii  libc62.31-12
pn  libcairo-gobject2
pn  libcairo2
ii  libgcc-s110.2.1-6
pn  libgdk-pixbuf-2.0-0  
ii  libglib2.0-0 2.66.8-1
pn  libpango-1.0-0   
pn  libpangocairo-1.0-0  
ii  libxml2  2.9.10+dfsg-6.6

Versions of packages librsvg2-2 recommends:
pn  librsvg2-common  

Versions of packages librsvg2-2 suggests:
pn  librsvg2-bin  



Bug#988610: unblock: libwebm/1.0.0.28-1

2021-05-16 Thread Vasyl Gello
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: mat...@debian.org

Please unblock package libwebm

[ Reason ]

This is a bigfix release fixing several buffer overflows, finally
tagged after 5 years of upstream marinade.

[ Impact ]

Several flaws with security vulnerability potential will not be
addressed. However, no CVEs allocated to the date.

[ Tests ]

Automatic testsuite + mwnual checks by Kodi users (including myself)

[ Risks ]

This package is used primarily by kodi-inputstream-adaptive, so risk
is low.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

unblock libwebm/1.0.0.28-1
diff -Nru libwebm-1.0.0.27+git20201124.485fb67/build/cxx_flags.cmake 
libwebm-1.0.0.28/build/cxx_flags.cmake
--- libwebm-1.0.0.27+git20201124.485fb67/build/cxx_flags.cmake  2020-11-24 
23:40:20.0 +
+++ libwebm-1.0.0.28/build/cxx_flags.cmake  2021-04-23 23:34:08.0 
+
@@ -5,7 +5,6 @@
 ##  tree. An additional intellectual property rights grant can be found
 ##  in the file PATENTS.  All contributing project authors may
 ##  be found in the AUTHORS file in the root of the source tree.
-cmake_minimum_required(VERSION 3.2)
 
 include(CheckCXXCompilerFlag)
 
diff -Nru libwebm-1.0.0.27+git20201124.485fb67/build/msvc_runtime.cmake 
libwebm-1.0.0.28/build/msvc_runtime.cmake
--- libwebm-1.0.0.27+git20201124.485fb67/build/msvc_runtime.cmake   
2020-11-24 23:40:20.0 +
+++ libwebm-1.0.0.28/build/msvc_runtime.cmake   2021-04-23 23:34:08.0 
+
@@ -5,7 +5,6 @@
 ##  tree. An additional intellectual property rights grant can be found
 ##  in the file PATENTS.  All contributing project authors may
 ##  be found in the AUTHORS file in the root of the source tree.
-cmake_minimum_required(VERSION 2.8)
 
 if (MSVC)
   # CMake defaults to producing code linked to the DLL MSVC runtime. In libwebm
diff -Nru libwebm-1.0.0.27+git20201124.485fb67/CMakeLists.txt 
libwebm-1.0.0.28/CMakeLists.txt
--- libwebm-1.0.0.27+git20201124.485fb67/CMakeLists.txt 2020-11-24 
23:40:20.0 +
+++ libwebm-1.0.0.28/CMakeLists.txt 2021-04-23 23:34:08.0 +
@@ -25,7 +25,8 @@
 option(ENABLE_WERROR "Enable warnings as errors." OFF)
 option(ENABLE_WEBM_PARSER "Enables new parser API." OFF)
 
-if(WIN32)
+if(WIN32 OR CYGWIN OR MSYS)
+  # Allow use of rand_r() / fdopen() and other POSIX functions.
   require_cxx_flag_nomsvc("-std=gnu++11")
 else()
   require_cxx_flag_nomsvc("-std=c++11")
diff -Nru libwebm-1.0.0.27+git20201124.485fb67/CONTRIBUTING.md 
libwebm-1.0.0.28/CONTRIBUTING.md
--- libwebm-1.0.0.27+git20201124.485fb67/CONTRIBUTING.md1970-01-01 
00:00:00.0 +
+++ libwebm-1.0.0.28/CONTRIBUTING.md2021-04-23 23:34:08.0 +
@@ -0,0 +1,29 @@
+# How to Contribute
+
+We'd love to accept your patches and contributions to this project. There are
+just a few small guidelines you need to follow.
+
+## Contributor License Agreement
+
+Contributions to this project must be accompanied by a Contributor License
+Agreement. You (or your employer) retain the copyright to your contribution;
+this simply gives us permission to use and redistribute your contributions as
+part of the project. Head over to <https://cla.developers.google.com/> to see
+your current agreements on file or to sign a new one.
+
+You generally only need to submit a CLA once, so if you've already submitted 
one
+(even if it was for a different project), you probably don't need to do it
+again.
+
+## Code reviews
+
+All submissions, including submissions by project members, require review. We
+use a [Gerrit](https://www.gerritcodereview.com) instance hosted at
+https://chromium-review.googlesource.com for this purpose. See the
+[WebM Project 
page](https://www.webmproject.org/code/contribute/submitting-patches/)
+for additional details.
+
+## Community Guidelines
+
+This project follows
+[Google's Open Source Community 
Guidelines](https://opensource.google.com/conduct/).
diff -Nru libwebm-1.0.0.27+git20201124.485fb67/debian/changelog 
libwebm-1.0.0.28/debian/changelog
--- libwebm-1.0.0.27+git20201124.485fb67/debian/changelog   2021-01-21 
20:25:40.0 +
+++ libwebm-1.0.0.28/debian/changelog   2021-05-08 21:47:39.0 +
@@ -1,3 +1,11 @@
+libwebm (1.0.0.28-1) unstable; urgency=medium
+
+  * New upstream version 1.0.0.28
+  * Switch to git tags in d/watch
+  * Bump library version in patch
+
+ -- Vasyl Gello   Sat, 08 May 2021 21:47:39 +
+
 libwebm (1.0.0.27+git20201124.485fb67-2) unstable; urgency=medium
 
   * Remove duplicated inclusion of -lpthread and -latomic
diff -Nru 
libwebm-1.0.0.27+git20201124.485fb67/debian/patches/0003-Provide-SOVERSION.patch
 libwebm-1.0.0.28/debian/patches/0003-Provide-SOVERSION.p

Bug#988611: Acknowledgement (unblock: kodi/2:19.1+dfsg1-1)

2021-05-18 Thread Vasyl Gello
Dear colleagues,

As Sebastian pointed in #988615, let me expand why the package is an 
improvement for bullseye.

The 19.1 point release has 80 bug fixes 
(https://github.com/xbmc/xbmc/milestone/141?closed=1).
Most notable ones are:

* [Linux] Fix playback of optical DVDs
* [Linux] Fix text issues when turning on / off TVs
* [Music][Backport]Make MySQL native sorting functions more robust
* DNSNameCache: only use a reachable address listed by nmblookup (a critical 
functionality regression for Samba users!)
* [Backport][PVR][GUI] Channel manager does not rename backend channel when 
supported

Picking only these chains still results in ~80% of 19.0 -> 19.1 debdiff, so I 
expect approving the request as I tested it.

On Debian side, the release incorporates two Debian bug fixes and the fix for 
regression that smashed user input of date in PVR search box.
The latter bug was reported not via Debian but it took me several evenings to 
hunt down :)

The release is tested using amd64 / i386 LXC containers and no issues spotted 
so far.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988615: unblock: kodi-inputstream-adaptive/2.6.14+ds1-1

2021-05-18 Thread Vasyl Gello
Hi Sebastian!

> And which bugs does that fix? Security issues?

No security issues this time :) All the version bumps till 2.6.14 fix various 
HLS and DASH parsing errors, like:

#607  Fix Base Domain (fixes uri=/path/)
#606  [Dash] Append / to baseurl if required
#621  [Dash] Remove reliance on namespace for pssh and default_kid
#618  [DASH] Support ec-3 channel count 
(urn:mpeg:mpegB:cicp:ChannelConfiguration)
#645  [Dash] Default update_parameter to full if using SegmentTimeline

The PR#607 actually fixed the inabiloty to use the addon in my scenario (OTT 
Divan.TV over kodi-pvr-iptvsimple).
There are also many test fixes and code cleanup but end-users will not notice 
them (although I do as maintainer).

Cheers!
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988616: Acknowledgement (unblock: kodi-inputstream-ffmpegdirect/1.21.3+ds1-1)

2021-05-18 Thread Vasyl Gello
Dear colleagues,

Continuing the spotlight on fixes worth unblocking:

[1.19.4] Fix locking on EOF detection of terminating catchup stream
[1.21.2] Allow timezone shift when live URLs have placeholders

So many intermittent releases of Kodi addons exist because onecMR mostly equals 
one release :(
And there is not much I can do about it.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988617: Acknowledgement (unblock: kodi-pvr-hts/8.3.0+ds1-1)

2021-05-18 Thread Vasyl Gello
Fixes in this request:

* 8.2.3: Fixed: Timer settings: Add missing duplicate detection values
* 8.3.0: Fixed regular expression in search dialog
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988618: Acknowledgement (unblock: kodi-pvr-iptvsimple/7.6.5+ds1-1)

2021-05-18 Thread Vasyl Gello
Useful fixes and improvements in this version:

* Fix parsing of tvg-rec M3U tags
* Fix crash if remote XMLTV data is compressed with XZ
* Allow sub-channels
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988619: Acknowledgement (unblock: kodi-pvr-mythtv/7.3.1+ds1-1)

2021-05-18 Thread Vasyl Gello
This is a fixup release implementing seek feature.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988620: Acknowledgement (unblock: kodi-pvr-mediaportal-tvserver/8.1.2+ds1-1)

2021-05-18 Thread Vasyl Gello
This release drops p8-platform dependency (code cleanup) and fixes OOB read in 
MultiByteToWideChar.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988621: Acknowledgement (unblock: kodi-pvr-nextpvr/8.2.3+ds1-1)

2021-05-18 Thread Vasyl Gello
This release adds missing "break" statement (bugfix) and re-adds recording 
directories dropped in 7.4.0 (regression fix).
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988622: Acknowledgement (unblock: kodi-pvr-vuplus/7.4.3+ds1-1)

2021-05-18 Thread Vasyl Gello
This is mostly a code cleanup release fixing memory leaks viewing some still 
images.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988623: Acknowledgement (unblock: kodi-pvr-waipu/2.8.4+ds1-1)

2021-05-18 Thread Vasyl Gello
This release fixes re-authentication not happening, and also removes login 
credentials from Kodi log.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988624: Acknowledgement (unblock: kodi-pvr-zattoo/19.7.9+ds1-1)

2021-05-18 Thread Vasyl Gello
Thos paych release fixes handling of a changed EPG format returned by Zattoo 
OTT provider.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988625: Acknowledgement (unblock: kodi-vfs-libarchive/2.0.1+ds1-1)

2021-05-18 Thread Vasyl Gello
This is a maintenance release dropping ISO playback support because Kodi now 
plays ISO / BD natively to avoid unnecessary heisenbugs.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988261: librsvg2-2: Please drop libcroco3 dependency on alpha, hppa, m68k, sh4, x32

2021-05-18 Thread Vasyl Gello
Hi Simon!

I dig deeper in the missing dependency issue and I think the solution is to 
mask librsvg2 in ffmpeg build-deps for x32 just like it is masked for hppa.

Sebastian, what do you think? I can try building ffmpeg on x32 without librsvg2 
in order to build Kodi locally.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988862: kodi-inputstream-adaptive: Attempts to load incorrect stream URLs

2021-05-20 Thread Vasyl Gello
Control: block -1 by 988615

Hi Nick!

I prepared 2.6.14 on Salsa and it will be uploaded once Sebastian unblocks it 
for bullseye.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988611: unblock: kodi/2:19.1+dfsg1-1

2021-05-30 Thread Vasyl Gello
Package: release.debian.org
Followup-For: Bug #988611
X-Debbugs-Cc: sramac...@respighi.debian.org, sramac...@debian.org, 
mat...@debian.org

Control: retitle -1 unblock: kodi/2:19.0+dfsg1-2

Hi Sebastian,

I prepared 2:19.0+dfsg1-2 fixing only bugs reported to Debian.
Debdiff against 2:19.0+dfsg1-1 attached.

As I wrote in the private message to you earlier this week, I don't want to take
responsibility from the Kodi upstream and cherry-pick only some bugfixes that 
might
be considered "important" from my PoV. This creates an inconsistent user 
experience
across vanilla Kodi and Kodi from Debian, plus requires me to spend even more 
time
carefully testing each combination of cherry-picked commits in addition to all 
the
time I already spent fixing a lot of stuff upstream and in Debian.

The Kodi upstream has an estabilished testing and backport culture, and it is 
not that
easy to slip a risky change into a stable branch (which 19.x currently is). 
Plus all
upstream changes must pass CI before getting merged.

If it is not possible to have 19.x point (bugfix) releases in bullseye, I think
I will upload next point releases to experimental during the bullseye freeze,
then to bullseye-backports after bookworm development cycle starts. And for 
stable
branch I will port only CVE fixes and bug fixes reported to Debian.

Regards,
Vasyl
diff -Nru kodi-19.0+dfsg1/debian/changelog kodi-19.0+dfsg1/debian/changelog
--- kodi-19.0+dfsg1/debian/changelog2021-02-19 00:02:45.0 +
+++ kodi-19.0+dfsg1/debian/changelog2021-05-30 04:57:39.0 +
@@ -1,3 +1,13 @@
+kodi (2:19.0+dfsg1-2) unstable; urgency=medium
+
+  * Add missing font dependency (Closes: #985497)
+  * Fix github ref
+  * Branch out bullseye
+  * Refresh cdatetime-std-chrono patch (Closes: #984682)
+  * libdate-tz: Fix crash for early local times and USE_OS_TZDB
+
+ -- Vasyl Gello   Sun, 30 May 2021 04:57:39 +
+
 kodi (2:19.0+dfsg1-1) unstable; urgency=medium
 
   * New upstream version 19.0+dfsg1
diff -Nru kodi-19.0+dfsg1/debian/control kodi-19.0+dfsg1/debian/control
--- kodi-19.0+dfsg1/debian/control  2021-02-19 00:02:45.0 +
+++ kodi-19.0+dfsg1/debian/control  2021-05-30 04:57:39.0 +
@@ -107,7 +107,7 @@
 Standards-Version: 4.5.1
 Rules-Requires-Root: no
 Vcs-Browser: https://salsa.debian.org/multimedia-team/kodi-media-center/kodi
-Vcs-Git: https://salsa.debian.org/multimedia-team/kodi-media-center/kodi.git
+Vcs-Git: https://salsa.debian.org/multimedia-team/kodi-media-center/kodi.git 
-b bullseye
 Homepage: https://kodi.tv/
 
 Package: kodi
@@ -154,6 +154,7 @@
  ${misc:Depends}
 Recommends: fonts-noto-hinted,
 fonts-noto-mono,
+fonts-roboto-hinted,
 fonts-roboto-unhinted
 Breaks: xbmc (<< 2:13.2+dfsg1-5~)
 Replaces: xbmc (<< 2:13.2+dfsg1-5~)
diff -Nru kodi-19.0+dfsg1/debian/gbp.conf kodi-19.0+dfsg1/debian/gbp.conf
--- kodi-19.0+dfsg1/debian/gbp.conf 2021-02-19 00:02:45.0 +
+++ kodi-19.0+dfsg1/debian/gbp.conf 2021-05-30 04:57:39.0 +
@@ -3,3 +3,4 @@
 [DEFAULT]
 filter = */.git*
 components = ["libdate-tz-embedded", "libdvdnav-embedded", 
"libdvdread-embedded"]
+debian-branch = bullseye
diff -Nru 
kodi-19.0+dfsg1/debian/patches/cdatetime-std-chrono/0001-Replace-Kodi-date-time-implementation-with-std-c.patch
 
kodi-19.0+dfsg1/debian/patches/cdatetime-std-chrono/0001-Replace-Kodi-date-time-implementation-with-std-c.patch
--- 
kodi-19.0+dfsg1/debian/patches/cdatetime-std-chrono/0001-Replace-Kodi-date-time-implementation-with-std-c.patch
 2021-02-19 00:02:45.0 +
+++ 
kodi-19.0+dfsg1/debian/patches/cdatetime-std-chrono/0001-Replace-Kodi-date-time-implementation-with-std-c.patch
 2021-05-30 04:57:39.0 +
@@ -1,7 +1,7 @@
-From 60adbc26eafaa4edd136f4f515cf494b62f24f4f Mon Sep 17 00:00:00 2001
+From e7e426ec1b8f22dfc0c24cdf7a8a4476920128e4 Mon Sep 17 00:00:00 2001
 From: Lukas Rusak 
 Date: Mon, 17 Feb 2020 22:41:25 -0800
-Subject: [PATCH 01/13] [cmake] add support for date library and tzdata
+Subject: [PATCH 01/17] [cmake] add support for date library and tzdata
 
 ---
  CMakeLists.txt   |  2 +
@@ -10,10 +10,10 @@
  create mode 100644 cmake/modules/FindDate.cmake
 
 diff --git a/CMakeLists.txt b/CMakeLists.txt
-index e30083d2f9..dbdaf3ee0e 100644
+index 572e99b481..e49e743fbd 100644
 --- a/CMakeLists.txt
 +++ b/CMakeLists.txt
-@@ -64,6 +64,7 @@ if(UNIX)
+@@ -68,6 +68,7 @@ if(UNIX)
option(ENABLE_INTERNAL_GTEST "Enable internal gtest?" OFF)
option(ENABLE_INTERNAL_UDFREAD "Enable internal udfread?" OFF)
option(ENABLE_INTERNAL_SPDLOG "Enable internal spdlog?" OFF)
@@ -21,7 +21,7 @@
  endif()
  # System options
  if(NOT WIN32)
-@@ -121,6 +122,7 @@ set(required_deps ASS
+@@ -125,6 +126,7 @@ set(required_deps ASS
Cdio
CrossGUID
Curl
@@ -128,1

Bug#990083: Further testing

2021-06-29 Thread Vasyl Gello
Hi Fabrice!

Just curious: can you please use Kodi's built-in functionality to access NFS 
agare, not system mount and see if it helps?
Maybe create a backup of Kodi profile & try mounting in userspace.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#990498: CCurlFile::FillBuffer - Failed: Error in the HTTP2 framing layer(16)

2021-06-30 Thread Vasyl Gello
Hi Matthieu!

This might be relevant: https://github.com/xbmc/xbmc/pull/18582

And this definitely is: https://github.com/xbmc/xbmc/issues/19738

> I even tried the bpo version

Were you able to reproduce an issue with 2:19.1+dfsg2-1~bpo10+1 ?

Which version of curl do you have?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

30 червня 2021 р. 18:22:19 UTC, Mathieu Malaterre  
написав(-ла):
>Source: kodi
>Version: 2:17.6+dfsg1-4
>
>For some reason I cannot get any plugin to work in kodi today. I even
>tried the bpo version.
>
>My kodi.log is filled with:
>
>2021-06-30 20:16:02.831 T:19196INFO : CPythonInvoker(0,
>/usr/share/kodi/addons/service.xbmc.versioncheck/resources/lib/runner.py):
>script successfully run
>2021-06-30 20:16:02.841 T:19196INFO : Python interpreter stopped
>2021-06-30 20:16:05.744 T:19163   ERROR :
>CCurlFile::FillBuffer - Failed: Error in the HTTP2 framing layer(16)
>2021-06-30 20:16:05.744 T:19163   ERROR : CCurlFile::Open
>failed with code 0 for
>https://mirrors.kodi.tv/addons/matrix/metadata.common.imdb.com/metadata.common.imdb.com-3.2.3.zip:
>
>2021-06-30 20:16:05.744 T:19163   ERROR : Could not fetch
>addon location and hash from
>https://mirrors.kodi.tv/addons/matrix/metadata.common.imdb.com/metadata.common.imdb.com-3.2.3.zip
>2021-06-30 20:16:05.744 T:19163   ERROR :
>CAddonInstallJob[metadata.common.imdb.com]: failed to resolve addon
>install source path
>2021-06-30 20:16:06.143 T:19163   ERROR :
>CCurlFile::FillBuffer - Failed: Error in the HTTP2 framing layer(16)
>2021-06-30 20:16:06.143 T:19163   ERROR : CCurlFile::Open
>failed with code 0 for
>https://mirrors.kodi.tv/addons/matrix/metadata.common.themoviedb.org/metadata.common.themoviedb.org-3.2.14.zip:
>
>2021-06-30 20:16:06.143 T:19163   ERROR : Could not fetch
>addon location and hash from
>https://mirrors.kodi.tv/addons/matrix/metadata.common.themoviedb.org/metadata.common.themoviedb.org-3.2.14.zip
>2021-06-30 20:16:06.143 T:19163   ERROR :
>CAddonInstallJob[metadata.common.themoviedb.org]: failed to resolve
>addon install source path
>2021-06-30 20:16:06.539 T:19163   ERROR :
>CCurlFile::FillBuffer - Failed: Error in the HTTP2 framing layer(16)
>
>Looking upstream, all I can find are:
>
>https://github.com/xbmc/xbmc/issues/16616
>
>which is not really helpful.
>


Bug#990498: CCurlFile::FillBuffer - Failed: Error in the HTTP2 framing layer(16)

2021-06-30 Thread Vasyl Gello
Package: kodi
Followup-For: Bug #990498
X-Debbugs-Cc: gh...@debian.org, elb...@debian.org

Hi Mathieu!

Can you please check if the following patch for curl 7.64.0-4+deb10u2 resolves 
your issue?
It is a backport of two patches merged in 7.65.0 and 7.67.0, respectively (see 
the commit msg
for details).

If that helps, I will reattach the bug to curl package since the patch is 
long-time merged
upstream.

Vasyl

-- System Information:
Debian Release: 11.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-7-amd64 (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages kodi depends on:
pn  kodi-bin   
pn  kodi-data  

Versions of packages kodi recommends:
pn  kodi-repository-kodi | kodi-repository  
pn  kodi-visualization-spectrum 

kodi suggests no packages.
diff --git a/debian/patches/28-Fix-HTTP2-framing-layer-#990498.patch 
b/debian/patches/28-Fix-HTTP2-framing-layer-#990498.patch
new file mode 100644
index 000..b6a917e
--- /dev/null
+++ b/debian/patches/28-Fix-HTTP2-framing-layer-#990498.patch
@@ -0,0 +1,34 @@
+Subject: Fix HTTP2 framing layer error (Closes: #990498)
+Author: Vasyl Gello 
+Forwarded: not-needed
+
+This is squashed no-change backport of two commits:
+
+https://github.com/curl/curl/commit/3f5da4e59a556fc68272a9857a38dd75234d0c04
+openssl: mark connection for close on TLS close_notify
+
+https://github.com/curl/curl/commit/a56a47ac33a8344c0a3f3f74bd4a6b07576f7e0a
+openssl: close_notify on the FTP data connection doesn't mean closure
+
+mentioned in upstream issue:
+
+https://github.com/curl/curl/issues/3750
+
+---
+
+--- a/lib/vtls/openssl.c
 b/lib/vtls/openssl.c
+@@ -3792,7 +3792,13 @@
+ 
+ switch(err) {
+ case SSL_ERROR_NONE: /* this is not an error */
++  break;
+ case SSL_ERROR_ZERO_RETURN: /* no more data */
++  /* close_notify alert */
++  if(num == FIRSTSOCKET)
++/* mark the connection for close if it is indeed the control
++   connection */
++connclose(conn, "TLS close_notify");
+   break;
+ case SSL_ERROR_WANT_READ:
+ case SSL_ERROR_WANT_WRITE:
diff --git a/debian/patches/series b/debian/patches/series
index 6330cd9..d0d1790 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -19,6 +19,7 @@
 25_CVE-2020-8286.patch
 26_CVE-2021-22876.patch
 27_CVE-2021-22890.patch
+28-Fix-HTTP2-framing-layer-#990498.patch
 
 # do not add patches below
 90_gnutls.patch


Bug#990498: CCurlFile::FillBuffer - Failed: Error in the HTTP2 framing layer(16)

2021-06-30 Thread Vasyl Gello
CC'ing just in case reportbug fails to deliver the reply to bug reporter.

Bug#990511: unblock: kodi/2:19.1+dfsg2-2

2021-06-30 Thread Vasyl Gello
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: mat...@debian.org

Please unblock package kodi

[ Reason ]

Targeted bug fix for #989814

[ Impact ]

Turkish users get Kodi unusable without it

[ Tests ]

See related Debian bug and https://github.com/xbmc/xbmc/issues/19883

[ Risks ]

Change is trivial and approved by upstream

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

unblock kodi/2:19.1+dfsg2-2
diff -Nru kodi-19.1+dfsg2/debian/changelog kodi-19.1+dfsg2/debian/changelog
--- kodi-19.1+dfsg2/debian/changelog2021-06-07 14:42:08.0 +
+++ kodi-19.1+dfsg2/debian/changelog2021-06-24 20:44:30.0 +
@@ -1,3 +1,9 @@
+kodi (2:19.1+dfsg2-2) unstable; urgency=medium
+
+  * Add runtime locale test and fallback (Closes: #989814)
+
+ -- Vasyl Gello   Thu, 24 Jun 2021 20:44:30 +
+
 kodi (2:19.1+dfsg2-1) unstable; urgency=medium
 
   * New upstream version 19.1+dfsg2
diff -Nru kodi-19.1+dfsg2/debian/patches/kodi/0022-Workaround-989814.patch 
kodi-19.1+dfsg2/debian/patches/kodi/0022-Workaround-989814.patch
--- kodi-19.1+dfsg2/debian/patches/kodi/0022-Workaround-989814.patch
1970-01-01 00:00:00.0 +
+++ kodi-19.1+dfsg2/debian/patches/kodi/0022-Workaround-989814.patch
2021-06-24 20:44:30.0 +
@@ -0,0 +1,67 @@
+From 8b8e97dbec5c6268d1b81eb7799cfc945ca9520e Mon Sep 17 00:00:00 2001
+From: Vasyl Gello 
+Date: Fri, 25 Jun 2021 01:37:02 +
+Subject: [PATCH 1/2] Check if applied locale correctly lowers chars and
+ fallback
+
+.. to default region if it does not.
+
+Fixes #19883.
+
+Signed-off-by: Vasyl Gello 
+---
+ xbmc/LangInfo.cpp | 10 ++
+ 1 file changed, 10 insertions(+)
+
+diff --git a/xbmc/LangInfo.cpp b/xbmc/LangInfo.cpp
+index 24f0419cfe..ace72e1ffe 100644
+--- a/xbmc/LangInfo.cpp
 b/xbmc/LangInfo.cpp
+@@ -981,6 +981,16 @@ void CLangInfo::SetCurrentRegion(const std::string& 
strName)
+ 
+   m_currentRegion->SetGlobalLocale();
+ 
++  // Check if locale is not affected by #19883
++  int test19883 = std::tolower('i') - std::tolower('I');
++  if (test19883 != 0)
++  {
++CLog::Log(LOGWARNING, "region '{}' is affected by #19883 - falling back 
to default region '{}'",
++  m_currentRegion->m_strName, m_defaultRegion.m_strName);
++m_currentRegion = &m_defaultRegion;
++m_currentRegion->SetGlobalLocale();
++  }
++
+   const std::shared_ptr settings = 
CServiceBroker::GetSettingsComponent()->GetSettings();
+   if (settings->GetString(CSettings::SETTING_LOCALE_SHORTDATEFORMAT) == 
SETTING_REGIONAL_DEFAULT)
+ SetShortDateFormat(m_currentRegion->m_strDateFormatShort);
+-- 
+2.32.0.rc0
+
+
+From 114ee13138389c96a759d6e5b73717093dd4030d Mon Sep 17 00:00:00 2001
+From: Vasyl Gello 
+Date: Sun, 27 Jun 2021 19:31:39 +
+Subject: [PATCH 2/2] kodi.sh.in: Unset LC_{ALL,CTYPE}, LANG
+
+Signed-off-by: Vasyl Gello 
+---
+ tools/Linux/kodi.sh.in | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/tools/Linux/kodi.sh.in b/tools/Linux/kodi.sh.in
+index 108c0b007b..29d17d2c0f 100644
+--- a/tools/Linux/kodi.sh.in
 b/tools/Linux/kodi.sh.in
+@@ -171,6 +171,9 @@ if command_exists gdb; then
+   fi
+ fi
+ 
++# Unset CTYPE, LANG and ALL - see issue #19883
++unset LC_CTYPE LC_ALL LANG
++
+ LOOP=1
+ while [ $(( $LOOP )) = "1" ]
+ do
+-- 
+2.32.0.rc0
+
diff -Nru kodi-19.1+dfsg2/debian/patches/series 
kodi-19.1+dfsg2/debian/patches/series
--- kodi-19.1+dfsg2/debian/patches/series   2021-06-07 14:42:08.0 
+
+++ kodi-19.1+dfsg2/debian/patches/series   2021-06-24 20:44:30.0 
+
@@ -19,6 +19,7 @@
 kodi/0019-Disable-GetCPUFrequency-test.patch
 kodi/0020-Fix-C++-example-includes.patch
 kodi/0021-Detect-and-honor-big-endian-arch.patch
+kodi/0022-Workaround-989814.patch
 libdvdnav/0001-xbmc-dvdnav-allow-get-set-vm-state.patch
 libdvdnav/0002-xbmc-dvdnav-expose-dvdnav_get_vm-dvdnav_get_button_i.patch
 libdvdnav/0003-xbmc-dvdnav-detection-of-dvd-name.patch


Bug#990511: unblock: kodi/2:19.1+dfsg2-2

2021-07-02 Thread Vasyl Gello
Hi Sebastian!

> I'm not sure why the second patch is needed. If I understand the first
> patch correctly, in the case where LC_CTYPE is set to a Turkish locale,
> the locale will be reset to C.UTF-8 (not sure that this is sane,
> though). The second patch makes it even worse since it resets it to
> C.UTF-8 for everyone else as well.

This is intended. Kodi internally expects to start with classic C locale and 
after language pack is loaded, Kodi's global locale is set to the desired 
locale.
The root cause of the bug is incorrect comparison of skin's includes.xml 
involving lowercase translation of file name (see upstream issue #19883, linked)
So there are two scenarios possible when the bug can manifest:

1. LC_TYPE is set to a locale where "Turkish I" is effective (tr_*, az_AZ) and 
user chooses Kodi language other than Turkish / Azeri.
In this case, the locale is set to C + overrides from LC_CTYPE / LANG / LC_ALL, 
so it becomes C + CTYPE("tr_TR.UTF-8"). The setlocale() call enforces this 
"franken-locale" and the tolower("Includes.xml") produces "Includes.xml" as per 
Turkish CTYPE rules, and not "inclides.xml" as expected.

2. LC_* and LANG is set to arbitrary locale and user chooses Turkish / Azeri 
language.
In this case, the locale is set to whatever the environment variables declare 
first, but then "CLangInfo::CRegion::SetGlobalLocale" sets global locale to 
"tr_TR.UTF-8" and Kodi interface gets completely broken due to failed XML 
substitutions etc.

That's why the first patch is not enough and I had to add the second one to 
enforce Kodi's internal expectation to start with POSIX locale.

Mattia asked the same question, BTW :) The resolution looks odd at the first 
glance as experienced users might expect Kodi to display UI in language 
controlled by LANG or LC_ALL environment variable, but with Kodi, the language 
is controlled by Settings -> Skin - Region -> Language and only by that means, 
because unlike coreutils, language packs are shipped in form of Kodi addons 
from central Kodi repository (https://mirrors.kodi.tv) and not as a collection 
of PO files.

-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#990511: unblock: kodi/2:19.1+dfsg2-2

2021-07-02 Thread Vasyl Gello
Hi Sebastian!

> So what you're telling me is that this tolower call should actually be
> call to tolower_l with an appropriate locale as kodi only expects
> tolower("...") == "includes.xml" under the C locale.

Very likely it is the more "proper" solution, but to separate 
"culture-dependent" and "ordinal" comparisons, one needs to overhaul half of 
Kodi.
And this would make the fix unfit for 19.x branch as the regressions would be 
just as severe as they could be with CDateTime PR.

I consider this patch as a quick workaround that works on all languages so far 
(to my surprise, as I tested that in loop with ~40 languages using API calls & 
scrot). As I mentioned in the upstream issue, if this workaround would not have 
worked, I'd have either to use tolower_t, toupper_t locale-wise, use 
"uselocale(8)" or even switch to ICU. But this worked and upstream approved 
PR#19905. Having said that, I think it is good to go.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#990511: unblock: kodi/2:19.1+dfsg2-2

2021-07-02 Thread Vasyl Gello
Also I don't see std::tolower_l as part of C++ standard. Looks like tolower_l 
is POSIX standard and Kodi uses std:: stuff there :(
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#990511: unblock: kodi/2:19.1+dfsg2-2

2021-07-02 Thread Vasyl Gello
>C++ has an overloaded version of tolower that takes a locale:
>https://en.cppreference.com/w/cpp/locale/tolower

Good find, thanks! Still, what do you think about this concern:

> but to separate "culture-dependent" and "ordinal" comparisons, one needs to 
> overhaul half of Kodi.
> And this would make the fix unfit for 19.x branch as the regressions would be 
> just as severe as they could be with CDateTime PR.

I dont think spending several weeks to isolate all places that need C-locale 
comparison from those implementing language-specific processing (amd testing 
all possible regressions!) is worth for 19.x.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#990511: unblock: kodi/2:19.1+dfsg2-2

2021-07-02 Thread Vasyl Gello
Hi Sebastian,

One more (technical) thing to mention: the best way to centralize ToLower and 
ToUpper (omitting collations for now, for that there is a libicu PR for v20 
targeting Android) is to declare an overloaded 'StringUtils::ToLower(char c, 
bool useCLocale)' function and make all Kodi use it. However, there are two 
instances of StringUtils.h and the second one is part of Kodi API SDK. Fixing 
Kodi API SDK will be immediately rejected by upstream for v19 because it 
triggers an API bump and rebuild of all addons (including minimum 12 addons of 
49 in Debian during the full freeze!).

Since the workaround does not break movie search / collation / addons, let's 
follow the upstream path and have it merged. For v20 development cycle, we can 
either refactor lower/upper/collation things or use libicu to perform similar 
comparisons.

If you have a better approach to solve this issue, please let me know on 
https://github.com/xbmc/xbmc/issue/19883

Cheers!
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#951257: udevadm: please exit nonzero with "Running in chroot, ignoring request." when /proc is not mounted

2021-07-04 Thread Vasyl Gello
Dear colleagues,

I trapped into the same issue testing the installation of udisks2 on top of 
udev from buster-backports.
An inexperienced user following the random guides from Internet can issue 
something like:

apt-get install -t buster-backports udisks2

(or package depending on udisks2) and get the failed install.

The workaround patch to udisks2 that fixes the issue for bullseye is
https://salsa.debian.org/utopia-team/udisks2/-/commit/050527c84bed6bc6c90d46d3eb612c48baf92e7d
but it was never backported to buster-updates. Can you please do it?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#988623: unblock: kodi-pvr-waipu/2.8.4+ds1-1

2021-07-05 Thread Vasyl Gello
Control: close -1

Hi Sebastian!

After more thorough review of commits themselves I feel not sure about 
re-authentication issue. So I am closing the bug until some Waipu.tv user 
reopens it.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

  1   2   3   4   >