Bug#892072: weechat: build against ruby2.5

[Emilio Pozuelo Monfort]

On Tue, 6 Mar 2018 13:58:02 +0100 =?utf-8?Q?S=C3=A9bastien?= Helleu
 wrote:
> On Sun, Mar 04, 2018 at 07:57:11PM -0300, Antonio Terceiro wrote:
> > Source: weechat
> > Version: 1.9.1-1
> > Severity: serious
> > Justification: will FTBFS soon
> > Tags: patch
> > 
> > Hi,
> > 
> > I am about to upload ruby-defaults to unstable, switching the default
> > Ruby to ruby2.5, and ruby2.3 support will be removed right after that.
> > Please consider applying the attached patch, obtained from upstream.
> > 
> > Even better: please work with upstream to be able to build against the
> > default ruby, instead of hardcoding a list of ruby versions. Otherwise,
> > every time there is a Ruby transition, weechat will be a blocker.
> > Hunting down these issues is quite time consuming.
> > 
> 
> Hi Antonio,
> 
> I agree with the need to detect Ruby and other libraries in WeeChat without
> hardcoding a list of supported versions in the CMake and configure files.
> 
> I opened an issue, so this will be implemented as soon as possible:
> 
>   https://github.com/weechat/weechat/issues/1156

Great, thanks! In the meantime, could you upload the patch Antonio attached, so
that this doesn't block the transition?

Thanks,
Emilio

Bug#892072: weechat: build against ruby2.5

[Sébastien Helleu]

On Sun, Mar 04, 2018 at 07:57:11PM -0300, Antonio Terceiro wrote:
> Source: weechat
> Version: 1.9.1-1
> Severity: serious
> Justification: will FTBFS soon
> Tags: patch
> 
> Hi,
> 
> I am about to upload ruby-defaults to unstable, switching the default
> Ruby to ruby2.5, and ruby2.3 support will be removed right after that.
> Please consider applying the attached patch, obtained from upstream.
> 
> Even better: please work with upstream to be able to build against the
> default ruby, instead of hardcoding a list of ruby versions. Otherwise,
> every time there is a Ruby transition, weechat will be a blocker.
> Hunting down these issues is quite time consuming.
> 

Hi Antonio,

I agree with the need to detect Ruby and other libraries in WeeChat without
hardcoding a list of supported versions in the CMake and configure files.

I opened an issue, so this will be implemented as soon as possible:

  https://github.com/weechat/weechat/issues/1156

-- 
Sébastien Helleu

web: weechat.org / flashtux.org
irc: FlashCode @ irc.freenode.net

Bug#892072: weechat: build against ruby2.5

[Antonio Terceiro]

Source: weechat
Version: 1.9.1-1
Severity: serious
Justification: will FTBFS soon
Tags: patch

Hi,

I am about to upload ruby-defaults to unstable, switching the default
Ruby to ruby2.5, and ruby2.3 support will be removed right after that.
Please consider applying the attached patch, obtained from upstream.

Even better: please work with upstream to be able to build against the
default ruby, instead of hardcoding a list of ruby versions. Otherwise,
every time there is a Ruby transition, weechat will be a blocker.
Hunting down these issues is quite time consuming.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 
'unstable'), (500, 'testing'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), 
LANGUAGE=pt_BR:pt:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
From cb98f528301c422bdf990bdba1108e53a86ea4db Mon Sep 17 00:00:00 2001
From: Jakub Jirutka 
Date: Tue, 26 Dec 2017 18:30:18 +0100
Subject: [PATCH] core: add detection for Ruby 2.5

---
 cmake/FindRuby.cmake | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmake/FindRuby.cmake b/cmake/FindRuby.cmake
index 673dde716..49bce219a 100644
--- a/cmake/FindRuby.cmake
+++ b/cmake/FindRuby.cmake
@@ -33,7 +33,7 @@ endif()
 
 find_package(PkgConfig)
 if(PKG_CONFIG_FOUND)
-  pkg_search_module(RUBY ruby-2.4 ruby-2.3 ruby-2.2 ruby-2.1 ruby-2.0 ruby-1.9 ruby-1.8)
+  pkg_search_module(RUBY ruby-2.5 ruby-2.4 ruby-2.3 ruby-2.2 ruby-2.1 ruby-2.0 ruby-1.9 ruby-1.8)
 endif()
 
 if(RUBY_FOUND)
@@ -41,7 +41,7 @@ if(RUBY_FOUND)
   mark_as_advanced(RUBY_LIB)
 else()
   find_program(RUBY_EXECUTABLE
-NAMES ruby2.4.0 ruby240 ruby2.4 ruby2.3.0 ruby230 ruby2.3 ruby23 ruby2.2.3 ruby223 ruby2.2.2 ruby222 ruby2.2.1 ruby221 ruby2.2.0 ruby220 ruby2.2 ruby22 ruby2.1.7 ruby217 ruby2.1.6 ruby216 ruby2.1.5 ruby215 ruby2.1.4 ruby214 ruby2.1.3 ruby213 ruby2.1.2 ruby212 ruby2.1.1 ruby211 ruby2.1.0 ruby210 ruby2.1 ruby21 ruby2.0 ruby20 ruby1.9.3 ruby193 ruby1.9.2 ruby192 ruby1.9.1 ruby191 ruby1.9 ruby19 ruby1.8 ruby18 ruby
+NAMES ruby2.5.0 ruby250 ruby2.5 ruby2.4.0 ruby240 ruby2.4 ruby2.3.0 ruby230 ruby2.3 ruby23 ruby2.2.3 ruby223 ruby2.2.2 ruby222 ruby2.2.1 ruby221 ruby2.2.0 ruby220 ruby2.2 ruby22 ruby2.1.7 ruby217 ruby2.1.6 ruby216 ruby2.1.5 ruby215 ruby2.1.4 ruby214 ruby2.1.3 ruby213 ruby2.1.2 ruby212 ruby2.1.1 ruby211 ruby2.1.0 ruby210 ruby2.1 ruby21 ruby2.0 ruby20 ruby1.9.3 ruby193 ruby1.9.2 ruby192 ruby1.9.1 ruby191 ruby1.9 ruby19 ruby1.8 ruby18 ruby
 PATHS /usr/bin /usr/local/bin /usr/pkg/bin
 )
   if(RUBY_EXECUTABLE)


signature.asc
Description: PGP signature