Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'
Hi Dominique, I am fine with your suggestion. We will wait for your implementation. Thank you for providing this package! Kind regards, Felix On Mon, Oct 29, 2018 at 9:44 AM Dominique Dumont wrote: > > On Monday, 29 October 2018 16:51:45 CET you wrote: > > I am happy to provide patches and merge requests that implement your > > idea, > > Thanks. But the change is trivial. I can do it on my side. > > We just need to find a common ground that allow fixing #905614 > > > but are you sure there are other meaningful consumers of the > > summary_or_text method? > > Absolutely not. But keeping backward compat with already published modules is > one of the best values of the Perl community. I intend to keep that promise as > much as possible > > > Your posting [1] restricts uses to Debian > > Debian and its 100+ derivates. > > > , and > > a search on codesearch.debian.net shows no other packages that rely on > > the current implementation that produces a copyright notice with a > > full text but not with a summary. Why is the current implementation > > worth keeping? > > Because we can't be sure that nobody will be impacted. A user may be relying > on summary_or_text but has not (or will not) publish her or his code. > > > Please forgive me if I appear insistent. It's the only > > question I have. > > No problem. You're right to challenge what is not clear :-) > > All the best > > > >
Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'
On Monday, 29 October 2018 16:51:45 CET you wrote: > I am happy to provide patches and merge requests that implement your > idea, Thanks. But the change is trivial. I can do it on my side. We just need to find a common ground that allow fixing #905614 > but are you sure there are other meaningful consumers of the > summary_or_text method? Absolutely not. But keeping backward compat with already published modules is one of the best values of the Perl community. I intend to keep that promise as much as possible > Your posting [1] restricts uses to Debian Debian and its 100+ derivates. > , and > a search on codesearch.debian.net shows no other packages that rely on > the current implementation that produces a copyright notice with a > full text but not with a summary. Why is the current implementation > worth keeping? Because we can't be sure that nobody will be impacted. A user may be relying on summary_or_text but has not (or will not) publish her or his code. > Please forgive me if I appear insistent. It's the only > question I have. No problem. You're right to challenge what is not clear :-) All the best
Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'
On Monday, 29 October 2018 15:21:25 CET you wrote: > I'm not thrilled at the idea of changing the behavior of summary_or_text > method because the implementation would no longer match its behavior. Oops, this sentence does not make sense. I meant that "the function name would no longer match its behavior." All the best
Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'
Hi Dominique, I am happy to provide patches and merge requests that implement your idea, but are you sure there are other meaningful consumers of the summary_or_text method? Your posting [1] restricts uses to Debian, and a search on codesearch.debian.net shows no other packages that rely on the current implementation that produces a copyright notice with a full text but not with a summary. Why is the current implementation worth keeping? Please forgive me if I appear insistent. It's the only question I have. Thank you! Kind regards, Felix [1] https://ddumont.wordpress.com/2018/07/07/new-softwarelicensemoreutils-perl-module/ On Mon, Oct 29, 2018 at 7:22 AM Dominique Dumont wrote: > > On Sat, 27 Oct 2018 15:57:56 +0200 gregor herrmann wrote: > > Dominique, could you look into this patch, please? > > yes, sorry for the delay. > > I'm not thrilled at the idea of changing the behavior of summary_or_text > method because the implementation would no longer match its behavior. > > Felix, how about un-deprecating debian_text method and putting your code there > ? > > All the best > >
Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'
On Sat, 27 Oct 2018 15:57:56 +0200 gregor herrmann wrote: > Dominique, could you look into this patch, please? yes, sorry for the delay. I'm not thrilled at the idea of changing the behavior of summary_or_text method because the implementation would no longer match its behavior. Felix, how about un-deprecating debian_text method and putting your code there ? All the best
Bug#911403: Please always include a copyright notice in 'LicenseWithSummary::summary_or_text'
On Fri, 19 Oct 2018 10:55:25 -0700, Felix Lechner wrote: > The routine 'LicenseWithSummary::summary' produces only a license > summary, while 'Software::License::fulltext' produces a copyright > notice in addition to the full text. Please return a copyright notice > when producing a summary in 'LicenseWithSummary::summary_or_text' so > the output of the method becomes more symmetrical. Attached please > find a patch. Thank you! Thanks. Dominique, could you look into this patch, please? Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Ostbahn-Kurti & Die Chefpartie: Chili Con Carne signature.asc Description: Digital Signature
