Bug#976865: Fwd: Bug#974900: dash removes trailing slash from script arguments

2020-12-10 Thread Herbert Xu
On Thu, Dec 10, 2020 at 10:20:29AM -0500, Jeff King wrote:
>
> It seems like it happens for "foo/", too. If I compile:

I think the key is that dash uses GLOB_NOMAGIC.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Bug#976865: Fwd: Bug#974900: dash removes trailing slash from script arguments

2020-12-10 Thread Herbert Xu
On Wed, Dec 09, 2020 at 01:27:17PM +0100, Aurelien Jarno wrote:
>
> Can you please describe more precisely what is the problem with glob(3)?

Create a regular file called "foo", then call glob(3) with the
pattern "foo\/".  This returns a single match with the string
"foo".  This should return no match.

If you change the pattern to "foo/", then it also matches but
returns with the string "foo/" as expected.

The only flag we pass to glob(3) is GLOB_NOMAGIC.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Bug#976865: Fwd: Bug#974900: dash removes trailing slash from script arguments

2020-12-10 Thread Herbert Xu
On Thu, Dec 10, 2020 at 08:58:37AM +0100, Aurelien Jarno wrote:
>
> That's the dash symptoms. glob(3) takes a pattern and just returns the
> paths matching the pattern, as they are named on the filesystem. That
> said, the option GLOB_MARK can return a trailing slash for all matched
> path that are a directory.

Yes but it's really a bug in glob(3).  It should really return
a no-match for the case in question, rather than matching and then
returning a filename without the slash.

IOW the pattern "foo\/" should not match a regular file foo.

Note that the problem doesn't occur for "foo/".

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Bug#976865: Fwd: Bug#974900: dash removes trailing slash from script arguments

2020-12-09 Thread Herbert Xu
Aurelien Jarno  wrote:
>
> Can you please describe more precisely what is the problem with glob(3)?

It's stripping trailing slashes from the pattern, even when the
name in question is a regular file.

https://patchwork.kernel.org/project/dash/patch/20201116025222.ga28...@gondor.apana.org.au/

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Re: Bug#211784 closed by Guillem Jover guil...@debian.org (Re: Bug#211784: start-stop-daemon --stop returns before daemon exits unless --retry is used)

2009-11-24 Thread Herbert Xu
reopen 211784
reassign 211784 libc6
retitle 211784 Use start-stop-daemon --restart
quit

On Tue, Nov 24, 2009 at 06:36:03PM +, Debian Bug Tracking System wrote:
 
 On Mon, 2004-08-30 at 08:02:46 +0200, Thomas Hood wrote:
  On Mon, 2004-08-30 at 07:21, GOTO Masanori wrote:
   We're talking about libc6.postinst start-stop code (line:264).  We
   don't execute start-stop-daemon directly.  So I think --retry option
   issue is out of scope.
  
  One should be able to call an initscript with the restart
  argument in order to restart the service that it controls.  If
  that doesn't work then there is a bug in the initscript.
  Stopping and starting should also work without a sleep in
  between.  This is something that should be addressed post-sarge.
 
 I agree with Thomas, those init scripts are buggy. Also the
 functionality is already present in start-stop-daemon with the --retry
 option. The fact that --stop does not wait is explained clearly in
 the man pages, and I don't think it's s-s-d's fault if people expect
 it to do something it's not supposed to.
 
 Thus closing.

Next time you close a bug, please look at the original report.
I never filed this against dpkg, it was reassigned by the maintainer
of the package it was filed against.

The original bug AFAICS is still there.
 
 Package: libc6
 Version: 2.3.2-7
 Severity: normal
 
 The delay of one second between stop/start is too short for nis.
 On my system, it often takes between one and two seconds to shutdown
 nis.
 
 This causes nis to be stopped but not started after a libc6 upgrade.
 
 The solution is either to increase the delay to at least two seconds,
 or use a better method to determine when the stop has completed.
 
 -- System Information
 Debian Release: testing/unstable
 Kernel Version: Linux gondolin 2.4.22-1-686-smp #1 SMP Sat Sep 6 00:06:59 EST 
 2003 i686 GNU/Linux
 
 Versions of the packages libc6 depends on:
 ii  libdb1-compat  2.1.3-7The Berkeley database routines [glibc 2.0/2.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to debian-glibc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#65458: closed by Clint Adams sch...@debian.org (Re: Bug#65458: (no subject))

2008-05-19 Thread Herbert Xu
reopen 65458
reassign 65458 libc6
quit

On Mon, May 19, 2008 at 01:03:10PM +, Debian Bug Tracking System wrote:
 
 This is an automatic notification regarding your Bug report
 which was filed against the libc6 package:
 
 #65458: sed: regexp performance woeful
 
 It has been closed by Clint Adams [EMAIL PROTECTED].

Until the fixed package enters Debian I can't verify this.  So
please keep it open.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#445210: closed by Pierre Habouzit [EMAIL PROTECTED] (Re: Bug#445210: libc6: glob(3) doesn't treat \ correctly)

2007-10-04 Thread Herbert Xu
reopen 445210
quit

On Thu, Oct 04, 2007 at 08:27:04AM +, Debian Bug Tracking System wrote:

 and the test case on http://sourceware.org/bugzilla/show_bug.cgi?id=3996 works
 as well.
 
 Please check your environment, the libc works.

There were other tests in the bug report.

$ cat a.c
#include glob.h
#include stdio.h

int main() {
glob_t pglob;
printf(%d\n, glob(\\/*, 0, 0, pglob));
printf(%d\n, glob(/*, 0, 0, pglob));
return 0;
}
$ make a
cc a.c   -o a
$ ./a
3
0
$

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#65458: closed by Touko Korpela [EMAIL PROTECTED] (Should be fixed now)

2007-09-26 Thread Herbert Xu
reopen 65458
quit

On Sat, Sep 15, 2007 at 09:21:04PM +, Debian Bug Tracking System wrote:

 This slowness should be fixed already in etch (and maybe even sarge).
 Please reopen if you can still reproduce it in current version.

The second problem seems to be fixed but the original problem
is now back:

$ time sed '/^$/d'  /dev/null  /var/lib/dpkg/available

real0m2.011s
user0m2.004s
sys 0m0.004s
$ time mawk '!/^$/ { print; }'  /dev/null  /var/lib/dpkg/available

real0m0.141s
user0m0.128s
sys 0m0.012s
$

Note that my machine is now much faster :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#328440: NSS/NIS is totally broken

2005-10-03 Thread Herbert Xu
severity 328440 grave
retitle 328440 NIS broken with bash 
quit

I'm raising the severity of this bug since it'll lock the user out
if NIS is used for authentication.

With this version of libc6, any attempt to login into a machine using
NIS fails with:

-bash: nss_nis/nis-netgrp.c:79: _nss_nis_setnetgrent: Assertion 
`malloc_usable_size (netgrp-data) = len + 1' failed.

This bug was previously reported upstream as

http://sources.redhat.com/bugzilla/show_bug.cgi?id=962

However, it appears to have been prematurely closed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#265245: acknowledged by developer (Re: Bug#265245: glibc-doc: htonl/ntohl belong in arpa/inet.h)

2005-01-14 Thread Herbert Xu
reopen 265245
quit

On Thu, Jan 13, 2005 at 08:34:53PM -0800, Debian Bug Tracking System wrote:
 
 At Thu, 12 Aug 2004 21:08:42 +1000,
 [EMAIL PROTECTED] wrote:
  According to POSIX, htonl/ntohl are declared in arpa/inet.h.  So
  the info text should be modified to refer to that file instead of
  netinet/in.h.
 
 Exactly POSIX says it should be arpa/inet.h.  However glibc put such
 definitions in netinet/in.h.  But don't worry because arpa/inet.h
 always includes netinet/in.h, so we don't violate POSIX definition.  I
 close this report.

Sorry I think you didn't get my point.  What I mean is that the
documentation should refer the user to the POSIX standard location
either by itself or in addition to where glibc actually puts it.

Otherwise someone referring to the glibc documentation may unwittingly
produce programs that don't work on other POSIX platforms.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: \-quoting in character class

2004-06-03 Thread Herbert Xu
On Thu, Jun 03, 2004 at 03:48:55PM +, Gerrit Pape wrote:
 
 Hi, the upstream author of the diet libc disagrees, and quotes relevant
 parts from the susv3 standard, see
 
  http://article.gmane.org/gmane.linux.lib.dietlibc/541
  http://article.gmane.org/gmane.linux.lib.dietlibc/543

That's what I thought too if you read the entire BTS entry.

However, there is a special clause in section 2.13.1 which specifically
applies to bracket expressions.

: When pattern matching is used where shell quote removal is not performed
: (such as in the argument to the find -name primary when find is being
: called using one of the exec functions as defined in the System
: Interfaces volume of IEEE Std 1003.1-200x, or in the pattern argument
: to the fnmatch( ) function), special characters can be escaped to remove
: their special meaning by preceding them with a backslash character.

This is also how other shells (bash  pdksh) treat these patterns:

[EMAIL PROTECTED]:~$ ksh -c 'case a in [\]a]) echo hi; ;; esac'
hi
[EMAIL PROTECTED]:~$ bash -c 'case a in [\]a]) echo hi; ;; esac'
hi
[EMAIL PROTECTED]:~$

Note: The case statement is another place where quote removal is not
performed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: \-quoting in character class

2004-06-03 Thread Herbert Xu
On Thu, Jun 03, 2004 at 03:48:55PM +, Gerrit Pape wrote:
 
 Hi, the upstream author of the diet libc disagrees, and quotes relevant
 parts from the susv3 standard, see
 
  http://article.gmane.org/gmane.linux.lib.dietlibc/541
  http://article.gmane.org/gmane.linux.lib.dietlibc/543

That's what I thought too if you read the entire BTS entry.

However, there is a special clause in section 2.13.1 which specifically
applies to bracket expressions.

: When pattern matching is used where shell quote removal is not performed
: (such as in the argument to the find -name primary when find is being
: called using one of the exec functions as defined in the System
: Interfaces volume of IEEE Std 1003.1-200x, or in the pattern argument
: to the fnmatch( ) function), special characters can be escaped to remove
: their special meaning by preceding them with a backslash character.

This is also how other shells (bash  pdksh) treat these patterns:

[EMAIL PROTECTED]:~$ ksh -c 'case a in [\]a]) echo hi; ;; esac'
hi
[EMAIL PROTECTED]:~$ bash -c 'case a in [\]a]) echo hi; ;; esac'
hi
[EMAIL PROTECTED]:~$

Note: The case statement is another place where quote removal is not
performed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#243885: Processed: t

2004-06-01 Thread Herbert Xu
On Tue, Jun 01, 2004 at 04:13:00AM +, Gerrit Pape wrote:
 
 Do you prefer your patch to work around glibc's fnmatch problem in dash?

Yes we should use that until glibc's fnmatch is fixed.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#243885: Processed: t

2004-05-31 Thread Herbert Xu
On Mon, May 31, 2004 at 05:13:56PM +, Gerrit Pape wrote:
 
 I patched the diet libc fnmatch() function to support \-quoting, and
 dash to use this implementation.  This fixes #250499 and #243885 in my
 tests.  The patches against dietlibc:fnmatch() and the dash package are
 attached.

Hmm, is there anything that the dietlibc fnmatch does that the dash
internal pmatch function doesn't do? Or is it smaller?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: Processed: t

2004-05-31 Thread Herbert Xu
On Tue, Jun 01, 2004 at 04:13:00AM +, Gerrit Pape wrote:
 
 Do you prefer your patch to work around glibc's fnmatch problem in dash?

Yes we should use that until glibc's fnmatch is fixed.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: Processed: t

2004-05-31 Thread Herbert Xu
On Mon, May 31, 2004 at 05:13:56PM +, Gerrit Pape wrote:
 
 I patched the diet libc fnmatch() function to support \-quoting, and
 dash to use this implementation.  This fixes #250499 and #243885 in my
 tests.  The patches against dietlibc:fnmatch() and the dash package are
 attached.

Hmm, is there anything that the dietlibc fnmatch does that the dash
internal pmatch function doesn't do? Or is it smaller?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#243885: Processed: t

2004-05-28 Thread Herbert Xu
On Thu, May 27, 2004 at 07:03:05PM -0700, Debian Bug Tracking System wrote:
 Processing commands for [EMAIL PROTECTED]:
 
  retitle 250499 dash: doesn't understand [[:digit:]]
 Bug#250499: clamav-daemon: dpkg-reconfigure; limit stream length question won't 
 accept any answer
 Changed Bug title.

Please cc the maintainer that you're reassinging to in future.

This bug will go away as soon as glibc fixes their fnmatch(3)
implementation re #243885.

To the glibc maintainers, have you made any progress on that issue?

Once that happens dash can switch back to using fnmatch(3) which
supports character classes.

Until then, we'll need something like the following patch.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: expand.c
===
RCS file: /home/gondolin/herbert/src/CVS/debian/dash/expand.c,v
retrieving revision 1.79
diff -u -r1.79 expand.c
--- a/expand.c  18 Mar 2004 09:56:55 -  1.79
+++ b/expand.c  28 May 2004 12:03:34 -
@@ -61,6 +61,8 @@
 #if !defined(GLOB_BROKEN)
 #include glob.h
 #endif
+#else
+#include ctype.h
 #endif
 #endif
 
@@ -1491,6 +1493,42 @@
 
 
 #if !defined(__GLIBC__) || defined(FNMATCH_BROKEN)
+STATIC int ccmatch(const char *p, int chr, const char **r)
+{
+   static const struct class {
+   char name[10];
+   int (*fn)(int);
+   } classes[] = {
+   { .name = :alnum:], .fn = isalnum },
+   { .name = :cntrl:], .fn = iscntrl },
+   { .name = :lower:], .fn = islower },
+   { .name = :space:], .fn = isspace },
+   { .name = :alpha:], .fn = isalpha },
+   { .name = :digit:], .fn = isdigit },
+   { .name = :print:], .fn = isprint },
+   { .name = :upper:], .fn = isupper },
+   { .name = :blank:], .fn = isblank },
+   { .name = :graph:], .fn = isgraph },
+   { .name = :punct:], .fn = ispunct },
+   { .name = :xdigit:], .fn = isxdigit },
+   };
+   const struct class *class, *end;
+
+   end = classes + sizeof(classes) / sizeof(classes[0]);
+   for (class = classes; class  end; class++) {
+   const char *q;
+
+   q = prefix(p, class-name);
+   if (!q)
+   continue;
+   *r = q;
+   return class-fn(chr);
+   }
+
+   *r = 0;
+   return 0;
+}
+
 STATIC int
 pmatch(const char *pattern, const char *string)
 {
@@ -1529,21 +1567,11 @@
} while (*q++ != '\0');
return 0;
case '[': {
-   const char *endp;
+   const char *startp;
int invert, found;
char chr;
 
-   endp = p;
-   if (*endp == '!')
-   endp++;
-   for (;;) {
-   if (*endp == '\0')
-   goto dft;   /* no matching ] */
-   if (*endp == '\\')
-   endp++;
-   if (*++endp == ']')
-   break;
-   }
+   startp = p;
invert = 0;
if (*p == '!') {
invert++;
@@ -1555,7 +1583,20 @@
return 0;
c = *p++;
do {
-   if (c == '\\')
+   if (!c) {
+   p = startp;
+   c = *p;
+   goto dft;
+   }
+   if (c == '[') {
+   const char *r;
+
+   found |= ccmatch(p, chr, r);
+   if (r) {
+   p = r;
+   continue;
+   }
+   } else if (c == '\\')
c = *p++;
if (*p == '-'  p[1] != ']') {
p++;


Bug#243885: Processed: t

2004-05-28 Thread Herbert Xu
On Thu, May 27, 2004 at 07:03:05PM -0700, Debian Bug Tracking System wrote:
 Processing commands for [EMAIL PROTECTED]:
 
  retitle 250499 dash: doesn't understand [[:digit:]]
 Bug#250499: clamav-daemon: dpkg-reconfigure; limit stream length question 
 won't accept any answer
 Changed Bug title.

Please cc the maintainer that you're reassinging to in future.

This bug will go away as soon as glibc fixes their fnmatch(3)
implementation re #243885.

To the glibc maintainers, have you made any progress on that issue?

Once that happens dash can switch back to using fnmatch(3) which
supports character classes.

Until then, we'll need something like the following patch.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: expand.c
===
RCS file: /home/gondolin/herbert/src/CVS/debian/dash/expand.c,v
retrieving revision 1.79
diff -u -r1.79 expand.c
--- a/expand.c  18 Mar 2004 09:56:55 -  1.79
+++ b/expand.c  28 May 2004 12:03:34 -
@@ -61,6 +61,8 @@
 #if !defined(GLOB_BROKEN)
 #include glob.h
 #endif
+#else
+#include ctype.h
 #endif
 #endif
 
@@ -1491,6 +1493,42 @@
 
 
 #if !defined(__GLIBC__) || defined(FNMATCH_BROKEN)
+STATIC int ccmatch(const char *p, int chr, const char **r)
+{
+   static const struct class {
+   char name[10];
+   int (*fn)(int);
+   } classes[] = {
+   { .name = :alnum:], .fn = isalnum },
+   { .name = :cntrl:], .fn = iscntrl },
+   { .name = :lower:], .fn = islower },
+   { .name = :space:], .fn = isspace },
+   { .name = :alpha:], .fn = isalpha },
+   { .name = :digit:], .fn = isdigit },
+   { .name = :print:], .fn = isprint },
+   { .name = :upper:], .fn = isupper },
+   { .name = :blank:], .fn = isblank },
+   { .name = :graph:], .fn = isgraph },
+   { .name = :punct:], .fn = ispunct },
+   { .name = :xdigit:], .fn = isxdigit },
+   };
+   const struct class *class, *end;
+
+   end = classes + sizeof(classes) / sizeof(classes[0]);
+   for (class = classes; class  end; class++) {
+   const char *q;
+
+   q = prefix(p, class-name);
+   if (!q)
+   continue;
+   *r = q;
+   return class-fn(chr);
+   }
+
+   *r = 0;
+   return 0;
+}
+
 STATIC int
 pmatch(const char *pattern, const char *string)
 {
@@ -1529,21 +1567,11 @@
} while (*q++ != '\0');
return 0;
case '[': {
-   const char *endp;
+   const char *startp;
int invert, found;
char chr;
 
-   endp = p;
-   if (*endp == '!')
-   endp++;
-   for (;;) {
-   if (*endp == '\0')
-   goto dft;   /* no matching 
] */
-   if (*endp == '\\')
-   endp++;
-   if (*++endp == ']')
-   break;
-   }
+   startp = p;
invert = 0;
if (*p == '!') {
invert++;
@@ -1555,7 +1583,20 @@
return 0;
c = *p++;
do {
-   if (c == '\\')
+   if (!c) {
+   p = startp;
+   c = *p;
+   goto dft;
+   }
+   if (c == '[') {
+   const char *r;
+
+   found |= ccmatch(p, chr, r);
+   if (r) {
+   p = r;
+   continue;
+   }
+   } else if (c == '\\')
c = *p++;
if (*p == '-'  p[1] != ']') {
p++;


Bug#249122: libc6: ldconfig: Creates spurious libncurses.so.5 symlink

2004-05-16 Thread Herbert Xu
On Mon, May 17, 2004 at 11:32:21AM +0900, GOTO Masanori wrote:
 
  However, I still don't think that ldconfig should create symlinks to
  symlinks.  It certainly didn't do that in woody.
 
 Could you tell me the reason?

1. It didn't do that in woody.
2. In this case we're talking about a symlink to a real file in /lib
which has already been processed by ldconfig.  There is no need to have
another symlink in /usr/lib.
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#249122: libc6: ldconfig: Creates spurious libncurses.so.5 symlink

2004-05-16 Thread Herbert Xu
severity 249122 normal
quit

On Sun, May 16, 2004 at 12:00:00AM +0900, GOTO Masanori wrote:

 apt-get source netkit-telnet got netkit-telnet_0.17-22.  I execute
 debuild.  Then I run dpkg-shlibdeps in dpkg-dev 1.10.21:
 
 [EMAIL PROTECTED]:~/debian/sample/netkit-telnet/netkit-telnet-0.17 
 dpkg-shlibdeps debian/tmp/usr/bin/telnet.netkit
 [EMAIL PROTECTED]:~/debian/sample/netkit-telnet/netkit-telnet-0.17 cat 
 debian/substvars 
 shlibs:Depends=libc6 (= 2.3.2.ds1-4), libgcc1 (= 1:3.3.3-1), libncurses5 
 (= 5.4-1), libstdc++5 (= 1:3.3.3-1)

I've found out that this only occurs on my system because I've got

/usr/lib
/lib

listed in /etc/ld.so.conf.

As the default order seems to be /lib:/usr/lib, it isn't as serious as
I thought it was.

However, I still don't think that ldconfig should create symlinks to
symlinks.  It certainly didn't do that in woody.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#249122: libc6: ldconfig: Creates spurious libncurses.so.5 symlink

2004-05-16 Thread Herbert Xu
On Mon, May 17, 2004 at 11:32:21AM +0900, GOTO Masanori wrote:
 
  However, I still don't think that ldconfig should create symlinks to
  symlinks.  It certainly didn't do that in woody.
 
 Could you tell me the reason?

1. It didn't do that in woody.
2. In this case we're talking about a symlink to a real file in /lib
which has already been processed by ldconfig.  There is no need to have
another symlink in /usr/lib.
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#249122: libc6: ldconfig: Creates spurious libncurses.so.5 symlink

2004-05-15 Thread Herbert Xu
Package: libc6
Version: 2.3.2.ds1-12
Severity: serious

I'm marking this bug as RC because it leads to packages being built with
missing dependencies on libncurses5.

When ldconfig is run with libncurses5 + libncurses5-dev installed, it
creates a symlink /usr/lib/libncurses.so.5 that points to libtermcap.so.
The latter is a symlink to libncurses.so which is a symlink to
/lib/libncurses.so.5.

This in itself is no great drama.

However, this totally confuses dpkg-shlibdeps as it fails to determine the
correct shlib dependency for libncurses5.  In fact, it will happily build
packages that use libncurses5 with no dependency on it at all:

$ dpkg-shlibdeps.orig debian/tmp/usr/bin/telnet.netkit
dpkg-shlibdeps.orig: warning: could not find any packages for /usr/lib/libncurses.so.5 
(libncurses.so.5)
dpkg-shlibdeps.orig: warning: unable to find dependency information for shared library 
libncurses (soname 5, path /usr/lib/libncurses.so.5, dependency field Depends)
$ echo $?
0
$ cat debian/substvars
shlibs:Depends=libc6 (= 2.3.2.ds1-4), libgcc1 (= 1:3.3.3-1), libstdc++5 (= 
1:3.3.3-1)
$

Since ldconfig in woody did not create such a symlink, and AFAIK it would
be trivial to avoid doing so by checking whether the target itself is
a symlink, I think ldconfig should be modified so that this symlink is
not created.

However, even after this is fixed we'll need to regularly monitor packages
that use libncurse5 since the developer's systems may still have broken
libncurses symlinks.

-- System Information
Debian Release: testing/unstable
Kernel Version: Linux gondolin 2.4.25-1-686-smp #1 SMP Tue Feb 24 12:07:16 EST 2004 
i686 GNU/Linux

Versions of the packages libc6 depends on:
ii  libdb1-compat  2.1.3-7The Berkeley database routines [glibc 2.0/2.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#249122: libc6: ldconfig: Creates spurious libncurses.so.5 symlink

2004-05-15 Thread Herbert Xu
Package: libc6
Version: 2.3.2.ds1-12
Severity: serious

I'm marking this bug as RC because it leads to packages being built with
missing dependencies on libncurses5.

When ldconfig is run with libncurses5 + libncurses5-dev installed, it
creates a symlink /usr/lib/libncurses.so.5 that points to libtermcap.so.
The latter is a symlink to libncurses.so which is a symlink to
/lib/libncurses.so.5.

This in itself is no great drama.

However, this totally confuses dpkg-shlibdeps as it fails to determine the
correct shlib dependency for libncurses5.  In fact, it will happily build
packages that use libncurses5 with no dependency on it at all:

$ dpkg-shlibdeps.orig debian/tmp/usr/bin/telnet.netkit
dpkg-shlibdeps.orig: warning: could not find any packages for 
/usr/lib/libncurses.so.5 (libncurses.so.5)
dpkg-shlibdeps.orig: warning: unable to find dependency information for shared 
library libncurses (soname 5, path /usr/lib/libncurses.so.5, dependency field 
Depends)
$ echo $?
0
$ cat debian/substvars
shlibs:Depends=libc6 (= 2.3.2.ds1-4), libgcc1 (= 1:3.3.3-1), libstdc++5 (= 
1:3.3.3-1)
$

Since ldconfig in woody did not create such a symlink, and AFAIK it would
be trivial to avoid doing so by checking whether the target itself is
a symlink, I think ldconfig should be modified so that this symlink is
not created.

However, even after this is fixed we'll need to regularly monitor packages
that use libncurse5 since the developer's systems may still have broken
libncurses symlinks.

-- System Information
Debian Release: testing/unstable
Kernel Version: Linux gondolin 2.4.25-1-686-smp #1 SMP Tue Feb 24 12:07:16 EST 
2004 i686 GNU/Linux

Versions of the packages libc6 depends on:
ii  libdb1-compat  2.1.3-7The Berkeley database routines [glibc 2.0/2.




Bug#247436: libc6-dev: odd dev_t/varargs behavior

2004-05-05 Thread Herbert Xu
Andres Salomon [EMAIL PROTECTED] wrote:
 Package: libc6-dev
 Version: 2.3.2.ds1-12
 Severity: normal
 
 I'm seeing some very odd behavior with dev_t (defined in linux/kdev_t.h)
 and varargs.  I have the following source file:
 
 #include stdio.h
 #include sys/types.h
 #include linux/kdev_t.h
   
  
 int main(void)
 {
dev_t x = 0x3af;
printf(%x %x\n, ((x)8), ((x)0xff));
return 0;
 }
 
 
 One would think that this would print out 3 af; however, it displays
 3 0.  If I change that printf to:
printf(%x %x %x\n, ((x)8), ((x)0xff));

Please review the C promotion rules.

The 2nd and 3rd arguments are 64-bits long, and therefore they get pushed
onto the stack as 64-bit values.  Your use of the %x conversion is
therefore incorrect.

In fact, gcc -Wall should've told you about it.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#243885: Bug#240887: Package building problem.

2004-04-18 Thread Herbert Xu
On Sat, Apr 17, 2004 at 10:44:27PM +0200, Kurt Roeckx wrote:
 
 If I understand Herbert Xu correctly, he's saying the regex
 should be written as:
 *[][~#$^*(){}\|;?]*

No, the way it's written currently is fine.

It's glibc's fnmatch(3) implementation that's broken.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: Bug#240887: Package building problem.

2004-04-18 Thread Herbert Xu
Kurt Roeckx [EMAIL PROTECTED] wrote:

 Not quite.  In the context of case patterns and fnmatch, quote removal
 is not performed.
 
 You mean fnmatch() gets called with the FNM_NOESCAPE flag?

No.  I mean that on the input path to fnmatch(), the escape characters
have to be there.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: Bug#240887: Package building problem.

2004-04-18 Thread Herbert Xu
On Sat, Apr 17, 2004 at 10:44:27PM +0200, Kurt Roeckx wrote:
 
 If I understand Herbert Xu correctly, he's saying the regex
 should be written as:
 *[][~#$^*(){}\|;?]*

No, the way it's written currently is fine.

It's glibc's fnmatch(3) implementation that's broken.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#243885: Bug#240887: Package building problem.

2004-04-18 Thread Herbert Xu
Kurt Roeckx [EMAIL PROTECTED] wrote:

 Not quite.  In the context of case patterns and fnmatch, quote removal
 is not performed.
 
 You mean fnmatch() gets called with the FNM_NOESCAPE flag?

No.  I mean that on the input path to fnmatch(), the escape characters
have to be there.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#243885: Bug#240887: Package building problem.

2004-04-16 Thread Herbert Xu
On Fri, Apr 16, 2004 at 08:49:14PM +0200, Kurt Roeckx wrote:

 After reading all that you have to get confused about what [\[\]\\] means.
 At the highest level it says that the '\' should be discarded,

Not quite.  In the context of case patterns and fnmatch, quote removal
is not performed.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#243885: Bug#240887: Package building problem.

2004-04-16 Thread Herbert Xu
On Fri, Apr 16, 2004 at 08:49:14PM +0200, Kurt Roeckx wrote:

 After reading all that you have to get confused about what [\[\]\\] means.
 At the highest level it says that the '\' should be discarded,

Not quite.  In the context of case patterns and fnmatch, quote removal
is not performed.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#240887: Package building problem.

2004-04-15 Thread Herbert Xu
clone 240887 -1
retitle -1 fnmatch breaks on [\]]
submitter -1 [EMAIL PROTECTED]
reassign -1 libc6
tags 240887 pending
quit

On Wed, Apr 14, 2004 at 01:59:01PM +0200, Frank K?ster wrote:
 
 This is how dash calls it in _some_ subdirectories:
 
 configuring in tetex
 running /bin/sh ./configure  --prefix=/usr --enable-ipc --without-dialog\
   --without-texinfo --with-system-ncurses --with-x --with-system-zlib \
   --with-system-pnglib --with-system-tifflib --with-system-wwwlib \
   --with-system-t1lib --disable-multiplatform --enable-shared \
   --mandir=/usr/share/man --infodir=${prefix}/share/info \
   --cache-file=.././config.cache --srcdir=.
 loading cache .././config.cache
 
 That is, dash replaced the first occurence of ${prefix} by the variable
 expansion. This shouldn't happen, because it is enclosed in single
 quotes. 

This is caused by dash's use of fnmatch(3) which appears to break
on patterns containing [\]...].

Here is a sample program to demonstrate it.

#include stdio.h
#include fnmatch.h

int main(int argc, char **argv)
{
printf(%d\n, fnmatch([\\]a], a, 0));
return 0;
}

I will disable fnmatch(3) in dash for now.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: Bug#240887: Package building problem.

2004-04-15 Thread Herbert Xu
clone 240887 -1
retitle -1 fnmatch breaks on [\]]
submitter -1 [EMAIL PROTECTED]
reassign -1 libc6
tags 240887 pending
quit

On Wed, Apr 14, 2004 at 01:59:01PM +0200, Frank K?ster wrote:
 
 This is how dash calls it in _some_ subdirectories:
 
 configuring in tetex
 running /bin/sh ./configure  --prefix=/usr --enable-ipc --without-dialog\
   --without-texinfo --with-system-ncurses --with-x --with-system-zlib \
   --with-system-pnglib --with-system-tifflib --with-system-wwwlib \
   --with-system-t1lib --disable-multiplatform --enable-shared \
   --mandir=/usr/share/man --infodir=${prefix}/share/info \
   --cache-file=.././config.cache --srcdir=.
 loading cache .././config.cache
 
 That is, dash replaced the first occurence of ${prefix} by the variable
 expansion. This shouldn't happen, because it is enclosed in single
 quotes. 

This is caused by dash's use of fnmatch(3) which appears to break
on patterns containing [\]...].

Here is a sample program to demonstrate it.

#include stdio.h
#include fnmatch.h

int main(int argc, char **argv)
{
printf(%d\n, fnmatch([\\]a], a, 0));
return 0;
}

I will disable fnmatch(3) in dash for now.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#240887: Package building problem.

2004-04-15 Thread Herbert Xu
reopen 243885
reassign 240887 dash
retitle 240887 fnmatch(3) is broken
quit

On Fri, Apr 16, 2004 at 08:09:05AM +1000, herbert wrote:
 
 On Thu, Apr 15, 2004 at 03:10:58PM +0100, Colin Watson wrote:

  Accordingly, I believe that the pattern in your example means
  backslash, followed by a, followed by closing square bracket, not what
  you think it means.
 
 You're quite right.  This is reaffirmed by the POSIX document for
 basic regular expressions, which is what POSIX uses to define
 shell patterns.

Sorry guys, but this turns out to be wrong.  POSIX has an additional
paragraph which I skipped earlier:

: When pattern matching is used where shell quote removal is not performed
: (such as in the argument to the find -name primary when find is being
: called using one of the exec functions as defined in the System
: Interfaces volume of IEEE Std 1003.1-200x, or in the pattern argument
: to the fnmatch( ) function), special characters can be escaped to remove
: their special meaning by preceding them with a backslash character. This
: escaping back slash is discarded. The sequence \\ represents one literal
: backslash. All of the requirements and effects of quoting on ordinary,
: shell special, and special pattern characters shall apply to escaping
: in this context.

This clearly says that backslashes must be interpreted.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#92186: [Fwd: Test case, seems fine.]

2004-04-12 Thread Herbert Xu
retitle 92186 libc6: getpwnam(3) should distinguish between NIS errors and user not 
found
close 239011
quit

On Sun, Dec 21, 2003 at 12:25:25AM -0500, Jeff Bailey wrote:
 
 I've built a testcase for looking at this.  When I run it, I get:
 
 ./a.out
 No match found!  Errno: 0
 
 Can you please provide a better testcase?  Otherwise, I'll assume the
 bug is fixed and close it (By the end of January or so)

Well yes that's good.  However, it is also setting errno to zero when
the NIS server is unavilable.  This means that the application still
can't distinguish between the two errors.

Thanks,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#231538: A possible solution

2004-03-02 Thread Herbert Xu
On Tue, Mar 02, 2004 at 04:22:30PM +0900, GOTO Masanori wrote:
 
  Well newer initrd-tools module-init-tools should be in woody 
  in order to upgrade to sarge smoothly.
 
 Is this ok?  Herbert?  Marco?  If not, I reassign this bug to such
 packages.

initrd-tools does not depend on glibc so the version in sarge/sid
should suffice.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#231538: libc6: illegal instruction on a 386

2004-02-08 Thread Herbert Xu
On Sun, Feb 08, 2004 at 09:43:30AM +0100, Matthias Klose wrote:
 Karolina Lindqvist writes:
  l?rdagen den 7 februari 2004 18.01 you wrote:
   This is not a bug, i386 support is dropped, gcc is configured to
   generate code for i486 and up. IIRC the kernel binaries for i386 do
   have a patch for emulation support for non-i386 instructions.
  
  So it's not a bug, but a feature. I could have gussed that. It would be 
  helpful if libc6, or something, actually had a Depend on the required kernel 
  version. 
  I am running a vanilla debian kernel,  2.4.18-1-386 version 2.4.18.12-1, on 
  that machine, which obviously is not enough. 
  The corresponding kernel from sid is called
  2.4.18-386 version 2.4.18-5. Will it solve the problem?
  Confusing.
 
 don't know about the exact kernel package...
 
 maybe the report should be kept open to document forht release, that
 sun4c, armv? and i386 arre not supported anymore.

2.4.18 is not in sid.  However, 2.4.24/2.6.0 in sid should both
emulate the needed instructions on 386.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#231538: libc6: illegal instruction on a 386

2004-02-08 Thread Herbert Xu
On Sun, Feb 08, 2004 at 09:43:30AM +0100, Matthias Klose wrote:
 Karolina Lindqvist writes:
  l?rdagen den 7 februari 2004 18.01 you wrote:
   This is not a bug, i386 support is dropped, gcc is configured to
   generate code for i486 and up. IIRC the kernel binaries for i386 do
   have a patch for emulation support for non-i386 instructions.
  
  So it's not a bug, but a feature. I could have gussed that. It would be 
  helpful if libc6, or something, actually had a Depend on the required 
  kernel 
  version. 
  I am running a vanilla debian kernel,  2.4.18-1-386 version 2.4.18.12-1, on 
  that machine, which obviously is not enough. 
  The corresponding kernel from sid is called
  2.4.18-386 version 2.4.18-5. Will it solve the problem?
  Confusing.
 
 don't know about the exact kernel package...
 
 maybe the report should be kept open to document forht release, that
 sun4c, armv? and i386 arre not supported anymore.

2.4.18 is not in sid.  However, 2.4.24/2.6.0 in sid should both
emulate the needed instructions on 386.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#218607: More about this bug

2003-11-03 Thread Herbert Xu
On Tue, Nov 04, 2003 at 01:49:04AM +0900, GOTO Masanori wrote:
 
 I would like to know Herbert opinion.
 
 The problem to provide linux-kernel-headers-24 (linux-kernel-headers
 including 2.4 kernel) is: this is not part of glibc-built headers.  So
 I think providing symlink in kernel-headers-2.4 is better.

No that's a terrible idea.  LILO should simply include a copy of whatever
kernel header file it needs.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#216921: Can't compile programs, using kernel headers from experimental libc6-dev

2003-10-22 Thread Herbert Xu
Dmitry Baryshkov [EMAIL PROTECTED] wrote:
 
 It IS a bug. Some programs (i.e. MPlayer) used (and use) them to in 
 compilation.

Buggy programs do not always fail.

 This worked with previous versions of libc, but doesn't work now. If this is
 a 'feature', then what do you recommed? Duplicate info from this headers and
 include it in program's sources? IIUC - that's why such headers exists in 
 libc6-dev package - to let programs to use them, isn't it?

Yes please create local copies of those header files.

The header files exist in libc6-dev because the latter includes
the complete set of headers from the kernel.  It is not a guarantee
that you can include them in userspace.

You should treat them the same way as headers in /usr/include/bits --
never include them directly.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#216921: Can't compile programs, using kernel headers from experimental libc6-dev

2003-10-22 Thread Herbert Xu
Dmitry Baryshkov [EMAIL PROTECTED] wrote:
 
 It IS a bug. Some programs (i.e. MPlayer) used (and use) them to in compilation.

Buggy programs do not always fail.

 This worked with previous versions of libc, but doesn't work now. If this is
 a 'feature', then what do you recommed? Duplicate info from this headers and
 include it in program's sources? IIUC - that's why such headers exists in 
 libc6-dev package - to let programs to use them, isn't it?

Yes please create local copies of those header files.

The header files exist in libc6-dev because the latter includes
the complete set of headers from the kernel.  It is not a guarantee
that you can include them in userspace.

You should treat them the same way as headers in /usr/include/bits --
never include them directly.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: This bug also affects d-i on alpha

2003-09-24 Thread Herbert Xu
reassign 212101 libc6.1-dev
quit

On Mon, Sep 22, 2003 at 11:42:17AM -0500, Steve Langasek wrote:
 reopen 212101
 thanks
 
 On Mon, Sep 22, 2003 at 10:11:11PM +1000, Herbert Xu wrote:
  On Sun, Sep 21, 2003 at 10:58:11PM -0500, Steve Langasek wrote:
   clone 210359 -1
   reassign -1 kernel-image-2.4.22-alpha
 
   This bug also affects the alpha build of busybox.  It isn't a problem
   generally, because most architectures don't include linux/config.h
   from asm/param.h.
 
  The current upstream policy is to not support userspace applications
  which include kernel header files.
 
  So unless that policy changes, or this patch is accepted by the
  upstream maintainer, I will not accept it.
 
 Then please reassign to libc6.1 if that's where you think the problem
 lies.  /usr/include/sys/param.h currently pollutes the macro namespace,
 and *something* needs to be changed to fix this.

Done.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: This bug also affects d-i on alpha

2003-09-24 Thread Herbert Xu
reassign 212101 libc6.1-dev
quit

On Mon, Sep 22, 2003 at 11:42:17AM -0500, Steve Langasek wrote:
 reopen 212101
 thanks
 
 On Mon, Sep 22, 2003 at 10:11:11PM +1000, Herbert Xu wrote:
  On Sun, Sep 21, 2003 at 10:58:11PM -0500, Steve Langasek wrote:
   clone 210359 -1
   reassign -1 kernel-image-2.4.22-alpha
 
   This bug also affects the alpha build of busybox.  It isn't a problem
   generally, because most architectures don't include linux/config.h
   from asm/param.h.
 
  The current upstream policy is to not support userspace applications
  which include kernel header files.
 
  So unless that policy changes, or this patch is accepted by the
  upstream maintainer, I will not accept it.
 
 Then please reassign to libc6.1 if that's where you think the problem
 lies.  /usr/include/sys/param.h currently pollutes the macro namespace,
 and *something* needs to be changed to fix this.

Done.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#203303: glibc: gcc3.3 complains swab.h fails to conform to ISO standard

2003-08-14 Thread Herbert Xu
GOTO Masanori [EMAIL PROTECTED] wrote:
 
 Could you try new glibc 2.3.2-2?  And I think it's not glibc problem.
 If you still get errors with 2.3.2-2, please reassign it to
 kernel-headers-2.4.21-3.

No please don't.  User space should never include kernel header files.

glibc has been violating this rule since day one.  That's OK except
that when it breaks you get to keep both pieces.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#155751: sed is using its own regex engine again

2003-04-04 Thread Herbert Xu
reassign 65458 sed
quit

It seems that the reason sed has slowed down again is because it's using
its own regex engine again.  So I'm now reassigning this back there.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



manpages-dev is correct about strerror_t

2003-03-25 Thread Herbert Xu
reassign 159298 libc6
quit

The declaration of strerror_tin manpages-dev conforms with SuS.  glibc
should be changed to match with it.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



manpages-dev is correct about strerror_t

2003-03-25 Thread Herbert Xu
reassign 159298 libc6
quit

The declaration of strerror_tin manpages-dev conforms with SuS.  glibc
should be changed to match with it.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#185485: telnet: resolving ip in decimal form stopped working

2003-03-19 Thread Herbert Xu
reassign 185485 libc6
quit

On Wed, Mar 19, 2003 at 12:23:47PM -0500, Justin A wrote:
 Package: telnet
 Version: 0.17-19
 Severity: minor
 Tags: upstream
 
 telnet has stopped being able to resolve addresses that are in decimal...
 i.e.
 
 $ telnet 0 22
 telnet: could not resolve 0/22: Name or service not known
 
 $ telnet 0.0.0.0 22
 Trying 0.0.0.0...
 Connected to 0.0.0.0.
 Escape character is '^]'.
 SSH-2.0-OpenSSH_3.5p1 Debian 1:3.5p1-5
 etc...

All resolutions are done through libc6, so the bug belongs there.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: Bug#185485: telnet: resolving ip in decimal form stopped working

2003-03-19 Thread Herbert Xu
reassign 185485 libc6
quit

On Wed, Mar 19, 2003 at 12:23:47PM -0500, Justin A wrote:
 Package: telnet
 Version: 0.17-19
 Severity: minor
 Tags: upstream
 
 telnet has stopped being able to resolve addresses that are in decimal...
 i.e.
 
 $ telnet 0 22
 telnet: could not resolve 0/22: Name or service not known
 
 $ telnet 0.0.0.0 22
 Trying 0.0.0.0...
 Connected to 0.0.0.0.
 Escape character is '^]'.
 SSH-2.0-OpenSSH_3.5p1 Debian 1:3.5p1-5
 etc...

All resolutions are done through libc6, so the bug belongs there.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#65458: acknowledged by developer (Bug#155751: fixed in glibc 2.3.1-15)

2003-03-18 Thread Herbert Xu
On Tue, Mar 18, 2003 at 11:15:29AM +0900, GOTO Masanori wrote:
 At Tue, 18 Mar 2003 12:08:35 +1100,
 Herbert Xu wrote:
  On Mon, Mar 17, 2003 at 06:03:18AM -0600, Debian Bug Tracking System wrote:
- Glibc 2.3 uses another regex engine: sed: woody version more than
  1000 times slower than potato version should be fixed.
  (Closes: #155751)
  
  Did you actually test it?
 
 Yes.  Please check yourself.

If you take a look at #65458, then you would find that the speed is much
worse compared to woody.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#65458: acknowledged by developer (Bug#155751: fixed in glibc 2.3.1-15)

2003-03-17 Thread Herbert Xu
reopen 65458
quit

On Mon, Mar 17, 2003 at 06:03:18AM -0600, Debian Bug Tracking System wrote:
  - Glibc 2.3 uses another regex engine: sed: woody version more than
1000 times slower than potato version should be fixed.
(Closes: #155751)

Did you actually test it?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#65458: acknowledged by developer (Bug#155751: fixed in glibc 2.3.1-15)

2003-03-17 Thread Herbert Xu
reopen 65458
quit

On Mon, Mar 17, 2003 at 06:03:18AM -0600, Debian Bug Tracking System wrote:
  - Glibc 2.3 uses another regex engine: sed: woody version more than
1000 times slower than potato version should be fixed.
(Closes: #155751)

Did you actually test it?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#183081: libc6-dev: hppa: bug in byteorder.h and swab.h

2003-03-02 Thread Herbert Xu
Stephen Gran [EMAIL PROTECTED] wrote:
 
 Ah, I see that now.  I checked with dpkg -S, but didn't look further.
 Because of what appear to be largely syntactic errors in these two
 headers, the build failed, but only on hppa.  I guess this needs to be
 reassigned to the kernel.  Sorry about that.

No you should close this.  User space programs must not include kernel
headers.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: help needed for defining hppa __clz_tab gcc-compat symbol

2003-02-28 Thread Herbert Xu
Randolph Chung [EMAIL PROTECTED] wrote:
 
 I've created a libgcc-compat.c that has something like this:
 
 #if SHLIB_COMPAT(libc, GLIBC_2_2, GLIBC_2_2_6)
 symbol_version (__clz_tab_internal, __clz_tab, GLIBC_2.2);
 typedef unsigned int UQItype  __attribute__ ((mode (QI)));
 static const UQItype __clz_tab_internal[] = { ... }
  ^^

Try getting rid of that?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: impossible to upgrade

2003-02-14 Thread Herbert Xu
Fumitoshi UKAI [EMAIL PROTECTED] wrote:
 
 So, I try to install kernel-image-2.4.19-64, but it has the following
 dependencies
 
  Package: kernel-image-2.4.19-64
  Version: 22.2
  Depends: initrd-tools (= 0.1.6), fileutils (= 4.0), modutils (= 2.3.12)
 
  Package: initrd-tools 
  Version: 0.1.36
  Depends: coreutils | fileutils (= 4.1.9) | stat (= 3.0), cpio, cramfsprogs, dash 
| ash, modutils (= 2.3.13), util-linux (= 2.11b-3)
 
  Package: dash
  Version: 0.4.10
  Pre-Depends: libc6 (= 2.3.1-1)
 
  Package: ash
  Version: 0.4.10
  Pre-Depends: dash
 
 So, installing kernel-image-24.19-64 requires that libc6 (=2 3.1-1) is
 already installed, but that is what to do after kernel-image-2.4.19-64
 installed.  Other packages that initrd-tools depends on also have
 dependency to newer libc6 (= 2.3.1-1) that I installed currently (2.2.5-14).

The ash package from woody should do the trick, no?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#70762: textutils: tail segfault

2002-11-16 Thread Herbert Xu
On Sat, Nov 16, 2002 at 08:02:43PM -0500, H. S. Teoh wrote:
 
 I guess the question is, at what point do we say, this is enough for
 practical purposes, we'll stop here? Or is it OK to let tail consume
 resources until it eats up everything and dies?

That's why we have resource limits.  The only bug here is that glibc
mallocs in fprintf which means that we can't print out a useful error
message when the memory is all used up.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#70762: textutils: tail segfault

2002-11-16 Thread Herbert Xu
On Sat, Nov 16, 2002 at 08:18:40PM -0500, H. S. Teoh wrote:
 
 Why does it have to use fprintf? It's hard to imagine fprintf() not

Read the coreutils source code.

 requiring to malloc any buffers, since it *is* supposed to handle output
 to files, and it has to parse  expand format strings, etc.. Perhaps the
 real issue is that fatal error messages should not be output through
 fprintf, but a special, last-resort output facility that doesn't require
 extra memory.

I can think of quite a few ways to do fprintf(%s: , s) without using
malloc.  In the fact, you can find a mallocless implementation in the
Linux kernel.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#70762: textutils: tail segfault

2002-11-16 Thread Herbert Xu
On Sat, Nov 16, 2002 at 08:02:43PM -0500, H. S. Teoh wrote:
 
 I guess the question is, at what point do we say, this is enough for
 practical purposes, we'll stop here? Or is it OK to let tail consume
 resources until it eats up everything and dies?

That's why we have resource limits.  The only bug here is that glibc
mallocs in fprintf which means that we can't print out a useful error
message when the memory is all used up.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#70762: textutils: tail segfault

2002-11-16 Thread Herbert Xu
On Sat, Nov 16, 2002 at 08:18:40PM -0500, H. S. Teoh wrote:
 
 Why does it have to use fprintf? It's hard to imagine fprintf() not

Read the coreutils source code.

 requiring to malloc any buffers, since it *is* supposed to handle output
 to files, and it has to parse  expand format strings, etc.. Perhaps the
 real issue is that fatal error messages should not be output through
 fprintf, but a special, last-resort output facility that doesn't require
 extra memory.

I can think of quite a few ways to do fprintf(%s: , s) without using
malloc.  In the fact, you can find a mallocless implementation in the
Linux kernel.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#70762: textutils: tail segfault

2002-11-15 Thread Herbert Xu
H. S. Teoh [EMAIL PROTECTED] wrote:
 
 But the original bug seems to be more of an issue: shouldn't it be a bug
 that tail chews up infinite amounts of memory when it can't find an
 end-of-line char? IMHO, tail should just bail out when it finds a line
 which is more than, say 10MB long (I'm being generous about limits here). 
 I mean, when there is no newline for 10MB's worth of data, is there even
 any usefulness to tail anymore? I just can't imagine any scenario where
 it'd actually do anything *useful*.

No, we should not impose arbitrary limits on applications.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#70762: textutils: tail segfault

2002-11-15 Thread Herbert Xu
On Fri, Nov 15, 2002 at 08:23:24AM -0500, Jeff Bailey wrote:
 On Fri, 2002-11-15 at 04:00, Herbert Xu wrote:
 
   But the original bug seems to be more of an issue: shouldn't it be a bug
   that tail chews up infinite amounts of memory when it can't find an
   end-of-line char? IMHO, tail should just bail out when it finds a line
   which is more than, say 10MB long (I'm being generous about limits here). 
   I mean, when there is no newline for 10MB's worth of data, is there even
   any usefulness to tail anymore? I just can't imagine any scenario where
   it'd actually do anything *useful*.
 
  No, we should not impose arbitrary limits on applications.
 
 Sure, but it would also be reasonable to flush the buffer to the screen
 every (screensize/2) so that a human could follow it.

Tail can't do that until it finds the new lines...
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#70762: textutils: tail segfault

2002-11-15 Thread Herbert Xu
H. S. Teoh [EMAIL PROTECTED] wrote:
 
 But the original bug seems to be more of an issue: shouldn't it be a bug
 that tail chews up infinite amounts of memory when it can't find an
 end-of-line char? IMHO, tail should just bail out when it finds a line
 which is more than, say 10MB long (I'm being generous about limits here). 
 I mean, when there is no newline for 10MB's worth of data, is there even
 any usefulness to tail anymore? I just can't imagine any scenario where
 it'd actually do anything *useful*.

No, we should not impose arbitrary limits on applications.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#70762: textutils: tail segfault

2002-11-15 Thread Herbert Xu
On Fri, Nov 15, 2002 at 08:23:24AM -0500, Jeff Bailey wrote:
 On Fri, 2002-11-15 at 04:00, Herbert Xu wrote:
 
   But the original bug seems to be more of an issue: shouldn't it be a bug
   that tail chews up infinite amounts of memory when it can't find an
   end-of-line char? IMHO, tail should just bail out when it finds a line
   which is more than, say 10MB long (I'm being generous about limits here). 
   I mean, when there is no newline for 10MB's worth of data, is there even
   any usefulness to tail anymore? I just can't imagine any scenario where
   it'd actually do anything *useful*.
 
  No, we should not impose arbitrary limits on applications.
 
 Sure, but it would also be reasonable to flush the buffer to the screen
 every (screensize/2) so that a human could follow it.

Tail can't do that until it finds the new lines...
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#70762: textutils: tail segfault

2002-11-15 Thread Herbert Xu
On Fri, Nov 15, 2002 at 01:22:44PM -0800, Jeff Bailey wrote:
 On Sat, Nov 16, 2002 at 08:10:22AM +1100, Herbert Xu wrote:
 
   Sure, but it would also be reasonable to flush the buffer to the screen
   every (screensize/2) so that a human could follow it.
 
  Tail can't do that until it finds the new lines...
 
 s/can't/doesn't/ ? Sounds like an upstream bug...

Huh? tail is meant to show you the last ten lines.  Until you've read
all the output, how are you meant to know whether they're the last ten?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#167608: ldd: ./: No such file or directory

2002-11-05 Thread Herbert Xu
Clint Adams [EMAIL PROTECTED] wrote:
 
 I do imagine that the explicit specification is more portable though.

According to the autoconf portability document, for a do is more
portable since some shells don't do $@ correctly.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#167608: ldd: ./: No such file or directory

2002-11-05 Thread Herbert Xu
Clint Adams [EMAIL PROTECTED] wrote:
 
 I do imagine that the explicit specification is more portable though.

According to the autoconf portability document, for a do is more
portable since some shells don't do $@ correctly.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#167608: ldd: ./: No such file or directory

2002-11-04 Thread Herbert Xu
Randolph Chung [EMAIL PROTECTED] wrote:

 ldd is doing is correct. The offending line is line 113 of ldd:
 
113 for file do


This is legal.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#167608: ldd: ./: No such file or directory

2002-11-04 Thread Herbert Xu
Randolph Chung [EMAIL PROTECTED] wrote:

 ldd is doing is correct. The offending line is line 113 of ldd:
 
113 for file do


This is legal.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#167409: glibc 2.3.1: breaks XEmacs builds; system breaks on revert to 2.2.5

2002-11-02 Thread Herbert Xu
Mark Brown [EMAIL PROTECTED] wrote:
 
 You need to downgrade everything that depends on the new libc before
 downgrading libc itself.  dpkg should have told you this when you were
 doing the downgrade (IIRC it should have required some explicit
 cooercion to do the downgrade).

1. dpkg does --force-downgrade by default
2. dpkg will let you break the depenedencies of packages that are already
   installed
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#167409: glibc 2.3.1: breaks XEmacs builds; system breaks on revert to 2.2.5

2002-11-02 Thread Herbert Xu
Mark Brown [EMAIL PROTECTED] wrote:
 
 You need to downgrade everything that depends on the new libc before
 downgrading libc itself.  dpkg should have told you this when you were
 doing the downgrade (IIRC it should have required some explicit
 cooercion to do the downgrade).

1. dpkg does --force-downgrade by default
2. dpkg will let you break the depenedencies of packages that are already
   installed
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#166419: RPC: Can't encode arguments

2002-10-26 Thread Herbert Xu
Package: libc6.1
Version: 2.2.5-11.2

My syslog is getting flooded by messages from ypbind:

Oct 26 11:45:10 cardolan.me.apana.org.au ypbind[215]: broadcast: RPC: Can't 
encode arguments.
Oct 26 11:45:50 cardolan.me.apana.org.au last message repeated 2 times
Oct 26 11:47:10 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:48:30 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:49:50 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:51:10 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:52:31 cardolan.me.apana.org.au last message repeated 4 times

According to #142312, this is a bug in glibc.  Could you please do
something about this as that bug has been outstanding for 6 months
now with no comment from any glibc maintainers?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#166419: RPC: Can't encode arguments

2002-10-25 Thread Herbert Xu
Package: libc6.1
Version: 2.2.5-11.2

My syslog is getting flooded by messages from ypbind:

Oct 26 11:45:10 cardolan.me.apana.org.au ypbind[215]: broadcast: RPC: Can't encode 
arguments.
Oct 26 11:45:50 cardolan.me.apana.org.au last message repeated 2 times
Oct 26 11:47:10 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:48:30 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:49:50 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:51:10 cardolan.me.apana.org.au last message repeated 4 times
Oct 26 11:52:31 cardolan.me.apana.org.au last message repeated 4 times

According to #142312, this is a bug in glibc.  Could you please do
something about this as that bug has been outstanding for 6 months
now with no comment from any glibc maintainers?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#38468: Why is this assigned to libc6?

2002-10-22 Thread Herbert Xu
Jeff Bailey [EMAIL PROTECTED] wrote:
 Can you please provide a testcase that shows that this bug actually
 belongs to glibc?  

Ugh, did you notice that rcmd(3) is part of glibc?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Re: Bug#165881: telnetd aborts when EAGAIN returned from writev

2002-10-22 Thread Herbert Xu
reassign 165881 libc6
quit

On Tue, Oct 22, 2002 at 05:57:19AM -0600, John Marvin wrote:
 
 However, the code checks for EWOULDBLOCK, not EAGAIN. Other Unix OS's
 might use EWOULDBLOCK in this case, but Linux uses EAGAIN. You should
 not get an EWOULDBLOCK from a write or writev call (I think Linux only
 uses EWOULDBLOCK for file locking).

Looks like a bug in glibc since it's meant to make the two symbols
identical:

 - Macro: int EAGAIN
 Resource temporarily unavailable; the call might work if you try
 again later.  The macro `EWOULDBLOCK' is another name for `EAGAIN';
 they are always the same in the GNU C library.

Why does parisc differentiate the two anyway? Every other Linux
architecture treats them the same way.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#38468: Why is this assigned to libc6?

2002-10-22 Thread Herbert Xu
Jeff Bailey [EMAIL PROTECTED] wrote:
 Can you please provide a testcase that shows that this bug actually
 belongs to glibc?  

Ugh, did you notice that rcmd(3) is part of glibc?
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#165881: telnetd aborts when EAGAIN returned from writev

2002-10-22 Thread Herbert Xu
reassign 165881 libc6
quit

On Tue, Oct 22, 2002 at 05:57:19AM -0600, John Marvin wrote:
 
 However, the code checks for EWOULDBLOCK, not EAGAIN. Other Unix OS's
 might use EWOULDBLOCK in this case, but Linux uses EAGAIN. You should
 not get an EWOULDBLOCK from a write or writev call (I think Linux only
 uses EWOULDBLOCK for file locking).

Looks like a bug in glibc since it's meant to make the two symbols
identical:

 - Macro: int EAGAIN
 Resource temporarily unavailable; the call might work if you try
 again later.  The macro `EWOULDBLOCK' is another name for `EAGAIN';
 they are always the same in the GNU C library.

Why does parisc differentiate the two anyway? Every other Linux
architecture treats them the same way.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#165881: telnetd aborts when EAGAIN returned from writev

2002-10-22 Thread Herbert Xu
On Wed, Oct 23, 2002 at 10:16:47AM +0900, GOTO Masanori wrote:
 
  Looks like a bug in glibc since it's meant to make the two symbols
  identical:
  
   - Macro: int EAGAIN
   Resource temporarily unavailable; the call might work if you try
   again later.  The macro `EWOULDBLOCK' is another name for `EAGAIN';
   they are always the same in the GNU C library.
 
 At least, it's not glibc's bug.

Then you better change the documentation and tell the world about it.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#164638: libc6-dev: SIOCSIFNAME needs to be added

2002-10-14 Thread Herbert Xu
reopen 164638
quit

On Mon, Oct 14, 2002 at 12:20:00AM -0400, Ben Collins wrote:
 On Mon, Oct 14, 2002 at 11:51:20AM +1000, [EMAIL PROTECTED] wrote:
  Package: libc6-dev
  Version: 2.2.5-14.3
  Severity: normal
  
  Please add this line to bits/ioctls.h:
  
  #define SIOCSIFNAME0x8923  /* set interface name */
 
 ioctl's are not defined by libc headers.

In that case please remove bits/ioctls.h.

 Aside from that, this ioctl is indeed defined in linux/sockios.h, which
 is included by bits/ioctls.h, which is then included by sys/ioctl.h. So
 doing:

Well in 2.2.5-14.3, bits/ioctls.h does not include linux/sockios.h.

$ grep ^.include /usr/include/bits/ioctls.h
#include asm/ioctls.h
$

 #include sys/ioctl.h
 
 Will get you what you want. E.g.
 
 
 hopper:~# cat test.c
 #include sys/ioctl.h
 
 int main() {
 printf(0x%04x\n, SIOCSIFNAME);
 return 0;
 }
 hopper:~# gcc -o test test.c

Well your libc6-dev appears to differ from mine:

$ gcc -o test test.c
test.c: In function `main':
test.c:4: `SIOCSIFNAME' undeclared (first use in this function)
test.c:4: (Each undeclared identifier is reported only once
test.c:4: for each function it appears in.)
$
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#162576: marked as done (libc6-dev: errno is a function call in non-threaded program)

2002-09-29 Thread Herbert Xu

On Sun, Sep 29, 2002 at 10:44:40AM +0200, Florian Weimer wrote:
 Herbert Xu [EMAIL PROTECTED] writes:

  No you don't, all you need to do is to make the errno macro
  conditional.
 
 And if we do that, libraries which use the non-macro version will come
 into existence sooner or later, and we lose.

Not if you make it the default behaviour threaded and have the
non-macro version available conditionally.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#162576: marked as done (libc6-dev: errno is a function call in non-threaded program)

2002-09-28 Thread Herbert Xu

Florian Weimer [EMAIL PROTECTED] wrote:
 
 The slowdown is a price to be paid, otherwise we would need a
 different set of almost all shared libraries for linking with
 multi-threading programs.  I think we already had this situation, and
 it wasn't nice at all.

No you don't, all you need to do is to make the errno macro conditional.
You already have to support people not including errno.h...
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#162576: libc6-dev: errno is a function call in non-threaded program

2002-09-27 Thread Herbert Xu

On Fri, Sep 27, 2002 at 08:14:23PM -0400, Ben Collins wrote:
 
 Heh, this is too easy :)
 
 #include errno.h
 #undef errno
 extern int errno;
 
 But that's not what you wanted, I suspect :)

Well no, I'd rather do it without modifying the application :)
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Re: Intent to (N)?MU 2.2.5-14

2002-09-12 Thread Herbert Xu

Jeff Bailey [EMAIL PROTECTED] wrote:
 
 I only object to the extent that I don't think everyone who's been
 looking at the Alpha patch has agreed that it's right, otherwise I
 would've done the upload yesterday.  If everyone agrees, the current
 plan is to do it tonight.

As I have pointed out in the BTS entry, this bug can't be that bad since
it's been around for at least five years, in both glibc and Linux.

Anyway, you can always disable the assembly version completely until a
fixed version becomes available.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Bug#159633: strncpy on alpha/libc broken

2002-09-08 Thread Herbert Xu

On Wed, Sep 04, 2002 at 06:33:18PM +, Adam Heath wrote:
 package: libc6.1
 version: 2.2.5-11.1
 severity: serious
 
 On lully, I have a repeatable segfault being caused by strncpy(which calls
 __stxncpy).

Here is a patch which should solve this problem.  It still needs to be
analysed for scheduling.

I don't buy the serious severity though since all it does is cross
a page boundary in very rare circumstances.  I know it's rare because
this code has been around for at least five years in both Linux and
glibc, yet no one has reported this before.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


--- stxncpy.S   2001-07-24 03:55:20.0 +1000
+++ /home/gondolin/herbert/stxncpy.S2002-09-08 19:23:45.0 +1000
@@ -192,6 +192,7 @@
cmpbge  zero, t2, t7# e0: find nulls in second partial
addqa0, 8, a0   # .. e1 :
subqa2, 1, a2   # e0:
+   beq a2, $u_late_head_exit
bne t7, $u_late_head_exit   # .. e1 :
 
/* Finally, we've got all the stupid leading edge cases taken care
@@ -200,6 +201,7 @@
extql   t2, a1, t1  # e0: position hi-bits of lo word
ldq_u   t2, 8(a1)   # .. e1 : read next high-order source word
addqa1, 8, a1   # e0:
+   subqa2, 1, a2
cmpbge  zero, t2, t7# e1 (stall)
beq a2, $u_eoc  # e1:
bne t7, $u_eos  # e1:



Bug#159633: strncpy on alpha/libc broken

2002-09-08 Thread Herbert Xu

On Sun, Sep 08, 2002 at 11:57:36AM -0400, Daniel Jacobowitz wrote:
 
 This patch is incorrect, unfortunately:
 
 {standard input}:182: Error: symbol `xdr_bp_whoambp_wh' is already defined
 {standard input}:187: Error: symbol `$xdr_bp_whoambp_wh..ng' is already defined

This error doesn't seem related to stxncpy, but I'm doing a glibc build
now to see if I can reproduce it.
 
 I'm not quite sure why your patch doesn't work but I think that
 $u_late_head_exit is the wrong exit point... and I'm not sure why the

u_late_head_exit is the right exit point for that place since it also
deals with end-of-count by oring t7 with t10.

 extra subtract was needed.  I was testing a branch to $u_eocfin but
 that isn't right either...

Without the extra subtract, the load in the loop may cause a SEGV...
Try strncpy(buf, page + 8169, 20).

I've got a better patch in terms of scheduling now.

As to sending it upstream, I'd simply send it to Richard Henderson
as he is the author of that file which is in both Linux and glibc.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


--- stxncpy.S   2001-07-24 03:55:20.0 +1000
+++ /home/gondolin/herbert/stxncpy.S2002-09-08 22:22:07.0 +1000
@@ -189,10 +189,11 @@
mskql   t6, a1, t6  # e0:   already seen
stq_u   t0, 0(a0)   # e0: store first output word
or  t6, t2, t2  # .. e1 :
+   addqa0, 8, a0   # e0:
+   subqa2, 1, a2   # .. e1 :
cmpbge  zero, t2, t7# e0: find nulls in second partial
-   addqa0, 8, a0   # .. e1 :
-   subqa2, 1, a2   # e0:
-   bne t7, $u_late_head_exit   # .. e1 :
+   beq a2, $u_late_head_exit   # .. e1 :
+   bne t7, $u_late_head_exit   # e1:
 
/* Finally, we've got all the stupid leading edge cases taken care
   of and we can set up to enter the main loop.  */
@@ -200,8 +201,9 @@
extql   t2, a1, t1  # e0: position hi-bits of lo word
ldq_u   t2, 8(a1)   # .. e1 : read next high-order source word
addqa1, 8, a1   # e0:
-   cmpbge  zero, t2, t7# e1 (stall)
-   beq a2, $u_eoc  # e1:
+   subqa2, 1, a2   # .. e1 :
+   cmpbge  zero, t2, t7# e0:
+   beq a2, $u_eoc  # .. e1 :
bne t7, $u_eos  # e1:
 
/* Unaligned copy main loop.  In order to avoid reading too much,



Bug#159633: strncpy on alpha/libc broken

2002-09-08 Thread Herbert Xu

On Mon, Sep 09, 2002 at 07:34:31AM +1000, herbert wrote:
 On Sun, Sep 08, 2002 at 11:57:36AM -0400, Daniel Jacobowitz wrote:
  
  This patch is incorrect, unfortunately:
  
  {standard input}:182: Error: symbol `xdr_bp_whoambp_wh' is already defined
  {standard input}:187: Error: symbol `$xdr_bp_whoambp_wh..ng' is already defined
 
 This error doesn't seem related to stxncpy, but I'm doing a glibc build
 now to see if I can reproduce it.

I've just built libc6.1 on lully with my new patch and it seems to
work fine.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]




Re: netdb.h

2001-06-01 Thread Herbert Xu
Ben Collins [EMAIL PROTECTED] wrote:

 In file included from /usr/include/netdb.h:38,
  from socket.c:64:
 /usr/include/bits/siginfo.h:21: #error Never include this file directly.  
 Use signal.h instead
 
 netdb.h includes signinfo.h directly :(

 What exactly is the command line? I can include netdb.h without
 problems, and I am using 2.2.3-5 aswell.

Could be a preprocessor bug.
-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Random name-resolution failures since glibc-2.1.94 upgrade?

2000-11-01 Thread Herbert Xu
Peter Palfrader [EMAIL PROTECTED] wrote:

 Maybe it is a misconfiguration, but I don't hope so:
 marvin:~# cat /etc/hosts
 127.0.0.1   localhost
 192.168.112.2   marvin.ibk.palfrader.org

 # The following lines are desirable for IPv6 capable hosts
 # (added automatically by netbase upgrade)

 ::1 ip6-localhost ip6-loopback
 fe00::0 ip6-localnet
 ff00::0 ip6-mcastprefix
 ff02::1 ip6-allnodes
 ff02::2 ip6-allrouters
 ff02::3 ip6-allhosts

I suspect that it's just trying to lookup localhost for IPv6.  Try putting
in a ::1 localhost and see what happens.
-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#70762: textutils: tail segfault

2000-09-02 Thread Herbert Xu
reassign 70762 libc6
quit

On Fri, Sep 01, 2000 at 08:54:05PM -0700, Joey Hess wrote:
 Package: textutils
 Version: 2.0-3
 Severity: minor
 
 Note severity. I don't think this happens in everyday use.

Is this new? Are there any other new ones available?

 [EMAIL PROTECTED]:~ulimit -a
 cpu time (seconds) unlimited
 file size (blocks) unlimited
 data seg size (kbytes) 81920
 stack size (kbytes)8192
 core file size (blocks)0
 resident set size (kbytes) 81920
 processes  150
 file descriptors   1024
 locked-in-memory size (kb) unlimited
 virtual memory size (kb)   81920
 [EMAIL PROTECTED]:~tail /dev/zero
 zsh: segmentation fault  tail /dev/zero
 
 If I disable memory limits, it doesn't segfault. Of course, it eventually
 eats up all memory on the machine and gets killed.

It's segfaulting in vfprintf which is called by error(3) (via fprintf(3))
which is called by xmalloc() when the malloc(3) fails.  So if this is a
bug at all, it is in libc6.
-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#69544: textutils: sort problem

2000-08-21 Thread Herbert Xu
reopen 69544
reassign 69544 libc6
quit

On Mon, Aug 21, 2000 at 10:07:23AM +0200, [EMAIL PROTECTED] wrote:
 Package: textutils
 Version: 2.0-2
 Severity: important
 
 Hi,
 $ sort
 a
 b
  a
  b
 ,a
 ,b
 #a
 #b
 
 gives:
  a
 ,a
 #a
 a
  b
 ,b
 #b
 b

Damn, happens in my locale (en_AU) as well :)

An ltrace shows that the bug is probably in libc6:

strcoll(a\n, b\n)   = -1
memcpy(0xbfffcea4,  b\n, 3)   = 0xbfffcea4
strcoll( a\n,  b\n) = -1
strcoll(a\n,  a\n)  = 1
strcoll(a\n,  b\n)  = -1
strcoll(b\n,  b\n)  = 1
memcpy(0xbfffcea4, ,b\n, 3)   = 0xbfffcea4
strcoll(,a\n, ,b\n) = -1
memcpy(0xbfffcea4, #b\n, 3)   = 0xbfffcea4
strcoll(#a\n, #b\n) = -1
strcoll(,a\n, #a\n) = -1
memcpy(0xbfffcee4, #a\n, 3)   = 0xbfffcee4
strcoll(,b\n, #a\n) = 1
strcoll(,b\n, #b\n) = -1
strcoll( a\n, ,a\n) = -1
strcoll(a\n, ,a\n)  = 1
strcoll(a\n, #a\n)  = 1
strcoll(a\n, ,b\n)  = -1
strcoll( b\n, ,b\n) = -1
strcoll(b\n, ,b\n)  = 1
strcoll(b\n, #b\n)  = 1

In the mean time, try unsetting your locale when sorting, it'll be heaps
faster that way.
-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#67921: glob(3) doesn't treat \ correctly, period.

2000-08-05 Thread Herbert Xu

retitle 67921 glob(3) doesn't treat \ correctly
quit

It seems that it isn't just \/, glob(3) doesn't do \*/* correctly either.
The first * is treated correctly as a literal, but so is the \.  So it only
matchers \*/a, and not */a as expected.

This is more serious than \/ since \/ can be worked around by not having
the slash there, but \* cannot.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


--  
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]




Bug#67921: glob(3) doesn't treat \ correctly, period.

2000-08-05 Thread Herbert Xu
retitle 67921 glob(3) doesn't treat \ correctly
quit

It seems that it isn't just \/, glob(3) doesn't do \*/* correctly either.
The first * is treated correctly as a literal, but so is the \.  So it only
matchers \*/a, and not */a as expected.

This is more serious than \/ since \/ can be worked around by not having
the slash there, but \* cannot.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#60984: getpty() under powerpc, with telnetd

2000-07-31 Thread Herbert Xu
On Sun, Jul 30, 2000 at 11:54:32PM -0400, Ben Collins wrote:
 On Mon, Jul 31, 2000 at 11:57:39AM +1000, Herbert Xu wrote:
  
  I believe that this is just a result of not having /dev/ptmx 666.  Is it
  possible for libc6 to check for this?
 
 What if for some silly reason, some one wants it that way? I'm not so sure
 that there is enough reason to force these perms on it.

I'm not saying that libc6 should force it to be 666, but it would be nice
for it to warn the user at least once if /dev/ptmx is not 666 which could
prevent further bug reports of this kind.

Then again, maybe it should just be documented somewhere.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#60984: getpty() under powerpc, with telnetd

2000-07-30 Thread Herbert Xu
Ben Collins [EMAIL PROTECTED] wrote:
 Does this bug still exist for you?

I believe that this is just a result of not having /dev/ptmx 666.  Is it
possible for libc6 to check for this?
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: textutils: sort is _very_ slow when LANG is set

2000-06-18 Thread Herbert Xu
reassign 62803 libc6
severity 62803 wishlist
quit

It's because we have to call strcoll instead of strcmp/memcmp.  The only way
to make it fast is by speeding up strcoll, which I'm not sure is possible or
not.  But I'll let the libc6 maintainer work it out.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#63897: getconf has no manual page

2000-05-11 Thread Herbert Xu
Josip Rodin [EMAIL PROTECTED] wrote:
 Package: libc6-dev

 The getconf utility has no manual page. If there's no way to get a proper
 manpage, at least make a symlink to undocumented(7), that's policy.

I'd like to point out that making a symlink is not sufficient to
close these kind of bugs.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[caspian@twu.net: Bug#60984: (no subject)]

2000-04-24 Thread Herbert Xu
reassign 60984 libc6
quit

It looks like openpty on PowerPC's don't work as a normal user, even when
devpts is present.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---BeginMessage---
Package: telnetd
Version: 0.16-3

On Debian/PowerPC (I'm running on a PowerMac), I can RSH into the box
(here named wozniak) just fine, but when I try to telnet in, I get:

murphy:~# telnet wozniak
Trying 10.0.4.16...
Connected to wozniak.greatfox.net.
Escape character is '^]'.
telnetd: getpty: Permission denied
---End Message---


Re: Processed:

1999-10-27 Thread Herbert Xu
reassign 21810 libc6
quit

On Wed, Oct 27, 1999 at 04:33:05AM -, Debian Bug Tracking System wrote:
 
  reassign 21810 netstd
 Bug#21810: libc6: rexec call dumps core with user=string and password=NULL
 Bug reassigned from package `libc6' to `netstd'.

This is not a bug in rexec.  It's in libc6.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Re: Bug#48446: rexec: If rexec is not given correct args a segmentation fault occurs

1999-10-27 Thread Herbert Xu
reassign 48446 libc6
quit

On Tue, Oct 26, 1999 at 11:37:49PM -0700, Steve Mayer wrote:
 Package: rexec
 Version: 1.5-2
 Severity: normal
 
 
 If I issue the command `rexec pdnt-test1 notepad.exe`, rexec will die with a 
 segmentation fault.  Giving the proper switches for the username and password 
 or the -n switch works fine.

This is a bug in libc6.  Please see #21810.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Re: Bug#46391: telnetd: All network ports in use

1999-10-01 Thread Herbert Xu
reassign 46391 libc6
quit

On Sat, Oct 02, 1999 at 07:24:37AM +1000, Brian May wrote:
 Package: telnetd
 Version: 0.14-7
 Severity: normal
 
 I get the error:
 
 telnetd: All network ports in use.

This is because openpty(3) failed.  So whatever it is, it's probably outside
telnetd's control.

You can try applying this patch to telnetd (it will be in the next release)
to get some more info on the error.  Alternatively you can try stracing or
ltracing the server.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
Index: telnetd.c
===
RCS file: /home/gondor/herbert/src/CVS/debian/netkit-telnet/telnetd/telnetd.c,v
retrieving revision 1.5
diff -u -r1.5 telnetd.c
--- telnetd.c   1999/08/23 05:36:30 1.5
+++ telnetd.c   1999/10/01 12:26:29
@@ -597,7 +597,7 @@
 */
pty = getpty();
if (pty  0)
-   fatal(net, All network ports in use);
+   fatalperror(net, getpty);
 
/* get name of connected client */
hp = gethostbyaddr((char *)who-sin_addr, sizeof (struct in_addr),



Bug#21810: Bug#46142: rexec still does not look at .netrc

1999-09-28 Thread Herbert Xu
severity 21810 important
quit

On Tue, Sep 28, 1999 at 11:47:55AM +1000, Daryl Radivojevic wrote:
 Package: rexec
 Version: 1.5-1
 
 rexec does not look at the .netrc file at all. As stated in the man page
 rexec should
 look at the .netrc file in the users home directory to find a default login
 and password
 for the specified machine. But looking through the source code bug #34100
 left
 over from version 1.4 from the package is still not fixed. There is nothing
 in the
 source code that will look at the .netrc file.
 
 Note 1: Red Hat has the identical problem (I do not know of other
 distributions).
 Note 2: I managed to fix the problem for myself by hacking into rexec.c and
 merging
 some of the code from the ftp code. (Ahhh.. the beauty of open source.)

OK.  What happened is that libc6 broke rexec(3) by not prompting when the
user/password is not set, then this was incorrectly fixed in rexec.  What
I'm going to do now is to restore the original rexec code and wait for the
libc6 maintainer to fix it.  This will have the side effect of rexec crashing
but maybe that'll at least get someone to write a patch for libc6 :)

There is already a bug report about this (#21810).  I'm going to raise the
severity because it causes rexec to be unusable in some circumstances.
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



Bug#21810: Bug#46142: rexec still does not look at .netrc

1999-09-28 Thread Herbert Xu
On Tue, Sep 28, 1999 at 01:24:30AM -0400, Raul Miller wrote:
 On Tue, Sep 28, 1999 at 02:20:46PM +1000, Herbert Xu wrote:
  OK. What happened is that libc6 broke rexec(3) by not prompting when
  the user/password is not set, then this was incorrectly fixed in
  rexec.
 
 I can't find anything in the libc docs about prompting for rexec.
 
 What is libc6 doing wrong?

Historically the rexec(3) would prompt for the username/password if the
arguments were null.  libc6 changed this, i.e., it now segfaults rather
than prompting for them.

Indeed, if we wish to keep the netrc code in rexec as has always been the
case, then the only place to prompt for missing usernames/passwords is
in rexec(3) (or actually, ruserpass()).

You won't find anything in the docs because there simply isn't any :)
-- 
Debian GNU/Linux 2.1 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



  1   2   >