Re: Possible Bug in Maven Debian Helper
On Tue, Jun 30, 2020 at 6:01 AM tony mancill wrote:
>
> On Sun, Jun 28, 2020 at 11:03:37PM -0400, Olek Wojnar wrote:
> > Hi tony,
> >
> > On Sun, Jun 28, 2020 at 9:48 PM tony mancill wrote:
> >
> > >
> > > I attempted to reproduce this but the package depends on
> > > libchecker-framework-java and the sources checked into the Salsa repo
> > > [3] don't match what I see uploaded NEW [4]. Do you mind pushing the
> > > branch you used for the upload?
>
> So we're definitely in the maven-repo-helper code, entering via [1] and
> stuck in [2]. Specifically, my guess is that we're looping in [3].
>
> However, I haven't found a fix yet. I'm still picking through the pom files
> in the patch to see if I can figure out why we're getting stuck. It
> seems like the code expands the pom, it refers to itself (or otherwise
> creates a cycle).
That is happening because all the poms are trying to find
"${project.version}". I think project.version will be 0.5.1, so just
replace all "${project.version}" with
"0.5.1" and you will not get the circular loop
anymore. I didnot get the time to check why it fails to build after
that.
--
Regards
Sudip
Re: Possible Bug in Maven Debian Helper
On Sun, Jun 28, 2020 at 11:03:37PM -0400, Olek Wojnar wrote: > Hi tony, > > On Sun, Jun 28, 2020 at 9:48 PM tony mancill wrote: > > > > > I attempted to reproduce this but the package depends on > > libchecker-framework-java and the sources checked into the Salsa repo > > [3] don't match what I see uploaded NEW [4]. Do you mind pushing the > > branch you used for the upload? > > > > Of course, sorry about that! I pushed the "master" branch which contains > the upload I plan to make to unstable once the package clears NEW. I also > pushed the "experimental" branch which adds an ephemeral experimental > commit on top of "master." The "experimental" branch is presently in NEW. > Please let me know if there's anything else that you need to examine this. > Thanks! > Hi Olek, Thank you! I was able to reproduce the problem you are experiencing and used jmc to grab some stack traces while it is stuck spinning. They all are some variant of this - the common bit being that we're always in somewhere in POMReader: "main" #1 prio=5 os_prio=0 cpu=133878.15ms elapsed=135.64s tid=0x7f7224015000 nid=0x20a26 runnable [0x7f722b037000] java.lang.Thread.State: RUNNABLE at java.util.TreeMap.getEntry(java.base@11.0.7/TreeMap.java:357) at java.util.TreeMap.get(java.base@11.0.7/TreeMap.java:277) at org.debian.maven.repo.POMReader.expandString(POMReader.java:255) at org.debian.maven.repo.POMReader.expandProperties(POMReader.java:239) at org.debian.maven.repo.POMReader.readPom(POMReader.java:207) at org.debian.maven.repo.POMReader.readPom(POMReader.java:57) at org.debian.maven.repo.POMTransformer.keepPomVersion(POMTransformer.java:171) at org.debian.maven.repo.POMTransformer$2.handlePOM(POMTransformer.java:162) at org.debian.maven.repo.ListOfPOMs.foreachPoms(ListOfPOMs.java:102) at org.debian.maven.repo.POMTransformer.keepPomVersions(POMTransformer.java:159) at org.debian.maven.repo.POMTransformer.main(POMTransformer.java:770) So we're definitely in the maven-repo-helper code, entering via [1] and stuck in [2]. Specifically, my guess is that we're looping in [3]. However, I haven't found a fix yet. I'm still picking through the pom files in the patch to see if I can figure out why we're getting stuck. It seems like the code expands the pom, it refers to itself (or otherwise creates a cycle). We can probably add some more debugging to maven-repo-helper too... :) Cheers, tony [1] https://salsa.debian.org/java-team/maven-repo-helper/-/blob/debian/1.9.4/src/main/java/org/debian/maven/repo/POMTransformer.java [2] https://salsa.debian.org/java-team/maven-repo-helper/-/blob/debian/1.9.4/src/main/java/org/debian/maven/repo/POMReader.java [3] https://salsa.debian.org/java-team/maven-repo-helper/-/blob/debian/1.9.4/src/main/java/org/debian/maven/repo/POMReader.java#L247-259 signature.asc Description: PGP signature
Re: Possible Bug in Maven Debian Helper
Hi tony, On Sun, Jun 28, 2020 at 9:48 PM tony mancill wrote: > > I attempted to reproduce this but the package depends on > libchecker-framework-java and the sources checked into the Salsa repo > [3] don't match what I see uploaded NEW [4]. Do you mind pushing the > branch you used for the upload? > Of course, sorry about that! I pushed the "master" branch which contains the upload I plan to make to unstable once the package clears NEW. I also pushed the "experimental" branch which adds an ephemeral experimental commit on top of "master." The "experimental" branch is presently in NEW. Please let me know if there's anything else that you need to examine this. Thanks! -Olek
Re: Possible Bug in Maven Debian Helper
Hi Olek, On Wed, Jun 24, 2020 at 03:09:43PM -0400, Olek Wojnar wrote: > Hi everyone, > > I've been having some problems with a tweaked build and, before reporting a > bug, I wanted to see if anyone had any insights as to what is going wrong > here. > > So flogger [1] and bazel have a circular build dependency therefore > upstream helped me to create an alternate Maven build for flogger (which > normally only builds with Bazel). Essentially, I have some POM files that > are created using a patch. However, this build always freezes up during > dh_auto_configure requiring me to manually abort the build. Specifically, > it freezes when executing the Java command at [2]. I've pored through the > code but I can't figure out what's wrong. More to-the-point, I can't > determine if there's some problem with my packaging (and patched build > system) or if this is an underlying bug in MDH. > > I appreciate any insights any of you can provide. Thanks! > > -Olek > > [1] https://salsa.debian.org/java-team/google-flogger/-/tree/olek-temp1 > [2] > https://salsa.debian.org/java-team/maven-repo-helper/-/blob/debian/1.9.4/src/main/bin/mh_patchpoms#L136 I attempted to reproduce this but the package depends on libchecker-framework-java and the sources checked into the Salsa repo [3] don't match what I see uploaded NEW [4]. Do you mind pushing the branch you used for the upload? Thanks, tony [3] https://salsa.debian.org/java-team/checker-framework.git [4] https://ftp-master.debian.org/new/checker-framework_3.0.0+repack1-1~exp2.html#dsc signature.asc Description: PGP signature
