Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Ben Hutchings]

On Tue, 2017-10-03 at 12:42 -0700, Vagrant Cascadian wrote:
> On 2017-10-03, Ben Hutchings wrote:
> > On Tue, 2017-10-03 at 11:28 -0700, Vagrant Cascadian wrote:
> > > Control: found 4.13.4-1 4.14~rc3-1~exp1
> > > 
> > > On 2017-10-02, Debian Bug Tracking System wrote:
> > > > This is an automatic notification regarding your Bug report
> > > > which was filed against the src:linux package:
> > > > 
> > > > #843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on
> > > > Odroid-Xu4 with rootfs on USB
> > > 
> > > It seems only partially fixed...
> > > 
> > > With 4.13.4-1 it usually detects the USB device, but I've gotten
> > > several
> > > boots where it kernel panics on mounting swap (an lvm volume on
> > > the USB
> > > device) or sometimes on unmounting swap as part of powerdown or
> > > reboot. Not really any better luck with 4.14~rc3-1~exp1.
> > 
> > [...]
> > 
> > Is this still the same bug?
> 
> Could be different. Though I have infrequently seen something
> more-or-less identical to the originally reported issue with the
> "connect debounce" messages with the fixed 4.13 and 4.14 kernels; I
> haven't been able to reproduce them to capture a log just yet...
> 
> 
> > Can you send the panic messages?
> 
> Attached should be a few logs with different panic/exception
> messages.
> 
> It doesn't cover all of the failure cases I've seen, as I haven't
> managed to capture the logs of all of the boots I've done...

These logs are showing three very different crashes:

1. Null dereference in bio_integrity_advance() during SCSI request
   completion (odxu4a-oops.log, odxu4a-swap-panic.log)
2. WARN at the bottom of rcu_check_callbacks() (odxu4a-swap-trace.log)
3. Null dereference in xhci_irq() (odxu4a-swap-panic-4.13.log)

They all seem to be associated with initialisation of USB host and
device drivers, but none of them are obviously related to this bug
report.  So I think these should be treated as 3 new bugs.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
A fail-safe circuit will destroy
others.


signature.asc
Description: This is a digitally signed message part

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Ben Hutchings]

On Tue, 2017-10-03 at 11:28 -0700, Vagrant Cascadian wrote:
> Control: found 4.13.4-1 4.14~rc3-1~exp1
> 
> On 2017-10-02, Debian Bug Tracking System wrote:
> > This is an automatic notification regarding your Bug report
> > which was filed against the src:linux package:
> > 
> > #843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with 
> > rootfs on USB
> 
> It seems only partially fixed...
> 
> With 4.13.4-1 it usually detects the USB device, but I've gotten several
> boots where it kernel panics on mounting swap (an lvm volume on the USB
> device) or sometimes on unmounting swap as part of powerdown or
> reboot. Not really any better luck with 4.14~rc3-1~exp1.
[...]

Is this still the same bug?  Can you send the panic messages?

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
   A fail-safe circuit will destroy others.



signature.asc
Description: This is a digitally signed message part

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

Control: found 4.13.4-1 4.14~rc3-1~exp1

On 2017-10-02, Debian Bug Tracking System wrote:
> This is an automatic notification regarding your Bug report
> which was filed against the src:linux package:
>
> #843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with 
> rootfs on USB

It seems only partially fixed...

With 4.13.4-1 it usually detects the USB device, but I've gotten several
boots where it kernel panics on mounting swap (an lvm volume on the USB
device) or sometimes on unmounting swap as part of powerdown or
reboot. Not really any better luck with 4.14~rc3-1~exp1.

Both versions seem slightly more reliable in a warm boot vs. a cold
boot, or if usb is started from u-boot, but I've still seen kernel
panics even then. Setting rootdelay=30 seems to help, but not every
time. Sounds a bit racy...

The patched .dtb I was running with 4.9.30-2+deb9u5 and another with
4.13.2-1~exp1 both had an uptime of 8 days and counting. Oddly, dtdiff
cannot tell the difference between the patched 4.13.2-1~exp1 dtb and the
dtb shipped with 4.13.4-1, though the checksums do differ.

Hrm.


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

Hi Gustavo,

* gustavo panizzo  [2017-09-28 10:47]:

everything works fine, USB3 devices work fine after reboot :)


Thanks for testing.


@Jochen, will you try to get it merged upstream?


Someone was faster:

https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/dt=3bf689f9275ff73de1ffad3e571837c8bff41d27

So we should have a working kernel soon :).


Cheers Jochen


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[gustavo panizzo]

On Sun, Sep 24, 2017 at 07:52:29AM +, Jochen Sprickerhof wrote:

Hi,

Finally I had the time and hardware available to look into this again 
and found a better way to fix it. Applying the attached patch results 
in a new exynos5422-odroidxu4.dtb that could simply be copied to 
/boot/dtbs/*/

I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.


I've tested with linux-next, on top of commit
73527316e3fdde8a210b8ab66c1bf48538cf6b09
4.14.0-rc1-next-20170922+

everything works fine, USB3 devices work fine after reboot :)

@Jochen, will you try to get it merged upstream?



@Ben: This seems unintrusive enough to be included in the next stretch 
point release, what do you think?


Cheers Jochen






--
IRC: gfa
GPG: 0X44BB1BA79F6C6333

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-09-24, Jochen Sprickerhof wrote:
> Finally I had the time and hardware available to look into this again 
> and found a better way to fix it. Applying the attached patch results in 
> a new exynos5422-odroidxu4.dtb that could simply be copied to /boot/dtbs/*/
> I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
> as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.

Thanks!

I'm testing the patched .dtb on linux-image-4.9.0-3-armmp-lpae on two
machines and one machine running linux-image-4.13.0-trunk-armmp-lpae.
All use USB for rootfs and a build partition, so should test USB
reasonable well. Seems to work fine so far.

Using a patched .dtb is a much easier workaround than having to
recompile the whole kernel (and follow security updates and so on)!

I'd be happy to also do some testing with newer mainline kernels, if
you'd like to CC me on patch submissions upstream.


live well,
  vagrant

> Cheers Jochen
> From 0d3552be829d5a275d549cbf6ab468bfdb026e49 Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof 
> Date: Sun, 24 Sep 2017 08:28:12 +0200
> Subject: [PATCH] ARM: dts: exynos: Use dwc3 quirk for USB3 and LAN on Odroid
>  XU4
>
> First proposed in https://lkml.org/lkml/2015/3/18/400 and discussed
> again in https://lkml.org/lkml/2017/1/24/402.
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu4.dts | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts 
> b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
> index 2faf88627a48..3861f74b2ecc 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
> @@ -43,6 +43,11 @@
>   status = "okay";
>  };
>  
> +_dwc3_0 {
> + snps,dis_u3_susphy_quirk;
> +};
> +
>  _dwc3_1 {
>   dr_mode = "host";
> + snps,dis_u3_susphy_quirk;
>  };
> -- 
> 2.14.1


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Ben Hutchings]

On Sun, 2017-09-24 at 09:52 +0200, Jochen Sprickerhof wrote:
> Hi,
> 
> Finally I had the time and hardware available to look into this again 
> and found a better way to fix it. Applying the attached patch results in 
> a new exynos5422-odroidxu4.dtb that could simply be copied to /boot/dtbs/*/
> I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
> as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.
> 
> @Ben: This seems unintrusive enough to be included in the next stretch 
> point release, what do you think?

I'm not applying this until it's accepted upstream.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an
expert.



signature.asc
Description: This is a digitally signed message part

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

Hi,

Finally I had the time and hardware available to look into this again 
and found a better way to fix it. Applying the attached patch results in 
a new exynos5422-odroidxu4.dtb that could simply be copied to /boot/dtbs/*/

I've tested this with the current kernel in sid (linux-image-4.12.0-2-armmp)
as well as stretch (linux-image-4.9.0-3-armmp). More tests welcome.

@Ben: This seems unintrusive enough to be included in the next stretch 
point release, what do you think?


Cheers Jochen
From 0d3552be829d5a275d549cbf6ab468bfdb026e49 Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof 
Date: Sun, 24 Sep 2017 08:28:12 +0200
Subject: [PATCH] ARM: dts: exynos: Use dwc3 quirk for USB3 and LAN on Odroid
 XU4

First proposed in https://lkml.org/lkml/2015/3/18/400 and discussed
again in https://lkml.org/lkml/2017/1/24/402.
---
 arch/arm/boot/dts/exynos5422-odroidxu4.dts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
index 2faf88627a48..3861f74b2ecc 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
@@ -43,6 +43,11 @@
 	status = "okay";
 };
 
+_dwc3_0 {
+	snps,dis_u3_susphy_quirk;
+};
+
 _dwc3_1 {
 	dr_mode = "host";
+	snps,dis_u3_susphy_quirk;
 };
-- 
2.14.1



signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Wed, Sep 06, 2017 at 11:24:27PM -0700, Vagrant Cascadian wrote:
>> One of them was running 4.11, and didn't seem any better or worse.
> And updated to testing on 4.12.10 on one of the boards...
> 
> Any progress getting these patches upstream?

...and on getting them into a stretch point release? It's really the only
thing that's missing for completely plain stretch on these boards. :-)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-07-16, Vagrant Cascadian wrote:
> On 2017-07-10, Vagrant Cascadian wrote:
>> On 2017-07-08, Steinar H. Gunderson wrote:
>>> On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
 For v4.9 the only patch needed is:
 
 https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97
>>>
>>> Don't you also want this?
>>>
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75
>>
>> I've built patched linux 4.9 packages using the above two patches, and
>> am running them on several odroid-xu4 boards used in the reproducible
>> builds builders, running rootfs and a build partition on USB. So that
>> should test USB reasonably well... I'll report if there are any major
>> stability issues.

4.9 still working reasonably well...


>> I'll also try to switch one of them over to a patched 4.11 or 4.12
>> soonish... to make sure there aren't further regressions there.
>
> One of them was running 4.11, and didn't seem any better or worse.

And updated to testing on 4.12.10 on one of the boards...


Any progress getting these patches upstream?


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[gustavo panizzo]

On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:


For current Linux master you need:

https://patchwork.kernel.org/patch/9815981/
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=2;bug=843448;filename=0001-usb-dwc3-core-Setup-phy-before-trying-to-read-from-i.patch;msg=117

I also forwarded this upstream here:

http://marc.info/?l=linux-usb=149945465112440=2




Test results welcome.


I'm testing both patches and
2166ffd004e04a61887eb2a39f8639dc12140c58-updated on top of linux-next
964bcc1b4f57028d56dace7d9bc5924f2eb43f36 which translates to 
4.13.0-rc1-next-20170717+ without problems so far :)


I'm pushing the 3rd patch upstream as well

https://www.spinics.net/lists/linux-usb/msg158924.html

cheers!

--
IRC: gfa
GPG: 0X44BB1BA79F6C6333



signature.asc
Description: Digital Signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-07-10, Vagrant Cascadian wrote:
> On 2017-07-08, Steinar H. Gunderson wrote:
>> On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
>>> For v4.9 the only patch needed is:
>>> 
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97
>>
>> Don't you also want this?
>>
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75
>
> I've built patched linux 4.9 packages using the above two patches, and
> am running them on several odroid-xu4 boards used in the reproducible
> builds builders, running rootfs and a build partition on USB. So that
> should test USB reasonably well... I'll report if there are any major
> stability issues.

There have been infrequent USB resets, but it usually handles them
successfully:

[500623.473890] scsi host0: uas_eh_bus_reset_handler start
[500623.483176] sd 0:0:0:0: [sda] tag#22 uas_zap_pending 0 uas-tag 23
inflight: CMD
[500623.489235] sd 0:0:0:0: [sda] tag#22 CDB: Write(10) 2a 00 01 a4 51
10 00 00 10 00
[500623.496778] sd 0:0:0:0: [sda] tag#23 uas_zap_pending 0 uas-tag 24
inflight: CMD
[500623.504219] sd 0:0:0:0: [sda] tag#23 CDB: Read(10) 28 00 00 66 59 20
00 00 60 00
[500623.511678] sd 0:0:0:0: [sda] tag#24 uas_zap_pending 0 uas-tag 25
inflight: CMD
[500623.519120] sd 0:0:0:0: [sda] tag#24 CDB: Write(10) 2a 00 04 d4 c1
e8 00 00 18 00
[500623.526667] sd 0:0:0:0: [sda] tag#25 uas_zap_pending 0 uas-tag 26
inflight: CMD
[500623.534112] sd 0:0:0:0: [sda] tag#25 CDB: Read(10) 28 00 00 50 b1 10
00 00 08 00
[500623.541570] sd 0:0:0:0: [sda] tag#26 uas_zap_pending 0 uas-tag 27
inflight: CMD
[500623.549012] sd 0:0:0:0: [sda] tag#26 CDB: Write(10) 2a 00 04 d4 c6
58 00 00 08 00
[500623.556561] sd 0:0:0:0: [sda] tag#27 uas_zap_pending 0 uas-tag 28
inflight: CMD
[500623.564003] sd 0:0:0:0: [sda] tag#27 CDB: Read(10) 28 00 00 66 58 e0
00 00 40 00
[500623.654698] usb 4-1.2: reset SuperSpeed USB device number 3 using
xhci-hcd
[500623.681540] scsi host0: uas_eh_bus_reset_handler success

This is no worse than when running on 4.7.


> I'll also try to switch one of them over to a patched 4.11 or 4.12
> soonish... to make sure there aren't further regressions there.

One of them was running 4.11, and didn't seem any better or worse.


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-07-08, Steinar H. Gunderson wrote:
> On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
>> For v4.9 the only patch needed is:
>> 
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97
>
> Don't you also want this?
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75

I've built patched linux 4.9 packages using the above two patches, and
am running them on several odroid-xu4 boards used in the reproducible
builds builders, running rootfs and a build partition on USB. So that
should test USB reasonably well... I'll report if there are any major
stability issues.

I'll also try to switch one of them over to a patched 4.11 or 4.12
soonish... to make sure there aren't further regressions there.


Thanks everyone for working on this!


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

* Steinar H. Gunderson  [2017-07-08 10:43]:
> Well, you don't get working USB after a warm boot without it, do you?

Oups forgot to test that, you are totally right :).

@Gustavo: could you take care of brining that one upstream? Thanks!

Cheers Jochen


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Sat, Jul 08, 2017 at 10:42:26AM +0200, Jochen Sprickerhof wrote:
>> Don't you also want this?
>> 
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75
> This is not needed to fix this bug.

Well, you don't get working USB after a warm boot without it, do you?

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

* Steinar H. Gunderson  [2017-07-08 10:38]:
> Don't you also want this?
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75

This is not needed to fix this bug.

Cheers Jochen


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Sat, Jul 08, 2017 at 07:50:03AM +0200, Jochen Sprickerhof wrote:
> For v4.9 the only patch needed is:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97

Don't you also want this?

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=2166ffd004e04a61887eb2a39f8639dc12140c58-updated.diff;msg=75

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

Hi Vagrant,

* Vagrant Cascadian  [2017-07-07 20:21]:
> Is this the only patch needed? Does it also need one of the patches
> mentioned earlier in this bug? This is a single patch, with a v4.12 and
> v4.11 variant, or two very similar looking patches?
> 
> I'd be happy to test on debian's 4.9 and 4.11 kernels, but it is a
> little unclear to me exactly which patches are meant for what.

Sorry for being unclear.

For v4.9 the only patch needed is:

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-usb-dwc3-core-setup-phy-before-trying-to-read-from-i.patch;msg=97

For v4.11 and v4.12 the only patch needed is:

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=843448;filename=0001-v4.12-usb-dwc3-core-Setup-phy-before-trying-to-read-.patch;msg=117

For current Linux master you need:

https://patchwork.kernel.org/patch/9815981/
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=2;bug=843448;filename=0001-usb-dwc3-core-Setup-phy-before-trying-to-read-from-i.patch;msg=117

I also forwarded this upstream here:

http://marc.info/?l=linux-usb=149945465112440=2

Test results welcome.

Cheers Jochen


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-07-07, Jochen Sprickerhof wrote:
> I've created patches for v4.12 (applies to v4.11 as well) and git
> master and send them to the subsystem maintainers. Would be great to see
> them included in the Debian kernel as well.

Thanks!

Is this the only patch needed? Does it also need one of the patches
mentioned earlier in this bug? This is a single patch, with a v4.12 and
v4.11 variant, or two very similar looking patches?

I'd be happy to test on debian's 4.9 and 4.11 kernels, but it is a
little unclear to me exactly which patches are meant for what.

live well,
  vagrant

> From 7b12187f59ff43571e664b9f6987534ee622700f Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof 
> Date: Fri, 7 Jul 2017 19:38:03 +0200
> Subject: [PATCH] v4.12: usb: dwc3: core: Setup phy before trying to read from
>  it
>
> Commit c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> moved the call to dwc3_phy_setup() from dwc3_probe() to dwc3_core_init()
> and after the dwc3_readl() (now in dwc3_core_is_valid). This broke USB
> and Ethernet on Odroid XU4, because dwc3_readl() needs dwc3_phy_setup()
> to be run before.
>
> Fix this by moving the call to dwc3_phy_setup() before
> dwc3_core_is_valid().
>
> This fixes USB and Ethernet on Odroid XU4.
>
> Also see https://bugs.debian.org/843448
>
> Signed-off-by: Jochen Sprickerhof 
> Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> ---
>  drivers/usb/dwc3/core.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 455d89a1cd6d..2418979a883a 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -732,6 +732,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
>   u32 reg;
>   int ret;
>  
> + ret = dwc3_phy_setup(dwc);
> + if (ret)
> + goto err0;
> +
>   if (!dwc3_core_is_valid(dwc)) {
>   dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
>   ret = -ENODEV;
> @@ -755,10 +759,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
>   if (ret)
>   goto err0;
>  
> - ret = dwc3_phy_setup(dwc);
> - if (ret)
> - goto err0;
> -
>   dwc3_core_setup_global_control(dwc);
>   dwc3_core_num_eps(dwc);
>  
> -- 
> 2.13.2
>
> From 6b7d33243a364c668530a5ae11ed5a57cecd42d9 Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof 
> Date: Fri, 7 Jul 2017 19:38:03 +0200
> Subject: [PATCH] usb: dwc3: core: Setup phy before trying to read from it
>
> Commit c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> moved the call to dwc3_phy_setup() from dwc3_probe() to dwc3_core_init()
> and after the dwc3_readl() (now in dwc3_core_is_valid). This broke USB
> and Ethernet on Odroid XU4, because dwc3_readl() needs dwc3_phy_setup()
> to be run before.
>
> Fix this by moving the call to dwc3_phy_setup() before
> dwc3_core_is_valid().
>
> This fixes USB and Ethernet on Odroid XU4.
>
> This needs and is supposed to be applied on top of
> https://patchwork.kernel.org/patch/9815981/
>
> Also see https://bugs.debian.org/843448
>
> Signed-off-by: Jochen Sprickerhof 
> Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> ---
>  drivers/usb/dwc3/core.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 03474d3575ab..3c6faddc1394 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -747,6 +747,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
>   u32 reg;
>   int ret;
>  
> + ret = dwc3_phy_setup(dwc);
> + if (ret)
> + goto err0;
> +
>   if (!dwc3_core_is_valid(dwc)) {
>   dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
>   ret = -ENODEV;
> @@ -774,10 +778,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
>   if (ret)
>   goto err0;
>  
> - ret = dwc3_phy_setup(dwc);
> - if (ret)
> - goto err0;
> -
>   dwc3_core_setup_global_control(dwc);
>   dwc3_core_num_eps(dwc);
>  
> -- 
> 2.13.2


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Fri, Jul 07, 2017 at 08:42:08PM +0200, Jochen Sprickerhof wrote:
> I've created patches for v4.12 (applies to v4.11 as well) and git
> master and send them to the subsystem maintainers. Would be great to see
> them included in the Debian kernel as well.

Thanks for doing this :-) I'd love to see this in a stretch point release
so that we don't have to wait for buster to get XU4 support.

(Granted, I've never tried d-i, but at least then I can rebuild my XU4
images.)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Processed: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Debian Bug Tracking System]

Processing control commands:

> tags -1 patch
Bug #843448 [src:linux] linux-image-4.8.0-1-armmp-lpae: fails to boot on 
Odroid-Xu4 with rootfs on USB
Added tag(s) patch.

-- 
843448: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843448
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

Control: tags -1 patch

Hi,

I've created patches for v4.12 (applies to v4.11 as well) and git
master and send them to the subsystem maintainers. Would be great to see
them included in the Debian kernel as well.

Cheers Jochen
From 7b12187f59ff43571e664b9f6987534ee622700f Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof 
Date: Fri, 7 Jul 2017 19:38:03 +0200
Subject: [PATCH] v4.12: usb: dwc3: core: Setup phy before trying to read from
 it

Commit c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
moved the call to dwc3_phy_setup() from dwc3_probe() to dwc3_core_init()
and after the dwc3_readl() (now in dwc3_core_is_valid). This broke USB
and Ethernet on Odroid XU4, because dwc3_readl() needs dwc3_phy_setup()
to be run before.

Fix this by moving the call to dwc3_phy_setup() before
dwc3_core_is_valid().

This fixes USB and Ethernet on Odroid XU4.

Also see https://bugs.debian.org/843448

Signed-off-by: Jochen Sprickerhof 
Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
---
 drivers/usb/dwc3/core.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 455d89a1cd6d..2418979a883a 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -732,6 +732,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	u32			reg;
 	int			ret;
 
+	ret = dwc3_phy_setup(dwc);
+	if (ret)
+		goto err0;
+
 	if (!dwc3_core_is_valid(dwc)) {
 		dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
 		ret = -ENODEV;
@@ -755,10 +759,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	if (ret)
 		goto err0;
 
-	ret = dwc3_phy_setup(dwc);
-	if (ret)
-		goto err0;
-
 	dwc3_core_setup_global_control(dwc);
 	dwc3_core_num_eps(dwc);
 
-- 
2.13.2

From 6b7d33243a364c668530a5ae11ed5a57cecd42d9 Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof 
Date: Fri, 7 Jul 2017 19:38:03 +0200
Subject: [PATCH] usb: dwc3: core: Setup phy before trying to read from it

Commit c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
moved the call to dwc3_phy_setup() from dwc3_probe() to dwc3_core_init()
and after the dwc3_readl() (now in dwc3_core_is_valid). This broke USB
and Ethernet on Odroid XU4, because dwc3_readl() needs dwc3_phy_setup()
to be run before.

Fix this by moving the call to dwc3_phy_setup() before
dwc3_core_is_valid().

This fixes USB and Ethernet on Odroid XU4.

This needs and is supposed to be applied on top of
https://patchwork.kernel.org/patch/9815981/

Also see https://bugs.debian.org/843448

Signed-off-by: Jochen Sprickerhof 
Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
---
 drivers/usb/dwc3/core.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 03474d3575ab..3c6faddc1394 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -747,6 +747,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	u32			reg;
 	int			ret;
 
+	ret = dwc3_phy_setup(dwc);
+	if (ret)
+		goto err0;
+
 	if (!dwc3_core_is_valid(dwc)) {
 		dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
 		ret = -ENODEV;
@@ -774,10 +778,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	if (ret)
 		goto err0;
 
-	ret = dwc3_phy_setup(dwc);
-	if (ret)
-		goto err0;
-
 	dwc3_core_setup_global_control(dwc);
 	dwc3_core_num_eps(dwc);
 
-- 
2.13.2



signature.asc
Description: PGP signature

Bug#843448: [jspri...@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB]

[Steinar H. Gunderson]

On Mon, Jul 03, 2017 at 04:35:49PM +0200, Jochen Sprickerhof wrote:
> thanks to the pointers, I've condensed the first patch (74b9605e) to the
> attached one against 4.9. Can you verify that it works?
> 
> I will try to port it to 4.11 and linux-next and post them.
> 
> The second patch (2166ffd00-updated.diff) looks good for me, would be great to
> see it in mainline. Did someone send it to the maintainers already?

I've built latest 4.9.0 from stretch, plus your patch, plus
2166ffd00-updated.diff. It seems to boot on my XU4 with networking
working just fine; unfortunately, I can't give it much more testing
than that right now.

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: [jspri...@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB]

[Steinar H. Gunderson]

On Mon, Jul 03, 2017 at 04:35:49PM +0200, Jochen Sprickerhof wrote:
> thanks to the pointers, I've condensed the first patch (74b9605e) to the
> attached one against 4.9. Can you verify that it works?

I'll try to give it a shot, although I fear that I might not have the time
before my XU4 goes down for transportation. :-)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: [jspri...@debian.org: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB]

[Jochen Sprickerhof]

Hi guys,

forgot to add you to Cc, sorry.

Cheers Jochen

- Forwarded message from Jochen Sprickerhof  -

Date: Mon, 03 Jul 2017 16:31:01 +0200
To: Debian Bug Tracking System <843...@bugs.debian.org>
X-Mailer: reportbug 7.1.7
Reply-To: Jochen Sprickerhof , 843...@bugs.debian.org
From: Jochen Sprickerhof 
Subject: Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on 
Odroid-Xu4 with rootfs on USB

Package: src:linux
Followup-For: Bug #843448

Hi,

thanks to the pointers, I've condensed the first patch (74b9605e) to the
attached one against 4.9. Can you verify that it works?

I will try to port it to 4.11 and linux-next and post them.

The second patch (2166ffd00-updated.diff) looks good for me, would be great to
see it in mainline. Did someone send it to the maintainers already?

Cheers Jochen

>From a06c3727c1c19b2761b0aef267ce6338f0b2de7e Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof 
Date: Mon, 3 Jul 2017 15:59:25 +0200
Subject: [PATCH] usb: dwc3: core: setup phy before trying to read from it

dwc3_readl needs the device to be set up with dwc3_phy_setup.

Tested with Odroid XU4.

This is a regression from c499ff71ff2a281366c6ec7a904c547d806cbcd1.

Signed-off-by: Jochen Sprickerhof 
---
 drivers/usb/dwc3/core.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 33d3eb0c944a..69ad59753590 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -606,6 +606,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
u32 reg;
int ret;
 
+   ret = dwc3_phy_setup(dwc);
+   if (ret)
+   goto err0;
+
reg = dwc3_readl(dwc->regs, DWC3_GSNPSID);
/* This should read as U3 followed by revision number */
if ((reg & DWC3_GSNPSID_MASK) == 0x5533) {
@@ -643,10 +647,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
if (ret)
goto err0;
 
-   ret = dwc3_phy_setup(dwc);
-   if (ret)
-   goto err0;
-
reg = dwc3_readl(dwc->regs, DWC3_GCTL);
reg &= ~DWC3_GCTL_SCALEDOWN_MASK;
 
-- 
2.13.2



- End forwarded message -


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Jochen Sprickerhof]

Package: src:linux
Followup-For: Bug #843448

Hi,

thanks to the pointers, I've condensed the first patch (74b9605e) to the
attached one against 4.9. Can you verify that it works?

I will try to port it to 4.11 and linux-next and post them.

The second patch (2166ffd00-updated.diff) looks good for me, would be great to
see it in mainline. Did someone send it to the maintainers already?

Cheers Jochen
>From a06c3727c1c19b2761b0aef267ce6338f0b2de7e Mon Sep 17 00:00:00 2001
From: Jochen Sprickerhof 
Date: Mon, 3 Jul 2017 15:59:25 +0200
Subject: [PATCH] usb: dwc3: core: setup phy before trying to read from it

dwc3_readl needs the device to be set up with dwc3_phy_setup.

Tested with Odroid XU4.

This is a regression from c499ff71ff2a281366c6ec7a904c547d806cbcd1.

Signed-off-by: Jochen Sprickerhof 
---
 drivers/usb/dwc3/core.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 33d3eb0c944a..69ad59753590 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -606,6 +606,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
u32 reg;
int ret;
 
+   ret = dwc3_phy_setup(dwc);
+   if (ret)
+   goto err0;
+
reg = dwc3_readl(dwc->regs, DWC3_GSNPSID);
/* This should read as U3 followed by revision number */
if ((reg & DWC3_GSNPSID_MASK) == 0x5533) {
@@ -643,10 +647,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
if (ret)
goto err0;
 
-   ret = dwc3_phy_setup(dwc);
-   if (ret)
-   goto err0;
-
reg = dwc3_readl(dwc->regs, DWC3_GCTL);
reg &= ~DWC3_GCTL_SCALEDOWN_MASK;
 
-- 
2.13.2

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Sun, May 28, 2017 at 12:38:12AM +0800, gustavo panizzo wrote:
> NIC works right away, I have to cold boot to see the USB3 hard
> drives.
> The only kernel that worked reliably after reboot was 4.5.5-1

Have you tried to apply the other patch, too? It's supposedly helping with
this very problem. (I haven't tried the USB3 external ports, really.)

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[gustavo panizzo]

On Wed, May 24, 2017 at 12:37:38AM +0200, Steinar H. Gunderson wrote:

On Sun, May 14, 2017 at 04:08:56PM +0200, Steinar H. Gunderson wrote:

I've verified that this fails on my XU4 in both Debian 4.9 and 4.11,
as well as upstream 4.12-rc1 (haven't tried 4.10, probably doesn't work).
The discussion says this broke in 4.8. The bisect pointed to a patch, which
has a partial revert here:

  https://lkml.org/lkml/2016/10/16/63

They seem too hackish to go into upstream, though.


I checked out ODROID's own 4.9 tree, and it works fine (tested for a few
days). So I diffed drivers/usb/dwc3/, and these are the only two patches that
actually are missing that I can see:

 
https://github.com/hardkernel/linux/commit/74b9605e5587b30912d6b6093e9d7fb06d043c33


I've applied this patch and booted my XU4

NIC works right away, I have to cold boot to see the USB3 hard
drives.
The only kernel that worked reliably after reboot was 4.5.5-1 


My UX4 is a fileserver, it sees a lot of disk and nic activity, I'll
report if I face any problems with this kernel

[...]


networking on my XU4. I saw this at some point after boot, though:

 [  550.087389] xhci-hcd xhci-hcd.5.auto: Cannot set link state.
 [  550.087426] usb usb6-port1: cannot disable (err = -32)


I don't have those errors on my dmesg, at least yet


--
IRC: gfa
GPG: 0X44BB1BA79F6C6333



signature.asc
Description: Digital Signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Sat, May 27, 2017 at 08:57:00AM -0700, Vagrant Cascadian wrote:
> Of course, the BeagleBoard-X15 isn't using USB for anything, so this
> isn't much of a test, but it's the only other board I have available
> that uses dwc3.

I suppose you could plug a device into it, even if there's nothing onboard
connected to it? I don't know the board, but from pictures and specs, it
seems to have multiple USB 3.0 ports.

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-05-27, Vagrant Cascadian wrote:
> I've also got a BeagleBoard-X15 that works reasonably well without the
> patch; will test the patched kernel to see if it appears to cause any
> problems.

Of course, the BeagleBoard-X15 isn't using USB for anything, so this
isn't much of a test, but it's the only other board I have available
that uses dwc3.


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-05-27, Steinar H. Gunderson wrote:
> On Wed, May 24, 2017 at 11:37:36PM +0200, Steinar H. Gunderson wrote:
>> Well, it's a revert of something that's supposed to only be a
>> cleanup/refactor (but isn't, presumably due to phy bugs). So it _should_ be
>> safe, at least in theory.
>> 
>> FWIW, after a bit over two hours, this happened:
>> 
>>   [ 7912.391226] usb 4-1: new SuperSpeed USB device number 2 using xhci-hcd
>>   [ 7912.413744] usb 4-1: New USB device found, idVendor=05e3, idProduct=0616
>>   [ 7912.413752] usb 4-1: New USB device strings: Mfr=1, Product=2, 
>> SerialNumber=0
>>   [ 7912.413758] usb 4-1: Product: USB3.0 Hub
>>   [ 7912.413764] usb 4-1: Manufacturer: GenesysLogic
>>   [ 7912.417680] hub 4-1:1.0: USB hub found
>>   [ 7912.417989] hub 4-1:1.0: 2 ports detected
>
> 72 hours uptime now, with no more ill effects. NIC works fine.

The three odroid-xu4 reproducible builds nodes, with rootfs and a build
partition on USB, have mostly been working under load with ~2.5 days
uptime for 2/3 of the machines:

  
https://jenkins.debian.net/munin/debian.net/odxu4-armhf-rb.debian.net/index.html
  
https://jenkins.debian.net/munin/debian.net/odxu4b-armhf-rb.debian.net/index.html
  
https://jenkins.debian.net/munin/debian.net/odxu4c-armhf-rb.debian.net/index.html

I've also got a BeagleBoard-X15 that works reasonably well without the
patch; will test the patched kernel to see if it appears to cause any
problems.


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Wed, May 24, 2017 at 11:37:36PM +0200, Steinar H. Gunderson wrote:
> Well, it's a revert of something that's supposed to only be a
> cleanup/refactor (but isn't, presumably due to phy bugs). So it _should_ be
> safe, at least in theory.
> 
> FWIW, after a bit over two hours, this happened:
> 
>   [ 7912.391226] usb 4-1: new SuperSpeed USB device number 2 using xhci-hcd
>   [ 7912.413744] usb 4-1: New USB device found, idVendor=05e3, idProduct=0616
>   [ 7912.413752] usb 4-1: New USB device strings: Mfr=1, Product=2, 
> SerialNumber=0
>   [ 7912.413758] usb 4-1: Product: USB3.0 Hub
>   [ 7912.413764] usb 4-1: Manufacturer: GenesysLogic
>   [ 7912.417680] hub 4-1:1.0: USB hub found
>   [ 7912.417989] hub 4-1:1.0: 2 ports detected

72 hours uptime now, with no more ill effects. NIC works fine.

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Wed, May 24, 2017 at 02:15:46PM -0700, Vagrant Cascadian wrote:
>> In any case, it essentially takes the system from “totally broken” to “might
>> have some problems”. Would you consider taking it in for stretch, so that the
>> XU4 has networking? I'll keep running with this kernel to get more
>> experience.
> Unfortunately, there are numerous other boards using dwc3, so I'm not
> sure this is a good idea...

Well, it's a revert of something that's supposed to only be a
cleanup/refactor (but isn't, presumably due to phy bugs). So it _should_ be
safe, at least in theory.

FWIW, after a bit over two hours, this happened:

  [ 7912.391226] usb 4-1: new SuperSpeed USB device number 2 using xhci-hcd
  [ 7912.413744] usb 4-1: New USB device found, idVendor=05e3, idProduct=0616
  [ 7912.413752] usb 4-1: New USB device strings: Mfr=1, Product=2, 
SerialNumber=0
  [ 7912.413758] usb 4-1: Product: USB3.0 Hub
  [ 7912.413764] usb 4-1: Manufacturer: GenesysLogic
  [ 7912.417680] hub 4-1:1.0: USB hub found
  [ 7912.417989] hub 4-1:1.0: 2 ports detected

This might be the issue of warm USB3 boot the other patch talked about?
(I don't have any devices connected to the external ports, so I don't really
know whether they work. I just want the NIC :-) )

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-05-23, Steinar H. Gunderson wrote:
>   
> https://github.com/hardkernel/linux/commit/74b9605e5587b30912d6b6093e9d7fb06d043c33
...
> I've applied the former patch (the revert) on top of Debian's 4.9.25 kernel
> (linux-image-4.9.0-3-armmp-lpae), and it boots with working USB and thus
> networking on my XU4. I saw this at some point after boot, though:
>
>   [  550.087389] xhci-hcd xhci-hcd.5.auto: Cannot set link state.
>   [  550.087426] usb usb6-port1: cannot disable (err = -32)

I've also applied the patch and was able to boot an odroid-xu4 with
it. I've got three of them used for the reproducible builds farm that
have been stuck on the 4.7.x kernel, so many thanks for identifying a
workaround! Will start using 4.9.x with this patch...


> In any case, it essentially takes the system from “totally broken” to “might
> have some problems”. Would you consider taking it in for stretch, so that the
> XU4 has networking? I'll keep running with this kernel to get more
> experience.

Unfortunately, there are numerous other boards using dwc3, so I'm not
sure this is a good idea...


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Sun, May 14, 2017 at 04:08:56PM +0200, Steinar H. Gunderson wrote:
> I've verified that this fails on my XU4 in both Debian 4.9 and 4.11,
> as well as upstream 4.12-rc1 (haven't tried 4.10, probably doesn't work).
> The discussion says this broke in 4.8. The bisect pointed to a patch, which
> has a partial revert here:
> 
>   https://lkml.org/lkml/2016/10/16/63
> 
> They seem too hackish to go into upstream, though.

I checked out ODROID's own 4.9 tree, and it works fine (tested for a few
days). So I diffed drivers/usb/dwc3/, and these are the only two patches that
actually are missing that I can see:

  
https://github.com/hardkernel/linux/commit/74b9605e5587b30912d6b6093e9d7fb06d043c33
  
https://github.com/hardkernel/linux/commit/2166ffd004e04a61887eb2a39f8639dc12140c58

The second doesn't apply cleanly, and I don't understand the commit message
anyway (does it only matter if dwc3 is _not_ built as a module?), but the
former seems safe enough to apply. Given that it's been in their tree since
2016, it also would seem to have received a fair amount of user testing.

I've applied the former patch (the revert) on top of Debian's 4.9.25 kernel
(linux-image-4.9.0-3-armmp-lpae), and it boots with working USB and thus
networking on my XU4. I saw this at some point after boot, though:

  [  550.087389] xhci-hcd xhci-hcd.5.auto: Cannot set link state.
  [  550.087426] usb usb6-port1: cannot disable (err = -32)

In any case, it essentially takes the system from “totally broken” to “might
have some problems”. Would you consider taking it in for stretch, so that the
XU4 has networking? I'll keep running with this kernel to get more
experience.

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Steinar H. Gunderson]

On Sun, Nov 13, 2016 at 04:21:30AM +, Ben Hutchings wrote:
> This message (from the core hub driver) looks important:
> 
> 2016-11-06_17:33:29.19077 [7.510995] usb usb3-port1: connect-debounce 
> failed
> 
> The device tree source for Exynos 5422 was changed between 4.7 and 4.8
> so some of the USB definitions could be shared with the 5410 (commit
> cb0896562228703209644e92926ed445150cc594).  This obviously shouldn't
> have a functional difference to the 5422 but maybe it did?

There was some discussion upstream, but with no definitive conclusion:

  https://lkml.org/lkml/2016/8/28/183

I've verified that this fails on my XU4 in both Debian 4.9 and 4.11,
as well as upstream 4.12-rc1 (haven't tried 4.10, probably doesn't work).
The discussion says this broke in 4.8. The bisect pointed to a patch, which
has a partial revert here:

  https://lkml.org/lkml/2016/10/16/63

They seem too hackish to go into upstream, though.

This bug unfortunately makes the XU4 pretty useless, since the NIC is hooked
up over USB. 4.7 works, but has no security support anymore (final release
was 4.7.10, in October 2016).

/* Steinar */
-- 
Homepage: https://www.sesse.net/

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2017-04-22, Vagrant Cascadian wrote:
> On 2016-11-12, Ben Hutchings wrote:
>> On Sun, 2016-11-06 at 10:00 -0800, Vagrant Cascadian wrote:
>>> When upgrading to linux 4.8.x on an Odroid-XU4 system, it no longer
>>> detects the USB sata adapter where rootfs is located.
>>> 
>>> Downgrading to the 4.7.x kernel from jessie-backports works fine.
> ...
>> This message (from the core hub driver) looks important:
>>
>> 2016-11-06_17:33:29.19077 [7.510995] usb usb3-port1: connect-debounce 
>> failed
...
> Will try with stretch's d-i next...

With stretch's d-i, I don't see the debounce messages, but USB fails to
work, and ethernet is implemented over USB, so this fails on the d-i
netboot image.

Attached is the full dmesg output from within d-i.

~ # uname -a
Linux (none) 4.9.0-2-armmp #1 SMP Debian 4.9.18-1 (2017-03-30) armv7l
GNU/Linux
~ #
~ # lsmod
Module  Size  Used by
dwc3_exynos 3827  0
ohci_exynos 4178  0
ohci_hcd   37898  1 ohci_exynos
ehci_exynos 4269  0
ehci_hcd   64996  1 ehci_exynos
dw_mmc_exynos   5942  0
usbcore   195888  4
ehci_exynos,ehci_hcd,ohci_hcd,ohci_exynos
dw_mmc_pltfm2485  1 dw_mmc_exynos
dw_mmc 25740  2 dw_mmc_pltfm,dw_mmc_exynos
phy_exynos_usb2 9238  2
phy_exynos5_usbdrd  7053  0
usb_common  3659  1 usbcore


live well,
  vagrant



odxu4c.log
Description: Binary data


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

On 2016-11-12, Ben Hutchings wrote:
> On Sun, 2016-11-06 at 10:00 -0800, Vagrant Cascadian wrote:
>> When upgrading to linux 4.8.x on an Odroid-XU4 system, it no longer
>> detects the USB sata adapter where rootfs is located.
>> 
>> Downgrading to the 4.7.x kernel from jessie-backports works fine.
...
> This message (from the core hub driver) looks important:
>
> 2016-11-06_17:33:29.19077 [7.510995] usb usb3-port1: connect-debounce 
> failed
>
> The device tree source for Exynos 5422 was changed between 4.7 and 4.8
> so some of the USB definitions could be shared with the 5410 (commit
> cb0896562228703209644e92926ed445150cc594).  This obviously shouldn't
> have a functional difference to the 5422 but maybe it did?

I tried booting 4.9 from jessie-backports just now using the dts from
4.7, and it had the same behavior. So I'm guessing that's not the issue.

I also tried with an initramfs that had all of the available driver
modules included, with no luck.

Will try with stretch's d-i next...


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Ben Hutchings]

On Sun, 2016-11-06 at 10:00 -0800, Vagrant Cascadian wrote:
> Package: src:linux
> Version: 4.8.5-1
> Severity: important
> 
> When upgrading to linux 4.8.x on an Odroid-XU4 system, it no longer
> detects the USB sata adapter where rootfs is located.
> 
> Downgrading to the 4.7.x kernel from jessie-backports works fine.
> 
> I didn't see anything obviously missing when diffing /boot/config-*.
> 
> Boot log attached.
> 
> If there's nothing obvious fromt the boot log, I can try taking it
> offline and doing an install with stretch or sid to do more
> debugging.

This message (from the core hub driver) looks important:

2016-11-06_17:33:29.19077 [7.510995] usb usb3-port1: connect-debounce failed

The device tree source for Exynos 5422 was changed between 4.7 and 4.8
so some of the USB definitions could be shared with the 5410 (commit
cb0896562228703209644e92926ed445150cc594).  This obviously shouldn't
have a functional difference to the 5422 but maybe it did?

Ben.

-- 
Ben Hutchings
Nothing is ever a complete failure; it can always serve as a bad
example.


signature.asc
Description: This is a digitally signed message part

Bug#843448: linux-image-4.8.0-1-armmp-lpae: fails to boot on Odroid-Xu4 with rootfs on USB

[Vagrant Cascadian]

Package: src:linux
Version: 4.8.5-1
Severity: important

When upgrading to linux 4.8.x on an Odroid-XU4 system, it no longer
detects the USB sata adapter where rootfs is located.

Downgrading to the 4.7.x kernel from jessie-backports works fine.

I didn't see anything obviously missing when diffing /boot/config-*.

Boot log attached.

If there's nothing obvious fromt the boot log, I can try taking it
offline and doing an install with stretch or sid to do more debugging.


live well,
  vagrant

-- Package-specific info:
** Model information
Hardware: SAMSUNG EXYNOS (Flattened Device Tree)
Revision: 
Device Tree model: Hardkernel Odroid XU4

** PCI devices:

** USB devices:
Bus 006 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 005 Device 003: ID 0bda:8153 Realtek Semiconductor Corp. 
Bus 005 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 002: ID 05e3:0616 Genesys Logic, Inc. 
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 003: ID 174c:55aa ASMedia Technology Inc. ASMedia 2105 SATA 
bridge
Bus 003 Device 002: ID 05e3:0610 Genesys Logic, Inc. 4-port hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub


-- System Information:
Debian Release: 8.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (1, 'experimental'), 
(1, 'unstable')
Architecture: armhf (armv7l)

Kernel: Linux 4.7.0-0.bpo.1-armmp-lpae (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages linux-image-4.8.0-1-armmp-lpae depends on:
ii  initramfs-tools [linux-initramfs-tool]  0.120+deb8u2
ii  kmod18-3
ii  linux-base  4.3~bpo8+1

Versions of packages linux-image-4.8.0-1-armmp-lpae recommends:
ii  firmware-linux-free  3.3
ii  irqbalance   1.0.6-3

Versions of packages linux-image-4.8.0-1-armmp-lpae suggests:
pn  debian-kernel-handbook  
pn  linux-doc-4.8   

Versions of packages linux-image-4.8.0-1-armmp-lpae is related to:
pn  firmware-amd-graphics 
pn  firmware-atheros  
pn  firmware-bnx2 
pn  firmware-bnx2x
pn  firmware-brcm80211
pn  firmware-cavium   
pn  firmware-intel-sound  
pn  firmware-intelwimax   
pn  firmware-ipw2x00  
pn  firmware-ivtv 
pn  firmware-iwlwifi  
pn  firmware-libertas 
pn  firmware-linux-nonfree
pn  firmware-misc-nonfree 
pn  firmware-myricom  
pn  firmware-netxen   
pn  firmware-qlogic   
pn  firmware-realtek  
pn  firmware-samsung  
pn  firmware-siano
pn  firmware-ti-connectivity  
pn  xen-hypervisor

-- no debconf information



odxu4c.log
Description: Binary data


signature.asc
Description: PGP signature