Lintian adaptation to Ubuntu
Good afternoon,
I am trying to adapt lintian to Ubuntu specific requirements. The only
modification I made is disabling NMU checks by default. I added -D and
--debian command-line switches to enable them again (debdiff attached).
I have been advised by an Ubuntu developper to make sure that these
changes will not collide with future lintian developments. If you have
any recommandations about these modifications I would be glad to follow
them.
This particular issue is tracked on Launchpad bug #36505 [1].
Regards,
--
Jérémie Corbier
[1] https://launchpad.net/distros/ubuntu/+source/lintian/+bug/36505
diff -Nru /tmp/KEnp6CGcQz/lintian-1.23.14ubuntu1/debian/changelog
/tmp/KXh4vD1xp6/lintian-1.23.14ubuntu2/debian/changelog
--- /tmp/KEnp6CGcQz/lintian-1.23.14ubuntu1/debian/changelog 2005-12-28
11:51:36.0 +0100
+++ /tmp/KXh4vD1xp6/lintian-1.23.14ubuntu2/debian/changelog 2006-03-25
01:12:00.0 +0100
@@ -1,3 +1,10 @@
+lintian (1.23.14ubuntu2) dapper; urgency=low
+
+ * Add a patch to disable NMU checks for Ubuntu. It can be enabled again
+using -D or --debian switches on the commandline.
+
+ -- Jeremie Corbier [EMAIL PROTECTED] Sat, 25 Mar 2006 01:08:54 +0100
+
lintian (1.23.14ubuntu1) dapper; urgency=low
* Resynchronise with Debian.
diff -Nru /tmp/KEnp6CGcQz/lintian-1.23.14ubuntu1/frontend/lintian
/tmp/KXh4vD1xp6/lintian-1.23.14ubuntu2/frontend/lintian
--- /tmp/KEnp6CGcQz/lintian-1.23.14ubuntu1/frontend/lintian 2005-12-19
13:49:12.0 +0100
+++ /tmp/KXh4vD1xp6/lintian-1.23.14ubuntu2/frontend/lintian 2006-03-25
01:08:10.0 +0100
@@ -36,6 +36,9 @@
#increased whenever incompatible
#changes are done to the lab
#so that all packages are re-unpacked
+# Debian specific checks which should be avoided if -D or --debian is not set
+# via the commandline. Format is (check1|check2|check3).
+my $deb_specific_checks = 'nmu';
# Variables used to record commandline options
# Commented out variables have defined checks somewhere to determine if
@@ -47,6 +50,7 @@
our $debug = 0;#flag for -d|--debug switch
my @debug;
my $check_everything = 0; #flag for -a|--all switch
+my $debian_behaviour = 0; #flag for -D|--debian switch
my $lintian_info = 0; #flag for -i|--info switch
our $display_infotags = 0; #flag for -I|--display-info switch
my $unpack_level = undef; #flag for -l|--unpack-level switch
@@ -137,6 +141,7 @@
-d, --debug turn Lintian\'s debug messages ON
--print-version print unadorned version number and exit
Behaviour options:
+-D, --debian turn Lintian\'s Debian specific checks on
-i, --infogive detailed info about tags
-I, --display-infodisplay I: tags (normally suppressed)
-l X, --unpack-level Xset default unpack level to X
@@ -252,6 +257,7 @@
debug|d = [EMAIL PROTECTED], # Count the -d flags
# -- behaviour options
+ debian|D = \$debian_behaviour,
info|i = \$lintian_info,
display-info|I = \$display_infotags,
unpack-level|l=i = \$unpack_level,
@@ -903,6 +909,7 @@
or fail(cannot read directory $LINTIAN_ROOT/checks);
for my $f (readdir CHECKDIR) {
+next if ($f =~ /^$deb_specific_checks\.desc$/ and !$debian_behaviour);
next unless $f =~ /\.desc$/;
print N: Reading checker description file $f ...\n if $debug = 2;
signature.asc
Description: OpenPGP digital signature
Re: Lintian adaptation to Ubuntu
Jeroen van Wolffelaar a écrit : On Sat, Mar 25, 2006 at 05:20:07PM +0100, Jeremie Corbier wrote: Good afternoon, I am trying to adapt lintian to Ubuntu specific requirements. The only modification I made is disabling NMU checks by default. I added -D and --debian command-line switches to enable them again (debdiff attached). You might want to replace the list of distribution targets for Ubuntu too then, and revert that behaviour when --debian is invoked: #350114 Ah yes, I knew I had forgotten something. Ubuntu targets handling is already included in a previous package release but I'll modify it so that it changes of behaviour when --debian is specified. I have been advised by an Ubuntu developper to make sure that these changes will not collide with future lintian developments. If you have any recommandations about these modifications I would be glad to follow them. I don't see a problem with --debian at least, -D is of course abit short, but I have no strong opinion here. In any case, I've just added a note in the source with the option processing, and we might decide to add this option (as a no-op in Debian) so that lintian --debian allways gives the same behaviour, on Ubuntu and on Debian and hopefully any other derivate. Other lintian devs opinions? About -D, and about even maybe even adding it as no-op option? I appreciate your quick answer and I am looking forward the other maintainers' opinions. Thank you in advance. This particular issue is tracked on Launchpad bug #36505 [1]. How can I cc messages to that bug? You can CC [EMAIL PROTECTED] Regards, -- Jérémie Corbier signature.asc Description: OpenPGP digital signature
Re: Lintian release soon?
On Thu, Mar 16, 2006 at 05:05:30AM +0100, Jeroen van Wolffelaar wrote: So, please stresstest current svn a bit, and in case there's no serious problems found, we should upload the package. We can't fix all bugs at once after all. I heard no comments, and the testset still works etc. I plan to release tonight or tomorrow or so, unless someone yells and wants some more testing/finds showstopper bugs. --Jeroen -- Jeroen van Wolffelaar [EMAIL PROTECTED] (also for Jabber MSN; ICQ: 33944357) http://Jeroen.A-Eskwadraat.nl -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r587
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r587 by jeroen tag 358523 + pending Bug#358523: please add check for broken invoke-rc.d calls caused by debhelper bug There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Lintian release soon?
Jeroen van Wolffelaar [EMAIL PROTECTED] writes: On Thu, Mar 16, 2006 at 05:05:30AM +0100, Jeroen van Wolffelaar wrote: So, please stresstest current svn a bit, and in case there's no serious problems found, we should upload the package. We can't fix all bugs at once after all. I heard no comments, and the testset still works etc. I plan to release tonight or tomorrow or so, unless someone yells and wants some more testing/finds showstopper bugs. Certainly works for me. I've been holding off from doing anything to make sure we stabilize for a release. :) -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: load custom checks from ~/.lintian/checks?
Michael Ablassmeier [EMAIL PROTECTED] writes: i just wondered how am i supposed to add my own checks to lintian. It seems the only way to do this (without beeing root) is to copy the stuff from /usr/share/lintian to $HOME and use the --root switch to change $LINTIAN_ROOT. I think it would be very nice if lintian could check ~/.lintian/checks for checks and load them, just like linda does. Attached is a (i guess pretty hackish patch) against trunk which does this. This seems like at least an idea worth considering. Could you submitt his and your patch as a wishlist bug report? I don't know about the other lintian developers, but I try really hard not to keep things sitting around in my inbox because then they nag at me and feel like clutter. If you put the patch into the BTS, it will be there each time I review current bugs to find something to work on. Thanks! -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: load custom checks from ~/.lintian/checks?
On Sat, Mar 25, 2006 at 11:53:53AM -0800, Russ Allbery wrote: Michael Ablassmeier [EMAIL PROTECTED] writes: i just wondered how am i supposed to add my own checks to lintian. It seems the only way to do this (without beeing root) is to copy the stuff from /usr/share/lintian to $HOME and use the --root switch to change $LINTIAN_ROOT. I think it would be very nice if lintian could check ~/.lintian/checks for checks and load them, just like linda does. Attached is a (i guess pretty hackish patch) against trunk which does this. This seems like at least an idea worth considering. Could you submitt his and your patch as a wishlist bug report? I don't know about the other lintian developers, Well, I agree such request are best filed as bugs immediately, for the same reasons you (Russ) cite, but I can already say that personally, I'm not really terribly fond of this idea. Lintian should IMHO really be a tool that has a reliable output, and that can be used as a base for structural QA work etc. An important requisite for this is that lintian output should be constant regardless of your environment. There is --root for development on lintian, testing out/using locally certain patches (including simply added checks). ~/.lintian/checks might be neat, but only addresses a small subset, because it can only add checks, and then only checks that don't need any sort of collector changes. --root actually allows any kind of adoption, and is very easy too (just a cp -a or even cp -sa and adding/modifying whatever pleases you). --Jeroen -- Jeroen van Wolffelaar [EMAIL PROTECTED] (also for Jabber MSN; ICQ: 33944357) http://Jeroen.A-Eskwadraat.nl -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: load custom checks from ~/.lintian/checks?
Jeroen van Wolffelaar [EMAIL PROTECTED] writes: Well, I agree such request are best filed as bugs immediately, for the same reasons you (Russ) cite, but I can already say that personally, I'm not really terribly fond of this idea. Lintian should IMHO really be a tool that has a reliable output, and that can be used as a base for structural QA work etc. An important requisite for this is that lintian output should be constant regardless of your environment. There is --root for development on lintian, testing out/using locally certain patches (including simply added checks). ~/.lintian/checks might be neat, but only addresses a small subset, because it can only add checks, and then only checks that don't need any sort of collector changes. --root actually allows any kind of adoption, and is very easy too (just a cp -a or even cp -sa and adding/modifying whatever pleases you). Hm, yes, those are both really good points. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
